Activity
From 07/02/2015 to 07/08/2015
07/08/2015
-
05:39 PM Bug #11152 (Feedback): Resolv::DNS should use Search Domains provided in /etc/resolv.conf by default
- Hi,
It should parse your `/etc/resolv.conf` file. Can you post your `/etc/resolv.conf`? Maybe it's a problem with the parser. -
04:08 PM Feature #10594: Comparable#clamp
- > I think there is even another option: Swapping the min and max values if they are passed in the wrong order.
I suspect there is little to no precedent for allowing "position-independent positional arguments". It's true that they cou... -
01:00 PM Feature #10594: Comparable#clamp
- I think there is even another option: Swapping the min and max values if they are passed in the wrong order.
This is obviously a question of the principle of least surprise. If you compare `#clamp` to `#between?`, it makes sense to ac... -
11:35 AM Revision 39051ba1 (git): leakchecker.rb: close console
- * test/lib/leakchecker.rb (LeakChecker#find_fds): close console
before find open FDs for each time.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51195 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:21 AM Bug #11316: ruby 2.2 on Windows generates incorrect BAT files for gems
- Update: just tested with rubygems 2.4.8 and it generates BAT files correctly. I hope this version is planned for inclusion into Windows builds of ruby.
-
- Hi and sorry for delay. My gem version is 2.4.5:
~~~
C:\Windows\system32>gem --version
2.4.5
C:\Windows\system32>where gem
C:\Program Files\ruby22\bin\gem
C:\Program Files\ruby22\bin\gem.bat
C:\Windows\system32>rhc --help
'... -
11:03 AM Bug #11336: TestProcess#test_exec_fd_3_redirect failed on Solaris 10
- > Also, maybe the __APPLE__ || __HAIKU__ code above is suitable for all
OS, too.
I think so, and the following patch solves the failure ofTestProcess#test_exec_fd_3_redirect on Solaris 10.
~~~
Index: process.c
==================... -
02:58 AM Bug #11336: TestProcess#test_exec_fd_3_redirect failed on Solaris 10
- [email protected] wrote:
> ~~~
> $ ruby -e 'a = IO.pipe; b = IO.pipe; p a; p b; pid = fork { exec("ruby", "-e", "print IO.for_fd(3).read(1)", 3=>a[0],1=>b[1]) }; b[1].close; a[0].close; a[1].write("."); p b[0].read(1); Process.wai... -
- Sometimes ASYNC BUG occurs, but it cannot be reproduced with truss.
~~~
$ ruby -e 'a = IO.pipe; b = IO.pipe; p a; p b; pid = fork { exec("ruby", "-e", "print IO.for_fd(3).read(1)", 3=>a[0],1=>b[1]) }; b[1].close; a[0].close; a[1].wri... -
- * lib/rubygems/resolver.rb (resolve): close UI output unless
debugging.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51194 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/socket/basicsocket.c (bsock_do_not_reverse_lookup),
(bsock_do_not_reverse_lookup_set): [DOC] swap examples. the code
setting the flag is for the setter.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51193 b2dd03c8-39d4-4d8... -
- * ext/socket/socket.c (socket_s_ip_address_list): pass saved errno
to rb_syserr_fail.
* ext/readline/readline.c (readline_getc, readline_s_set_input),
(readline_s_set_output): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... -
01:59 AM Bug #11327: Improve duplicate key warning.
- Agreed.
Matz
07/07/2015
-
10:43 PM Revision 601c10e6 (git): * lib/csv.rb: typo fix [ci skip][fix GH-958] Patch by @henrik
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51191 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Can you try a higher fd number instead of 3?
Also, truss output would be useful.
Thanks. -
- >Was there any output in stderr from this test?
nothing
Recently, the failure message is changed to below.
It seems the SIGKILL is caused by timeout of the test.
~~~
TestProcess#test_exec_fd_3_redirect [/XXXXX-51186/test/ruby/... -
- Was there any output in stderr from this test? Thanks.
-
- On Solaris 10, TestProcess#test_exec_fd_3_redirect failed since r51146 (where the test was added).
~~~
1) Failure:
TestProcess#test_exec_fd_3_redirect [/XXXXX-51146/test/ruby/test_process.rb:2049]:
<"."> expected but was
<nil>.
... -
- ~~~
rb_scan_args and hash lookups for kwargs in the C API are clumsy and
slow. Instead of improving the C API for performance, use Ruby
instead :)
Implement IO#read_nonblock and IO#write_nonblock in prelude.rb
to avoid argument p... -
07:51 PM
Bug #11338 (Closed): [PATCH] iseq.c (iseq_data_to_ary): dump kw_arg as symbol
- Applied in changeset r51190.
----------
iseq.c (iseq_data_to_ary): dump kw_arg as symbol
Fix RubyVM::InstructionSequence#to_a after r49517
Keywords were made symbols to fix [Bug #10831] [ruby-core:68031],
so we should dump symbols as-i... -
- iseq.c (iseq_data_to_ary): dump kw_arg as symbol
Fix RubyVM::InstructionSequence#to_a after r49517
Keywords were made symbols to fix [Bug #10831] [ruby-core:68031],
so we should dump symbols as-is instead of attempting to convert
t... - 07:50 PM Revision 011347e4 (git): iseq.c (iseq_data_to_ary): dump kw_arg as symbol
- Fix RubyVM::InstructionSequence#to_a after r49517
Keywords were made symbols to fix [Bug #10831] [ruby-core:68031],
so we should dump symbols as-is instead of attempting to convert
them from IDs
* iseq.c (iseq_data_to_ary): dump kw_arg ... -
06:29 PM Bug #11327: Improve duplicate key warning.
- If matz will approve, and no objection, I will commit it.
-
- In the case of `min > max`, the options seem to be these:
* return `nil`
* return the receiver
* raise an `ArgumentError`
Given that the first two are likely to cause something else to explode down the line, it seems best to just... - 03:57 PM Revision fe94eaa5 (git): * test/ruby/test_method.rb (TestMethod#test_{instance,define}_method): assumed
- default external is UTF-8. fixed failures introduced at r51175.
* test/-ext-/symbol/test_type.rb
(Test_Symbol::TestType#test_check_{id,symbol}_invalid_type): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51189 b2dd03c8-3... - 03:42 PM Revision 3294c272 (git): * 2015-07-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51188 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:41 PM Revision d4397258 (git): * test/ruby/test_array.rb
- (TestArray#test_short_heap_array_sort_bang_memory_leak): seems to need more
margin.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51187 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:38 PM Feature #11337 (Closed): Allow rescue without begin inside blocks
- While it's possible to have rescue's without begin in method definitions it's not possible to have the same facility inside blocks. For example, this is currently not possible:
~~~
1.times do
abc
rescue
p 'error'
end
~~~
... -
09:21 AM Revision 4f66d02c (git): * random.c (fill_random_bytes_syscall): fix compile error.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51186 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51185 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:48 AM Revision 2fb7e7df (git): compile.c (COMPILE_ERROR): reduce GET_THREAD() calls
- Shorten a long line and reduce global variable access, giving
a minor code size reduction (at least on 32-bit x86):
text data bss dec hex filename
96807 772 48 97627 17d5b compile.orig
96775 772 ... - 07:46 AM Revision 50c0a200 (git): random.c: fix failures on old Linux
- This follows the behavior of fill_random_bytes_urandom and fixes
the following failures I encountered on my old machine:
1) Error:
TestSecureRandom#test_s_random_bytes_without_openssl:
NotImplementedError: No random device
$RUBYDIR/... -
- * random.c (fill_random_bytes_syscall): try getrandom system call
on Linux if supported by the kernel.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51182 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * random.c (fill_random_bytes): separate into functions by system
call and by direct read of urandom device.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51181 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * file.c (rb_str_normalize_ospath): skip invalid byte sequence not
to loop infinitely. this case usually does not happen as the
input name should come from real file systems.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51180 ... -
05:41 AM Revision 548497d5 (git): * vm_backtrace.c: remove debug flag introduced accidentaly.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51179 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:40 AM Bug #11221: Fix indentation in Zlib documentation
- ruby_2_1 r51178 merged revision(s) 50834.
- 04:40 AM Revision c7458b51 (git): merge revision(s) 50834: [Backport #11221]
- * ext/zlib/zlib.c: Fix indentation for rdoc.
[Bug #11221][ruby-core:69465]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@51178 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_1 r51177 merged revision(s) 50860.
- 04:37 AM Revision a0cf0fbd (git): merge revision(s) 50860: [Backport #11249]
- * ext/bigdecimal/bigdecimal.gemspec: Fix require paths for released gem.
[fix GH-929] Patch by @voxik
* ext/io/console/io-console.gemspec: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@51177 b2... - 04:24 AM Revision e25bb03e (git): merge revision(s) 50972:
- test_gem_remote_fetcher.rb: get rid of errors
* test/rubygems/test_gem_remote_fetcher.rb (start_ssl_server):
temporary measure for "dh key too small" error of OpenSSL
1.0.2c+.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/bra... -
- * symbol.c (rb_check_id, rb_check_symbol): preserve encoding of
the given name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51175 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- introduced at r19890, maybe accidentaly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51174 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- do not check data->me
* proc.c (method_inspect): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- no longer exists.
* iseq.c: don't use rb_iseq_t::orig.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51172 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- clone iseq any more.
* class.c (clone_method): share iseq between cloned methods. All of
method dependent information are able to refer from method entry.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51171 b2dd03c8-39d4-4d8f-98...
07/06/2015
- 07:45 PM Revision bbf7495f (git): string.c: ensure String#freeze resizes internal buffer
- rb_str_freeze may resize oversized buffers to save memory, so favor
it over rb_obj_freeze. This is useful because IO methods do not
prematurely shrink buffers, as they are likely to be overwritten
with full data.
* string.c (Init_Strin... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51169 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- needed.
* eval.c (frame_func_id): simplify. rb_callable_method_entry_t
has enough information.
* eval.c (frame_called_id): ditto.
* iseq.c (prepare_iseq_build): catch up this fix.
* proc.c (rb_mod_define_method): ditto.
* vm.c (vm_defi... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51167 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * internal.h, iseq.c (rb_iseq_klass): remove it because
rb_iseq_t::klass is removed.
* vm_insnhelper.c (vm_super_outside): do not see cfp->iseq, but
check callable method entry on a frame.
This fix simplify the logic to search supe... -
- This fix does not affect any ordinal execution, but
affects debug prints.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51165 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:49 PM Revision bba7c4b0 (git): * 2015-07-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51164 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:49 PM Revision 73c0f4f7 (git): * test/ruby/test_array.rb
- (TestArray#test_short_heap_array_sort_bang_memory_leak): relax the threshold
to get rid of a false positive failure of mswin CI.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51163 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I tried the basic implementation (adaption of `#between?`). What should we do about cases like these?
```
irb(main):001:0> 1.clamp(2, 1)
=> 2
irb(main):002:0> 2.clamp(2, 1)
=> 1
```
With `#between?` these make more sense, becaus... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51162 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r51161.
----------
* vm_insnhelper.c (vm_search_super_method): do not skip calling
same methods in super.
[Bug #3351]
* test/ruby/test_super.rb: fix a test. -
- Agreed.
Matz.
-
- same methods in super.
[Bug #3351]
* test/ruby/test_super.rb: fix a test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51161 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51160 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- and remoev prefix `rb_' because it is used only in proc.c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51159 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51158 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- and imported to trunk at r49511.
-
- Fixed at https://github.com/rubygems/rubygems/commit/f9232680
-
- * string.c (register_fstring): separate registration from
rb_fstring().
* string.c (rb_fstring_new): skip argument checks in rb_fstring().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51157 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/05/2015
-
- * test/rubygems/test_gem_commands_install_command.rb: previously
load rubygems/request_set which will be required in
rubygems/commands/install_command.rb to get rid of loading
multiple times.
git-svn-id: svn+ssh://ci.ruby-lang.org... - 08:55 PM Revision 77eea6f9 (git): test/ruby/test_array.rb: longer timeout for memory leak test
- This was causing CI failures on ko1's test box
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51155 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:18 PM Revision 1f3971e0 (git): * 2015-07-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51154 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/lib/test/unit/parallel.rb: make @@project_dir one level
upper as this file had moved one level deeper.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/optparse.rb: [DOC] Fix typo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51152 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:27 AM Bug #11335 (Closed): `ruby -r debug` catchpoint problem
- With a `test-debug.rb` like this:
~~~
raise 'test'
~~~
And starting the debugger like this:
~~~
ruby -r debug test-debug.rb
~~~
By default, the catchpoint is `StandardError`, but it doesn't work:
~~~
test-debug.rb:1:r... - 09:28 AM Revision 4f1178ac (git): gc.c (gc_profile_record_get): fix spelling error in keys
- This may cause compatibility problems for some users, but maybe
nobody tracked it closely in the past because it is disabled by
default.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51151 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:05 AM Bug #11316: ruby 2.2 on Windows generates incorrect BAT files for gems
- No issue with a fresh ruby-2.2.2-p95-x86-mingw either.
Deka, what do you get for "gem --version" ? Check which gem exe is getting picked up in your path with "where gem" as well. -
- It's generated by rubygems, not ruby's installer.
-
- I tested this against ruby 2.2.2p95 x64-mingw without issue.
rhc.bat appears to be correct.
~~~
@ECHO OFF
IF NOT "%~f0" == "~f0" GOTO :WinNT
@"c:\Ruby22-x64\bin\ruby.exe" "c:/Ruby22-x64/bin/rhc" %1 %2 %3 %4 %5 %6 %7 %8 %9
GOTO ... -
05:58 AM Bug #11037: Time Parse Documentation Incorrect - Undefined method getlocal
- Hi,
I think it is useful Time.parse specifications on the document.
This patch is fix operation to along specifications. -
05:54 AM Revision cd56fbdf (git): * README.md: fix a typo pointed out by raoulvdberge. [ci skip] [DOC]
- https://github.com/ruby/ruby/pull/953#commitcomment-11998186
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * README.md: Added link HowToReport bugs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51149 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:03 AM Bug #11332: Arrayの操作でcrubyインタプリタのメモリリークが起きる
- rev.51148 で実行して直っていることを確認しました
-
- Applied in changeset r51147.
----------
array.c: fix memory leak
* array.c (rb_ary_sort_bang): the original array may not be
embedded even if a substitution array is embedded, as it is
embedded when the original array is short enou... -
- `pop`だけで起きるのはOSXのlibc固有のようでした。
Linuxではたしかに4要素から3要素に減らしたあとでsort!した場合だけのようです。 -
- * test/ruby/test_process.rb (test_exec_fd_3_redirect): should reap
the grandchild process, in common.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51148 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * array.c (rb_ary_sort_bang): the original array may not be
embedded even if a substitution array is embedded, as it is
embedded when the original array is short enough but not
embedded. [ruby-dev:49166] [Bug #11332]
git-svn-id: ... - 12:40 AM Revision 033e8e5b (git): test/ruby/test_process.rb: test for fd=3 usability in child
- Ensure we can redirect anything to fd=3 in a child process. This
test exists because fd=3 is a commonly reserved FD for a timer
thread pipe in the parent Ruby VM, but fd=3 is the first FD used by
the sd_listen_fds function for systemd.
...
07/04/2015
-
- `Array#pop`だけで起きるような気がします。
~~~
$ for i in 1 5 10 100 1000 10000; do echo; echo $i; ruby2.2 -r ./test/lib/memory_status.rb -e "puts m0 = Memory::Status.new; 10000.times{[*1..$i].pop}; GC.start; puts m1 = Memory::Status.new; p m1.rss.f... -
03:15 PM Bug #11332: Arrayの操作でcrubyインタプリタのメモリリークが起きる
- `ruby -e 'loop { [1, 2, 3, 4].tap(&:pop).sort! }'` とすると、同じ現象と思われるメモリ増加が確認できました。
(ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-darwin14])
`loop { [1, 2, 3, 4, 5].tap(&:pop).sort! }` でも `loop { [1, 2, 3].tap(&:pop).sort! }` でもメモリ増... -
- きしもとです
`Array` の `sort!` と、`pop` または `shift` の操作を組み合わせると、わずか
ですが ruby インタプリタのメモリリークを引き起こすようです。多数回
繰返すと、どんどん大きくなります。
以下のサンプルを手元の環境（FreeBSD/amd64のruby 2.1.6、ruby 2.2.2、
trunk (r51120) ）で試すと、どれもインタプリタのプロセスのメモリ
サイズが大きくなっていきます（最後はメモ... -
- I tried to fix it int load.c, but failed rubyspec:
http://80x24.org/spew/m/[email protected]
However, this one-liner seems to work:
~~~diff
--- a/enumerator.c
+++ b/enumerator.c
@@ -2060,6 +2060,... - 04:53 PM Revision 4ea870cd (git): * 2015-07-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51145 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51144 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- きしもとです
Array の sort! と、pop または shift の操作を組み合わせると、わずか
ですが ruby インタプリタのメモリリークを引き起こすようです。多数回
繰返すと、どんどん大きくなります。
以下のサンプルを手元の環境（FreeBSD/amd64のruby 2.1.6、ruby 2.2.2、
trunk (r51120) ）で試すと、どれもインタプリタのプロセスのメモリ
サイズが大きくなっていきます（最後はメ... -
- 「メールをチケットにする」操作のミスで重複チケットを作ってしまったので閉じます。
失礼いたしました。 -
- きしもとです
Array の sort! と、pop または shift の操作を組み合わせると、わずか
ですが ruby インタプリタのメモリリークを引き起こすようです。多数回
繰返すと、どんどん大きくなります。
以下のサンプルを手元の環境（FreeBSD/amd64のruby 2.1.6、ruby 2.2.2、
trunk (r51120) ）で試すと、どれもインタプリタのプロセスのメモリ
サイズが大きくなっていきます（最後はメ... -
- Backported into `ruby_2_2` branch at r51143.
-
- * file.c (rb_file_load_ok): try opening file without gvl not to
lock entire process. [Bug #11060]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@51143 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51142 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Patch by @yui-knk [fix GH-955]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [fix GH-954]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51140 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:49 AM Revision df11c9c5 (git): enum.c: remove volatile, use RB_GC_GUARD
- volatile appears unnecessary in most cases as the VALUEs are used as
arguments of uninlined functions. Even worse, volatile can be
insufficient in places where RB_GC_GUARD is necessary.
* enum.c (zip_ary): remove volatile, use RB_GC_GU... -
- Loaded features is an obvious candidate for fstring since
feature paths of Ruby sources are included in iseq locations,
and iseq locations are in the fstring table anyways.
Deduplicating expanded load path can reuse old objects, sin... -
- rb_str_freeze may resize oversized buffers to save memory, so favor
it over rb_obj_freeze. This is useful because IO methods do not
prematurely shrink buffers, as they are likely to be overwritten
with full data.
* string.c (Init_... -
- [email protected] wrote:
> Eric Wong wrote:
> > I suggest banning it (barely-tested patch):
>
> +1
OK with matz to commit my patch? (+ tests)?
Also, what about '?' and '!' in field names?
Can we continue to allow those?
I ... -
- Applied in changeset r51138.
----------
test_case.rb: fix multiple load
* lib/rubygems/test_case.rb (teardown): do not delete features
loaded from the original load paths, the same libraries should
be loaded again when the same fea... -
- * lib/rubygems/test_case.rb (teardown): do not delete features
loaded from the original load paths, the same libraries should
be loaded again when the same features are required.
[ruby-dev:49031] [Bug #11222]
git-svn-id: svn+ssh:/... -
01:30 AM Misc #11329 (Closed): Improved documentation grammar for open-uri#open option
- Minor documentation readability improvement
- 12:47 AM Revision 443ce92b (git): * 2015-07-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51137 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:47 AM Revision 8bfc0b65 (git): vm.c: reduce branches for always-set VM fields
- thgroup_default, mark_object_ary, load_path, load_path_snapshot,
expanded_load_path, loaded_features, loaded_features_snapshot,
top_self, defined_module_hash are always defined at process startup.
This makes it wasteful to have extra br...
07/03/2015
-
- Backported into `ruby_2_2` branch at r51135.
-
- ruby_2_1 r51123 merged revision(s) 50717.
-
- * lib/mkmf.rb (pkg_config): split --libs if --libs-only-l option
is not available. patch in [ruby-core:69428] by Hans Mackowiak.
[ruby-core:69421] [Bug #11201]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/r... -
08:05 PM Feature #10672: Enable SSL on cache.ruby-lang.org
- This is really great, and addresses the hardest part of my request. Thank you to Fastly for supporting the open source Ruby project with TLS for cache.ruby-lang.org, and to the Ruby project for enabling it!
I'll move the latter part o... -
- I launched https CDN at 03/07/2015 JST.
Please use https://cache.ruby-lang.org
I appreciated fastly's suppot. -
- Backported into `ruby_2_2` at r51134.
-
- sorry, previous commet is a mistake.
-
- Backported into `ruby_2_2` branch at r51132.
-
- ruby_2_1 r51122 merged revision(s) 50671.
-
- * compile.c (iseq_compile_each): out of range NTH_REF is always
nil.
* parse.y (parse_numvar): check overflow of NTH_REF and range.
[ruby-core:69393] [Bug #11192]
* util.c (ruby_scan_digits): make pu... -
- Backported into `ruby_2_2` branch at r51133.
-
- ruby_2_1 r51119 merged revision(s) 50430,50440.
-
- * vm_eval.c (rb_method_call_status): undefined refined method is
not callable unless using. [ruby-core:69064] [Bug #11117]
* vm_eval.c (rb_method_call_status): resolve refined method entry
to check if undefi... -
- Backported into ruby_2_2 branch at r51132.
-
- ruby_2_1 r51121 merged revision(s) 50793,51120.
-
- * lib/cmath.rb: [DOC] Add docs [ci skip][Fix GH-909][Bug #11162]
Patch provided by @davydovanton
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@51132 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:30 PM Bug #11327 (Closed): Improve duplicate key warning.
- This change rephrases the duplicate key warning, which causes some confusion.
Before:
~~~
/Users/andre/bug.rb:4: warning: duplicated key at line 5 ignored: :max_instances
~~~
After:
~~~
/Users/andre/bug.rb:4: warning: key ... -
- test_gem_remote_fetcher.rb: get rid of errors
* test/rubygems/test_gem_remote_fetcher.rb (start_ssl_server):
temporary measure for "dh key too small" error of OpenSSL
1.0.2c+.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/bra... -
- Backported into `ruby_2_2` branch at r51130.
-
- * test/ruby/test_m17n_comb.rb: test_str_crypt split into strict
and non-strict versions to allow masking out non-strict when
glibc version cannot be determined (#11045).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@... -
- Backported into `ruby_2_2` at r51129.
-
- vm.c: break from orphan block
* vm.c (rb_vm_search_cf_from_ep): break from orphan block is
possible condition, but not [BUG].
[ruby-core:69548] [Bug #11254]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@5112... - 12:55 PM Revision 6282b156 (git): * test/ruby/test_require.rb (TestRequire#test_loading_fifo_threading):
- fix previous commit. [Bug #11060]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@51128 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I committed this change. If you find any regression, please report about it.
I measured some applications with https://github.com/ko1/class_stat gem. This gem reports class/module/T_ICLASS usage.
For example, my rails app https://g... -
- Applied in changeset r51126.
----------
* method.h: introduce rb_callable_method_entry_t to remove
rb_control_frame_t::klass.
[Bug #11278], [Bug #11279]
rb_method_entry_t data belong to modules/classes.
rb_method_entry_t::owner ... - 11:25 AM Revision 8895c18d (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51127 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r51126.
----------
* method.h: introduce rb_callable_method_entry_t to remove
rb_control_frame_t::klass.
[Bug #11278], [Bug #11279]
rb_method_entry_t data belong to modules/classes.
rb_method_entry_t::owner ... -
- rb_control_frame_t::klass.
[Bug #11278], [Bug #11279]
rb_method_entry_t data belong to modules/classes.
rb_method_entry_t::owner points defined module or class.
module M
def foo; end
end
In this case, owner is M.
... -
11:05 AM Bug #11060: load(fifo) blocks whole process
- Nobuyoshi Nakada wrote:
> Franck Verrot wrote:
> ...
My automatic translator tricked me :-)
> > Once running, it seems that loading from a FIFO isn't supported (it's expecting a regular file). Here's a patch for making `load` work w... -
- ruby_2_1 r51118 merged revision(s) 50887,50896,50902.
- 10:30 AM Revision b0ed2765 (git): * test/ruby/test_require.rb (TestRequire#test_loading_fifo_threading):
- ignore Errno::ENOENT on unlinking. [Bug #11060]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@51125 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:15 AM Revision 759d1288 (git): merge revision(s) 49235: [Backport #10711]
- numeric.c: fix message
* numeric.c (coerce_failed): fix the error message on non-flonum
platforms.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@51124 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:43 AM Revision f81db3c8 (git): merge revision(s) 50717: [Backport #11201]
- * lib/mkmf.rb (pkg_config): split --libs if --libs-only-l option
is not available. patch in [ruby-core:69428] by Hans Mackowiak.
[ruby-core:69421] [Bug #11201]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/r... - 09:39 AM Revision bf571987 (git): merge revision(s) 50671: [Backport #11192]
- * compile.c (iseq_compile_each): out of range NTH_REF is always
nil.
* parse.y (parse_numvar): check overflow of NTH_REF and range.
[ruby-core:69393] [Bug #11192]
* util.c (ruby_scan_digits): make pu... -
- Eric Wong wrote:
> I suggest banning it (barely-tested patch):
+1 -
- [email protected] wrote:
> I don't have a strong opinion whether defining a writer member should
> ...
I suggest banning it (barely-tested patch):
~~~diff
--- a/struct.c
+++ b/struct.c
@@ -12,6 +12,7 @@
#include "internal.h"... -
07:38 AM Bug #11326 (Closed): Defining a writer as a Struct member allowed?
- Hi,
yesterday I've stumbled on weird behavior defining writers as Struct members.
While this code works on MRI it breaks on JRuby and Rubinius:
```ruby
Struct.new(:x=).new(nil).x = 23
```
On JRuby it fails with:
```
Arg... - 09:12 AM Revision a57c9250 (git): merge revision(s) 50793,51120: [Backport #11162]
- * lib/cmath.rb: [DOC] Add docs [ci skip][Fix GH-909][Bug #11162]
Patch provided by @davydovanton
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@51121 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:08 AM Revision 6ddfcd93 (git): * lib/cmath.rb: shouldn't use non-ASCII characters in documentation. as a
- custom, single quote is seen as the same as apostrophe in computer typography.
[skip ci]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51120 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:55 AM Revision 1bd36e36 (git): merge revision(s) 50430,50440: [Backport #11117]
- * vm_eval.c (rb_method_call_status): undefined refined method is
not callable unless using. [ruby-core:69064] [Bug #11117]
* vm_eval.c (rb_method_call_status): resolve refined method entry
to check if undefi... - 08:51 AM Revision dffe87c7 (git): merge revision(s) 50887,50896,50902: [Backport #11060]
- * file.c (rb_file_load_ok): try opening file without gvl not to
lock entire process. [Bug #11060]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@51118 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Is this a spec change or a bug?
-
- That does make a lot of sense. I'll send another pull request.
-
- * win32/file.c: some mingw compilers need a tweek for the
declarations of _wfreopen_s. [Bug #11320]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51117 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r51116.
----------
transcode.c: empty encoding name
* transcode.c (rb_econv_set_replacement): target encoding name can
be empty now. [ruby-core:69841] [Bug #11324] -
- * transcode.c (rb_econv_set_replacement): target encoding name can
be empty now. [ruby-core:69841] [Bug #11324]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51116 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/02/2015
-
- * object.c (convert_type): conversion without "to_" prefix is not
implicit. fix up r51039.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51115 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:24 PM Revision 5d8f0a42 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51114 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:23 PM
Feature #11318 (Closed): [PATCH] delay `exception: false' checks for minor speedup
- Applied in changeset r51113.
----------
delay `exception: false' checks for minor speedup
Delay hash lookups until we are about to hit an exception. This
gives a minor speedup ratio of 2-3% in the new bm_io_nonblock_noex
benchmark as ... - 10:22 PM Revision df4e282e (git): delay `exception: false' checks for minor speedup
- Delay hash lookups until we are about to hit an exception. This
gives a minor speedup ratio of 2-3% in the new bm_io_nonblock_noex
benchmark as well as reducing code.
* benchmark/bm_io_nonblock_noex.rb: new benchmark
* ext/openssl/ossl... - 10:13 PM Revision 79d757b1 (git): * 2015-07-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51112 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * dir.c (replace_real_basename): Win32 API does not set errno, get
the last error by GetLastError() and map to errno. [Bug #10015]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51111 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:48 PM Bug #11174: threads memory leak
- I've checked the bug on older versions and the 2.2-head: leaks all but 1.8.7
~~~
$ ruby --version
ruby 2.2.3p139 (2015-07-01) [x86_64-linux]
$ ruby /tmp/thread_memleak4.rb
VmRSS: 47152 kB
VmRSS: 72872 kB
VmRSS: 90448... -
01:48 PM Feature #11325 (Rejected): Block is passed to initializer implicitly even when I asked not to.
- It may be surprising to you, but this is by design.
You have to explicitly pass an empty block when using `super`:
super(&nil)
There's also no way to change this even if we wanted to because of incompatibilities. -
01:05 PM Feature #11325 (Rejected): Block is passed to initializer implicitly even when I asked not to.
- This works as expected:
~~~ruby
class Foo
attr_reader :block
def initialize(&block)
@block = block
end
end
foo = Foo.new { :foo }
foo.block.nil?
# => false
~~~
But then I'm trying to stop passing a block to ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51110 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * dir.c (replace_real_basename): show warnings at errors.
[Bug #10015]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51109 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r51108.
----------
* gc.c: remove `#define RGENGC_OBJ_INFO 1' line introduced to
debug Bug #11244. -
- debug Bug #11244.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51108 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Fill internal object information into passed buffer.
* gc.h: declare rb_raw_obj_info().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51107 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:21 AM Bug #11324: Encoding to a String's own encoding with some options fails
- See also #8123
-
- To encode a `String` instance to its own encoding seems to be a bad idea, but following result looks strange:
```ruby
s = "A\nB\r\nC".force_encoding('US-ASCII')
#=> "A\nB\r\nC"
s.encode('US-ASCII')
#=> "A\nB\r\nC"
s.encode('US-AS... -
08:08 AM Feature #11322: OpenUri: RuntimeError: HTTP redirection loop
- Dear D.E. Akers: Your workaround works like a charm. Thank you very much.
-
07:36 AM Feature #4897: Define Math::TAU and BigMath.TAU. The "true" circle constant, Tau=2*Pi. See http://tauday.com/
- I'm a bit late, but here it is rebased for Tau Day 2015:
* https://github.com/ruby/ruby/pull/644
-
- Applied in changeset r51106.
----------
dir.c: update path type
* dir.c (replace_real_basename): update path type by the target
attributes if possible, to improve the performance. [Bug #10015] -
- * dir.c (replace_real_basename): update path type by the target
attributes if possible, to improve the performance. [Bug #10015]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51106 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:14 AM Bug #11314: [BUG] Segmentaton fault
- thanks for good advices.
i"ll try to update ffi gem. - 05:48 AM Revision 37c8a704 (git): * st.c: get rid of VC++'s warnings of C4700 (uninitialized local
- variable used). I think that these are wrong, but should shut them
up.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51105 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/rubygems.rb (Gem.load_path_insert_index): search
@gem_prelude_index first.
* lib/rubygems/test_case.rb (Gem::TestCase#setup): keep already
expanded paths to prserve instance variables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
- * ruby.c (process_options): also copy initial load path marks at
setting load paths encoding.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51103 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51102 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `Array#uniq` is implemented using a hash table; since hashes in Ruby preserve insertion order, so too does `Array#uniq`. The following simplified translation to Ruby should help clarify what's going on in `rb_ary_uniq()`:
``` ruby
cl... -
01:39 AM Feature #11323 (Open): Documentation update on how uniq works / guarantee of order
- Greetings,
I was looking at Array.uniq and I was wondering how the code made the array unique.
There are 2 different possible outcomes for making an array unique.
For example:
[1,2,1]
The first value is kept and all subseque... -
- * test/rubygems/test_require.rb (test_dash_i_beats_gems): skip
because the target feature just does not work. requiring a gem
inserts its paths and its dependents' paths at the beginning of
$LOAD_PATH, regardless -I options.
git-... -
- * test/rubygems/test_gem_server.rb (process_based_port): use
dynamically chosen port numberss to get rid of conflicts.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51100 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:00 AM Revision ad0c1466 (git): * test/rubygems/test_gem_specification.rb: skip tests which the
- platform does not permit the filename of its test file.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51099 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:36 AM
Feature #11298 (Closed): [PATCH] socket: memoize common socket families in fptr->mode
- Applied in changeset r51097.
----------
socket: memoize common socket families in fptr->mode
This provides a minor speedup by avoiding an extra syscall
require 'socket'
require 'benchmark'
nr = 100000
msg = 'hello world'
buf = ''... -
- * test/rubygems/test_gem_resolver_git_specification.rb: require
rubygems/installer.rb before Gem::TestCase#setup runs, otherwise
as Gem::TestCase#teardown restores $LOADED_FEATURES to the state
at that time, the requiring the file ... - 01:58 AM Revision 6dda4f17 (git): socket: memoize common socket families in fptr->mode
- This provides a minor speedup by avoiding an extra syscall
require 'socket'
require 'benchmark'
nr = 100000
msg = 'hello world'
buf = ''
size = msg.bytesize
puts(Benchmark.measure ... -
- I think we need to preserve existing behavior with accept_nonblock in case
there is code which shares accepted FDs with non-Ruby processes (or even
passes it to a C extension).
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51096 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- platform.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51095 b2dd03c8-39d4-4d8f-98ff-823fe69b080e