Activity
From 11/01/2016 to 11/07/2016
11/07/2016
- 03:26 PM Revision 121ce4ac (git): * 2016-11-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56667 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:26 PM Revision 9a23a406 (git): Add entry for Enumerator::Lazy#chunk_while
- [ci skip][GH-1186]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56666 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:28 PM Feature #12142: Hash tables with open addressing
- Koichi,
Yes, it was my mistake.
Thank you for all your efforts.
Regards,
Yura -
10:08 AM Feature #12142: Hash tables with open addressing
- On 2016/11/07 18:32, [email protected] wrote:
> 1) My last version is open addressing
> 2) ... (so it doesn't use more memory)
> 3) It is on github
> https://github.com/funny-falcon/ruby/tree/st_table_with_array6
> (and I've ... -
10:05 AM Feature #12142: Hash tables with open addressing
- I understand, it was my mistake to push into new branch instead of `st_table_with_array3`.
-
09:32 AM Feature #12142: Hash tables with open addressing
- Koichi,
1) My last version is open addressing
2) ... (so it doesn't use more memory)
3) It is on github
https://github.com/funny-falcon/ruby/tree/st_table_with_array6
(and I've posted link in https://bugs.ruby-lang.org/issues/121... -
09:11 AM Feature #12142: Hash tables with open addressing
- On 2016/11/07 17:53, [email protected] wrote:
> You've measured latest Vlad's version, but not latest mine.
There are several reasons:
(1) Your last version is not open addressing.
It is hard to compare many evaluation poin... -
08:53 AM Feature #12142: Hash tables with open addressing
- Koichi,
You've measured latest Vlad's version, but not latest mine.
Though, it doesn't matter now.
Regards,
Yura. -
08:33 AM Feature #12142: Hash tables with open addressing
- I updated my report:
<https://gist.github.com/ko1/dda8243134bc40f7fc05e293abc5f4b2#file-report-md>
* add vlad2 as last vlad's implementation
* add insertion overhead
Conclusion is not changed. Both implementations are faster than... -
06:09 AM Feature #12142: Hash tables with open addressing
- Matz,
I was disappointed not because you chose Vlad's version,
but because you called it "simpler" than mine.
I'm glad that Ruby will have new implementation.
I do respect your choice.
I do respect Vladimir's work. I learned a lot... -
03:47 AM Feature #12142: Hash tables with open addressing
- Funny_falcon,
Sorry for not choosing yours. Both are as good, the difference is so slight, and I had to make a decision at the moment.
I felt Vlad's version has some root for improvement that we see in yours. That's the reason I said... -
01:51 AM Feature #12142: Hash tables with open addressing
- On 2016/11/06 15:37, [email protected] wrote:
> Issue #12142 has been updated by Yura Sokolov.
> I was ready to loose,
Open Source Software is not a zero-sum game. I think that with the
patches now in Ruby trunk, everybody... -
12:45 AM Feature #12142 (Closed): Hash tables with open addressing
- Applied in changeset r56650.
----------
Introduce table improvement by Vladimir Makarov <[email protected]>.
[Feature #12142]
See header of st.c for improvment details.
You can see all of code history here:
<https://github.com/vn... -
12:10 PM Revision 36b4b44b (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56665 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:46 AM Revision 911f3d95 (git): Added Entry for Rubygems 2.6.8 update.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56664 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:45 AM Bug #12908: make-snapshot is broken
- It seems that this works:
```
tool/make-snapshot -packages=xz -srcdir=. tmp
```
i.e. the ```-srcdir=.``` makes a difference ... -
09:33 AM Bug #12908 (Closed): make-snapshot is broken
- Testing with r56663, the make-snapshot fails with message:
```
$ tool/make-snapshot -packages=xz tmp
/builddir/ruby/tool/vcs.rb:123:in `realpath': no implicit conversion of URI::HTTP into String (TypeError)
from /builddir/ruby/too... -
09:41 AM Feature #12515: Create "Boolean" superclass of TrueClass / FalseClass
- > Why do you use Kernel::Boolean and not just Boolean?
Some gems define
~~~ruby
class Boolean
end
class TrueClass; include Boolean; end
class FalseClass; include Boolean; end
~~~
and some gems define:
~~~ruby
module B... -
08:21 AM Bug #12789 (Closed): syntax error keyword_do_block at ruby 2.4.0dev (2016-09-26 trunk 56254)
-
04:49 AM Bug #12789: syntax error keyword_do_block at ruby 2.4.0dev (2016-09-26 trunk 56254)
- こちら以下のバージョンでは再現しないため HEAD で一時的に起きていた現象と思われます。よろしければクローズ頂ければと思います。
```
% ruby -v
ruby 2.4.0dev (2016-11-07 trunk 56657) [x86_64-darwin13]
``` -
07:45 AM Revision 5f25ecd4 (git): test_optimization.rb: for r56208
- * test/ruby/test_optimization.rb (test_tailcall_condition_block):
test for r56208. [ruby-core:78015] [Bug #12905]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56663 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:00 AM Bug #12905 (Closed): tailcall_optimization not working as expected under certain condition order
- It's a bug fixed in the trunk.
-
06:57 AM Revision 233fa910 (git): Extend Net::HTTP#open_timeout for chkbuild on Solaris 10s.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56662 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:53 AM Revision 4c5f4258 (git): Add NEWS about removing ChangeLog
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56660 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:24 AM Bug #12907 (Closed): rb_respond_to() return value is incorrect
- As of Ruby 2.3.0 rb_respond_to incorrectly reports non-zero for methods that are not supported. This occurs with subclasses of BasicObject. This occurs with Oj when but should occur with other C code. A simple sample that demonstrates th...
-
03:47 AM Revision 12ee4e38 (git): vcs.rb: suppress warning
- * tool/vcs.rb (DebugPOpen): suppress refinements warning in 2.0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56658 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:28 AM Revision ba800653 (git): add cast
- * hash.c (rb_objid_hash): need to cast down.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56657 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:25 AM Revision 2fa7cd75 (git): vcs.rb: exclude beginning revision
- * tool/make-snapshot: pass the last revision in the last ChangeLog
file without increment.
* tool/vcs.rb (export_changelog): exclude the beginning revision
of the range uniformly. svn log includes it, but git log not.
git-svn-id: s... -
03:19 AM Feature #12906: do/end blocks work with ensure/rescue/else
- My error on the duplication, I tried searching a couple different ways but the first results weren't about this and I didn't see how to use the filters and the keywords together. Fortunately it seems congruent with https://bugs.ruby-lang...
-
02:52 AM Feature #12906 (Assigned): do/end blocks work with ensure/rescue/else
- Josh Cheek wrote:
> but this is the diff:
> ...
So from the patch you sent, I guess you are implicitly proposing to forget about `{...}`-style blocks for a while and focus on `do ... end`-style blocks. That is in fact a wise idea. To... -
01:16 AM Feature #12906 (Closed): do/end blocks work with ensure/rescue/else
- When you want to rescue in a block, you must do this:
~~~ruby
lambda do
begin
raise 'err'
rescue
$! # => #<RuntimeError: err>
end
end.call
~~~
I've wished on numerous occasions that I could omit the begin/end ... -
03:01 AM Bug #12874 (Third Party's Issue): Eventmachine recompile with openssl-win64 error
- Judging from the backtrace, the issue is in EventMachine. Please report to the EventMachine project.
-
02:54 AM Revision 4201000a (git): vcs.rb: unnecessary arguments
- * tool/make-snapshot: $srcdir is optional.
* tool/vcs.rb (export_changelog): remove unnecessary arguments.
VCS should know srcdir and url.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56655 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:54 AM Revision 8b97d669 (git): vcs.rb: use chdir option
- * tool/vcs.rb (export_changelog): for old git, use chdir option
instead of git -C option, and set language environmets to C.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56654 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:19 AM Bug #3867 (Rejected): Bus Error when running drb/ssl regression tests on loongson/OpenBSD
- Closing for now. I have no idea what was happening, but OpenSSL::PKey::RSA.new which was called from lib/drb/ssl.rb:57 was re-written in Ruby 2.0.0.
-
02:10 AM Revision 2a8ba4bd (git): Just check that interruption doesn't cause SEGV.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56653 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:23 AM Revision e18f3e85 (git): make-snapshot: sort globbed results
- * tool/make-snapshot (package): globbed results order is
undefined.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56652 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:03 AM Revision 807f3f97 (git): fix NEWS message
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56651 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:45 AM Revision 75775157 (git): Introduce table improvement by Vladimir Makarov <[email protected]>.
- [Feature #12142]
See header of st.c for improvment details.
You can see all of code history here:
<https://github.com/vnmakarov/ruby/tree/hash_tables_with_open_addressing>
This improvement is discussed a... -
12:13 AM Misc #12283: Obsolete ChangeLog and commit message in Git-style
- !!!
So is it now open? Can we commit without ChangeLog entry? -
12:04 AM Revision 2bb96b87 (git): vcs.rb: popen with env
- * tool/vcs.rb (IO.popen): support passing environment variables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56649 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/06/2016
-
05:34 PM Revision 30e54ac3 (git): revision.h shouldn't depend ChangeLog
- Maybe it needs vcs dependent ways.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56648 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:46 PM Bug #12905: tailcall_optimization not working as expected under certain condition order
- I have also tried below and still get SystemStackError:
~~~ ruby
RubyVM::InstructionSequence.compile_option = {
:tailcall_optimization => true,
:trace_instruction => false
}
RubyVM::InstructionSequence.new(<<-EOF).eval
def... -
03:58 PM Bug #12905: tailcall_optimization not working as expected under certain condition order
- Shugo Maeda wrote:
> Kai Sun wrote:
> ...
I have tried with eval but seems still getting stack level too deep error. -
03:48 PM Bug #12905 (Rejected): tailcall_optimization not working as expected under certain condition order
- Kai Sun wrote:
> Below code gets stack too deep error:
RubyVM::InstructionSequence.compile_option must be set before
compilation of the target program, so you need eval, load, etc.
```ruby
RubyVM::InstructionSequence.compile_opt... -
03:37 PM Bug #12905 (Closed): tailcall_optimization not working as expected under certain condition order
- Below code gets stack too deep error:
~~~ ruby
RubyVM::InstructionSequence.compile_option = {
:tailcall_optimization => true,
:trace_instruction => false
}
def run_forever(current, final)
if current < final
run_fore... -
04:22 PM Bug #11531: IPAddr#== implements wrong logic
- I think this is intentional. IPAddr represents an IP address, not an IP network, so it does not consider a difference in netmasks as significant.
-
03:56 PM Revision 4e9a5a3e (git): Obsolete ChangeLog [Feature #12283]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56645 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:35 PM Revision e8ffc63c (git): * test/ruby/test_optimization.rb (test_tailcall_interrupted_by_sigint):
- ignore on Windows because we cannot handle signaled status of child
ruby process on this platform.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56644 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:33 PM Revision a8206276 (git): * 2016-11-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56643 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:33 PM Revision fd9f3834 (git): confirm that status.termsig is not nil.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56642 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:41 PM Revision 90bf4a8e (git): * test/ruby/test_optimization.rb (test_tailcall_interrupted_by_sigint):
- send SIGKILL if the child process doesn't die within 1 second.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56641 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:01 PM Revision 76e047a8 (git): remove debug sleep & exit
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56640 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:57 PM Misc #12283 (Closed): Obsolete ChangeLog and commit message in Git-style
- Applied in changeset r56638.
----------
* tool/vcs.rb (export_changelog): generate ChangeLog file from
vcs's log. [Feature #12283]
* tool/make-snapshot (package): overwrite ChangeLog by generated
ChangeLog. -
12:57 PM Revision f7f00b89 (git): * tool/vcs.rb (export_changelog): generate ChangeLog file from
- vcs's log. [Feature #12283]
* tool/make-snapshot (package): overwrite ChangeLog by generated
ChangeLog.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56638 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:36 PM Revision cf96cfe7 (git): * NEWS: Added entry for RDoc 5.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56637 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:36 PM Revision 670b1802 (git): * NEWS: ordered entries and adjust styles.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56636 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:23 AM Revision 9b09175d (git): * NEWS: Added entry for [Feature #12160][ruby-core:74239]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56635 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:18 AM Revision 69dc5302 (git): * NEWS: Added entry for r56624.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56634 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:58 AM Revision 17678b5a (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56633 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:58 AM Revision 53938555 (git): * configure.in (-Wno-maybe-uninitialized): gcc 6 also shows the same
- warnings as described in r49410.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56632 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:37 AM Feature #12142: Hash tables with open addressing
- Any way,
I apologize again for my messages after decision.
It were inappropriate.
It is just emotional reaction.
I was ready to loose, but I really thought my version is simpler, so it is reaction only on that remark. -
06:32 AM Feature #12142: Hash tables with open addressing
- looks like I removed function definitions in previous count. fixed that.
now counts are: 428 lines vs 572 lines. -
06:14 AM Feature #12142: Hash tables with open addressing
- Vladimir,
Yes, I excluded tables, and I measured after preprocessor,
so all `#if` are removed:
- removed function that checks table consistency (I also has such function, and it is also removed)
- removed all calls to such function a... -
01:35 AM Feature #12142: Hash tables with open addressing
- Vladimir Makarov wrote:
>
> ...
Sorry, my suspicion was wrong. It seems you excluded this in your line counting.
-
05:42 AM Bug #12887 (Closed): Object#extendを引数無しで呼び出すとErrorとなるが、Module#includeとModule#prependはエラーとならない
- Applied in changeset r56631.
----------
include and prepend check no args
* eval.c (rb_mod_include, rb_mod_prepend): check if arguments are
given, as well as Kernel#extend. [ruby-dev:49854] [Bug #12887]
[Fix GH-1470] -
05:42 AM Revision d2101310 (git): include and prepend check no args
- * eval.c (rb_mod_include, rb_mod_prepend): check if arguments are
given, as well as Kernel#extend. [ruby-dev:49854] [Bug #12887]
[Fix GH-1470]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56631 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
05:39 AM Revision 2456f869 (git): ChangeLog: remove garbage lines
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56630 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:38 AM Revision 6082f061 (git): ChangeLog: make us-ascii
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56629 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:22 AM Revision 25aa35d4 (git): ChangeLog: make us-ascii
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56628 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:29 AM Revision 7ee58884 (git): add a ticket number [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56627 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:04 AM Revision eb6d1cfc (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56626 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:04 AM Revision 8a2bd2b7 (git): * test/rinda/test_rinda.rb (test_make_socket_ipv6_multicast,
- test_make_socket_ipv6_multicast_hops): skip if IPv6 multicast
address is not available.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56625 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:53 AM Revision 493e4889 (git): irb.rb: Binding#irb
- * lib/irb.rb (Binding#irb): new method like Binding#pry.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56624 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:50 AM Revision af3f5267 (git): * test/net/smtp/test_smtp.rb (test_tls_connect, test_tls_connect):
- use Socket.tcp_server_sockets in case localhost is resolved to ::1.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56623 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:49 AM Revision 5e214d40 (git): irb.rb: IRB::Irb#run
- * lib/irb.rb (IRB::Irb#run): split from IRB.start.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56622 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:45 AM Revision d903681a (git): e2mmap.rb: remove old definition
- * lib/e2mmap.rb (E2MM.def_exception): remove old definition if
exists so that works multiple times.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56621 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:17 AM Feature #11428: system/exec/etc. should to_s their argument to restore Pathname functionality as it was in 1.8
- Akira Tanaka wrote:
> I think `to_s` is too strong. However calling `to_path` is possible option.
After `to_s` failed, try `to_path`?
-
01:05 AM Feature #11428: system/exec/etc. should to_s their argument to restore Pathname functionality as it was in 1.8
- I think `to_s` is too strong. However calling `to_path` is possible option.
-
01:20 AM Revision 75ca0646 (git): Use Signal.signame instead of Signal.list.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56620 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:06 AM Revision 0de0e14d (git): * test/ruby/test_optimization.rb (test_tailcall_interrupted_by_sigint):
- don't use sleep to run faster.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56619 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:58 AM Bug #8004 (Closed): spawn does not honor its passed PATH
- Applied in changeset r56618.
----------
process.c: PATH env in spawn
* process.c (rb_exec_fillarg): honor the given path environment
variable. [ruby-core:53103] [Bug #8004] -
12:58 AM Revision 4b7fd61a (git): process.c: PATH env in spawn
- * process.c (rb_exec_fillarg): honor the given path environment
variable. [ruby-core:53103] [Bug #8004]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56618 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:54 AM Bug #10044 (Closed): socket.write has different behaviors in process and thread
- I think this is fixed at r48476.
-
12:46 AM Bug #10276 (Rejected): nil/true/false に singleton メソッドを定義できてしまう
- 12:10 AM Revision 840d23cb (git): * doc/standard_library.rdoc: fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56617 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/05/2016
-
11:58 PM Revision a2acbf4b (git): shell.rb: suppress warnings
- * lib/shell.rb: initialize class instance variables and remove
writer methods to be overwritten soon.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56616 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:54 PM Revision 1b95e8ef (git): e2mmap.rb: suppress a warning
- * lib/e2mmap.rb (bind): eval with the location. undefine
predefined method before overwriting to suppress a warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56615 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:16 PM Feature #12142: Hash tables with open addressing
- Yura Sokolov wrote:
> my st_table code is much shorter and simpler.
> ...
I think measuring lines after removing comments and single braces to
define what is simpler is not an accurate approach:
- I suspect you did not count tab... -
05:03 PM Feature #12142: Hash tables with open addressing
- Sorry again for sending a version after accepted decision.
It is my last attempt to jump in a train:
https://bugs.ruby-lang.org/attachments/download/6228/st_table_array4.mbox
I removed all siphash related code. (but I kept murmur fi... -
04:48 PM Feature #12142: Hash tables with open addressing
- Koichi Sasada wrote:
> > in my repository https://github.com/vnmakarov/ruby.git
> ...
Yes. The head of the branch has smaller memory footprint for tables than my April version. And it is a bit slower than April version. -
04:42 PM Feature #12142: Hash tables with open addressing
- Matz,
I apologize for this message,
I'm just asking for a bit more comments.
> So I chose Vlad's version as a baseline since it is slightly simpler.
> ...
Although my version contains a lot of non st_table related code (improvin... -
04:27 PM Feature #12142: Hash tables with open addressing
- > in my repository https://github.com/vnmakarov/ruby.git
Is it a small (but slightly slow) version?
I prefer it. -
03:38 PM Feature #12142: Hash tables with open addressing
- Yukihiro Matsumoto wrote:
> Performance-wise, the difference between two candidates is so small. I'm having a hard time making a decision. But to merge it before 2.4, we need to make a decision now.
> ...
Thank you.
I learned a lot ... -
03:22 PM Feature #12142: Hash tables with open addressing
- Performance-wise, the difference between two candidates is so small. I'm having a hard time making a decision. But to merge it before 2.4, we need to make a decision now.
So I chose Vlad's version as a baseline since it is slightly si... -
08:58 AM Feature #12142: Hash tables with open addressing
- I've uploaded new version.
It has one-line "security" fix in `murmur_finish` that doesn't change performance or memory footprint.
https://bugs.ruby-lang.org/attachments/download/6226/st_table_array2.mbox
- 06:09 PM Revision f0e2194b (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56614 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:09 PM Revision 84323167 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56613 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:09 PM Revision 8c5ae893 (git): Add ChangeLog-2015 as an anchor of new ChangeLog see #12283
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56612 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:06 PM Feature #5446: at_fork callback API
- We had to get around missing at_fork in concurrent-ruby as well. Since we are avoiding monkey_patching we had to result in lazy-checking pid, when it changes we re-create a resource. The resource has to check on every usage though which ...
-
04:56 PM Revision 051ba7b0 (git): Alias regist_scanner to register_scanner
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56611 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:43 PM Bug #12670: Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- The attached Dockerfile may help to reproduce.
-
04:18 PM Bug #12670: Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- I'm also using "Ubuntu 14.04.5 LTS" with gcc version 4.8.4 (Ubuntu 4.8.4-2ubuntu1~14.04.3).
-
03:36 PM Bug #12670: Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- Koichi Sasada wrote:
> On my linux VM, I can't reproduce with and without previous patch.
> ...
I have several PC and this problem reproduces even in TravisCi. But all my PC's and travis images are Ubuntu-based. It may be important. Wh... -
03:33 PM Bug #12670: Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- On my linux VM, I can't reproduce with and without previous patch.
* ruby 2.4.0dev (2016-11-05 trunk 56574) [x86_64-linux]
* ruby 2.4.0dev (2016-11-01 trunk 56534) [x86_64-linux]
Sorry... -
02:26 PM Bug #12670: Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- I think the status is changed, but there is another issue.
We can see a assertion fail when I set RGENGC_CHECK_MODE as 1 in gc.c.
```
$ bundle exec ruby test.rb
ruby: ../gc.c:1532: heap_page_allocate: Assertion `heap_allocated_page... -
02:34 AM Bug #12670 (Assigned): Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
-
04:42 PM Bug #12576 (Closed): SEGV when interrupting tail recursion
- Applied in changeset r56610.
----------
* compile.c (tailcallable_p): disable tail call optimization for
toplevel, eval, and load to avoid SEGV when interrupted by SIGINT.
[ruby-core:76327] [Bug #12576] -
03:35 PM Bug #12576: SEGV when interrupting tail recursion
- sorry for long absence. I agree with your suggestion. Could you commit it?
-
04:42 PM Revision 11c37ed3 (git): * compile.c (tailcallable_p): disable tail call optimization for
- toplevel, eval, and load to avoid SEGV when interrupted by SIGINT.
[ruby-core:76327] [Bug #12576]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56610 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:32 PM Feature #10298 (Rejected): Array#float_sum (like math.fsum of Python)
- Ruby 2.4 implements Array#sum and Enumerable#sum.
-
04:31 PM Bug #12527 (Closed): warning: macro redefined: REG_PC and REG_SP on Solaris 10
- Applied in changeset r56609.
----------
* vm_insnhelper.h: rename REG_(CFP|PC|SP|EP) to VM_REG_....
[Bug #12527]
* vm_exec.c: ditto. -
04:31 PM Revision b0569e3d (git): * vm_insnhelper.h: rename REG_(CFP|PC|SP|EP) to VM_REG_....
- [Bug #12527]
* vm_exec.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56609 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:23 PM Feature #10544 (Rejected): Time#to_i(:millisecond)
- We have Process.clock_gettime since Ruby 2.1.
```
% ruby -e 'p Process.clock_gettime(Process::CLOCK_REALTIME, :millisecond)'
1478362786099
```
This can be used as Time.now.to_i(:millisecond) which is shown in this issue.
... -
04:22 PM Bug #12330 (Closed): vm_trace.c (get_event_id) returns :specified_line if SPECIFIED_LINE was occurred
- Thank you for your investigation. Now, `RUBY_EVENT_SPECIFIED_LINE` should not be used and I'll remove this feature soon.
Thanks,
Koichi -
04:21 PM Feature #12236 (Rejected): Introduce `mmap` managed heap
- Now I need to reconsider about this feature request. So I close it.
Thank you for your joining about this discussion. -
04:16 PM Bug #12159: Thread::Backtrace::Location#path returns absolute path for files loaded by require_relative
- Agreed.
Matz.
-
04:14 PM Bug #12159: Thread::Backtrace::Location#path returns absolute path for files loaded by require_relative
- Sorry for late response.
I'll ask matz again.
I and Nobu talked about this topic and we agree with:
(1) to be obsolete `absolute_path` method and alias with `path` method.
(2) `path` method returns absolute path, even if main scr... -
04:09 PM Bug #11595 (Rejected): Time#utc? and Time#gmt? return misleading results based on $TZ
- Current behavior is intentional.
Time#utc? returns the mode of Time object, not the time zone offset is zero.
The mode affects several methods.
For example, Time#to_s generates "UTC" for UTC Time objects and
numeric timezone of... -
03:55 PM Bug #11909 (Rejected): io.popen problem in 2.2 and over
-
03:49 PM Revision a44c3bb2 (git): dir.c: merge rb_glob2 into rb_glob
- * dir.c (rb_glob): merge rb_glob2 which is used only here.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56608 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:46 PM Revision 7c7444bc (git): Enumerator::Lazy#chunk_while defined.
- * enumerator.c (InitVM_Enumerator): Enumerator::Lazy#chunk_while
defined. [Fix GH-1186]
https://github.com/ruby/ruby/pull/1186
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56607 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:45 PM Revision 04ff7cf7 (git): numeric.c: raise TypeError at wrong argument
- * numeric.c (int_pos_p, int_neg_p): raise TypeError if not an
Integer instead of returning nil.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56606 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:30 PM Revision 3f2f64db (git): * vm_eval.c (vm_call0_cfunc_with_frame): pass method id to
- dtrace hook. follow up r56592.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56605 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:19 PM Bug #11912 (Closed): [WIP] resolv: attempt to fix Resolv::LOC::Coord.create
- Applied in changeset r56604.
----------
fix Resolv::LOC::Coord.create.
* lib/resolv.rb (Resolv::LOC::Coord.create): fixed.
[ruby-core:72567] [Bug #11912] fixed by Eric Wong and Kazuhiro
NISHIYAMA. -
03:19 PM Revision 7d27c0a2 (git): fix Resolv::LOC::Coord.create.
- * lib/resolv.rb (Resolv::LOC::Coord.create): fixed.
[ruby-core:72567] [Bug #11912] fixed by Eric Wong and Kazuhiro
NISHIYAMA.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56604 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:05 PM Revision 825e1912 (git): * configure.in (-Wimplicit-fallthrough): gcc7 introduces case
- fall through warnings but it is too noisy.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=7652
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56603 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:02 PM Revision e3142f88 (git): * 2016-11-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56602 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:02 PM Revision a0842e7c (git): * numeric.c (rb_int_round): cast to SIGNED_VALUE to suppress
- warnings by -Wsign-compare.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56601 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:00 PM Bug #12652 (Closed): For Dir.home encode passed user
- Applied in changeset r56600.
----------
* file.c (rb_home_dir_of): convert given username into filesystem
encoding. [ruby-core:76682] [Bug #12652]
patched by Dāvis Mosāns -
03:00 PM Revision 54a6cd84 (git): * file.c (rb_home_dir_of): convert given username into filesystem
- encoding. [ruby-core:76682] [Bug #12652]
patched by Dāvis Mosāns
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56600 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:59 PM Bug #11994 (Closed): Incorrect result for yday in vtm_add_offset with negative UTC offset on last day of the year
- Applied in changeset r56599.
----------
fix vtm_add_offset yday on last day of year.
* time.c (vtm_add_offset): Fix yday on last day of year.
[ruby-core:72878] [Bug #11994] Fixed by Andrew White. -
02:59 PM Revision a03411b6 (git): fix vtm_add_offset yday on last day of year.
- * time.c (vtm_add_offset): Fix yday on last day of year.
[ruby-core:72878] [Bug #11994] Fixed by Andrew White.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56599 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:50 PM Feature #12375 (Closed): Net::HTTP.post
- Yui NARUSE wrote:
> Agreed about Net::HTTP.post shouldn't support post(hostname, path, port) form because there's no reason to support to use HTTP.
> ...
Merged in r56597.
-
02:19 PM Feature #12375 (Assigned): Net::HTTP.post
- Agreed about Net::HTTP.post shouldn't support post(hostname, path, port) form because there's no reason to support to use HTTP.
Could you commit it? -
02:49 PM Revision 85e74908 (git): Add the ticket number.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56598 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:39 PM Revision 88243c53 (git): * lib/net/http.rb (Net::HTTP.post): new convenience method to send a POST request.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56597 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:35 PM Feature #12902: How about Enumerable#sum uses initial value rather than 0 as default?
- Akira Tanaka wrote:
> I think [].sum should return 0.
> ...
I guess you mean Array#join
And the fact that Enumerable#sum could be used for string concatenation makes the default value of 0 pretty weird. Just imagine the following pi... -
04:01 AM Feature #12902: How about Enumerable#sum uses initial value rather than 0 as default?
- On 2016/11/05 04:28, [email protected] wrote:
> Issue #12902 has been updated by Aaron Lasseigne.
> In https://bugs.ruby-lang.org/issues/12217#note-3, Akira Tanaka, mentions that the default argument to sum is 0. This create... -
02:29 AM Feature #12902 (Feedback): How about Enumerable#sum uses initial value rather than 0 as default?
- I think [].sum should return 0.
Returning 0 is better than nil because programmers don't need to treat empty array specially.
This behavior is different with Enumerable#reduce which returns nil for empty array.
Also, string summatio... -
02:33 PM Feature #12268 (Rejected): Open3 should use extend self instead of module_function calls
- module_function is the standard way to define module methods.
I think it is because "include mod" makes us possible to call module methods without module name,
as "popen3(...)" instead of "Open3.popen3(...)",
"sin(...)" instead of "... -
02:19 PM Bug #12904 (Feedback): Seg fault in openssl
- Do you reproduce with ruby_2_3 branch head?
I can't tell anything without a reproducer but I suspect this is related to [Bug #12292]. -
02:04 PM Bug #12904 (Rejected): Seg fault in openssl
- I'm using Threads and EventMachine in a weird way because I don't really know what I'm doing. The same code but single threaded does not produce an error. There were no ruby files in the crash report directories.
/usr/local/Cellar/ru... -
02:14 PM Feature #12607: Ruby needs an atomic integer
- I agree with performance advantages.
I'm negative to introduce this feature because it is too hard.
People who know well about thread programming can use this feature using concurrent-ruby and I don't want to recommend it for peopl... -
01:55 PM Feature #12607: Ruby needs an atomic integer
- OK, then let's discuss the needs of this class.
An obvious benefit of this class to be in core is that we don't even need Mutex in theory. Because we have GVL, if we do this in core we can just increment the backend integer and that ... -
01:27 PM Feature #12607: Ruby needs an atomic integer
- > So you mean we don't need atomic integer because concurrent-ruby sucks? I don't think that's a valid reason to reject this.
I didn't mean that. After "BTW" is only my impression about threading. -
12:11 PM Feature #12607: Ruby needs an atomic integer
- So you mean we don't need atomic integer because concurrent-ruby sucks? I don't think that's a valid reason to reject this.
-
10:01 AM Feature #12607 (Feedback): Ruby needs an atomic integer
-
10:00 AM Feature #12607: Ruby needs an atomic integer
- At first, we need a box of integer, not an atomic integer.
Like that:
```ruby
box = IntegerBox.new(0)
box.increment
box.increment
box.to_i #=> 2
```
This IntegerBox can be implemented by the following code:
```ruby
clas... -
02:08 PM Bug #12890 (Closed): Net::HTTP should treat unexpected 1XX responses as non-final.
- Applied in changeset r56596.
----------
* lib/net/http.rb (transport_request): other than HTTPContinue
in 1xx (HTTPInformation) also needs to continue. [Bug #12890] -
02:08 PM Revision 8ec6fcb2 (git): * lib/net/http.rb (transport_request): other than HTTPContinue
- in 1xx (HTTPInformation) also needs to continue. [Bug #12890]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56596 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:03 PM Revision 5fa7cdbd (git): Time.parse's "now" argument as nil works again.
- * lib/time.rb (make_time): "now" argument as nil works again.
This is broken since Ruby 2.2.
Mathieu Jobin pointed a problem.
https://github.com/ruby/ruby/commit/e4b05d91eb0d48fd172abf015c493bb42d755d07#commitcomment-17421387
gi... -
02:02 PM Bug #12198: Hash#== sometimes returns false incorrectly
- The documentation of Set clearly states the following:
> * Set assumes that the identity of each element does not change
> ...
So it is not a bug, but that you are not supposed to modify an object once stored in a set. -
02:00 PM Feature #7360 (Feedback): Adding Pathname#glob
- It seems the proposed implementation treats the receiver as a glob pattern.
```
% ruby -rpathname -e '
class Pathname
def glob(pattern, flags = 0, &b)
Array(pattern).flat_map do |pat|
self.class.glob(join(pat), flags,... -
01:54 PM Bug #12799: IPAddr#== throws an exception with objects that can't be converted to IPAddr
- Committed, thanks!
-
01:53 PM Bug #12799 (Closed): IPAddr#== throws an exception with objects that can't be converted to IPAddr
- Applied in changeset r56594.
----------
IPAddr#== and IPAddr#<=> no longer raise an exception if coercion fails
* lib/ipaddr.rb (IPAddr#==): If coercion fails, return false
instead of passing through the exception. [ruby-core:77451]
... - 01:53 PM Revision 2d884179 (git): IPAddr#== and IPAddr#<=> no longer raise an exception if coercion fails
- * lib/ipaddr.rb (IPAddr#==): If coercion fails, return false
instead of passing through the exception. [ruby-core:77451]
[Bug #12799]
* lib/ipaddr.rb (IPAddr#<=>): If coercion fails, return nil
instead of passing through the excep... -
01:46 PM Bug #12897 (Rejected): Hash failed to recognize the existed key and send not found when using Vector as key
- I missed `0.0` and `0`.
-
01:17 PM Feature #12747: Add TracePoint#callee_id
- Thank you, I committed.
-
01:15 PM Feature #12747 (Closed): Add TracePoint#callee_id
- Applied in changeset r56592.
----------
* eval.c, method.h, proc.c, vm.c, vm_eval.c, vm_insnhelper.c, vm_method.c:
TracePoint#method_id should return method_id, not callee_id.
[ruby-core:77241] [Feature #12747]
* test/ruby/test_set... -
01:15 PM Revision 9cbd6ee0 (git): * vm_trace.c (tracepoint_attr_callee_id, rb_tracearg_callee_id):
- add TracePoint#callee_id. [ruby-core:77241] [Feature #12747]
* cont.c, eval.c, gc.c, include/ruby/intern.h, insns.def, thread.c,
vm.c, vm_backtrace.c, vm_core.h, vm_eval.c, vm_insnhelper.c, vm_trace.c: ditto.
* test/ruby/test_settrac... -
01:15 PM Revision 8004ad33 (git): * eval.c, method.h, proc.c, vm.c, vm_eval.c, vm_insnhelper.c, vm_method.c:
- TracePoint#method_id should return method_id, not callee_id.
[ruby-core:77241] [Feature #12747]
* test/ruby/test_settracefunc.rb: change accordingly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56592 b2dd03c8-39d4-4d8f-98ff-823... -
12:59 PM Revision bbeeb253 (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56591 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:49 AM Bug #12548 (Closed): Rounding modes inconsistency between round versus sprintf
- Applied in changeset r56590.
----------
numeric.c: round to nearest even
* numeric.c (flo_round, int_round): support round-to-nearest-even
semantics of IEEE 754 to match sprintf behavior, and add `half:`
optional keyword argument f... -
08:59 AM Bug #12548: Rounding modes inconsistency between round versus sprintf
- We had a discussion today, and the conclusions:
* add `half:` optional keyword argument to `round` methods,
* its value must be one of `:up`, `:even`, and `nil`,
* `:up` is compatible with the existing behavior,
* `:even` is the ne... -
09:49 AM Revision dfe91fcd (git): numeric.c: round to nearest even
- * numeric.c (flo_round, int_round): support round-to-nearest-even
semantics of IEEE 754 to match sprintf behavior, and add `half:`
optional keyword argument for the old behavior.
[ruby-core:76273] [Bug #12548]
git-svn-id: svn+ssh:... -
09:34 AM Feature #12210: Add IdentitySet class that compares members by identity
- Note that SortedSet#compare_by_identity is unimplemented when SortedSet uses rbtree.
`rbtree.readjust { |a, b| a.object_id <=> b.object_id }` comes pretty close, but rbtree treats string keys specially by storing a copy of each string... -
09:23 AM Feature #12210 (Closed): Add IdentitySet class that compares members by identity
- Applied in changeset r56589.
----------
Add Set#compare_by_identity and Set#compare_by_identity?
* lib/set.rb (Set#compare_by_identity, Set#compare_by_identity?):
New methods. [Feature #12210] -
09:19 AM Feature #12210: Add IdentitySet class that compares members by identity
- I'd rather add Set#compare_by_identity.
- 09:23 AM Revision 76977611 (git): Add Set#compare_by_identity and Set#compare_by_identity?
- * lib/set.rb (Set#compare_by_identity, Set#compare_by_identity?):
New methods. [Feature #12210]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56589 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:18 AM Revision cb3b7fc0 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56588 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:18 AM Revision 942bfc7b (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56587 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:18 AM Revision cdc527db (git): * lib/rdoc/*, test/rdoc/*: Update rdoc-5.0.0
- Release note: https://github.com/rdoc/rdoc/blob/b825775647f62c5b525e9780a28ff2fbb1d5bf6f/History.rdoc#500--2016-11-05
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56586 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:13 AM Feature #12596 (Closed): Add Pathname#empty? to be consistent with Dir.empty? and File.empty?
- implemented at r56571
-
09:12 AM Bug #12372 (Closed): Resolv::DNS does not fetch authority section resources when calling getresource(s)
- fixed at r56583
-
08:59 AM Revision 0a0eb280 (git): Refix r56559 with Fs.noatime? [ruby-core:77943] [Bug #12903]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56585 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:59 AM Revision 8d2e44c2 (git): rename to noatime?
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56584 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:33 AM Revision 365c3215 (git): extract_resources uses each_resource instead of each_answer.
- * lib/resolv.rb (Resolv::DNS#extract_resources): Use each_resource
instead of each_answer.
[ruby-core:75461] [Bug#12372] reported by Rafael Fernandez Lopez.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56583 b2dd03c8-39d4-4d8... -
08:23 AM Revision 0fe34211 (git): * ext/-test/file/fs.c (get_atime_p): Updating of file access times
- is enabled or not.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56582 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:28 AM Feature #12553 (Closed): IO.readlines(filename, chomp: true)
- Applied in changeset r56581.
----------
chomp option
* io.c (extract_getline_opts): extract chomp option.
[Feature #12553] -
07:28 AM Revision a2144bd7 (git): chomp option
- * io.c (extract_getline_opts): extract chomp option.
[Feature #12553]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56581 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:25 AM Bug #12814 (Rejected): Pathname#each_child(false) produces unusable file paths
- Pathname#each_child is designed that easier access for child files by default (with_directory=true).
But it is also possible to obtain filenames only (with_directory=false) for applications which
remember the directory in the applicati... - 07:18 AM Revision cc7b3feb (git): * doc/standard_library.rdoc: remove "thread.rb" phrase because
- Queue and ConditionVariable were moved to built-in class.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56580 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:14 AM Revision c40e5bac (git): mkconfig.rb: trailing space
- * tool/mkconfig.rb: [DOC] remove trailing space from a generated
line.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56579 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:10 AM Revision 34ac59c8 (git): openssl/ut_eof.rb: rename TestEOF
- * test/openssl/ut_eof.rb (OpenSSL::TestEOF): move TestEOF module
under OpenSSL to get rid of conflict with test/ruby/ut_eof.rb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56578 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:59 AM Revision 639ccc40 (git): * tool/mkconfig.rb: [DOC] add rbconfig documentation.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56577 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:47 AM Bug #12678 (Closed): No way to set a timeout for TLS handshake when using Net::SMTP
- Applied in changeset r56576.
----------
* lib/net/smtp.rb (tlsconnect): support timeout for TLS handshake.
[ruby-core:76893] [Bug #12678]
* lib/net/protocol.rb (ssl_socket_connect): new method to implement
timeout for TLS handshake... -
06:47 AM Revision 73b3b10d (git): * lib/net/smtp.rb (tlsconnect): support timeout for TLS handshake.
- [ruby-core:76893] [Bug #12678]
* lib/net/protocol.rb (ssl_socket_connect): new method to implement
timeout for TLS handshake.
* lib/net/http.rb (connect): use Net::Protocol#ssl_socket_connect.
git-svn-id: svn+ssh://ci.ruby-lang.org/... - 05:40 AM Revision 19c749f6 (git): Document the change in Shellwords.shellwords
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56575 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:17 AM Bug #12900 (Closed): TestSyntax#test_block_after_cmdarg_in_paren fails on PPC64
- Applied in changeset r56574.
----------
parse.y: fix restored cmdarg_stack
* parse.y (brace_body, do_body): since cmdarg_stack is saved in
VALUE val, should restore from the same member. on big-endian
platforms where VALUE is larg... -
05:17 AM Revision 8a5512b4 (git): parse.y: fix restored cmdarg_stack
- * parse.y (brace_body, do_body): since cmdarg_stack is saved in
VALUE val, should restore from the same member. on big-endian
platforms where VALUE is larger than int, it restored 0 in the
upper word. [ruby-core:77920] [Bug #1290... -
05:00 AM Bug #10055: Shellwords.shellsplit() does not match POSIX sh behavior for backslashes within double-quoted strings
- That is correct! I've fixed the implementation to conform to the standard.
-
04:58 AM Bug #10055 (Closed): Shellwords.shellsplit() does not match POSIX sh behavior for backslashes within double-quoted strings
- Applied in changeset r56573.
----------
Fix the handling of the backslash in double quotes
* lib/shellwords.rb (Shellwords#shellsplit): Fix the handling of
the backslash in double quotes to conform to the standard.
[ruby-core:63807... - 04:58 AM Revision 2da5ae42 (git): Fix the handling of the backslash in double quotes
- * lib/shellwords.rb (Shellwords#shellsplit): Fix the handling of
the backslash in double quotes to conform to the standard.
[ruby-core:63807] [Bug #10055]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56573 b2dd03c8-39d4-4d8f-98... -
03:31 AM Revision 7a78133a (git): Add NEWS about r56213.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56572 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:29 AM Revision 9373c5ef (git): Pathname#empty? implemented.
- * ext/pathname/pathname.c (Pathname#empty?): New method.
[ruby-core:76404] [Feature#12596] Proposed by John Backus.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56571 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:22 AM Bug #12893: trunk fails on linux with clang on test with callcc
- Yui NARUSE wrote:
> NetBSD pkgsrc and FreeBSD ports were fixed by adding volatile.
> ...
It seems to be a different issue.
I tried adding volatile to `cont` in `cont_new()`, but it didn't work.
-
02:53 AM Bug #12893: trunk fails on linux with clang on test with callcc
- NetBSD pkgsrc and FreeBSD ports were fixed by adding volatile.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206111 -
02:23 AM Bug #12893 (Closed): trunk fails on linux with clang on test with callcc
- Applied in changeset r56561.
----------
* cont.c (cont_new): disable optimization if clang's version is
3.8.0. [ruby-core:77894] [Bug #12893] -
03:13 AM Revision 19e59705 (git): Add NEWS about r56200
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56570 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:01 AM Bug #12836: Backport r56416 (copy_stream to duplex IO)
- ruby_2_3 r56569 merged revision(s) 56416.
-
03:01 AM Revision 4450acf4 (git): merge revision(s) 56416: [Backport #12836]
- * io.c (copy_stream_body): use IO to write to copy to duplex IO.
http://twitter.com/knu/status/786505317974585344
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56569 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:01 AM Bug #11186: Can't refine aliases in subclasses
- The bug was fixed in Ruby 2.3, and need not to be backported to prior versions, I think.
-
02:57 AM Bug #11186 (Closed): Can't refine aliases in subclasses
- Applied in changeset r56568.
----------
* test/ruby/test_refinement.rb (test_refine_alias_in_subclass):
add a test to check that alias in subclasses can be refined.
[ruby-core:69374] [Bug #11186] -
02:57 AM Revision 8b54e694 (git): * test/ruby/test_refinement.rb (test_refine_alias_in_subclass):
- add a test to check that alias in subclasses can be refined.
[ruby-core:69374] [Bug #11186]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56568 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:52 AM Bug #12895: Backport r53533
- ruby_2_3 r56567 merged revision(s) 53533.
-
02:52 AM Revision 5b52d585 (git): merge revision(s) 53533: [Backport #12895]
- * sprintf.c (rb_str_format): format exact number more exactly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56567 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:50 AM Revision 8afd5857 (git): [DOC] add explanation for Array#sum
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56566 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:48 AM Bug #12868: Please backport r55074 (openssl, fix ex_data index for X509_STORE_CTX)
- ruby_2_3 r56565 merged revision(s) 55074.
-
02:48 AM Revision 93bceb14 (git): merge revision(s) 55074: [Backport #12868]
- * ext/openssl/ossl.c (Init_openssl): register an ex_data index for
X509_STORE and X509_STORE_CTX respectively. Since they don't share
the ex_data index registry, we can't use the same index.
(ossl_verify_cb)... -
02:44 AM Bug #11959: Segfault during `exit' in thread initialize (Extended class).
- ruby_2_3 r56564 merged revision(s) 53449.
-
02:44 AM Revision 56408279 (git): merge revision(s) 53449: [Backport #11959]
- * thread.c (rb_thread_pending_interrupt_p): no pending interrupt
before initialization.
* thread.c (thread_raise_m, rb_thread_kill): uninitialized thread
cannot interrupt. [ruby-core:72732] [Bug #11959]
gi... -
02:39 AM Bug #11133 (Closed): Wrong Hyperlink representation in man page
- Thanks for your confirmation! It's just as intended that the URLs being rendered in bold.
-
02:39 AM Revision a2f30699 (git): test_logger.rb: suppress a warning
- * test/logger/test_logger.rb (test_datetime_format): suppress
warning when strftime called with empty format string.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56563 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:32 AM Revision d56ccddb (git): merge revision(s) 56550:
- * ext/bigdecimal/bigdecimal.c: Import changes from ruby/bigdecimal
repository.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@56562 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:31 AM Bug #12903: TestFile#test_stat fails on FreeBSD 11.0
- Nobuyoshi Nakada wrote:
> Do you mount with `noatime` option?
I didn't mean to, but yes.
> ...
It might to be better to check the mount option.
-
01:07 AM Bug #12903 (Closed): TestFile#test_stat fails on FreeBSD 11.0
- Applied in changeset r56559.
----------
test_file.rb: fix noatime
* test/ruby/test_file.rb (TestFile#test_stat): fix noatime case.
[ruby-core:77943] [Bug #12903] -
02:27 AM Feature #12810 (Rejected): Improve `Set#find_index` performance
- As commented by Herwin W and replied to the submitter in a personal mail, Set has no sense of index where elements are theoretically unordered. It's just that a Set happens to respond to `find_index` via the Enumerable module and have a...
-
02:23 AM Revision 6f6a5176 (git): * cont.c (cont_new): disable optimization if clang's version is
- 3.8.0. [ruby-core:77894] [Bug #12893]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56561 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:07 AM Revision 9d708e05 (git): * 2016-11-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56560 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:07 AM Revision c71a60c1 (git): test_file.rb: fix noatime
- * test/ruby/test_file.rb (TestFile#test_stat): fix noatime case.
[ruby-core:77943] [Bug #12903]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56559 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/04/2016
-
11:58 PM Bug #12903: TestFile#test_stat fails on FreeBSD 11.0
- Do you mount with `noatime` option?
-
11:55 PM Bug #12903 (Closed): TestFile#test_stat fails on FreeBSD 11.0
- TestFile#test_stat fails on FreeBSD 11.0 as follows:
```
CC = cc
LD = ld
LDSHARED = cc -shared
CFLAGS = -O3 -fno-fast-math -ggdb3 -Wall -Wextra -Wno-unused-parameter -Wno-parentheses -Wno-long-long -Wno-missing-field-initializ... -
11:20 PM Bug #12893: trunk fails on linux with clang on test with callcc
- Shugo Maeda wrote:
> static VALUE
> ...
I'm not sure whether the version of clang should be checked as follows:
```diff
diff --git a/cont.c b/cont.c
index 8119b5c..85d3766 100644
--- a/cont.c
+++ b/cont.c
@@ -471,6 +471,10 @@ ... -
10:59 PM Bug #12893: trunk fails on linux with clang on test with callcc
- Reproduced on my FreeBSD box:
```
./ruby -r continuation -e 'cont = nil; ary = [1,2,3]; ary.combination(2) { callcc {|k| cont = k} unless cont }; cont.call'
ruby 2.4.0dev (2016-11-04 trunk 56558) [x86_64-freebsd11.0]
-- Control f... -
12:52 PM Bug #12893: trunk fails on linux with clang on test with callcc
- FreeBSD failure log is here:
http://rubyci.org/logs/rubyci.s3.amazonaws.com/freebsd11zfs/ruby-trunk/log/20161104T063002Z.fail.html.gz -
02:22 AM Bug #12893: trunk fails on linux with clang on test with callcc
- Seems related to segfaults on FreeBSD 11.
I tried with MacPorts clang 3.8.1, but it didn't reproduce.
Maybe clang 3.8.0's issue?
-
10:51 PM Bug #12897 (Feedback): Hash failed to recognize the existed key and send not found when using Vector as key
- It should work.
```
$ ruby2.0 -v -rmatrix -e 'p = { Vector[1.0, 2.0, 0.0] => 1}' -e 'p p.key?(Vector[1.0, 2.0, 0.0])'
ruby 2.0.0p648 (2015-12-16 revision 53162) [universal.x86_64-darwin15.3.0]
true
```
Is your matrix library th... -
05:18 PM Bug #12897 (Rejected): Hash failed to recognize the existed key and send not found when using Vector as key
- This is not a bug. `Hash#[]` uses `eql?` and not `==` to match keys.
0 == 0.0 # => true
0.eql? 0.0 # => false
{0 => 42}[0.0] # => nil
{0.0 => 42}[0.0] # => 42 -
08:52 AM Bug #12897: Hash failed to recognize the existed key and send not found when using Vector as key
- also affected version ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux].
-
08:11 AM Bug #12897 (Rejected): Hash failed to recognize the existed key and send not found when using Vector as key
- When I was using Vector as the key to the Hash, Hash sometimes failed to recognize the key and send nil, while the key-value pair actually existed.
Example as followed:
irb(main):002:0> require"matrix"
=> true
irb(main):003:0> Ve... -
10:42 PM Feature #12515: Create "Boolean" superclass of TrueClass / FalseClass
- Samuel Williams wrote:
>
> ...
It's just one of the issues, but it's the one backed by the same numbers you seem to think are the be-all and end-all. Anyone can munge code to not conflict with existing implementations. (`Kernel::Boole... -
07:27 PM Feature #12515: Create "Boolean" superclass of TrueClass / FalseClass
- Just a side question:
Samuel Williams wrote:
> class Kernel::Boolean
> ...
Why do you use Kernel::Boolean and not just Boolean?
-
12:37 PM Feature #12515: Create "Boolean" superclass of TrueClass / FalseClass
- Matthew, I ask you to find one of those examples that would break by introducing the following to core Ruby:
~~~
if $VERBOSE and defined? Boolean
warn "Top level Boolean is deprecated, please update your code"
end
class Kern... -
10:37 PM Bug #12899 (Closed): OptParse documentation : example is broken
-
09:45 AM Bug #12899 (Closed): OptParse documentation : example is broken
- Hello,
The complete example code in OptParse documentation at http://ruby-doc.org/stdlib-2.3.1/libdoc/optparse/rdoc/OptParse.html#class-OptParse-label-Complete+example does not run at all.
There are several problems in this code. c... -
10:03 PM Feature #12142: Hash tables with open addressing
- I've uploaded refined mbox patch:
https://bugs.ruby-lang.org/attachments/download/6225/st_table_array.mbox
Corresponding github branch:
https://github.com/funny-falcon/ruby/commits/st_table_with_array5
It almost the same version Vl... -
09:28 PM Feature #12142: Hash tables with open addressing
- Vladimir Makarov wrote:
> Koichi's investigation reported that small hash tables are majority during
> ...
-
09:23 PM Feature #12142: Hash tables with open addressing
- Koichi's investigation reported that small hash tables are majority during
work of Ruby on Rails:
https://gist.github.com/ko1/dda8243134bc40f7fc05e293abc5f4b2#file-report-md
Memory footprint of cloud applications like Ruby on Rail... -
07:06 AM Feature #12142: Hash tables with open addressing
- Vladimir is right.
Despite all my believes, I suggest again to concentrate on open-addressing variants.
I'll prepare new mbox with last changes accurately squashed into right commits and further simplified code.
I'll remove my p... -
02:37 AM Feature #12142: Hash tables with open addressing
- To decrease sizes of very small tables I tuned some parameters. Now minimal table size is 4 (instead of 8) and bins starts with 16 (instead of 8):
https://github.com/vnmakarov/ruby/commit/f4d2bf3ab78e59118e5dd89bcc5c3d8c4371ed35
I... -
09:23 PM Bug #12890: Net::HTTP should treat unexpected 1XX responses as non-final.
- A testing endpoint is available at https://nghttp2.org/?103-eh (see https://lists.w3.org/Archives/Public/ietf-http-wg/2016OctDec/0408.html).
-
07:28 PM Feature #12902: How about Enumerable#sum uses initial value rather than 0 as default?
- In https://bugs.ruby-lang.org/issues/12217#note-3, Akira Tanaka, mentions that the default argument to sum is 0. This creates problems with non-numeric summations (e.g. strings). I would like to suggest using the first enumerable value. ...
-
07:24 PM Feature #12902 (Rejected): How about Enumerable#sum uses initial value rather than 0 as default?
- In https://bugs.ruby-lang.org/issues/12217#note-3, Akira Tanaka, mentions that the default argument to sum is 0. This creates problems with non-numeric summations (e.g. strings). This would make the method more flexible. It also makes it...
-
06:03 PM Bug #12900: TestSyntax#test_block_after_cmdarg_in_paren fails on PPC64
- The same error is observed on sparc64-solaris2.10, running on 64-bit big-endian CPU.
-
05:06 PM Bug #12900: TestSyntax#test_block_after_cmdarg_in_paren fails on PPC64
- It actually passes on PPC64LE. Isn't it something related to different endianness of PPC64?
-
04:41 PM Bug #12900 (Closed): TestSyntax#test_block_after_cmdarg_in_paren fails on PPC64
- Trying to build r56558 on Fedora Rawhide, the build fails on PPC64 with following message:
```
1) Failure:
TestSyntax#test_block_after_cmdarg_in_paren [/builddir/build/BUILD/ruby-2.4.0-r56558/test/ruby/test_syntax.rb:897]:
[ruby-... -
06:01 PM Feature #12901: Anonymous functions without scope lookup overhead
- Much +1 for this feature, I used anonymous functions extensively in graphql-ruby until I learned about this overhead. We still have lots of APIs where the user input is a callable, and I would love to be able to advise procs in those cas...
-
05:30 PM Feature #12901: Anonymous functions without scope lookup overhead
- It would probably be better if ruby could do analysis and if there are no references to local variables in the outer scope(s), automatically optimize such procs, so that you don't need to specify `scope: false`. I believe JRuby already ...
-
04:54 PM Feature #12901 (Open): Anonymous functions without scope lookup overhead
- Right now if you are writing performance sensitive code you can get a performance bump by not using anonymous functions (procs, lambdas, blocks) due to the scope lookup overhead.
https://twitter.com/apotonick/status/791167782532493312... -
06:01 PM Feature #12236: Introduce `mmap` managed heap
- Yura Sokolov wrote:
> > I believe we don't have any drawback with 256MB virtual memory allocation. (but it can depend on OSs)
> ...
Well, as long as your Ruby process never actually needs more than 64MB of memory, that's not a problem,... -
05:15 PM Bug #12666: Fatal error: glibc detected an invalid stdio handle
- For both BSD and Linux, I want to suggest
~~~ ruby
when /bsd|dragonfly|linux/
libc_so = "libc.so"
libm_so = "libm.so"
~~~
Works for me on OpenBSD:
~~~
$ make test-all TESTS=fiddle
...
# Running tests:
Finished test... -
03:57 PM Bug #12666: Fatal error: glibc detected an invalid stdio handle
- Ping ... any chance to get this fixed? PPC was recently added into primary Fedora builder, so this is troublesome :/ Also, it will make issues to Fedora PPC users as soon as Fedora 25 is release, which should be next Tuesday if I am not ...
-
11:57 AM Bug #12780: BigDecimal#round returns different types depending on argument
- We need matz's approval to change `Float#round`.
-
07:31 AM Bug #12780: BigDecimal#round returns different types depending on argument
- Good point, I didn't catch that. If it was up to me I'd rather have `Float#round` always return `Float` as well for consistency. I could work on a patch for that too if you agree.
-
05:03 AM Bug #12780: BigDecimal#round returns different types depending on argument
- `Float#round` returns Fixnum value when the argument is `0` or omitted.
```
irb(main):005:0> 12.34.round.class
=> Fixnum
irb(main):006:0> 12.34.round(0).class
=> Fixnum
```
If we will fix `BigDecimal#round`, we should change t... -
11:20 AM Feature #12898: String#match? method in addition to Regexp#match?
- Shyouhei Urabe wrote:
> You mean a String instance method named "match?" that takes a Regexp instance?
Yes, exactly. The methods to match a string with a regexp (or vice versa) are present in both classes:
`Regexp#=~` and `String#... -
08:50 AM Feature #12898: String#match? method in addition to Regexp#match?
- Stefan Schüßler wrote:
> Ruby 2.4 introduces [`Regexp#match?`](https://bugs.ruby-lang.org/issues/8110). There should be an accompanying `String#match?` method.
Can you be a bit more verbose here? You mean a String instance method na... -
08:44 AM Feature #12898 (Closed): String#match? method in addition to Regexp#match?
- Ruby 2.4 introduces [`Regexp#match?`](https://bugs.ruby-lang.org/issues/8110). There should be an accompanying `String#match?` method.
-
10:27 AM Bug #12670: Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- Koichi Sasada wrote:
> I commit a fix on trunk. Could you check it?
Seems nothing changed. Errors looks like same
ruby -v
ruby 2.4.0dev (2016-11-04 trunk 56558) [x86_64-linux]
Attached a terminal output file. -
08:57 AM Bug #12670 (Feedback): Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- I commit a fix on trunk. Could you check it?
-
08:54 AM Bug #12670 (Closed): Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- Applied in changeset r56558.
----------
* gc.c (heap_page_resurrect): do not return tomb_pages when
page->freelist == NULL.
[Bug #12670] -
08:54 AM Revision 0b8ab5b0 (git): * gc.c (heap_page_resurrect): do not return tomb_pages when
- page->freelist == NULL.
[Bug #12670]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56558 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:33 AM Bug #12705: yielding args to a lambda uses block/proc rather than lambda/method semantics
- This is working memo. Now I can't find out the solution.
(1) auto splat for lambda with `yield ary` is allowed [Bug #9605]. So #4 is intentional change.
(2) However, lambda generated by Method#to_proc is not allowed (reported by this... -
07:31 AM Bug #12889 (Closed): Regression of Ruby 2.4.preview2 string interpolation
- Applied in changeset r56557.
----------
util.c: round to even
* util.c (ruby_dtoa): round to even, instead of rounding to
nearest. [ruby-core:77864] [Bug #12889] -
07:31 AM Revision 6ed8c79d (git): util.c: round to even
- * util.c (ruby_dtoa): round to even, instead of rounding to
nearest. [ruby-core:77864] [Bug #12889]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56557 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:37 AM Feature #12896 (Closed): Add compiler version message into rbconfig
- Applied in changeset r56556.
----------
* configure.in: Add compiler version message into rbconfig
as RbConfig::CONFIG['CC_VERSION_MESSAGE']. [Feature #12896] -
06:30 AM Feature #12896 (Closed): Add compiler version message into rbconfig
- When a extension library developer receives bug reports, they sometimes want to know what compiler is used for building the ruby binary.
We can already know its compiler option but cannot know compiler name and version.
```diff
diff... -
06:37 AM Revision 25728a19 (git): * configure.in: Add compiler version message into rbconfig
- as RbConfig::CONFIG['CC_VERSION_MESSAGE']. [Feature #12896]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56556 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:18 AM Bug #12718 (Closed): BigDecimal() should raise on invalid input, consistent with Integer() and Float()
- Close this because it duplicates #10286
-
05:10 AM Bug #12895 (Closed): Backport r53533
- r53533をバックポートしてください。
-
04:29 AM Bug #12815 (Closed): Integer#digits's error message different when base is Fixnum or Bignum
- I've fixed this on r56554
- 04:29 AM Revision b7c93a3c (git): ChangeLog: cite issue on redmine
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56555 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:12 AM Bug #12894 (Third Party's Issue): Seems to be some issue with sqlite3
-
03:54 AM Bug #12894 (Third Party's Issue): Seems to be some issue with sqlite3
- Trying to run the console, but I get a massive error.
I think I should see development.sqlite3 and text.sqlite3 in my /db folder, but they're not there.
I'm attaching the bug report. - 04:05 AM Revision 95e9ccbb (git): numeric.c (rb_int_digits): Fix exception message
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56554 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:51 AM Revision e4257036 (git): pathname.c: unnormalized Fixnum value
- * ext/pathname/pathname.c (path_hash): fix unnormalized Fixnum
value bug on mingw/mswin.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56553 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:35 AM Bug #12892 (Closed): FileUtils::cp_r() raises RuntimeError "unknown file type" instead of Errno::ENOENT "No such file or directory" for non-existent source path
- Applied in changeset r56551.
----------
fileutils.rb: fix error for non-existent entry
* lib/fileutils.rb (FileUtils::Entry_#copy): ensure that the
source entry exists first, to fix error for non-existent entry.
[ruby-core:77885] [... - 01:35 AM Revision 61982b15 (git): * 2016-11-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56552 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:35 AM Revision 0785b3e1 (git): fileutils.rb: fix error for non-existent entry
- * lib/fileutils.rb (FileUtils::Entry_#copy): ensure that the
source entry exists first, to fix error for non-existent entry.
[ruby-core:77885] [Bug #12892]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56551 b2dd03c8-39d4-4d8f-9...
11/03/2016
-
06:52 PM Bug #12893: trunk fails on linux with clang on test with callcc
- Other segfault on `TestMarshal#test_gc`
~~~
$ make test-all TESTS='-n !/callcc/' # and I edited test/ruby/test_continuation.rb to no-op
CC = clang
LD = ld
LDSHARED = clang -shared
CFLAGS = -O3 -fno... -
06:30 PM Bug #12893 (Closed): trunk fails on linux with clang on test with callcc
- Test fails on linux with clang.
It doesn't fails with gcc.
OS: Ubuntu 16.04 x64_64
clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)
configure: `../configure CC=clang CXX=clang++`
test:
$ make test-all TESTS='-n /callcc/'
... -
06:24 PM Feature #12142: Hash tables with open addressing
- Koichi,
HUGE makes difference for `st_table_entry` only for version with chaining.
Version with open addressing has same `st_table_entry` regardless of HUGE.
It differs only in sizeof `st_table`.
You had tested this version wit... -
03:01 PM Feature #12142: Hash tables with open addressing
- My assumption is HUGE enables to extend 64bits entries and HUGE entries
are increase constantly. And table size should be proportion of entry
count. However st_memsize() returns only constant difference compare
with HUGE=0.
So I a... -
02:16 PM Feature #12142: Hash tables with open addressing
- Well, chaining is not faster with HUGE=1. It is only faster with HUGE=0.
-
01:51 PM Feature #12142: Hash tables with open addressing
- Koichi,
Here is patch that returns chaining in my implementation.
It is smaller than I expected :-)
https://bugs.ruby-lang.org/attachments/download/6212/return-chaining-into-implementation.patch
(it is applied after last additi... -
11:26 AM Feature #12142: Hash tables with open addressing
- Yura Sokolov wrote:
> Vladimir:
> ...
To be honest I am not glad. I am working on RTL VM insns and JIT and it is a big distraction for me.
Instead of accepting one (original) variant and then improving it (as I proposed yesterday),... -
08:45 AM Feature #12142: Hash tables with open addressing
- Koichi,
Difference between HUGE=0 and HUGE=1 is small and constant cause they
differs only in header ( `struct st_table` ).
HUGE=1 has 48 byte header and HUGE=0 has 32 byte header.
Difference were larger when "chaining" were used... -
03:46 AM Feature #12142: Hash tables with open addressing
- As small table size seems so important now, I did some small changes to my branch to decrease it.
https://github.com/vnmakarov/ruby/commit/a99e4e0e929af225c2b7475fa6b492e989bc3b07
Before the change, my code maintained 4:1 ratio of ... -
01:23 AM Feature #12142: Hash tables with open addressing
- Yura:
Could you check that there are no memory usage (`st_memsize()`) between HUGE=0 and HUGE=1.
Is it reasonable?
Here is a raw data <https://gist.github.com/ko1/dda8243134bc40f7fc05e293abc5f4b2#file-size-csv>. -
01:21 AM Feature #12142: Hash tables with open addressing
- Thank you. This is very interesting, informative and educational. Good
look with getting your patch accepted.
On 11/02/2016 06:41 PM, [email protected] wrote:
> Issue #12142 has been updated by Yura Sokolov.
>
> File hash... -
12:35 AM Feature #12142: Hash tables with open addressing
- Koichi, thank you for investigation.
Your graphs give a lot of useful information.
Expected behaviour:
- memory usage is lesser with my patch
(cause it has more reallocation steps, and smaller header)
- performance of huge table... -
04:20 PM Feature #12886: URI#merge doesn't handle paths correctly
- Samuel Williams wrote:
> I feel like this should work.
Feelings are not enough. As Matthew already said, https://tools.ietf.org/html/rfc3986.html#section-5.2 doesn't define this. I can see at least the following problems:
1) Based... - 12:46 PM Revision 03c9bc2b (git): Import from ruby/bigdecimal repository
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56550 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:21 AM Bug #12892 (Closed): FileUtils::cp_r() raises RuntimeError "unknown file type" instead of Errno::ENOENT "No such file or directory" for non-existent source path
- In Ruby 1.9.3 both FileUtils.cp(src, dst) and FileUtils.cp_r(src, dst) raised Errno::ENOENT "No such file or directory" for a non-existent src path (which is correct behaviour imho).
At least since Ruby 2.1.0 FileUtils.cp_r(src, dst) ... -
08:26 AM Bug #12890: Net::HTTP should treat unexpected 1XX responses as non-final.
- Apologies, it was noted that it would be more helpful to provide the example server in Ruby instead:
~~~ ruby
require 'socket'
server = TCPServer.new 8080
loop do
client = server.accept
client.puts "HTTP/1.1 103 Ear... -
08:07 AM Bug #12891: armv7l-linux-eabihf/openssl.so: [BUG] Illegal instruction at 0xb6659cfc
- Nobuyoshi Nakada wrote:
> Can't you reproduce it with `gdb` and get the stack trace?
If you could give me a hint on how to do that I certainly could.
-
03:23 AM Bug #12891 (Feedback): armv7l-linux-eabihf/openssl.so: [BUG] Illegal instruction at 0xb6659cfc
- Can't you reproduce it with `gdb` and get the stack trace?
> ```
> ...
Seems failing inside libcrypto.so.
-
06:46 AM Feature #12515: Create "Boolean" superclass of TrueClass / FalseClass
- Samuel Williams wrote:
> [...] But what evidence do you have to support NOT adding Boolean? I can't think of any good reason why you shouldn't add it.
Ignoring most of the "bad" reasons in this thread, how about reiterating this one:... -
06:14 AM Feature #12515: Create "Boolean" superclass of TrueClass / FalseClass
- Matz has explained the reasons.
-
04:23 AM Feature #12515: Create "Boolean" superclass of TrueClass / FalseClass
- > It seems specific to the context, and should be defined there.
Yeah but it's not. 2,080,658 instances of code on GitHub disagree with you. It's not my personal opinion, it's tangible evidence. But what evidence do you have to suppor... -
06:02 AM Revision 6c7024f6 (git): file.c: include sys/sysmacros.h
- * file.c: include sys/sysmacros.h for ArchLinux which deprecated
use of major() and minor() in sys/types.h.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56549 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:46 AM Revision f0baa122 (git): * 2016-11-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56548 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:46 AM Revision 91fbf2b2 (git): file.c: use DEVT2NUM
- * file.c (rb_stat_dev_major, rb_stat_dev_minor): use DEVT2NUM as
well as rdev_major and rdev_minor.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56547 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:53 AM Feature #12747: Add TracePoint#callee_id
- Sorry for late response.
I missed incompatibility.
How about to commit it before next preview and ask feedback from users?
Thansk,
Koichi
11/02/2016
-
10:03 PM Bug #12890: Net::HTTP should treat unexpected 1XX responses as non-final.
- I believe the fix is relatively simple; the main change is to `lib/net/http.rb`:
~~~diff
--- a/lib/net/http.rb
+++ b/lib/net/http.rb
@@ -1439,7 +1439,7 @@ def transport_request(req)
begin
res = HTTPRespons... -
08:58 PM Bug #12890 (Closed): Net::HTTP should treat unexpected 1XX responses as non-final.
- Long story short
Net::HTTP's client does not tolerate non-100 status codes from the 1XX block in a sensible manner: it treats them as final responses, rather than as provisional ones.
Expected behaviour
When Net::HTTP receives... -
09:39 PM Bug #12891 (Closed): armv7l-linux-eabihf/openssl.so: [BUG] Illegal instruction at 0xb6659cfc
- While installing GitLab on my Raspberry 2, at the end I'm executing the command: `sudo gitlab-ctl reconfigure`
This leads to the reported bug. The complete error message is as follows:
```
/opt/gitlab/embedded/lib/ruby/2.3.0/armv7... -
04:45 PM Feature #12142: Hash tables with open addressing
- Koichi Sasada wrote:
> Sorry for my lazy-ness, I evaluated your two implementations (ffalcon has two versions, HUGEHASH or not).
> ...
Koichi, thank you for your detail investigation of the two tables. Looking
at this report, I got a... -
09:28 AM Feature #12142: Hash tables with open addressing
- Sorry for my lazy-ness, I evaluated your two implementations (ffalcon has two versions, HUGEHASH or not).
Now, I depicted all of my evaluations in charts, so I introduce this report: <https://gist.github.com/ko1/dda8243134bc40f7fc05e2... -
03:38 PM Bug #12889 (Closed): Regression of Ruby 2.4.preview2 string interpolation
- ~~~
$ ./ruby -v
ruby 2.4.0dev (2016-07-10 trunk 55620) [x86_64-linux]
$ ./ruby -e 'puts ("%01.0f" % 1234567892.0)'
1234567892
~~~
https://github.com/ruby/ruby/commit/295f60b94d5ff6551fab7c55e18d1ffa6a4cf7e3
~~~
$ ./ruby -v
r... -
03:21 PM Bug #12888 (Rejected): Require 'thread' crash on recent 2.2.x
- By just calling the Thread class, a ruby script or just IRB crash :
(French install)
LoadError: 127: La procédure spécifiée est introuvable. - Init_Thread
It works on ruby for windows 1.9.3-p327, 2.0.0-p353
It fails on ruby f... -
07:07 AM Feature #12760: Optional block argument for `itself`
- What about giving it an obvious name like `yield_self` and making a syntax sugar `object.{|x| ... }` for calling it like we do in Proc#call?
-
02:46 AM Feature #5446: at_fork callback API
- ping, any plans to add these apis, they will help clean up a lot in the Ruby ecosystem, just hit it again today.
I think what is really needed here is a conceptual Yes or No from Koichi or Matz -
01:31 AM Revision af015a9a (git): assertions.rb: assert_all_assertions
- * test/lib/test/unit/assertions.rb (assert_all_assertions): prefix
assert to be filtered out.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56546 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:50 AM Revision d97b8d0d (git): extension.rdoc: update rb_ensure description
- * doc/extension.rdoc: set ANYARGS as arguments for func1 and func2.
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56545 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/01/2016
-
11:45 PM Revision 564cb1a0 (git): extension.rdoc: update rb_rescue description
- * doc/extension.rdoc: set ANYARGS as arguments for func1 and func2.
* doc/extension.rdoc: mention the exception object which is passed
to func2 as the second argument. [Fix GH-1471]
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
10:34 PM Bug #12875 (Closed): Fixnum bit operator and coerce
- Applied in changeset r56543.
----------
numeric.c: bit op with non-integer
* numeric.c (rb_num_coerce_bit): enable bit operations with
coercing by non-integer object. [ruby-core:77783] [Bug #12875] -
10:34 PM Revision 13149a59 (git): numeric.c: bit op with non-integer
- * numeric.c (rb_num_coerce_bit): enable bit operations with
coercing by non-integer object. [ruby-core:77783] [Bug #12875]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56543 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:03 PM Bug #8004: spawn does not honor its passed PATH
- On my computer, the reason for this is:
It should have found the path here: https://github.com/ruby/ruby/blob/c7e99cbfc8dea00ffa5d0a286ea484e90e789df4/process.c#L2193
But notice the second argument, 0, which causes `dln_find_exe_r`... -
08:29 PM Bug #12832: Calling Object#method hangs for private method defined on module then made public once it's been used to extend class
- @George: Thanks for explaining. Makes sense.
-
08:10 PM Bug #12832: Calling Object#method hangs for private method defined on module then made public once it's been used to extend class
- Ruby defers signals. At safe moments, Ruby checks if a signal arrived, then handles it. If Ruby is stuck in an infinite loop (because of a bug like this one), then Ruby would never check if a signal arrived, so the signal would be ignore...
-
12:33 PM Bug #12832: Calling Object#method hangs for private method defined on module then made public once it's been used to extend class
- @nobu: Is it possible there is a separate problem with the code such that interrupt signals are incorrectly being ignored...?
-
11:45 AM Bug #12832: Calling Object#method hangs for private method defined on module then made public once it's been used to extend class
- It's not expected but a bug is always what causes unexpected behavior.
-
09:34 AM Bug #12832: Calling Object#method hangs for private method defined on module then made public once it's been used to extend class
- @nobu: Thank you for fixing this. Is it expected that a bug like this would cause the interpreter not to accept interrupt signals?
- 03:47 PM Revision c7e99cbf (git): * 2016-11-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56542 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:47 PM Revision fa857bc6 (git): fix some typos [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56541 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:56 PM Feature #12515: Create "Boolean" superclass of TrueClass / FalseClass
- Nobuyoshi Nakada wrote:
> Rodrigo Rosenfeld Rosas wrote:
> ...
This doesn't seem to work as I just tested in irb: [true, false] === true => false -
02:59 AM Feature #12515: Create "Boolean" superclass of TrueClass / FalseClass
- Samuel Williams wrote:
> > It's a choice by that library author. They are not classes but methods, there can be `Boolean` method in the library.
> ...
It seems specific to the context, and should be defined there.
-
01:51 AM Feature #12515: Create "Boolean" superclass of TrueClass / FalseClass
- Rodrigo Rosenfeld Rosas wrote:
> Maybe something like:
```ruby
Boolean = [true, false]
```
> ...
-
12:04 AM Feature #12515: Create "Boolean" superclass of TrueClass / FalseClass
- Joel on Software "Don't Let Architecture Astronauts Scare You" by Joel
Spolsky http://www.joelonsoftware.com/articles/fog0000000018.html
-
12:01 AM Feature #12515: Create "Boolean" superclass of TrueClass / FalseClass
- Rodrigo Rosenfeld Rosas wrote:
> I'd just like to add a real situation where I missed a `Boolean` class recently.
> ...
There's a potential religious argument here about validating against the schema before/after deserialising. Pragmat... -
01:10 PM Revision 544e59ec (git): test_integer.rb: common parts
- * test/ruby/test_integer.rb (MimicInteger, CoercionToInt): extract
common parts.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56540 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:10 PM Revision 69fc155c (git): numeric.c: use rb_num_coerce_bit
- * numeric.c (int_and, int_or, int_xor): use rb_num_coerce_bit to
reduce repeated code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56539 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:48 PM Bug #12887 (Closed): Object#extendを引数無しで呼び出すとErrorとなるが、Module#includeとModule#prependはエラーとならない
- Object#extend を引数無しで呼び出すと、ArgumentErrorとなります。 https://bugs.ruby-lang.org/issues/6085
~~~
$ ruby -e 'Module.new { extend }'
-e:1:in `extend': wrong number of arguments (given 0, expected 1+) (ArgumentError)
from -e:1:in `block in <... -
12:41 PM Bug #10802 (Closed): strict-aliasing warning on RHEL/CentOS 6
- Fixed by r55831 and r55833. Backport requested in #12657.
-
12:38 PM Bug #12657: [PATCH] ANSI aliasing fix for XL compiler
- I checked that the patches fix the warnings in Ruby 2.2. BTW r55833 is required alongside of r55831
-
12:35 PM Revision cbfe54c5 (git): numeric.c: fix return value on big 0
- * numeric.c (num_zero_p): should return true if zero.
rb_bigzero_p returns 1 or 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56538 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:35 PM Revision 22e41718 (git): numeric.c: adjust indent [ci skip]
- * numeric.c (rb_num2ulong_internal): adjust indent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56537 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:35 PM Revision 5dc24720 (git): numeric.c: fix typos [ci skip]
- * numeric.c (rb_num2ulong_internal, rb_num2ull): fix typos in
comments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56536 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:51 AM Revision 8baad2d3 (git): bignum.c: use RB_INTEGER_TYPE_P
- * bignum.c (rb_big_and, rb_big_or, rb_big_xor): use dedicated
macro RB_INTEGER_TYPE_P instead of combination of FIXNUM_P and
RB_BIGNUM_TYPE_P.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56535 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:44 AM Bug #10222: require_relative and require should be compatible with each other when symlinks are used
- Today I learned that [PHP caches realpath](http://jpauli.github.io/2014/06/30/realpath-cache.html), and causes troubles when people use symlink to deploy scripts.
The situation is not exactly the identical to ours, but we should avoid...