Activity
From 11/27/2016 to 12/03/2016
12/03/2016
- 03:41 PM Revision 1fa8bd75 (git): * 2016-12-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:41 PM Revision 071d3ae3 (git): Use IPv6 if it's preferred.
- I hope this fix makes tests faster on Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56973 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:18 PM Revision d95f5bc8 (git): string.c: chomp option
- * string.c (rb_str_enumerate_lines): implement chomp option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:40 PM Feature #12747: Add TracePoint#callee_id
- Thanks Yamaguchi-san, good catch.
I'll revert rb_frame_method_id_and_class.
-
08:50 AM Feature #12747: Add TracePoint#callee_id
- r56593 changed the signature of rb_frame_method_id_and_class() which is exposed to C extensions. For example, this broke ruby-prof gem. Is this intentional?
-
-
11:24 AM Misc #10756 (Rejected): Add spaces between args
- I think this is duplicated of #12977.
And this patch cannot apply now. -
-
- Always add a space between a comma and the next element. These spaces
were there sometimes, but not always. This keeps to code consistent.
Patch by: Herwin Weststrate <[email protected]>
[ruby-core:78297] [Misc #12977] [GH-1492]
g... -
- * ext/stringio/stringio.c (strio_getline): implement chomp option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56970 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/stringio/test_stringio.rb (test_gets, test_each):
assertions for paragraph mode.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:18 AM Revision 0d2a4cc5 (git): add tests againts regressions for upcoming codepoint reordering in unfolding table
- * test/ruby/enc/test_case_mapping.rb: Add method test_reorder_unfold to test against
problems when reordering codepoints in some entries in
CaseUnfold_11_Type CaseUnfold_11_Table.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56... - 05:09 AM Revision fc410343 (git): * 2016-12-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/enc/test_case_comprehensive.rb: Change test class name from
TestComprehensiveCaseFold to TestComprehensiveCaseMapping because the
tests are about mapping in general, not only folding
git-svn-id: svn+ssh://ci.ruby-lang.or... -
-
- In r56965, load_lock() was changed as follows:
```
switch (rb_thread_shield_wait((VALUE)data)) {
case Qfalse:
data = (st_data_t)ftptr;
st_insert(loading_tbl, data, (st_data_t)rb_thread_shield_new());
...
12/02/2016
-
09:23 PM Feature #13001 (Closed): Add `full` option to `ObjectSpace.dump_all`
- I would like to include T_NONE slots in the `ObjectSpace.dump_all` outpout so that I can visualize heap fragmentation. I've attached a patch that adds a "full" option to `dump_all` so that all slots are dumped to the JSON output, includ...
-
04:25 PM Feature #13000 (Feedback): Implement Set#include? with Hash#include?
- Why does `Set#include?` not call `Hash#include?`? Currently it calls `Hash#[]`.
The protocol of Set already use `Hash#include?` for `==`.
```diff
diff --git a/lib/set.rb b/lib/set.rb
index 43c388c..f3dbe2d 100644
--- a/lib/set.r... -
03:34 PM Bug #12507: random SEGV in kernel.system when called with long parametre list
- The issue can be reproduced with old trunk, r45357 ... r51492.
So I think it is a GC issue of ALLOCV_N, similar to [Bug #11418]. -
- Yuki Kurihara wrote:
> ## Important point
> ...
Use alias.
```C
rb_define_alias(rb_cRange, "===", "include?");
```
instead of
```C
rb_define_method(rb_cRange, "===", range_include, 1);
```
-
05:09 AM Feature #12996 (Closed): Optimize Range#===
- The proposal is that Range#=== optimize by reducing method calls.
## Benchmark
~~~shell
$ cat t.rb
i = 0
while i < 1_000_000
case i
when 1..1000
end
i += 1
end
~~~
~~~
$ time ./miniruby -e 1
./miniruby -e 1 0... -
- TestRequire#test_require_with_loaded_features_pop fails by increasing the number of threads,
so it seems that there still exist race conditions in require.
```
lexington:ruby$ cat t/require_test.rb
require "tempfile"
Tempfile.cr... -
- With this lines.rb:
```ruby
lines = "abc\n\n\n\ndef\n"
p IO.pipe{|r,w|w.print lines; w.close; r.each_line("").to_a}
p lines.each_line("").to_a
```
```
$ ./ruby -v lines.rb
ruby 2.4.0dev (2016-12-02 trunk 56965) [x86_64-darwin15... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Valgrind reports out-of-bounds memory access while creating a Regexp object with an invalid byte sequence:
~~~
$ valgrind ruby -e'Regexp.new("\\\xD3\xD5\xBE\x1E+".force_encoding("euc-jp"))'
==21986== Memcheck, a memory error detecto... -
- * parse.y (parser_tokadd_codepoint): move error checks and add
char.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56964 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parser_tokadd_utf8): relax restriction spaces inside
"\u{...}".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56963 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Don't discard the hash value computed for the regexp object. It seems it
was simply missed out in r24754, when MatchData#hash was initially
implemented.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56962 b2dd03c8-39d4-4d8f-98ff-823...
12/01/2016
- 05:43 PM Revision cf3ff02e (git): * 2016-12-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:43 PM Revision 7e1b5d8d (git): Remove unused variable
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56960 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:05 PM Feature #12871: Using the algorithm like math.fsum of Python for Array#sum
- Julia can do it, too.
~~~
julia> sum_kbn([1.0e10, 1.0e-10, -1.0e10])
1.0e-10
~~~
The source code is https://github.com/JuliaLang/julia/blob/master/base/reduce.jl .
-
- A quick hack.
* Elongation (or reallocation) of the array of partials[] when nn exeeds NUM_PARTIALS.
* Tests.
* Name of this algorithm. Kahan-Babuska-Neumaier?
are required.
~~~ diff
diff --git a/array.c b/array.c
index b99a... -
02:49 PM Feature #10118: Double splat for non-symbol keys
- It would be beneficial if one could do:
my_method(**hash_with_string_keys)
This for example you can read a hash from MongoDB and pass it as parameters to your method without additional processing. For example to implement per... -
- Applied in changeset r56959.
----------
String#unpack1 [Feature #12752]
Returns the first value of String#unpack. -
- Akinori MUSHA wrote:
> With a qualifier or multiple directives given, would it raise an ArgumentError or just go ahead with the process and only return the first value?
Just after processing the first value, it returns. -
10:25 AM Feature #12752: Unpacking a value from a binary requires additional '.first'
- With a qualifier or multiple directives given, would it raise an ArgumentError or just go ahead with the process and only return the first value?
-
09:52 AM Feature #12752: Unpacking a value from a binary requires additional '.first'
- Go ahead.
Matz.
-
- Returns the first value of String#unpack.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56959 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:12 PM Feature #12921: Retrieve user and password for proxy from env
- Motohiro KOSAKI wrote:
> Modern OS don't have such mistake.
I can't make it sure but if environment variables are in fact kept secure for all platforms that run ruby, then I'm happy to withdraw my concern about security in ENV['http... -
12:41 PM Feature #12921: Retrieve user and password for proxy from env
- > Yuri Samoilenko wrote:
>> What do you mean when say "insecure"? Storing login and password in filesystem and then read it and pass to http request manually is secure? Insecure is availability to pass login/password in plain form like... - 01:20 PM Revision b6e137e9 (git): Remove `offset:` from `Array#pack`
- * pack.c (pack_pack): can use `@` instead of `offset:`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56958 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:08 PM Feature #12754 (Closed): Want to use prepared buffer with `Array#pack`
- Applied in changeset r56957.
----------
Supports `buffer` and `offset` in `Array#pack`
* pack.c (pack_pack): Supports `buffer` and `offset` in `Array#pack`.
[Feature #12754] [ruby-dev:49798] - 01:08 PM Revision 0dd9c302 (git): Supports `buffer` and `offset` in `Array#pack`
- * pack.c (pack_pack): Supports `buffer` and `offset` in `Array#pack`.
[Feature #12754] [ruby-dev:49798]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:15 PM Feature #12995: Conditional expression taking a receiver outside the condition
- You can do that with #tap. A very stupid example:
```ruby
array = [true]
res = array.to_a.tap do |obj|
if obj[0]
obj.replace([['true', :val]])
else
obj.replace([['false', :val]])
end
end.to_a.to_h
p res
```
... -
07:00 AM Feature #12995 (Rejected): Conditional expression taking a receiver outside the condition
- Since a conditional expression has a return value, we can continue a method chain after a conditional expression like this:
```ruby
if hoge
foo1.foo2.foo3
else
bar1.bar2
end
.baz1.baz2.baz3.baz4
```
```ruby
case hoge
w... -
- Shugo Maeda wrote:
> IBM InfoSphere and MS FoxPro have BITTEST(), but its second argument is the bit position
> ...
I didn't mean to propose this behavior.
I just meant to point out that `bittest?` may not be suitable for the proposed... -
- Yui NARUSE wrote:
> Herwin W wrote:
> ...
IBM InfoSphere and MS FoxPro have BITTEST(), but its second argument is the bit position
to be tested.
http://www.ibm.com/support/knowledgecenter/SSZJPZ_11.3.0/com.ibm.swg.im.iis.ds.basic.d... -
- Herwin W wrote:
> ```ruby
> ...
Above one.
> > There's two AND, bitwise and logical.
> ...
I can't show a use case of `|`.
`^` is maybe useful but the name is difficult. -
- * parse.y (parser_tokadd_codepoint): reject invalid codepoint,
surrogate blocks and surrogate pair, as well as mruby.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56956 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:24 AM Revision df53b142 (git): Update bundled_gems
- * minitest-5.10.0
* test-unit-3.2.3
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56955 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Because RubyCI on Solaris 10 failed as follows:
1) Failure:
TestProcess#test_execopts_redirect_open_fifo_interrupt_raise [/export/home/rubyci/unstable10s/tmp/build/20161130T201909Z/ruby/test/ruby/test_process.rb:646]:
<"ok\n"> e... -
- Import the following two commits from upstream:
commit 72126d6c8b88abd69c3565fc3bbbd5ed1e401611
Author: Kazuki Yamaguchi <[email protected]>
Date: Thu Dec 1 22:27:03 2016 +0900
pkey: check existence of EVP_PKEY_get0()
EVP_P... -
03:55 AM Feature #12901: Anonymous functions without scope lookup overhead
- It would also be very useful for making ObjectSpace#define_finalizer easier to use (to avoid the common memory leak passing a regular proc in can cause).
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/30/2016
-
- Applied in changeset r56949.
----------
Regexp supports Unicoe 9.0.0's \X
* meta character \X matches Unicode 9.0.0 characters with some workarounds
for UTR #51 Unicode Emoji, Version 4.0 emoji zwj sequences.
[Feature #12831] [ruby... - 05:29 PM Revision 48beedd5 (git): * 2016-12-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56950 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * meta character \X matches Unicode 9.0.0 characters with some workarounds
for UTR #51 Unicode Emoji, Version 4.0 emoji zwj sequences.
[Feature #12831] [ruby-core:77586]
The term "character" can have many meanings bytes, codepoints,... -
03:58 PM Feature #12906: do/end blocks work with ensure/rescue/else
- Checking that I submitted this correctly, I usually do Github, so might have gotten this wrong.
-
- I don't know what is "an ruby embedded engine".
But I can say that you have to call `rb_w32_sysinit` before calling `ruby_init` on Windows. -
03:38 PM Bug #12994 (Closed): Embedded ruby vs2015 build crashes
- When an embedded ruby engine in a vs2015 application is initialised using ruby_init the function set_pioinfo_extra in win32.c is not called.
This results in a crash when ruby_init is called and it is trying to derefence the __pioinfo po... -
03:18 PM Bug #12993: SEGV in OpenSSL::TestSSL#test_close_after_socket_close
- Actually, I thought the fix was applied in the package according to the OpenSSL changelog:
```
* Tue Nov 22 2016 Tomáš Mráz <[email protected]> 1.1.0c-2
- revert SSL_read() behavior change
- patch from upstream (#1394677)
- EC curv... -
- Imported at r56946.
-
- Not really a segfault but rb_sys_fail() is calling rb_bug() because errno is 0. OpenSSL 1.1.0c introduced a breaking change in SSL_read()[1], and it is already reverted in the OpenSSL-1_1_0-stable branch.
I have patched ruby/openssl[2... -
- r56693 used to build for me and now it fails, so this is apparently some change in Fedora Rawhide.
-
- Testing the latest version of Ruby from trunk on Fedora Rawhide, the OpenSSL::TestSSL#test_close_after_socket_close segfaults (see the attached log). Not sure what might be possible the reason, if it is some change in Fedora in Ruby.
... -
- * ext/openssl/ossl.c (ossl_pem_passwd_cb): cast to int. it's safe
because len does not exceed int max_len.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:46 PM Feature #12921: Retrieve user and password for proxy from env
- Shyouhei Urabe wrote:
> Yuri Samoilenko wrote:
> ...
Yuri Samoilenko said than it's operation system problem, if any users can read you env. Not ruby.
Anyway, http-proxy it's standart way set proxy and with auth too.
-
- Yuri Samoilenko wrote:
> What do you mean when say "insecure"? Storing login and password in filesystem and then read it and pass to http request manually is secure? Insecure is availability to pass login/password in plain form like "ht... -
08:08 AM Feature #12921: Retrieve user and password for proxy from env
- Shyouhei Urabe wrote:
> You have to understand that environment variables are in fact insecure. It is a very bad idea to store passwords there. Surprising or not, insecure is insecure. We shall not introduce this.
What do you mean... -
- * parse.y (parser_tokadd_utf8): refine error message at bad char
in unicode escape, "invalid" instead of "unterminated".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56947 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Import Ruby/OpenSSL 2.0.0. The full commit history since 2.0.0 beta.2
(imported at r56098) can be found at:
https://github.com/ruby/openssl/compare/v2.0.0.beta.2...v2.0.0
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56946 b2dd03... -
- rbinstall.rb couldn't load "psych/versions".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56945 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It fixed segmentation fault related with GC.
https://github.com/ruby/psych/pull/296
and removed deprecated code of Ruby 1.8.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parser_tokadd_codepoint): extract from
parser_tokadd_utf8.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parser_tokadd_utf8): make open/close braces constant.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56942 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thx for implementing this. ```--with-compress-debug-sections=no``` seems to disable the compression of debug sections.
-
- A short additional note: If cases like these increase with future versions of Unicode, I plan to change the special treatment of U+03B9/U+03BC/U+A64B to something more data-based.
-
- Applied in changeset r56941.
----------
fix uppercasing for U+A64B, CYRILLIC SMALL LETTER MONOGRAPH UK
* enc/unicode.c: Add U+A64B to the special cases 03B9 and 03BC
at the end of onigenc_unicode_case_map (Bug #12990).
* enc/unicode... -
- Just for the record, I think this is where the problem was introduced:
https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/55478/diff/test/ruby/enc/test_case_comprehensive.rb
That explains why almost all characters are ... -
- * enc/unicode.c: Add U+A64B to the special cases 03B9 and 03BC
at the end of onigenc_unicode_case_map (Bug #12990).
* enc/unicode/case-folding.rb: Add U+A64B to the special cases
03B9 and 03BC. Add a comment pointing to enc/unicode.... -
- Shyouhei Urabe wrote:
> The new default is called the "banker's round" for reasons. Money related people should prefer this.
We don't know to what extent such an argument applies around the world.
> ...
Definitely. But while we... -
- Jerome Cornet wrote:
> But does this mean that Float rounds in a different way as BigDecimal by default then ?
> ...
Correct. It is true that we fixed one inconsistency to introduce another. This might perhaps be a problem. Not sure... -
02:43 AM Bug #12958: Breaking change in how `#round` works
- > Am I making myself understood? I am distinguishing Floats and BigDecimals. We did not change how a BigDecimal rounds. Money related calculations should use that class instead. Not Float. Using Float for money is in fact toxic; for...
-
- Jerome Cornet wrote:
> Unfortunately there are many instances where money math requires floating point calculation, like taxes for example (discounts are also another source of float-related money math)
I would like to disagree.
I... -
- Unfortunately there are many instances where money math requires floating point calculation, like taxes for example (discounts are also another source of float-related money math)
Most jurisdictions that charge sales taxes specify rou... -
- Jerome Cornet wrote:
> Shyouhei Urabe wrote:
> ...
The new default is called the "banker's round" for reasons. Money related people should prefer this. And to say frankly, using Floats for money-related calculation is the source of w... -
- * parse.y (parser_yylex): do not warn parentheses of lambda
argument list, because there is no name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56940 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56939 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- You could close this issue by including `[Bug #12988]` in the commit message.
11/29/2016
-
08:59 PM Feature #12979: Avoid exception for #dup on Integer (and similar cases)
- Benoit Daloze wrote:
> `1.clone(freeze: false)` does not do what you say.
> ...
Oh wow. That's entirely my fault. I totally confused Ruby's dup/cloning with another language (and/or my imagination, haha).
Fortunately my point still... -
08:39 PM Feature #12979: Avoid exception for #dup on Integer (and similar cases)
- Mike Vastola wrote:
> Nobuyoshi Nakada wrote:
> ...
`1.clone(freeze: false)` does not do what you say.
The keyword :freeze has default value true for #clone, which means if the original object is frozen so will be the clone.
See #123... -
- Nobuyoshi Nakada wrote:
> Should `Kernel#clone` be same?
The original consensus was that the fix should be for both **`#dup`** and **`#clone`** to fail silently on immediate objects. The person who created this issue rendered **`#clo... -
- Integer (Fixnum) can dup now.
But Integer (Bignum) can't dup.
~~~
% ruby -ve '1.dup'
ruby 2.4.0dev (2016-11-29 trunk 56928) [x86_64-linux]
% ruby -ve '(1<<64).dup'
ruby 2.4.0dev (2016-11-29 trunk 56928) [x86_64-linux]
-e:1:in `d... -
- I vote for ArgumentError, because `clone(freeze: false)` is invalid operation for immediate (thus unfreezable) objects.
Matz.
-
- I remember `clone` has `freeze` option.
What should `1.clone(freeze: false)` do, ignore the option, or raise an `ArgumentError`? -
- Should be fixed in r56938
-
- Confirmed the overrun, although it didn't segfault.
Please commit the fix. -
12:31 AM Bug #12988: Calling `inspect` sometimes causes a segv
- [email protected] wrote:
> * Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: REQUIRED
I think a backport will be required for all supported versions.
I'm surprised this remained undiscovered for so many years.
> I've attached ... -
- If you have code like this:
```ruby
class A
def initialize
@a = nil
@b = nil
@c = nil
@d = nil
@e = nil
end
end
x = A.new
y = x.clone
100.times { |z| x.instance_variable_set(:"@foo#{z}", nil) }
puts y.inspect
``... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56937 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Follow net/http and open-uri. Don't rely on the constants/methods from
OpenSSL::TestUtils.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Follow net/http. Define own test DH parameters and use.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56935 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Make test code independent of test/openssl/utils.rb. The development of
openssl library has moved to a separate repository and
OpenSSL::TestUtils may be modified at any time.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56934 b2dd0... -
- * object.c (special_object_p): no longer raise a TypeError for
Integer and Float, and return itself instead. [Feature#12979]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56933 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56932 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:23 PM Revision 40c9f1f3 (git): get rid of test failures on CI introduced at r56927
- * lib/matrix.rb: now ruby warns ambiguous parentheses after a space in method definitions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56931 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Shyouhei Urabe wrote:
> As far as I can see the Rails breakage only happens in views, where 30secs is shown "less than a minute" instead of "1 minute". That sounds very trivial to me. And yet, did not break silently.
Actually, any... - 03:14 PM Revision 18658d7d (git): * 2016-11-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56930 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * object.c (rb_obj_clone2): no longer raise a TypeError for
special constants, and return itself instead. however, if
freeze option is false, raise an ArgumentError. [Feature#12979]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... -
02:27 PM Feature #12992 (Open): ArgumentError if hostname is missing
- Tue Nov 29 15:07:31 2016 Mohamed Osama <[email protected]>
* lib/net/http/generic_request.rb: Throw ArgumentError if hostname is
not provided in URI -
- Applied in changeset r56928.
----------
thread.c: fix doc of abort_on_exception [ci skip]
* thread.c (rb_thread_s_abort_exc, rb_thread_s_abort_exc_set):
[DOC] the raised exception will be re-raised in the main thread,
and then foll... -
12:09 PM Bug #12991 (Closed): Documentation of Thread.abort_on_exception is wrong: it raises error again in main thread
- Currently, ruby doc says that:
```
When set to true, all threads will abort (the process will exit(0)) if an exception is raised in any thread.
```
But actually, the error raised in thread (with abort_on_exception = true) will ... -
- * thread.c (rb_thread_s_abort_exc, rb_thread_s_abort_exc_set):
[DOC] the raised exception will be re-raised in the main thread,
and then follows the ordinary exception sequence, exit status is
not 0. [ruby-core:78415] [Bug #12991]... -
- * parse.y (parser_yylex): warn ambiguous parentheses after a space
in method definitions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56927 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Fix documentation of String#casecmp? (examples didn't have the '?').
Add an example with non-ASCII characters. Clarify that casecmp,
unlike casecmp?, only does case-insensitivity on A-Z/a-z.
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.... -
- Ryan Ringler wrote:
> I see the changeset implements the new method by calling `String#downcase` on both strings and compares the results for equality.
Yes, this is as proposed at https://bugs.ruby-lang.org/issues/12786#note-1.
... -
03:42 AM Feature #12786: String#casecmp?
- Thank you for incorporating this!
I see the changeset implements the new method by calling `String#downcase` on both strings and compares the results for equality. While this does allow unicode support in advance of `String#casecmp`,... -
- The culprit is line 4555 in enc/unicode/9.0.0/casefold.h:
```
{0xa64b, {2, {0x1c88, 0xa64a}}},
```
With comments, this looks as follows:
```
{0xa64b /* ꙋ */, {2, {0x1c88, 0xa64a /* ᲈ, Ꙋ */}}},
```
Correct would be
... -
- Nobuyoshi Nakada wrote:
> I found that tests generated by `TestComprehensiveCaseFold.unicode_case_mapping_tests` compares `target` with same `target`, which should be always true usually.
Nice catch, thanks! This is indeed a serious ... -
- Applied in changeset r56924.
----------
Fix erroneous test of target against target
* test/ruby/enc/test_case_comprehensive.rb: fix test condition,
add a temporary check for U+A64B, the only character where the tests
currently fail... -
- Failed results:
```
$ ./ruby test/runner.rb test/ruby/enc/test_case_comprehensive.rb
Run options:
# Running tests:
[258/422] TestComprehensiveCaseFold#test_UTF-16BE_capitalize = 0.30 s
1) Failure:
TestComprehensiveCaseFold... -
- I found that tests generated by `TestComprehensiveCaseFold.unicode_case_mapping_tests` compares `target` with same `target`, which should be always true usually.
I suspect this is unintentional, tried comparison `target` with `result`,
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56925 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/enc/test_case_comprehensive.rb: fix test condition,
add a temporary check for U+A64B, the only character where the tests
currently fail. (Bug #12990)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56924 b2dd03c8-39d4-... -
- Errno::ECONNRESET was raised by test_tls_post_connection_check and
test_tls_unknown_ca on mswin64 CI.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56923 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Encoding argument should be prior to `binmode` option.
```ruby
open(IO::NULL, "r", binmode: true){|f| p [f.binmode?, f.external_encoding]} #=> [true, #<Encoding:ASCII-8BIT>]
open(IO::NULL, "r:utf-8", binmode: true){|f| p [f.binmode?... -
- * test/ruby/test_keyword.rb (test_block_required_keyword): more
assertions for positional and require keyword parameters.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56922 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_keyword.rb (test_block_required_keyword):
assert_raise_with_message returns the raised exception object.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56921 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (rb_str_casemap): use xmalloc simply instead of
ALLOC_N.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56920 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The TLS handshake timeout can be specified independently, because the TLS
handshake doesn't start just after the underlying connection is established,
but after the AUTH command is completed. It's also useful for testing
purposes. Howe... -
- Otherwise, @sock.read in Net::FTP#close hungs until read_timeout exceeded.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:21 AM Revision d8a0f14b (git): * 2016-11-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Otherwise, file descriptor leaks may occur in Net::FTP.new.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56916 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/28/2016
-
- Hi,
> Is there any problem with the following code?
> ...
2 problems
1. It's slower than it could be (as Naruse demonstrates)
2. It's very noisy when `-d` is enabled.
In Psych, I am trying to avoid noise from `-d`. That means... -
- Here is a sample program:
~~~ruby
Encoding.default_external = Encoding::UTF_8
Encoding.default_internal = Encoding::UTF_8
reader, writer = IO.pipe(binmode: true)
reader.binmode? # => true
reader.external_encoding # =... -
- `rb_obj_inspect` calls `rb_ivar_count ` to find the number of instance variables on an object. `rb_ivar_count` uses `tbl->num_entries` on the instance variable index table to determine how far in to the instance variable array it should...
-
05:31 PM Bug #12984: `rescue *[]` should be equivalent to `rescue` as `method_call(*[])` is equivalent to `method_call`
- bug hit wrote:
> Nobuyoshi Nakada wrote:
> ...
The difference between rescue and super is that there is such a thing as an explicit empty `super()` that passes nothing, but there is no corresponding explicit empty `rescue()` that rescu... -
- Nobuyoshi Nakada wrote:
> It's similar to:
> ...
I guess there's some similarity. But super has a very explicit definition. Only a naked super is auto-forwarding, any attempt to pass args turns it into manual super. So `super(*[])` i... -
- It's similar to:
```ruby
super(*[])
``` -
- * string.c (mapping_buffer): get rid of zero-length array member,
which is not a part of C90.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56915 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:47 PM Bug #12987: Win32 API.rb can not call function without argument.
- Thank you very much.
I just learned that only nil was clearly stating that there are no arguments in the previous document.
I used a single 'V' to specify no arguments, so it was up to this idea. -
- For workaround, you can use '' instead of '0'.
-
- In Win32API.rb, it is not possible to call a function without arguments.
I could avoid it for the time being if I did the following (against trunk).
~~~
diff --git a/ext/win32/lib/Win32API.rb b/ext/win32/lib/Win32API.rb
index d03ec... - 10:17 AM Revision f2a1f32f (git): hide exceptions in server thread
- * test/net/ftp/test_ftp.rb (test_tls_connect_timeout): sleeping to give a chance of complete of accept is a timing issue at all. therefore, simply ignore the exception.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56914 b2dd03c8-... -
- * string.c (rb_str_casecmp_p): [DOC] move forward declaration of
rb_str_downcase to enable rdoc.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r56912.
----------
implement String/Symbol#casecmp? including Unicode case folding
* string.c: Implement String#casecmp? and Symbol#casecmp? by using
String#downcase :fold for Unicode case folding. This does not ... -
-
- * string.c: Implement String#casecmp? and Symbol#casecmp? by using
String#downcase :fold for Unicode case folding. This does not include
options such as :turkic, because these currently cannot be combined
with the :fold option. Thi... -
04:04 AM Feature #12986 (Open): HTTP/request basic_auth context should be switched
- HTTP basic auth should be persisted over the HTTP object and not the request object. The consequence is having to authenticate on every request.
-
- I don't really care if this gets low priority. I'd just like to have a quick discussion and get it approved.
-
- Need to implement an RFC-compliant cookie handling method. Specifically, set-cookies need to be handled properly; but we really should put in an overall proper handling.
-
- * insns.def (checkmatch): adjust type of the index variable, to
get rid of (potential) overflow.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56911 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:14 AM Revision 8e7e71d6 (git): Give a chance to complete server.accept
- * test/net/ftp/test_ftp.rb (test_tls_connect_timeout): get rid of a test error on Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:02 AM Revision a530b970 (git): * 2016-11-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56909 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_peephole_optimize): remove splatarray following
always-array insn.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56908 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/27/2016
-
10:23 PM Feature #12973: [RFC] net/http: use require_relative to reduce syscalls
- I have no particular pro or con opinion, not that it would be relevant anyway - but I am watching this closely out of interest what others have to say. :)
-
- Splatting an empty array to a construct that takes a list is supposed to be equivalent to specifying no list
```ruby
def foo
end
foo *[] #works
```
So `rescue *[]` should be equivalent to `rescue`
```ruby
begin
raise '... -
- Umm, I guess the issue may be readine's and this can be reproduced without ruby.
```
#include <stdio.h>
#include <readline/readline.h>
int main() {
FILE *fp;
rl_outstream = NULL;
while(1) {
fp = fdopen... -
- Should `Kernel#clone` be same?
-
- * signal.c (check_stack_overflow): [EXPERIMENTAL] consider the
segfault a stack overflow when the fault address is between SP
and BP.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * object.c (rb_obj_dup): no longer raise a TypeError for special
constants, and return itself instead. [Feature#12979]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56906 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Seems a simple stack overflow, but it's strange that `sigsegv` handler hasn't been called.
Could you elaborate what you did? -
- Committed as r56905.
-
- Please commit it.
-
- The `compatibility_version` should have an API version and the `current_version` should have a program version of Ruby, but they have been reversed and the binary compatibility has never worked.
For example, the ruby 2.3.3 program/dyl... - 10:08 AM Revision 673a6ad9 (git): Reverse compatibility_version and current_version for Darwin
- The `compatibility_version` should have an API version and the
`current_version` should have a program version of Ruby, but they have
been reversed and the binary compatibility has never worked.
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... - 09:40 AM Revision c46946ca (git): * 2016-11-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56903 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Nobuyoshi Nakada wrote:
> `String#casecmp` also should have those options, I think.
I agree that once String#casecmp supports full Unicode, it should have these options (and more, because for Unicode sorting, you need/can have a lot ... -
- Nobuyoshi Nakada wrote:
> `String#casecmp` also should have those options, I think.
I agree, and feel strongly that the logic to support those options should live there. Someone smarter than I should probably make the changes Martin... -
- `String#casecmp` also should have those options, I think.
-
- Ryan Ringler wrote:
> The attached patch implements `#casecmp?` by calling `#casecmp` and checking whether the return value is zero. I think this provides a clean separation of concerns (keeping all the comparison logic in `#casecmp`... -
04:12 AM Feature #10912: Add method(s) to IPAddr for determining whether an address is link local
- I also want a method to determine whether an address is link-local.
There is a proposal for a fix on https://github.com/ruby/ruby/pull/1494 .