Activity
From 02/25/2017 to 03/03/2017
03/03/2017
-
10:20 PM Feature #13166: Feature Request: Byte Arrays for Ruby 3
- The points Kevin makes are exactly some of the reason I think, **from a users perspective**,
its clearer to provide a separate name and API for this resource.
A normal user will have no knowledge of how the things works under the hoo... -
01:32 AM Feature #13166: Feature Request: Byte Arrays for Ruby 3
- I'm in favor of a separate byte type as well. I think it conveys intent much more clearly, is easier to reason about, is easier to optimize, and is less error-prone.
While an ASCII-8BIT string can do the work, it leads to two use case... -
10:16 PM Bug #13270 (Feedback): IRB hangs when printing "\e]"
- What terminal emulator are you using, the standard `Terminal.app`?
-
04:56 PM Bug #13270: IRB hangs when printing "\e]"
- Even more information, this is reproducible on ruby -v ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux], but instead of printing out "30m" after CMD+D it prints out nothing. This seems to be a bug within IRB. Interesting, this beh...
-
- I can reproduce it on Darwin, so I'm switching it back to open.
My `ruby -v` is `ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin14]`
Also it occurs with `irb -f` but not with `ruby -e` -
- I can't reproduce it on darwin15.
Does it happen without irb, just `ruby -e print "\e]"`?
If only with irb, does it with `irb -f`? -
10:09 PM Feature #13263: Add companion integer nth-root method to recent Integer#isqrt
- If you get the wrong answer from Newton's, then you are doing it wrong. It may fail to converge, (which seems MOST unlikely in this case) but that is a different matter. But ultimately, there is 0 credibility to benchmarks that show BB...
-
07:46 PM Bug #10403 (Closed): `puts` documentation fix
-
- `puts` (rb_io_puts) uses `rb_default_rs` ("\n"), which isn't supposed to be customizable from within Ruby code, right? (Different from `$\` = `rb_output_rs`.)
So IMO this is a good improvement and I'll apply the patch. - 07:39 PM Revision 2e97d5bc (git): * 2017-03-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57768 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * io.c: [DOC] clarify that the 'record separator' between
arguments passed to 'puts' is always a newline.
Based on a patch by Mark Amery. [ruby-core:65801] [Misc #10403]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57767 b2dd03... -
06:32 PM Bug #13276 (Closed): Dir.glob returns empty array when OS has no more file handles (expected exception)
- The following terminal session demonstrates how `Dir.glob` returns an empty array when the OS has run out of file handles; whereas `File.new` raises a `Errno::EMFILE` exception.
I would expect `Dir.glob` to fail fast in a similar way ... -
04:21 PM Feature #13272: Keyword argument to instantiate a subclass of Struct
- I agree it is easier to read.
In the other thread, Shyouhei Urabe said that nobody at the developer
meeting was against it (I assume this also includes matz).
So I suppose that this may be implemented eventually.
-
04:10 AM Feature #13272 (Closed): Keyword argument to instantiate a subclass of Struct
- When we define a subclass of Struct, it take arguments of values of fields when instantiated:
```ruby
ServiceAccount = Struct(:account_name, :full_name, :nickname, :name_invited_by, :twitter_account_name)
a = ServiceAccount.new("tag... -
- RDoc doesn't handle Document-method directives for `#[]` correctly. When multiple directives are given, "Document-method: []" shows up as a code block, at the beginning of the docs for the method of the directive before:
```
$ cat do... -
-
- 2.2.2 is outdate, does it happen with recent versions?
-
10:17 AM Bug #13274 (Closed): Ruby interpreter when using Puma.
- ```
=== puma startup: 2017-03-02 09:38:34 +0000 ===
/var/www/redacted_app_name/vendor/gems/ruby/2.2.0/gems/activesupport-5.0.0/lib/active_support/dependencies.rb:458: warning: already initialized constant Stats
/var/www/redacted_app_n... -
- Does it happen with recent versions?
-
- * ext/zlib/extconf.rb: fix building zlib for mingw, and for
cross-compiling.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57766 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r57765.
----------
proc.c: documentation for Proc#{call,yield,[]}
* proc.c: [DOC] fix and improve docs for Proc#{call,yield,[]}:
* change order of Document-method directives as workaround for an
RDoc renderi... -
- The documentation for Proc#call displays one of its Document-method directives as a code block:
```
$ ri Proc.call
------------------------------------------------------------------------------
prc.call(params,...) -> obj
--... -
- * proc.c: [DOC] fix and improve docs for Proc#{call,yield,[]}:
* change order of Document-method directives as workaround for an
RDoc rendering problem where the documentation for Proc#call displays
a "Document-method: []" cod... -
08:40 AM Feature #12901: Anonymous functions without scope lookup overhead
- Benoit Daloze wrote:
> Shyouhei Urabe wrote:
> ...
True. There are two ways to tackle this problem:
1. add a new construct that does not capture variables outside of a given block.
2. just prohibit obtaining bindings; make lambdas... -
- * template/configure-ext.mk.tmpl (EXTMK_ARGS): add MINIRUBY for
cross-compling, which is used in extmk.rb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * util.c: define MINGW_HAS_SECURE_API for qsort_s on recent
mingw64.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57763 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r57762.
----------
broken mingw
* configure.in: check whether frexp and modf are broken.
* include/ruby/win32.h (frexp, modf): ignore bad declarations when
compiling as C++. [ruby-core:79859] [Bug #13267] -
- * configure.in: check whether frexp and modf are broken.
* include/ruby/win32.h (frexp, modf): ignore bad declarations when
compiling as C++. [ruby-core:79859] [Bug #13267]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57762 b2d...
03/02/2017
-
11:36 PM Revision 2f3ff53f (git): [DOC] update doc.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57761 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:33 PM Revision b7336a24 (git): * 2017-03-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57760 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The "n" option for regexp, /.../n, is historical.
It doesn't mean the regexp works as binary match since Ruby 1.9.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57759 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:38 PM Bug #13271 (Closed): Clarifications on refinement spec
- Consider the following code:
~~~ruby
class Foo
def foo
"Foo#foo"
end
def bar
"Foo#bar"
end
end
class Bar < Foo
def foo
"Bar#foo -> "+super
end
def bar
"Bar#bar -> "+super
end
end
modu... -
- Is this darwin-specific? It appears to work fine on my linux system here.
ruby 2.4.0p0 (2016-12-24 revision 57164) [i686-linux] -
08:19 PM Bug #13270 (Rejected): IRB hangs when printing "\e]"
- Steps to reproduce:
- `irb`
- `print "\e]"`
- Or: `puts "\e["`
- try CMD+C, nothing happens
- try CMD+D, prints "30m"
Expected behavior:
- just prints "30m" (that's what `pry` does)
Ruby versions tried:
- ruby 2.3.3p22... -
03:41 PM Bug #13269 (Closed): test/readline/test_readline.rb and mingw
- When running test-all on a mingw build, [`test_readline.rb`](https://github.com/ruby/ruby/blob/trunk/test/readline/test_readline.rb) generates failures and errors. Several of the errors are due to the `with_temp_stdio` method in `test_r...
-
03:08 PM Feature #13257: Symbol#singleton_class should be undef
- Is that a use case where you need a method for checking without allocating a singleton class?
As I read it diagonally, it looks like you are always accessing and using the singleton class when an object has one. -
- After chat with narse, I found that what I really want is the list of classes and modules on method search path of objects (nearly equal to `obj.singleton_class.ancestors`).
If I can get it without creating/allocating singleton classes,... -
- My motivation is to know whether there is an class/module in ancestors or not.
I needed it at this patch: https://github.com/msgpack/msgpack-ruby/pull/132/files
The feature implemented in this patch serialize/deserialize objects in a... -
- What's the motivation behind this? You cannot tell if an object has no singleton class just because it doesn't define or respond to #singleton_class anyway. BasicObject is an exception, and I could imagine certain kinds of objects (for...
-
- I understood that `#respond_to?` doesn't matter in fact.
What I really want is to undef `Symbol#singleton_class` (and Integer, Float too). -
09:27 AM Feature #13257 (Feedback): Symbol#singleton_class should be undef
- Fundamentally, `#respond_to?` is a method to check method existence. The class Symbol does have `#singleton_class` so that it's natural for it to return `true`, even though `#singleton_class` always fails.
It seems you want to check t... -
02:56 PM Bug #7976: TracePoint call is at call point, not call site
- I recently found this behaviour while attempting to build a gem that outputs the full call graph for our Rails application.
Using TracePoint, we can capture all calls/returns with the object the method is invoked upon, but finding th... -
-
- Closing, fixed with r51859.
-
- Closing, this should have been solved with #12332.
-
10:44 AM Feature #12901: Anonymous functions without scope lookup overhead
- To come back to the main topic of this issue,
I think having some syntax support for a non-capturing lambda
can be a useful feature in Ruby, but should not be for performance reasons.
It should be a design tool.
If a lambda/proc do... -
- Koichi Sasada wrote:
> I haven't read discussion details, but some optimizations eliminate
> ...
No, that's the important part, proper deoptimization *must* be able to restore
local variables. It can do so how it wants, but typically... -
03:08 AM Feature #12901: Anonymous functions without scope lookup overhead
- On 2017/03/01 5:47, [email protected] wrote:
> It is possible with deoptimization though.
> An optimizer might assume that a block does not call binding and in case it does, deoptimize.
I haven't read discussion details, but some ... -
- Benoit Daloze wrote:
> > now, should what be visible from the obtained binding? Should we re-calculate the optimized-out variables?
> ...
This (recomputation) sounds practically very difficult to me, if not impossible. Much easier to... -
- Closing, because:
* in 2.1, 2.2, 2.3, the example code shows uses of both `#<<` and `#concat`,
* since 2.4, they are not aliases any more (`#concat` now accepts multiple arguments). -
- Applied in changeset r57758.
----------
string.c: restore documentation for String#<<
* string.c: [DOC] restore documentation for String#<<
which became undocumented with r56021; fix a typo.
[ruby-core:79865] [Bug #13268] -
- Since r56021 (Feature #12333), `String#<<` is not documented; the patch fixes this.
A backport should only be needed for 2.4. -
- * string.c: [DOC] restore documentation for String#<<
which became undocumented with r56021; fix a typo.
[ruby-core:79865] [Bug #13268]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57758 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:01 AM Bug #13267: ruby 2.4.0 i686-w64-mingw32 + boost compilation error
- When compiling the same program, with the same libraries for linux, this issue does not arise.
-
- When building https://github.com/Ancurio/mkxp for windows (via i686-w64-mingw32), the following build error occurs:
```
In file included from /usr/i686-w64-mingw32/include/ruby-2.4.0/ruby/defines.h:243:0,
from /usr/... -
- Jabari Zakiya wrote:
> An **Array8** is an array and a **String** a string.
I think I understand what you mean but in Ruby, classes tend not be split when they share same backends. For instance Array class can also be used as stacks... -
- > Additionally, an empty array is returned when the starting index for
an element range is at the end of the array. -
04:35 AM Bug #13266 (Rejected): Slicing in array producing wrong results
- ```
even_nums = [2,4,6,8,10]
2.3.1 :007 > even_nums[5,0]
=> []
# it must return nil as index is out of bound when slicing
# it may be due to the code written in ruby.c
=begin
if (argc == 2) {
if (SYMBOL_P(argv[0])) {
... -
- This is possible in perl:
```
use strict;
use warnings;
use Data::Dumper qw(Dumper);
my %hash = qw();
$hash{q}{w}{e}{r}{t} = 'y';
warn(Dumper(\%hash));
```
From perl's POV it seems ruby lacks this feature. -
- * test/lib/envutil.rb: rbconfig/sizeof may not be available when
cross-compiling. use RbConfig::Limits instead of calculating
limits of Fixnum with hard-coded CHAR_BIT.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57757 b2dd03... -
- * common.mk (test-rubyspec): add dependency for cross-compiling.
* defs/gmake.mk: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57756 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:21 AM Feature #13245: [PATCH] reject inter-thread TLS modification
- How about we allow some inter-thread TLS operations, but not others?
Maybe:
Allowed:
+ reading values
+ updating value of existing keys (maybe)
Disallowed:
- setting value to a new key
In other words, the Allowed stuf... -
01:14 AM Bug #12834: `prepend` getting prepended even if it already exists in the ancestors chain
- I feel like this is a bug, and should be fixed. Prepending the same thing multiple times should be a warning IMHO. I'm not even sure what situation this is useful.
```
2.4.0 :001 > module M
2.4.0 :002?> end
=> nil
2.4.0 :003 >...
03/01/2017
-
- Actually, this **bbm** version is generally a smidgen faster than the original, especially for perfect roots.
```
class Integer
def irootn3(n) # binary bit method (bbm) for nth root
return nil if self < 0 && n.even?
ra... -
- Further testing shows Newton's method is sensitive to its implementation as you take larger roots.
Shown below are test results that show the **irootn1** Newton's implementation starts to give incorrect (smaller)
results past a certa... -
- Jabari Zakiya wrote:
> This will enhance Ruby's use even more in fields like number theory, advanced math, cryptography,
> ...
I'm not immediately against this but can I ask you when is this method useful? Because being amateur, I don... -
- Julien BONNET wrote:
> Between version 2.0.0 and 2.3.1, documentation has shrunk a lot.
Could you please be more specific about which parts are missing?
I can not see big differences:
* http://ruby-doc.org/stdlib-2.0.0/libdoc/soc... -
- * struct.c: [DOC] improve examples for ::new, improve #dig example,
simplify #select example, use consistent style for return values,
fix typos and example code style, remove duplicate cross reference.
git-svn-id: svn+ssh://ci.ruby-... - 07:57 PM Revision 9386e511 (git): * 2017-03-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57754 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57753 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:41 PM Feature #13265 (Rejected): TracePoint for basic operation redefinition
-
Add TracePoint for basic operation redefinition.
This infrequent event can have an outsized performance impact by eliminating a lot of the optimization that exists in the Ruby interpreter.
In order to know when these sor... -
02:00 PM Bug #13264 (Closed): Binding#irb does not work in context of frozen object
- This works as expected (starts IRB):
```
$ ruby -r irb -e '"".instance_eval{ binding.irb }'
```
This throws an error:
```
$ ruby -r irb -e '"".freeze.instance_eval{ binding.irb }'
```
```
/home/jan/.rvm/rubies/ruby-2.4.0... -
11:39 AM Bug #12774: TkDND cannot handle text/plain, text/uri-list type well
- There is no Issue tracker in https://github.com/ruby/tk
Where should we report bugs related with tk? -
11:37 AM Revision c1fd1b11 (git): lib/e2mmap.rb: Specify frozen_string_literal: true.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57752 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Shyouhei Urabe wrote:
> Let me ask a (possibly stupid) question. Consider this scenario:
> ...
I assume you mean a binding via Kernel#binding.
I think that's the general contract of deoptimization: it must not be observable from the ... -
- Math Ieu wrote:
> Shyouhei Urabe wrote:
> ...
I (broadly) agree with you. Extending or modifying the language to make optimization possible is a great idea. Matz said in comment #9 that Koichi has one of such ideas. Let us see what ... -
- Benoit Daloze wrote:
> Shyouhei Urabe wrote:
> ...
Let me ask a (possibly stupid) question. Consider this scenario:
1. create a proc.
2. it gets optimized.
3. lots of calculations goes on without variable captures.
4. obtain a b... -
- * lib/fileutils.rb: [DOC] fix invalid example code to make it
syntax highlighted, fix rdoc for lists, nodoc internal methods,
avoid a dangerous example.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57751 b2dd03c8-39d4-4d8f-98ff... -
10:15 AM Revision 3acda398 (git): openssl: avoid segfault during running tests on Ubuntu trusty
- Import the commit 6693a549d673 ("test/test_pkey_ec: do not use dummy 0
order", 2017-02-03) from upstream. Hopefully this will fix the segfault
on RubyCI icc16-x64:
http://rubyci.org/logs/rubyci.s3.amazonaws.com/icc-x64/ruby-trunk/log/... -
-
- I used `/dev/urandom` in the example because `/dev/random` might block.
-
- * lib/fileutils.rb (compare_file): [DOC] clarify documentation
by avoiding confusing return value of "maybe false".
[ruby-core:75431] [Misc #12365] reported by Robert A. Heiler.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57749... -
- [email protected] wrote:
> Nobuyoshi Nakada wrote:
> > It is not guaranteed that `ruby_xfree` can free a pointer allocated by other than `ruby_xmalloc` and so on.
> > You can't mix bare `malloc` and `ruby_xfree`.
>
> Agreed. ... -
- Nobuyoshi Nakada wrote:
> It is not guaranteed that `ruby_xfree` can free a pointer allocated by other than `ruby_xmalloc` and so on.
> ...
Agreed. I heard that DLLs can have their own malloc() implementation on Windows. Even on POSI... -
- * common.mk (clean-ext): separate clean-up of makefiles and
timestamps, and clean-up of subdirectories under ext and gems.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57748 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:39 AM Feature #13110: Byte-based operations for String
- Yukihiro Matsumoto wrote:
> Are byteindex and byteoffset good enough for your use-case?
I also want bytesplice, but its priority is lower.
> ...
byteoffsets may be better, but we should consider consistency with MatchData#offset.
-
- Are byteindex and byteoffset good enough for your use-case?
Should byteoffset be byteoffsets since it returns both edge?
Matz.
-
07:00 AM Feature #12515: Create "Boolean" superclass of TrueClass / FalseClass
- Shyouhei Urabe wrote:
> Radovan Smitala wrote:
> ...
Just deprecated warnings for Fixnum and Bignum :) And that is OK. Rails is biggest project/framework/tool in Ruby community. It takes some time to be fully compatible, not only for I... -
- Radovan Smitala wrote:
> There should be some circumstances where implemented Boolean class should be problematic. But many of existed gems just reopen class and life goes on. Rails 5 isn't till now compatible with Ruby 2.4 with introdu... -
- * ext/zlib/extconf.rb: clean zlib libraries generated in the
place.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57747 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:16 AM Revision c0be1c7b (git): * 2017-03-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57746 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:16 AM Revision d1a506ec (git): deduplicate strings sooner at load and compile
- We can use rb_fstring_cstr in some places to prevent an
intermediate object from being created before deduplication
via rb_fstring.
* compile.c (iseq_compile_each): use rb_fstring_cstr
(rb_insns_name_array): ditto
* load.c (rb_load_in...
02/28/2017
-
- Newton's method has quadratic convergence. This means that a properly implemented Newton's method will blow away any BBM if more than just a few bits are needed.
"Properly implemented" is a big deal, because, as I have found with som... -
- Following the heels of adding the method ``Integer#isqrt``, to create exact integer
squareroot values for arbitrary sized integers, based on the following threads:
https://bugs.ruby-lang.org/issues/13219
https://bugs.ruby-lang.org/i... -
10:37 PM Feature #12901: Anonymous functions without scope lookup overhead
- Shyouhei Urabe wrote:
> Math Ieu wrote:
> ...
But it could be enabled on-demand. Say with a magic comment, then all closures created from code of this file would be optimized to not capture everything. I guess there might as well be sp... -
- Shyouhei Urabe wrote:
> I think it's impossible to optimize lambdas without breaking backwards compatibility.
It is possible with deoptimization though.
An optimizer might assume that a block does not call binding and in case it doe... -
12:35 PM Feature #12901: Anonymous functions without scope lookup overhead
- I didn't think about (er, *know* about!) those ways of accessing the inner scope. That definitely rules out skipping the binding in those cases! Thanks for the info.
-
10:30 AM Feature #12901: Anonymous functions without scope lookup overhead
- Robert Mosolgo wrote:
> What about checking at the block level? I mean, could we check that:
> ...
In addition to what Shyouhei said, somebody could also redefine addition, like so:
~~~ ruby
alias :old_plus :'+'
def + (other)
b... -
- Robert Mosolgo wrote:
> What about checking at the block level? I mean, could we check that:
> ...
Sorry, no. You can look at outside scope from within the lambda's binding like this:
```
zsh % rbenv exec irb
irb(main):001:0> a =... -
- What about checking at the block level? I mean, could we check that:
- All local variable reads come from the block's local table
- There are no method calls on implicit receiver
So, this could be optimized:
~~~ ruby
lambda... -
- Math Ieu wrote:
> The introspection features like the "binding" method and maybe the way "eval" works might make this hard to optimize though (since they essentially capture everything?).
Yes. This is why we capture everything. And... -
- Fixed with r57539 (#11752).
-
12:09 PM Feature #13259: Kernel#Date
- Marcus Stollsteimer wrote:
> Note also the ongoing discussion about the future of Date (#13072).
Thanks for the notification. I actually do think there should be a similar thing with `Time`, and if `Date` is supposed to become obsole... -
- Note also the ongoing discussion about the future of Date (#13072).
-
- I have nothing against it per se but what happens to the Date namespace?
People may be confused when they see Date like the above that used to be part of the
require 'date' call, but now suddenly is part of Kernel.
On a side note ... -
- I often see a piece of code like this:
```ruby
require "date"
begin
Date.strptime(some_string, some_format)
rescue
nil
end
```
Since we now have (https://bugs.ruby-lang.org/issues/12732) `Kernel#Integer` with a parame... -
- I first stumbled upon it when doing `ri Integer` (before the proper documentation there appear snippets introduced by BigDecimal, OpenSSL (both fixed upstream now), and mathn), and then also noticed in the context of #13219 that `ri Math...
-
- Very interesting find. I would not have thought that this is a possibility.
May I ask how you did discover this? -
- The deprecated (#10169) mathn library leaks documentation into some core classes, or even replaces it (see example further down).
I would like to fix this, but I could need some ideas what would be the best way to do that. The problem... -
- > I think we have lots of occasions to receive a true or false value as a string input, and
> ...
I agree. :)
Not saying that I agree with the API, it feels a bit cumbersome; but I agree with the
comment above.
By the way, I thi... -
- I agree that the proposal was vague. Instead of using `strict`, perhaps we can pass a string or strings expressing the language/mode that we want to allow.
```ruby
Boolean("はい", allow: ["JA", "EN"])
Boolean("0", allow: ["NUMBER"])
... -
- The proposal is still vague, especially when `strict: false`. The criteria are totally culture dependent.
"yes" may be true for English speaking people, but what about "はい" (Japanese) or "Ja" (German)? The list would go on.
Until the... -
- Please note that this proposal is distinct from any proposal to introduce the `Boolean` class into Ruby. In think the latter does not make sense, and I am against it.
-
- I think we have lots of occasions to receive a `true` or `false` value as a string input, and want to convert it to `true` or `false`. Perhaps we can have a method `Kernel#Boolean` in a similar spirit to `Kernel#Integer` and its kins, wh...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57744 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Makefile.in (clean-ext): clean gem directories too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57743 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:46 AM Feature #13261 (Closed): Gemify sdbm
- Applied in changeset r57742.
----------
Added initial gemspec for SDBM module.
[Feature #13261]
* doc/*.rdoc: Move SDBM entry to default gem section.
* ext/sdbm/sdbm.gemspec: first gemspec. -
- This issue is tracking for gem release of SDBM module.
-
- [Feature #13261]
* doc/*.rdoc: Move SDBM entry to default gem section.
* ext/sdbm/sdbm.gemspec: first gemspec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57742 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r57741.
----------
disable critical-error-handler
* win32/win32.c (rb_w32_sysinit): disable critical-error-handler
message box even on mswin, regardless of runtime DLL version.
[ruby-dev:49988] [Bug #13254] -
- * win32/win32.c (rb_w32_sysinit): disable critical-error-handler
message box even on mswin, regardless of runtime DLL version.
[ruby-dev:49988] [Bug #13254]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57741 b2dd03c8-39d4-4d8f-... -
- * win32/Makefile.sub (config.h): define ULL_TO_DOUBLE for
conversion from unsigned __int64 to double, which is not
implemented in till Visual Studio.NET 2003, aka VC7.1.
* bignum.c (estimate_initial_sqrt): use ULL_TO_DOUBLE if defin... -
- * numeric.c (DEFINE_INT_SQRT): suppress a type-limits warning
where int is always smaller than double.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57739 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- * Makefile.in (update-mspec, update-rubyspec): use CHDIR, which may
use -P, to resolve symbolic links.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57738 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/27/2017
-
- Two thoughts regarding BigDecimal and Float:
1. INHO it's desirable that the inspect output should be different; it should be possible to distinguish between a BigDecimal and a Float by inspecting it.
2. BigDecimal doesn't use scie... -
07:16 PM Feature #12790: Better inspect for stdlib classes
- ~~~
$ rvm use 2.4
$ ruby -rbigdecimal -e "p BigDecimal.new(150)"
0.15e3
~~~
So, the boilerplate dropped yet scientific notation remains? Could I provide patch to get rid of it for "reasonably small" numbers?.. -
- Thanks Matz!
I'm honored, and I'm glad I can help improve Ruby in some small way.
Marcus (stomar)
-
- Applied in changeset r57737.
----------
date_core.c: expand docs for Date shifting
* ext/date/date_core.c: [DOC] expand docs for Date shifting
* add examples for Date#>> and Date#<< that clarify some edge cases
* add examples for ... -
- * ext/date/date_core.c: [DOC] expand docs for Date shifting
* add examples for Date#>> and Date#<< that clarify some edge cases
* add examples for Date#next_year and Date#prev_year
* add cross references to Date#>> and Date#<<
... -
- Applied in changeset r57735.
----------
Fix doc for Hash#dig and Struct#dig
* hash.c (rb_hash_dig): [DOC] correct argument name
in method description; fix formatting in examples.
* struct.c (rb_struct_dig): ditto.
[ruby-core:79221] ... - 06:07 PM Revision fbf98a77 (git): * 2017-02-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57736 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * hash.c (rb_hash_dig): [DOC] correct argument name
in method description; fix formatting in examples.
* struct.c (rb_struct_dig): ditto.
[ruby-core:79221] [Bug #13148]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57735 b2dd03c8... -
- Would be better if this could be determined automatically, as others have pointed out.
A lot of functional programming languages optimize this away with some form of "lambda lifting".
The shared variables that are not ever reassign... -
- [Fix GH-5129]
Author: fate0 <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57734 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (iseq_set_arguments_keywords): make keyword rest
argument name nd_vid consistently, regardless of whether other
keyword arguments are present. [Fix GH-1529]
* parse.y (new_args_tail_gen): ditto.
git-svn-id: svn+ssh://c... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57732 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:27 PM Bug #13258 (Closed): Segmentation fault at 0x00000000000000 during instance_eval
- My program is a website that runs inside webrick. Intermittently when calling instance_eval, a segmentation fault occurs, producing console output as shown in the attached file.
I have not been able to spot a pattern to when the segme... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57731 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Agreed.
-
- etc gem is preserved name. but it can be install via `gem i etc`
https://rubygems.org/gems/etc
We need to transfer it namespace to us and yank it. -
- Applied in changeset r57730.
----------
Added initial gemspec for Etc module.
[Feature #13256]
* doc/*.rdoc: move Etc module to default gem section.
* ext/etc/etc.gemspec: first gemspec. -
- This issue is tracking for gem release of Etc module.
-
- Nobuyoshi Nakada wrote:
> Note that these results are in NFD.
> ...
This is mostly true, but there are 'visual' characters that cannot be expressed in a single code point in Unicode. As an example: "q̈".unicode_normalize.gsub("q", "x")... -
10:14 AM
Bug #13254: Dir.exist? などで「ディスクがありません」ダイアログが表示される
- 再現手順に漏れと誤りがありましたので、説明を編集しました。
* 再現手順１に手順 1)～2) を追加しました。「DVD-ROM ドライブでは現象が起こらない」を削除しました。
* DVD-ROM ドライブでも現象が起こったため、再現手順２を追加しました。
-
- Objects of some classes doesn't have singleton classes (e.g., Symbol, Integer, Float...).
Symbol#singleton_class raises TypeError.
But Symbol#respond_to?(:singleton_class) returns true, and we cannot know when #singleton_class return... -
- [Feature #13256]
* doc/*.rdoc: move Etc module to default gem section.
* ext/etc/etc.gemspec: first gemspec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57730 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:29 AM Bug #9975: irb で Hash を 1.9 記法で記述したときに、キーがキーワードだと syntax error
- https://bugs.ruby-lang.org/issues/13012 により、2.4 では修正されているようです
-
- * Makefile.in (clean-ext): recurse by exts.mk in parallel first.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57729 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (clean-rubyspec): remove OBJDIR for rubyspec C-API
tests.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57728 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/mkmf.rb (create_makefile): add TARGET_SO to CLEANLIBS only
when the extension library will be build, to get rid of trying
to remove $(TARGET_SO_DIR).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57727 b2dd03c8-39d4-4d8f-9... -
- * Makefile.in (clean-local): remove debug symbol directories on
Mac OS.
* common.mk (clean-ext): remove parent directories of timestamp
directory.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57726 b2dd03c8-39d4-4d8f-98ff-823f... -
- * Makefile.in (clean-ext): remove exts.mk files in subdirectories
underneath ext.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57725 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57724 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/mkmf.rb (try_link0): remove generated files other than the
executable file.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57723 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * Makefile.in (verify-static-library): separate from LIBRUBY_A.
no check every times by default.
* lib/mkmf.rb (try_link): remove debugging symbol directory after
linking, instead of try_do.
* lib/mkmf.rb (try_link): bccwin32 suppo... -
- Marcus Stollsteimer wrote:
> Regarding `code` vs. `:code`, IMHO for beginners it's much easier to understand without leading ":", similar to the usage in the call sequence, it's _not_ `explode(:code: 123)` but `explode(code: 123)`, an... -
- Registered gem is here: https://github.com/jruby/dbm
I will coordinate JRuby team and rubygems admin. -
- gdbm was already registered rubygems.
* https://rubygems.org/gems/gdbm
* https://github.com/presidentbeef/ffi-gdbm/
It overrides global namespace. I will coordinate gem author and rubygems admins. - 12:53 AM Revision eeea1b38 (git): * 2017-02-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57721 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57720 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/26/2017
-
- Olivier Lacan wrote:
> ```diff
> ...
* I think `rb_str_cat_cstr(mesg, ": ");` in the while-loop doesn't work; ":" must be added before the loop, in the loop only " " to separate different entries
* suggestion: s/keyword/keyword argu... -
03:40 AM Bug #13196: Improve keyword argument errors when non-keyword arguments given
- Although I find Nobu's patch excellent, it still bothers me that the exception says `expected 0`.
Keyword arguments do increase a method's arity just like regular arguments, so the message is both confusing *and* disingenuous.
Giv... -
- Marcus Stollsteimer wrote:
> wrong number of arguments (given 1, expected 0; missing keywords: code, foo)
I agree that this is clearer so I slightly modified Nobu's patch:
```diff
diff --git a/vm_args.c b/vm_args.c
index 6cded80... -
08:59 PM Feature #13201: Gemify dbm
- Since this is JRuby implementation of dbm, I believe it shouldn't be big big deal to get that name available ....
-
- Perhaps the rubygems.org folks can de-register that gem, due to two reasons - ruby stdlib and core should have a higher priority over custom gems; and the gem is not very active, only two updates, one in 2009 and another one in 2013. (It...
-
- Yay, first commit...!
nobu, thanks for your patience; please give feedback if I should have done anything differently. -
- Applied in changeset r57719.
----------
Add rdoc for Integer.sqrt
* numeric.c (rb_int_s_isqrt): [DOC] add rdoc for Integer.sqrt.
[ruby-core:79762] [Bug #13251] -
- I see, the usage is another issue in any rate.
The doc seems nice, thank you. -
- For the specific patch I tried to follow the style in the current file. Generally, I see both, and it seems `+` is more common than `_` (see e.g. Array).
Are there any agreed upon guidelines on documentation style? There are hints reg... -
- * numeric.c (rb_int_s_isqrt): [DOC] add rdoc for Integer.sqrt.
[ruby-core:79762] [Bug #13251]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57719 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Please show the Crash Report log file.
P.S. 2.1.8 is outdated and 2.1 will reach the EOL soon. -
07:51 AM Bug #13255 (Closed): segmentation fault
- ```
/apollo/env/SDETools/ruby2.1.x/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55: [BUG] Segmentation fault at 0x00000000000018
ruby 2.1.8p440 (2015-12-16 revision 53160) [x86_64-darwin15.0]
-- Crash Report log information --... -
- * node.c (dump_node): fix a typo, index and rvalue. fix
NODE_OP_ASGN1 operator to nd_mid. [Fix GH-1528]
Author: fate0 <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57718 b2dd03c8-39d4-4d8f-98... -
03:39 AM
Bug #13254 (Closed): Dir.exist? などで「ディスクがありません」ダイアログが表示される
- ## 概要
windows 10で使用しています。
sdカードリーダーにメディアを差していない状態で、同ドライブに Dir.exist? などを行うと、次のメッセージダイアログが表示されスクリプトの実行が一時停止します。
「キャンセル」か「続行」を2回クリックするとスクリプトが再開し、Dir.exist? であれば false を返します。
~~~
---------------------------
ruby.exe - ディスクがありません
--... -
- Applied in changeset r57717.
----------
parse.y: indent at invalid identifier
* parse.y (parser_heredoc_identifier): set indent only when valid
identifier, not to dedent non-existent contents later.
[ruby-core:79772] [Bug #13253] -
- * parse.y (parser_heredoc_identifier): set indent only when valid
identifier, not to dedent non-existent contents later.
[ruby-core:79772] [Bug #13253]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57717 b2dd03c8-39d4-4d8f-98ff-...
02/25/2017
-
- Argument names should be marked up using `+arg+`, or `_arg_`?
Although I've thought it would be `_` and there are such usage, `+` seems major? -
- FYI, here my suggestion (will commit soon, but need to read some HowTo's on how exactly that works, first):
``` patch
diff --git a/numeric.c b/numeric.c
index b34fb0a..2400a9c 100644
--- a/numeric.c
+++ b/numeric.c
@@ -5154,6 +... -
- Two clarifying questions:
Is it confirmed that using Floats will only give wrong results that are too large? _Update: no, too small also occurs._
See e.g. the case of cube roots:
``` ruby
64 ** (1.0/3) # => 3.9999999999... -
- Thank you, feel free to add it.
I was writing it too, but you'll make better one.
This is my draft, FYI.
```diff
diff --git c/NEWS i/NEWS
index 2a0413f006..8647e5e2ce 100644
--- c/NEWS
+++ i/NEWS
@@ -21,4 +21,8 @@ with all su... - 10:28 PM Revision e35907a4 (git): * 2017-02-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57716 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:28 PM Revision 8feb9779 (git): ext/win32ole/win32ole.c(ole_initialize): avoid to fail in Windows nano server.
- This is experimental. Thanks to mwrock, Ethan Brown.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57715 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Eric Wong wrote:
> No. There is existing code which assumes #freeze always returns
> ...
Oh indeed, that slipped my mind, thanks for the explanation. -
- [email protected] wrote:
> Eric Wong wrote:
> > Anyways, committed as r57698
>
> This should have a NEWS entry and tests since it changes the semantics.
Sorry, I forgot; will do. Thanks for the reminder.
> BTW, should my_s... -
- The examples confuse me a bit.
Does private actually make sense on any class-method / singleton method?
I understand it as a limitation for methods on the class, where outside
calls are not allowed, only internal ones (though ruby... -
07:11 AM Bug #13249: Access modifiers don't have an effect inside class methods in Ruby >= 2.3
- Well, ability to declare `private` methods inside class methods seems strange given that it's not possible to declare private methods inside instance methods:
~~~ ruby
class C
def foo
private def bar
end
end
end
C.n... -
05:38 PM Bug #13242: SIGSEGV in rb_bigzero_p()
- Nobuyoshi Nakada wrote:
> This is not vulnerability.
Right, I'm too fast ;-) -
- After some fuzz testing I found a crashing test case.
Git HEAD: fbd5cda6aad6db01bbca3d893a9970314a1bd52c
To reproduce: miniruby ruby_parse.rb
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57714 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r57713.
----------
bignum.c: improve estimate
* bignum.c (estimate_initial_sqrt, rb_big_isqrt): improve initial
estimate by sqrt(). [ruby-core:79754] [Feature #13250] -
- It would be nice if you backported this code into point releases of older versions too.
-
- * bignum.c (estimate_initial_sqrt, rb_big_isqrt): improve initial
estimate by sqrt(). [ruby-core:79754] [Feature #13250]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57713 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We never backport any bug fixes to 2.1 except security fixes as announce before:
https://www.ruby-lang.org/en/news/2016/02/24/support-plan-of-ruby-2-0-0-and-2-1/
If you nevertheless believe the documentation should be fixed, cont... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57712 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:25 AM Bug #13239: Bug with "special exceptions" when they are thrown in context of a rescue clause.
- Yes, that appears to be the case, thanks you.
-
- * .gdbinit (rp_bignum): print bignum from higher digits.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57711 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:31 AM Revision 15ef28a9 (git): NEWS: document String#-@ change
- * test/ruby/test_string.rb (test_uplus_minus): test deduplication
[ruby-core:79747] [Feature #13077]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57710 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It is not guaranteed that `ruby_xfree` can free a pointer allocated by other than `ruby_xmalloc` and so on.
You can't mix bare `malloc` and `ruby_xfree`. -
12:19 AM Feature #13252 (Assigned): C API for creating strings without copying
- Hi,
I'd like to have a C API that allows me to create String objects without copying the underlying `char *`. Basically a C API similar to the `rb_str_new_static`, but have the GC free the underlying `char *` when the object dies. T...