Activity
From 05/16/2017 to 05/22/2017
05/22/2017
- 11:41 PM Revision 40a99224 (git): * 2017-05-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:41 PM Revision 2ab82704 (git): variable.c (autoload_sleep_done): avoid needless list_node init
- We do not need list_del_init in ensure callbacks, only list_del,
since it can only ever be called after list_del_init... -
09:09 PM Bug #13589: unmatched opening backtick / closing quote in NoMethodError: undefined method `name' for {}:Hash
- Thought about it when trying to explain Struct vs OpenStruct on Stack Overflow :) https://stackoverflow.com/a/4412181...
-
- From [`error.c`](https://github.com/ruby/ruby/blob/trunk/error.c#L1953-L1964):
~~~ c
/*
* Document-class: NoMe... -
06:35 PM Feature #8631: Add a new method to ERB to allow assigning the local variables from a hash
- I'm actually fine with whatever name you prefer. result_with_locals and render_with_locals are both fine to me. Thank...
-
03:50 AM Feature #8631: Add a new method to ERB to allow assigning the local variables from a hash
- > Or maybe ERB.new(str, locals: {a: b}).result?
For this case, it would have the same problem as ERB.new(str).resu... -
04:15 PM Bug #13582 (Closed): IMAPTest#test_append_fail always errors on Windows
- shugo (Shugo Maeda) wrote:
> r58840 で対策してみましたがどうでしょうか？
手元で何度か試行してみた感じでは、大丈夫っぽく見えます。
rubyciでも問題が出なくなっているようです。
とい... -
06:14 AM Bug #13582: IMAPTest#test_append_fail always errors on Windows
- usa (Usaku NAKAMURA) wrote:
> r58792で追加されたテストですが、Windowsでは毎回Errorになります。
> assertion自体は通過してるっぽいですが、テストメソッドから抜ける際に
>... -
02:25 PM Revision 35695788 (git): source directory may not be writable
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:11 PM Feature #13588: Add Encoding#min_char_size, #max_char_size, #minmax_char_size
- Seems sensible to me. Guess someone from the ruby core team or matz should chime in and perhaps comment - or someone ...
-
12:10 PM Feature #13588 (Feedback): Add Encoding#min_char_size, #max_char_size, #minmax_char_size
- When implementing an IO-like object, I'd like to handle encoding correctly. To do so, I need to know the minimum and ...
-
11:36 AM Feature #13568: File#path for O_TMPFILE fds has no meaning
- nobu (Nobuyoshi Nakada) wrote:
> Once #13576 is introduced, this issue becomes stale.
> It doesn't make sense to ch... -
- Once #13576 is introduced, this issue becomes stale.
It doesn't make sense to change `File#path`. -
- nobu (Nobuyoshi Nakada) wrote:
> ```sh
> $ ./x86_64-linux/bin/ruby -e 'f = open(File.expand_path("/tmp"), File::RDW... -
- ```sh
$ ./x86_64-linux/bin/ruby -e 'f = open(File.expand_path("/tmp"), File::RDWR|File::TMPFILE); p open(f).read'
T... -
- shyouhei (Shyouhei Urabe) wrote:
> nobu (Nobuyoshi Nakada) wrote:
> > A correction; The method which `open` calls i... -
- nobu (Nobuyoshi Nakada) wrote:
> shyouhei (Shyouhei Urabe) wrote:
> > At the meeting we discussed the use case of `... -
- Took me time for several reasons:
1. Had temporarily ran out of my docker hosts and had to prepare new one. This ... -
- Agree, it has no meanings.
- 07:36 AM Revision cbedbaf9 (git): lib/net/protocol.rb: account read_bytes before caller sees it
- Users may modify the chunk yielded to them in Net::HTTPResponse#read_body.
This will allow users to reduce memory usa... -
07:13 AM Revision 5565fed8 (git): hash.c: [DOC] fix docs for Hash#transform_values!
- Hash#transform_values! returns the receiver rather than a new Hash
object.
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
- Otherwise literal data will be sent even if NO response is returned
because @exception is set to nil in receive_respo... -
- It reproduced "incorrect checksum for freed object", with a fix.
```diff
- Data_Wrap_Struct(rb_cData, NULL, du... -
05:05 AM Bug #12670: Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- nobu (Nobuyoshi Nakada) wrote:
> > ```c
> Data_Wrap_Struct(rb_cData, NULL, dummy_free, &i);
> ```
>
> Wrapp... -
- > ```c
Data_Wrap_Struct(rb_cData, NULL, dummy_free, &i);
```
Wrapping the pointer to a local variable?
Obvi... -
- I reduced repro codes, segv.c and segv.rb.
They cause assertion failure with RGENGC_CHECK_MODE=1.
```
ruby 2.5.0... -
- * tool/downloader.rb (Downloader.link_cache): on Cygwin, make true
symlink only, which is provided by the OS. as m... -
- Applied in changeset trunk|r58842.
----------
erb.rb: Skip creating regexp
if stags and etags are not changed from ... -
- if stags and etags are not changed from default.
:putobject insn (of regexp) will be used instead of :toregexp insn.... -
- * tool/downloader.rb (Downloader.download): just link to the cache
when downloaded to the cache but not the target ...
05/21/2017
- 11:52 PM Revision 8623ba86 (git): lib/net/protocol: clear short-lived read buffer
- Using a parallel Net::HTTP downloader, this reduced memory usage
from around 120MB to 50MB on my 32-bit x86 system.
... -
08:05 PM Bug #13312: String#casecmp raises TypeError instead of returning nil
- I did not include the type check in `str_casecmp`, which seems superfluous to me. I also adjusted the tests, docs, an...
-
- Applied in changeset trunk|r58837.
----------
string.c: fix String#{casecmp,casecmp?} for non-string arguments
* st... -
- * See https://bugs.ruby-lang.org/issues/13312
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58839 b2dd03c8-39d4-... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * string.c: make String#{casecmp,casecmp?} return nil for
non-string arguments instead of raising a TypeError.
* t... -
- * test/ruby/test_string.rb: add more test cases for String#casecmp.
* test/ruby/test_symbol.rb: ditto for Symbol#{cas... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Martin showed this example:
> class Array
> class << self
> alias :my_new :new
> end
Ruby allows thi... -
- > Given that it's very easy (as shown by Matthew) to create such a method, do you think it's necessary that this
> b... -
04:51 PM Feature #13587 (Closed): Improve performance of string interpolation
- This patch will add pre-allocation in string interpolation.
By this, unnecessary capacity resizing is avoided.
Fo... - 04:45 PM Revision 4a9a0eaa (git): * 2017-05-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58834 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/downloader.rb (Downloader.download): manage download cache.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58832 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/downloader.rb (Downloader::RubyGems.download): utilize
`dir` argument of Downloader.download.
git-svn-id: s... -
07:17 AM Bug #13191 (Open): sample/pty/shl.rb がうまく動かない
-
- Explicitly says that the methods return a new hash rather than just
stating it return a new something we don't know.
... -
03:36 AM Bug #13357 (Closed): Improve Time#+ & Time#- performance
- Applied in changeset trunk|r58829.
----------
Improve Time#+ & Time#- performance
* time.c (wadd): use internal add... -
- Applied in changeset trunk|r58828.
----------
Improve Time#<=> performance
* time.c (wcmp): use internal cmp() func... -
- * time.c (wadd): use internal addv() function to calculate internal value in
Time object. On 64-bit machine, Time... -
- * time.c (wcmp): use internal cmp() function for comparing internal Fixnum value
in Time objects. On 64-bit machi... -
- Use character class directly instead of
character class in character class.
git-svn-id: svn+ssh://ci.ruby-lang.org/r...
05/20/2017
-
11:32 PM Feature #13396: Net::HTTP has no write timeout
- [email protected] wrote:
> Only supports Linux:
...And only with sockets where O_NONBLOCK is not set, because
t... -
10:01 PM Feature #13396: Net::HTTP has no write timeout
- Only supports Linux:
```diff
@@ -10372,11 +10383,23 @@ static int
nogvl_wait_for_single_fd(int fd, short events... -
- The concept Net::HTTP#write_timeout sounds fine.
> However adding a Timeout.timeout call around req.exec did work.... -
- I would already suggest a new name when I read about the problems with overriding the current method, so I would agre...
-
-
- I think the names are good, both #transform_keys and #transform_values.
Seem quite clear to me from the names.
... -
08:56 AM Feature #13583: Adding `Hash#transform_keys` method
- I don't think you missed anything, except I would just point out to also add `Hash#transform_keys!`. I don't know if ...
-
- Thank you for issuing this. I see there is an obvious needs for this transformation (stringify_keys) so I'm :+1: to ...
-
06:55 PM Bug #13566 (Assigned): A process freezes at the beginning of C level backtrace when a certain SEGV is occurred
- This issue is not only for NULL but also the other address such as 0x00000000000001.
```
$ ruby -r fiddle -e 'Fid... -
- Hanmac (Hans Mackowiak) wrote:
> as Sorah did there: https://github.com/aws/aws-sdk-ruby/pull/1516
> i would sugges... -
- to unify a behavior with r58823 and r58825.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58826 b2dd03c8-39d4-4d... -
- Applied in changeset trunk|r58825.
----------
erb.rb: Allow explicit trimming carriage return
when trim_mode is "-"... -
- when trim_mode is "-", for Windows environments.
[ruby-core:39625] [Bug #5339]
git-svn-id: svn+ssh://ci.ruby-lang.o... -
- The current maintainer suggested this in ruby-dev:50113.
Please ping me if an issue happens in ERB.
git-svn-id: svn+... -
- Applied in changeset trunk|r58823.
----------
erb.rb: Allow trimming carriage return
when trim_mode is "<>", for Wi... -
- when trim_mode is "<>", for Windows environments.
[Bug #11464]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58... -
04:36 PM Bug #13586 (Closed): Ruby hangs when accessing array which is modified in instance_eval after Coverage.start
- The following code will hang ruby:
~~~
# main.rb
require "coverage"
Coverage.start
require_relative "./f... -
- of LoadError in some method calls, not from `require "strscan"`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5... - 03:58 PM Revision 9aa33d5d (git): * 2017-05-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58820 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Original `SimpleScanner` was used only in tests.
Since `SimpleScanner` and `SimpleScanner2` work in the same way, I w... -
- > Can you handle this?
Ok. - 01:00 PM Revision f1e10bd2 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:00 PM Revision 33710d45 (git): Add coverage measurement mode by using gcov
- This experimental feature is only for Ruby-core team, not for casual users.
Usage: `./configure --enable-gcov && mak... -
- shyouhei (Shyouhei Urabe) wrote:
> At the meeting we discussed the use case of `File#path` and we thought there are ... -
07:20 AM Feature #13568: File#path for O_TMPFILE fds has no meaning
- like i said, open with write mode is the problem.
because it didn't fail with the nonexistent path
an way for it ... -
- At the meeting we discussed the use case of `File#path` and we thought there are 2 kinds:
- Pass it to `open()`
-... -
- The order of sed commands in Makefile of ripper was wrong: it tries to
replace `y.tab.c` with `ripper.c`, but before ... -
- * compile.c (compile_branch_condition, iseq_compile_each0):
eliminate unreachable branches in NODE_IF.
git-svn-id:... -
- * compile.c (compile_branch_condition): turn recursion at binary
logical operator into loop by goto, and check the ... -
- * test/test_prime.rb: remove alias after timeout test.
* lib/prime.rb: fix typo.
git-svn-id: svn+ssh://ci.ruby-lang... -
- r58812
-
09:47 AM
Feature #9632 (Closed): [PATCH 0/2] speedup IO#close with linked-list from ccan
- Applied in changeset trunk|r58812.
----------
speed up IO#close with many threads
Today, it increases IO#close perf... - 09:47 AM Revision 508091d9 (git): speed up IO#close with many threads
- Today, it increases IO#close performance with many threads:
Execution time (sec)
name trunk after
... -
- @marcandre
I actually was working on the essentially same fix for the test case and about to commit; only I did wa... -
12:39 AM Bug #13492 (Closed): Integer#prime? and Prime.each might produce false positives
- Good catch.
I tweaked the timeout test by patching `Integer.sqrt`.
-
- Applied in changeset trunk|r58811.
----------
Improve Hash#merge performance
* hash.c (rb_hash_merge): use rb_hash_... -
- * hash.c (rb_hash_merge): use rb_hash_dup() instead of rb_obj_dup() to duplicate
Hash object. rb_hash_dup() is fa... -
- ruby 2.4.2p131 (2017-05-10 revision 58637) [x86_64-linux] で試してみたところ、 r57530 も backport しないと C-z がきかないようです。
exit した... -
05:14 AM Bug #13578: Another iseq_set_sequence: adjust bug
- Thank you. While your test code does NOT repro under 2.4.1p111, it does under trunk. I've verified that this and my o...
-
-
05:03 AM Feature #13585 (Rejected): select! and reject! do not returns the same array in specific situations
- This can be surprising, but it's in line with many other destructive methods. It can be very useful when writing a lo...
-
- FYI it is intentional for this feature being automatically enabled right now, instead of some configuration like the ...
-
- * compile.c (remove_unreachable_chunk): do not eliminate chunks
followed by labels in catch-table entries.
git-svn... - 12:36 AM Revision 68354c35 (git): lib/prime: Fix primality of some large integers [#13492].
- * lib/prime.rb: Use accurate sqrt to insure all factors are tested.
Patch by Marcus Stollsteimer.
* test/test_prim... -
12:27 AM Feature #13581: Syntax sugar for method reference
- Why the version with symbol (`Math->:sqrt`) needs to be supported?
05/19/2017
-
11:39 PM Revision 825a1e93 (git): Merge gemspec from ruby/fileutils.
- * Replaced homepage option to source code location as github.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5880... -
10:32 PM Feature #13585: select! and reject! do not returns the same array in specific situations
- It's pretty clearly documented:
"If changes were made, it will return `self`, otherwise it returns `nil`." -
09:48 PM Feature #13585 (Rejected): select! and reject! do not returns the same array in specific situations
- When all elements are returned on select!, the method returns nil.
~~~
(main) normal> [1,2,3].select! { |x| x == ... - 09:34 PM Revision c018d464 (git): fix off-by-one in r58806
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58807 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:33 PM Revision b9f8fc51 (git): test/ruby/test_io.rb: new test for IO.select exception set
- Ensure this rarely-used feature of IO.select continues
to work properly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby... -
- watson1978 (Shizuo Fujita) wrote:
> naruse (Yui NARUSE) wrote:
> > Hmm, the result shows clang is not efficient as ... -
07:53 PM Bug #13584 (Third Party's Issue): Crash in logging (os_log) on MBP
- .rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/httpclient-2.7.1/lib/httpclient/session.rb:597: [BUG] Segmentation fau...
-
07:04 PM Bug #13542: MinGW trunk Builds - Summary of Issues
- Built `ruby 2.5.0dev (2017-05-20 trunk 58803) [x64-mingw32]` and removed all encoding related settings, and also any ...
-
06:53 PM
Feature #13552 (Closed): [PATCH 0/2] reimplement ConditionVariable, Queue, SizedQueue using ccan/list
- Applied in changeset trunk|r58805.
----------
thread_sync.c: rewrite the rest using using ccan/list
The performance... -
- [email protected] wrote:
> > https://80x24.org/spew/20170519034419.GA29820@whir/raw
>
> Thank you. Adding `const` he... -
06:39 AM Feature #13552: [PATCH 0/2] reimplement ConditionVariable, Queue, SizedQueue using ccan/list
> https://80x24.org/spew/20170519034419.GA29820@whir/raw
Thank you. Adding `const` helps us to recognize.
```...-
- [email protected] wrote:
> Sorry for late response.
No problem.
> Only one comment (maybe you passes all of tests... -
- Sorry for late response.
Only one comment (maybe you passes all of tests, right?)
New data type should be RUBY_... - 06:53 PM Revision ea1ce47f (git): thread_sync.c: rewrite the rest using using ccan/list
- The performance improvement increases as the number of waiters
increases, due to avoiding the O(n) behavior of rb_ary... -
- As mentioned in [13542](https://bugs.ruby-lang.org/issues/13542), I have not had a failure with this for a while, eve...
-
- 06:34 PM Revision 44e48eca (git): thread_sync.c: rename mutex_waiter struct to sync_waiter
- We will reuse this struct for ConditionVariable, Queue, and SizedQueue,
so it is no longer Mutex-specific.
git-svn-i... -
- In 2.4, new useful method `Hash#transform_values` was added. I would like to propose also adding matching method `Has...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58803 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This is intended. If a method accepts keyword arguments and if its last argument is a hash object, it is considered ...
-
- mame-san: what do you think about it?
-
- Umm, I noticed that actually the length of "ERB.new(*).result(locals: {a: b})" is the same as "ERB.new("aaa").result_...
-
- I found that my suggestion is a little hard to implement to avoid argument modification. It got a little ugly https:/...
-
- Applied in changeset trunk|r58801.
----------
Net::HTTP::STATUS_CODES is added as HTTP Status Code Repository [Misc ... - 04:06 PM Revision 83af1c6a (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58802 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Note that 418 I'm a teapot doesn't exist because RFC 2324 and
RFC 7168 are not registered in IANA repository.
https:/... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58800 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- r58792で追加されたテストですが、Windowsでは毎回Errorになります。
assertion自体は通過してるっぽいですが、テストメソッドから抜ける際に
@receiver_thread の中でErrno::ECONNRE... -
- Applied in changeset trunk|r58798.
----------
Net::HTTP#start now pass :ENV to p_addr by default [Bug #13351]
To av... - 03:13 PM Revision 61bbe32c (git): * 2017-05-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58799 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- To avoid this, pass nil explicitly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58798 b2dd03c8-39d4-4d8f-98ff-... -
- * compile.c (dump_disasm_list_with_cursor): improve disassemble
list. show whole elemetns and mark the current ele... -
- my current thinking is if that short form should do symbol support.
if `Math->sym` should be supported, than the n... -
- The **`->`** was just a suggestion... Could be another symbol or combination of symbols like **`Math->>sqrt`**, **`Ma...
-
- that might collide with `-> {}` a lambda syntax
so i think the chances are low that ruby gets something like that.
... -
- Some another programming languages (even Java, in version 8) has a cool way to refer a method as a reference.
I wr... -
- Applied in changeset trunk|r58796.
----------
Merge latest dtoa.c [Bug #13545]
Apply some part of http://www.netlib... -
- Apply some part of http://www.netlib.org/fp/dtoa.c with my eyes...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... -
- Thank you for your confirming.
I enforced https on all of lists.ruby-lang.org.
If you faced some issue, Please re... - 12:44 PM Revision a4d51619 (git): Of course, opened file is not able to unlink on Windows
- * test/test_tempfile.rb (test_create_with_block): close the tempfile before
unlink. fixed a failure on Windows int... -
- as Sorah did there: https://github.com/aws/aws-sdk-ruby/pull/1516
i would suggest that Digest should try to read fil... -
- Digest::SHA256.file()'s first argument is file path name but it accidentally accepts file object.
But for file objec... -
- i think returing an unexisting path whould be way problematic if it isnt checked if it exist.
other functions might ... -
09:17 AM Feature #13568 (Assigned): File#path for O_TMPFILE fds has no meaning
- We discussed about this today in [DevelopersMeeting20170519Japan](https://bugs.ruby-lang.org/projects/ruby/wiki/Deve...
-
10:49 AM Bug #13580: bug
- on second run
~~~
~/projects/ngrx-todolist with_jsonapi_suite clear; rspec spec/api/comments/create_spec.... -
- https://pastebin.com/raw/NJ6QCggq
repository state when bug occurred https://github.com/BjornMelgaard/ngrx-todolis... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58794 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:35 AM Bug #13492: Integer#prime? and Prime.each might produce false positives
- The patch seems good.
-
- Further reduced via IRC:
~~~ ruby
def process_defn
if false
case 42
when s {} then
when 42 then... -
- This seems to be related to #12613
~~~ ruby
#!/usr/bin/env ruby -w
def process_defn
if true then
# not... -
09:29 AM Bug #13315: Single "%" at the end of `printf` format string appears in the result
- When I wrote the original code, it was intentional, but without any specific reason.
It's OK for me to raise an erro... -
- 09:25 AM Revision 940f32eb (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58793 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [ruby-dev:50129] [Bug#13579]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58792 b2dd03c8-39d4-4d8f-98ff-823fe69... -
- Net::IMAP#append blocks when a NO response is received.
For example, if the destination mailbox doesn't exist, Net::... -
- * lib/tempfile.rb (Tempfile.create): should not fail even if the
temporary file has been removed in the block, just... -
- Looks good to me.
Matz.
-
- Sounds good.
Matz.
-
- +1 for Dir.children
-
- There is `Pathname#children` and `Pathname#each_child`.
How about `Dir.children` and `Dir.each_child` ? -
- I think it would make generator happy.
-
- It should be done by gem.
This will depends Unicode CLDR, and it's beyond Ruby itself's scope. -
- [Feature #13568] sheds light on situations where a File might not have its corresponding path. I understand that thi...
-
- I reject the proposal.
It may be useful for some application, I admit, but it is not the language matter.
Matz. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58790 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- How about that matching indentation of `=begin` and `=end`?
```ruby
=begin
in a comment
=end
sti... -
- vp (Vladimir Pavlov) wrote:
> Particularly, you assign the result of setjmp() call to a variable.
It is not assig... -
- Today, it increases IO#close performance with many threads:
Execution time (sec)
name trunk afte... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58789 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * method.h (rb_method_definition_t#type): specify unsigned explicitly.
Some compilers (includes VC) returns negative... -
- keysen (Jérémy Carlier) wrote:
> When connecting using TLS to an unresponsive SMTP server, Net::SMTP can hang until ... -
- I will insert warning.
I will not change the current behavior.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58787 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Matz approved it.
-
-
- I think there is no problem with time.rb.
I don't want to change the day format in time.rb
because the current be... -
- @stomar
It should return nil same as other comparison methods. Can you handle this? -
- Applied in changeset ruby-trunk:trunk|r58786.
----------
eval_error.c: enrich backtrace
* eval_error.c (print_backt... -
-
- Applied in changeset ruby-trunk:trunk|r58785.
----------
Add NEWS about [Feature #8661] -
- We expect some people may object this.
Therefore we're gathering feedback now (so thank you for your feedback).
T... -
- * eval_error.c (print_backtrace): add frame number when printing
in reverse order. [Feature #8661]
git-svn-id: sv... -
- Could you tell us more details? Your sample code and acquired errors (or output).
-
- Fundamentally, we can't control machine stack overflow.
We will improve the situation (but can't solve completely).
-
- This is specification.
(1) parse `example` method and define `foo`.
(2) In `eval` method, compile given string (`... -
- Thank you. I'll commit it.
-
- ```
def foo
puts caller(0) # (1)
end
def bar
p 0
begin # (3)
p 1
raise
p 2
rescue
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58785 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Agreed with better message description.
Matz.
-
06:00 AM
Feature #13494 (Closed): [PATCH] pack rb_method_definition_t struct
- Applied in changeset trunk|r58784.
----------
method.h: pack rb_method_definition_t struct
We only have 12 method t... -
- Sorry for late response.
No problem.
Thanks,
Koichi - 06:00 AM Revision f82a9304 (git): method.h: pack rb_method_definition_t struct
- We only have 12 method types, so 4 bits is enough for
rb_method_type_t.
Size reductions:
- x86-64 48 => 40 byte... -
- I reject this ticket with the reason #5.
-
- Sorry for late response.
Unfortunately I have no enough disk to run docker. Try later when I get new machine.
-
-
- I close this ticket because we need long-time effort.
> Also, can we introducing it in 2.5?
> (keeping compatibil... -
- Sorry for late response.
Basically, TracePoint should be implementation independent.
(so that `:c_call, :c_return... -
- Sorry for late response.
> we may want to drop OpenBSD <5.2 support
On https://bugs.ruby-lang.org/projects/ruby... -
- Backport r57248.
-
- I think Ruby 2.4.x on Mac 10.5.x is not a supported combination. The proposed patch _seems_ fine though. I no longe...
-
- graywolf (Gray Wolf) wrote:
> You said
>
> > you need to start discussing about transform_keys if you want that
... -
12:25 AM Feature #13574: Method redefinition warning
- As there's no other way to silence the redefinition warning (apart from removing the method first, which isn't atomic...
-
12:07 AM Feature #13574 (Open): Method redefinition warning
- Hi,
If I redefine a method like this, I get a warning:
~~~ruby
class Foo
def bar
end
end
class Foo
...
05/18/2017
-
- I think emulating the behaviour of
```ruby
[2] pry(main)> Hash[{ a: 1, b: 2 }.map { |key, value| [:s, value] }]
... -
- This issue has no move so far. I think you need to start discussing about transform_keys if you want that. It has o...
-
07:25 PM Bug #13573 (Closed): Compilation on Mac OS X 10.5.8 fails because of missing _fgetattrlist
- When compiling Ruby 2.3.x and 2.4.x on Mac OS X 10.5.8, compilation fails with:
~~~
linking miniruby
Undefined s... -
- [email protected] wrote:
> thread_sync.c: rename mutex_waiter struct to sync_waiter
> thread_sync.... -
- > Whitespace isn't the issue here
That's wrong. Definitely whitespace matters. If you change to use a following t... -
- which I introduced at r58773.
Hard tabs and spaces are mixed...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58... - 03:06 PM Revision 0ea0f07f (git): * 2017-05-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58782 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * common.mk (parse.c): replace source file name in #line pragmas
with the path in the source directory, so that bin... -
- There's a problem that a receiver is unclear and not configurable if argument is only a Hash object. To address the p...
-
01:55 PM Bug #13040: syslog/logger uses "require 'logger'" which is interpreted as circular dependency
- Am I the only person having this problem? This is in different code sources we are maintaining. Here is the latest. I...
-
- Yet another proposal: https://twitter.com/yancya/status/865070681213386756
```ruby
just do it.! end
``` -
- * dir.c (rb_dir_getwd): get rid of potential memory leak.
* util.c (ruby_getcwd): ditto.
git-svn-id: svn+ssh://ci.r... -
- marked
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:42 AM Revision 83b7e0bd (git): * 2017-05-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58778 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Patch by @joshpencheon (Josh Pencheon)
[fix GH-1607]
#### benchmark-ips results
```
trunk:
Warming up ----...
05/17/2017
-
- What's the status on this? In #12512, only Hash#transform_values was added, should I bother making patch adding Hash#...
-
09:46 PM Bug #13572 (Closed): Please backport r53400 to 2.3
- r53400 fixes a bug in which `includedir`, instead of `oldincludedir`, is inappropriately prefixed with `SDKROOT`. Thi...
-
- The following is windows/MinGW specific.
I have been patching around a failure in [TestRubyOptions#test_command_li... -
- * spec/rubyspec/command_line/dash_upper_s_spec.rb: enable tests on vboxsf
(VirtualBox shared directory) and change ... -
02:14 PM Feature #12996: Optimize Range#===
- I updated the patch (range_eqq2.patch).
It optimize only special cases.
---
# Range with Fixnum
~~~
i = ... -
- for future backport to ruby/spec repository.
See r58772 r58773 r58774.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- to make it compatible with ERB::Util.url_encode.
ext/cgi/escape/escape.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang... -
- Applied in changeset trunk|r58772.
----------
erb.rb: Don't encode tilde in #url_encode
Based on patch by madeofcod... -
- It's now close to 19 years since RFC 2396, so please fix this issue, thanks!
-
- Based on patch by madeofcode (Mark Dodwell).
[ruby-core:46168] [Bug #6696] [Fix GH-54]
`~` is a unreserved character... -
10:45 AM Feature #13396: Net::HTTP has no write timeout
- > I would also like to add native timeout support to IO.copy_stream
That would be the best indeed. -
- * spec/rubyspec/command_line/dash_upper_s_spec.rb:
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58771 b2dd03c8... -
- Applied in changeset trunk|r58770.
----------
Optimize CSV#shift.
[Bug #12373][ruby-core:75462]
Patch by Yuki K... -
- @hsbt
Good, Thank you for confirming and managing. -
- Ah,
>Should we use @double_quote_char instead of @quote_char ?
`@quote_char` is wrong. I intended to write `@q... -
- @hsbt
Thank you for responding.
csv-shift-hsbt.patch looks good to me.
> Should we use @double_quote_char inst... -
- [Bug #12373][ruby-core:75462]
Patch by Yuki Kurihara.
Benchmark:
```
Warming up ----------------------------... -
- Applied in changeset trunk|r58769.
----------
Treat NULL reference case [Bug #13566] -
- It can be reproducible on Ruby 2.2.7, too.
```
$ RBENV_VERSION=2.2.7 ruby -rfiddle -e 'Fiddle::Function.new(Fiddl... -
- I confirmed that it is reproducible on Ruby 2.3.3.
```
$ RBENV_VERSION=2.3.3 ruby -r fiddle -e 'Fiddle::Function.... -
- A small code to reproduce this issue is here:
```ruby
require 'fiddle'
Fiddle::Function.new(Fiddle::NULL, [], Fi... -
- mrkn (Kenta Murata) wrote:
> r15: 0x00007fff577eb7d0 rip: 0x0000000000000000 rfl: 0x0000000000010246
rb_dump_mac... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58769 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- https://github.com/k-takata/Onigmo/commit/1364ae3488cac0acbf2d61ef3ce2b62fe0c0f528
git-svn-id: svn+ssh://ci.ruby-lan... -
- * ruby.c (process_options): encode script name to locale encoding
instead of associate, if UTF-8 path.
git-svn-id:... -
- * .gdbinit (nd_tree): use rb_str_tmp_new to get rid of
`__extension__'.
git-svn-id: svn+ssh://ci.ruby-lang.org/rub... -
- Name proposal - cede
```ruby
url.cede { |u| open(u).read } # return "itself -> fetch from the network"
``` -
- Well, I know everyone don't like the name yield_self but, it seems that's a separate issue than this one. Can we foc...
-
- * test/ruby/test_dir_m17n.rb (test_entries_compose): read in
filesystem encoding instead of default external encodi...
05/16/2017
- 11:59 PM Revision 8dbf0f2a (git): Revert "test/test_extilibs.rb: do not check the existence of fiddle"
- This reverts r58761 since fiddle is considered critical.
[ruby-core:81201] [ruby-core:81203]
git-svn-id: svn+ssh://c... - 11:15 PM Revision 6e7dfec8 (git): ENV["HOME"] is prior as home on Windows
- * spec/rubyspec/core/dir/home_spec.rb: ENV["HOME"] is prior as home on Windows.
reported by ko1.
git-svn-id: svn+... -
- * defs/gmake.mk (TEST_DEPENDS): check and more tests targets need
all to be built.
git-svn-id: svn+ssh://ci.ruby-l... - 10:05 PM Revision c836e8dd (git): test/test_extilibs.rb: do not check the existence of fiddle
- libffi is not installed on all systems, and is not needed
for most of the tests.
Tested on a fresh FreeBSD 11.0 VM
... -
- > Does mkmf works well on Windows?
I'm not a c type. With MinGW builds, I've got 89 mkmf.log files in the build d... -
12:47 PM Feature #13570 (Closed): Using mkmf for ruby/spec C API specs
- Hello all,
I am thinking to use mkmf to compile the C API specs.
https://github.com/ruby/ruby/blob/trunk/spec/r... - 04:16 PM Revision b1d57ac6 (git): Should require at spec file, not fixture file
- Fixed ERRORs at non-Windows platforms.
* spec/rubyspec/library/win32ole/fixtures/classes.rb (require): removed.
* s... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58759 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:45 PM Revision 10f713e4 (git): Should require WIN32OLE
- * spec/rubyspec/library/win32ole/fixtures/classes.rb: should require WIN32OLE
here because this file causes NameErr... - 03:17 PM Revision ec5e5c09 (git): * 2017-05-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58757 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/lib/test/unit.rb (_run_parallel): flush job tokens after
quitting workers when normally finished too.
git-s... -
- * test/ruby/test_process.rb (test_execopts_open_chdir_m17n_path):
compare directory name in UTF-8. encoding of `Di... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58754 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58753 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58752 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:50 PM Revision 8dd82a3e (git): * common.mk (help): get rid of make error with nmake.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58751 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58750 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58749 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58748 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Avoids a race between finding an available port and another process starting a server on it.
git-svn-id: svn+ssh:/... - 12:15 PM Revision 35da88e6 (git): Rename rubyspec to spec
- * common.mk (*-rubyspec): rename to *-spec because rubyspec is historical name.
of course, *-rubyspec are still ava... -
- sorah (Sorah Fukumori) wrote:
> it would be happier if we can get all of source locations where a class opened?
I... -
- * dir.c (rb_dir_getwd): convert from UTF-8.
* win32/win32.c (w32_getcwd): codepage aware getcwd using
GetCurrentDi... -
- Patch by @cllns. [Fix GH-957]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58744 b2dd03c8-39d4-4d8f-98ff-823fe6... -
- Applied in changeset trunk|r58743.
----------
Added accessor of original line when parsing.
[Feature #11865][ruby... -
- [Feature #11865][ruby-core:72452][fix GH-1170]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58743 b2dd03c8-39d4... -
- @ksss
I confirmed your patch and benchmark results.
```
Warming up --------------------------------------
... - 08:03 AM Revision 59faac61 (git): Search SSL libraries by testing various filename patterns
- * ext/openssl/extconf.rb (find_openssl_library): should search by more flexible
method, especially for LibreSSL on ... -
- I've confirmed that this issue isn't reproduced on x86_64-linux.
-
- Hanmac (Hans Mackowiak) wrote:
> shyouhei (Shyouhei Urabe) wrote:
> > The patch seems okay to me, but honestly I do... -
- shyouhei (Shyouhei Urabe) wrote:
> The patch seems okay to me, but honestly I don't see any practical use case of it... -
- The patch seems okay to me, but honestly I don't see any practical use case of it. Do you nedd this?
-
- * lib/rubygems/ext/ext_conf_builder.rb (build): needs to close
before unlink on Windows.
git-svn-id: svn+ssh://ci.... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58740 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I guess it was fixed at r41853 before v2_1_0_preview1 and backported to ruby2_0_0 at r41946 [Backport #8633].
-
- It seems that original issue is resolved https://github.com/gurgeous/teleport/issues/22.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58739 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:59 AM Feature #13563: Implement Hash#choice method.
- At first, I overlook Hash#slice method. Sorry...
And, I reconsider about it.
I feel that Hash#slice is wrong na... -
- On 2017/05/15 20:31, [email protected] wrote:
> I think using Exception#cause for this would be a better way to ad... -
- Supporting this kind of behavior doesn't make sense to me. Suppose following erb template:
~~~ erb
foo <% # comme... -
- Applied in changeset trunk|r58737.
----------
enable ruby_w32_codepage on cygwin
* debug.c, localeinit.c: enable ru... - 12:15 AM Revision 1fc689d9 (git): * 2017-05-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58738 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * debug.c, localeinit.c: enable ruby_w32_codepage on cygwin too.
[ruby-core:81163] [Bug #13567]
git-svn-id: svn+ss...
Also available in: Atom