Activity
From 06/22/2017 to 06/28/2017
06/28/2017
-
08:57 PM Bug #13695: Issue with require and require_relative with symlinked directories
- [rspec-duplicate-require](https://github.com/wconrad/rspec-duplicate-require) shows that this behavior has been aroun...
-
07:41 PM Bug #13695 (Closed): Issue with require and require_relative with symlinked directories
- Symlinked directories cause an issue with require_relative where libraries loaded from a symlinked path (e.g. in a ty...
-
07:23 PM
Feature #13692: Array#index?
- This feature may not be that good, I agree. :)
I thought it could occasionally be useful when querying arrays. For... -
05:57 PM Feature #13692: Array#index?
- I am not sure if there is a huge need for it - and I am usually saying yes to lots of stuff. :)
I think another pr... -
03:35 PM Feature #13692: Array#index?
- > this is sometimes useful to check if an array index exists.
I couldn't imagine the situation that needs to check... -
03:24 PM
Feature #13692: Array#index?
- Or is this feature too trivial ?
-
02:43 PM
Feature #13692 (Rejected): Array#index?
- Hello!
We currently have these methods:
~~~
Hash#key(value)
Hash#key?(key)
Array#index(value)
~~~
I was ... -
06:34 PM Feature #13694 (Rejected): Add Tau constant to Math
- Duplicate of #4897, which matz rejected 7 months ago.
-
06:05 PM Feature #13694 (Rejected): Add Tau constant to Math
- Today (June 28) is **Tau Day**! to honor the true circle constant **tau = 2*pi = 6.28**.
Michael Hartl (https://ta... -
- I think you are right, due to the behaviour of '1e+3'.to_i alone. Perhaps it was forgotten?
-
05:39 PM Feature #13693 (Rejected): Allow String#to_i and / or Kernel::Integer to parse e-notation
- `Kernel` can properly convert e-notation strings into numeric objects:
```ruby
Float('1e+3') #=> 1000.0
R... -
- Hmm you are right. That's interesting. I may be wrong but this may possibly be a limitation of the
parser, otherwise... -
11:57 AM Bug #13691 (Rejected): Word- and symbol array literals not valid where regular array is
- Not sure if this is a limitation of the design space in the parser, or just a missed edge case. (Note that a regular ...
-
- shyouhei (Shyouhei Urabe) wrote:
> we would like to to merge this issue with #12732. How do you feel, Stefan?
I'... -
03:25 PM Bug #13689 (Closed): `Thread#inspect` affect Fiber switching
- Applied in changeset trunk|r59200.
----------
introduce rb_fiber_t::first_proc.
* cont.c (rb_fiber_t): add rb_fiber... -
- `Thread#inspect` shows different results when Fiber is switched.
I believe it isn't intended behavior.
```
Thr... - 03:25 PM Revision f7349819 (git): * 2017-06-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59201 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * cont.c (rb_fiber_t): add rb_fiber_t::first_proc and do not use
rb_thread_t::first_proc which should be thread loc... -
02:35 PM Feature #13681: Ruby digest init fails in FIPS mode when built against OpenSSL ~> 1.0.1
- rhenium (Kazuki Yamaguchi) wrote:
> rinzler (Colton Jenkins) wrote:
> > > > ```diff
> > > > + rb_raise(rb_eRunt... -
- * vm_core.h (rb_thread.h): move errinfo and trace_arg to
rb_execution_context_t.
* cont.c (fiber_switch, rb_cont_c... - 10:18 AM Revision 75392e45 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:18 AM Revision 9ec55ed9 (git): Added sync tool for default gems from github master.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59197 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:55 AM Bug #13690 (Closed): next in once causes [BUG]
- Thought it was a variant of #13680, but turned out to be a different story.
-
07:05 AM Feature #9145 (Open): Queue#pop(true) return nil if empty instead of raising ThreadError
-
06:22 AM Feature #13683: Add strict Enumerable#single
- `Enumerable#first` returns not only the first element, the elements at the beginning up to the number given by an opt...
-
01:15 AM Feature #13683: Add strict Enumerable#single
- shevegen (Robert A. Heiler) wrote:
> What would the results be for the following code? In ruby (I find
> it easier ... -
- * parse.y (parser_parse_string): return proper token tREGEXP_END
at unterminated regexp. [Bug #13363]
git-svn-id:... -
- * vm_core.h (rb_thread_t): move root_lep, root_svar and ensure_list
to rb_execution_context_t.
git-svn-id: svn+ss... -
- * parse.y (parser_yyerror): add ellipsis properly when error line
is truncated.
git-svn-id: svn+ssh://ci.ruby-lang... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59193 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_core.h (rb_thread_ptr): added to replace GetThreadPtr() macro.
* thread.c (in some functions: use "target_th" i... -
- * parse.y (parser_number_literal_suffix, parse_numeric): flush
numeric token so following unexpected token part is ... -
- Passing the attached file makes hang.
-
03:13 AM Bug #13605: GC bug calling `ObjectSpace.each_object`
- `git bisect` shows that the issue is come from r55766 [Feature #12628].
This commit is in ruby_2_4, but not in ruby_... -
- Is this same to #13605 and fixed at r59063?
-
- * vm_core.h (rb_thread_t): move storages to rb_execution_context_t.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tru... -
02:28 AM Revision b3f38b57 (git): add two tests
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59189 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r59188.
----------
parse.y: fix parser_yyerror
* parse.y (parser_yyerror): fix buffer ov... -
- * parse.y (parser_yyerror): fix buffer overflow at truncation of
error line. [ruby-core:81790] [Bug #13687]
git-s... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59187 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I guess it is the same issue as #13605 because of the log pattern.
(using pry, T_NONE, newobj_slowpath_wb_protected ...
06/27/2017
-
11:19 PM Feature #13683: Add strict Enumerable#single
- +1. I always feel uncomfortable whenever using `first` for this purpose.
-
- I am not against or in favour of it but just a question.
What would the results be for the following code? In ruby... -
10:17 AM Feature #13683: Add strict Enumerable#single
- +1, I have found this useful a few times as well.
Usually, I just define my own on Array, but it makes sense as well... -
06:08 AM Feature #13683 (Feedback): Add strict Enumerable#single
- ### Summary
This is inspired by other languages and frameworks, such as LINQ's [Single](https://msdn.microsoft.com... -
11:16 PM Bug #13614 (Closed): IFMapper v2.0.4 crashes on Windows FXRuby
- It is fixed in the latest FXRuby release.
-
- Yay! More Emoji tokens to create games in pure ruby with these tokens! :D
One day I shall have a game with the uni... -
- Unicode 10.0.0 was published about a week ago (see
http://blog.unicode.org/2017/06/announcing-unicode-standard-versi... -
- Applied in changeset trunk|r59185.
----------
downloader.rb: get rid of symlinks
* tool/downloader.rb: do not save ... -
06:40 AM Bug #13684 (Closed): Snapshots are broken
- `make install` of the ruby from snapshot fails with message:
~~~
$ make install DESTDIR=/builddir/build/BUILDROOT... - 05:10 PM Revision d68773fd (git): * 2017-06-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59186 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/downloader.rb: do not save downloaded files to cache.
[ruby-core:81780] [Bug #13684]
git-svn-id: svn+ssh://... -
- Applied in changeset trunk|r59184.
----------
fix return in toplevel ensure
* compile.c (iseq_compile_each0): adjus... -
- Seems incomplete.
```
% ./miniruby -ve 'begin raise ensure return end and self'
ruby 2.5.0dev (2017-06-27 trunk ... -
- Applied in changeset trunk|r59183.
----------
fix return in toplevel rescue/ensure
* compile.c (iseq_compile_each0)... -
- Attached script causes [BUG] Stack consistency error (sp: 7, bp: 6)
-
- * compile.c (iseq_compile_each0): adjust stack after return in
toplevel ensure, when the value is used.
[ruby-cor... -
- Yet another instance of this issue:
https://github.com/socketry/timers/pull/63 -
- Attached file, when passed to ruby, dumps core.
-
12:58 PM Feature #13686 (Closed): Add states of scanner to tokens from Ripper.lex and Ripper::Filter#on_*
- I'm writing syntax analysis software by pure Ruby, for processing Ruby's source code and meta information what are cl...
-
09:26 AM Feature #13681: Ruby digest init fails in FIPS mode when built against OpenSSL ~> 1.0.1
- rinzler (Colton Jenkins) wrote:
> > > ```diff
> > > + rb_raise(rb_eRuntimeError, error_message); \
> > > + } \... -
- nobu (Nobuyoshi Nakada) wrote:
> rhenium (Kazuki Yamaguchi) wrote:
> > > ```diff
> > > + error_message = ERR_re... -
- rhenium (Kazuki Yamaguchi) wrote:
> > ```diff
> > diff -Nurp old/ext/digest/digest.h new/ext/digest/digest.h
> > -... -
- rhenium (Kazuki Yamaguchi) wrote:
> > ```diff
> > + error_message = ERR_reason_error_string(ERR_peek_last_error(... -
- > ```diff
> diff -Nurp old/ext/digest/digest.h new/ext/digest/digest.h
> --- old/ext/digest/digest.h 2017-06-21 12:... -
- When FIPS (https://en.wikipedia.org/wiki/FIPS_140-2) is enabled attempting to initialize any digest will kill the pro...
-
- * compile.c (iseq_compile_each0): throw TAG_RETURN at return in
toplevel rescue/ensure to adjust VM stack properly.... -
- rebase to trunk
-
- Applied in changeset trunk|r59181.
----------
vm_insnhelper.c: break in once
* vm_insnhelper.c (vm_throw_start): si... - 03:45 AM Revision c95cbf6a (git): * 2017-06-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59182 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_insnhelper.c (vm_throw_start): size of catch table has been
included in iseq_catch_table struct, which could b...
06/26/2017
-
- Attached script dumps core.
-
10:37 AM Revision 978967b2 (git): webrick is _unmaintained_
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59180 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (call_bin_op_gen): adjust line number to the receiver,
instead of the rhs.
git-svn-id: svn+ssh://ci.ruby... -
- * parse.y (parser_yyerror): mark the whole last token which caused
the error, not only the end.
before:
```
if... -
- * vm_core.h (rb_thread_t): move several fields which are copied at cont.c
to rb_execution_context_t.
git-svn-id: ... -
- * cont.c (cont_restore_thread): on Fiber we only need to copy ec struct.
git-svn-id: svn+ssh://ci.ruby-lang.org/rub... -
- This has actually been implemented by Feature #10085, so it can be closed.
-
- * cont.c (enum fiber_status): add "FIBER_" prefix for all names.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@... -
- * cont.c (cont_restore_thread): On Fiber switching, thread status shold be
THREAD_RUNNABLE so that we don't need to... -
04:54 AM Feature #13665: String#delete_suffix
- I've sent a PR https://github.com/ruby/ruby/pull/1661.
I will merge if I get agreement at a ruby developer's meeting. -
- jphelps (Jeremy Phelps) wrote:
> I've got a patch ready for this, but I have no idea how to submit it. There are ser... -
02:51 AM Feature #10771: An easy way to get the source location of a constant
- [email protected] wrote:
> Ok, then here's my patch. I called the method
> "const_source_location" inste... -
01:34 AM Feature #10771: An easy way to get the source location of a constant
- Ok, then here's my patch. I called the method "const_source_location" instead of "constant_source_location", because ...
-
- [email protected] wrote:
> normalperson (Eric Wong) wrote:
> > Did you try the nakayoshi_fork gem as ko1 sugges... -
12:55 AM Bug #11101: Forking is killing my memory when running GC
- normalperson (Eric Wong) wrote:
> Did you try the nakayoshi_fork gem as ko1 suggested?
Sorry for replying so lat... - 12:59 AM Revision d39dd5ed (git): * 2017-06-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_compile_each0): debugs/ruby_debug_printf do not
support PRIsVALUE.
git-svn-id: svn+ssh://ci.ruby...
06/25/2017
-
- [email protected] wrote:
> I've got a patch ready for this, but I have no idea how to
> submit it. There... -
- I've got a patch ready for this, but I have no idea how to submit it. There are serious contradictions in this page:
... -
- * compile.c (fix_sp_depth): separate fix-up of sp depth from code
generation.
git-svn-id: svn+ssh://ci.ruby-lang.o... -
- Applied in changeset trunk|r59169.
----------
compile.c: toplevel return in argument
* compile.c (iseq_compile_each... - 05:10 AM Revision 21637abf (git): * 2017-06-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59170 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_compile_each0): adjust the stack before return
in an evstr/argument (reported by Balazs <balazs@k... -
- ```
/opt/local/ruby-2.3.4/bin/ruby(sigsegv+0x3e) [0x55bda632f12e] signal.c:890
/lib/x86_64-linux-gnu/libpthread.so....
06/24/2017
-
07:02 PM Bug #13679 (Third Party's Issue): ruby crash
- ```
[-] [framework/parts/audit#audit_page:90] [operation_timedout] Timeout was reached
/opt/arachnidev/arachni/lib... -
- In general I agree that error messages should be as useful as possible.
(By the way, I think if you indent ruby co... -
- Attached script causes [BUG] Stack consistency error (sp: 7, bp: 6)
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59168 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r59167.
----------
Delegate to `eql?` [Fix GH-1564]
* lib/delegate.rb (eql?): Delegate t... -
- * lib/delegate.rb (eql?): Delegate to `eql?` of the inner object.
based on the patch by giginet <giginet.net@gmail.... -
- * spec/mspec/lib/mspec/commands/mspec.rb (MSpecMain#run): do not
close jobserver FDs for mspec-run.
git-svn-id: sv...
06/23/2017
-
09:28 PM Bug #11033: OpenSSL related threading issues in Ruby 2.1 and 2.2
- Thank you @rhenium - I had not realized that openssl is packaged differently for Ruby 2.4
I have a pull request op... -
08:59 PM
Misc #13673 (Closed): minor correction to Queue docs
- Applied in changeset trunk|r59165.
----------
thread_sync.c: fix documentation for Queue#close
When Queue#closed? i... -
09:59 AM Misc #13673 (Closed): minor correction to Queue docs
- When Queue#closed? is true, using push/enq/<< will raise an exception. Not return nil.
- 08:59 PM Revision b11350d6 (git): thread_sync.c: fix documentation for Queue#close
- When Queue#closed? is true, using push/enq/<< will raise an
exception, and not return nil.
* thread_sync.c: fix docu... -
04:51 PM Feature #13677 (Feedback): Add more details to error "Name or service not known (SocketError)"
- ruby version: `ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux]`
ruby script:
~~~ ruby
require 'socket'... -
- I like symmetry. :)
-
- IO#ungetc accepts nil and just does nothing:
p File.new(__FILE__).ungetc(nil)
But on a GzipReader it fails:... -
- I have no pro or con opinion. I did however had want to compare Set to Array and the two behave differently.
```ru... -
01:57 PM Feature #13676: to_s method is not overriden for Set
- > What do you want to do?
> If you want a list of the elements, use to_a.
> If you want to see what elements it has... -
01:47 PM Feature #13676: to_s method is not overriden for Set
- nobu (Nobuyoshi Nakada) wrote:
> What do you want to do?
> If you want a list of the elements, use `to_a`.
> If yo... -
- What do you want to do?
If you want a list of the elements, use `to_a`.
If you want to see what elements it has, us... -
- When I call
~~~ ruby
s1 = Set.new
s1<<'tic'<<'tac'
s1.to_s
~~~
I'd expect ['tic', 'tac'] values being print... - 03:08 PM Revision 88c3bc2c (git): * 2017-06-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59164 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/shell/test_command_processor.rb (test_option_type): Windows
needs a suffix to execute.
git-svn-id: svn+ssh:... -
- BigDecimal("-0.2E5556") > -Float::INFINITY
returns wrong results in MRI 2.2.x and 2.3.x:
for ruby in 2.... -
- * parse.y (void_expr_gen): should warn operator expression style
calls only, but not method style calls. [Fix GH-1... -
- I'm not asking for consistency between `String#succ` and `String#<=>` (although that would be desirable). I do unders...
-
- Applied in changeset trunk|r59161.
----------
parse.y: check multibyte char
* parse.y (parser_precise_mbclen): chec... -
- Passing the attached file makes hang.
```
ruby hang.rb
``` -
- * parse.y (parser_precise_mbclen): check invalid multibyte char at
skipping strings following `?x` literal string, ... -
- * vm_core.h (rb_vm_tag): move jmpbuf which should be stored at the
last in TH_PUSH_TAG, between tag and state so en... -
- * vm_core.h (rb_thread_t::tag_state): move to "rb_vm_tag::state".
Lifetime of "state" should be same as current tag... -
08:49 AM Bug #13671: Regexp with lookbehind and case-insensitivity raises RegexpError only on strings with certain characters
- did some checks on my windows system to check how deep the problem is.
i used "ä" as variable.
the same problem h... -
- * vm_core.h (rb_thread_t): rename rb_thread_t::state to tag_state
to make it clear.
git-svn-id: svn+ssh://ci.ruby... -
- This was triggered again during automatic rebuild of Fedora's Pry package
https://apps.fedoraproject.org/koschei/b... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59157 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * thread.c (exec_recursive): rb_catch_protect() uses `int*` as
well as rb_protect.
git-svn-id: svn+ssh://ci.ruby-l... -
- Return value of EXEC_TAG() is saved by "int state".
Instead of "int", use "enum ruby_tag_type". First EXEC_TAG()
valu... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59154 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59152 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59151 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It was thoughtless. Let me revert it.
-
-
-
- This reverts r59142.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_insnhelper.c (vm_stack_consistency_error): extracted from
insns.def for further info in the future.
git-svn-i... - 12:29 AM Revision 83d1fdee (git): * 2017-06-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59148 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * doc/syntax/refinements.rdocrefinements.rdoc: grammatical
correction and code highlighting improved
* doc/syntax/...
06/22/2017
-
11:28 PM Bug #13671 (Assigned): Regexp with lookbehind and case-insensitivity raises RegexpError only on strings with certain characters
- Here is a test program:
~~~ ruby
def test(description)
begin
yield
puts "#{description} is OK"
re... -
06:02 PM Bug #13670 (Closed): [BUG] Bus Error at 0xefce7b (armv7l) (ruby 2.3.4p301)
- On using the library bootsnap the error occurred (see attachment). The developer of the library suggested to report t...
-
- * test/objspace/test_objspace.rb (test_count_symbols): exclude a
dynamic symbol which has been turned into immortal... -
- * lib/shell/system-command.rb (SystemCommand#initialize):
`def_e2message` wraps error message, but does not define ... -
- * common.mk: use --dump=--dump=parsetree_with_comment,insns
instead of tool/parse.rb. maybe nobody use this option ... -
- 匿名ユーザー wrote:
> Applied in changeset trunk|r59142.
>
> ----------
> Allow IO#reopen to take a block
>
> * io.... -
06:50 AM
Feature #2631 (Closed): Allow IO#reopen to take a block
- Applied in changeset trunk|r59142.
----------
Allow IO#reopen to take a block
* io.c (rb_io_reopen): take a block a... -
- * test/objspace/test_objspace.rb (test_count_symbols): make more complex dynamic
symbols to avoid conflict with oth... -
- [email protected] wrote:
> Issue #9145 has been updated by Glass_saga (Masaki Matsushita).
>
> Status changed... -
- Currently, Queue#pop takes non_block flag.
-
- trunkでは既にrb_memsearch()を利用するようになっているため、このチケットは閉じます。
-
- * io.c (rb_io_reopen): take a block and ensure the IO closed
[Feature #2631]
* test/ruby/test_io.rb: add a test
*... - 06:42 AM Revision 2a46ba94 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * gc.c (heap_allocatable_pages_set): added. This function set
heap_allocatable_pages and sorted_list atomically.
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59139 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * gc.c (GC_ASSERT()): added. GC_ASSERT() is similar to VM_ASSERT in
vm_core.h but turn on by RGENGC_CHECK_MODE.
g... -
01:18 AM Feature #12733: Bundle bundler to ruby core
- > the test suite also needs connection to internet to succeed
The Bundler test suite no longer requires an interne... -
- Applied in changeset trunk|r59136.
----------
gc.c: expand sorted pages
* gc.c (heap_page_allocate): expand sorted ... - 12:59 AM Revision d0b8fa73 (git): * 2017-06-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59137 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * gc.c (heap_page_allocate): expand sorted pages before inserting
allocated new page. [Bug #12670]
git-svn-id: sv...
Also available in: Atom