Activity
From 02/14/2018 to 02/20/2018
02/20/2018
-
08:11 PM Bug #14425: rb_funcall too strict on extra args
- ruby_2_5 r62501 merged revision(s) 62116,62151.
-
- ruby.h: relax rb_funcall check on extra args for clang
clang 5.+ (tested clang 7.0.0) seems to be attempting... -
07:08 PM Feature #14392: Pipe operator
- Hanmac (Hans Mackowiak) wrote:
> Symbol#pri and others will never work because you failed to understand how Object w... -
03:59 PM Bug #14499 (Third Party's Issue): [win32-service] "ruby.exe" crashes har
- Hello can someone help me? I have a problem with the Ruby-Gem "win32-service".
Here the "ruby.exe" crashes hard.
... -
03:24 PM Feature #14498: Class#to_proc
- Hanmac (Hans Mackowiak) wrote:
> Duplicate of #4910
>
> PS: might be a bit more complicated in C,
> but i would ... -
03:13 PM Feature #14498: Class#to_proc
Duplicate of #4910
PS: might be a bit more complicated in C,
but i would like this:
~~~ruby
proc { |*args,...-
- Hello!
I was creating a list of class instances via `some_list.map { |e| SomeClass.new(e) }` and wondered if there... -
03:13 PM Feature #12967: Add a default for RUBY_GC_HEAP_GROWTH_MAX_SLOTS out-of-the-box
- IMHO this should be reconsidered, as it provides a huge memory saving for a typical Rails app and it's so easy and un...
-
02:13 PM Bug #14400: IO#ungetc and IO#ungetbyte documentation is inconsistent with the behavior
- Could the buffer grow automatically to allow pushing multiple bytes/characters back?
That's the current implementati... -
01:03 PM Bug #14400: IO#ungetc and IO#ungetbyte documentation is inconsistent with the behavior
- Even worse, I found an example which ungetc can not push back
a character which just returned by getc.
```
% ./r... -
- Basically, ungetbyte/ungetc works if there is enough space in the IO buffer.
Since the IO buffer is not dynamicall... -
06:25 AM Bug #14400 (Assigned): IO#ungetc and IO#ungetbyte documentation is inconsistent with the behavior
-
10:49 AM Feature #8158: lightweight structure for loaded features index
- normalperson (Eric Wong) wrote:
> > https://bugs.ruby-lang.org/issues/8158
>
> I am curious, what is the sign... -
- @matz , yes I will.
Excuse me for the delay. I'll try to proceed with steps from CommitterHowto this week.
With r... -
06:34 AM Feature #8158: lightweight structure for loaded features index
- @funny_falcon? Will you be a committer?
Matz.
-
10:08 AM Revision 55515ef4 (git): error.c: bypass Exception.new
- * error.c (rb_exc_new, rb_exc_new_str): instantiate exception
object directly without Exception.new method call.
R... -
09:45 AM Feature #14491: MJIT needs internal debugging methods
- > My #1 motivation is that I am trying to figure out why --jit is making discourse bench slower even after everything...
-
09:20 AM Feature #14491: MJIT needs internal debugging methods
- My #1 motivation is that I am trying to figure out why --jit is making discourse bench slower even after everything i...
-
- > I would say the most critical piece though is MJIT.pause cause I need to properly measure additional overhead that ...
-
- Yes I ran with it during my testing and confirm jit-verbose helps somewhat. But compared to GC type instrumentation t...
-
- > Measure how long it takes to JIT all methods (avg, median, max, total)
> Measure how many methods got JITted
> Me... -
- > Measure impact of --jit when all jitting is disabled
This can be achieved by not passing --jit, can't it?
> D... -
- * mjit.c (convert_unit_to_func): separate a function call from a
macro, which evaluates the argument multiple times... -
- * include/ruby/ruby.h (rb_int2inum, rb_uint2inum): adjust
declarations. [ruby-core:83424] [Bug #14036]
git-svn-id... -
09:30 AM Misc #14497 (Closed): [PATCH] thread*: all condvars are monotonic
- thread*: all condvars are monotonic
There's no reason to use CLOCK_REALTIME for any condvars in Ruby.
Indeed, we ... -
- Applied in changeset trunk|r62497.
----------
random.c: Random.bytes
* random.c (random_s_bytes): new method Random... -
- Accepted. Better later than never.
Matz.
-
- * random.c (random_s_bytes): new method Random.bytes, which is
equivalent to Random::DEFAULT.bytes. [Feature #4938... -
- * Makefile.in (mjit_config.h): expand for each words.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62496 b2dd03... -
- [email protected] wrote:
> May I add two new candidates (IoThread and Thread::Coop)?
Thanks for the ideas. I l... -
- May I add two new candidates (IoThread and Thread::Coop)?
Matz.
-
- We cannot change the behavior. The change would increase the memory consumption (and decrease the performance).
Ma... -
08:44 AM
Bug #14494 (Closed): [PATCH] tool/m4/ruby_replace_type.m4 use AC_CHECK_TYPES for HAVE_* macros
- Applied in changeset trunk|r62495.
----------
tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros
AC... -
- I have no particular opinion on it, probably it'd be convenient.
- 08:44 AM Revision e691d4d7 (git): tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros
- AC_CHECK_TYPE (no "S") does not define HAVE_* macros for types,
so use AC_CHECK_TYPES (with "S") instead. Without th... -
- We don't want to change the behavior of basic methods. That would break existing code.
FYI, the slice is `nil` when ... -
- At least some of your points are rational. Those behaviors are inherited from Perl.
I don't think we can change the ... -
- It warns as follows on -w option:
ruby: warning: -K is specified; it is for 1.8 compatibility and may cause odd beha... -
- Keep compatibility for a while.
-
-
- Warning for a backslash followed by spaces is:
Old:
```
$ ruby2.5 -e ' \ '
-e:1: syntax error, unexpected $un... -
-
- Today, everyone knows Ruby's Hash is a OrderedHash.
Matz.
-
- Applied in changeset trunk|r62494.
----------
Signature of rb_uint2big and rb_int2big
* include/ruby/ruby.h (rb_uin... -
- * include/ruby/ruby.h (rb_uint2big, rb_int2big): declare with
uintptr_t and intptr_t instead of VALUE and SIGNED_VA... -
- * mjit.c (check_tmpdir): W_OK and S_ISDIR may not defined on
Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- I am against making it a syntax error. Adding warnings is OK (but maybe we can rely on Rubocop etc. to detect them).
... -
- The original intention for `dig` is a short-hand traversal of array-hash trees. I don't think it's normal to use `pro...
-
- I agree with de-duping. I also want the reference document to be updated.
Matz.
-
- I agree with adding `+JIT`.
Matz.
-
- Applied in changeset trunk|r62492.
----------
mjit.c: prefer $TMPDIR and $TMP
* mjit.c (system_tmpdir): prefer `$TM... -
- * mjit.c (system_tmpdir): prefer `$TMPDIR` and `$TMP` over system
defulat temporary directory, if exists, writable,... -
- * mjit.c (CC_DLDFLAGS_ARGS): default libraries are necessary on
Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
- No problems, thank you Vladimir, let me know when you are ready for me to test again!
-
04:42 AM Feature #12589: VM performance improvement proposal
- On 02/19/2018 05:17 PM, [email protected] wrote:
> Issue #12589 has been updated by sam.saffron (Sam Saffron).
... -
- On 02/19/2018 07:40 PM, [email protected] wrote:
> Issue #12589 has been updated by k0kubun (Takashi Kokubun).
... -
- Great work on rtl_gen, Vladimir! Keeping both stack insns and RTL insns would be good for safe migration.
> There ... -
- * mjit.c (system_tmpdir): rb_w32_wstr_to_mbstr returns the pointer
to `malloc`ed region. allocate with `xmalloc` i... -
- * vm.c: include dummy dtrace probes header in jit header.
* vm_insnhelper.c: probes headers are included by vm.c.
g... -
- Btw, I commented:
> I've thought the default way of ISeq serialization costs and bootsnap improves the performance... -
- * Makefile.in, common.mk, win32/Makefile.sub: moved MJIT macros to
mjit_config.h from XCFLAGS.
git-svn-id: svn+ssh... - 01:23 AM Revision 2124cb65 (git): * 2018-02-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62487 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62486 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/19/2018
-
- I just measured your branch using Discourse bench at: https://github.com/discourse/discourse/blob/master/script/bench...
-
- Last 4 months I've been working on generation of RTL from stack
insns. The reason for this is that stack insns ar... -
- In general bootsnap has had significantly more dev time. The actual technique it uses does not require and c extensio...
-
12:07 PM Feature #14492: iseq loading + caching should be in core
- > So not such a big difference.
I also ran it just because I was curious.
> time ruby -e exit
real 0m0.109s
... -
- FWIW, here are number on a laptop from 2014 with a i7-4702HQ @ 2.20GHz:
$ ruby -v
ruby 2.5.0p0 (2017-12-2... -
- ```
... And not in a RubyGem like yomikomu(*)
RubyGems itself is responsible for over 100ms of startup time on my... -
- > By the way, one thing I want to share is that currently JIT-ed function is not reusable for another process. That's...
-
- By the way, one thing I want to share is that currently JIT-ed function is not reusable for another process. That's b...
-
- [email protected] wrote:
> sam.saffron (Sam Saffron) wrote:
> > It can use an ISEQ SHA1 hash as the ke... -
02:14 AM Feature #14489: MJIT needs a reusable cache
- sam.saffron (Sam Saffron) wrote:
> It can use an ISEQ SHA1 hash as the key to the cache.
If this feature is added... -
- Currently on Discourse boot I notice a few minutes of jitting every time you boot it:
This is a redacted output: h... -
- ### MJIT.pause use cases
1. Measure impact of --jit when all jitting is disabled
2. Disable MJIT in large appli... -
- > MJIT.enable, MJIT.disable, MJIT.pause, MJIT.trace
Could you describe some detailed use cases (some possible prob... -
- Not sure about the method-names above, but I agree with the reasoning;
we have methods on "GC." too so I think it wo... -
- ### Issue
Doing careful analysis of MJIT performance is very hard cause there is no way of instrumenting this in r... -
07:44 PM Misc #14493: begin-rescue-end and def-rescue-end stacktraces inconsistent
- Thank you. Sorry for the duplicate.
-
- It is fixed in 2.3.6.
-
- I have filed this as type Misc because I don't know whether the current behaviour is intended or a true bug. Please r...
-
- [email protected] wrote:
> Indeed, it was a mistake.
> Do you think `HAVE_` macros should be defined for all `RUB... -
- Indeed, it was a mistake.
Do you think `HAVE_` macros should be defined for all `RUBY_REPLACE_TYPE`? -
- Eric Wong wrote:
> On a side note, I also realized we have no use for realtime
> condvars, only monotonic ones....... -
- [email protected] wrote:
> Without this, HAVE_CLOCKID_T goes undefined and I can't
> USE_MONOTONIC_COND in thr... -
- tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros
Without this, HAVE_CLOCKID_T goes undefined and... -
04:51 PM Bug #14496 (Closed): MJIT, Windows, MinGW and tmp dir
- For the time being, I've shut off testing MJIT on ruby-loco, as (at least when I did so) tests seemed to be timing ou...
-
01:01 PM Bug #14495: Enumerator::Lazy#uniq invalid state
- Solution https://github.com/ruby/ruby/pull/1820
-
Currently
~~~ ruby
2.5.0-preview1 :001 > arr = (0..100).lazy.uniq{|i| i % 10}
=> #<Enumerator::Lazy: #<Enumer...-
10:46 AM Bug #12548: Rounding modes inconsistency between round versus sprintf
- Hi again
After I raised this bug and saw the comment from matz I stopped watching assuming that sprintf would be "... -
10:02 AM Feature #14332 (Assigned): Module.used_refinements to list refinement modules
- Eregon (Benoit Daloze) wrote:
> Module.used_modules was added in #7418.
> But I think `Module.used_refinements` is ... -
09:52 AM Bug #14466: Errno::ECONNRESET or Errno::EPIPE raised instead of HTTPResponse returned when POSTing with large body
- I have just confirmed with wireshark that a 404 is returned before the connection aborts.
-
- I believe this should be backported to 2.4 and 2.5.
- 09:28 AM Revision 92dd6d84 (git): thread_pthread.c: spelling ("cancellation")
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62485 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:28 AM Revision 4651ef77 (git): thread_pthread.c: fix thread cache for non-monotonic clock
- I noticed this because of https://bugs.ruby-lang.org/issues/14494
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@... -
- ruby_2_5 r62483 merged revision(s) 62040.
-
- string.c: clear substring code range
* string.c (str_substr): substring of broken code range string may
... -
- ruby_2_5 r62482 merged revision(s) 61645.
-
- Added bundler for `test-bundled-gems` dependency.
rake, did_you_mean, test-unit depends on bundler.
git-s... -
- ruby_2_5 r62472 merged revision(s) 61591.
-
- compile.c (iseq_compile_each0): remove irrelevant tracecoverage
This change removes tracecoverage instructio... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62480 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:56 AM Bug #10864 (Assigned): REXML adds white space to text property when indent > -1
-
- > This was reported earlier but I would like to add some test methodology here: (tested using Discourse)
Ah, som... -
- Yes, I recognize this problem and will investigate the cause for sure. I don't know a clear cause for this yet.
> ... -
- This was reported earlier but I would like to add some test methodology here: (tested using Discourse)
### What I ... -
- Applied in changeset trunk|r62479.
----------
Escape MINIRUBY in --make-flags to extmk.rb
If MINIRUBY had arguments... -
- If MINIRUBY had arguments, which is the case of cross compiling
they wouldn't be parsed correctly and compiling would... - 12:30 AM Revision 3cadd10a (git): thread_pthread.c (native_thread_create): remove needless attrp
- Followup-to: r61719 (commit e8f40bd8f83e1b22ef9c22f0e5d7a1fc0b07f94c)
("thread_pthread: remove HAVE_PTHREAD_ATTR_IN... - 12:23 AM Revision cfeb344b (git): thread_pthread.c (rb_thread_create_mjit_thread): destroy attr
- This is required on some platforms to avoid leaks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62477 b2dd03c8-...
02/18/2018
- 11:58 PM Revision bff57efc (git): thread_pthread.c (thread cache): destroy cond after unlock
- No need to hold a lock while destroying a condition variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6247... - 11:58 PM Revision 7a8460ed (git): thread_pthread.c (rb_thread_create_mjit): set detach before create
- This should be slightly cheaper on NPTL as it does not rely on
atomics to set pd->joinid. We already use pthread_at... -
11:02 PM Bug #14488 (Closed): Unicode characters prevent [[:punct:]] character class from matching certain characters in subsequent matches
- In 2.3.5, `[[:punct:]]` doesn't match `+`. In 2.5.0, it does. In 2.4.3, it matches, but not after you match against a...
-
- simplify altstack and enable reuse with thread cache
Instead of allocating and registering the altstack in differe... - 09:03 PM Revision 1ad2db38 (git): * 2018-02-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62474 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:03 PM Revision eac50243 (git): thread.c: remove redundant USE_SIGALTSTACK #define
- thread.c already includes vm_core.h where USE_SIGALTSTACK is
defined, #include it explicitly (eval_intern.h already i... -
05:26 PM Bug #14486 (Closed): MINIRUBY not quoted in template/configure-ext.mk.tmpl
- MINIRUBY is not quoted in template/configure-ext.mk.tmpl, which made cross compiling, when MINIRUBY is something like...
-
05:25 PM Bug #14485 (Closed): For File#path.tainted? and File#to_path.tainted? should match original.tainted?
- Problem: if you create a File object using an untainted path, File#path and File#to_path return identical strings exc...
-
- iseq.c (rb_iseq_new_with_opt): handle the case where node is imemo_func
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- reverted ruby_2_5 r62426. it caused test failure
- 11:53 AM Revision f9ead597 (git): * 2018-02-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62471 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- it cause test failure
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62470 b2dd03c8-39d4-4d8f-98ff-8... -
- * mjit.c (compile_c_to_so): pass pch file only when using
"-include-pch" option.
git-svn-id: svn+ssh://ci.ruby-lan... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62468 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:11 AM Revision 189b4a4e (git): README.ja.md: Mac OS X -> macOS [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62467 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:54 AM Revision 4a57b88b (git): thread_pthread.c: shorten and fix thread cache implementation
- Update to use ccan/list for constant-time delete on expiry and
avoid malloc. We must also initialize th->thread_id u... -
- * mjit.c (compile_c_to_so): place DLDFLAGS at last, as compilers
other than cl.exee don't care the order of flag ar... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62464 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * mjit.c (form_args): do not use va_copy, which cannot detect
appropriate way to simulate when cross compiling.
gi... -
- I agree with Martin. Perhaps alternatives such as `all_same?` or
even better, `all_equal?` could be explored/used.
N... - 03:00 AM Revision ecd2c08a (git): thread.c (thread_join_m): handle negative timeouts correctly
- Users may subtract and round into negative values when using
Thread#join, so clamp the timeout to zero to avoid infin... - 03:00 AM Revision fbad2c55 (git): thread.c (double2timespec): adjust to use NULL for infinity
- Using:
strace ruby -e 'Thread.new { sleep }.join(Float::INFINITY)'
Will show a difference in futex() syscall args ... - 02:51 AM Revision cd0673e6 (git): Fixed the order of arguments for cl.exe
- * mjit.c (compile_c_to_so): `CC_DLDFLAGS_ARGS` must be after `-link` for cl.exe.
git-svn-id: svn+ssh://ci.ruby-lang... - 02:12 AM Revision 8f47542d (git): thread_pthread.c (native_cond_timeout): simplify
- Rely on getclockofday for CLOCK_MONOTONIC, avoid needless
variables, and rely on overflow protection from timespec_ad... - 02:12 AM Revision f65ee1e8 (git): thread.c: stop updating timespec when timeout is unspecified
- No need to waste cycles updating timespecs if there's no expiry.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6... - 02:12 AM Revision e6bf0128 (git): thread.c (update_timespec): use timespec_update_expire
- Rename "end" as a appropriate for readability.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62457 b2dd03c8-39d4... - 12:38 AM Revision 014e9a4a (git): thread.c: introduce timespec_cmp for timespec comparisons
- This hopefully improves readability when comparing timespecs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6245... - 12:38 AM Revision b160a113 (git): thread.c (timespec_update_expire): improve naming
- Naming the constant timespec as "end" should make it more
apparent is is an absolute time. Update callers, too.
git... - 12:38 AM Revision 63d19f6b (git): * 2018-02-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62454 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:38 AM Revision 604a96d9 (git): ext/fiddle/lib/fiddle/pack.rb: pack "void *" properly on 32-bit
- Fixes: r62450 (commit 1aaeeb326e754c5c5db83fbf35f780f729a9dfed)
("long long is a C99ism")
git-svn-id: svn+ssh...
02/17/2018
-
10:11 PM Bug #14484: Error - using - ruby 2.2.1
- Thank you. I need to run app on 2.2.1. Will check this extensions libraries.
-
- 2.2.1 is outdated.
```
-- C level backtrace information -------------------------------------------
0 libruby.... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62452 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:04 AM Revision a5c76f8c (git): a C source code must end with EOL
- cf: ISO 9899 section 5.1.1.2
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62451 b2dd03c8-39d4-4d8f-98ff-823fe6... -
- so SIZEOF_LONG_LONG is not always available.
We have to check its defined?-ness before using.
git-svn-id: svn+ssh:/... -
- * ext/socket/lib/socket.rb (Addrinfo#connect_internal): make
protected for Addrinfo#connect_to, instead of private ... -
- * Makefile.in, win32/Makefile.sub (LIBRUBY_A): link with extension
libraries if EXTSTATIC is set, so that static-ru... -
- * Makefile.in, win32/Makefile.sub (PRE_LIBRUBY_UPDATE): separate
definitions without miniruby.
git-svn-id: svn+ssh... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62446 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62445 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/16/2018
-
- Try to run some rails server / console command. It's my first when I do sth with ruby (need to changes some front-end...
-
04:41 PM Bug #13782: Backport r57733: kwrest arg name in --dump=parsetree
- ruby_2_4 r62444 merged revision(s) 57733,57734.
-
- kwrest arg name
* compile.c (iseq_set_arguments_keywords): make keyword rest
argument name nd_vid ... - 04:35 PM Revision 20ad678d (git): merge revision(s) 62422,62436: [Backport #14481]
- Merge RubyGems 2.7.6 from upstream.
It fixed some security vulnerabilities.
http://blog.rubygems.or... - 04:34 PM Revision e4317b5e (git): merge revision(s) 62422,62436: [Backport #14481]
- Merge RubyGems 2.7.6 from upstream.
It fixed some security vulnerabilities.
http://blog.rubygems.or... - 04:27 PM Revision 664b94fd (git): merge revision(s) 58471,58493,62436: [Backport #13505]
- load.c: backtrace of circular require
* load.c (load_lock): print backtrace of circular require via
... -
- ruby_2_4 r62440 merged revision(s) 59983,59984.
-
- ruby_2_4 r62440 merged revision(s) 59983,59984.
-
- ruby_2_4 r62440 merged revision(s) 59983,59984.
-
- file.c: rb_check_realpath
* file.c (rb_check_realpath): returns real path which has no
symbolic li... - 04:21 PM Revision 08fb5c21 (git): merge revision(s) 58471,58493,62436: [Backport #13505]
- load.c: backtrace of circular require
* load.c (load_lock): print backtrace of circular require via
... -
- fix regexp literal warning.
test/rubygems/test_gem_server.rb: eliminate duplicated character class warning.
... - 04:04 PM Revision 21249d84 (git): * 2018-02-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62437 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- test/rubygems/test_gem_server.rb: eliminate duplicated character class warning.
[Bug #14481]
git-svn-id: svn+ssh://c... -
- I've found that ruby -wc test/rubygems/test_gem_server.rb report some warnings.
Due to this warnings, `TEST_RIPPER_R... -
- Applied in changeset ruby_2_4|r62434.
----------
merge revision(s) 62422: [Backport #14481]
Merge RubyGems 2.7.6 f... -
- >So, Ruby 2.2 contained RubyGems 2.4. It's affected by its vulnerability.
oops, "It's NOT affected" is correct st... -
- RubyGems 2.7.6 has been released. It contained the several vulnerability fixes.
http://blog.rubygems.org/2018/02/1... -
- ruby_2_4 r62435 merged revision(s) 58471,58493.
-
- I believe this is a bug of Warning.warn feature in 2.4.
I will move this ticket to Bug to backport the changesets. -
- load.c: backtrace of circular require
* load.c (load_lock): print backtrace of circular require via
... -
- Merge RubyGems 2.7.6 from upstream.
It fixed some security vulnerabilities.
http://blog.rubygem... -
- This is reported by @hasimo. Fixing a case like this:
#0 __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/l... -
- * tool/m4/ruby_check_va_copy.m4 (RUBY_CHECK_VA_COPY): use
AC_TRY_LINK instead of AC_TRY_RUN for cross compiling.
g... -
- sk (SK Liew) wrote:
> Expected: HTTPResponse with status code of 404.
> Observed: Errno::ECONNRESET or Errno::EPIPE... -
- \o/
-
11:55 AM Bug #14483 (Closed): Enchance Method docs
- Main changes:
* fix conflict with `Proc` methods documentation (currently [one can see](http://ruby-doc.org/core-2... -
11:50 AM Bug #14482 (Closed): headerが重複したCSVをheaders:trueでparseした場合、row.to_h[key] と row[key] の結果が一致しない
- 1行目に重複したkeyがあるcsvファイルをheaders: trueでparseした場合、
row[key]とrow.to_h[key]が異なる値を返します。
~~~ruby
require 'csv'
invalid_... -
08:54 AM Bug #14480 (Closed): miniruby crashing when compiled with -O2 or -O1 on aarch64
- Recently, it is not possible to build Ruby 2.5.0 on aarch64 on Fedora Rawhide, because miniruby fails during build:
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62431 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62430 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Init functions are called only once, cache is useless.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62429 b2dd0... -
- ruby_2_5 r62428 merged revision(s) 61616.
-
- marshal.c: allow marshalling keyword_init struct
struct.c: define rb_struct_s_keyword_init to shared with ma... -
- ruby_2_5 r62427 merged revision(s) 61754.
-
- dir.c: pass flags to openat(2) correctly
Flags are 3rd argument of openat(2) while the 4th argument
... -
- ruby_2_5 r62426 merged revision(s) 61617,61618.
-
- compile.c: remove more unreachable chunk
* compile.c (remove_unreachable_chunk): remove beyond labels to be
... -
- ruby_2_5 r62425 merged revision(s) 61639.
-
- net/ftp: fix FrozenError in BufferedSocket
I noticed this bug while working on something else with
R... -
- From: SHIBATA Hiroshi <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62424 b2dd03c8-39d4-4d8... - 08:08 AM Revision 3a4de69e (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62423 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It fixed some security vulnerabilities.
http://blog.rubygems.org/2018/02/15/2.7.6-released.html
git-svn-id: svn+s... -
- ruby_2_5 r62421 merged revision(s) 61636.
-
- string.c: out-of-bounds access
* string.c (rb_str_enumerate_lines): fix out-of-bounds access when
... -
- ruby_2_5 r62420 merged revision(s) 61603.
-
- check array for zsuper. [Bug #14279]
* compile.c (iseq_compile_each0): for zsuper (NODE_ZSUPER), we need to ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62419 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Just a note: this is caused by a tzdata bugfix reported at <http://mm.icann.org/pipermail/tz/2018-January/025896.html>.
-
- So this is a test which checks if ruby can understand real-world timezone glitches. And the reality changed. I thin...
-
- * compile.c (iseq_peephole_optimize): keep freezestring insn
with debug info. [Bug #14475]
git-svn-id: svn+ssh://... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62417 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:49 AM Revision afc7be75 (git): * 2018-02-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62416 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62415 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/15/2018
-
- > https://bugs.ruby-lang.org/issues/8158
I am curious, what is the significance of the 0xfea7009e
initializer pa... -
- I don't have any pro or con opinion here but I wanted to comment on
one statement:
> maybe only another like 5 pe... -
- Since it's var = -str, it's very clear the return value should be used (and deduped) and we can't expect `str` to cha...
-
- > how about we do heap sharing
I am very against this, I just don't see the compatibility risk I think myself and... -
- To reduce compatibility risk, how about we do heap sharing with
fstring for already-frozen strings when calling umi... -
05:14 AM Feature #14478: String #uminus should de-dupe unconditionally
- Summary of this issue:
# Background
We changed to return dedup-ed string with `String-@`.
https://bugs.ruby-... -
- The contract says "possibly pre-existing copy of it." ... where possibly means "if the string is not frozen"
So t... -
02:13 AM Feature #14478: String #uminus should de-dupe unconditionally
- sam.saffron (Sam Saffron) wrote:
> > -@ should be one such exposure
>
> Oh this is already the case, see the sou... -
- > -@ should be one such exposure
Oh this is already the case, see the source:
```
/*
* call-seq:
* -str... -
- sam.saffron (Sam Saffron) wrote:
>
> ```
> puts x.object_id
> x.freeze
> puts x.object_id # must not change
> ... -
03:29 PM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- nobu (Nobuyoshi Nakada) wrote:
> `Array#uniq?` sounds like that all elements are unique, `ary.uniq.size == ary.size... -
- `Array#uniq?` sounds like that all elements are unique, `ary.uniq.size == ary.size`.
-
04:53 AM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- Four points.
First, re. uniq?:
mrkn (Kenta Murata) wrote:
> We don't have Array#uniq?.
> Do you suggest add... -
- mrkn (Kenta Murata) wrote:
> We don't have Array#uniq?.
> Do you suggest adding such a new method?
That is wh... -
12:38 AM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- > I suppose that Array#uniq? could work as Array#all? returning once false?
We don't have Array#uniq?.
Do you sug... -
01:13 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- The PG gem which uses libpq provides both synchronous and asynchronous APIs, and it is up to the client code to selec...
-
- [email protected] wrote:
> How does Process.wait behave in `Thread::Green`?
Process.wait* methods use rb_... -
- How does Process.wait behave in `Thread::Green`?
- 11:16 AM Revision d6db2d95 (git): Avoid using `@` in macro substitution that confuses FreeBSD make
- ```
making mjit_config.h
make: Unknown modifier ' '
make: Unclosed variable specification (expecting ')') for "Q" (va... -
- brianmario (Brian Lopez) wrote:
> fwiw GitHub's implementation of trailer parsing is based on the rules defined by g... -
- * array.c (rb_ary_values_at): optimization range argument case.
bulk concatenation than pushing for each element.
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62412 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Add a ad-hoc wait. Follows test_ioflush2.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62411 b2dd03c8-39d4-4d8... -
-
04:04 AM Feature #14362: use BigDecimal instead of Float by default
- yugui,
> Why do you think they are not familiar with floating-point values like IEEE754?
In my experience, most... -
03:09 AM Bug #14479 (Rejected): Exceptions raised from a :call tracepoint can sometimes be "rescued" inside the method
- This is a Ruby 2.5 regression.
If you raise an exception from a :call tracepoint, it can, in certain circumstances... -
- The configure script fails to guess the direction on emscripten.
Perhaps this is because of https://github.com/kripke... -
- This is also for emscripten.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62409 b2dd03c8-39d4-4d8f-98ff-823fe69... -
- Instead of `pthread_kill`. This is because emscripten supports
`pthread_create` but not `pthread_kill`.
git-svn-id:...
02/14/2018
-
- I created a new topic for this at: https://bugs.ruby-lang.org/issues/14478
> At this point, it may break existing... -
- [email protected] wrote:
> "If the string is frozen, then return the string itself."
>
> Yeah I do not agree... -
- Opened https://bugs.ruby-lang.org/issues/14478 to discuss change to uminus
-
10:35 PM
Bug #14475 (Closed): String de-duplication is broken in files with frozen_string_literal: true
- Applied in changeset trunk|r62407.
----------
compile.c: drop freezestring insn on String#-@
Followup to r62039 and... -
- "If the string is frozen, then return the string itself."
Yeah I do not agree with this documentation, I think it ... -
- [email protected] wrote:
> Workaround ... whenever de-duping strings always use `-+`
Yes, String#-@ document... -
- Workaround ... whenever de-duping strings always use `-+`
```
x = "#{1}".freeze
# this is always properly de-dup... -
- Simpler repro:
```
x = "#{1}".freeze
p x.object_id
x = -x
p x.object_id
x = "#{1}".freeze
p x.object_id
... -
- Create 2 files:
test.rb
```
$LOAD_PATH.unshift(File.dirname(__FILE__))
require 'frozen'
puts frozen.object... -
- > Why not make it impossible to create a frozen string that isn't deduped?
This can not be done without enormous b... -
- Why not make it impossible to create a frozen string that isn't deduped? That way the current `-x` works fine by def...
-
- continuing: https://bugs.ruby-lang.org/issues/14475
Current documentation for String uminus says: "If the string i... - 10:35 PM Revision 7606806c (git): compile.c: drop freezestring insn on String#-@
- Followup to r62039 and remove the redundant freezestring
insn which was preventing deduplication from String#-@
* co... - 10:35 PM Revision dc9ce328 (git): test/ruby/test_optimization.rb: fix compile kwarg
- Fixes: r62177 ("compile.c: fix string Range optimization with FSL")
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... -
- Upgraded tzdata to 2018c on both my Debian stretch (stable) and jessie
(oldstable) machines via "apt-get dist-upgrad... -
06:39 PM Feature #14460 (Closed): Speed up `require` and reduce memory usage
- Fixed in r62404. See Feature #8158
-
- Aaron, while I'm going to accept commit right, I'm asking you to apply my patch.
With regards,
Yura. -
- Committed in r62404. Thanks Yura!!
-
- Year after I think I am more stable person, so I'm going to accept commit rights with gratitude, honor and great resp...
- 06:38 PM Revision a08d41ea (git): * 2018-02-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62405 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Use integer hashsum instead of string as a key in loaded_features_index.
Do not use ruby strings for substring operat... -
- brianmario (Brian Lopez) wrote:
> > Better to make trailer interpretation tolerate empty lines;
> > as trailers are... -
05:43 PM Misc #14470: Use Commit together with co-authors Github feature in svn commits
- normalperson (Eric Wong) wrote:
> [email protected] wrote:
> > nobu (Nobuyoshi Nakada) wrote:
> > > The f... -
- normalperson (Eric Wong) wrote:
> [email protected] wrote:
> > nobu (Nobuyoshi Nakada) wrote:
> > > The f... -
- mrkn (Kenta Murata) wrote:
> uniq scans all elements, whereas all? and == don't.
> And uniq allocates a new array... -
- `uniq` scans all elements, whereas `all?` and `==` don't.
And `uniq` allocates a new array, so `uniq` is always slow... -
- I believe we could even do:
```ruby
ary.uniq?(&:foo)
``` -
- Why would it be more efficient in C?
A sufficiently smart JIT (or of course it can be done manually) could turn
... -
- Usually I use the following code to achieve the same purpose:
```ruby
ary.uniq.size < 2
```
I didn't test but... -
- In this issue, I propose to introduce `same_all?` instance method of `Array` class. This new method checks whether al...
-
- We have good feature to share common configuration between branches:
https://www.appveyor.com/docs/branches/#sharing-... -
- Using conditional build configuration.
https://www.appveyor.com/docs/branches/#conditional-build-configuration
This ... -
- There is extensive discussion on this at #7636. Please check.
-
- * mjit.c (mjit_get_iseq_func), mjit.h (mjit_exec): do not compare
a pointer as shorter type. by loosing the precis... -
-
- Applied in changeset trunk|r62400.
----------
skip "TestException#test_thread_signal_location" as a known bug [Bug #... -
- `TestException#test_thread_signal_location` fails randomly
https://gist.github.com/ko1/797b0f058f2d09ae57c9af1ee07... -
04:12 AM Bug #14472: `File::open` closes the file too early when used with callcc
- I used raw continuations for the simplicity of explanation but I found it was a bit confusing (and I was also confuse...
-
- > You can do it by `File.open` without a block.
I know that. Again, I'm not in trouble.
> `callcc` rollbacks en... -
- blackenedgold (Sunrin SHIMURA) wrote:
> This code throws an IOError, but expected to exit normally:
`callcc` roll... -
- Eric Wong wrote:
> [email protected] wrote:
> > issue" means, but I'm relatively certain that it's a bug in
> > R... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62400 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- As a maintainer of BigDecimal, I don't agree with you about BigDecimal is more developer friendly than Float.
And th... -
12:52 AM Feature #13581: Syntax sugar for method reference
- cben (Beni Cherniavsky-Paskin) wrote:
> A non-syntax idea: could `Math.method.sqrt` look significantly nicer than `M...
Also available in: Atom