Activity
From 07/26/2018 to 08/01/2018
08/01/2018
-
11:41 PM Feature #14473: Add Range#subrange?
- I agree that the max performance issue is likely to be a rare case; I am happy to leave it as-is.
Apologies on the second issue - I originally misunderstood "ignore" to mean "don't rescue".
I've attached another updated patch - it ... -
10:54 PM Bug #14716: SecureRandom throwing an error in Ruby 2.5.1
- We also got this error after upgrading to 2.5.1 (we had been on 2.4.2). We're also on a v3.13 kernel (3.13.0-24-generic). `cat /dev/urandom` produces output, and the errors are intermittent. Over the past day, `failed to get urandom` was...
-
08:55 PM Feature #14759: [PATCH] set M_ARENA_MAX for glibc malloc
- normalperson (Eric Wong) wrote:
> We will probably match arenas to Guild count dynamically;
> ...
Ah, great to know! I have no objection then.
> I don't know about ko1's timeline, but glibc releases every
> ...
It sounds like th... -
07:22 PM Feature #14759: [PATCH] set M_ARENA_MAX for glibc malloc
- [email protected] wrote:
> The question then becomes: What happens when Guilds land?
We will probably match arenas to Guild count dynamically;
depending on whether the program uses Guilds or not.
glibc checks arena_max whenever... -
- The question then becomes: What happens when Guilds land?
It will be a hard choice to have slow allocations when there are many guilds,
or remove this behavior and regress on existing programs not using guilds.
What does @ko1 think ... -
- > https://bugs.ruby-lang.org/issues/14759#change-73263
Btw, has anybody tested this patch with various allocators
to ensure it doesn't trigger a conflict (resulting in a
segfault) when using the other allocator via LD_PRELOAD?
jem... -
- > https://bugs.ruby-lang.org/issues/14759#change-73263
Another followup on this, current glibc 2.28 still creates
arenas without checking for contention, first. It can create
(nproc * 8) arenas on 64-bit and (nproc * 2) on 32-bit.... -
12:20 AM Feature #14759: [PATCH] set M_ARENA_MAX for glibc malloc
- Koichi / Nobu
Is there any chance we can merge this in and even backport to 2.4/2.5.
It is a very safe change for now and users can override the behavior if they need to using ENV (rare cases where you say host a ton of V8 runtim... -
03:21 PM Bug #14958 (Closed): rand(endless_range) raises TypeError (no implicit conversion of Range into Integer)
- I think TypeError message is a bit strange.
```console
$ ruby -v
ruby 2.6.0dev (2018-08-01 trunk 64154) [x86_64-linux]
$ ruby -e 'p rand(1..1)'
1
$ ruby -e 'rand(1..)'
Traceback (most recent call last):
1: from -e:1:in ... -
02:46 PM Bug #14957 (Closed): MinGW, gcc 8.2.0, bootstraptest test_thread.rb - failure ?
- Very recently MSYS/MinGW updated gcc from 7.3.0 to 8.2.0. For the most part, every test suite runs fine except the bootstraptest test, which has a single failure on Appveyor:
```
#1379 test_thread.rb:
Thread.new("foo", &Objec... -
- [email protected] wrote:
> As much as we like to think of jemalloc as a silver bullet of
> sorts... there are problems... In particular if you have THP
> enabled which most people do out of the box its behavior is
> not ideal de... -
03:41 AM Feature #14718: Use jemalloc by default?
- sam.saffron (Sam Saffron) wrote:
> After spending a bit too much time thinking about this, I would like to recommend **against** any jemalloc related changes and instead to double down on Eric's https://bugs.ruby-lang.org/issues/14759 f... -
- > Are you using LD_PRELOAD instead?
Yes that is how we deploy PRD we compile without jemalloc and then just ld preload various libs via environment depending on what we are testing.
btw... jemalloc with THP off is really good, its... -
- > Testing the following patch with
> "MALLOC_ARENA_MAX=1 MALLOC_ARENA_TEST=1 make gcbench-rdoc"
> seems show a small improvement in VmHWM across repeated
> runs, but the results aren't stable...
>
> https://80x24.org/spew/2... -
12:55 AM Feature #14718: Use jemalloc by default?
- Sam, I'm ok with your suggestion, any progress here is welcome. The main issue with tcmalloc is that Ruby doesn't support it out of the box with a `--with-tcmalloc` flag. Are you using LD_PRELOAD instead?
-
- After spending a bit too much time thinking about this, I would like to recommend **against** any jemalloc related changes and instead to double down on Eric's https://bugs.ruby-lang.org/issues/14759 for the next release of Ruby (which I...
-
09:58 AM Bug #7750 (Rejected): ＧＣ中にオブジェクトが割り当てられる
- 1.9.3 はすでにサポートを終了しているバージョン、かつ現在の安定バージョンの Ruby では GC の仕組みを大きく変わっているのでクローズします。
-
- 1.9.3 is already EOL status. If you have the same issue with the latest stable version of Ruby, Please report again.
Thanks. -
- [email protected] wrote:
> It causes system call and extra overhead so that I'm not sure
> it is acceptable.
> On previous proposal I could measure some performance down on
> fine-grain madvise.
OK. I am worried about that, too.
... -
06:53 AM Feature #14955: [PATCH] gc.c: use MADV_FREE to release most of the heap page body
- It causes system call and extra overhead so that I'm not sure it is acceptable.
On previous proposal I could measure some performance down on fine-grain madvise.
https://bugs.ruby-lang.org/issues/12236
I assume that we need to mak... -
- gc.c: use MADV_FREE to release most the heap page body
On x86 and x86-64 Linux and FreeBSD (at least), we can release
most of the heap page body (12k of nearly 16k). This is better
than causing malloc fragmentation with free(3) on ... -
06:20 AM Misc #14921: DevelopersMeeting20180809Japan
- sam.saffron (Sam Saffron) wrote:
> really hoping we can make a call on:
> ...
@sam.saffron: Please follow the format; not everybody can remember numbers. So this should be
* [Feature #14759] set M_ARENA_MAX for glibc malloc
> I... -
- really hoping we can make a call on:
https://bugs.ruby-lang.org/issues/14759
I would also very much like to see it backported 2.4 and 2.5. It is of enormous value to the ecosystem
-
12:27 AM Misc #14921: DevelopersMeeting20180809Japan
- * [Feature #14869] Proposal to add Hash#=== (nobu)
* [Feature #14916] Proposal to add Array#=== (aycabta)
* [Feature #14912] Introduce pattern matching syntax
I believe that these three items are related, and personally I could do a... -
03:54 AM Misc #14956: Remove staled branches in svn repository
- v1_* branches are just like ruby_2_* branches.
Please keep them. -
- the ruby svn repository has a lot of staled branches.
I will remove the following branches for migrating git.
```
half-baked-1.9
KEIJU
KOSAKO
matzruby
mvm
new_gc
rexml_adds_tests
ricsin
RUBY
ruby_m17n
SER
SHIGEO
SPCOLT... -
-
03:40 AM Revision e62214be (git): move atomic logic from mjit.c from ruby_atomic.h
- This macro shall be shared among other files, not just for mjit.c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64156 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64155 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- There was a previous discussion on this which had many good details and discussion:
https://bugs.ruby-lang.org/issues/14709
@zverok and I had done some work and writing on this which may yield some new ideas.
07/31/2018
-
10:53 PM Bug #14949: test_jit.rb test_unload_units fails on 32-bit
- Eric, thanks to the header information, I could fix at least the RubyCI's Debian 7.11 i686.
-
- Applied in changeset trunk|r64138.
----------
transform_mjit_header.rb: accept having attribute
between a type of return value and function identifier. Like:
```
rb_control_frame_t *
__attribute__ ((__fastcall__)) rb_vm_opt_struct_are... -
06:58 PM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
- jeremyevans0 (Jeremy Evans) wrote:
> sawa (Tsuyoshi Sawada) wrote:
> ...
I agree. Because of the existing mixed semantics, and predicates returning `Integer`s, I'm wary of using `^` as a general purpose logical operator. However, `!a ^... -
05:10 PM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
- danga (Dan Garubba) wrote:
> Sure. In my day job, I write testing code. So I've written an expression like:
> ...
The code and the explanation differ.
If the former is correct, the latter should be:
"raise an error unless the actio... -
02:45 PM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
- sawa (Tsuyoshi Sawada) wrote:
> I propose to extend the exclusive or operator `^` to be defined on `Object`. For `Integer`, the method would be overwritten by the current bitwise operator, and it would not benefit from the extension, bu... -
07:28 AM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
- I propose to extend the exclusive or operator `^` to be defined on `Object`. For `Integer`, the method would be overwritten by the current bitwise operator, and it would not benefit from the extension, but making it available for other c...
-
- Thanks. Essentially, this helper is a form of the boolean singleton normalization I apply at the application level.
I understand there should be a high threshold for introducing new operators into a language, so I wanted to see if an... -
01:26 AM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
- How about defining a helper function for your assertions?
```
def assert_same_as_boolean(x, y)
raise MyError unless !x == !y
end
assert_same_as_boolean(in_scenario_x?, actions_performed_for_scenario_x?)
```
It would be a g... -
- @k0kubun
I just built ruby 2.6.0dev (2018-08-01 trunk 64153) [x64-mingw32], and every JIT test is showing stderr as:
```
Failure in MJIT header file name initialization
```
The previous build was r64137. If you need an interm... -
- [Fix GH-1923]
From: Andrea Gómez <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64154 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64152 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:02 PM Revision e4aca224 (git): * 2018-08-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64151 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- If you want to suppress warnings, you can use `undef_method` instead of `remove_method` for the time being.
```ruby
module M
def foo; end
end
class C
include M
undef_method(:foo) if method_defined?(:foo)
define_method(:... - 02:21 PM Revision 8b310ae7 (git): merge revision(s) 60011:
- test_gc.rb: relax criterion
* test/ruby/test_gc.rb (TestGc#test_expand_heap): relax the
criterion and compare by epsilon.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@64149 b2dd03c8-39d4-4d8f-98ff-823... -
- ruby_2_4 r64148 merged revision(s) 63512,63514.
- 02:12 PM Revision 9f86a436 (git): merge revision(s) 63512,63514: [Backport #14790]
- time.rb: fix parsing time zone in iso8601
* lib/time.rb (Time.xmlschema): a colon in time zone designator
can be omitted. [ruby-core:87277] [Bug #14790]
time.rb: fix parsing time zone in iso8601
* li... -
- ruby_2_4 r64147 merged revision(s) 63417.
- 02:01 PM Revision 607d93b9 (git): merge revision(s) 63417: [Backport #14756]
- error.c: check redefined backtrace result
* error.c (rb_get_backtrace): check the result of `backtrace` even
if the method is redefined. [ruby-core:87013] [Bug #14756]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/bran... - 01:54 PM Revision 312de7a9 (git): backport openssl v2.0.8 [Backport #14754]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@64146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64145 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- to reduce "SKIPPED" logs on MJIT header build.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64144 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- when $MJIT_SEARCH_BUILD_DIR is set.
If prefix path is owned by root, `make install` needs to be run by root.
But in general we don't want to run `make test-all`, and also running
`make test-all` currently fails due to permission tests o... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64142 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64140 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64139 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- between a type of return value and function identifier. Like:
```
rb_control_frame_t *
__attribute__ ((__fastcall__)) rb_vm_opt_struct_aref(rb_execution_context_t *ec, rb_control_frame_t *reg_cfp)
{
...
}
```
[Bug #14949]
git-svn-... -
- * [Feature #14954] Add :wait option to RubyVM::MJIT.pause
* Since it's not released even in preview2 yet, is it okay to change the behavior?
* Is there any objection for having the option or the option name? -
- ## Problem
To measure an MJIT-generated code's performance, currently we need to do `sleep ...; RubyVM::MJIT.pause` and it's hard to decide an appropriate sleep seconds.
## Solution
Add an :wait option (default: true) and:
~~~ ru... -
- Wrongly created in ruby-dev... I'll re-create this on ruby-core.
-
- ## Problem
To measure an MJIT-generated code's performance, currently we need to do `sleep ...; RubyVM::MJIT.pause` and it's hard to decide an appropriate sleep seconds.
## Solution
Add an :wait option (default: true) and:
~~~ ru... -
- * test/ruby/test_thread_{cv,queue}.rb: Move under the test/ruby directory.
and rename TestThread* from Test*.
* test/test_sync.rb: Move toplevel of test diretory because sync is still
standard library.
git-svn-id: svn+ssh://ci... -
01:52 AM
Feature #14473: Add Range#subrange?
- Thank you for the new patch.
At the first issue, I understood max method has performance issue at that case.
But how often will we encounter it? I think it is a very rare case.
Or please show the application.
At the second issue... -
- Hi tarui, thank you for reviewing and your suggestion/question.
In fact, with my v4 patch in the case you describe there is a bug: `(1..3).cover?(1.0...4.0)` is `true` not `false`. This is prevented using `b >= (c...d).max` as you su... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64136 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:33 AM Revision 931cda4d (git): test/ruby/test_io.rb (test_race_gets_and_close): use SIGABRT on timeout
- I can't reproduce the test failure and I'm still not sure what's
wrong, but maybe we can get a core dump from P895:
http://ci.rvm.jp/results/trunk@P895/1174672
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64135 b2dd03c8-39d4-4d8f-9... -
- davidtgoldblatt (David Goldblatt) wrote:
> I don't think this benchmark is a useful way to compare performance between versions 3 and 5 of jemalloc. In between them was the advent of time-based purging, where the allocator waits for a w...
07/30/2018
-
- I'm investigating this. It looks like a symbol (of rb_mRubyVMFrozenCore) referred from /tmp/_ruby_mjit_pXXXuYYY.so is resolved to an address which is different from the address in ruby.exe. `rb_class_of((VALUE)rb_mRubyVMFrozenCore)` beco...
-
- > yet, sky3 had a failure at
> http://ci.rvm.jp/results/trunk-test@ruby-sky3/1173398 and it
> might be related. Investigating...
I thought r64133 fixed it, but I still saw this failure:
http://ci.rvm.jp/results/trunk@P895/11739... -
- [email protected] wrote:
> Congrats to achieve this. I think this should be a notable
> change written in NEWS :)
Thanks, I plan to :> I don't think we're out of the woods,
yet, sky3 had a failure at
http://ci.rvm.jp/result... -
- Congrats to achieve this. I think this should be a notable change written in NEWS :)
-
10:46 PM Feature #14718: Use jemalloc by default?
- davidtgoldblatt (David Goldblatt) wrote:
> I don't think this benchmark is a useful way to compare performance between versions 3 and 5 of jemalloc. In between them was the advent of time-based purging, where the allocator waits for a w... -
08:27 PM Feature #14718: Use jemalloc by default?
- I don't think this benchmark is a useful way to compare performance between versions 3 and 5 of jemalloc. In between them was the advent of time-based purging, where the allocator waits for a while (by default, around 10 seconds) before ...
-
- Got it, thanks @fweimer.
I did run a test with **jemalloc 5.1** and I've got the same results as you did.
```
Min. :242.9
1st Qu.:1593.5
Median :1737.7
Mean :1691.5
3rd Qu.:1860.0
Max. :2127.9
```
Remembering my pre... -
01:20 PM Feature #14718: Use jemalloc by default?
- andresakata (André Guimarães Sakata) wrote:
> Hello @fewimer, very interesting.
> ...
In the first test, yes, but I did not quote those numbers. The first quoted numbers are for untuned glibc 2.26.
-
- Hello @fewimer, very interesting.
Just to understand one thing, were you using MALLOC_ARENA_MAX=2 in your first test? -
- I can reproduce your MALLOC_ARENA_MAX=2 number.
But my untuned glibc 2.26 numbers are slightly worse (presumably due to the thread cache, which delays coalescing even further):
~~~
count 5000.000000
mean 2299.963311
std ... -
- [email protected] wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=14581
> The Ruby allocator calls posix_memalign (16384, 16344), and
> unfortunately, such allocations, when freed, can not always be
> reused for subseque... - 09:48 PM Revision 86d35a6b (git): thread_pthread.c (unregister_ubf_list): assert unblock.func is unset
- We must not allow reentry into ubf_list_head once we delete
ourselves, otherwise we could hang in there forever.
[ruby-core:88218] [Bug #14945]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64134 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > https://bugs.ruby-lang.org/issues/14945
Actually, r64083 may not be completely safe, either, as
the list_empty checks are dangerous, at least w/o GVL.
However, this order must be enforced:
unblock_function_clear
unregiste... -
09:16 PM Bug #14952 (Closed): [Docs] Backport r64057 to ruby 2.5
- Please backport r64057 (https://github.com/ruby/ruby/commit/ac1193d38f12e6ce5106f5413bcc57b6f585a2a1) since the bug also applies to ruby-2.5 documentation.
-
- I'm also seeing a lot of error text, 395 items in the errs array. Asserts pass up to the assert_equal at line 562. The matches on errs[10] & errs[11] exist, but they're at 201 & 202 respectively.
I've got `rb_mjit_min_header-2.6.0.h... -
- Header from native 32-bit machine (can't attach multiple files
w/o JS, it seems)
-
- Attached is rb_mjit_header.h from a 32-bit userspace on 64-bit kernel/HW
and mjit_header_i686_native.h from a 32-bit machine
-
- Eric, thanks to notify this. To fix it, I want to know the content of MJIT header files. I could see debian i686-linux on rubyci was failing in the same reason, but it looks a little hard to know the path of MJIT header from test_jit.rb ...
-
- Sure. In my day job, I write testing code. So I've written an expression like:
~~~ ruby
raise MyError unless in_scenario_x? == actions_performed_for_scenario_x?
~~~
To express: "raise an error unless the actions are performed for... -
02:31 PM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
- Can you show me examples of concrete usage of the proposed operator?
Your explanation is a bit vague.
Matz.
-
02:16 PM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
- I am not sure if the trade off of adding a new operator is worth it in
this case, even well aside from backwards compatibility here.
But that's just my personal opinion. -
- It conflicts with the existing syntax, `a=?b`.
-
- I propose adding a new operator for truthy/falsy equivalence, similar to what was proposed on https://bugs.ruby-lang.org/issues/13067, but with new syntax. The main purpose would be for writing expressions for logical equivalence (i.e., ...
- 06:53 PM Revision 508f0031 (git): thread_pthread.c (gvl_yield): do ubf wakeups when uncontended
- Not having contention for GVL could mean everybody else is stuck
in blocking region without GVL, so we kick the ubf list in that
case.
I expect this to fix test_thread_fd_close timeout:
http://ci.rvm.jp/results/trunk-test@ruby-sky3/1173... -
04:35 PM Bug #14009: macOS High Sierra and “fork” compatibility
- nagachika (Tomoyuki Chikanaga) wrote:
> ruby_2_4 r61358 merged revision(s) 60182.
With 2.4.4 (ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-darwin17]), I am still seeing
09:27:49 processor.1 | objc[44872]: +[__NSCFConstantS... -
- It is now registered for the next upcoming developer meeting at:
https://bugs.ruby-lang.org/issues/14921
(I think nobu added it to the developer meeting recently; it was most likely
forgotten for some time).
Hopefully future pa... -
- Sorry, it was my mistake.
-
- It still happens at `TestOpen3#test_pipeline_start`.
And it seems less frequently with -O0 than with -O3.
-
- normalperson (Eric Wong) wrote:
> I wrote:
> ...
It seems fixed, thanks.
> (Maybe reverting r64123 helps, too)
The crash had happened since r64110, I don't think it would help.
-
- I wrote:
> I wonder if condvars on OSX has a "memory" of which mutexes
> are associated with it. If so, that would be a problem with
> the rewritten GVL. So maybe a second condvar is necessary
> in native_thread_data.
Maybe usi... -
- [email protected] wrote:
> normalperson (Eric Wong) wrote:
> > [email protected] wrote:
> > > Since r64107, `make test-all` crashes by EINVAL at `pthread_cond_timedwait`.
> > > Attached logs at r64113.
> >
> > I think r6411... -
- normalperson (Eric Wong) wrote:
> [email protected] wrote:
> ...
It still happens at r64123.
> If not, we can try using:
> ...
It didn't help unfortunately.
Other than `[BUG]`, drb/ut_large.rb can hang forever. -
- [email protected] wrote:
> Since r64107, `make test-all` crashes by EINVAL at `pthread_cond_timedwait`.
> Attached logs at r64113.
I think r64117 will solve this (can't reproduce the problem, but
I understand it).
("process.c ... -
-
- Since r64107, `make test-all` crashes by EINVAL at `pthread_cond_timedwait`.
Attached logs at r64113. -
- @normalperson
Eric, r64111 passed Appveyor mswin & MingW (ruby-loco). Travis also.
Thanks, Greg -
- [email protected] wrote:
> 1) Failure:
> TestQueue#test_thr_kill [/home/travis/build/ruby/ruby/test/thread/test_queue.rb:153]:
> only 0/250 done in 60 seconds.
Yep r64109 wasn't sufficient; but I'm working on it. -
- @normalperson Eric,
Thanks. mswin passed, I haven't checked MinGW yet. Bad news is the Travis build had the following error in test-all:
```
1) Failure:
TestQueue#test_thr_kill [/home/travis/build/ruby/ruby/test/thread/test_q... -
- OK, r64110 should work. I mangled #ifdef nesting in r64109 :x
-
- Applied in changeset trunk|r64110.
----------
thread.c: move ppoll wrapper into thread_pthread.c
thread_pthread.c relies on ppoll for rb_sigwait_sleep, so ensure
the compatibility wrapper is available for it.
[Bug #14950]
Reported-by... -
- I got another error with macOS.
- 03:21 PM Revision 2a4e8c17 (git): * 2018-07-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64132 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * thread_pthread.c (USE_NATIVE_SLEEP_COND): revised wrongly removed
line with the ifndef guard.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64131 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r64130 merged revision(s) 63741.
- 02:15 PM Revision 8f2e9879 (git): merge revision(s) 63741: [Backport #14868]
- process.c (ruby_fork_ruby): fix race in signal handling
We must block signals before stopping timer-thread, otherwise
signal handing may be delayed until (and if) another signal
is received after timer-thread is ... -
- ruby_2_4 r64129 merged revision(s) 63727.
- 02:11 PM Revision cd5c3d12 (git): merge revision(s) 63727: [Backport #14865]
- vm.c: fix infinite loop
* vm.c: use EXEC_EVENT_HOOK_AND_POP_FRAME. While exception handling, if an exception
is raised in hooks, need to pop current frame and raise this raised exception by hook.
[ruby-dev:505... -
- ruby_2_4 r64128 merged revision(s) 63698.
- 02:06 PM Revision 5b5739df (git): merge revision(s) 63698: [Backport #14856]
- lib/drb/extservm.rb (service): do not return `false'
invoke_service_command may set entries in @servers to `false',
making it incompatible with the intended use of the
safe navigation operator.
This caus... -
- ruby_2_4 r64127 merged revision(s) 63112.
- 02:00 PM Revision 08c74b75 (git): merge revision(s) 63112: [Backport #14818]
- Remove outdated example from Numeric documentation
Since 2.5, Numeric instances can be cloned and duplicated.
[Fix GH-1850]
From: Miguel Landaeta <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- ruby_2_4 r64126 merged revision(s) 63571,63572.
- 01:57 PM Revision b6ab48d8 (git): merge revision(s) 63571,63572: [Backport #14816]
- `int isnan(double)` is a POSIXism
- `isnan` is something relatively new. We need to provide one for
those systems without it. However:
- X/Open defines `int isnan(double)`. Note the `int`.
- C99 defin... -
- ruby_2_4 r64125 merged revision(s) 63549,63551,63554.
- 01:54 PM Revision 7367d5db (git): merge revision(s) 63549,63551,63554: [Backport #14805]
- memo->u3.cnt is long not int [Bug #14805]
enum.c: mitigate overflows
* enum.c (enum_count): convert counters to Integer as unsigned
long, instead of long, to mitigate overflows.
[ruby-core:87348] [Bu... - 09:54 AM Revision a038bf23 (git): thread_pthread.h (native_thread_data): split condvars on some platforms
- Maybe some platforms have strange condition variable implementations
which have a "memory" of which mutexes they're associated with.
In any case, it makes documentation easier even on GNU/Linux and
FreeBSD.
git-svn-id: svn+ssh://ci.rub... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64123 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64122 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64121 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:13 AM Feature #6284: Add composition for procs
- matz (Yukihiro Matsumoto) wrote:
> Considering the combination of OOP and FP, it seems a good idea to adding both forward and reverse combination of procs. So we pick Groovy way (adding `<<` and `>>` methods to `Proc`).
What do you t... - 08:05 AM Revision ebfc4485 (git): bootstraptest/runner.rb: speed up assert_finish with IO.select (take #2)
- Resurrect r63754 in a 1.8-compatible way. While we're at it,
add a note to maintain 1.8 compatibility (cf. r63757).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64120 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18) reportedly fails to compile
cf: https://rubyci.org/logs/rubyci.s3.amazonaws.com/centos6/ruby-trunk/log/20180726T093003Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64119 b2... -
07:31 AM Feature #14473: Add Range#subrange?
Thank you for your patch owst.
I reviewed it and feel the behavior below is strange.
~~~
$ ruby -e 'p (1..3.1).cover?(1...3)'
true
$ ruby -e 'p (1..3.1).cover?(1...4)'
Traceback (most recent call last):
1: from -e:1:i...-
- We see several occurrence of "diagnostic push/pop" so why not
make them macros. Tested on GCC8 / Clang 6.
Note that ruby.h is intentionally left untouched because we don't
want to introduce new public macros.
git-svn-id: svn+ssh://ci... - 06:35 AM Revision 7018acc9 (git): process.c (waitpid_nogvl): prevent conflicting use of sleep_cond
- We reuse sleep_cond for waitpid notifications as well as GVL
waiting. So we must take care to not hold onto sleep_cond
when we try to reacquire GVL.
[ruby-core:88183]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64117 b2dd03c8-39... - 06:02 AM Revision 56491afc (git): thread_pthread.c (rb_sigwait_sleep): th may be 0 from MJIT
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64116 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:51 AM Revision ab47a57a (git): thread*.c: waiting on sigwait_fd performs periodic ubf wakeups
- We need to be able to perform periodic ubf_list wakeups when a
thread is sleeping and waiting on signals.
[ruby-core:88088] [Misc #14937] [Bug #5343]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64115 b2dd03c8-39d4-4d8f-98ff-823fe... - 05:51 AM Revision 95cae748 (git): thread_pthread.c (gvl_destroy): make no-op on GVL bits
- It's possible for another thread to take vm->gvl.lock
during gvl_release at the end of thread_start_func_2
during VM shutdown, at least.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64114 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:28 AM Revision 45143629 (git): thread_pthread.c (rb_sigwait_sleep): fix uninitialized poll set in UBF case
- [ruby-core:88088] [Misc #14937] [Bug #5343]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64113 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64112 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:28 AM Revision 26b8a70b (git): thread_pthread.c (rb_sigwait_sleep): re-fix [Bug #5343] harder
- We can't always designate a timer thread, so any sleepers must
also perform ubf wakeups. Note: a similar change needs to be
made for rb_thread_fd_select and rb_wait_for_single_fd.
[ruby-core:88088] [Misc #14937] [Bug #5343]
git-svn-id... -
- mtsmfm (Fumiaki Matsushima) wrote:
> ~~~ruby
> ...
This warning dispatches `on_arg_ambiguous` method.
> - How can I get the range of code instead of lineno and column only?
No way right now.
I think you can propose new methods f... - 12:31 AM Revision 3dc7727d (git): thread.c: move ppoll wrapper into thread_pthread.c
- thread_pthread.c relies on ppoll for rb_sigwait_sleep, so ensure
the compatibility wrapper is available for it.
[Bug #14950]
Reported-by: SHIBATA Hiroshi <[email protected]>
Reported-by: Greg L <[email protected]>
git-svn-id: svn+s...
07/29/2018
-
- @normalperson
Eric,
Both windows builds (mswin & mingw) failed compiling thread.c.
Attached logs of both.
Thanks, Greg -
- I get multiple definition warnings from this test. It only
happens on my 32-bit systems (both VM and real HW) on Debian 9.
Attached log was made with below patch:
```
--- a/test/ruby/test_jit.rb
+++ b/test/ruby/test_jit.rb
@@ -5... - 10:54 PM Revision 2fa1e2e3 (git): thread.c: move ppoll wrapper before thread_pthread.c
- thread_pthread.c relies on ppoll for rb_sigwait_sleep, so ensure
the compatibility wrapper is available for it.
Reported-by: SHIBATA Hiroshi <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64109 b2dd03c8-39d4-4d8... - 10:19 PM Revision 4c1ab82f (git): thread_pthread.c (ubf_select): refix [Bug #5343]
- We still need to to designate a timer thread after registering target
thread for the ubf list.
Oops :x
Note: I was never able to reproduce
test/thread/test_queue.rb::test_thr_kill failures on my on
Debian machines.
[ruby-core:88088] [... - 08:47 PM Revision 708bfd21 (git): thread_pthread: remove timer-thread by restructuring GVL
- To reduce resource use and reduce CI failure; remove
timer-thread. Single-threaded Ruby processes (including forked
children) will never see extra thread overhead. This prevents
glibc and jemalloc from going into multi-threaded mode an... - 08:28 PM Revision 822e54a5 (git): * 2018-07-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64106 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:28 PM Revision 5db03b7b (git): test/ruby/test_process.rb (test_wait_and_sigchld): improve reliability
- This should fix CI failure under MJIT, 100ms wait may not be
enough for signal handler to fire:
http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1169472
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64105 b2dd03c8-39d4-4d8f-98ff-8... -
- bluz71 (Dennis B) wrote:
> @andresakata,
> ...
I had forgotten to answer it. Yes, in that test I was using jemalloc 3.6.0. -
- I removed the NewRelic dependency and it's using the `get_process_mem` gem instead. It should work on different platforms as well.
Now there is a README file in the repository that may help you to reproduce the tests. Let me know you ... -
- fweimer (Florian Weimer) wrote:
> Thanks. Would it be possible to eliminate the dependency on `newrelic_rpm`, and possibly Rails as well? We don't have a commercial `newrelic_rpm` license, and we are not Ruby developers, so this is no... -
- andresakata (André Guimarães Sakata) wrote:
> Hi!
> ...
Thanks. Would it be possible to eliminate the dependency on `newrelic_rpm`, and possibly Rails as well? We don't have a commercial `newrelic_rpm` license, and we are not Ruby de... -
- I believe this has been reported multiple times against glibc, without ever mentioning Ruby. The most relevant upstream bug seems to be:
https://sourceware.org/bugzilla/show_bug.cgi?id=14581
The Ruby allocator calls posix_memalign... -
- [email protected] (Carlos O'Donell) wrote:
> I will try to keep the ruby community updated with regard to our analysis of fluentd and the ruby vm with glibc's malloc.
Please do keep us informed Carlos.
Thank you, I genuinely hop... -
- @andresakata,
Which version of jemalloc?
Ubuntu 16.04 provides jemalloc 3.6.0 in the repos, is that the version you are testing?
Simple testing some of us have done indicates that newer jemalloc versions will behave **very diff... -
- Hi!
I'm another Ruby user that used to have memory bloat problems and switched to `jemalloc` as well.
I just wrote a simple script (36 lines) that seems to reproduce the issue.
https://github.com/andresakata/ruby-memory-bloat
... -
04:37 PM Feature #14938: Provide API to get same result as ruby -wc
- Hmm, I tried `warn` but it doesn't work in some case:
~~~ruby
#!/usr/bin/ruby
require 'ripper'
require 'tempfile'
class Lint < Ripper
def warn(*s)
@results << [:warning, lineno, column, *s]
end
alias warning warn
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64104 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64103 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:15 AM Revision c95467e5 (git): thread_pthread.c: clear altstacks in thread cache at GVL destruction
- Otherwise, an altstack may live past ObjectSpace destruction
and xfree-ing the altstack will segfault.
[ruby-core:85621] [Feature #14487]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64102 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/openssl/extconf.rb: LibreSSL headers emit "overriding WinCrypt
defines" warnings if wincrypt.h has been included (except for
x509.h) on Windows. get rid of including the header by defining
NOCRYPT macro.
git-svn-id: svn+ssh... -
- to use compaction with --jit-save-temps.
Prior to this commit, JIT compaction didn't work with --jit-save-temps
but it wasn't intentional.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64100 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thanks again! I'll probably commit soon since this looks very
straightforward (it took a long time to get there, though;
probably the most challenging thing I've done for Ruby). -
- @normalperson
Eric,
Ran both patches on top of r64095, result was similar to above (passed as above).
Thanks, Greg -
- > > https://bugs.ruby-lang.org/issues/14937
>
> https://80x24.org/spew/[email protected]/raw
Hi Greg, thanks for testing. I'll let k0kubun deal with JIT
failures. For threading, I found more code to delete
(go... -
- for the ease of MSP-Greg's CI. I'll track this failure as Bug#14948 and
fix it later.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64099 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- @k0kubun
I apologize, I should have been clearer. ruby-loco is built three times a day. The list of builds is shown at https://ci.appveyor.com/project/MSP-Greg/ruby-loco/history or https://msp-greg.github.io/file.mingw_test-all.html... -
- > Starting with r64076, every subsequent build has failed
Does this mean, r64075 passes and r64076 fails? r64076 changes almost no behavior, so I feel it's very unlikely that r64076 is related to the failure.
2 points to notice:
... -
- for better C-level backtrace
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64098 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- When --jit-wait is specified, `unit_queue.length` is always 0 and it's
not a good metric.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64097 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Repack rb_thread_struct, rb_execution_context_struct, args_info and
iseq_compile_data to save 1 word per struct.
re_pattern_buffer remains unpacked due to the possible binary
compatibility.
[Fix GH-1907]
Based on the patch
From: Lour... -
- Applied in changeset trunk|r64095.
----------
mkexports.rb: flip-flop
* win32/mkexports.rb (Exports::Mswin#each_export): get rid of
flip-flop warning. [ruby-core:88147] [Bug #14946] -
- * win32/mkexports.rb (Exports::Mswin#each_export): get rid of
flip-flop warning. [ruby-core:88147] [Bug #14946]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64095 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/28/2018
-
- Starting with r64076, every subsequent build has failed, both in parallel & retry, on `TestJIT#test_unload_units`.
Finally ran it locally, below is the log of running the whole test file/suite.
Thanks again, Greg
```
1) Ski... -
- @normalperson
Eric,
Passed all tests using r64094. TestJIT#test_unload_units has been failing (both in parallel & retry) since it was added. Been meaning to post an issue/bug report about it...
Thanks, Greg
```
———————————... -
- > https://bugs.ruby-lang.org/issues/14937
OK, new patch to eliminate timer-thread completely. It seems to pass
repeated "make exam" and introduce no regressions. So far I have found
and fixed two bugs while working on this.
[B... -
- normalperson (Eric Wong) wrote:
> Giving control to other threads still happens with Thread.pass
> ...
At that point I wouldn't call them threads anymore,
I think threads usually imply preemption (not just on blocking actions but als... -
- [email protected] wrote:
> Is this the same as `Thread.new { Thread.handle_interrupt(Exception => :never) { ... } }`?
> What's the difference?
No, current thread switching does not use interrupts in the same
sense (no Exception o... -
04:23 PM Bug #14634: Queue#push seems to crash after fork
- Hi, we've also been running into this at work. Thanks for the fix and backport! We look forward to a 2.5.2 release.
-
- Applied in changeset trunk|r64094.
----------
mjit.c: introduce JIT compaction [experimental]
When all compilation finishes or the number of JIT-ed code reaches
--jit-max-cache, this compacts all generated code to a single .so file
and... -
- When all compilation finishes or the number of JIT-ed code reaches
--jit-max-cache, this compacts all generated code to a single .so file
and re-loads all methods from it.
In the future, it may trigger compaction more frequently and/or ... -
- Applied in changeset trunk|r64092.
----------
win32.c: limit write size on console
* win32/win32.c (constat_parse): split long buffer and limit write
size on a console, as well as rb_w32_write.
[ruby-dev:50597] [Bug #14942] - 03:29 PM Revision 2a9cae33 (git): * 2018-07-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64093 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * win32/win32.c (constat_parse): split long buffer and limit write
size on a console, as well as rb_w32_write.
[ruby-dev:50597] [Bug #14942]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64092 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/fiddle/test_function.rb (test_nogvl_poll): fix messages as
failed conditions, with errno description.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64091 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64090 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64089 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64088 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I get the warning in the subject. I think it's better to get rid of this
in our own build code. -
- Closed. Because there is no actual bug, there is no need to backport this.
-
- I committed the tests adapted from Python and the fix of the comparison operator, because it's technically correct and we never know when this would lead to an actual bug if something somewhere else in the code gets changed.
@MaLin, t... -
03:16 AM Bug #14934: Unicode: Hangul normalize bug
- Get it. :)
-
- * lib/unicode_normalize/normalize.rb: Fix the range check for trailing
Hangul jamo characters in Unicode normalization. Different from
leading or vowel jamos, where LBASE and VBASE are actual characters,
a value equal to TBASE expr... -
- * test/test_unicode_normalize.rb: extract tests that do not depend
on NormalizationTest.txt data file from conditionally constructed
part of TestUnicodeNormalize class, to always run them even if
the data file isn't found.
git-svn... -
- * test/test_unicode_normalize.rb: search ucd directory
first if it exists. This change follows r61415.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64085 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:34 AM Revision 3943dcd1 (git): use https:// instead of git:// when possible
- Avoid MitM when downloading from insecure networks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64084 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r64083.
----------
thread.c (blocking_region_end): clear ubf before unregister_ubf_list
If we keep ubf set after unregistering, there is a window for
other threads (including timer thread) to put this thread ... -
- thread.c (blocking_region_end): clear ubf before unregister_ubf_list
If we keep ubf set after unregistering, there is a window for
other threads (including timer thread) to put this thread back
on the ubf_list right away. Entering ... - 03:10 AM Revision 856bd77a (git): thread.c (blocking_region_end): clear ubf before unregister_ubf_list
- If we keep ubf set after unregistering, there is a window for
other threads (including timer thread) to put this thread back
on the ubf_list right away. Entering ubf_list unexpectedly
after GVL acquisition may cause spurious wakeup and ... -
01:14 AM Feature #14912: Introduce pattern matching syntax
- shyouhei-san:
I changed my mind. We should be able to avoid such "fragile" case.
Though duck typing is important, it should be designed by another approach.
akr-san:
> I think Ruby's pattern matching should support this style.
...
07/27/2018
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64082 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:28 PM Revision efee3033 (git): Include Hash#size in the examples
- Both methods Hash#length and Hash#size share the same source code in
Ruby, but they also share the same documentation. Now when you look at
the documentation of Hash#size you only see examples for Hash#length,
which is confusing. This co... - 05:19 PM Revision ecf4641b (git): * 2018-07-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64080 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Co-authored-by: Brad Landers <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64079 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Module has many introspection methods for methods and constants that
either return an array or return true or false for whether the method
or constant is defined. Most of these methods support an optional
argument that controls whethe... -
-
- Just refactoring. Despite its name, the function does NOT return a
boolean but raises an exception when the class given is frozen.
I don't think the new name "rb_class_modify_check" is the best, but
it follows the precedeint "rb_ary_mod... -
- Btw, I can probably improve on this by making GVL waiter perform
timeslice; so it would eliminate timer-thread completely. Will
work on it tomorrow (too tired, now) -
- [email protected] wrote:
> With jemalloc 5.1.0, ruby 2.4.4 failed to initalize timer thread and it causes broken runtime, e.g. signals are ignored.
> This problem has been reported in jemalloc issue. See
> https://github.com/jem... -
10:00 AM Bug #14943 (Closed): ruby 2.4 doesn't work with jemalloc 5.1.0 properly.
- With jemalloc 5.1.0, ruby 2.4.4 failed to initalize timer thread and it causes broken runtime, e.g. signals are ignored.
- ruby 2.4.4
~~~
$ LD_PRELOAD=~/jemalloc_lib/5.1.0/lib/libjemalloc.so.2 ruby print_version.rb
<main>: warni... -
- Is this the same as `Thread.new { Thread.handle_interrupt(Exception => :never) { ... } }`?
What's the difference?
Is preemption as in threads giving control (and the GIL) to another still possible with `Thread#preemptible = true` or ... -
- [email protected] wrote:
> `Thread.exclusive` ?
No, this is different from that old method because thread
switching still happens from blocking regions. -
- `Thread.exclusive` ?
-
- and lazily delete them on termination.
This will be needed to create a large so file later.
The large number of .o files will be probably compacted before the large so
file is created.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@... -
- units, renaming it from NOT_COMPILABLE_JIT_ISEQ_FUNC.
NOT_READY_JIT_ISEQ_FUNC is for ones being compiled, so
mjit_get_iseq_func treats it specially and it shouldn't be used for the
purpose.
I renamed it instead of adding a new one beca... -
08:26 AM Bug #14942 (Closed): Windows7でコンソールに長い文字列を出力できない
- WindowsのRubyは、WriteConsoleWでコンソールに文字を出力していますが、
Windows7では、WriteConsoleで書き出せるバッファのサイズは61KB程度が限界のようです。
(WriteConsoleWで"あ"が31366文字まで、WriteConsoleAで"a"が62733文字まででした。)
長い文字列を出力する時は、小分けにして書き出してくれるとありがたいです。
※ Windows10では問題ありません。 -
- `xfree(unit)` was missing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64075 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64074 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- which was originally NULL before r62221
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64073 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64072 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r64071.
----------
ruby.c: taint ARGV on Windows
* ruby.c (external_str_new_cstr): strings come from the external
should be tainted. [ruby-dev:50596] [Bug #14941] -
- WindowsのRuby2.2以降で、コマンドライン引数の文字列に汚染マークを付け忘れてます。
~~~
$ ruby -e "p ARGV[0].tainted?" arg
false
~~~ -
- * ruby.c (external_str_new_cstr): strings come from the external
should be tainted. [ruby-dev:50596] [Bug #14941]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64071 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I think I have figured things out:
The patch is technically correct. While LBASE and VBASE are the values of the first actual leading and vowel jamos, the value of TBASE is one smaller than the first actual trailing jamo at 0x11A8. Th... -
- [Feature #11076] Enumerable method count_by
As mentioned in the discussion, Nobu was kind enough to update this to work with current master for Ruby: https://github.com/ruby/ruby/compare/trunk...nobu:feature/11076-Enumerable%23count_b... -
- Why don't you use ripper?
```ruby
#!/usr/bin/ruby
require 'ripper'
class Lint < Ripper
def warn(*s)
@results << [:warning, lineno, column, *s]
end
alias warning warn
def results
unless defined?(@results) and...
07/26/2018
-
- nobu (Nobuyoshi Nakada) wrote:
> How about `Enumerable#just(num=1)` or `Enumerable#only(num=1)`?
Or maybe a slightly more verbose `Enumerable#first_and_only(num = 1)`? -
- I've released a string-crypt gem based on the previous patch: https://github.com/jeremyevans/ruby-string-crypt
The gem has some minor differences in `extconf.rb`, because it needs to avoid overlap with macros defined in `ruby/config.h... -
06:51 PM Feature #14718: Use jemalloc by default?
- > vo.x (Vit Ondruch) wrote:
> ...
I am a glibc developer, and project steward.
We have no plans to merge jemalloc.
We have plans to look into glibc's RSS usage under certain workloads including a ruby application which has issues ... - 06:46 PM Revision c0e478ed (git): * 2018-07-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64070 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:46 PM Revision 5219adf4 (git): lib/ostruct: Remove unnecessary `__send__`
- Patch by yuuji.yaginuma [Fix GH-1890]
Since `remove_method` is public.
Ref: https://bugs.ruby-lang.org/issues/14133
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64069 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- @shevegen Of course, we will take plenty of time to migrate before making it a keyword.
If we made the decision, we will make it warn you first for a year or two before the actual change.
Matz.
-
- I don't want to write too much, so just one comment - I would also prefer foo(kw: 1)
to retain being a Hash rather than to be assumed to be a keyword argument. I think
that it may surprise people when it would become a keyword suddenly. -
- I want to get 3 things.
1. Type (warning or error)
2. Message
3. Location
I think location interface should be the same as RubyVM::AST::Node
https://ruby-doc.org/core-2.6.0.preview2/RubyVM/AST/Node.html
My proposal is the f... -
- Good idea. Do you have an idea about API and implementation?
Maybe parse.y should be modified (== difficult). -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64068 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * dir.c (do_stat, do_lstat, do_opendir): need the length of the base
path for fstatat() when fd is valid.
* dir.c (glob_helper): fix for platforms where DT_UNKNOWN is not
available, e.g. Solaris.
git-svn-id: svn+ssh://ci.ruby-lang.... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64066 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * process.c (before_fork_ruby, after_fork_ruby): used only if fork()
or daemon() is available.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64065 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64064 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64063 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [email protected] wrote:
> Good point. Seems good. Thank you!
OK, commited as r64062
> BTW, I forget that why the trap handler is limited to main thread.
I can think of at least three reasons:
1) Similar to this bug: other thre... -
- Applied in changeset trunk|r64062.
----------
cont.c (ec_switch): prevent delayed/missed trap interrupt race
timer-thread may set trap interrupt with rb_threadptr_check_signal
at any time independent of GVL. This means timer-thread ma... -
- Oops, sorry forget about `sleep` lines.
-
- Good point. Seems good. Thank you!
BTW, I forget that why the trap handler is limited to main thread.
```
trap(:INT) do
p Thread.current
end
Thread.new{
sleep 1
Process.kill :INT, $$
p [:child, Thread.current]
}... -
- Applied in changeset trunk|r64062.
----------
cont.c (ec_switch): prevent delayed/missed trap interrupt race
timer-thread may set trap interrupt with rb_threadptr_check_signal
at any time independent of GVL. This means timer-thread ma... - 08:30 AM Revision 97538e81 (git): cont.c (ec_switch): prevent delayed/missed trap interrupt race
- timer-thread may set trap interrupt with rb_threadptr_check_signal
at any time independent of GVL. This means timer-thread may set
the trap interrupt flag on the previous execution context; causing
the flag to be unnoticed until a futur... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64061 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Thanks, applied as r64060.
I needed to add RUBYLIB=/path/to/bcrypt/lib to my make command
line to test bcrypt; but I suppose that's fine -
- Applied in changeset trunk|r64060.
----------
webrick: Support bcrypt password hashing
This adds a password_hash keyword argument to
WEBrick::HTTPAuth::Htpasswd#initialize. If set to :bcrypt, it
will create bcrypt hashes instead of cr... - 03:21 AM Revision 9749bfbf (git): webrick: Support bcrypt password hashing
- This adds a password_hash keyword argument to
WEBrick::HTTPAuth::Htpasswd#initialize. If set to :bcrypt, it
will create bcrypt hashes instead of crypt hashes, and will
raise an exception if the .htpasswd file uses crypt hashes.
If :bcr... -
-
-
-
-