Project

General

Profile

Activity

From 08/22/2018 to 08/28/2018

08/28/2018

07:46 PM Bug #15039: Random.urandom and SecureRandom arc4random use
On OpenBSD, arc4random is not really a userspace PRNG in the sense that it is reseeded on a regular basis using new e... jeremyevans0 (Jeremy Evans)
07:16 PM Bug #15039 (Closed): Random.urandom and SecureRandom arc4random use
Random.urandom defaults to arc4random() on a lot of platforms, including FreeBSD.
On all currently released versio...
Freaky (Thomas Hurst)
04:17 PM Bug #15038 (Closed): Appveyor MinGW - bundled gems missing?
I just noticed that the Appveyor MinGW build is not showing the installed bundled gems in the console output, althoug... MSP-Greg (Greg L)
02:55 PM Revision 8867f285 (git): Tag a couple specs failing on AIX
* The rest seems OS bugs, MRI bugs or incomplete IPv6 implementation:
https://rubyci.org/logs/rubyci.s3.amazonaws.c...
Eregon (Benoit Daloze)
01:42 PM Revision 8a999649 (git): Fixed installation failure with mswin environment.
[ruby-core:88699][Bug #15035]
This patch was provided by MSP-Greg.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tru...
hsbt (Hiroshi SHIBATA)
09:41 AM Revision d36cd0b0 (git): Update to ruby/spec@6fd9472
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64584 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
08:22 AM Feature #14097: Add union and difference to Array
[@Student](https://bugs.ruby-lang.org/users/6774) as I just answered in the [PR](https://github.com/ruby/ruby/pull/17... ana06 (Ana Maria Martinez Gomez)
08:19 AM Feature #15036 (Closed): after upgrade when run apt upgrade metasploit
... bennylangston (benny langston)
07:06 AM Feature #15010 (Closed): Reduce allocation for rest parameters
Applied in changeset trunk|r64583.
----------
rest parameter optimization [Feature #15010]
* vm_args.c: rb_ary_dup(...
ko1 (Koichi Sasada)
06:53 AM Feature #15010: Reduce allocation for rest parameters
It seems fine.
I'll commit it.
ko1 (Koichi Sasada)
07:06 AM Revision 1f4efb9a (git): rest parameter optimization [Feature #15010]
* vm_args.c: rb_ary_dup(args->rest) to be used at most once during
parameter setup. [Feature #15010]
A patch by c...
ko1 (Koichi Sasada)
06:49 AM Feature #15030: Have T_INTEGER constant for checking Integer types in C API
Eregon (Benoit Daloze) wrote:
> There are certainly cases where a C extension wants to check the argument is an Inte...
ko1 (Koichi Sasada)
03:58 AM Bug #15035: Windows make install failures
@MSP-Greg
Thanks for your patches. I will merge a patch of `tool/rbinstall.rb` after confirming with my windows en...
hsbt (Hiroshi SHIBATA)
03:53 AM Bug #15035: Windows make install failures
@hsbt
Thanks for applying the patch. I should have been clearer, as the patch fixes two issues, both involving Ru...
MSP-Greg (Greg L)
02:39 AM Bug #15035 (Closed): Windows make install failures
Applied in changeset trunk|r64582.
----------
Fixed test failures in mswin environment at r64555.
[ruby-core:8869...
hsbt (Hiroshi SHIBATA)
12:41 AM Bug #15035 (Closed): Windows make install failures
@hsbt
Windows has been failing on install, seems due to a combination of RubyGems changes.
ruby-loco is passing...
MSP-Greg (Greg L)
02:39 AM Revision 715666cc (git): Fixed test failures in mswin environment at r64555.
[ruby-core:88699][Bug #15035]
This patch was provided by MSP-Greg.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tru...
hsbt (Hiroshi SHIBATA)
02:04 AM Misc #15014: thread.c: use rb_hrtime_scalar for high-resolution time operations
On 2018/08/27 18:17, Eric Wong wrote:
>>> A joke; at least as far as we know it is a joke :>
>>
>> I'm not sure w...
ko1 (Koichi Sasada)
01:00 AM Feature #14844: Future of RubyVM::AST?
I hope this is relevant.
I found an interesting article here: http://www.oilshell.org/blog/2016/12/11.html
It d...
ioquatix (Samuel Williams)
12:24 AM Revision 4d9c2377 (git): thread_pthread.h: rename `gvl.acquired' to `gvl.owner' and document
`acquired' was an old boolean variable, but nowadays it is a
rb_thread_t pointer; "gvl.owner" seems like a more appr...
Eric Wong
12:12 AM Bug #15034 (Feedback): Crash in Opensuse Software management
Thank you for your report.
This is a issue tracker for ruby development, and I'm not at all familiar with Yast2 pa...
mame (Yusuke Endoh)

08/27/2018

11:39 PM Revision fcaf8745 (git): thread_pthread.c: document sigwait_th and sigwait_fd [ci skip]
This is an important concept to document, I think.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64580 b2dd03c8-...
Eric Wong
11:29 PM Revision 1b1274f7 (git): thread_pthread.c: fix deadlock on test_thread.rb::test_signal_at_join
Fixes: r64575 ("avoid lock ping-pong in do_gvl_timer & ubf_select")
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun...
Eric Wong
09:37 PM Bug #15034 (Closed): Crash in Opensuse Software management
Hi,
the problem appears when starting the Software Management component of Open Suse's Yast2 package manager.
Th...
[email protected] (Martin Strecker)
09:19 PM Bug #15033 (Closed): Encoding fallback uses wrong character when multiple conversions are required
When converting a string from one encoding to another that involves multiple conversions, the proc passed to `encode`... stevecheckoway (Stephen Checkoway)
08:32 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
> https://bugs.ruby-lang.org/issues/13618

Btw, many of my recent changes ([Misc #15014] (rb_hrtime_t)),
and proc...
normalperson (Eric Wong)
07:08 PM Revision 8500714a (git): Rewrite Etc.sysconf spec to allow nil or Integer for all variables
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64578 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
06:37 PM Revision e61e6ae5 (git): process.c: fix potential missed wakeups in r64576
Oddly, all existing test cases passed multiple times
before this patch (even with --jit-wait), so this seems
like a d...
Eric Wong
06:34 PM Feature #14912: Introduce pattern matching syntax
"The patterns are run in sequence until the first one that matches."
This means O(n) time for matching. If we are ...
dsisnero (Dominic Sisneros)
05:17 PM Revision 9d4027b5 (git): process.c: simplify SIGCHLD-based waitpid
Introduce a new rb_thread_sleep_interruptible that does not
execute interrupts before sleeping. Skipping the interru...
Eric Wong
05:17 PM Revision 943bf37b (git): thread_pthread.c: avoid lock ping-pong in do_gvl_timer & ubf_select
This simplifies the locking logic somewhat.
While we're at it, designate_timer_thread is worthless in
ubf_select bec...
Eric Wong
04:38 PM Revision cda13d8c (git): * 2018-08-28
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64574 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:38 PM Revision 5ffa775f (git): SC_TZNAME_MAX can also be infinite
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64573 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
04:22 PM Revision 293ed16e (git): * append newline at EOF.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64572 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:22 PM Revision 2dca35b9 (git): Update to ruby/spec@007e908
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64571 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
04:07 PM Bug #14920: Backport r63857 to fix performance problem on Time class in MacOs systems
Hi @usa.
63994 alone doesn't fix the issue. I just cloned ruby_2_4 with r64560 and run the same benchmark script ...
rafaelfranca (Rafael França)
01:59 PM Bug #14920: Backport r63857 to fix performance problem on Time class in MacOs systems
ruby_2_4 r64560 merged revision(s) 63994. usa (Usaku NAKAMURA)
02:49 PM Revision 58689fa7 (git): * append newline at EOF.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64570 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:49 PM Revision 85d1a8ba (git): Update to ruby/spec@a89819d
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64569 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
02:33 PM Revision 35f2b71c (git): Fix template/fake.rb.in if ENV["RUBYOPT"] is nil
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64568 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
02:25 PM Revision 5e9cd520 (git): Fix template/fake.rb.in when external and internal encodings are set
* To be able to run spec/ruby/command_line/dash_encoding_spec.rb
with the in-repo build.
git-svn-id: svn+ssh://ci....
Eregon (Benoit Daloze)
02:25 PM Revision cea7d047 (git): * append newline at EOF.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64566 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:25 PM Revision 8180b5bf (git): Update to ruby/spec@09fa86c
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64565 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
02:19 PM Bug #14942: Windows7でコンソールに長い文字列を出力できない
ruby_2_4 r64564 merged revision(s) 64092. usa (Usaku NAKAMURA)
02:18 PM Revision cccbcd17 (git): merge revision(s) 64092: [Backport #14942]
win32.c: limit write size on console
* win32/win32.c (constat_parse): split long buffer and limit write
...
U.Nakamura
02:15 PM Bug #14941: WindowsでARGVの文字列に汚染マークが付いてない
ruby_2_4 r64563 merged revision(s) 64071. usa (Usaku NAKAMURA)
02:15 PM Revision 94e65989 (git): merge revision(s) 64071: [Backport #14941]
ruby.c: taint ARGV on Windows
* ruby.c (external_str_new_cstr): strings come from the external
sho...
U.Nakamura
02:11 PM Bug #14926: Different results between Enumerable#sum and #reduce when Float::INFINITY present
ruby_2_4 r64562 merged revision(s) 64014. usa (Usaku NAKAMURA)
02:11 PM Revision ba757763 (git): merge revision(s) 64014: [Backport #14926]
fix sum on infinity
* array.c (rb_ary_sum): consider non-finite floats.
[ruby-core:88024] [Bug #14...
U.Nakamura
02:08 PM Bug #14929: [PATCH] thread.c (do_select): fix leak on exception
ruby_2_4 r64561 merged revision(s) 64007,64019,64020. usa (Usaku NAKAMURA)
02:08 PM Revision 95abe79e (git): merge revision(s) 64007,64019,64020: [Backport #14929]
thread.c (do_select): fix leak on exception
When do_select is interrupted and raise happens from
RUB...
U.Nakamura
01:59 PM Revision 1bbf7789 (git): merge revision(s) 63994: [Backport #14920]
reduce tzset
* time.c (rb_localtime_r): call tzset() only after TZ environment
variable is changed...
U.Nakamura
01:48 PM Bug #14853: [BACKPORT] NameError#receiver at private constant returns a hidden object
ruby_2_4 r64559 merged revision(s) 63696. usa (Usaku NAKAMURA)
01:48 PM Revision 4941bba3 (git): merge revision(s) 63696: [Backport #14853]
variable.c: fix receiver on private constant
* variable.c (rb_const_search): fix NameError :receiver attribu...
U.Nakamura
01:47 PM Bug #14495: Enumerator::Lazy#uniq invalid state
ruby_2_4 r64558 merged revision(s) 62731,62735. usa (Usaku NAKAMURA)
01:47 PM Revision 7d957281 (git): merge revision(s) 62731,62735: [Backport #14495]
Bug Fix Enumerator::Lazy#uniq state for multiple call
* enumerator.c (lazy_uniq_i): create new hash for each...
U.Nakamura
12:03 PM Feature #15030: Have T_INTEGER constant for checking Integer types in C API
[email protected] wrote:
> There are certainly cases where a C extension wants to check the argument is an Integer,...
normalperson (Eric Wong)
10:02 AM Feature #15030: Have T_INTEGER constant for checking Integer types in C API
There are certainly cases where a C extension wants to check the argument is an `Integer`, and its range doesn't matt... Eregon (Benoit Daloze)
06:05 AM Feature #15030 (Rejected): Have T_INTEGER constant for checking Integer types in C API
+1 for Hanmac.
C extension writers should check `T_FIXNUM` or `T_BIGNUM` explicitly.
ko1 (Koichi Sasada)
05:49 AM Feature #15030: Have T_INTEGER constant for checking Integer types in C API
hm that is not that easy, while `Fixnum` and `Bignum` are deprecated on the ruby side,
on the C side they still exis...
Hanmac (Hans Mackowiak)
05:12 AM Feature #15030 (Rejected): Have T_INTEGER constant for checking Integer types in C API
After Integer unification in Ruby 2.4, I think it makes sense to introduce a T_INTEGER
type that helps in directly ...
v0dro (Sameer Deshmukh)
11:45 AM Feature #15031: T_RANGE for testing whether object is a Range
ko1 (Koichi Sasada) wrote:
> `rb_obj_is_range()` can be accepted like `rb_obj_is_proc` and so on.
> `T_xxx` shows d...
v0dro (Sameer Deshmukh)
06:06 AM Feature #15031: T_RANGE for testing whether object is a Range
`rb_obj_is_range()` can be accepted like `rb_obj_is_proc` and so on.
`T_xxx` shows data layout of `RVALUE`.
ko1 (Koichi Sasada)
05:28 AM Feature #15031 (Open): T_RANGE for testing whether object is a Range
Range is an in-built type of Ruby and it would be better for C extension
writers if there existed a constant `T_RANG...
v0dro (Sameer Deshmukh)
10:54 AM Feature #14975: String#append without changing receiver's encoding
> Is there a use-case for using this new method with non-binary strings?
Yes, predictably appending strings withou...
ioquatix (Samuel Williams)
09:46 AM Feature #14975: String#append without changing receiver's encoding
I agree the current behavior for appending with binary strings is surprising.
Especially since the result of the ope...
Eregon (Benoit Daloze)
10:12 AM Revision a6413848 (git): Simplify guards, the behavior seems Linux-specific
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64557 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
10:08 AM Feature #15010: Reduce allocation for rest parameters
@ko1, I've added new field rest_dupped to args_info.
Updated patch https://bugs.ruby-lang.org/attachments/7344/Re...
chopraanmol1 (Anmol Chopra)
07:41 AM Feature #15010: Reduce allocation for rest parameters
ko1 (Koichi Sasada) wrote:
> # Idea (as my understanding)
>
> ~a rest parameter" is dup multiple times because of...
chopraanmol1 (Anmol Chopra)
06:33 AM Feature #15010: Reduce allocation for rest parameters
Sorry for late response.
# Idea (as my understanding)
~a rest parameter" is dup multiple times because of curre...
ko1 (Koichi Sasada)
05:26 AM Feature #15010: Reduce allocation for rest parameters
@ko1, It would be great if you could review https://bugs.ruby-lang.org/attachments/7343/Reduce-allocation-for-rest-pa... chopraanmol1 (Anmol Chopra)
10:05 AM Revision 73c8b1ea (git): * remove trailing spaces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64556 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
10:05 AM Revision 85d46145 (git): Merge master branch from rubygems upstream.
* It's preparation to release RubyGems 3.0.0.beta2 and Ruby 2.6.0
preview 3.
* https://github.com/rubygems/ruby...
hsbt (Hiroshi SHIBATA)
09:22 AM Misc #15014: thread.c: use rb_hrtime_scalar for high-resolution time operations
Koichi Sasada <[email protected]> wrote:
> On 2018/08/27 16:16, Eric Wong wrote:
> > Yep. Maybe some small systems ca...
normalperson (Eric Wong)
07:42 AM Misc #15014: thread.c: use rb_hrtime_scalar for high-resolution time operations
On 2018/08/27 16:16, Eric Wong wrote:
> Yep. Maybe some small systems can benefit with
> usec/msec resolution and...
ko1 (Koichi Sasada)
07:22 AM Misc #15014: thread.c: use rb_hrtime_scalar for high-resolution time operations
[email protected] wrote:
> Thanks!
>
> > + * Hi-res monotonic clock. It is currently nsec resolution, which has ove...
normalperson (Eric Wong)
06:55 AM Misc #15014: thread.c: use rb_hrtime_scalar for high-resolution time operations
Thanks!
> + * Hi-res monotonic clock. It is currently nsec resolution, which has over 500 years of range (unsigne...
ko1 (Koichi Sasada)
08:48 AM Revision 3a83ba90 (git): hrtime.h: add note explaining current use of uint64_t [ci skip]
[ruby-core:88678]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64554 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
06:31 AM Bug #13671: Regexp with lookbehind and case-insensitivity raises RegexpError only on strings with certain characters
Thanks shyouhei for your pointing out.
I imagine another Rexexp option, say `//I`, which is almost the same as `/...
gotoken (Kentaro Goto)
06:02 AM Bug #13671: Regexp with lookbehind and case-insensitivity raises RegexpError only on strings with certain characters
gotoken (Kentaro Goto) wrote:
> By the way, this expansion by `//i` option looks over kill for me.
> I wish case s...
shyouhei (Shyouhei Urabe)
05:44 AM Bug #13671: Regexp with lookbehind and case-insensitivity raises RegexpError only on strings with certain characters
Thanks znz. The workaround is helpful. And I understood what was happened.
https://github.com/k-takata/Onigmo/issues...
gotoken (Kentaro Goto)
03:46 AM Bug #13671: Regexp with lookbehind and case-insensitivity raises RegexpError only on strings with certain characters
You can use `(?:s)` instead of `s` for workaround.
```
$ ruby -ve '/(?<=ast)/iu'
ruby 2.5.1p57 (2018-03-29 revis...
znz (Kazuhiro NISHIYAMA)
02:35 AM Bug #13671: Regexp with lookbehind and case-insensitivity raises RegexpError only on strings with certain characters
I encountered a non `ss` case. Is this a same problem?
```
% ruby -ve '"".match(/(?<=ast)/ui)'
ruby 2.6.0dev (2...
gotoken (Kentaro Goto)
05:49 AM Revision 50840311 (git): hrtime.h: missing paren
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64553 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
05:48 AM Revision 995bc923 (git): hrtime.h: explicit casts to time_t
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64552 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
05:39 AM Revision 762f44cf (git): configure.ac: printf prifix for int64_t
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64551 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
05:32 AM Revision 49a55f28 (git): thread.c: check interrupts explicitly in select/ppoll blocking regions
The logic around blocking_region_begin is confusing to me,
but the goal of this patch is to ensure rb_sigwait_fd_get
...
Eric Wong
04:41 AM Bug #13593: Addrinfo#== behaves oddly
ioquatix (Samuel Williams) wrote:
> Doing a binary comparison would be acceptable.
I don't think so. As Akira al...
shyouhei (Shyouhei Urabe)
04:33 AM Bug #13593: Addrinfo#== behaves oddly
Doing a binary comparison would be acceptable. ioquatix (Samuel Williams)
04:29 AM Bug #14880: Time#localtime doesn't always seem to respect TZ
@nobu Isn't changing TZ enough that `#localtime` should do something? ioquatix (Samuel Williams)
04:25 AM Feature #14888: Add trace point for eval (and related functions)
@marcandre I already added support for coverage of templates and it works pretty well. You need to be careful with te... ioquatix (Samuel Williams)
04:23 AM Feature #15022: Oneshot coverage
Did you take a look at https://github.com/ioquatix/covered - I'd be interested in your feedback. Can we discuss furth... ioquatix (Samuel Williams)
04:22 AM Feature #15022: Oneshot coverage
What about using trace points? ioquatix (Samuel Williams)
04:19 AM Misc #14981: DevelopersMeeting20180913Japan
* [Feature #14975] String#append without changing receiver's encoding (ioquatix)
* Can we review this PR? We need ...
ioquatix (Samuel Williams)
01:30 AM Revision bab586e7 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64549 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:30 AM Revision 6a052fcd (git): * remove trailing spaces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64548 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:30 AM Revision 95e213d3 (git): Merge rdoc-6.1.0.beta1.
* https://github.com/ruby/rdoc/compare/v6.0.4...v6.1.0.beta1
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64547...
hsbt (Hiroshi SHIBATA)
12:44 AM Revision 41fb2436 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64546 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:44 AM Revision 56ac079e (git): * 2018-08-27
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64545 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:44 AM Revision 867581dd (git): Merge psych-3.1.0.pre1.
* Update bundled libyaml-0.2.1 from 0.1.7.
https://github.com/ruby/psych/pull/368
* Unify Psych's API: To use k...
hsbt (Hiroshi SHIBATA)

08/26/2018

11:49 PM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
naruse (Yui NARUSE) wrote:
> methodmissing (Lourens Naudé) wrote:
> > ko1 (Koichi Sasada) wrote:
> > > I agree to ...
methodmissing (Lourens Naudé)
12:41 PM Revision e0311eb8 (git): test/ruby/test_io.rb (test_recycled_fd_close): Linux workaround
Arch Linux CI still seems to timeout on this test...
Note, I can't reproduce the failures in these tests on a
FreeBS...
Eric Wong
12:41 PM Revision 70d6c1a1 (git): thread_sync.c: common wakeup_{one,all} implementation
This let us avoid looping in rb_szqueue_max_set, saves us
some lines of code and reduces binary size slightly
(number...
Eric Wong
12:36 PM Bug #15027: When Struct#each method is overriden Struct#select and Struct#to_a use wrong collections
as a middle way, can't we just do the "is overwritten by user" check?
i think i have seen it on other classes like A...
Hanmac (Hans Mackowiak)
06:53 AM Bug #15027: When Struct#each method is overriden Struct#select and Struct#to_a use wrong collections
Since matz asked for feedback, just a comment - I have no particular pro or con opinion
per se, mostly because I ver...
shevegen (Robert A. Heiler)
02:46 AM Bug #15027: When Struct#each method is overriden Struct#select and Struct#to_a use wrong collections
I'm against changing the current behavior. If you can override `each`, you can override other methods. If we wanted... jeremyevans0 (Jeremy Evans)
01:56 AM Bug #15027 (Feedback): When Struct#each method is overriden Struct#select and Struct#to_a use wrong collections
The proposed behavior is more consistent but slower. I am not sure it's a good idea to hinder performance by supporti... matz (Yukihiro Matsumoto)
09:08 AM Feature #14097 (Assigned): Add union and difference to Array
Thank you for the answer. I'm assigning this ticket to matz. mame (Yusuke Endoh)
08:52 AM Feature #14097: Add union and difference to Array
@mame
> However, I'm now getting confused. I thought you agreed that Array#union should be non-destructive, but in...
ana06 (Ana Maria Martinez Gomez)
06:03 AM Bug #15019 (Assigned): Documentation for Net::HTTP claims that multipart/form-data is not supported
hsbt (Hiroshi SHIBATA)
04:29 AM Revision 84859fd2 (git): process.c: remove worthless waitpid_sys macro
It is identical to do_waitpid, and the win32 version will not
be needed for MJIT (since win32 does not suffer from th...
Eric Wong

08/25/2018

10:32 PM Revision 32910b87 (git): test/io/wait/test_io_wait_uncommon.rb: relax /dev/random check
Too many machines lack entropy to have a usable /dev/random. I
had similar problems on my system until I started usi...
Eric Wong
10:14 PM Revision 894847a5 (git): thread_pthread.c (ubf_wakeup_thread): `th' is never NULL
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64539 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eric Wong
09:59 PM Revision 70a8a6d3 (git): thread_pthread.c: main thread always gets hit by signals
We need to ensure Signal.trap handlers can function if the main
thread is sleeping after a subthread has grabbed sigw...
Eric Wong
09:33 PM Revision 49309733 (git): * 2018-08-26
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64537 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
09:33 PM Revision b4084d7c (git): thread.c: quiet down -Wmaybe-uninitialized on gcc 7.[2-3]
Haven't tested gcc 8, yet; but gcc 6 seems fine....
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64536 b2dd03c8...
Eric Wong
05:40 PM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
methodmissing (Lourens Naudé) wrote:
> ko1 (Koichi Sasada) wrote:
> > I agree to introduce COLD attribute.
>
> I...
naruse (Yui NARUSE)
05:29 PM Bug #15027 (Rejected): When Struct#each method is overriden Struct#select and Struct#to_a use wrong collections
### Bug
Here's the code snippet that should reproduce the problem:
~~~ ruby
class Foo < Struct.new(:bar)
de...
bruno (Bruno Sutic)
03:13 PM Feature #14097: Add union and difference to Array
Ana, I watched the video of [your EuRuKo talk](https://www.youtube.com/watch?v=jUc8InwoA-E). I could understand the ... mame (Yusuke Endoh)
09:02 AM Revision 95abea43 (git): hrtime.h: add documentation
I updated the patch with documentation but forgot about it,
earlier :x
[ruby-core:88616] [Misc #15014]
git-svn-id: ...
Eric Wong
06:58 AM Misc #15014 (Closed): thread.c: use rb_hrtime_scalar for high-resolution time operations
Applied in changeset trunk|r64533.
----------
thread.c: use rb_hrtime_t scalar for high-resolution time operations
...
normalperson (Eric Wong)
06:58 AM Revision 0e063601 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64534 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:58 AM Revision b0253a75 (git): thread.c: use rb_hrtime_t scalar for high-resolution time operations
Relying on "struct timespec" was too annoying API-wise and
used more stack space. "double" was a bit wacky w.r.t rou...
Eric Wong
05:05 AM Feature #15024: Support block in Array#join
I'd like somewhat to agree with the motivation. Indeed, I sometimes feel I want to insert separators between each pa... mame (Yusuke Endoh)
03:23 AM Feature #15024: Support block in Array#join
`Array#join` concatenates array elements recursively.
What do you expect as the index between different level elements?
nobu (Nobuyoshi Nakada)
02:32 AM Revision 7c31c273 (git): drb: close graceful shutdown pipe before socket
Closing a listen socket while entering select(2) may
trigger IOError or even deadlock because another thread
may give...
Eric Wong
02:32 AM Revision a4802248 (git): drb: simplify shutdown pipe close logic
IO#close is idempotent, so we don't need to waste bytecode
to check or nil it at shutdown time.
git-svn-id: svn+ssh:...
Eric Wong
01:13 AM Bug #15025 (Closed): Encountered a bug in interpreter or extension libraries
Seems an already fixed bug. nobu (Nobuyoshi Nakada)

08/24/2018

10:32 PM Revision 7710bdd1 (git): Add AIX guards
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64530 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)
08:55 PM Feature #15024: Support block in Array#join
For `%{a b c d}.join { |_,_,i| i.to_s } == "a0b1c2d"`, you could do:
~~~ ruby
*a, l = %w{a b c d}; a.each.with_ob...
jeremyevans0 (Jeremy Evans)
07:54 PM Feature #15024: Support block in Array#join
Doesn't `#each_slice` create temporary array for each pair? Doesn't seem very efficient. But assuming that does not m... graywolf (Gray Wolf)
05:45 PM Feature #15024: Support block in Array#join
Your examples are both possible to implement using existing Array methods:
~~~ ruby
puts %w{a b c d}.each_slice(2...
jeremyevans0 (Jeremy Evans)
05:11 PM Feature #15024 (Open): Support block in Array#join
I think it could be handy to have block support in Array#join.
For example
```ruby
> puts %w{a b c d}.join { |...
graywolf (Gray Wolf)
08:28 PM Revision 6277b924 (git): test/ruby/test_io.rb (test_recycled_fd_close): use IO#read to avoid ppoll call
IO#sysread calls rb_wait_for_single_fd for compatibility, and
perhaps something is amiss with that (unrelated to time...
Eric Wong
08:03 PM Bug #15025 (Closed): Encountered a bug in interpreter or extension libraries
/Users/suyesh/.rbenv/versions/2.6.0-preview2/lib/ruby/gems/2.6.0/gems/bootsnap-1.3.1/lib/bootsnap/compile_cache/iseq.... suyesh (suyesh bhandari)
07:19 PM Misc #15011 (Closed): [PATCH] thread_pthread.c: use eventfd instead of pipe on Linux
Applied in changeset trunk|r64527.
----------
thread_pthread.c: use eventfd instead of pipe on Linux
Based on r6447...
normalperson (Eric Wong)
07:19 PM Revision 72af13f3 (git): * 2018-08-25
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64528 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
07:19 PM Revision 0a77fd04 (git): thread_pthread.c: use eventfd instead of pipe on Linux
Based on r64478, any regular user creating more than 1024 pipes
on Linux will end up with tiny pipes with only a sing...
Eric Wong
04:04 PM Bug #15023: Time precision (in microsecond) inaccurate after performing strftime
`Time.at` supports `Rational` numbers too.
```ruby
puts Time.at(1486525793.995r).strftime("%s.%6N") #=> 148652579...
nobu (Nobuyoshi Nakada)
03:58 PM Bug #15023 (Rejected): Time precision (in microsecond) inaccurate after performing strftime
IEEE 754 floating point numbers are inexact, and cannot represent that value exactly.
```ruby
printf("%.20f\n", 1...
nobu (Nobuyoshi Nakada)
03:41 PM Bug #15023 (Rejected): Time precision (in microsecond) inaccurate after performing strftime
Please see the example below. I think we should expect the result to be "1486525793.995". Right?
OS version: MacOS...
calvinchso (Calvin So)
02:47 PM Bug #14997: Socket connect timeout exceeds the timeout value for
If anyone is actually willing to confirm, that it is indeed an unwanted / unexpected behavior, I offer to fix it.
...
maciej.mensfeld (Maciej Mensfeld)
02:47 PM Bug #15021: Segfault when compiling certain code on Ruby 2.5.1
I think this is duplicate of https://bugs.ruby-lang.org/issues/14897 which contain the fix and the backport request t... rafaelfranca (Rafael França)
09:56 AM Bug #15021: Segfault when compiling certain code on Ruby 2.5.1
Can reproduce this on 2.5, but not on trunk. Seems 2.5 needs a backport?
Not sure which is the exact revision though.
shyouhei (Shyouhei Urabe)
09:44 AM Bug #15021: Segfault when compiling certain code on Ruby 2.5.1
Sorry there's a small typo. The command to run the script is `ruby code.rb` not `ruby foo.rb` st0012 (Stan Lo)
09:40 AM Bug #15021 (Closed): Segfault when compiling certain code on Ruby 2.5.1

## Steps to reproduce
save the following code to `code.rb`
```
code =<<CODE
if false
new(arg: $arg)
end
CO...
st0012 (Stan Lo)
01:32 PM Misc #14981: DevelopersMeeting20180913Japan
* [Feature #15022] Oneshot coverage
* I'd like to introduce a new kind of coverage to record whether each line is ...
mame (Yusuke Endoh)
01:28 PM Feature #15022 (Closed): Oneshot coverage
I'd like to introduce a new feature to the coverage library, namely, "oneshot coverage".
## Synopsis
The follow...
mame (Yusuke Endoh)
10:25 AM Bug #15020 (Closed): [PATCH] Add 'guards' for mswin, mingw, update test_readline.rb
Applied in changeset trunk|r64526.
----------
ext/readline/extconf.rb: try using more readline APIs
on MinGW.
[Bug...
k0kubun (Takashi Kokubun)
01:58 AM Bug #15020: [PATCH] Add 'guards' for mswin, mingw, update test_readline.rb
@k0kubun,
I forgot one patch that I have on `ext/readline/extconf.rb`, at [ruby-loco/patches/ext-readline-extconf....
MSP-Greg (Greg L)
10:25 AM Revision 5bd4283f (git): ext/readline/extconf.rb: try using more readline APIs
on MinGW.
[Bug #15020]
From: MSP-Greg <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6452...
k0kubun (Takashi Kokubun)
08:26 AM Feature #14989: Add Hash support for transient heap
~~~
Hello, I took a look at add-hash-support-for-transient-heap.patch.
It seems lines are copy & pasted from st.c...
shyouhei (Shyouhei Urabe)
05:55 AM Feature #15009 (Assigned): Add negotiated SSL protocol and cipher to Net::HTTP debug output
znz (Kazuhiro NISHIYAMA)

08/23/2018

11:50 PM Revision 6264225c (git): test/readline/test_readline.rb: fix readline test
for mingw.
test/lib/minitest/unit.rb: Add 'guards' for mingw.
Removed still-unused method `mswin?` from original pat...
k0kubun (Takashi Kokubun)
07:49 PM Revision 7bde63fa (git): thread_pthread.c (ubf_timer_destroy): remove redundant getpid check
TIMER_THREAD_CREATED_P already checks that pid, and glibc 2.25+
no longer caches getpid(2).
git-svn-id: svn+ssh://ci...
Eric Wong
07:13 PM Revision f3bf0e1b (git): * 2018-08-24
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64523 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
07:13 PM Revision 8ae44386 (git): NEWS: add entries for rb_waitpid and timer-thread [ci skip]
Some of these changes may affect debugging and tracing tools
[Bug #14867] [ruby-core:88199] [Misc #14937]
git-svn-i...
Eric Wong
06:01 PM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
Hanmac (Hans Mackowiak) wrote:
> what happens when i would call such cold function outside of Init_xxx ?
I consid...
methodmissing (Lourens Naudé)
05:57 PM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
ko1 (Koichi Sasada) wrote:
> I agree to introduce COLD attribute.
I was wondering about Eric's suggestion about t...
methodmissing (Lourens Naudé)
02:16 PM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
what happens when i would call such cold function outside of Init_xxx ?
what functions in my own binding should be...
Hanmac (Hans Mackowiak)
08:20 AM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
I agree to introduce COLD attribute.
----
> TLB (translation lookaside buffer) specific
Do PHP people specif...
ko1 (Koichi Sasada)
05:28 PM Bug #15020 (Closed): [PATCH] Add 'guards' for mswin, mingw, update test_readline.rb
When the mingw build was added, test_readline.rb failed. One test fails on mingw, several tests error due to the win... MSP-Greg (Greg L)
12:40 PM Bug #15019 (Closed): Documentation for Net::HTTP claims that multipart/form-data is not supported
https://ruby-doc.org/stdlib-2.5.1/libdoc/net/http/rdoc/Net/HTTP.html claims that `At this time Net::HTTP does not sup... graywolf (Gray Wolf)
10:42 AM Misc #15014: thread.c: use rb_hrtime_scalar for high-resolution time operations
[email protected] wrote:
> Just a comment.

> API references (a list of provided functions with a comment) at the beg...
normalperson (Eric Wong)
07:16 AM Misc #15014: thread.c: use rb_hrtime_scalar for high-resolution time operations
Just a comment.
API references (a list of provided functions with a comment) at the beginning of the hrtime.h will h...
ko1 (Koichi Sasada)
08:49 AM Revision 7c9af3e1 (git): iseq.c (rb_vm_encoded_insn_data_table_init): add a cast to build on clang
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64521 b2dd03c8-39d4-4d8f-98ff-823fe69b080e mame (Yusuke Endoh)
08:33 AM Revision 57a5a3eb (git): Mention `--enable=jit` instead of `--jit`
"--jit" flag usage may be deprecated at r63995 [Feature #14878]
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/rub...
znz (Kazuhiro NISHIYAMA)
08:32 AM Revision 5b720972 (git): iseq.c (rb_iseq_trace_set): refactoring by using encoded_insn_data
Now it uses encoded_insn_data to identify and replace each encoded insn.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby...
mame (Yusuke Endoh)
08:32 AM Revision d574683c (git): iseq.c: add a map from encoded insn to insn data
This enhances rb_vm_insn_addr2insn which retrieves a decoded insn number
from encoded insn.
The insn data table inclu...
mame (Yusuke Endoh)
07:45 AM Revision bf6e2eb7 (git): compile.c: drop unused array
* compile.c (iseq_peephole_optimize): drop unused dynamic array
literal, without concatenation.
git-svn-id: svn+ss...
nobu (Nobuyoshi Nakada)
07:41 AM Feature #15010: Reduce allocation for rest parameters
ko1 (Koichi Sasada) wrote:
> sorry, which patch should I review?
Reduce-allocation-for-rest-parameters-v1.patch
chopraanmol1 (Anmol Chopra)
07:22 AM Feature #15010: Reduce allocation for rest parameters
sorry, which patch should I review?
ko1 (Koichi Sasada)
07:22 AM Revision 130ef3b4 (git): compile.c: drop unused string
* compile.c (iseq_peephole_optimize): drop unused dynamic string
literal, without concatenation.
git-svn-id: svn+s...
nobu (Nobuyoshi Nakada)
07:11 AM Bug #14817 (Feedback): TracePoint#parameters for bmethod's return event should return the same value as its Method#parameters
ko1 (Koichi Sasada)
07:10 AM Bug #14817: TracePoint#parameters for bmethod's return event should return the same value as its Method#parameters
見逃してました。
これ、実装見てたら、どーしょーもない気がするんで、制限のある仕様、ってことで駄目でしょうか。駄目かなあ。実装アイディア募集。
ko1 (Koichi Sasada)
05:54 AM Revision 8752a1ff (git): remove `const` warning.
* compile.c (iseq_ibf_load): remove `const` to pass iseq as no `const`
parameter.
git-svn-id: svn+ssh://ci.ruby-l...
ko1 (Koichi Sasada)
04:13 AM Bug #14702 (Closed): On Ruby 2.5.1, tracepoint isn't working on the file that is loaded by load_iseq
Applied in changeset trunk|r64514.
----------
check trace flags at loading [Bug #14702]
* iseq.c (iseq_init_trace):...
ko1 (Koichi Sasada)
04:12 AM Revision b85b10c1 (git): check trace flags at loading [Bug #14702]
* iseq.c (iseq_init_trace): at ISeq loading time, we need to check
`ruby_vm_event_enabled_flags` to turn on trace i...
ko1 (Koichi Sasada)

08/22/2018

07:18 PM Revision 870af862 (git): Also skip on AIX
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64513 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)
04:02 PM Revision 37fa201e (git): compile.c: pop literal object in condition
* compile.c (compile_branch_condition): pop dynamic literal
object, which is never nil/false, as the branch conditi...
nobu (Nobuyoshi Nakada)
03:04 PM Bug #15018: NODE_ARGSCAT is not parsed properly
Good catch! I've committed it. Thank you! mame (Yusuke Endoh)
03:04 PM Bug #15018 (Closed): NODE_ARGSCAT is not parsed properly
Applied in changeset trunk|r64510.
----------
parse.y (arg_append): support NODE_ARGSCAT case
Because of the lack o...
mame (Yusuke Endoh)
12:10 PM Bug #15018 (Closed): NODE_ARGSCAT is not parsed properly
Instead of wrapping following arguments in one list, current implementation creates multiple list wrapping only 2 ele... chopraanmol1 (Anmol Chopra)
03:04 PM Revision 954613bd (git): * 2018-08-23
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64511 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:04 PM Revision fad01941 (git): parse.y (arg_append): support NODE_ARGSCAT case
Because of the lack of this case, `[*ary,1,2,3,4,5,6]` was parsed into
an inefficient AST like `ary + [1,2] + [3,4] +...
mame (Yusuke Endoh)
02:46 PM Bug #13889: FileUtils.rmdir が Errno::ENOTEMPTY を無視している
Seems related to https://bugs.ruby-lang.org/issues/3178 - maybe close that ticket? apeiros (Stefan Rusterholz)
11:47 AM Misc #15012: Testing on latest version gcc on Travis CI
Hi Greg,
> Sorry, my message was unclear.
No problem at all. Thanks for the explanation to be cleared.
> th...
jaruga (Jun Aruga)
11:09 AM Revision 100bf275 (git): compile.c: remove tracecoverage instruction for line coverage
Line coverage was based on special instruction "tracecoverage".
Now, instead, it uses the mechanism of trace hook [Fe...
mame (Yusuke Endoh)
10:38 AM Revision d65f7458 (git): parse.y: remove coverage-related code fragments
The code fragments that initializes coverage data were scattered into
both parse.y and compile.c. parse.y allocated ...
mame (Yusuke Endoh)
10:38 AM Revision 52bd0d19 (git): node.h (rb_ast_t): move its field mark_ary to node_buffer_t
I want to add a new field to rb_ast_t whose size is restricted because
it is an imemo. This change makes one room in...
mame (Yusuke Endoh)
10:22 AM Revision c5f50296 (git): prototized
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64506 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
10:13 AM Bug #15001: Peek causes cursor to advance when enumerating the lines of a file
i think the problem is that String Enumerations are rewindable while on the IO/File it is not Hanmac (Hans Mackowiak)
09:48 AM Bug #15001: Peek causes cursor to advance when enumerating the lines of a file
with slight modification of the above code,
~~~ ruby
e = File.open("f").each_line
p e.each.to_a
e.peek
p e.each....
ysfk (Yosfik Alqadri)
05:42 AM Feature #15017: Provide extended information about Signal
> Feature #15017: Provide extended information about Signal
> https://bugs.ruby-lang.org/issues/15017#change-73659
...
normalperson (Eric Wong)
02:57 AM Feature #15017: Provide extended information about Signal
shevegen (Robert A. Heiler) wrote:
> Some comments (personal opinion here):
>
> 1) I think the described use case...
nobu (Nobuyoshi Nakada)
05:24 AM Revision 664bf8bf (git): common.mk: update "make help" so that "make check" now runs test-spec
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64505 b2dd03c8-39d4-4d8f-98ff-823fe69b080e mame (Yusuke Endoh)
05:24 AM Revision 33af0429 (git): thread.c (rb_reset_coverages): remove coverage counters from all ISeqs
When coverage measurement is enabled, the compiler makes each iseq have
a reference to the counter array of coverage....
mame (Yusuke Endoh)
04:04 AM Revision 84fd997f (git): Avoid compiler depend error
ref r64492
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64503 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
znz (Kazuhiro NISHIYAMA)
 

Also available in: Atom