Activity
From 10/24/2018 to 10/30/2018
10/30/2018
-
11:48 PM Bug #14867: Process.wait can wait for MJIT compiler process
- > holding vm->waitpid_lock across two Ruby method calls won't work.
Oh, I see.
> AFAIK, the waitpid code has be... -
04:22 PM Bug #14867: Process.wait can wait for MJIT compiler process
- [email protected] wrote:
> @normalperson By the way, is there any plan to apply
> `rb_f_system`-like changes t... -
- @normalperson By the way, is there any plan to apply `rb_f_system`-like changes to `rb_f_spawn` as well? Many of "1. ...
-
- > I'm testing this patch for ccan/list in rb_mjit_unit:
> https://80x24.org/spew/[email protected]/... -
- > Howeever, I think I found an old bug. Accessing unit->iseq->body outside of critical section seems wrong and I hit ...
-
04:00 AM Bug #14867: Process.wait can wait for MJIT compiler process
- @normalperson
r65437 passed.
> very odd, it's breaking in bigdecimal which isn't affected by any changes in int... -
- > compact_units list is useless and you have no plans for it right?
Oh, it's intended to be "List of compacted so ... -
- > I am going to move more data into rb_mjit_unit struct for state
> management using callbacks and events. It look... -
- [email protected] wrote:
> Congrats, while mswinci's vc12-x64 is not finished yet, r65437
> at least worked on... -
- Congrats, while mswinci's vc12-x64 is not finished yet, r65437 at least worked on AppVeyor CI (mswin, mingw). That se...
-
- > *sigh* reverted r65434
> None of these errors seem related, even
> http://mswinci.japaneast.cloudapp.azure.com/v... -
- > > I normally just build mingw, so I'm not testing the mswin/vc builds. I added the patch, and several build error...
-
11:43 PM Bug #15271 (Closed): Segfault (null pointer deref) in parse.y:1354
- Applied in changeset trunk|r65460.
----------
parse.y: last location from bison
* parse.y (command): set the last l... -
09:36 PM Bug #15271 (Closed): Segfault (null pointer deref) in parse.y:1354
- Reproducer and crash:
~~~
jtruba@dev118:~/rubies/ruby-trunk$ ./ruby -e 'a **{}'
./ruby: [BUG] Segmentation fault a... -
- * parse.y (command): set the last location from the location
managed by bison, so that other nodes are not needed.
... -
- I could collect 2 test failure information:
https://app.wercker.com/ruby/ruby/runs/test-mjit-wait/5bd8a253191eda00065... -
10:55 PM Revision 35796756 (git): fix type.
- * internal.h (RHASH_ARRAY_SIZE_RAW): should be `int` because
it returns n<=8.
* hash.c (RHASH_ARRAY_BOUND_RAW): di... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65457 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * string.c (rb_str_format_m): should pass `int`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65456 b2dd03c8-3... -
- Applied in changeset trunk|r65454.
----------
support theap for T_HASH. [Feature #14989]
* hash.c, internal.h: supp... -
- Do we have non-micro benchmark results for this? Maybe gcbench-rdoc on [Bug #14858] is the one?
> rails_ruby_bench... - 10:12 PM Revision d4f1187d (git): * remove trailing spaces, expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65455 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * hash.c, internal.h: support theap for small Hash.
Introduce RHASH_ARRAY (li_table) besides st_table and small Has... - 10:03 PM Revision ca83ed8d (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65453 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * struct.c: members memory can use theap.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65452 b2dd03c8-39d4-4d8... -
- * variable.c: now instance variable space has theap supports.
obj_ivar_heap_alloc() tries to acquire memory from th... - 09:54 PM Revision 43739223 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65450 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * transient_heap.c, transient_heap.h: implement TransientHeap (theap).
theap is designed for Ruby's object system. ... -
- Reproducer:
~~~
jtruba@dev118:~/rubies/ruby-trunk$ xxd ../repro5
00000000: 3c3c 7e30 270a 200a 3023 7b7d 0a30 ... -
09:19 PM Bug #15269: Process.setproctitle has odd behaviour on Mac OS X
- I will test on another language, e.g. Python and see if it works or not.
-
- It isn't ruby specific.
Seems like an issue of htop, it just does not update the info.
-
- On Mac OS X, using `Process.setproctitle` does seem to update when inspecting the process using `ps` but doesn't seem...
- 09:02 PM Revision 69b8ffcd (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65448 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65447 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * variable.c: now instance variable space has theap supports.
obj_ivar_heap_alloc() tries to acquire memory from th... -
- Applied in changeset trunk|r65444.
----------
introduce TransientHeap. [Bug #14858]
* transient_heap.c, transient_h... - 08:46 PM Revision f926f799 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65445 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * transient_heap.c, transient_heap.h: implement TransientHeap (theap).
theap is designed for Ruby's object system. ... - 06:26 PM Revision b51724aa (git): mjit.c (free_list): clear .length
- For robustness against future changes. There should be no impact
at the moment,here, but we may call mjit_finish more... -
04:16 PM Bug #15262: WeakRef::RefError for object that is still in use
- I agree, this appears to a be a bug in WeakRef. The Adder instance is not garbage collected, but you still get a `We...
-
03:08 PM Bug #15262: WeakRef::RefError for object that is still in use
- @nobu I updated the bug report, so that it should be more understandable now, what's going wrong.
-
- larskanis (Lars Kanis) wrote:
> > It waits just once.
>
> Yes, but the one event is sent after all 10 threads hav... - 03:39 PM Revision a5582e69 (git): * 2018-10-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65442 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I don't think we fixed that, but if so, I would like to see more test
failures. Previous failures didn't keep enough ... -
- because it's not supported by this file. Also, shared `def_iseq_ptr`
instead of copying the main definition of it.
v... -
02:50 PM Bug #15270: [PATCH] Fix TracePoint for code loaded using ISeq.load_from_binary
- Typos
-
- Hello. This is a patch for Bug #14702, which I don't think is fully addressed.
The tests in the patch should fail on... -
02:18 PM Feature #15230: RubyVM.resolve_feature_path
- If it's reliable enough (I think it is) to detect native extensions by the file extension (.so, .dylib)
then I think... -
02:00 PM Feature #15230: RubyVM.resolve_feature_path
- `:r` means `.rb` and `:s` means `.so`, I guess :-)
It is not absolutely necessary. But it would be somewhat usefu... -
- What's the leading one letter Symbol in the return value?
That seems fairly cryptic.
Do you need it? I would expe... -
- I think it's very bad style to modify the return value of #inspect, and some objects do already return frozen strings...
- 03:22 AM Revision fae6c6bf (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65439 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65438 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:34 AM Revision f7c0cc36 (git): process.c: implement rb_f_system without toggling ruby_nocldwait
- Following how mjit_worker.c currently works, rb_f_system
now ensures the VM-wide waitpid lists is locked before
creat... - 01:12 AM Revision fbee3b8f (git): revert r65434
- http://mswinci.japaneast.cloudapp.azure.com/vc12-x64/ruby-trunk/log/20181030T003541Z.fail.html.gz
I have no chance of... -
12:47 AM Feature #15236: add support for hash shorthand
- janfri (Jan Friedrich) wrote:
> I think the use of destructuring for this is much more Rubyish than the ES6 syntax.
...
10/29/2018
- 11:52 PM Revision 76f08cec (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65435 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:52 PM Revision 8227c91d (git): process.c: implement rb_f_system without toggling ruby_nocldwait
- Following how mjit_worker.c currently works, rb_f_system
now ensures the VM-wide waitpid lists is locked before
creat... -
- [email protected] wrote:
> normalperson (Eric Wong) wrote:
>
> > Greg: everything should be confined to *nix ... -
- normalperson (Eric Wong) wrote:
> Greg: everything should be confined to *nix for now, but can you
> make sure ... -
- Today I took a deeper look at how rb_waitpid is currently working. After reading that, while I couldn't exactly figur...
-
- [email protected] wrote:
> > Ah, so the waitpid from #system is on /bin/rm (I missed that earlier)
>
> For ... -
- > The other thing is MJIT multi-threading/synchronization seems tricky-to-debug right now, and making it event-based ...
-
- [email protected] wrote:
> Issue #14867 has been updated by k0kubun (Takashi Kokubun).
>
> > I think we'll h... -
- * vm_eval.c (local_var_list_init): use `rb_hash_new_compare_by_id()`
directly instead of manipulating st_table.
g... - 06:00 PM Revision 90a97887 (git): * 2018-10-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65432 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:00 PM Revision 708142ca (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65431 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * class.c (rb_keyword_error_new): use RARRAY_AREF() because
RARRAY_CONST_PTR() can introduce additional overhead in... -
03:38 PM Bug #15268 (Closed): Solarisでtest/drb/test_drbssl.rbが落ちる
- 他のテストの結果が隠れてしまうので今は skip しているのですが、Solaris で test/drb/test_drbssl.rb が落ちます。
ほぼ同じような TCPSocket 直接と UNIXSocket では落ちてい... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65429 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:08 PM Feature #15261: Expose rl_variable_value as Readline.variable_value
- I would recommend to you, if you would like to, to add your request to the next
developer meeting at:
https://bug... -
- > It waits just once.
Yes, but the one event is sent after all 10 threads have been called, so that `@count` is de... -
- larskanis (Lars Kanis) wrote:
> It does: `initialize` waits for all threads to have called `Adder#add` at the last l... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65428 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:40 AM Misc #15265: Documentation for `Object#instance_variable_set` is inaccurate and pejorative
- mame (Yusuke Endoh) wrote:
> Indeed, it looks a very subjective view of the author (Dave Thomas). Though, I can't u... -
- Indeed, it looks a very subjective view of the author (Dave Thomas). Though, I can't understand its subtlety because...
-
- Related to #15224, I found the case `File.basename(name, '.*')+File.extname(name) == File.basename(name)` is not true...
-
- Merged https://github.com/ruby/rdoc/pull/660
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65427 b2dd03c8-39d4-4... -
- If `File.extname("..jpg")` returns `".jpg"`, `File.basename("..jpg", ".*")` should return `"."` without that part, to...
-
03:21 AM Revision c80f3f70 (git): less verbose code by sharing attribute definitions
- The idea behind this commit is that handles_sp and leaf are two
concepts that are not mutually independent. By makin... -
- This enhances stability of the generated source code (namely
insns_info.inc) across attribute insertion / deletion. ...
10/28/2018
-
- Hello. I don't think this issue is fully fixed.
I have put together a patch that has a fix and tests that fail on bo... -
05:03 PM Revision 437dd881 (git): Revert "Add test for cause on pty"
- This reverts commit r65422.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65424 b2dd03c8-39d4-4d8f-98ff-823fe69b... - 04:06 PM Revision 13cde0a1 (git): * 2018-10-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65423 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65422 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:50 PM Bug #14678: Segmentation fault in pg
- Yes. I'm not sure but they are binary incompatible.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65421 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * time.c (tm_initialize): allow 7th argument as well as
Time#initialize, but just ignore.
git-svn-id: svn+ssh://ci... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65419 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Here're my plans.
> ## timezone argument to `Time.at`
>
> `Time.at` already has the fraction second and its uni... -
- Thanks @nobu for looking at the issue!
> This method doesn't wait these threads which run start_adder.
It does:... -
- larskanis (Lars Kanis) wrote:
> Although `start_adder` works with a `WeakRef`, the `Adder` object should still be GC... -
- `p`を何も表示されないということは通常ないのですが、`sock`や`client_addrinfo`はどうなっているでしょうか。
また、「問題なく表示」されるコードはどのようなものでしょうか。 -
- Yes I agree. That phrasing is not necessary.
There is more than one way to do many things in ruby. A good example ... -
04:11 AM Misc #15265 (Closed): Documentation for `Object#instance_variable_set` is inaccurate and pejorative
- The v2.5.1 documentation for this method states, in part, "Sets the instance variable named by symbol to the given ob...
-
10:49 AM Bug #15264 (Rejected): [PATCH] vm_trace.c (postponed_job_register): only hit main thread
- Duplicates with #15263
-
09:13 AM Bug #13930: Exception is caught in rescue above ensure
- I think it's due to `compile_next()` and `add_ensure_iseq()`.
The following is a reduced script result.
```
$ ... -
09:10 AM Feature #14145: Proposal: Better Method#inspect
- guilhermereiscampos (Guilherme Reis Campos) wrote:
> zverok (Victor Shepelev) wrote:
> > ```ruby
> > # We can't ex... -
- ko1 (Koichi Sasada) wrote:
> I don't have strong opinions on your proposal, but source location information seems al... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65418 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > I think we'll have to support non-blocking/event-based waitpid in Windows for auto-fiber/Thread::Light, anyways. So...
-
- [email protected] wrote:
> > 2. Get rid of MJIT worker thread and rely on SIGCHLD + non-blocking waitpid. I don... -
- > I haven't looked at it in detail, but it adds extra synchronization overhead for a slightly more up-to-date cache, ...
-
- on msys2 because it sometimes crashes worker like
https://ci.appveyor.com/project/ruby/ruby/builds/19853558/job/8v1eh... -
07:19 AM Feature #15239: [patch] test-spec win32ole
- Thank you for your help. I prefer to use MSXML.Document for WIN32OLE_EVENT specs.
Because I think other (light and ... -
- @suke
I'd like to help. I just ran CI again on the branch I created the PR from, it passed in both Travis & Appve... -
- @k0kubun & @suke
When I did the patch, I saw no reason to have non Windows builds requiring the classes.rb file if... -
- Please look at the patch. It modifies several files. Removing the rescue block without patching the other files wil...
-
- @suke r65401 is breaking CI on Linux like https://gist.github.com/ko1/2c561f9185492f339cf7a763ea219e79, so the assump...
-
- * spec/ruby/library/win32ole/fixtures/classes.rb: remove rescue block
because this file is required when platform i... -
- * spec/ruby/library/win32ole/win32ole/ole_methods_spec.rb: refactoring.
remove Internet Explorer.
git-svn-id: svn+... -
- * spec/ruby/library/win32ole/fixtures/event.xml use MSXML.DOMDocument
instead of InternetExplorer.Application. Inte... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65413 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * spec/ruby/library/win32ole/win32ole_event/new_spec.rb: use
MSXML.DOMDocument. InternetExplorer.Application is not... -
- * compile.c (ibf_dump_object_hash): use `rb_hash_foreach()`
instead of using `st_foreach()`.
git-svn-id: svn+ssh:... -
- * spec/ruby/library/win32ole/win32ole/shared/setproperty.rb: use
Scripting.Dictionary. InternetExplorer.Application... -
- * spec/ruby/library/win32ole/win32ole/ole_put_methods_spec.rb: use
Scripting.Dictionary. InternetExplorer.Applicati... -
- * spec/ruby/library/win32ole/win32ole/ole_methods_spec.rb: use Scripting
Dictionary. InternetExplorer.Application i... -
- * spec/ruby/library/win32ole/win32ole/ole_obj_help_spec.rb: use
Scripting.Dictionary. InternetExplorer.Application ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65406 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * spec/ruby/library/win32ole/win32ole/ole_method_spec.rb: recuire in
platform_is block.
* spec/ruby/library/win32ol... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65404 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/rdoc/parser/c.rb (RDoc::Parser::C#deduplicate_call_seq):
skip dynamically added methods at runtime, because t... -
- Because it does break Linux CI like:
https://gist.github.com/ko1/2c561f9185492f339cf7a763ea219e79
git-svn-id: svn+ss... -
- * spec/ruby/library/win32ole/fixtures/classes.rb: remove rescue block
because this file is required on Windows only... -
- * spec/ruby/library/win32ole/win32ole/ole_func_methods_spec.rb: use
Scripting.Dictionary. InternetExplorer.Applicat...
10/27/2018
-
11:56 PM Feature #14145: Proposal: Better Method#inspect
- zverok (Victor Shepelev) wrote:
> ```ruby
> # We can't extract default values, but at least we can say they are the... -
- * spec/ruby/library/win32ole/invoke_spec.rb: use Scripting.Dictionary
instead of InternetExplorer.Application. Inte... -
- ```
vm_trace.c (postponed_job_register): only hit main thread
Since postponed_job_register may be called in a sig... -
- ```
vm_trace.c (postponed_job_register): only hit main thread
Since postponed_job_register may be called in a sig... -
- _getproperty spec.
* spec/ruby/library/win32ole/_getproperty_spec.rb: use
Scripting.Dictionary. InternetExplorer.A... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65397 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65396 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * spec/ruby/library/win32ole/fixtures/classes.rb: add
WIN32OLESpecs::MSXML_AVAILABLE
git-svn-id: svn+ssh://ci.ruby-l... - 09:45 PM Revision 1064376b (git): * 2018-10-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65394 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Print `cause` of the exception if the exception is not caught and printed
its backtraces and error message [Feature #... -
- [email protected] wrote:
> Thank you for your quick and detailed reply. For 1, I'll try
> to acquire GVL from ... -
- Thank you for your quick and detailed reply. For 1, I'll try to acquire GVL from MJIT worker thread to resolve this i...
-
- [email protected] wrote:
> In this case, 3 threads are blocking in:
>
> 1. `rb_thread_io_blocking_region` ca... -
- Recently we see 2 types of deadlocks on CI with --jit or --jit-wait.
## 1. waitpid on #system, #`, or Process.wait... -
- Given the following program:
```ruby
require "weakref"
Thread.abort_on_exception = true
class Adder
def ... -
03:10 PM Feature #15261 (Closed): Expose rl_variable_value as Readline.variable_value
- I would like to propose exponsing rl_variable_value as Readline.variable_value, it would be useful in pry.
Pull re... -
- from terminate_spec.rb, as suggested here:
https://github.com/ruby/ruby/commit/c7220bd3dea0a113b81f267cc3b656da7d7d7a... -
- Sounds good to me to use the MSXML object.
The patch looks good from a quick look. -
- suke (Masaki Suketa) wrote:
Thanks for looking at it. Apologies for not testing on Travis.
> I'm afraid your p... -
- Thank you for your patch. I'm reeding your patch now. And I'm afraid
your patch would be fail on environment except... -
- and move retry logic to internal method
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65391 b2dd03c8-39d4-4d8f-9... -
- * The 2.3 alias in RVM seems to resolve to 2.3.7.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65390 b2dd03c8-3... -
- to this spec as well, since the same issue was reproduced here
https://ci.appveyor.com/project/ruby/ruby/builds/19842... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65388 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65387 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It looks like mspec worker may immediately die on Linux as well.
https://travis-ci.org/ruby/ruby/jobs/447018758
Drop... -
- @knu Could you share your opinion?
I also wonder, why are these operations raising an error with non-Set arguments... -
- Hanmac (Hans Mackowiak) wrote:
> hm i especially hate such part of code:
>
> ~~~ ruby
> case
> when set.instanc... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65385 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:22 AM Revision b16d73ae (git): Update the example of local variable shadowing
- I came up with this snippet when we were trying to convince Matz.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... -
07:20 AM Feature #14136: Implement #empty? on more classes
- jeremyevans0 (Jeremy Evans) wrote:
> bozhidar (Bozhidar Batsov) wrote:
> > > Yeah, in this case I'd argue that it's... -
- which I tried to avoid skipping this in r65311, but the test seems not
working under some high load of ci.rvm.jp.
gi...
10/26/2018
-
08:30 PM Revision 8f0eb44d (git): string.c: improve docs for String#strip and related
- * string.c: [DOC] improve docs for String#{strip,lstrip,rstrip}{,!}:
small clarification, avoid referring to the re... - 05:08 PM Revision ab99fd06 (git): * 2018-10-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65381 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It disables cross-references to the classes/modules, even if those
are defined in other places. I suspect this is no... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65379 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65378 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65377 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65376 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- because it may silently die like
https://ci.appveyor.com/project/ruby/ruby/builds/19813015/job/a99c4hrs69g4iorg
and w... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65374 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:18 AM Revision ea9961f9 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65373 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65372 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > But I got some spec failures due to singleton class (below). I
> haven't investigated, yet, but I think there ma... -
- [email protected] wrote:
> I think so far it looks good, let me know if I did something wrong while running th... -
- Applied in changeset trunk|r65371.
----------
hash.c: aset deduplicates un-tainted string
We revisit [Bug #9188] si... - 05:32 AM Revision 1e83e15a (git): hash.c: aset deduplicates un-tainted string
- We revisit [Bug #9188] since st.c is much improved since then,
and benchmarks against so_k_nucleotide seem to indicat... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65370 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- You can now write the following without warning.
user = User.all.find {|user| cond(user) }
Fixes [Feature #1249... -
- I forgot to add the copyright of the patch...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65368 b2dd03c8-39d4-... -
- Applied in changeset trunk|r65367.
----------
parse.y: remove "shadowing outer local variable" warning
You can now ... -
- You can now write the following without warning.
user = User.all.find {|user| cond(user) }
Fixes [Feature #12490]... - 01:47 AM Revision df38879a (git): * 2018-10-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65366 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65365 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/25/2018
-
10:43 PM Bug #15255 (Rejected): Change in protected handling 2.3 -> 2.4,2.5
- It looks like when moving to 2.4 and higher, the access to protected method has changed. In the following case:
~~... -
09:56 PM Bug #15254 (Rejected): Array#slice should not treat the index past the last element as a special case
- This is per spec.
Here's one way to see the start indices:
```
[ :a, :b, :c ]
# ^ ^ ^ ^
# ... -
09:44 PM Bug #15254 (Rejected): Array#slice should not treat the index past the last element as a special case
- Array#slice should not treat the index past the last element as a special case. This causes Array#slice(start, length...
-
01:11 PM Bug #15253 (Closed): Arduinoとの接続においてSocket.tcp_server_loop中で$stderr.puts、pなどが使用できない
- サーバーにおいて以下のコードを動かしています。
```ruby
require 'socket'
Socket.tcp_server_loop("", 49088) {|sock, client_addrinfo|
... -
10:50 AM Misc #15202: Adding Coverity Scan to CI to see the result casually
- > Instead of that, It looks good to me that someone could see the result of coverity scan casually anytime to fix tho...
-
- > Let me close this now. Thank you for the report!
Yeah, thank you for closing. I saw the updated .travis.yaml.
o... -
- Let me close this now. Thank you for the report!
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65364 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:05 AM Feature #15251: Hash aset should deduplicate non tainted string
- @normalperson I also benchmarked so_k_nucleotide mentioned in https://bugs.ruby-lang.org/issues/9188 with following c...
-
- as failing
https://app.wercker.com/ruby/ruby/runs/test-mjit-wait/5bd092a89b1e440006d5780d?step=5bd092e3591ca800072584... -
- * debug_counter.h: add `gc_major_oldmalloc`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65362 b2dd03c8-39d4-... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65361 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * time.c (time_localtime): check if `vtm.zone` is a simple zone
name string before trying to call the conversion me...
10/24/2018
-
- * debug_counter.h: add new debug counters to count GC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65359 b2dd... -
- [email protected] wrote:
> https://bugs.ruby-lang.org/issues/15251
> I'm not sure if current behavior is ex... -
- I'm not sure if current behavior is expected one or a bug. So feel free to change tracker type.
Currently Hash ASE... -
07:12 PM Bug #15252 (Closed): hitting what seems like a gc segfault at random
- I apologize as I don't have a reproducible test case but I'm hoping by sharing the trace that others may be able to c...
-
- test-all2 is taking much longer time than test-all1 now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65358 b2d... - 03:41 PM Revision d82a7612 (git): * 2018-10-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65357 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I assumed somehow this check was not needed, but it did need.
By canceling this instead of just warning here, we didn... -
- This seems to have been fixed in r65190.
~~~
$ ./ruby --version
ruby 2.6.0dev (2018-10-24 trunk 65355) [x86_64-l... -
- nobu (Nobuyoshi Nakada) wrote:
> Maybe fixed by r65190?
Yes, looks fixed.
~~~
$ ASAN_OPTIONS=detect_leaks=0 .... -
- Maybe fixed by r65190?
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65355 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:05 PM Bug #15250 (Closed): Concurrent fibers segfault when thread caching is disabled
- ~~~ ruby
500.times do
Array.new(200) { |n|
Thread.new {
Fiber.new {
readable = open(__FILE__... -
- As Wercker is managing workflow by GUI, the commit had no impact for
behavior... I already fixed the workflow on GUI.... -
- to reduce time taken for finishing all jobs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65353 b2dd03c8-39d4-4... - 12:13 PM Revision 789244e1 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65352 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- which are under investigation. I'm debugging it right now, but let's
make it green to stop bothering other developmen... -
- Yes, 2.4 is ok but 2.5 crashes.
```
$ ruby2.4 -v -e 'i = 0; %w(1) || 2 while (i += 1) < 100; p i'
ruby 2.4.5p335... -
11:48 AM Bug #15245: Heap buffer overflow (write of size 8) in vm.inc
- I think r59892 introduce this bug. I'll fill Backport field according to the changeset timing. I didn't confirm it's ...
-
- Applied in changeset trunk|r65350.
----------
compile.c: fix peephole optimization
* compile.c (iseq_peephole_optim... -
- Applied in changeset trunk|r65350.
----------
compile.c: fix peephole optimization
* compile.c (iseq_peephole_optim... -
- I guess this is as same as #15245.
```
$ echo -n "2557 0024 7f54 0020 7c7c 6e54 5a20 7768 696c 6523 4054 456d 652... -
- * compile.c (iseq_peephole_optimize): should `pop` before jump
instruction which succeeds to `newarray` of a litera... - 10:29 AM Revision cd0181dd (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65349 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- for now. It's randomly failing on test-mjit-wait.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65348 b2dd03c8-3... -
- TestParallel in test/testunit/... seems to be slow. Let's see if this
contributes to loosen timeout or not.
git-svn-... -
- It randomly failed.
https://app.wercker.com/ruby/ruby/runs/test-mjit-wait/5bcfd19aa9806e000655c598?step=5bcfd1d5acc45... -
- * insns.def (newhashfromarray): `rb_hash_bulk_insert()` can call
Ruby methods like #hash so that it should not be a... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65344 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * insns.def (newhashfromarray): added to replace `core_hash_from_ary`
method to eliminate method call overhead.
...
Also available in: Atom