Activity
From 11/02/2018 to 11/08/2018
11/08/2018
-
11:04 PM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
- @normalperson Eric,
Sorry for the delay. The patch passed. I applied it to r65635...
-
03:43 AM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
- [email protected] wrote:
> Yes. Below is a summary of all builds from r64892 2018-10-01 thru r65558, except TestJIT. I assume TestIO & TestThread are the only tests possibly affected by anything you're working on...
>
> Since th... -
02:24 PM Feature #15289: Accept "target" keyword on `TracePoint#enable`
- Sounds nice. Please do not forget documentation when/if approved/added. :)
I have no particular opinion on the API/name(s) as such, but I would recommend
to try to keep it simple and "logical" if possible. A Hash would probably make
... -
12:37 PM Bug #15290: load_from_binary Bus error on Solaris sparc
- I am not able to apply all these patches right now, but I managed to build latest Ruby 2.6.0 preview 3 and this issue is not there so it might be fixed.
It is however a little bit weird that this issue appeared with version 2.5.3 and ... -
08:46 AM Bug #15290: load_from_binary Bus error on Solaris sparc
- In addition to the above, r63118, r63119, and r63120 are needed.
-
09:52 AM Revision e3cfb1f3 (git): st.c: bin might be zero
- When EMPTY_OR_DELETED_BIN_P(bin) is true, it is a wrong idea to
subtract ENTRY_BASE from it. Delay doing so until we are sure to be
safe.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65635 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:46 AM Revision e226772a (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65634 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:46 AM Revision 39725a4d (git): gc.c: avoid integer overflow at process exit
- This is rather nitpicking but at the moment the process terminates,
heap_pages_final_slots overflows.
(lldb) bt
* thread #1: tid = 0xc0903, 0x00000001002b3bf7 miniruby`finalize_list(objspace=0x0000000101c09240, zombie=4329149840) + 999 ... -
07:42 AM Bug #595: Fiber ignores ensure clause
- > Eric Wong wrote:
> > It will be difficult/unsafe to use auto-fiber/Thread::Coro
> > [Feature #13618] without this
>
> I think I can get around this by making iom a GC root,
> so all auto-yielded Fibers get marked.
Btw, I work... -
07:41 AM Revision 3483e6da (git): hash.c: +(-1) is a wrong idea
- Before this changeset RHASH_ARRAY_SIZE_DEC() was expaneded to include
an expression like `RHASH_ARRAY_SIZE+(-1)`. RHASH_ARRAY_SIZE is by
definition unsigned int. -1 is signed, of course. Adding a signed
and an unsigned value requires ... -
06:35 AM Bug #15291 (Assigned): ruby-2.6.0-preview3でbin/bundle_rubyがインストールされる
- `bundle_ruby` が無いと落ちるテストがあったので port してましたが、リリースまでにはテストと一緒に消しておこうと思います。
-
06:26 AM Revision 42274ff5 (git): vm_core.h: conform C90
- https://travis-ci.org/ruby/ruby/jobs/452230859
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65631 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:22 AM Revision 7cc97cfe (git): avoid (size_t)-- (2nd try)
- The decrements overflow and these variables remain ~0 when leaving the
while loops. They are not fatal by accident, but better replace with
ordinal for loops.
See also: https://travis-ci.org/ruby/ruby/jobs/452218871#L3246
git-svn-id:... -
06:19 AM Revision c68d1c92 (git): lib/rubygems/indexer.rb: suppress random test-all error
- by bundler. Similar to r65613, but fixing this more carefully
because here is not just inside tests but inside rubygems code.
http://ci.rvm.jp/results/trunk_gcc5@silicon-docker/1448239
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6... -
05:35 AM Bug #15288 (Closed): RUBY_DEBUG=gc_stress dumps core
- Applied in changeset trunk|r65628.
----------
initialize VM postponed_job first. [Bug #15288]
* inits.c: call `Init_vm_postponed_job` first because
postponed_job is used by transient heap. -
05:35 AM Revision 8634e62a (git): initialize VM postponed_job first. [Bug #15288]
- * inits.c: call `Init_vm_postponed_job` first because
postponed_job is used by transient heap.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65628 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:34 AM Revision a74d08b9 (git): svn merge -r 65625:65623 .
- Was breaking make test-all
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65627 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:34 AM Revision 7b9dd379 (git): .travis.yml: simplify travis matrix description
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65626 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:24 AM Revision 28997227 (git): st.c: fix comparison between signed and unsigned
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65625 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:06 AM Revision 24fff750 (git): avoid (size_t)--
- The decrements overflow and these variables remain ~0 when leaving the
while loops. They are not fatal by accident, but better replace with
ordinal for loops.
See also: https://travis-ci.org/ruby/ruby/jobs/452218871#L3246
git-svn-id:... - 05:01 AM Revision f4a2170e (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65623 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:01 AM Revision 26081169 (git): separate Thread type (func or proc) explicitly.
- * vm_core.h (rb_thread_struct): introduce new fields `invoke_type`
and `invoke_arg`.
There are two types threads: invoking proc (normal Ruby thread
created by `Thread.new do ... end`) and invoking func, created
by C-API. `invoke_... -
04:24 AM Revision 96af6823 (git): st.c: straight-forward comparison of characters
- These functions are used in strcasehash, which is used to store encoding
names. Encoding names often include hyphens (e.g. "UTF-8"), and
` '-' - 'A' ` is negative (cannot express in unsigned int).
Don't be tricky, just do what to do.
... -
04:06 AM Revision 3f1524f0 (git): test_ftp.rb: extend timeout for --jit-wait testing
- to avoid random failures like
https://app.wercker.com/ruby/ruby/runs/mjit-test1/5be394b818310600284f2b50?step=5be394f1591ca800079b1329
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65620 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:27 AM Revision 86dca76e (git): ext/socket/init.c (wait_connectable): bail out early on some errors
- This becomes necesary if sockets become non-blocking by
default <https://bugs.ruby-lang.org/issues/14968>; but it's
always been possible to make sockets non-blocking anyways.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65619 b2dd0... -
02:25 AM Revision 17e9667f (git): refine parse_rat
- * rational.c (read_num): return the exponent instead of the
divisor, to get rid of huge bignums.
* rational.c (parse_rat): subtract exponents instead of reduction
of powers.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65618 b... -
01:57 AM Revision dcfb7f6d (git): compile.c: compile error than rb_bug [ci skip]
- * compile.c (get_local_var_idx, get_dyna_var_idx): raise a compile
error which is useful than rb_bug, when ID is not found.
* compile.c (iseq_set_sequence): ditto when IC index overflow,
with dumping generated code.
git-svn-id: svn... -
01:43 AM Revision 96c26fbb (git): st.c: suppress integer overlow warnings
- This `i += h;` overflows. Don't know the intention of the
operation, so just suppress UBSAN.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65616 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:36 AM Revision 3038bc31 (git): NEWS: Add `RubyVM::AST.of` to NEWS [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65615 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:12 AM Revision 7d3e758a (git): compile.c: unreachable than rb_bug [ci skip]
- * compile.c (iseq_calc_param_size): use UNREACHABLE than rb_bug,
at where never reachable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65614 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:06 AM Revision e6c4d558 (git): test/rdoc/minitest_helper.rb: suppress bundler error
- maybe after bundler introduction to this repository, we randomly hit
errors like:
http://ci.rvm.jp/results/trunk-gc-asserts@silicon-docker/1447918
As we would require minitest in this repository anyway, it should be
fine to suppress the...
11/07/2018
-
07:25 PM Bug #15270: [PATCH] Fix TracePoint for code loaded using ISeq.load_from_binary
- @ko1 can you mark this issue to be backported to 2.5.x please?
-
05:18 PM Revision 5ea27174 (git): Following up r65583. Removed VCR files when retrieving code from upstream.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65612 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:51 PM Revision 9b7d8947 (git): Clear CC_WRAPPER in other than the toplevel
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65611 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:23 PM Bug #15290: load_from_binary Bus error on Solaris sparc
- The bus error occurs in compile.c line 8883, in function ibf_load_object_string().
It seems that this bug is already fixed in the trunk by commits r62791, r62796, r63098(?), r63101(?), r63113, r63117, r63167, r63368, and r63413(?).
-
11:26 AM Bug #15290 (Closed): load_from_binary Bus error on Solaris sparc
- When we updated to recently released version 2.5.3, one test on sparc started to fail:
~~~
/.../ruby-25/ruby-2.5.3/test/ruby/test_iseq.rb:403: [BUG] Bus Error at 0x000000010d1de3ec
ruby 2.5.3p105 (2018-10-18 revision 65156) [sparcv9... -
04:12 PM Feature #11527 (Assigned): IPAddr#mask_addr isn't a method
-
04:00 PM Feature #6946: FIPS support?
- @rhenium I think we can close this ticket.
Thanks for reminding us.
I do not see the issue on the fips mode.
I could pass the tests of trunk ruby with openssl 1.0.2 fips mode.
Right now the OpenSSL 1.1.1 does not support the buildi... -
03:55 PM Feature #14109 (Closed): FileUtils: Use Dir.children instead of Dir.entries
- Applied in changeset trunk|r65610.
----------
Dir.children is available since Feature #11302. FileUtils uses
Dir.each on an internal method encapsulated on a private class
`Entry_#entry`, having no '.' neither '..' entries would make
no... -
03:55 PM Revision 37c08fad (git): Dir.children is available since Feature #11302. FileUtils uses
- Dir.each on an internal method encapsulated on a private class
`Entry_#entry`, having no '.' neither '..' entries would make
now superfluous a chained reject filtering.
This change can improve the performance of these FileUtils
methods ... - 03:47 PM Revision 8c56aa51 (git): * 2018-11-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65609 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:47 PM Revision 852ddf18 (git): Expand MJIT_CC on mswin too
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65608 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:44 PM Bug #15291 (Closed): ruby-2.6.0-preview3でbin/bundle_rubyがインストールされる
- ruby-2.6.0-preview3を試していたところ、bin/以下に"bundle_ruby"というファイルがありました。
bundler由来のもののようですが、これは意図されたものでしょうか?
`gem install bundler`でインストールしたときには"bundle_ruby"は作成されないようです。
~~~
% gem install bundler
:
% gem spec bundler version
--- !ruby... -
02:27 PM Revision 61eaa5e3 (git): Convert MJIT_CC to Windows path on msys too
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65607 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:48 PM Revision fc14c408 (git): * expand tabs. [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65606 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:48 PM Revision d99d8cc8 (git): Add cast to suppress warnings on Solaris [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65605 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:06 PM Bug #15206: require_relative in std_lib
- I revert examples in comment and replace numeric features too at r65548.
-
11:38 AM Revision adb723bc (git): `+` sign in the path of ruby needs to be escaped
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65604 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:55 AM Revision 9e618397 (git): Generalize r65594
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65603 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:55 AM Revision f84577ba (git): clean mjit_build_dir.dylib.dSYM directory on macOS
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65602 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:03 AM Bug #15285: lambda return behavior regression from #14639
- ea15ceddbef2cc4c459c1ad5796e43ae9fa2cbf1 is r64996, which is a backport of r63030, which fixes #14639.
@nobu any idea? -
08:51 AM Feature #15289 (Closed): Accept "target" keyword on `TracePoint#enable`
- # Abstract
To enable TracePoint for specific location, I propose new keyword argument `target:` to `TracePoint#enable` for specific events (`line`, `call`, `return`, `class`, `end`).
Usage:
```ruby
line_trace = TracePoint.new(:... -
08:35 AM Feature #14145: Proposal: Better Method#inspect
- Good point. I can't think of a good solution to that that would not involve substantial work.
nobu (Nobuyoshi Nakada) wrote:
> Ruby's default argument is not so simple as you think.
> ...
-
07:06 AM Feature #14145: Proposal: Better Method#inspect
- Ruby's default argument is not so simple as you think.
Where `foo` is defined as
```ruby
def foo(a, b = a.bar) end
```
from where should `method(:foo).default_values[:b]` refer `a`?
-
08:19 AM Bug #15288 (Closed): RUBY_DEBUG=gc_stress dumps core
- ```
zsh % RUBY_DEBUG=gc_stress lldb -- ./miniruby -vep
(lldb) target create "./miniruby"
Current executable set to './miniruby' (x86_64).
(lldb) settings set -- target.run-args "-vep"
(lldb) run
Process 7103 launched: './miniruby'... -
08:15 AM Feature #15287: New TracePoint events to support loading features
- I love introspection, so .. \o/
-
05:19 AM Feature #15287 (Closed): New TracePoint events to support loading features
- # Abstract
I propose the following new TracePoint events:
* `loaded` (invoked after `require`/`load`)
* `method_added` (invoked after method definition)
# Background
Sometimes we need to hook loading iseq. For example, check... - 08:13 AM Revision ebf58990 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65601 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:13 AM Revision b06649b9 (git): Rename get/setinlinecache to opt_get/opt_setinlinecache
- The instructions are just for optimization. To clarity the intention,
this change adds the prefix "opt_", like "opt_case_dispatch".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65600 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:04 AM Revision c8cfd78b (git): mjit_worker.c: stop expanding already-absolute MJIT_CC
- r65577 seems to have made MJIT_CC (MJIT_CC_COMMONA) become an absolute
path. So start_process doesn't need to find that from PATH by dln_find_exe_r.
This commit is motivated by the msys2 AppVeyor CI failure:
https://ci.appveyor.com/proj... -
08:04 AM Revision 3f6a4be3 (git): vm_backtrace.c: pos can be zero
- (lldb) target create "./miniruby"
Current executable set to './miniruby' (x86_64).
(lldb) settings set -- target.run-args "-e0"
(lldb) run
Process 97005 launched: './miniruby' (x86_64)
./miniruby(rb_print_backtrace+0x15) [0x10024f7d5] v... -
08:03 AM Revision 0f36bc09 (git): insns.def: forgot add cast [ci skip]
- See r65595
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65597 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:21 AM Revision 76566bfd (git): ruby-runner.c: enable MJIT_SEARCH_BUILD_DIR only if no relative loading
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65596 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:16 AM Revision 48649e46 (git): insns.def: avoid integer overflow
- In these expressions `1` is of type `signed int` (cf: ISO/IEC
9899:1990 section 6.1.3.2). The variable (e.g. `num`) is of type
`rb_num_t`, which is in fact `unsigned long`. These two expressions
then exercises the "usual arithmetic conv... -
07:15 AM Revision ecbd0d79 (git): test_process.rb: avoid test failure by r65588
- on macOS.
https://travis-ci.org/ruby/ruby/jobs/451709313
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65594 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:26 AM Revision 391811c1 (git): .travis.yml: UNALIGNED_WORD_ACCESS=0 for UBSAN
- Unaligned word access warnings generated by UBSAN are often
treated well already, depending on this macro.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65593 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:23 AM Revision 74fe1cc3 (git): string.c: this assumption is false [ci skip]
- Looking at the lines right above, it is clear than a blue sky
that we cannot assume `p` to be aligned at all when
UNALIGNED_WORD_ACCESS is true. It is a wrong idea to use
__builtin_assume_aligned for that situation.
See also: https://t... -
05:07 AM Revision 4d3c254e (git): Fix call-seq [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65591 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:56 AM Revision 9722ed0e (git): suppress GCC warning about unknown sanitizers
- See also: https://travis-ci.org/ruby/ruby/jobs/451710726#L1941
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65590 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:22 AM Feature #15286: Proposal: Add Kernel.#expand(*args)
- Thanks for comment, shevegen.
`Kernel.#expand` can be used as follows.
```ruby
names = [:a, :b, :meth]
# expand(:a, :b, :meth)
expand(*names)
# => {:a=>1, :b=>2, :meth=>"meth"}
# ???
{ *names }
```
-
12:33 AM Feature #15286: Proposal: Add Kernel.#expand(*args)
- I think one possible question in regards to the suggestion here is whether the above method may be useful
on its own, even without a shorthand syntax for Hash. (This is really just a question; I personally am
not having any strong pro/... -
04:19 AM Misc #15229: DevelopersMeeting20181122Japan
- * [Feature #15286] Proposal: Add Kernel.#expand(*args)
-
04:09 AM Revision 234ffbce (git): blacklist UBSAN's unsigned integer overflow
- Integer overflow for unsigned types are fully defined in C. They
are not always problematic (but not always OK). These functions
in this changeset intentionally utilizes that behaviour.
Blacklist from UBSAN checks for better output.
Se... -
04:02 AM Revision c818b2fc (git): ruby-runner.c: enable MJIT_SEARCH_BUILD_DIR
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65588 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:49 AM Revision f837601c (git): mjit_build_dir: separate MJIT_BUILD_DIR
- * Makefile.in (mjit_build_dir.so): separate MJIT_BUILD_DIR to
eliminate the feature for test-all after installation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65587 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/06/2018
-
11:50 PM Revision 92e9f615 (git): Fix build_os:host_os pair
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65586 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:36 PM Feature #14145: Proposal: Better Method#inspect
- It may be possible to procify the arguments to self-contain them without really disturbing their integrity. `method(:name)` already returns a proc, so would it be wholly unexpected that the arguments may do the same?
Thinking out loud... -
11:18 PM Feature #15286 (Rejected): Proposal: Add Kernel.#expand(*args)
- This is a suggestion for Hash shorthand.
* [add support for hash shorthand](https://bugs.ruby-lang.org/issues/15236)
`Kernel.#expand(*args)` is expand `local variable` and `method` to Hash.
`*args` is method or local variable names.... - 10:56 PM Revision ca2e5225 (git): * 2018-11-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65585 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:55 PM Revision 9c40a954 (git): Revert "thread.c (rb_wait_for_single_fd): no point initializing pollfd.revents"
- It may cause an access to uninitialized variables.
The call to ppoll will set the `revents` field, but ppoll is not always
called because it is in the guard `!RUBY_VM_INTERRUPTED(th->ec)`.
This issue was found by Coverity Scan.
git-svn-... -
09:20 PM Bug #15285 (Closed): lambda return behavior regression from #14639
- The change in ea15ceddbef2cc4c459c1ad5796e43ae9fa2cbf1 to use rb_yield_force_blockarg changes the behavior of returns called inside a passed lambda function. In 2.5.1 and below, including before the enum.c change, the attached script wo...
-
08:47 PM Revision e6bf368c (git): Removed VCR cassettes files for reducing package size.
- [Bug #14219]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65583 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:35 PM Feature #15281: Speed up Set#intersect with size check.
- > we can do that as Sets are ordered
IMO if they are, it's an implementation detail that you shouldn't rely on. Also there's more room to optimize unordered sets.
if you need an ordered (or indexed?) set, it should be a subclass th... -
04:51 PM Bug #13999 (Assigned): Cygwin 環境で ripper_state_lex.rb がコアダンプする
-
03:52 PM Bug #15282: Segfault (null pointer dereference) in variable.c iv_index_tbl_make
- ruby_2_5 r65582 merged revision(s) 65554.
-
03:52 PM Feature #8781 (Closed): Use require_relative() instead of require() if possible
-
03:52 PM Revision 783f1b29 (git): merge revision(s) 65554: [Backport #15282]
- Don't set throw data as cause [Bug #15282]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@65582 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:48 PM Bug #15268: Solarisでtest/drb/test_drbssl.rbが落ちる
- これrubyciのLinux Armv7でも同様の問題が出ていたので、Solaris依存ではない気もしています
-
03:31 PM Bug #15271: Segfault (null pointer deref) in parse.y:1354
- ruby_2_5 r65581 merged revision(s) 65460.
-
03:31 PM Revision 218ac97b (git): merge revision(s) 65460: [Backport #15271]
- parse.y: last location from bison
* parse.y (command): set the last location from the location
managed by bison, so that other nodes are not needed.
[ruby-core:89648] [Bug #15271]
git-svn-id: svn+ssh://ci.ru... -
03:28 PM Bug #15206: require_relative in std_lib
- Oh, good catch, I should have thought of that...
I modified my script to check if the path with .rb actually exists and it came back with only these two exceptions. -
03:13 PM Bug #15245: Heap buffer overflow (write of size 8) in vm.inc
- ruby_2_5 r65580 merged revision(s) 65350.
-
03:13 PM Revision 75600918 (git): merge revision(s) 65350: [Backport #15245]
- compile.c: fix peephole optimization
* compile.c (iseq_peephole_optimize): should `pop` before jump
instruction which succeeds to `newarray` of a literal object,
not after. [ruby-core:89536] [Bug #15245]
gi... -
02:50 PM Bug #15087: Segmentation fault with splat and block
- ruby_2_5 r65579 merged revision(s) 64786.
-
02:49 PM Revision a2d9317d (git): merge revision(s) 64786: [Backport #15087]
- parse.y: fix block passing with empty kwargs
* parse.y (arg_blk_pass): preceeding arguments node may be NULL when
an empty keyword argument hash splat is optimized away.
[ruby-core:88890] [Bug #15087]
git-sv... -
02:33 PM Feature #4475: default variable name for parameter
- shevegen (Robert A. Heiler) wrote:
> The first variant, aka the variant with "x", or any other single letter, including
> ...
"_" is special there. it doesn't cause Syntax Error
like you can do this `iterator.each {|a, _, c, _| }`
bu... -
02:15 PM Feature #4475: default variable name for parameter
- I also like the idea in principle, largely because I can relate to the idea. I encounter
this every now and then when writing ruby code, in that I want a simple way to access
a concept or argument.
For example, consider ruby code l... -
12:08 PM Revision 78bf275c (git): Expand MJIT_CC in configure
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65577 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:53 AM Revision bb2ee549 (git): workaround C++ism in ASAN header
- See also: https://travis-ci.org/ruby/ruby/jobs/451299690
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65576 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:19 AM Revision 3f97d88a (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65575 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:19 AM Revision 5fcc43e2 (git): cont.c: direct use of rb_thread_t
- The only usage of rb_fiber_reset_root_local_storage() is from
ruby_vm_destruct(), where the object space is already terminated.
This `th->self` is not alive. Why not just use `th` itself.
See also: https://travis-ci.org/ruby/ruby/jobs/... -
10:06 AM Revision 4a80c054 (git): adopt sanitizer API
- These APIs are much like <valgrind/memcheck.h>. Use them to
fine-grain annotate the usage of our memory.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65573 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:54 AM Bug #15284 (Closed): Unintentional warnings with node.h
- Recently, I got the following warnings with build time.
```
parse.c:4720:14: warning: incompatible pointer types passing 'FILE *' (aka 'struct __sFILE *') to parameter of type 'struct parser_params *' [-Wincompatible-pointer-types]
... -
08:01 AM Revision dbd90b2d (git): mjit.c: don't use mutex before checking availability
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65572 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:45 AM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
- > Does that seem reasonable as a unit of work to you?
Perfect!
Note that we will release ruby 2.6 in Dec. If you finish (3) "Possibly rb_memerror...", it is easy to introduce. We can continue further improvement on next release. -
07:30 AM Revision 6c201476 (git): mjit_worker.c: don't use _one for now
- I'm planning to use _one later, but it may be doubly registered by
switching `stop_worker_p` now and so we should not use _one for now.
Otherwise stale job may reject new job registration and
copy_cache_from_main_thread may wait forever... -
07:28 AM Revision e0a35586 (git): Makefile.in: do not expand MJIT_CC if cross compiling
- * Makefile.in (mjit_config.h): expand MJIT_CC only if native
build, the path on cross compiling host is useless.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65570 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:22 AM Revision 7a2263fb (git): mjit_worker.c: strictly control MJIT copy job
- -available region. reducing risk of SEGV in mjit_copy_job_handler() like
http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1446117
I'm not sure which exact part is causing "[BUG] Segmentation fault at 0x0000000000000008"
on `(mjit_copy... -
07:03 AM Revision 9f17712d (git): Makefile.in: convert MJIT_CC to Windows path
- * Makefile.in (mjit_config.h): convert MJIT_CC to Windows path on
mingw.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65568 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:38 AM Bug #15270 (Closed): [PATCH] Fix TracePoint for code loaded using ISeq.load_from_binary
- Thank you! You are completely right.
applied at r65567 (I forget to add ticket reference on commit log).
-
06:36 AM Revision 09821dd2 (git): Fix TracePoint for nested iseq loaded from binary [Bug#14702]
- When loading iseq from binary while a TracePoint is on, we need to
recompile instructions to their "trace_" variant. Before this commit
we only recompiled instructions in the top level iseq, which meant
that TracePoint was malfunctioning... -
05:14 AM Revision b11b804f (git): Revert "mjit_build_dir: separate MJIT_BUILD_DIR"
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65566 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:07 AM Revision a5400ebb (git): do not delete function declarations in case of non-sanitizing builds
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65565 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:06 AM Revision cbb6a3a6 (git): annotate functions to blacklist MSAN
- In these functions we are intentionally reading memory address
not owned by us. These reads should not be diagnosed.
See also [Bug #8680]
See also https://travis-ci.org/ruby/ruby/jobs/451202718
git-svn-id: svn+ssh://ci.ruby-lang.org... -
04:14 AM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
- normalperson (Eric Wong) wrote:
> Do you have any historical info about the pass/fail rate of these tests in parallel?
Yes. Below is a summary of all builds from r64892 2018-10-01 thru r65558, except TestJIT. I assume TestIO & Tes... -
01:03 AM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
- [email protected] wrote:
> The above patch (v5) passed when added to:
>
> ruby 2.6.0dev (2018-11-06 trunk 65555) [x64-mingw32]
>
> It's not uncommon for a few tests to fail during parallel testing, but normally all pass on retr... -
12:28 AM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
- @normalperson Eric,
The above patch (v5) passed when added to:
ruby 2.6.0dev (2018-11-06 trunk 65555) [x64-mingw32]
It's not uncommon for a few tests to fail during parallel testing, but normally all pass on retry. It occurs wh... -
04:13 AM Revision a39080f5 (git): mjit_build_dir: separate MJIT_BUILD_DIR
- * Makefile.in (mjit_build_dir.so): separate MJIT_BUILD_DIR to
eliminate the feature for test-all after installation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65563 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:13 AM Revision a4b73e7e (git): Makefile.in: make MJIT_CC_COMMON an absolute path
- * Makefile.in (mjit_config.h): expand MJIT_CC_COMMON path to
mitigate potential security risks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65562 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:32 AM Revision 67de4342 (git): configure.ac: insert DLDSHARED
- * configure.ac (DLDSHARED): `.dylib` (created by `-dynamiclib`)
and `.bundle` (created by `-dynamic -bundle`) on macOS are
different. `LIBRUBY_LDSHARED` should be the former always.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... - 03:18 AM Revision f740687e (git): Fixed compile error introduced at r65558
- * internal.h (ATTRIBUTE_NO_ADDRESS_SAFETY_ANALYSIS): of course, parens around
function signature in its definition is syntax error.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65560 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:06 AM Revision 1a83433f (git): .travis.yml: FIBER_USE_NATIVE=0
- I remember this configuration unveiled several bugs before.
Better check it occasionally.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65559 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:57 AM Revision 16f5b18b (git): gc.c: move ASAN check to configure
- Availability of attributes are checked in configure these days,
rather than compiler macros. Also
__attribute__((no_address_safety_analysis)) is considered
deprecated in both GCC and Clang. Use the current best practice
if available. ... -
01:45 AM Revision ee7af442 (git): .travis.yml: allow UBSAN to fail
- Forgot this line, sorry!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65557 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:36 AM Revision 19adb808 (git): .travis.yml: add cron-only builds
- Inspired by [GH-1984], let us add some tests that run only
once a day. These configurations are either slow to compile
or slow to run. But I think they are worth done occasionally.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6... -
01:21 AM Feature #15236: add support for hash shorthand
- blakewest (Blake West) wrote:
> Hi all,
> ...
osyo (manga osyo) wrote:
> hi, blakewest.
> ...
I like this :+1:
`{ a, b, c }` looks a bit cleaner to me, probably because of my familiarity with es6 syntax, so it require less conte...
11/05/2018
-
11:33 PM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
- > https://bugs.ruby-lang.org/issues/14968
Updated patch against r65553 with non-blocking socket support:
https://80x24.org/spew/[email protected]/raw
Greg: It should be hiding errors for Win32 users, but I can'... -
11:07 PM Bug #15282 (Closed): Segfault (null pointer dereference) in variable.c iv_index_tbl_make
- Applied in changeset trunk|r65554.
----------
Don't set throw data as cause [Bug #15282] -
04:36 PM Bug #15282 (Closed): Segfault (null pointer dereference) in variable.c iv_index_tbl_make
- Reproducer and crash:
~~~
jtruba@dev118:~/rubies/ruby-trunk$ ./ruby -e 'END{n}; END{return}'
-e: unexpected return
-e:1: [BUG] Segmentation fault at 0x0000000000000018
ruby 2.6.0dev (2018-10-31 trunk 65474) [x86_64-linux]
-- Cont... - 11:06 PM Revision cc508b54 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65555 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:06 PM Revision fdcc9c9e (git): Don't set throw data as cause [Bug #15282]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65554 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:56 PM Revision c076d600 (git): thread.c (rb_wait_for_single_fd): no point initializing pollfd.revents
- poll(2) and ppoll(2) implementations need to check and write to
.revents on the initial scan, anyways. So any poll/ppoll call
which returns a positive result can be expected to have an
initialized .revents value.
git-svn-id: svn+ssh://... - 05:27 PM Revision de753720 (git): * 2018-11-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65552 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:27 PM Revision d05e04b8 (git): Relax MJIT_BUILD_DIR restriction
- * mjit.c (init_header_filename): sticky-mode directory probably
would be less unsafe even if it is not owned.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65551 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:43 PM Feature #11689: Add methods allow us to get visibility from Method and UnboundMethod object.
- (I think it may be easier to file a separate issue for the predicate methods,
such as Method#public?, Method#protected? or Method#private?).
Kaneko Yuichiro added the issue to the next upcoming developer meeting. Let's
see to the up... -
12:40 AM Feature #11689: Add methods allow us to get visibility from Method and UnboundMethod object.
- Oh, sorry. I missed where you were looking for an example before. Here's a good one from the popular activesupport gem: [here](https://github.com/rails/rails/blob/c823f9252be2552c65bb1370ccf42a14de461439/activesupport/lib/active_support/...
- 08:02 AM Revision 62ebf355 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65550 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:02 AM Revision 05711c45 (git): use `RSTRUCT_CONST_PTR` carefully.
- * struct.c: should not use `RSTRUCT_CONST_PTR` with method dispatch
because pointers can be obsolete after method dispatch. `rb_equal()`
and so on can dispatch Ruby's methods.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65549... -
07:01 AM Revision 972cf8c9 (git): Fix up r65505 [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65548 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:01 AM Revision ed44d40b (git): Sort in alphabetical order [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65547 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:02 AM Revision c8cbae68 (git): Fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65546 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:57 AM Revision fc8bda6f (git): Respect explicitly given MJIT_CC
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65545 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:25 AM Revision 002e0ca4 (git): Create MJIT header with strict permission
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65544 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:14 AM Feature #14836 (Closed): Method to return first/last lineno/column of Proc
- Applied in changeset trunk|r65542.
----------
Implement `RubyVM::AST.of` [Feature #14836] - 02:14 AM Revision 5164e2e4 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65543 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:13 AM Revision ce798d08 (git): Implement `RubyVM::AST.of` [Feature #14836]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65542 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:05 AM Revision 6d497629 (git): More verbose message at unsafe header
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65541 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:52 AM Misc #15229: DevelopersMeeting20181122Japan
- * [Feature #11689] Add methods allow us to get visibility from Method and UnboundMethod object. (yui-knk)
* I want to introduce this feature to help meta programming. I'd like to hear opinions from other committers.
11/04/2018
-
11:56 PM Feature #11689: Add methods allow us to get visibility from Method and UnboundMethod object.
- Thanks for your comment.
Can you show me the use cases where predicate methods are useful?
I think these predicate methods can be implemented by using `#visibility` method, so these predicate methods should not be needed as core features. -
10:36 PM Revision fc1f476b (git): addr2line.c uses c99ism
- https://travis-ci.org/ruby/ruby/jobs/450505006
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65540 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:39 PM Revision 8b8c374c (git): Fix RubyGems extension build failure after r65470
- Port of upstream patch https://github.com/rubygems/rubygems/pull/2457
Since r65470 (Upstream: https://github.com/rubygems/rubygems/pull/2441),
builds of extension gem had always failed under really_verbose mode.
git-svn-id: svn+ssh://c... -
03:25 PM Feature #15277: at_exec
- > I imagine that the need of calling at_exec is rare though
I think something similar could be said about at_exit. While I
think it is fine that it exists, I found that in larger projects
it can be quite annoying if some other proje... - 03:14 PM Revision 052e45f1 (git): * 2018-11-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65538 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:14 PM Revision e6d63ac6 (git): Use symtab if there's no .dSYM file
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65537 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:46 PM Revision ef94a94d (git): Check MJIT_BUILD_DIR strictly
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65536 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:24 PM Revision c111c42b (git): MJIT_CC should not use CC_WRAPPER
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65535 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:46 AM Revision 2c62b3fb (git): hash.c: [DOC] add docs for ENV.{filter,filter!}
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65534 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:45 AM Revision 7633552b (git): hash.c: [DOC] fix wrong cross-references
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65533 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:45 AM Revision 45868d20 (git): hash.c: [DOC] add missing `block' in call-seq's
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65532 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:44 AM Revision 6928faa6 (git): struct.c: [DOC] add docs for Struct#filter
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65531 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:43 AM Revision 83e459b2 (git): hash.c: [DOC] add docs for Hash#{filter,filter!}
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65530 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:41 AM Revision b3adc0c5 (git): hash.c: [DOC] improve Hash#{select!,keep_if} docs
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65529 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:40 AM Revision 139d9d81 (git): array.c: [DOC] add docs for Array#{filter,filter!}
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65528 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:39 AM Revision bd20f031 (git): array.c: [DOC] improve Array#{select,select!,keep_if} docs
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65527 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:01 AM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
- ko1 (Koichi Sasada) wrote:
> I agree to introduce cold attribute (I have no idea about the naming).
> ...
Yes, I agree - in retrospect `rb_define` functions would affect startup time, especially for very large Rails applications. I was... -
02:09 AM Revision f167ff47 (git): Hide Time::TM as Time::tm
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65526 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:02 AM Revision 125e9ef7 (git): Refine Timezone class in test-spec
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65525 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:30 AM Feature #15066: Documentation and providing better API for accessing Complex numbers functions in C extensions
- Sorry for laziness.
What about https://github.com/nobu/ruby/pull/new/feature/15066-Complex-API ?
- 01:14 AM Revision 356a73e7 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65524 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:14 AM Revision 2fbbbba5 (git): Merge upstream changes from 2-0-stable branch of bundler/bundler.
- * It update bundler 2 mode to bundler 3.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65523 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:22 AM Revision 3e063ca7 (git): complex.c: rb_dbl_complex_polar_pi
- * complex.c (rb_dbl_complex_polar_pi): suffixed with _pi to
clarify that `ang` is not radian, but multiplied by PI.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65522 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:08 AM Feature #15281: Speed up Set#intersect with size check.
- marcandre (Marc-Andre Lafortune) wrote:
> I'd be enclined to say that Set should be officially ordered, even if "mathematically" speaking that doesn't make sense. I'm assigning this to Matz.
I'd be inclined to say that Set should b...
11/03/2018
-
11:52 PM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
- I agree to introduce cold attribute (I have no idea about the naming).
`rb_bug` or `rb_warn` (etc) should be cold functions because they should not be called.
However, I'm not sure `rb_define_...` and so on because it can affect st... -
11:43 PM Revision 7d9623eb (git): Makefile.in: use CC_WRAPPER
- * Makefile.in (CC_WRAPPER): use the wrapper to suppress warnings
by Apple's broken packages when linking in the toplevel
directory.
* configure.ac (CC_WRAPPER): separate from CC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65... -
11:10 PM Revision 0f28fe2b (git): configure.ac: set CC_WRAPPER by checking message
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65520 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:08 PM Revision 7b845212 (git): * 2018-11-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65519 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:08 PM Revision 0660d7cb (git): Just skip on armv7l-linux
- it seems ssl.close doesn't cause EOFError on client side, but just skip
because it breaks test-all.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65518 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:52 PM Feature #15277: at_exec
- [email protected] wrote:
> normalperson (Eric Wong) wrote:
> > Would this work for subprocesses? (system, spawn, ``,
> > popen, ...)
>
> I'm not sure I understand the question. `exec` effectively
> terminates the Ruby pro... -
12:05 AM Feature #15277: at_exec
- normalperson (Eric Wong) wrote:
> Would this work for subprocesses? (system, spawn, ``, popen, ...)
I'm not sure I understand the question. `exec` effectively terminates the Ruby process although the `at_exit` callbacks are not call... -
08:37 PM Bug #15206: require_relative in std_lib
- For `lib/racc/parser.rb` I reverted this in r65514 for the require of `racc/cparse.so` (similar to r65511 for `cgi/escape`).
Possibly there might be other C extensions that are required from within `/lib`, where require_relative would... -
05:29 AM Bug #15206 (Closed): require_relative in std_lib
- Applied in changeset trunk|r65511.
----------
lib/cgi/util.rb: use require
* lib/cgi/util.rb: reverted r65505. require_relative does not
work for cgi/escape.so, as extension libraries are placed in
other directories than ruby libr... -
06:42 PM Feature #15281: Speed up Set#intersect with size check.
- RGBD (Oleg Zubchenko) wrote:
> > Set implements a collection of unordered values with no duplicates. This is a hybrid of Array's intuitive inter-operation facilities and Hash's fast lookup.
Good point.
Note that this documentation... -
05:10 PM Feature #15281: Speed up Set#intersect with size check.
- marcandre (Marc-Andre Lafortune) wrote:
> Thanks for the patch.
> ...
Where in the documentation can I read that?
[this](https://ruby-doc.org/stdlib-2.5.3/libdoc/set/rdoc/Set.html#method-i-to_a) says order is uncertain. I thought it... -
03:51 PM Feature #15281: Speed up Set#intersect with size check.
- Thanks for the patch.
Sadly, I don't think we can do that as `Set`s are ordered. That optimization would change the order of the resulting `Set` in some cases. -
01:08 PM Feature #15281 (Assigned): Speed up Set#intersect with size check.
- Current implementation computes set intersection s1 & s2 in O(s2.size) time.
It can be reduced to O([s1.size, s2.size].min) time.
Additional speedup comes from using #each instead of #do_with_enum.
See files attached for benchmark... -
05:02 PM Bug #15280: r65509 - bundler & make install, no CLI
- This seems to only affect `bundler`, while `bundle` is working fine. May be similar to `-rubygems` and `-rrubygems`...
-
06:19 AM Bug #15280 (Assigned): r65509 - bundler & make install, no CLI
-
04:50 AM Bug #15280 (Closed): r65509 - bundler & make install, no CLI
- Something may be amiss with the addition of bundler and `make install`, as `bundle(r) version` is not working. Previously, I installed the bundler gem, and all was fine...
If it's any help, the ruby-loco 7z file (ruby_trunk.7z) is av... -
03:15 PM Feature #14151 (Closed): Make Matrix#[]= public method
-
05:48 AM Feature #14151: Make Matrix#[]= public method
- It's been merged and issue can be closed now :)
-
12:42 PM Bug #14867: Process.wait can wait for MJIT compiler process
- [email protected] wrote:
> I close this ticket. Please file another ticket if you work on
> moving to event-based MJIT worker.
Thanks, but I don't know if it can happen in time for 2.6 :<
Judging by how often processes are s... -
07:39 AM Bug #14867 (Closed): Process.wait can wait for MJIT compiler process
- The CIs have been stable since r65495. I think this issue seems to be fixed now. Thank you so much!
I close this ticket. Please file another ticket if you work on moving to event-based MJIT worker. -
12:31 PM Revision 67da45a1 (git): Merge rubygems-3.0.0.beta2.
- * It enabled `USE_BUNDLER_FOR_GEMDEPS` for using gemdeps of rubygems.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65517 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:24 PM Revision 38caab29 (git): Always inline rb_to_integer to prevent a method call penalty
- for integer types
Close https://github.com/ruby/ruby/pull/2001
Co-Authored-By: methodmissing <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65516 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:20 AM Revision 728afecc (git): expose `rb_ary_detransient`.
- * internal.h: expose `rb_ary_detransient`. I'm not sure why there are
no many troubles without this patch...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65515 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:43 AM Revision e9adca49 (git): lib/racc/parser.rb: use require for racc/cparse
- * lib/racc/parser.rb: reverted r65505. require_relative does
not work for racc/cparse.so, as extension libraries are placed
in other directories than Ruby libraries.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65514 b2dd03c8-... -
07:58 AM Revision 84a27619 (git): hash.c: fix types
- * hash.c (RHASH_ARRAY_BOUND_RAW): should be unsigned as well as
RHASH_ARRAY_SIZE_RAW.
* hash.c (find_entry): return unsigned for the consistency with
RHASH_ARRAY_SIZE and RHASH_ARRAY_BOUND.
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
06:56 AM Bug #15279 (Closed): Lots of warnings about signed and unsigned types for macro RHASH_SIZE
- Applied in changeset trunk|r65512.
----------
internal.h: RHASH_ARRAY_SIZE_RAW value is unsigned
and get rid of warnings. [ruby-core:89688] [Bug #15279] -
03:19 AM Bug #15279 (Closed): Lots of warnings about signed and unsigned types for macro RHASH_SIZE
- When trying to compile the latest version of Ruby, I get a lot of warnings such as the following:
```
compiling array.c
In file included from transient_heap.h:12:0,
from array.c:21:
array.c: In function ‘rb_ary_un... -
06:55 AM Revision fd8d3c5c (git): internal.h: RHASH_ARRAY_SIZE_RAW value is unsigned
- and get rid of warnings. [ruby-core:89688] [Bug #15279]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65512 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:35 AM Bug #15087: Segmentation fault with splat and block
- Sorry, I've missed filling the Backport.
-
05:29 AM Revision 6b1e4251 (git): lib/cgi/util.rb: use require
- * lib/cgi/util.rb: reverted r65505. require_relative does not
work for cgi/escape.so, as extension libraries are placed in
other directories than ruby libraries. [Bug #15206]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65511... -
04:20 AM Bug #15278 (Closed): Refinements don't work well with Forwardable
- It's intentional. Refinement is **lexical** overriding of methods. That means refined methods (e.g. `origin` in this case) are not called from delegators.
Matz.
-
12:06 AM Bug #15278 (Closed): Refinements don't work well with Forwardable
- Refined methods become unreachable when called through def_delegator.
```ruby
require "forwardable"
module URIExtensions
refine URI::Generic do
def authority
port_string = port == default_port ? nil : ":#{port}"
... -
12:44 AM Revision bec184b5 (git): wercker.yml: use pipeline name for notification [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65510 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/02/2018
-
11:08 PM Feature #12733 (Closed): Bundle bundler to ruby core
- Applied in changeset trunk|r65509.
----------
Added bundler as default gems. Revisit [Feature #12733]
* bin/*, lib/bundler/*, lib/bundler.rb, spec/bundler, man/*:
Merge from latest stable branch of bundler/bundler repository and
... -
11:07 PM Revision 59c8d506 (git): Added bundler as default gems. Revisit [Feature #12733]
- * bin/*, lib/bundler/*, lib/bundler.rb, spec/bundler, man/*:
Merge from latest stable branch of bundler/bundler repository and
added workaround patches. I will backport them into upstream.
* common.mk, defs/gmake.mk: Added `tes... -
10:28 PM Revision 7deb3777 (git): common.mk: --no-ri and --no-rdoc options were removed
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65508 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:22 PM Feature #15277: at_exec
- [email protected] wrote:
> https://bugs.ruby-lang.org/issues/15277
Would this work for subprocesses? (system, spawn, ``, popen, ...)
(if so, it would defeat vfork optimization we do under Linux)
> There's currently no easy... -
07:23 PM Feature #15277 (Assigned): at_exec
- There's currently no easy way to have code executed before a subsequent call to `exec`. One has to monkey-patch the builtin method.
I'd like to propose a new method `at_exec` that would be very similar to `at_exit`, except that the ca... -
08:55 PM Feature #15236: add support for hash shorthand
- I would like to use Hash shorthand in the following cases.
```ruby
describe User do
let(:id) { ... }
let(:name) { ... }
let(:age) { ... }
let(:registered_at) { ... }
# I want to hash shorthand!
let(:user) { User.new(id: id, age:... -
08:47 PM Feature #15236: add support for hash shorthand
- hi, blakewest.
I proposaled it.
https://bugs.ruby-lang.org/issues/14973
I need to consider an implementation that does not use `#eval`. -
08:29 PM Feature #15236: add support for hash shorthand
- Hi all,
I've really wanted a feature like this for a long time. I find myself often using named arguments, which I love for the clarity. But then the callers often have variables of the same name as the parameter name, making it more v... -
07:31 PM Bug #15087: Segmentation fault with splat and block
- This is **still crashing** in Ruby 2.5.3. Is this going to ever be fixed in Ruby 2.5 series?
- 05:52 PM Revision eda970cf (git): lib/matrix.rb: Make Matrix & Vector mutable. Add #[]=, #map!.
- Adapted from patch by Grzegorz Jakubiak. [#14151] [Fix GH-1769] [Fix GH-1905]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65507 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:52 PM Revision b9d42af0 (git): lib/*: Prefer require_relative over require, remove explicit extension
- [#15206] [Fix GH-1976]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65506 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:52 PM Revision e859e668 (git): lib/*: Prefer require_relative over require.
- [#15206] [Fix GH-1976]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65505 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:52 PM Revision c8c66bcf (git): lib/matrix: Use consistent style
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65504 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:52 PM Revision 5ba9a950 (git): lib/matrix: use consistent style
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65503 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:52 PM Revision a1f22c4f (git): lib/matrix.rb: Alias antisymmetric? with skew_symmetric?
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65502 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:51 PM Revision 5a5bf993 (git): * 2018-11-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65501 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:51 PM Revision 55961ac9 (git): Revert "Matrix: Add #reflexive? method. [Fix GH-1730]"
- This reverts commit 19fe6552c456e41c0b85816806399ca1609255c0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65500 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:30 PM Revision df58e74e (git): Add timeout
- it breaks armv7 CI.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65499 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:21 PM Revision 119068f9 (git): README.md: add wercker status badge [ci skip]
- and show trunk branch's build status for travis as well
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65498 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:40 AM Revision 2337f0f3 (git): * 2018-11-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65497 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:40 AM Revision 6e9703b0 (git): mjit_worker.c: do no access pointer after free
- When we return there, `unit` is already freed.
This is detected by coverity scan.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65496 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:04 AM Bug #13427 (Closed): gemspec might be treat as binary - probably bug?
- Closed at r65461
-
03:25 AM Bug #15276: URI.join behaviour is unintuitive
- What name would you suggest? Avdi mentioned the name #merge_path - is this the name
that you suggest? (I ask specifically because finding a good name is not always
easy. And in the proposal no specific name was mentioned as such.)