Project

General

Profile

Activity

From 04/07/2020 to 04/13/2020

04/13/2020

11:45 PM Revision b9d3ceee (git): Unwrap vm_call_cfunc indirection on JIT
for VM_METHOD_TYPE_CFUNC.
This has been known to decrease optcarrot fps:
```
$ benchmark-driver -v --rbenv 'before ...
k0kubun (Takashi Kokubun)
07:16 PM Feature #16783: Implicit vs explicit self
😻 koriroys (Kori Roys)
05:59 PM Feature #16783 (Closed): Implicit vs explicit self
This was implemented in Ruby 2.7:
```ruby
class A
def b
self.a
self.a = 1
end
private
attr_...
jeremyevans0 (Jeremy Evans)
05:49 PM Feature #16783: Implicit vs explicit self
phrasing koriroys (Kori Roys)
05:48 PM Feature #16783 (Closed): Implicit vs explicit self
I recently ran into this case while trying to explain why `self` is needed for calling setters (can't disambiguate be... koriroys (Kori Roys)
05:37 PM Feature #16688: Allow #to_path object as argument to system()
There's maybe just one small gotcha to consider:
```ruby
o = File.open("o","w")
system("ls", out: o) #sh...
Dan0042 (Daniel DeLorme)
05:29 PM Feature #11816: Partial safe navigation operator
The `&.` operator has pretty well-defined semantics by now and changing it *may* break some existing code. Maybe a po... Dan0042 (Daniel DeLorme)
04:26 PM Bug #16740: Deprecating and removing the broken Process.clock_getres
I added an explicit list based on the file linked above in a6f7458ea81e084f6ebe7dc5c8cb5b7cb70fe2be.
On the upside i...
Eregon (Benoit Daloze)
04:16 PM Bug #16740: Deprecating and removing the broken Process.clock_getres
I don't think a list of ~15 cases of OS+clock would be helpful there, it's basically all OS we test.
And I doubt any...
Eregon (Benoit Daloze)
04:25 PM Revision fb40495c (git): * 2020-04-14 [ci skip]
git[bot]
04:23 PM Revision a6f7458e (git): Add a a list of cases for which clock_getres() has been observed to be inaccurate
* See [Bug #16740] Eregon (Benoit Daloze)
01:57 PM Revision c28e230a (git): Improve Hash documentation.
burdettelamar (Burdette Lamar)
12:51 PM Revision 67bcac87 (git): Allow simple R-assign in endless def
nobu (Nobuyoshi Nakada)
07:38 AM Revision 5dc6080c (git): delete CACHELINE
Since https://github.com/ruby/ruby/pull/2888 this macro is no longer
used in any place.
shyouhei (Shyouhei Urabe)
07:06 AM Revision c37a357c (git): include what you use.
This reverts commit 443389effc37308ce1a3c3a840082a344fc6af56.
This reverts commit d94960f22ec2de3a3855305cb51343806d2...
shyouhei (Shyouhei Urabe)
07:06 AM Revision 4ff3f205 (git): add #include guard hack
According to MSVC manual (*1), cl.exe can skip including a header file
when that:
- contains #pragma once, or
- star...
shyouhei (Shyouhei Urabe)
06:10 AM Revision a3f6f679 (git): Add MJIT_COUNTER macro to dump total_calls
k0kubun (Takashi Kokubun)
03:43 AM Bug #16782: `lock': deadlock; recursive locking (ThreadError) in 2.7.1
Total stab in the dark, but I wonder if it's because the signal handling is interrupting the same thread it's already... ioquatix (Samuel Williams)
03:42 AM Bug #16782 (Closed): `lock': deadlock; recursive locking (ThreadError) in 2.7.1
Using the latest `async-http` repo:
```
% bundle exec rspec spec/async/http/performance_spec.rb
Traceback (mos...
ioquatix (Samuel Williams)
03:31 AM Feature #15897: `it` as a default block parameter
jeremyevans0 (Jeremy Evans) wrote in #note-39:
> I'm going to close this feature since numbered block parameters w...
joallard (Jonathan Allard)
12:51 AM Misc #16778: Should we stop vendoring default gems code?
CI in general, and in particular Actions (along with actions/checkout@v2) can be done from any repo.
There could a...
MSP-Greg (Greg L)

04/12/2020

08:47 PM Feature #16781 (Open): alias :fold :reduce
1. Method "collect" has short synonym "map", short synonym of "inject" and "reduce" doesn't exist.
2. Name "fold" is...
0x81000000 (/ /)
07:19 PM Revision 82fdffc5 (git): Avoid UB with flexible array member
Accessing past the end of an array is technically UB. Use C99 flexible
array member instead to avoid the UB and simpl...
alanwu (Alan Wu)
03:02 PM Revision f2c3848a (git): * 2020-04-13 [ci skip]
git[bot]
02:29 PM Revision 4c8e3f12 (git): Make rb_scan_args implementations same
between rb_scan_args_set and rb_scan_args_assign +
rb_scan_args_result.
nobu (Nobuyoshi Nakada)
02:04 PM Bug #16776: Regression in coverage library
Eregon (Benoit Daloze) wrote in #note-5:
> Maybe coverage could use a second type of internal tracepoint to fix this...
mame (Yusuke Endoh)
02:01 PM Bug #16776: Regression in coverage library
IMO, TracePoint hooks should have a priority. A TracePoint hook that is first enabled should monitor a hook code tha... mame (Yusuke Endoh)
01:14 PM Bug #16776: Regression in coverage library
I'm surprised too the coverage stdlib gets hit by this issue.
Maybe coverage could use a second type of internal t...
Eregon (Benoit Daloze)
06:27 AM Bug #16776: Regression in coverage library
I'm not super familiar with `TracePoint`, but at first sight `DeepCover` shouldn't generate any extra callbacks as th... marcandre (Marc-Andre Lafortune)
05:32 AM Bug #16776: Regression in coverage library
I never realized this limitation. I imagine that for the vast majority of users it's a non issue, but for `byebug` it... marcandre (Marc-Andre Lafortune)
01:11 PM Feature #16779: Add sprintf %q format option
`%p` is part of the documentation of `sprintf` but maybe it's not so clear.
PR welcome to improve that documentation.
Eregon (Benoit Daloze)
01:10 PM Feature #16779 (Rejected): Add sprintf %q format option
Eregon (Benoit Daloze)
11:54 AM Feature #16779: Add sprintf %q format option
I am not aware of `%p` format option, this option exactly did what i try to solve.
Thanks.
Someone can close thi...
gearnode (Bryan Frimin)
10:59 AM Feature #16779: Add sprintf %q format option
`.inspect.dump` double quotes, that doesn't seem readable/useful to me:
```ruby
puts sprintf("%s", "abc".inspect.du...
Eregon (Benoit Daloze)
10:57 AM Feature #16779: Add sprintf %q format option
Isn't `%p` enough (which uses `#inspect`)? Eregon (Benoit Daloze)
11:16 AM Misc #16778: Should we stop vendoring default gems code?
I believe that is a good practice in general because:
* Contributions don't get affected by changes in external depe...
deivid (David Rodríguez)
11:04 AM Misc #16778: Should we stop vendoring default gems code?
> One issue might be that ruby/ruby changes frequently but the CI of e.g. ruby/ostruct might run infrequently because... deivid (David Rodríguez)
10:45 AM Misc #16778: Should we stop vendoring default gems code?
I think this is a great idea and it would make the stdlib really "just a set of gems".
I'm not sure what should ha...
Eregon (Benoit Daloze)
10:19 AM Misc #16778: Should we stop vendoring default gems code?
Hei @mame!
> When Ruby CI fails, we need to stop the error as soon as possible. It is not acceptable to send a pul...
deivid (David Rodríguez)
05:05 AM Misc #16778: Should we stop vendoring default gems code?
mame (Yusuke Endoh) wrote in #note-11:
> As a committer who is involved in security release, I'm concerned about the ...
greggzst (Grzegorz Jakubiak)
03:29 AM Misc #16778: Should we stop vendoring default gems code?
As a committer who is involved in security release, I'm concerned about the maintenance policy of default gems.
Cons...
mame (Yusuke Endoh)
02:56 AM Misc #16778: Should we stop vendoring default gems code?
I have one favor as a maintainer of Ruby CIs. If the copies of default gems are removed from ruby/ruby, please allow... mame (Yusuke Endoh)
10:26 AM Feature #16494: Allow hash unpacking in non-lambda Proc
Honestly, after how Matz has stated his opinion, I don't expect there is any room for dialogue.
The only thing I'd...
zverok (Victor Shepelev)
09:45 AM Feature #16494: Allow hash unpacking in non-lambda Proc
I am another person with blocks affected in a production application codebase, found sixteen uses.
I see a cluster...
inopinatus (Joshua GOODALL)
05:58 AM Feature #16754 (Closed): Pager for `--help`
Applied in changeset commit:git|f22c4ff359498ab342e4b6d6feb21af6004ee270.
----------
View the help message with PAGE...
nobu (Nobuyoshi Nakada)
05:58 AM Revision a07cbacd (git): Honor COLUMNS [Feature #16754]
nobu (Nobuyoshi Nakada)
05:58 AM Revision cc68d2fb (git): Hightlight usage [Feature #16754]
nobu (Nobuyoshi Nakada)
05:58 AM Revision 3825662d (git): Set up environment variable for pager [Feature #16754]
nobu (Nobuyoshi Nakada)
05:58 AM Revision e6551d83 (git): PAGER without fork&exec too [Feature #16754]
nobu (Nobuyoshi Nakada)
05:58 AM Revision f22c4ff3 (git): View the help message with PAGER [Feature #16754]
View the help message wth pager designed by RUBY_PAGER or PAGER
environment variable, unless that value is empty.
nobu (Nobuyoshi Nakada)
03:45 AM Revision 5c276818 (git): Enable fastpath on invokesuper (#3021)
Fastpath has not been used for invokesuper since it has set vm_call_super_method on every invocation.
Because it seem...
k0kubun (Takashi Kokubun)
03:20 AM Feature #11816: Partial safe navigation operator
FWIW, EcmaScript 2020 introduced a similar operator, see https://github.com/tc39/proposal-optional-chaining/
. The p...
marcandre (Marc-Andre Lafortune)
01:09 AM Bug #13962: Change http://unicode.org to https
znz (Kazuhiro NISHIYAMA) wrote in #note-13:
> Making snapshots of 2.5 and 2.6 sometimes failed to download from `htt...
duerst (Martin Dürst)

04/11/2020

10:26 PM Misc #16778 (Assigned): Should we stop vendoring default gems code?
hsbt (Hiroshi SHIBATA)
10:24 PM Misc #16778: Should we stop vendoring default gems code?
Using git submodules would certainly have advantages, but it's a big change.
Either way, it would be helpful if up...
MSP-Greg (Greg L)
09:12 PM Misc #16778: Should we stop vendoring default gems code?
shevegen (Robert A. Heiler) wrote in #note-4:
> this may help distributions such as,
> say, debian, when there is s...
vo.x (Vit Ondruch)
07:57 PM Misc #16778: Should we stop vendoring default gems code?
Yeah! You're right about those other reasons. Specially for security issues in standard libraries, gemification is gr... deivid (David Rodríguez)
07:02 PM Misc #16778: Should we stop vendoring default gems code?
> I believe that all of that kind of defeats the point of "gemification" of
> the standard library.
If I remember...
shevegen (Robert A. Heiler)
04:17 PM Misc #16778: Should we stop vendoring default gems code?
> Is that done against ruby/ruby's code, or the master code of all run-time and/or testing dependencies (ie, the 'gem... deivid (David Rodríguez)
03:07 PM Misc #16778: Should we stop vendoring default gems code?
> upstream's responsibility to make sure the code works and it's properly tested
Is that done against ruby/ruby's co...
MSP-Greg (Greg L)
01:49 PM Misc #16778: Should we stop vendoring default gems code?
Forgot to mention, but something else that should be done as a "prerequisite" to this would be to make sure that all ... deivid (David Rodríguez)
01:26 PM Misc #16778 (Rejected): Should we stop vendoring default gems code?
Currently ruby-core vendors all the code in default gems, and runs the tests for each of them.
Also, ruby-core con...
deivid (David Rodríguez)
10:17 PM Bug #16780 (Closed): Net::FTP PUT command issuing Net::ReadTimeout too quickly
This is my first time writing up an issue for this community, so I apologize if this is written in an abnormal way th... rgerard (Ryan Gerard)
09:34 PM Feature #16779: Add sprintf %q format option
The github pull request: https://github.com/ruby/ruby/pull/3019 gearnode (Bryan Frimin)
06:06 PM Feature #16779 (Rejected): Add sprintf %q format option
It would be great to have format option for quoted string for sprintf (like golang sprintf),
it's particularly usefu...
gearnode (Bryan Frimin)
03:19 PM Revision a01bda59 (git): * 2020-04-12 [ci skip]
git[bot]
03:07 PM Revision 022c7bbe (git): Relaxed of R-assign value to arg
nobu (Nobuyoshi Nakada)
02:00 PM Feature #16742: RbConfig.windows? and RbConfig.host_os
> it should be false for cygwin too since it also tries to hide the fact you're on Windows.
Agreed. I think. I've ...
MSP-Greg (Greg L)
01:16 PM Bug #13962: Change http://unicode.org to https
Making snapshots of 2.5 and 2.6 sometimes failed to download from `http://www.unicode.org`.
But it seems making snap...
znz (Kazuhiro NISHIYAMA)
11:48 AM Bug #16669: Rails Action Text unit tests fail since b9007b6c548f91e88fd3f2ffa23de740431fa969
Thanks for providing a fix, which addresses the failure originally reported at Rails Action Text. https://github.com/... yahonda (Yasuo Honda)
11:34 AM Bug #16660 (Rejected): Struct#deconstruct_keys inconsistent behavior
My stance is "if we really should care about consistency over performance, we should remove the `keys` argument itsel... ktsj (Kazuki Tsujimoto)
08:15 AM Feature #16763 (Closed): MSVC: allow ranges for MSVC 2017 and 2019 support in win32/Makefile.sub
Applied in changeset commit:git|93edbb4c08856d6d10d0e2676cc2e36eef839a7d.
----------
Support version ranges for MSVC...
nobu (Nobuyoshi Nakada)
08:12 AM Revision 93edbb4c (git): Support version ranges for MSVC [Feature #16763]
nobu (Nobuyoshi Nakada)
03:59 AM Revision e56e089b (git): Assertions for basic use of `encoding:` option
nobu (Nobuyoshi Nakada)
03:59 AM Revision bae16b42 (git): Assertions for enumerators of Dir
nobu (Nobuyoshi Nakada)
02:58 AM Revision aade69ea (git): Removed unnecessary `to_a` call
`Dir.entries` returns an array. nobu (Nobuyoshi Nakada)
02:39 AM Bug #14413: `-n` and `-p` flags break when stdout is closed
I understand change. It makes sense. My only concern is:
- Is exit status changed when `SignalException` is raised?
...
ioquatix (Samuel Williams)
12:30 AM Bug #14413 (Closed): `-n` and `-p` flags break when stdout is closed
Applied in changeset commit:git|6f28ebd585fba1aff1c9591ced08ed11b68ba9e3.
----------
Silence broken pipe error messa...
nobu (Nobuyoshi Nakada)
02:34 AM Bug #16455 (Closed): coroutine ucontext uses deprecated POSIX getcontext/swapcontext/makecontext, absent in musl and uclibc
It is fixed: https://github.com/ruby/ruby/pull/2995 ioquatix (Samuel Williams)
02:24 AM Bug #16777 (Closed): IRB in Ruby 2.7 hangs on pasting long here document
IRB in Ruby 2.7 hangs on pasting long here document. Here is an example when I copy and paste the script in the attac... jnchito (Junichi Ito)
02:23 AM Revision bfe70671 (git): [ci skip] Enumerator doc cleanup
This is my first attempt at a pull request. I was reading the ruby docs
the other day and noticed that the output did...
gerero20
02:19 AM Revision abe2e7de (git): Don't require sub-word atomics
On some architectures (like RISC-V) sub-word atomics are only available
when linking against -latomic, but the config...
Andreas Schwab
01:51 AM Bug #16740: Deprecating and removing the broken Process.clock_getres
Eregon (Benoit Daloze) wrote in #note-11:
> I don't have time to report these bugs to all operations systems.
> I'v...
mame (Yusuke Endoh)
12:51 AM Bug #16771: Segmentation fault when inspecting a bound method
I can reproduce this in 2.7.1, but not on master. Here's debugging information:
```
(gdb) bt
#0 0x00000bbf2523...
jeremyevans0 (Jeremy Evans)
12:30 AM Revision 6f28ebd5 (git): Silence broken pipe error messages on STDOUT [Feature #14413]
Raise `SignalException` for SIGPIPE to abort when EPIPE occurs. nobu (Nobuyoshi Nakada)
12:24 AM Bug #16768 (Rejected): "\n" started not to work as a delimiter in time zone names for Date._strptime since 2.7.0
This seems more like a bugfix than a regression to me, even if the change was unintended. Is there a reason you woul... jeremyevans0 (Jeremy Evans)

04/10/2020

10:40 PM Bug #16669 (Assigned): Rails Action Text unit tests fail since b9007b6c548f91e88fd3f2ffa23de740431fa969
k0kubun (Takashi Kokubun)
10:09 PM Bug #16740: Deprecating and removing the broken Process.clock_getres
mame (Yusuke Endoh) wrote in #note-9:
> But some people said, it might be only guaranteed that the number returned b...
Eregon (Benoit Daloze)
09:47 PM Bug #16740: Deprecating and removing the broken Process.clock_getres
akr (Akira Tanaka) wrote in #note-8:
> It doesn't describe OS version and actual problem of OS behavior.
If you l...
Eregon (Benoit Daloze)
06:01 PM Bug #16740: Deprecating and removing the broken Process.clock_getres
Eregon (Benoit Daloze) wrote in #note-6:
> https://github.com/ruby/spec/blob/ec844797a51a017ebc93af833e421362b4b24a17...
mame (Yusuke Endoh)
04:49 PM Bug #16740: Deprecating and removing the broken Process.clock_getres
Eregon (Benoit Daloze) wrote in #note-6:
> https://github.com/ruby/spec/blob/ec844797a51a017ebc93af833e421362b4b24a1...
akr (Akira Tanaka)
04:34 PM Bug #16740: Deprecating and removing the broken Process.clock_getres
I'm OK to change to "operating system or hardware bugs", although I don't think it's the fault of the hardware.
cloc...
Eregon (Benoit Daloze)
04:26 PM Bug #16740: Deprecating and removing the broken Process.clock_getres
https://github.com/ruby/spec/blob/ec844797a51a017ebc93af833e421362b4b24a17/core/process/fixtures/clocks.rb#L19-L59 an... Eregon (Benoit Daloze)
03:26 PM Bug #16740: Deprecating and removing the broken Process.clock_getres
I don't think that it is a good idea to say "operating system bugs" in rdoc unless there is a solid evidence. You sh... mame (Yusuke Endoh)
02:48 PM Bug #16740: Deprecating and removing the broken Process.clock_getres
Eregon (Benoit Daloze) wrote in #note-3:
> OK. I'll improve the documentation to mention it's basically unreliable o...
akr (Akira Tanaka)
12:23 PM Bug #16740: Deprecating and removing the broken Process.clock_getres
OK. I'll improve the documentation to mention it's basically unreliable or broken on most operating systems. Eregon (Benoit Daloze)
07:06 AM Bug #16740 (Rejected): Deprecating and removing the broken Process.clock_getres
We discussed this issue at a Ruby developer meeting.
https://bugs.ruby-lang.org/issues/16693
We don't want to rem...
akr (Akira Tanaka)
05:32 PM Revision 87bcb3c4 (git): Fix articles.
akr (Akira Tanaka)
05:25 PM Bug #16776: Regression in coverage library
I see.
It's a severe as "I can no longer track code coverage on my library that makes heavy use of TracePoint" is co...
deivid (David Rodríguez)
05:20 PM Bug #16776: Regression in coverage library
Thank you for your report. The reason why the method execution is missed is because:
* coverage measurement is ba...
mame (Yusuke Endoh)
04:39 PM Bug #16776 (Assigned): Regression in coverage library
Hi!
I noticed a regression in the coverage library. I tried to write a minimal program to show it, hopefully it gi...
deivid (David Rodríguez)
05:09 PM Revision 7df83c4e (git): * 2020-04-11 [ci skip]
git[bot]
05:09 PM Revision 6abd08c0 (git): Replace Fixnum by Integer in a document.
akr (Akira Tanaka)
04:51 PM Bug #16770 (Closed): Commit: RUBY3_HAS_BUILTIN: fix for nonexistent builtin - large increase in MinGW & mswin compile times
I guess 443389effc37308ce1a3c3a840082a344fc6af56 probably fixed this. Eregon (Benoit Daloze)
01:41 PM Bug #16770: Commit: RUBY3_HAS_BUILTIN: fix for nonexistent builtin - large increase in MinGW & mswin compile times
@Eregon
I apologize for the possible confusion. When I opened the issue, I woke up, and all three builds (Actions...
MSP-Greg (Greg L)
04:45 PM Bug #14413: `-n` and `-p` flags break when stdout is closed
I like silent exit at EPIPE on STDOUT.
The error message of `ruby ... | head` doesn't help us.
The user, who type...
akr (Akira Tanaka)
04:01 PM Bug #14413: `-n` and `-p` flags break when stdout is closed
I think we need to be careful about changing the exceptions that IO operations can raise.
We already have:
Sock...
ioquatix (Samuel Williams)
04:44 PM Bug #6087: How should inherited methods deal with return values of their own subclass?
Much like all Enumerable methods return `Array` and (of course) do not copy instance variables, I think Array methods... Eregon (Benoit Daloze)
07:18 AM Bug #6087: How should inherited methods deal with return values of their own subclass?
Should we do an experiment in 3.0?
Matz
matz (Yukihiro Matsumoto)
07:17 AM Bug #6087: How should inherited methods deal with return values of their own subclass?
I used to think methods should honor subclasses, but I changed my mind that the behavior made things too complex.
So...
matz (Yukihiro Matsumoto)
04:06 PM Feature #16428: Add Array#uniq?, Enumerable#uniq?
In my cases, I (server side) only had to check duplication because a client also have validations.
Legal users can't...
kyanagi (Kouhei Yanagita)
02:42 PM Feature #16428: Add Array#uniq?, Enumerable#uniq?
kyanagi (Kouhei Yanagita) wrote in #note-5:
> I was developing mobile games, and I met these situations:
>
> A ca...
shyouhei (Shyouhei Urabe)
02:25 PM Feature #16428: Add Array#uniq?, Enumerable#uniq?
I was developing mobile games, and I met these situations:
A card deck can't have duplicate characters.
i.e. `dec...
kyanagi (Kouhei Yanagita)
04:41 AM Feature #16428 (Feedback): Add Array#uniq?, Enumerable#uniq?
You said, "I often need to check if an array have duplicate elements". But we cannot think of the real-world use-case... matz (Yukihiro Matsumoto)
02:47 PM Misc #16775 (Closed): DevelopersMeeting20200514Japan
# The next dev meeting
**Date: 2020/05/14 13:00-17:00**
Place/Sign-up: https://docs.google.com/document/d/11rxI64...
mame (Yusuke Endoh)
02:47 PM Misc #16693 (Closed): DevelopersMeeting20200410Japan
mame (Yusuke Endoh)
02:07 PM Revision 108d392e (git): RUBY3_HAS_ATTRIBUTE: fix fallbacks
Same as 133ae0807d661eac174b59c6e91c11a40975baea shyouhei (Shyouhei Urabe)
02:02 PM Bug #16774 (Closed): Don't require sub-word atomics
On some architectures (like RISC-V) sub-word atomics are only available
when linking against -latomic, but the confi...
schwab (Andreas Schwab)
01:46 PM Revision 8ec79540 (git): [DOC] Fixed POSIX clock_getres(3) link [ci skip]
It should not be linked to `Process.clock_getes`. nobu (Nobuyoshi Nakada)
01:12 PM Revision b18a6b64 (git): include/ruby/3: do not skip RUBY3_UNREACHABLE_RETURN
Revert "Revert "include/ruby/3/core/rtypeddata.h: Use 0 instead of NULL for C++ compiler""
Revert "include/ruby/3/cor...
shyouhei (Shyouhei Urabe)
12:42 PM Revision c9b3aa84 (git): Warn about Process#clock_getres being unreliable in documentation
* [Bug #16740]
* Remove the GETTIMEOFDAY_BASED_CLOCK_REALTIME example because the
caveat applies to all clock ids, ...
Eregon (Benoit Daloze)
12:20 PM Feature #16746: Endless method definition
nobu (Nobuyoshi Nakada) wrote in #note-19:
> It is not easy to control parsing time warnings, and bothers tests.
...
Eregon (Benoit Daloze)
11:59 AM Feature #16746: Endless method definition
It is not easy to control parsing time warnings, and bothers tests. nobu (Nobuyoshi Nakada)
10:20 AM Feature #16746: Endless method definition
> I'd like to experiment with this new syntax. We may find drawbacks in the future, but to find them, we need to expe... retro (Josef Šimánek)
10:06 AM Feature #16746 (Closed): Endless method definition
Applied in changeset commit:git|e8f53692ca7d65c92bde6d5bc6a1aea492915d9f.
----------
Endless method definition [Feat...
nobu (Nobuyoshi Nakada)
08:26 AM Feature #16746: Endless method definition
I'd like to experiment with this new syntax. We may find drawbacks in the future, but to find them, we need to experi... matz (Yukihiro Matsumoto)
02:18 AM Feature #16746: Endless method definition
Using the assignment operator like `def value =` expects the following behavior.
```ruby
value = 42
# Refer to v...
osyo (manga osyo)
12:15 PM Feature #16769: Struct.new(..., immutable: true)
Sad to see this rejected as there was a lot of agreement here, and I think #16122 might take a lot longer before anyt... Eregon (Benoit Daloze)
08:38 AM Feature #16769 (Rejected): Struct.new(..., immutable: true)
I don't like the keyword argument that changes the fundamental behavior. I prefer #16122 to this proposal.
Let's dis...
matz (Yukihiro Matsumoto)
12:13 PM Feature #16122: Data: simple immutable value object
In my view, `Struct.new` is the perfect example to generate a custom class in Ruby.
I think making it customizable wi...
Eregon (Benoit Daloze)
12:09 PM Feature #16122: Data: simple immutable value object
We already have `Struct.new(..., keyword_init: true)`.
I think having other variants like `immutable: true, enumerab...
Eregon (Benoit Daloze)
12:02 PM Revision 302da060 (git): Reference to [Feature #16746] [ci skip]
nobu (Nobuyoshi Nakada)
11:56 AM Feature #16688: Allow #to_path object as argument to system()
mame (Yusuke Endoh) wrote in #note-9:
> I'd like to confirm: `system(Pathname("cat /etc/passwd"))` should attempt to...
Eregon (Benoit Daloze)
11:44 AM Feature #16688: Allow #to_path object as argument to system()
I'd like to confirm: `system(Pathname("cat /etc/passwd"))` should attempt to execute a file whose path is `./cat\ /et... mame (Yusuke Endoh)
06:38 AM Feature #16688: Allow #to_path object as argument to system()
Accepted.
Matz.
matz (Yukihiro Matsumoto)
06:36 AM Feature #16688: Allow #to_path object as argument to system()
I'm positive.
It would be useful for most options for `spawn`.
(except open mode, "w" of `system("ls", out: ["/tm...
akr (Akira Tanaka)
11:53 AM Feature #16742: RbConfig.windows? and RbConfig.host_os
For `RbConfig.host_os` I expect the same as `RbConfig::CONFIG['host_os']`, or better slightly simplified (no version,... Eregon (Benoit Daloze)
06:00 AM Feature #16742: RbConfig.windows? and RbConfig.host_os
Is `host_os` what you want to see?
`RbConfig::CONFIG['host_os']` is bare value by config.guess, like "linux-gnu", "d...
nobu (Nobuyoshi Nakada)
05:54 AM Feature #16742: RbConfig.windows? and RbConfig.host_os
The `#host_os` seems OK.
Regarding `#windows?`, what do you want to check using the value? Drive letter? Path sepa...
matz (Yukihiro Matsumoto)
11:36 AM Feature #16773 (Open): Reduce allocations in net/http
Some minor patches which help to reduce allocations in net/http, which should benefit any programs making heavy use o... timcraft (Tim Craft)
11:35 AM Feature #15921: R-assign (rightward-assignment) operator
`expr in var` already allows rightward assignment:
```
$ ruby -e '(1..).lazy.map {|x| x*2} in x; p x.first(10)'
...
Eregon (Benoit Daloze)
07:27 AM Feature #15921: R-assign (rightward-assignment) operator
Cases where `=>` is used outside hashes, arrays, and method call arguments currently are syntax errors. This changes... jeremyevans0 (Jeremy Evans)
07:11 AM Feature #15921 (Closed): R-assign (rightward-assignment) operator
Applied in changeset commit:git|1b2d351b216661e03d497dfdce216e0d51474664.
----------
Rightward-assign by ASSOC
[Fea...
nobu (Nobuyoshi Nakada)
05:17 AM Feature #15921: R-assign (rightward-assignment) operator
Accepted. I choose `=>`. Some confusing cases should be warned (by the compiler or a cop) e.g.
```
m((a=>b))
m (a=...
matz (Yukihiro Matsumoto)
09:02 AM Revision e8f53692 (git): Endless method definition [Feature #16746]
nobu (Nobuyoshi Nakada)
08:55 AM Feature #16754: Pager for `--help`
I have no objection to the feature. Go ahead.
Matz.
matz (Yukihiro Matsumoto)
08:35 AM Revision 878e21c6 (git): R-assign is still experimental [Feature #15921] [ci skip]
nobu (Nobuyoshi Nakada)
07:58 AM Feature #16684: Use the word "to" instead of "from" in backtrace
matz (Yukihiro Matsumoto) wrote in #note-8:
> I don't think `to` is sufficient. I'd rather remove `from` altogether ...
sawa (Tsuyoshi Sawada)
07:52 AM Feature #16684: Use the word "to" instead of "from" in backtrace
I don't think `to` is sufficient. I'd rather remove `from` altogether if there's no compatibility issue.
Should we r...
matz (Yukihiro Matsumoto)
07:29 AM Bug #14541 (Closed): Class variables have broken semantics, let's fix them
Applied in changeset commit:git|900e83b50115afda3f79712310e4cb95e4508972.
----------
Turn class variable warnings in...
jeremyevans (Jeremy Evans)
05:36 AM Bug #14541: Class variables have broken semantics, let's fix them
Accepted. Let's see if it works out.
Matz.
matz (Yukihiro Matsumoto)
07:29 AM Revision 900e83b5 (git): Turn class variable warnings into exceptions
This changes the following warnings:
* warning: class variable access from toplevel
* warning: class variable @foo o...
jeremyevans (Jeremy Evans)
07:17 AM Revision defc0ee9 (git): ext/-test-/cxxanyargs: add #pragma for icc.
shyouhei (Shyouhei Urabe)
07:17 AM Revision 4e7d84cf (git): ruby3_rstring_getmem: suppres warning
icc warns at this line.
> include/ruby/3/core/rstring.h(126): warning #413: variable "retval" has an uninitialized c...
shyouhei (Shyouhei Urabe)
07:17 AM Revision 3e92785f (git): RUBY3_ASSUME: suppress warnings on icc
icc warns side effects for RUBY3_ASSUME like this:
> ./include/ruby/3/value_type.h(202): warning #2261: __assume exp...
shyouhei (Shyouhei Urabe)
07:17 AM Revision d69c5326 (git): configure: suppress SunPro warning
To this date there is no way for Oracle developer Studio to suppress
warnings about unreachable codes (12.6 manual sa...
shyouhei (Shyouhei Urabe)
07:17 AM Revision 75802bcf (git): configure: suppress icc warnings
Every time a pointer to/from VALUE conversion happens, these two
warnings are issued:
- warning #1684: conversion fr...
shyouhei (Shyouhei Urabe)
07:17 AM Revision e43237b1 (git): configure: always check for __builtin_unreachable
Non-gcc compilers tend to have this intrinsic these days (e.g. icc).
Better check it regardless of $GCC.
shyouhei (Shyouhei Urabe)
07:17 AM Revision 133ae080 (git): RUBY3_HAS_BUILTIN: fix __builtin_unreachable
This macro has to be truthy, otherwise the `+0` trick above evalues
RUBY3_HAS_BUILTIN(__builtin_unreachable) to be al...
shyouhei (Shyouhei Urabe)
07:17 AM Revision 4b853932 (git): mjit_worker: __GNUC__ is too lax
Namely icc defines __GNUC__, but doesn't have -Wdeprecated-declarations shyouhei (Shyouhei Urabe)
06:03 AM Revision 1b2d351b (git): Rightward-assign by ASSOC
[Feature #15921] nobu (Nobuyoshi Nakada)
05:53 AM Bug #16772 (Closed): Build becomes slow with CIFS mounted srcdir
Applied in changeset commit:git|443389effc37308ce1a3c3a840082a344fc6af56.
----------
reduce duplicate include.
With...
ko1 (Koichi Sasada)
05:53 AM Revision d94960f2 (git): update dependencies
ko1 (Koichi Sasada)
05:53 AM Revision 443389ef (git): reduce duplicate include.
Without this patch, 20k files are opened (openat syscall) because
of duplicate includes. This patch reduced it to 3k ...
ko1 (Koichi Sasada)
05:31 AM Bug #16660: Struct#deconstruct_keys inconsistent behavior
I agree that it's inconsistent and (a little bit) confusing. But it's not a bug.
I wish @ktsj to revisit this issue,...
matz (Yukihiro Matsumoto)
01:52 AM Revision 63a5412d (git): Make `#inspect` interruptible in `Kernel#p`
Only writing the inspected result and a newline is
uninterruptible.
nobu (Nobuyoshi Nakada)
01:38 AM Revision 230efaf2 (git): * 2020-04-10 [ci skip]
git[bot]
01:37 AM Revision 614d816a (git): Constified writev function family
nobu (Nobuyoshi Nakada)

04/09/2020

07:59 PM Feature #15330: autoload_relative
autoload is important for big rails applications, as for things like Rake scripts, being able to load only what is re... brodock (Gabriel Mazetto)
01:42 PM Bug #16772: Build becomes slow with CIFS mounted srcdir
@shyouhei maybe it was split in too many header files?
Agreed before ruby/ruby.h and intern.h were too big, but 186 ...
Eregon (Benoit Daloze)
12:59 AM Bug #16772: Build becomes slow with CIFS mounted srcdir
On my Windows PC, building ruby without tests takes over 20 min now.
And mswin-CI (http://mswinci.japaneast.cloudapp...
usa (Usaku NAKAMURA)
12:43 AM Bug #16772 (Closed): Build becomes slow with CIFS mounted srcdir
Recent 9e6e39c3512f7a962c44dc3729c98a0f8be90341 increases many include files and it makes slow build on my machine.
...
ko1 (Koichi Sasada)
01:36 PM Feature #16769: Struct.new(..., immutable: true)
@nobu setter methods shouldn't be defined, so just `.freeze` is not enough. Eregon (Benoit Daloze)
02:05 AM Feature #16769: Struct.new(..., immutable: true)
How about:
```ruby
Freezing = ->*{def initialize(...) super; freeze; end}
Post = Struct.new(:id, :name, &Freezin...
nobu (Nobuyoshi Nakada)
01:05 AM Feature #16769: Struct.new(..., immutable: true)
It would be good to reuse an existing "freeze" mechanism.
```ruby
Post = Struct.new(:id, :name, freeze: true)
post ...
mame (Yusuke Endoh)
09:23 AM Revision 55a5a4bc (git): Fixed to initialize ruby-core repository when it has no master branch
hsbt (Hiroshi SHIBATA)
07:34 AM Revision 7a26021d (git): Support one repository for updating the latest commits
hsbt (Hiroshi SHIBATA)
05:24 AM Revision b965e7e0 (git): Revert "include/ruby/3/core/rtypeddata.h: Use 0 instead of NULL for C++ compiler"
This reverts commit d2bb2e066b5a914283dd3ea473fc1762183af013.
It didn't work:
https://rubyci.org/logs/rubyci.s3.ama...
mame (Yusuke Endoh)
03:51 AM Revision fd0222ca (git): should check pending interrupts correctly.
rb_uninterruptible() disables any interrupts using handle_interrupt
feature (This function is used by `p`).
After thi...
ko1 (Koichi Sasada)
03:50 AM Revision d2bb2e06 (git): include/ruby/3/core/rtypeddata.h: Use 0 instead of NULL for C++ compiler
NULL in C++ is esoteric mame (Yusuke Endoh)
03:23 AM Revision 97f73bd0 (git): Ignore upper bits of pw_change on macOS too
nobu (Nobuyoshi Nakada)
03:12 AM Bug #6087: How should inherited methods deal with return values of their own subclass?
Recently this ticket was discussed at dev-meeting, and matz changed his mind. I remember that matz said:
* A meth...
mame (Yusuke Endoh)
01:56 AM Bug #16753: ruby -run -e httpd . -p 8080 , not support CJK directorys .
znz (Kazuhiro NISHIYAMA) wrote in #note-2:
> https://github.com/ruby/ruby/pull/2998
``` diff
--- filehandler.rb....
sevk (kk kk)
12:44 AM Revision f099bb04 (git): Ignore upper bits of pw_expire on macOS
`pw_expire` is declared as `time_t`, but actually not, and
`getpwuid` returns a garbage there.
Also the declaration ...
nobu (Nobuyoshi Nakada)
12:38 AM Revision 9af3469b (git): internal/bits.h: Suppress "uninitialized variable"
Coverity Scan says "Using uninitialized value c.fixnum when calling
__builtin_mul_overflow_p."
mame (Yusuke Endoh)
12:14 AM Revision 1a4f33e8 (git): numeric.c: Remove unreachable code
b cannot be <= 0 here. Found by Coverity Scan mame (Yusuke Endoh)

04/08/2020

11:55 PM Revision cdd613b2 (git): configure.ac: Skip C++ compiler of Sun OpenStudio
It fails to compile ext/-test-/cxxanyargs/cxxanyargs.cpp.
Need work to support it. Contribution is welcome.
mame (Yusuke Endoh)
11:19 PM Revision 8ab4c55e (git): include/ruby/3: Skip RUBY3_UNREACHABLE_RETURN for icc
I'm unsure why, but it fails on icc.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/icc-x64/ruby-master/log/2020040...
mame (Yusuke Endoh)
10:44 PM Revision a4021ecd (git): * 2020-04-09 [ci skip]
git[bot]
10:37 PM Revision 78eec3cd (git): include/ruby/3: Stop RUBY3_UNREACHABLE_RETURN to suppress a SunC warning
I don't find how to suppress a false positive "unreachable" warning of
the Sun compiler:
```
"./include/ruby/3/core/...
mame (Yusuke Endoh)
10:32 PM Bug #16771 (Closed): Segmentation fault when inspecting a bound method
This piece of code leads to a crash in ruby 2.7.1.
```ruby
bound_method = Kernel.instance_method(:respond_to?).bi...
decuplet (Nikita Shilnikov)
10:24 PM Bug #16770: Commit: RUBY3_HAS_BUILTIN: fix for nonexistent builtin - large increase in MinGW & mswin compile times
Is it due to that specific commit, or rather due to https://github.com/ruby/ruby/pull/2991 ? Eregon (Benoit Daloze)
01:20 PM Bug #16770 (Closed): Commit: RUBY3_HAS_BUILTIN: fix for nonexistent builtin - large increase in MinGW & mswin compile times
Inspecting logs both here and in ruby-loco, the following commit greatly increased compile time in MinGW builds:
h...
MSP-Greg (Greg L)
09:23 PM Feature #16254: MRI internal: Define built-in classes in Ruby with `__intrinsic__` syntax
@ko1 wrote in #note-5:
> Eregon (Benoit Daloze) wrote:
> > A common syntax for intrinsics/primitives would allow to s...
Eregon (Benoit Daloze)
06:35 PM Feature #16769: Struct.new(..., immutable: true)
Agreed, and @ioquatix and @headius seemed positive too in some recent discussion. Eregon (Benoit Daloze)
10:45 AM Feature #16769: Struct.new(..., immutable: true)
Makes sense. shevegen (Robert A. Heiler)
09:00 AM Feature #16769 (Rejected): Struct.new(..., immutable: true)
## Background
We've discussed interface to pass Struct attributes (like `immutable: true`, which is actually not add...
k0kubun (Takashi Kokubun)
04:49 PM Bug #16658: `method__cache__clear` DTrace hook was dropped without replacement
@Koichi could you please take a look, since your commit removed the hook. Thx vo.x (Vit Ondruch)
04:41 PM Feature #16688: Allow #to_path object as argument to system()
I think what would be useful is when interpolating Path like objects (`to_path`) that the path objects are shell esca... dsisnero (Dominic Sisneros)
01:41 PM Revision e7128aa7 (git): Disable deprecation error on mingw
nobu (Nobuyoshi Nakada)
01:32 PM Revision dd04b803 (git): RARRAY_EMBED_LEN/RSTRING_EMBED_LEN: add RUBY3_CAST
RUBY3_CAST is a macro to suppress g++/clang++ warnings about C-style
casts. Though Ruby core don't have to bother C+...
shyouhei (Shyouhei Urabe)
01:30 PM Revision ec1b3464 (git): RUBY3_HAS_BUILTIN: icc has broken __has_builtin
It turned out that compilation errors in icc were due to their having
broken __has_builtin. Let's just skip such sit...
shyouhei (Shyouhei Urabe)
09:33 AM Revision 8d622a58 (git): [ruby/weakref] Update TODO on README
https://github.com/ruby/weakref/commit/a67073856e hsbt (Hiroshi SHIBATA)
09:32 AM Bug #16337: kernel_gem.rb:68 - ThreadError
Great, let me know if you run into issues. deivid (David Rodríguez)
02:20 AM Bug #16337: kernel_gem.rb:68 - ThreadError
Sorry, I never got notifications about your posts. I was acting as the maintainer of google-fluentd, and trying to up... jkohen (Javier Kohen)
09:07 AM Misc #16693: DevelopersMeeting20200410Japan
* [Feature #16769] Struct.new(..., immutable: true) (k0kubun)
* I wanted it today, and found the discussion of [Fe...
k0kubun (Takashi Kokubun)
09:03 AM Revision 11d5a831 (git): Suppress C4244 "possible loss of data" warnings
nobu (Nobuyoshi Nakada)
07:28 AM Revision d8720eb7 (git): Suppress -Wshorten-64-to-32 warnings
nobu (Nobuyoshi Nakada)
07:18 AM Revision 6163a4e1 (git): RUBY3_HAS_BUILTIN: fix for nonexistent builtin
Trying to fix icc breakage:
https://rubyci.org/logs/rubyci.s3.amazonaws.com/icc-x64/ruby-master/log/20200408T050004Z....
shyouhei (Shyouhei Urabe)
06:59 AM Revision ba3b99b9 (git): The current net-http is only works with Ruby 2.6+
hsbt (Hiroshi SHIBATA)
06:51 AM Revision 3e8e4c05 (git): [ruby/net-ftp] Added guard condition for the old ruby versions
https://github.com/ruby/net-ftp/commit/a56ba121ee hsbt (Hiroshi SHIBATA)
06:50 AM Revision 0c131fb7 (git): [ruby/net-ftp] Guard with under the Ruby 2.6
https://github.com/ruby/net-ftp/commit/bed4bc31db hsbt (Hiroshi SHIBATA)
06:20 AM Revision 484ed0d2 (git): The current tempfile.rb is only works with Ruby 2.5+
hsbt (Hiroshi SHIBATA)
06:13 AM Revision e474c189 (git): Suppress -Wswitch warnings
nobu (Nobuyoshi Nakada)
05:33 AM Revision 3b1029f8 (git): Update the latest gemspec of prime.
* prime gem didn't use `version.rb` file.
* Removed development_dependency because they are handled by Gemfile.
hsbt (Hiroshi SHIBATA)
05:21 AM Revision 393789f3 (git): Update the version of published gemspec.
* It couldn't use `English` because `english` is already reserved.
* Bump version to 0.7.0 because versions < 0.7 a...
hsbt (Hiroshi SHIBATA)
04:28 AM Revision 9e6e39c3 (git): Merge pull request #2991 from shyouhei/ruby.h
Split ruby.h shyouhei (Shyouhei Urabe)
03:28 AM Revision 5ac4bf2c (git): [win32] Moved `MSC_VER` to verconf.mk and reduce running CPP
nobu (Nobuyoshi Nakada)
03:27 AM Feature #16763: MSVC: allow ranges for MSVC 2017 and 2019 support in win32/Makefile.sub
1. Are they completely binary compatible?
2. Only the last digit changes?
If it is expected from now on, I prefer...
nobu (Nobuyoshi Nakada)
02:51 AM Revision 8c8e64a2 (git): [win32] Removed useless macro name that isn't expanded in `#error`
nobu (Nobuyoshi Nakada)

04/07/2020

06:40 PM Bug #13671: Regexp with lookbehind and case-insensitivity raises RegexpError only on strings with certain characters
FYI The issue has been addressed in Onigmo https://github.com/k-takata/Onigmo/pull/116 and has already been released ... mauromorales (Mauro Morales)
04:21 PM Bug #16767 (Closed): Time#strftime not working correctly with a big precision on recurred formats like "%c"
Applied in changeset commit:git|2f1895fa15386fb3cdc91c5604171290828b9da8.
----------
Fixed formatted substring expan...
nobu (Nobuyoshi Nakada)
12:45 PM Bug #16767 (Closed): Time#strftime not working correctly with a big precision on recurred formats like "%c"
Confirmed on: Ruby 2.6.3 and 2.7.0 on Mac OS X 10.13.
```ruby
Time .now .strftime("%28c")
```
Expected:
```
...
dmikurube (Dai MIKURUBE)
04:13 PM Revision 2f1895fa (git): Fixed formatted substring expansion [Bug #16767]
nobu (Nobuyoshi Nakada)
03:18 PM Bug #16764: Module.const_source_location does not work on autoloaded constants
Prior to 2.6 don't have `Module#const_source_location`, but redefinition warning message has this location. nobu (Nobuyoshi Nakada)
03:06 PM Bug #16764 (Closed): Module.const_source_location does not work on autoloaded constants
Applied in changeset commit:git|927308108cced69cae478798004524b9a5d2f252.
----------
Fix source location of autoload...
nobu (Nobuyoshi Nakada)
03:06 PM Revision 17112581 (git): * 2020-04-08 [ci skip]
git[bot]
12:50 PM Bug #16768 (Rejected): "\n" started not to work as a delimiter in time zone names for Date._strptime since 2.7.0
Confirmed on: Ruby 2.7.0 on Mac OS X 10.13.
```
require 'date'
DateTime._strptime("aus\neastern standard time", ...
dmikurube (Dai MIKURUBE)
12:35 PM Revision 92730810 (git): Fix source location of autoloaded constant [Bug #16764]
nobu (Nobuyoshi Nakada)
11:20 AM Revision ce608213 (git): Removed unnecessary cast
nobu (Nobuyoshi Nakada)
06:44 AM Bug #16760 (Closed): backport #67305 / e39f7e64 to 2.6?
Thank you for pointing this out. I have confirmed the snippet reproduces SEGV with 2.6.6 on my laptop.
I will fill t...
nagachika (Tomoyuki Chikanaga)
04:59 AM Revision bc646e67 (git): [DOC] get rid of parsing as TIDYLINK unintentionally
nobu (Nobuyoshi Nakada)
04:01 AM Revision e73e4b3e (git): Bundler is not documented in RDoc, but something different
nobu (Nobuyoshi Nakada)
03:50 AM Revision bdf769bc (git): * 2020-04-07 [ci skip]
git[bot]
03:49 AM Revision 67f616c5 (git): Show the deprecated name in the warning
Fixed up a58bbd6a512d95ca010d8bebae4fe590400c1413. nobu (Nobuyoshi Nakada)
01:16 AM Bug #16669: Rails Action Text unit tests fail since b9007b6c548f91e88fd3f2ffa23de740431fa969
https://bugs.ruby-lang.org/projects/ruby-master/repository/git/revisions/2943ff9d4441485a18773aa745bab7f47767dde2 fix... kamipo (Ryuta Kamizono)
 

Also available in: Atom