Activity
From 08/21/2020 to 08/27/2020
08/27/2020
-
10:17 PM Bug #17031 (Closed): `Kernel#caller_locations(m, n)` should be optimized
- Applied in changeset commit:git|3b24b7914c16930bfadc89d6aff6326a51c54295.
----------
Improve performance of partial ... -
- Previously, backtrace_each fully populated the rb_backtrace_t with all
backtrace frames, even if caller only requeste... -
07:54 PM Revision 8095114f (git): Comply with guide for method doc: hash.c (#3466)
- Instance methods considered (most unchanged):
- any
- dig
- \<=
- \<
- \>=
- \>
- to_proc -
- Instance methods considered (maybe not all changed):
invert
merge!
merge
assoc
rassoc
flatte... -
05:16 PM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- Dan0042 (Daniel DeLorme) wrote in #note-21:
> Yeah ok, that sentence wasn't very clear, sorry.
>
> The first thin... -
04:55 PM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- Yeah ok, that sentence wasn't very clear, sorry.
The first thing is that when compiling a method to an iseq, you h... -
08:03 AM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- Dan0042 (Daniel DeLorme) wrote in #note-15:
>
> So a simpler approach would be to check if the match operation's s... -
02:10 AM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- Dan0042 (Daniel DeLorme) wrote in #note-17:
> Maybe not impossible, but personally I wouldn't want to code that kind... -
- Instance methods considered (maybe not all changed):
to_a
inspect
to_hash
to_h
keys
values
... -
- @zverok
Without `take` (or simply if `step` will have a block) this will be problematic.
But, agreed, good example. -
04:12 PM Feature #15573: Permit zero step in Numeric#step and Range#step
- > What is the purpose of a zero step? I cannot understand why/how it would be used.
> This is basically an infinit... -
- Dan0042 (Daniel DeLorme) wrote in #note-9:
> What is the purpose of a zero step? I cannot understand why/how it woul... -
- What is the purpose of a zero step? I cannot understand why/how it would be used.
-
- Mathematically, it is allowed that step can be 0, but from practical stand point - this is an infinite loop waiting t...
-
04:01 PM Revision 9658a5a8 (git): Show deprecation warning on TCPSocket.gethostbyname
-
04:00 PM Revision 5483bf8f (git): add T_ZOMBIE support to lldb scripts
-
- How about `all_equivalent?` or `all_duplicates?`?
-
- I would like the ruby team to reconsider this feature.
There is a high demand for this and a lot of implementations... -
- Applied in changeset commit:git|c60aaed1856b2b6f90de0992c34771830019e021.
----------
Fix Method#super_method for ali... -
- Applied in changeset commit:git|c60aaed1856b2b6f90de0992c34771830019e021.
----------
Fix Method#super_method for ali... -
- Previously, Method#super_method looked at the called_id to
determine the method id to use, but that isn't correct for... - 03:06 PM Revision f41bd0d7 (git): * 2020-08-28 [ci skip]
-
02:55 PM Revision 280d0281 (git): [ruby/stringio] Bump version to 0.1.4
- https://github.com/ruby/stringio/commit/64f2360d38
-
02:46 PM Revision f4b9e943 (git): [ruby/io-console] Bug 17128: In test_set_winsize_console, wrapped re-size in a begin-rescue-else.
- https://github.com/ruby/io-console/commit/a22333c33a
-
02:41 PM Revision b3c1c767 (git): [stringio] fix stringio codepoint enumerator off by one error
-
-
- Instance methods considered (some maybe not changed):
clear
[]=
replace
length
empty?
each_v... -
- merged: https://github.com/ruby/ruby/commit/2038cc6cab6ceeffef3ec3a765c70ae684f829ed
-
07:43 AM Misc #17041: DevelopersMeeting20200831Japan
- Adjust subject to match new date.
-
07:42 AM Revision 49001008 (git): sed -i '/rmodule.h/d'
-
- Only one function in only one file uses contents of this public header.
That is not a wise idea. Let's just free the... -
07:39 AM Revision 2038cc6c (git): Make Socket.getaddrinfo interruptible (#2827)
- Before, Socket.getaddrinfo was using a blocking getaddrinfo(3) call.
That didn't allow to wrap it into Timeout.timeou... -
07:33 AM Feature #17103: Add a :since option to ObjectSpace.dump_all
- That's a good point. I added:
> The current generation can be accessed using GC::count. -
12:19 AM Feature #17103: Add a :since option to ObjectSpace.dump_all
- I missed "allocation tracing disabled are not dumped" sentence. And changed version is more helpful.
Now I don't h... -
- Commit 7aab062ef3772c7e8e50fc872a1647918c76dbba says:
> ruby_show_version() will no longer exits the process, if
> R... -
-
- Remove all usages of RCAST() so that the header file can be excluded
from ruby/ruby.h's dependency. -
- We should not recommend RBIMPL_*.
-
- Nobody uses this macro any longer.
-
- It has been deprecated for 5 years since 1f2255604087e9a7d7efcb2df61b5ca0e2daa200.
-
05:42 AM Feature #17125 (Open): Remove Thread.exclusive
-
- Applied in changeset commit:git|3353baac3d55e1b42515ce7084e7b7f07abc0192.
----------
Use own mutex instead of Thread... -
- ref [Feature #17125]
-
-
-
- 05:08 AM Revision d9c93a0d (git): * 2020-08-27 [ci skip]
-
- Used from nowhere any longer.
-
-
-
-
03:21 AM Bug #17129: bundle install `eventmachine` and `sassc` fails since 914b2208ab3eddec478cdc3e079e6c30d0f0892c
- I think this issue has been resolved by https://github.com/ruby/ruby-docker-images/commit/6e36738aaea9caedc31372d5c3f...
-
> This is not a problem by itself. But a next mystery arises: how was it possible to compile eventmachine before, g...-
02:35 AM Bug #17129: bundle install `eventmachine` and `sassc` fails since 914b2208ab3eddec478cdc3e079e6c30d0f0892c
- I added g++ in the docker image. I confirmed this problem was fixed by the steps to reproduce described above. Thanks.
-
- Thank you!
https://gist.github.com/mrkn/1c2b8ad11810355ff916fd86af8317be#file-config-log-L1147-L1149
> ```
> con... -
- This is config.log produced by `rake docker:build ruby_version=master:914b2208ab3eddec478cdc3e079e6c30d0f0892c`.
htt... -
- Does this help to check `config.log`?
https://gist.github.com/yahonda/25231929b96c2eb5a6cb6df8862ac742 -
- > So, external input like JSON data is not the target of this proposal. Rather, this proposal is just a variant of St...
08/26/2020
-
- What about this?
```ruby
2.times do
p $~ # depends on match *below*
rx =~ str
end
```
Now imagine if ... -
- Dan0042 (Daniel DeLorme) wrote in #note-15:
> But static analysis has other limits
Good example but it is easily ... -
- > Couldn't static analysis of the code determine in most cases if match data need be generated or not?
scivola20 h... -
- fatkodima (Dima Fatko) wrote in #note-13:
> In many cases, probably yes, but again, `case-when`, when arguments/cons... -
- marcandre (Marc-Andre Lafortune) wrote in #note-12:
> Maybe it would be best to start a different thread as none of t... -
- Couldn't static analysis of the code determine in most cases if match data need be generated or not?
This is Ruby,... -
- sawa (Tsuyoshi Sawada) wrote in #note-10:
> I feel scivola20 (sciv ola)'s idea promising, but have a concern that it ... -
08:27 PM Bug #17048: Calling initialize_copy on live modules leads to crashes
- Yes, nobu's patch fixes the crash. It is technically a breaking change though, so maybe it needs approval from Matz?
... -
- The check for `to_int` in addition to `to_r` is deliberate. The related code comment states: `test to_int method ava...
-
05:49 PM Bug #17131 (Closed): Time.at(time) != time in certain cases
- ## Problem
According to the [spec](https://github.com/ruby/ruby/blob/445e5548c9da906a2d7a490e660328b2893d07d1/spec... -
- Pull request submitted: https://github.com/ruby/ruby/pull/3458
-
- Method#super_method currently does not work correctly for aliased methods. Here's a simple example:
```ruby
clas... -
- I'm able to reproduce this issue on Windows (`ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x64-mingw32]`), but not ...
-
-
-
09:05 AM Feature #17127: Some TrueClass methods are faster if implemented in Ruby
- these method able to speeding up implemented by Ruby code.
- `TrueClass#^`
- `TrueClass#&`
benchmark:
```yaml
benc... -
08:40 AM Misc #17041: DevelopersMeeting20200831Japan
- The meeting was postponed to the next Monday (31th Aug.) for some reason.
-
- * [Feature #16812] Allow slicing arrays with ArithmeticSequence (mrkn)
* I found the wrong test case, so the imple... -
- It only reproduces with Ruby using`rubylang/ruby:master-nightly-bionic`.
It does not reproduce ruby installed by `rb... -
- Is there a way for me to get the `config.log` which has to be created during compiling ruby itself? It must contain ...
-
- bundle install `eventmachine` and `sassc` fails since 914b2208ab3eddec478cdc3e079e6c30d0f0892c
Ruby on Rails CI ag... -
07:43 AM Feature #17104: Do not freeze interpolated strings when using frozen-string-literal
- Non-freezing interpolated strings is good thing to reduce allocations.
I think it is possible if most developers und... -
07:30 AM Feature #17125: Remove Thread.exclusive
- We checked gems which use this API and they look obsoleted.e
We should check the impact with preview.
Go ahead -
- It looks implementation detail and concurrent gems already supports new headers.
Go ahead -
- If we can accept the compatibility issue, I support it.
However, I'm not sure the "category" is a last attribute, so... -
- We discussed about it and I recognized the motivation is how to shorten the migration period (to reuse conflicts feat...
- 05:28 AM Revision 72cb9bc5 (git): [webrick][DOC] Describe the stance of WEBrick about its security and utilization (#3457)
- WEBrick is not recommended for the production use. We need to explicitly
describe this fact in the document to avoid... -
- Gauche scheme interpreter has same issue and Kawai-san (the author of Gauche) investigate it.
http://blog.practica...
08/25/2020
-
11:37 PM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- I feel scivola20 (sciv ola)'s idea promising, but have a concern that it is going to introduce the same kind of mess ...
-
- I have implemented a simple PoC - https://github.com/ruby/ruby/pull/3455.
I got the following results.
## Enume... -
- I like @scivola20 's idea and would like to try to implement it.
Before starting, @nobu, wdyt, is this something tha... -
- - [Feature #14723] python's buffer protocol clone (mrkn)
- I renamed `buffer` to `memory_view`.
- This na... -
-
- I think this was fixed by commit:92b2d5816ae04375cef7e3909bf69954e1833160.
-
- The pull request was merged (https://github.com/ruby/io-console/pull/16), so this can be closed.
-
- Methods reviewed (a few not modified):
key
delete
shift
delete_if
reject!
reject
slice
... -
05:50 PM Revision 92b2d581 (git): Add documentation to "dcompact" callback and "parent" member
-
05:14 PM Revision 326d89b7 (git): Correctly account for heap_pages_final_slots so it does not underflow
- `rb_objspace_call_finalizer` creates zombies, but does not do the correct accounting (it should increment `heap_pages...
- 03:47 PM Revision 8c030b5c (git): * 2020-08-26 [ci skip]
-
- Methods:
::new
::[]
::try_convert
#rehash
#[]
#fetch
#default
#default=
#default... -
12:17 PM Revision 2e3a7f70 (git): Promote nkf to default gems
- 09:11 AM Revision 8d68f54c (git): Fix erb executable
- Run ERb processing unconditionally since __FILE__ and $0 doesn't match
in a gem context.
08/24/2020
-
-
- Applied in changeset commit:git|9e25eb308d4fae9a10e120c2b4601916cc38336c.
----------
Update PTY.open documentation t... - 11:11 PM Revision 1b34d843 (git): * 2020-08-25 [ci skip]
-
- For a regular block, accepting two arguments is fine as the array
will be autosplatted. However, a lambda that acce... -
- I've added a pull request with a fix for this: https://github.com/ruby/ruby/pull/3452
-
- The enabled-by-default deprecation warnings have following effects.
- Good Effect: It makes developers more aware of... -
- +1
I think this is more important than having a general Set syntax as discussed in #5478. Being able to use `%ws[fo... -
- > matz: Positive to introduce Set into core. But we need to first introduce a set literal. { x, y, z } is good, but J...
-
- That's great news.
Was there discussion for a *frozen* set literal of symbols / strings as I proposed in #16994? F... -
- We discussed this issue at the last-month meeting.
https://github.com/ruby/dev-meeting-log/blob/master/DevelopersM... -
- k0kubun (Takashi Kokubun) wrote in #note-3:
> off topic: If you write an entire ticket in English, I think you shoul... -
- Dan0042 (Daniel DeLorme) wrote in #note-37:
> > I thought that this would be a useful substitute of symbol-key Hash ... -
- > I thought that this would be a useful substitute of symbol-key Hash (like JSON data) which we can read the values b...
-
- 👍
I'd like to have optional `start` and `stop` arguments for `find_index`, `find`, `bsearch` and `bsearch_index`.
... -
-
- > this feature strongly connected with trace_object_allocations, right?
Indeed.
> so please write it on documen... -
- this feature strongly connected with `trace_object_allocations`, right? so please write it on document.
what happens... -
-
-
- Without the patch:
```ruby
require "digest"
p Digest::SHA256 #=> Digest::SHA256
p Digest::SHA2 #=> Digest::SH...
08/23/2020
-
09:07 PM Feature #6309: Add a reference queue for weak references
- This still seems like a good idea. Any update?
- 05:10 PM Revision f292bb24 (git): * 2020-08-24 [ci skip]
-
- Further compliance with https://github.com/ruby/ruby/blob/master/doc/method_documentation.rdoc#details-and-examples-
-
- 12:46 PM Revision 4f7ff9c9 (git): * 2020-08-23 [ci skip]
-
- Added some cross compilers that we can run on GitHub Workflow runner
environments. Because they are cross compilers ... -
- > > When it comes to optimization, though, I would assume that the keywords are all symbols would open a lot more doo...
08/22/2020
-
09:59 AM Bug #16853: calling bla(hash, **kw) with a string-based hash passes the strings into **kw (worked < 2.7)
- FWIW I also find the `where("table.id" => 42)` example unconvincing.
That could work just fine with `def where(condi... -
- sylvain.joyeux (Sylvain Joyeux) wrote in #note-9:
> Keyword splat would not allow anything but symbols as keys pre-2... -
- They are rather annoying than being useful to us.
-
02:54 AM Feature #15974: Warn in verbose mode on defining a finalizer that captures the object
- A partial solution to this but with a better implementation is at https://github.com/ruby/ruby/pull/3444.
-
- It seems `clang --save-temps` does not interface well with
tool/update-deps. Prefer gcc for that purpose. -
- STRIP now depends on compilers, not on OS. Previous check against
$target_os does no longer work. -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/freebsd12/ruby-master/log/20200821T223002Z.fail.html.gz
```
process.c...
08/21/2020
-
- Applied in changeset commit:git|a0273d67d044dc9fe25313e0854a33374b990e8a.
----------
Avoid a use after free in VM as... -
- I think I've found a solution. If the thread for the EC has been killed, then don't check that the VM pointer matche...
-
- If the thread for the current EC has been killed, don't check
the VM ptr for the EC (which gets it via the thread), a... -
- "Trivial" typically means "returns a new empty Array."
-
08:37 PM Bug #16853: calling bla(hash, **kw) with a string-based hash passes the strings into **kw (worked < 2.7)
- > If there is a call like foo(**h), and h has both Symbol and non-Symbol keys, in <2.7 the Hash is "split" which I fi...
-
06:37 PM Feature #17127: Some TrueClass methods are faster if implemented in Ruby
- off topic: If you write an entire ticket in English, I think you should post your ticket to ruby-core to attract more...
-
- Most of the CI issues were when running with asserts, so I compiled with asserts enabled and ran tests. It took quit...
-
- * Remove nil-return examples from hash.c
-
- Jeremy, thank you for the suggestion! I will do that now.
-
- leam (Leam Hall) wrote in #note-1:
> I have opened Bug 17128, to handle an edge case in a test. I have
> working ... -
- I have opened Bug 17128, to handle an edge case in a test. I have
working code to fix the issue, but am still lear... -
- When running "make test-all TESTS=io/console/test_io_console" on the current Ruby source, the following error is gene...
-
- CI failures observed for old Sun C++. We don't want to hustle, as newer
versions are okay. Just check the sanity an... -
- AC_PROG_CC_C99 calls AC_PROC_CC, which calls _AC_PROG_CC_G, which sets
default CFLAGS, whose contents are not customi... - 03:33 PM Revision 7263fd6f (git): * 2020-08-22 [ci skip]
-
- `llvm-strip-7` is a sane valid strip command that LLVM 7 ships, albeit
it does not understand `--version`. It is a b... -
02:22 PM Feature #17016: Enumerable#accumulate
- I'd like to propose that we name this method `#accumulate`. @matz do you think that is an acceptable name?
-
-
-
-
-
- At first, I misunderstood this feature. I thought that this would be a useful substitute of symbol-key Hash (like JS...
-
- In case of cross-compilation, GCC might provide its own linker. Its
behaviour seems slightly different from that of ... -
- Caused CI failures on environments without sane C++ compilers.
-
- Historically `$program_transform_name` has been put in front of
`AC_CANONICAL_TARGET`. Previous commit changes it, w... -
- These days as link-time optimisations spread accross compilers, they
tend to ship their own version of ld, ar, etc. ... -
- Because we check HAVE_STMT_AND_DECL_IN_EXPR in configure, it is peoven
to work in C. But C++ situation can be differ... -
- I found a way to suppress particular kind of warnings via pragmas.
-
- Oracle Developer Studio's C++ preprocessor started to understand
__has_cpp_attribute since version 12.5, and is broke... -
Also available in: Atom