Project

General

Profile

Activity

From 09/30/2021 to 10/06/2021

10/06/2021

09:03 PM Bug #18232: Ractor.make_shareable is broken in code loaded with RubyVM::InstructionSequence.load_from_binary
I've attached a patch that fixes this (for me) along with a test. I had to change the information that we dump when ... tenderlovemaking (Aaron Patterson)
06:47 PM Bug #18232: Ractor.make_shareable is broken in code loaded with RubyVM::InstructionSequence.load_from_binary
It looks like the [outer variables list](https://github.com/ruby/ruby/blob/e4d85d3a2d0c7d4a1abf981fb1ba557e21cad968/v... tenderlovemaking (Aaron Patterson)
06:38 PM Bug #18232: Ractor.make_shareable is broken in code loaded with RubyVM::InstructionSequence.load_from_binary
(this comment was moved to https://bugs.ruby-lang.org/issues/18243, replied to the wrong issue) Eregon (Benoit Daloze)
06:31 PM Bug #18232: Ractor.make_shareable is broken in code loaded with RubyVM::InstructionSequence.load_from_binary
FYI the way it currently works for OpenStruct seems buggy on the Ractor side: #18243 Eregon (Benoit Daloze)
09:22 AM Bug #18232: Ractor.make_shareable is broken in code loaded with RubyVM::InstructionSequence.load_from_binary
Because [OpenStruct was recently changed to use `make_shareable`](https://github.com/ruby/ostruct/pull/29), this bug ... byroot (Jean Boussier)
08:58 PM Feature #10883 (Closed): Passing a block to itself
jeremyevans0 (Jeremy Evans)
08:56 PM Feature #18242: Parser makes multiple assignment sad in confusing way
jeremyevans0 (Jeremy Evans) wrote in #note-1:
> [...] Attached is a patch that implements the necessary parser rules...
danh337 (Dan H)
04:28 PM Feature #18242: Parser makes multiple assignment sad in confusing way
The parser is currently not setup to handle this, so I don't think it is a bug. You would have to add new parser rul... jeremyevans0 (Jeremy Evans)
04:39 AM Feature #18242 (Open): Parser makes multiple assignment sad in confusing way
Example:
``` ruby
a, b = 2, 1 if 1 < 2 # Works
a, b = [2, 1] if 1 < 2 # Works
(a, b) = 2, 1 if 1 ...
danh337 (Dan H)
08:51 PM Revision fb122042 (git): Enhanced RDoc for Enumerable (#4941)
Treated:
#sum
#uniq
#compact
burdettelamar (Burdette Lamar)
08:45 PM Feature #9999 (Closed): Type Annotations (Static Type Checking)
jeremyevans0 (Jeremy Evans)
08:43 PM Feature #9635 (Closed): Map a hash directly to a hash
jeremyevans0 (Jeremy Evans)
08:42 PM Feature #9322 (Closed): method_defined? family of of methods should support the exclusion of ancestors
jeremyevans0 (Jeremy Evans)
08:37 PM Feature #8977 (Closed): String#frozen that takes advantage of the deduping
jeremyevans0 (Jeremy Evans)
08:36 PM Feature #8953 (Closed): `str =~ /pattern/` does not call =~ method if (1) str is a String, (2) /pattern/ is a Regexp literal
This was fixed in Ruby 2.2:
```
$ ruby22 -ve 's = "foo"; class << s; def =~ (rhs); raise "a"; end; end; s =~ /foo...
jeremyevans0 (Jeremy Evans)
08:32 PM Feature #8895 (Closed): Destructuring Assignment for Hash
jeremyevans0 (Jeremy Evans)
08:20 PM Feature #7793 (Closed): New methods on Hash
This feature was implemented as `transform_keys`, `transform_values`, and `to_h`. jeremyevans0 (Jeremy Evans)
08:20 PM Feature #9970 (Closed): Add `Hash#map_keys` and `Hash#map_values`
This feature was implemented as `transform_keys`, `transform_values`, and `to_h`. jeremyevans0 (Jeremy Evans)
07:41 PM Feature #6669 (Closed): A method like Hash#map but returns hash
This was implemented by `Hash#to_h` taking a block starting in Ruby 2.6. jeremyevans0 (Jeremy Evans)
07:38 PM Bug #18023 (Closed): Ractor#make_shareable changes the values of closured shareable objects
Applied in changeset commit:git|76228191474c76810043b294a74bbb2f1808b3d9.
----------
Fix Ractor.make_shareable chang...
alanwu (Alan Wu)
07:38 PM Revision 121424a0 (git): * 2021-10-07 [ci skip]
git[bot]
07:38 PM Revision 76228191 (git): Fix Ractor.make_shareable changing locals for Procs
env_copy() uses rb_ary_delete_at() with a loop counting up while
iterating through the list of read only locals. rb_a...
alanwu (Alan Wu)
06:39 PM Bug #18243: Ractor.make_shareable does not freeze the receiver of a Proc but allows accessing ivars of it
Smaller repro:
```
$ ruby -e 'Object.new.instance_eval { p object_id; proc = Ractor.make_shareable -> { self }; Rac...
Eregon (Benoit Daloze)
06:29 PM Bug #18243 (Closed): Ractor.make_shareable does not freeze the receiver of a Proc but allows accessing ivars of it
```ruby
class C
attr_accessor :foo
def setter_proc
Ractor.make_shareable(-> v { @foo = v })
end
end
...
Eregon (Benoit Daloze)
05:19 PM Feature #6414 (Closed): Destructuring Assignment
This proposal has basically been implemented, with single-line pattern matching and valueless hash creation syntax:
...
jeremyevans0 (Jeremy Evans)
03:59 PM Bug #18234: exit after `binding.irb`
I submitted a pull request to irb to fix this by calling super if UncaughtThrowError is raised by IRB::Context#exit: ... jeremyevans0 (Jeremy Evans)
12:46 PM Feature #12075: some container#nonempty?
Probably not, considering that some classes I named earlier, File::Stat and Enumerator, only have #size and no #lengt... knu (Akinori MUSHA)
11:19 AM Feature #12075: some container#nonempty?
If `size?` will be chosen, should we also add `length?` as `size` and `length` are aliases? p8 (Petrik de Heus)
06:42 AM Revision d5349371 (git): Add the dependency of GNUmakefile itself [ci skip]
nobu (Nobuyoshi Nakada)
05:01 AM Revision 702a58e9 (git): Remove duplicate type qualifiers
`rb_encoding` is defined as `const OnigEncodingType`.
Fix lots of C4114 warnings for each files by MSVC.
nobu (Nobuyoshi Nakada)
03:19 AM Revision 7ed1180e (git): Remove the useless platform guard
nobu (Nobuyoshi Nakada)
02:41 AM Revision ddca0c66 (git): Fix filesystem dependent tests
Ruby cannot guarantee the resolutions of underlying filesystems. nobu (Nobuyoshi Nakada)

10/05/2021

11:57 PM Revision abd47392 (git): Enhanced RDoc for Enumerable (#4938)
Treats:
#slice_after
#slice_when
#chunk_while
burdettelamar (Burdette Lamar)
05:41 PM Revision b9f34062 (git): Update to ruby/spec@ccf0d85
Eregon (Benoit Daloze)
04:34 PM Revision afcbb501 (git): marshal.c Marshal.load accepts a freeze: true option.
Fixes [Feature #18148]
When set, all the loaded objects are returned as frozen.
If a proc is provided, it is called...
byroot (Jean Boussier)
04:31 PM Feature #18148 (Closed): Marshal.load freeze option
Applied in changeset commit:git|afcbb501ac17ba2ad5370ada5fd26e8dda9a5aaa.
----------
marshal.c Marshal.load accepts ...
byroot (Jean Boussier)
03:52 PM Revision 279b2b5b (git): Enhanced RDoc for Enumerable#slice_before (#4932)
* Enhanced RDoc for Enumerable#slice_before
* Enhanced RDoc for Enumerable#slice_before
burdettelamar (Burdette Lamar)
03:41 PM Bug #18241 (Closed): Question on String Concatentation Documentation
Applied in changeset commit:git|c6706f15af123bdbb3b39a21903d85c78462d047.
----------
Fix documentation for String#{<...
jeremyevans (Jeremy Evans)
03:31 PM Bug #18241: Question on String Concatentation Documentation
This is a documentation bug. Both String#<< and String#concat mutate and return the receiver. I'll fix this shortly. jeremyevans0 (Jeremy Evans)
03:22 PM Bug #18241: Question on String Concatentation Documentation
edit: to be clear, I'm making a distinction between "new string" in the contents-sense, and "new string" in the memor... hernanat (Anthony Hernandez)
03:18 PM Bug #18241 (Closed): Question on String Concatentation Documentation
Hello,
I noticed that the documentation for `<<` and `concat` both state that the result of each operation is a ne...
hernanat (Anthony Hernandez)
03:41 PM Revision f883f550 (git): * 2021-10-06 [ci skip]
git[bot]
03:40 PM Revision 1bf3f3f4 (git): * remove trailing spaces. [ci skip]
git[bot]
03:39 PM Revision c6706f15 (git): Fix documentation for String#{<<,concat,prepend}
These methods mutate and return the receiver, they don't create
and return a new string.
Fixes [Bug #18241]
jeremyevans (Jeremy Evans)
03:37 PM Bug #18240 (Closed): Random segfault on a local Rails server
jeremyevans0 (Jeremy Evans)
03:33 PM Bug #18240: Random segfault on a local Rails server

Thanks Jeremy for your answer. We're gonna try to disable the C extensions one by one to identify if one behaves ba...
Benoit_Tigeot (Benoit Tigeot)
02:43 PM Bug #18240: Random segfault on a local Rails server
Unfortunately, I don't think there is enough information provided to help diagnose the specific cause of the issue (t... jeremyevans0 (Jeremy Evans)
08:52 AM Bug #18240 (Closed): Random segfault on a local Rails server
Hello
I am having random segfault locally when rails a basic rails app.
The control frame is weird:
| -- Co...
Benoit_Tigeot (Benoit Tigeot)
03:10 PM Feature #18239: Variable Width Allocation: Strings
Regarding ABI compatibility, AFAIK CRuby doesn't care about it for development versions.
I.e., conceptually we can t...
Eregon (Benoit Daloze)
01:08 PM Feature #18239: Variable Width Allocation: Strings
Hi @duerst. Thank you for adding it to the developer meeting.
I understand your concern for gem incompatibility. S...
peterzhu2118 (Peter Zhu)
02:22 PM Revision f2ca6526 (git): debug.gem v1.2.4
This version fixes test failures on MacOS enviornment. ko1 (Koichi Sasada)
01:33 PM Revision dc8fa269 (git): [ruby/reline] Reduce window size so that it can be displayed in my desktop
https://github.com/ruby/reline/commit/22359d50ab aycabta (aycabta .)
01:33 PM Revision f625645a (git): [ruby/reline] The width of block elements is 1 on Windows
https://github.com/ruby/reline/commit/5f4a75c7a0 aycabta (aycabta .)
01:33 PM Revision 2c2a017f (git): [ruby/reline] Cyrillic chars are now forced to be displayed in full-width on Windows
So testing is no longer necessary.
https://github.com/ruby/reline/commit/c59589548b
aycabta (aycabta .)
01:32 PM Revision 6966c3ff (git): [ruby/reline] Change struct size correctly
https://github.com/ruby/reline/commit/df2a1b4e08 aycabta (aycabta .)
09:24 AM Revision 7c98e673 (git): Fix a typo since 688f2e1a893e04457a1a5aa3577b13f74b2bc080
nobu (Nobuyoshi Nakada)
08:14 AM Revision cd182c5e (git): Adjust types to rb_enc_left_char_head
I dislike unnatural casts. nobu (Nobuyoshi Nakada)
07:59 AM Revision a15996c7 (git): Split parser_yyerror0 from parser_yyerror
The former uses the current location, while the latter takes a
non-null location.
nobu (Nobuyoshi Nakada)
07:44 AM Revision 1f544d67 (git): Show the last line at unexpected end-of-input error
nobu (Nobuyoshi Nakada)
06:56 AM Revision 5a961c37 (git): Remove a redundant cast between the exact same types
nobu (Nobuyoshi Nakada)
06:00 AM Revision 126122bb (git): Replace inaccurate error messages
When Bison reports "memory exhausted", it means the parser stack
depth reached the limit `YYMAXDEPTH` which is defaul...
nobu (Nobuyoshi Nakada)
05:58 AM Revision 0553494a (git): debug.gem 1.2.3
This version uses tempdir instead of homedir to store UNIX domain
socket.
ko1 (Koichi Sasada)
05:18 AM Revision f032c09b (git): rb_enc_left_char_head(): take void*
Nobu doesn't like (char*) cast. shyouhei (Shyouhei Urabe)
05:18 AM Revision 499660b0 (git): downcase_single/upcase_single: assume ASCII
These functions assume ASCII compatibility. That has to be ensured in
their caller.
shyouhei (Shyouhei Urabe)
05:18 AM Revision 5c167a97 (git): ruby tool/update-deps --fix
shyouhei (Shyouhei Urabe)
05:18 AM Revision 5112a548 (git): include/ruby/encoding.h: convert macros into inline functions
Less macros == huge win. shyouhei (Shyouhei Urabe)
05:18 AM Revision 312668cf (git): split include/ruby/encoding.h
2,291 lines are too much! include/ruby/encoding.h became the biggest
header file once it had doxygen comments. Let ...
shyouhei (Shyouhei Urabe)
05:18 AM Revision 2fa4715b (git): rb_ractor_shareable_p(): fix doxygen
My bad. The document is clearly broken. Maybe I pressed my delete key
too much. [ci skip]
shyouhei (Shyouhei Urabe)
05:18 AM Revision e42c8c16 (git): add undeclared variables
Why did they even exist? shyouhei (Shyouhei Urabe)
04:30 AM Revision ee89543e (git): Fix regression on Solaris after change to use realpath on loaded features
After the change to use realpath on loaded features, Solaris CI
started failing in test_no_curdir (which tests behavi...
jeremyevans (Jeremy Evans)
04:06 AM Revision 16ce578d (git): Enable inline assembly of SET_MACHINE_STACK_END on AIX
Rei Odaira

10/04/2021

11:55 PM Feature #18239: Variable Width Allocation: Strings
This is impressive work. I haven't time to study all the details, in particular the benchmark results.
But I'm som...
duerst (Martin Dürst)
08:18 PM Feature #18239: Variable Width Allocation: Strings
Ah, fool question. Sorry. It was arguments on rdoc benchmark (I misunderstood that it is for general characteristics). ko1 (Koichi Sasada)
08:17 PM Feature #18239: Variable Width Allocation: Strings
Yes, [rdoc generation](#rdoc-generation). Speed is 0.95x but memory usage dropped to 0.81x (0.89x for jemalloc). peterzhu2118 (Peter Zhu)
08:15 PM Feature #18239: Variable Width Allocation: Strings
> The performance decrease is small but the memory decrease is large.
Sorry, which results do you say? rdoc genera...
ko1 (Koichi Sasada)
08:13 PM Feature #18239: Variable Width Allocation: Strings
Your concerns about memory usage and performance are all valid. A solution is we could make VWA enabled by default bu... peterzhu2118 (Peter Zhu)
08:07 PM Feature #18239: Variable Width Allocation: Strings
> I can't make good reason why VWA is slower than FWA on your benchmark.
The only benchmark above where VWA is slo...
peterzhu2118 (Peter Zhu)
07:16 PM Feature #18239: Variable Width Allocation: Strings
* Performance:
* P4. `GC.compact` can be slower than FWA because it should be copy the body. But maybe it is not a...
ko1 (Koichi Sasada)
07:09 PM Feature #18239: Variable Width Allocation: Strings
Thank you for your reply.
peterzhu2118 (Peter Zhu) wrote in #note-3:
> - The RString layout does not change much....
ko1 (Koichi Sasada)
06:57 PM Feature #18239: Variable Width Allocation: Strings
Sorry for incremental questions.
Why do we need to enable it now? Current benchmark you showed illustrate not so dif...
ko1 (Koichi Sasada)
06:49 PM Feature #18239: Variable Width Allocation: Strings
Hi @ko1, thank you for the feedback.
- The RString layout does not change much. The only big change is that the le...
peterzhu2118 (Peter Zhu)
06:32 PM Feature #18239: Variable Width Allocation: Strings
ko1 (Koichi Sasada) wrote in #note-1:
> * Could you explain the variable size page strategy? https://bugs.ruby-lang....
ko1 (Koichi Sasada)
06:29 PM Feature #18239: Variable Width Allocation: Strings
Thank you for your work. I have several questions.
* Could you explain the RString layout?
* Could you explain th...
ko1 (Koichi Sasada)
06:13 PM Feature #18239 (Closed): Variable Width Allocation: Strings
# GitHub PR: https://github.com/ruby/ruby/issues/4933
# Feature description
Since merging #18045 which introduc...
peterzhu2118 (Peter Zhu)
11:52 PM Misc #18174: DevelopersMeeting20211021Japan
- [Feature #18239] Variable Width Allocation: Strings
- Discuss deployment schedule and binary incompatibility iss...
duerst (Martin Dürst)
05:51 PM Revision e4d85d3a (git): Revert rescue around internal realpath call on Solaris
Solaris CI still has a problem even with these commits, so it doesn't
appear to fix the issue. Reverting both 84e8e2...
jeremyevans (Jeremy Evans)
05:20 PM Feature #18231: `RubyVM.keep_script_lines`
Some comments:
* For debugger, `Thread::Backtrace::Location#script_lines` is enough.
* If we introduce this featu...
ko1 (Koichi Sasada)
04:51 PM Feature #18231: `RubyVM.keep_script_lines`
I clarified a bit with @ko1.
First, `script_lines` returns all lines, not the lines of a specific method (I missed t...
Eregon (Benoit Daloze)
03:02 PM Feature #18231: `RubyVM.keep_script_lines`
> For what else do you need to get the source? Ruby::AbstractSyntaxTree::Node?
> How do you get the Ruby::AbstractSy...
ko1 (Koichi Sasada)
12:38 PM Feature #18231: `RubyVM.keep_script_lines`
ko1 (Koichi Sasada) wrote in #note-13:
> Do you talking about `toSource` method in JS?
Yeah it's JS Function's `t...
Eregon (Benoit Daloze)
12:29 PM Feature #18231: `RubyVM.keep_script_lines`
Eregon (Benoit Daloze) wrote in #note-12:
> We already have something similar to "code locations" objects: `Thread::...
ko1 (Koichi Sasada)
09:38 AM Feature #18231: `RubyVM.keep_script_lines`
We already have something similar to "code locations" objects: `Thread::Backtrace::Location`.
We could add `#{first,...
Eregon (Benoit Daloze)
03:05 AM Feature #18231: `RubyVM.keep_script_lines`
I don't want to bother progressing here, so I accept `RubyVM.keep_script_lines` with the indication of implementation... matz (Yukihiro Matsumoto)
05:07 PM Revision bc96a45f (git): introduce debug.gem
For the `test-bundled-gems`, make `debug.so` with extconf.rb and
`make` command directly because `rake-compiler` assu...
ko1 (Koichi Sasada)
05:07 PM Revision ae1da7e1 (git): remove lib/debug.rb
ko1 (Koichi Sasada)
05:07 PM Revision cbb11521 (git): Enabled to build extensions with the bundled gems
hsbt (Hiroshi SHIBATA)
04:43 PM Feature #18026 (Closed): Add global variables for instruction information
Applied in changeset commit:git|b44c5187b4d05d8644242e532f2243210d0b74df.
----------
Expose instruction information ...
nobu (Nobuyoshi Nakada)
04:43 PM Revision 3381fa54 (git): Only rescue realpath calls during require on Solaris
Remove temporary skip of test_no_curdir to see if this fixes the
problem.
jeremyevans (Jeremy Evans)
04:43 PM Revision d9b74037 (git): Use a rescue around the internal realpath call for each loaded feature
This appears to be only necessary on Solaris, but this commit
enables it unconditionally to test breakage. The follo...
jeremyevans (Jeremy Evans)
04:43 PM Revision b44c5187 (git): Expose instruction information for debuggers [Feature #18026]
nobu (Nobuyoshi Nakada)
03:41 PM Revision aa2a1fb0 (git): * 2021-10-05 [ci skip]
git[bot]
03:41 PM Revision 8dc546b6 (git): Enhanced RDoc for Enumerable#chunk (#4930)
burdettelamar (Burdette Lamar)
11:46 AM Revision c4570acc (git): Refactor ordering of tests
* Split the sorting types into classes.
* Apply the same sorting to method sorting under the parallel
test.
nobu (Nobuyoshi Nakada)
11:44 AM Revision 44b2e32f (git): Fix a typo
nobu (Nobuyoshi Nakada)
11:04 AM Revision 3842e723 (git): Leave builddir absolute
So that rubygems installer will work to build extension gems. nobu (Nobuyoshi Nakada)
11:03 AM Revision bac6e8ca (git): Stop building extension gems for now
Extension gems will be installed by the installed standard
libraries.
nobu (Nobuyoshi Nakada)
08:43 AM Bug #18238 (Third Party's Issue): CSV encoding issue with parsing from Zlib::GzipReader stream
Could you open this on https://github.com/ruby/csv ? ruby/csv is the upstream of csv. kou (Kouhei Sutou)
08:41 AM Bug #18238 (Third Party's Issue): CSV encoding issue with parsing from Zlib::GzipReader stream
Hi,
I found an issue with parsing CSVs directly from a `Zlib::GzipReader` IO which I am trying to debug. Unfortuna...
dim (Dimitrij Denissenko)
03:37 AM Revision e8dde463 (git): Relax time-out for bundler
nobu (Nobuyoshi Nakada)
03:16 AM Revision 28392d30 (git): The same warning for static symbol literal
nobu (Nobuyoshi Nakada)
03:16 AM Revision da139317 (git): Fix the warning message for dynamic symbol literal in condition
nobu (Nobuyoshi Nakada)
03:16 AM Revision e25ad547 (git): Shorten timeouts on macOS and MinGW
From recent results, `check` and `test-all` will finish within 10
minutes on macOS or 30 minutes on MinGW, otherwise...
nobu (Nobuyoshi Nakada)
12:38 AM Feature #14975 (Rejected): String#append without changing receiver's encoding
Closing since this seems not acceptable.
Feel free to reopen if any progress.
nobu (Nobuyoshi Nakada)
12:37 AM Revision 31332cf4 (git): [ruby/irb] Fix typo of variable
https://github.com/ruby/irb/commit/692eb9b9b5 aycabta (aycabta .)

10/03/2021

11:21 PM Revision e54d1e99 (git): Move rb_ractor_p definition
S_H_ (Shun Hiraoka)
11:15 PM Revision 3f5b52bf (git): Function `w32_error` does not return
xtkoba (Tee KOBAYASHI)
11:13 PM Revision 0cf91979 (git): Clang never evaluates expr in `__builtin_assume`
xtkoba (Tee KOBAYASHI)
03:14 PM Revision 76138316 (git): * 2021-10-04 [ci skip]
git[bot]
03:14 PM Revision 1e9714cf (git): [ruby/reline] Use default background color to erase on Windows
https://github.com/ruby/reline/commit/852e855d82 aycabta (aycabta .)
01:34 PM Revision dc9112cf (git): Using NIL_P macro instead of `== Qnil`
S_H_ (Shun Hiraoka)
01:16 PM Bug #18237 (Closed): Remove unnecessary checks for `Time` in `Range#each` as per the comment
Applied in changeset commit:git|fb03598666ddbb9f8b35eb4f599e75654ca7ca06.
----------
Remove unnecessary checks in `R...
Anonymous
11:50 AM Bug #18237 (Closed): Remove unnecessary checks for `Time` in `Range#each` as per the comment
In commit:7817a438eb1803e7b3358f43bd1f38479badfbdc, the implementation of `Time#succ`, which had been deprecated for ... jwmittag (Jörg W Mittag)
01:16 PM Revision fb035986 (git): Remove unnecessary checks in `Range#each` [Bug #18237]
In commit:7817a438eb1803e7b3358f43bd1f38479badfbdc, the implementation
of `Time#succ`, which had been deprecated for ...
Jörg W Mittag
01:06 PM Bug #18236 (Closed): Conversion to float not working for object with to_f method
Applied in changeset commit:git|19f9d9cf739e7fc185ef90d5da5b4b12cf902a52.
----------
Remove extraneous conversion to...
nobu (Nobuyoshi Nakada)
01:06 PM Revision 19f9d9cf (git): Remove extraneous conversion to float [Bug #18236]
nobu (Nobuyoshi Nakada)
12:51 PM Revision 853ca5cc (git): [ruby/irb] Remove `require` in signal handler to avoid ThreadError
`rdoc` has been required so it looks unnecessary
https://github.com/ruby/irb/commit/5f749c613c
pocke (Masataka Kuwabara)
12:51 PM Revision 64e96d6b (git): [ruby/reline] Re-calc the scroll pos when the content in dialog is shortened
https://github.com/ruby/reline/commit/12ea63e6e0 aycabta (aycabta .)
12:50 PM Revision 208b7b81 (git): [ruby/irb] Version 1.3.8.pre.10
https://github.com/ruby/irb/commit/15bcbbb284 aycabta (aycabta .)
12:50 PM Revision a5c58e88 (git): [ruby/irb] Update dependency, reline >= 0.2.8.pre.10
https://github.com/ruby/irb/commit/800e83eabd aycabta (aycabta .)
12:48 PM Revision 7f02cc50 (git): [ruby/reline] Version 0.2.8.pre.10
https://github.com/ruby/reline/commit/1c6c0c82f0 aycabta (aycabta .)
12:38 PM Revision 6cb37d41 (git): [ruby/reline] Initialize @trap_key to suppress warning
https://github.com/ruby/reline/commit/b42c0980d9 aycabta (aycabta .)
12:25 PM Feature #18035: Introduce general model/semantic for immutability.
I forgot to mention, it's also much better if all instances of a class (and potential subclasses) are immutable, if o... Eregon (Benoit Daloze)
12:21 PM Feature #18035: Introduce general model/semantic for immutability.
I think nobody expects #freeze or #deep_freeze to ever freeze (non-singleton) classes/modules, so IMHO these methods ... Eregon (Benoit Daloze)
09:59 AM Feature #18231: `RubyVM.keep_script_lines`
duerst (Martin Dürst) wrote in #note-8:
> Can you say exactly what the problem is? Is it that the file may get chang...
Eregon (Benoit Daloze)
09:53 AM Feature #18231: `RubyVM.keep_script_lines`
ko1 (Koichi Sasada) wrote in #note-6:
> > I would think having code_location on exceptions and methods is also enoug...
Eregon (Benoit Daloze)
08:31 AM Feature #18231: `RubyVM.keep_script_lines`
Eregon (Benoit Daloze) wrote in #note-5:
> I am strongly against this proposal as it currently stands.
> For `err...
duerst (Martin Dürst)
09:41 AM Revision bf4f3ef5 (git): [ruby/reline] Add a comment to use "private alias_method" idiom after drop Ruby 2.5
https://github.com/ruby/reline/commit/1b00cae0fd aycabta (aycabta .)
09:31 AM Bug #18235 (Closed): try_var in mkmf.rb recognizes a variable that is not declared
Applied in changeset commit:git|ea64e742f5feddbdfb6526cd0a54a9986097a34d.
----------
Revert "mkmf.rb: try linking at...
nobu (Nobuyoshi Nakada)
09:23 AM Revision ea64e742 (git): Revert "mkmf.rb: try linking at try_var" [Bug #18235]
This reverts commit 524513be399e81bb170ec88aa0d501f33cbde8c3,
which can return false positive by existing but unusabl...
nobu (Nobuyoshi Nakada)
07:33 AM Bug #18184: Wrong key for `ruby2_keywords_hash` flag
ruby_3_0 f192e01233ccd7966721a164e62a86707b4e6d9e merged revision(s) 7c0230b05d0978958f89434c84ddd9c82419c1a5,552728a... nagachika (Tomoyuki Chikanaga)
07:33 AM Bug #18173: The feature in `$LOADED_FEATURES` is loaded again
ruby_3_0 5341eca588e738cd5031ab7d8bb5c300471c00e9 merged revision(s) ddb32e66160ab50849419ef7c7ac584913b79c34. nagachika (Tomoyuki Chikanaga)
07:16 AM Revision f192e012 (git): merge revision(s) 7c0230b05d0978958f89434c84ddd9c82419c1a5,552728a23aeab0df598b356b19a573259e297d14,49af9012a20a824542cf588e55e5488895553e09: [Backport #18184]
Check the entire name as `ruby2_keywords_flag` [Bug #18184]
---
marshal.c | 2 +-
...
nagachika (Tomoyuki Chikanaga)
07:10 AM Revision 5341eca5 (git): merge revision(s) ddb32e66160ab50849419ef7c7ac584913b79c34: [Backport #18173]
[Bug #18173] Update loaded_features_index
If $LOADED_FEATURES is changed in the just required file, also the...
nagachika (Tomoyuki Chikanaga)
06:31 AM Revision b91b3000 (git): [ruby/reline] Add code block notation in doc
https://github.com/ruby/reline/commit/b283791dc5 aycabta (aycabta .)
06:25 AM Revision bc5407f0 (git): [ruby/reline] Add doc for ed-unassigned and ed-insert macro
https://github.com/ruby/reline/commit/7fe9ecf945 aycabta (aycabta .)
05:53 AM Revision d31279fe (git): [ruby/reline] Add a test for rerendering arg prompt after pasting
https://github.com/ruby/reline/commit/5414a42b0e aycabta (aycabta .)
05:53 AM Revision 95522ef8 (git): [ruby/reline] Rerender whole buffer when argument editing finished
If the argument prompt disappears when pasting is finished, rerender the
whole buffer.
https://github.com/ruby/relin...
aycabta (aycabta .)
05:27 AM Revision bf0a8a74 (git): [ruby/reline] Call LineEditor#resize on Windows
https://github.com/ruby/reline/commit/65b27dd2ff aycabta (aycabta .)
05:26 AM Revision ef350b3a (git): [ruby/reline] Simplify SIGWINCH handler to avoid aborting when resizing.
https://github.com/ruby/reline/commit/481add0537 tommy (Masahiro Tomita)
05:09 AM Revision 2a3d0fbe (git): [ruby/reline] Add newlines for readability
https://github.com/ruby/reline/commit/2a60aacebb aycabta (aycabta .)
05:08 AM Revision 4401bbe8 (git): [ruby/reline] Use String#unpack1
https://github.com/ruby/reline/commit/179c52bca8 aycabta (aycabta .)
05:08 AM Revision a2d2f00e (git): [ruby/reline] Adjust border of scrollbar rendering calculation
https://github.com/ruby/reline/commit/737b23beae aycabta (aycabta .)
05:08 AM Revision 1d2edda9 (git): [ruby/reline] The @block_elem_width shouldn't be used for height calculation
https://github.com/ruby/reline/commit/da35902d78 aycabta (aycabta .)
05:08 AM Revision 7c6ef27d (git): [ruby/reline] Stop using Ctrl+j to test on Windows
Because Ctrl+j and Enter are the same on Windows.
https://github.com/ruby/reline/commit/fa885ed449
aycabta (aycabta .)
04:59 AM Revision ff480f29 (git): Cast to void pointer to suppress -Wformat-pedantic in RUBY_DEBUG_LOG
nobu (Nobuyoshi Nakada)
02:23 AM Revision ceeae319 (git): Avoid using the altzone variable in AIX
In AIX, altzone exists in the standard library but is not declared
in time.h. By 524513be399e81bb170ec88aa0d501f33cb...
Rei Odaira
02:09 AM Revision 2962c421 (git): [DOC] fix small mistake in doc/marshal.rdoc [ci skip]
mitsu-ksgr
02:06 AM Revision c5ff9544 (git): Get rid of unused function warning for `_WIN32`
xtkoba (Tee KOBAYASHI)

10/02/2021

11:05 PM Revision 84267324 (git): * 2021-10-03 [ci skip]
git[bot]
10:55 PM Revision 4f65e6ce (git): Temporarily skip test_no_curdir test to avoid CI failures on Solaris
jeremyevans (Jeremy Evans)
02:51 PM Bug #17885 (Closed): require_relative and require should be compatible with each other when symlinked files are used
Applied in changeset commit:git|79a4484a072e9769b603e7b4fbdb15b1d7eccb15.
----------
Do not load file with same real...
jeremyevans (Jeremy Evans)
02:51 PM Revision 79a4484a (git): Do not load file with same realpath twice when requiring
This fixes issues with paths being loaded twice in certain cases
when symlinks are used.
It took me multiple attempt...
jeremyevans (Jeremy Evans)
02:51 PM Revision 3f7da458 (git): Make encoding loading not issue warning
Instead of relying on setting an unsetting ruby_verbose, which is
not thread-safe, restructure require_internal and l...
jeremyevans (Jeremy Evans)
02:51 PM Feature #18231: `RubyVM.keep_script_lines`
I agree `RubyVM` namespace is not portable, and not well-considered API.
So I think:
* Ruby users should not us...
ko1 (Koichi Sasada)
02:46 PM Feature #18231: `RubyVM.keep_script_lines`
> I would think having code_location on exceptions and methods is also enough for the debugger.
How to get the pro...
ko1 (Koichi Sasada)
10:36 AM Feature #18231: `RubyVM.keep_script_lines`
I am strongly against this proposal as it currently stands.
This is yet another hack added under RubyVM.
I think add...
Eregon (Benoit Daloze)
01:57 PM Bug #18236 (Closed): Conversion to float not working for object with to_f method
Following code works on all previous versions (1.8.7-p375, 1.9.3-p551, 2.0.0-p648, 2.1.10, 2.2.10, 2.4.10, 2.5.9, 2.6... toy (Ivan Kuchin)
12:22 PM Revision e0ef4899 (git): [Win32] Prefer Cryptography Next Generation API
[BCryptGenRandom] is available since Windows Vista / Windows
Server 2008.
Regarding [CryptGenRandom]:
> This API is ...
nobu (Nobuyoshi Nakada)
10:58 AM Revision b8327fb8 (git): [ruby/reline] Refactoring Reline::Key.match? and add test.
https://github.com/ruby/reline/commit/90e8999ae4 osyo (manga osyo)
04:50 AM Bug #17507 (Closed): Regexp capture groups ignored sometimes in some multithreaded environments (possible race condition)
Applied in changeset commit:git|abc0304cb28cb9dcc3476993bc487884c139fd11.
----------
Avoid race condition in Regexp#...
jeremyevans (Jeremy Evans)
04:50 AM Revision abc0304c (git): Avoid race condition in Regexp#match
In certain conditions, Regexp#match could return a MatchData with
missing captures. This seems to require at the lea...
jeremyevans (Jeremy Evans)
02:43 AM Bug #18171 (Closed): `Marshal` ignores `Hash#compare_by_identity`
Applied in changeset commit:git|d08721465850a6e6954b43bbfebe2ed5a7256dec.
----------
Restore Hash#compare_by_identit...
nobu (Nobuyoshi Nakada)
02:43 AM Revision d0872146 (git): Restore Hash#compare_by_identity mode [Bug #18171]
nobu (Nobuyoshi Nakada)
02:43 AM Revision 806e7947 (git): Add rb_ident_hash_new_with_size
nobu (Nobuyoshi Nakada)
02:22 AM Bug #18166: Windows Ripper test-all failures? bison package?
ruby_3_0 efa1ba15fd5007210f819e6d11002ca829c989bf merged revision(s) fa05697e4832fbd67a4f91b9bb362471902faab3. nagachika (Tomoyuki Chikanaga)
02:22 AM Revision efa1ba15 (git): merge revision(s) fa05697e4832fbd67a4f91b9bb362471902faab3: [Backport #18166]
Use `%printer` directive for Bison 3.8
---
parse.y | 74 ++++++++++++++++++++++++++-----------------...
nagachika (Tomoyuki Chikanaga)

10/01/2021

11:02 PM Revision 601c67e4 (git): Suppress maybe-uninitialized warning on mingw
The compilation time pragma seems not applied to inline functions
expanded by the link time optimization. The local ...
nobu (Nobuyoshi Nakada)
10:51 PM Revision 8c10fd25 (git): Enhanced RDoc for Enumerable (#4922)
Treated:
#drop
#drop_while
#cycle
burdettelamar (Burdette Lamar)
06:44 PM Revision 27d9935d (git): Enhanced RDoc for Enumerable (#4918)
Treats:
#zip
#take
#take_while
burdettelamar (Burdette Lamar)
05:13 PM Revision eaeb0a00 (git): * 2021-10-02 [ci skip]
git[bot]
05:12 PM Revision e8d6076f (git): Fix typo in static function name
jeremyevans (Jeremy Evans)
05:12 PM Revision 9b04909a (git): Introduce rb_vm_call_with_refinements to DRY up a few calls
jeremyevans (Jeremy Evans)
04:39 PM Bug #18235 (Closed): try_var in mkmf.rb recognizes a variable that is not declared
In 524513be399e81bb170ec88aa0d501f33cbde8c3, `try_var` in mkmf.rb has been modified to recognize a variable that exis... ReiOdaira (Rei Odaira)
12:25 PM Bug #18156: 3.0.2 configuration checks by default for C++ compiler instead of C?
Thank you for the patch to fix the warning about AC_C_BIGENDIAN.
For the patch `912a8dcfc5369d840dcd6bf0f88ee0bac7...
jaruga (Jun Aruga)
02:02 AM Bug #18156 (Closed): 3.0.2 configuration checks by default for C++ compiler instead of C?
Applied in changeset commit:git|ca3cc677b31897e7306ac3b4565a0dd928168b08.
----------
Define ACTION-IF-UNIVERSAL of `...
nobu (Nobuyoshi Nakada)
11:30 AM Revision 0ad3ed5e (git): Checks for CPU specific header on universal build
nobu (Nobuyoshi Nakada)
11:30 AM Revision c7414f51 (git): Prefer `printf` like the recent autoconf
nobu (Nobuyoshi Nakada)
11:29 AM Bug #18191 (Closed): All loaded feature filenames should be in the file system encoding
Applied in changeset commit:git|60d0421ca861944459f52292d65dbf0ece26e38a.
----------
Fix the encoding of loaded feat...
nobu (Nobuyoshi Nakada)
11:28 AM Revision 3e46117d (git): Associate the encoding to the found path
nobu (Nobuyoshi Nakada)
11:28 AM Revision 842b0008 (git): Skip broken strings as the locale encoding
nobu (Nobuyoshi Nakada)
11:28 AM Revision 409dbc95 (git): Replace expanded load path only when modified
nobu (Nobuyoshi Nakada)
11:28 AM Revision b6534691 (git): Copy path strings as interned strings
nobu (Nobuyoshi Nakada)
11:28 AM Revision 60d0421c (git): Fix the encoding of loaded feature names [Bug #18191]
The feature names loaded from the default load paths should also
be in the file system encoding.
nobu (Nobuyoshi Nakada)
05:10 AM Feature #18228: Add a `timeout` option to `IO.copy_stream`
"ioquatix (Samuel Williams)" <[email protected]> wrote:
> Just FYI: `sendfile` is less flexible and you should ...
normalperson (Eric Wong)
04:49 AM Feature #18228: Add a `timeout` option to `IO.copy_stream`
"Eregon (Benoit Daloze)" <[email protected]> wrote:
> I wonder, can `sendfile(2)` be interrupted by a signal li...
normalperson (Eric Wong)
02:14 AM Revision 8e9d696e (git): Use macos-11 instead of macos-latest
znz (Kazuhiro NISHIYAMA)
02:14 AM Revision 77804be4 (git): Use macos-10.15 and macos-11 instead of macos-latest
https://github.blog/changelog/2021-09-29-github-actions-jobs-running-on-macos-latest-are-now-running-on-macos-big-sur... znz (Kazuhiro NISHIYAMA)
01:56 AM Revision ca3cc677 (git): Define ACTION-IF-UNIVERSAL of `AC_C_BIGENDIAN` [Bug #18156]
As we do not use config.h.in, just define the helper macro
instead.
nobu (Nobuyoshi Nakada)
01:07 AM Feature #18231: `RubyVM.keep_script_lines`
for debugger/error_highlight we need source code other than methods so `Method` is not enough.
I agree `Method#scrip...
ko1 (Koichi Sasada)

09/30/2021

11:38 PM Misc #18233: Intermediate Representation for Ruby's JIT
> MIR is designed to be used for different languages, including C. Standard ruby methods implemented on C, e.g. times... k0kubun (Takashi Kokubun)
06:26 PM Misc #18233 (Closed): Intermediate Representation for Ruby's JIT
This is for discussing an IR design for Ruby's JIT. This thread is spun out from [Feature #18229] to let it focus on ... k0kubun (Takashi Kokubun)
10:18 PM Bug #18180 (Closed): opt_newarray_min/max instructions ignore refined methods
Applied in changeset commit:git|1f5f8a187adb746b01cc95c3f29a0a355f513374.
----------
Make Array#min/max optimization...
jeremyevans (Jeremy Evans)
10:18 PM Revision 1f5f8a18 (git): Make Array#min/max optimization respect refined methods
Pass in ec to vm_opt_newarray_{max,min}. Avoids having to
call GET_EC inside the functions, for better performance.
...
jeremyevans (Jeremy Evans)
08:46 PM Revision a55a5fc6 (git): Enhanced RDoc for Enumerable (#4917)
Treats:
#each_with_index
#reverse_each
#each_entry
#each_slice
#each_cons
#each_with_object
burdettelamar (Burdette Lamar)
08:07 PM Revision 40ef0345 (git): * 2021-10-01 [ci skip]
git[bot]
08:06 PM Revision bb488a1a (git): Use faster any_hash logic in rb_hash
From the documentation of rb_obj_hash:
> Certain core classes such as Integer use built-in hash calculations and
> d...
jhawthorn (John Hawthorn)
08:06 PM Feature #18228: Add a `timeout` option to `IO.copy_stream`
byroot (Jean Boussier) wrote in #note-8:
> However if we use a signal to interrupt it (assuming it's possible, becau...
Eregon (Benoit Daloze)
10:09 AM Feature #18228: Add a `timeout` option to `IO.copy_stream`
> Once a timeout occurs, are you sure we can make such a guarantee about the number of bytes that are copied reliably... byroot (Jean Boussier)
10:02 AM Feature #18228: Add a `timeout` option to `IO.copy_stream`
> As for the return value in case of a timeout, it is important to convey both that a timeout happened, and the numbe... ioquatix (Samuel Williams)
08:03 PM Feature #18231: `RubyVM.keep_script_lines`
ko1 (Koichi Sasada) wrote in #note-2:
> It is ISeq/AST related API so it should be internal.
I don't see how it i...
Eregon (Benoit Daloze)
12:00 PM Feature #18231: `RubyVM.keep_script_lines`
> This new API must be implement-able for other Ruby implementations.
It is ISeq/AST related API so it should be i...
ko1 (Koichi Sasada)
09:13 AM Feature #18231: `RubyVM.keep_script_lines`
This new API must be implement-able for other Ruby implementations.
Hence, it must not be on `RubyVM`, and it should...
Eregon (Benoit Daloze)
08:16 AM Feature #18231 (Closed): `RubyVM.keep_script_lines`
This ticket proposes the method `RubyVM.keep_script_lines` to manage the flag to keep the source code.
Now, `SCRIP...
ko1 (Koichi Sasada)
06:41 PM Bug #18234 (Closed): exit after `binding.irb`
`exit` after `binding.irb' calls IRB's `exit` and raises an error.
expected:
```ruby
# binding.irb
exit #=> t...
ko1 (Koichi Sasada)
06:28 PM Feature #18229: Proposal to merge YJIT
> Yes, please. It's always very interesting to follow discussions about how to make Ruby faster.
Created a new thr...
k0kubun (Takashi Kokubun)
02:44 PM Feature #18229: Proposal to merge YJIT
The upstreaming work is now in progress and we've created a checklist:
https://github.com/Shopify/yjit/issues/257
maximecb (Maxime Chevalier-Boisvert)
01:45 PM Feature #18229: Proposal to merge YJIT
maximecb (Maxime Chevalier-Boisvert) wrote in #note-9:
> I have looked at MIR and it looks close to machine code, t...
vmakarov (Vladimir Makarov)
07:55 AM Feature #18229: Proposal to merge YJIT
k0kubun (Takashi Kokubun) wrote in #note-10:
> > We should probably continue this specific thread of discussion by e...
duerst (Martin Dürst)
03:22 AM Feature #18229: Proposal to merge YJIT
Great!
I'll release Ruby 3.1.0-preview1 after YJIT is merged!
naruse (Yui NARUSE)
03:33 PM Bug #18141 (Closed): Marshal load with proc yield objects before they are fully initialized
https://github.com/ruby/ruby/pull/4866 was merged as commit:529fc204af84f825f98f83c34b004acbaa802615, closing. byroot (Jean Boussier)
02:50 PM Revision 529fc204 (git): marshal.c: don't call the proc with partially initialized objects. (#4866)
For cyclic objects, it requires to keep a st_table of the partially
initialized objects.
Jean byroot Boussier
02:40 PM Bug #18156: 3.0.2 configuration checks by default for C++ compiler instead of C?
> As vo.x (Vit Ondruch) says in comment #note-1, we must call AC_PROG_CC somewhere.
I see the following commit:git...
jaruga (Jun Aruga)
12:59 AM Bug #18156: 3.0.2 configuration checks by default for C++ compiler instead of C?
jaruga (Jun Aruga) wrote in #note-7:
> > When a C++ compiler is not installed, the ./configure fails. Is this a expe...
shyouhei (Shyouhei Urabe)
11:47 AM Bug #18232 (Closed): Ractor.make_shareable is broken in code loaded with RubyVM::InstructionSequence.load_from_binary
This was first reported as a Bootsnap bug: https://github.com/Shopify/bootsnap/issues/376
But I reduced it to:
...
byroot (Jean Boussier)
10:22 AM Revision 912a8dcf (git): Needs `AC_PROG_CC`
Although `AC_PROG_CC_C99` has been obsolete, `AC_PROG_CC` is not
and the latter is necessary not to make C++ compiler...
nobu (Nobuyoshi Nakada)
07:55 AM Revision 90f2ab9d (git): rb_fiber_raise(): add doxygen
Must not be a bad idea to improve documents. shyouhei (Shyouhei Urabe)
 

Also available in: Atom