Activity
From 02/14/2022 to 02/20/2022
02/20/2022
-
04:06 PM Feature #18498: Introduce a public WeakKeysMap that compares by equality
- @mame, I think you convinced me, I'll remove it.
-
03:56 PM Feature #18498: Introduce a public WeakKeysMap that compares by equality
- What is `#size` method needed for? It may be error-prune to depend on a return value of the method because the size m...
- 03:44 PM Revision 1abd0684 (git): * 2022-02-21 [ci skip]
-
03:44 PM Revision 1f3fe380 (git): Fix links [ci skip]
-
01:21 PM Feature #18481: Porting YJIT to Rust (request for feedback)
- jeremyevans0 (Jeremy Evans) wrote in #note-7:
> maximecb (Maxime Chevalier-Boisvert) wrote in #note-6:
> > > believ... -
> I think Rust should be treated like OpenSSL. If you build Ruby without OpenSSL, Ruby doesn't download OpenSSL f...-
12:39 PM Feature #16295: Chainable aliases for String#-@ and String#+@
- Exactly, and so `+@` is already good enough for `buffer = +"literal"`, and `buffer = "literal".dup` is fine too.
Th... -
01:49 AM Feature #16295: Chainable aliases for String#-@ and String#+@
- zverok (Victor Shepelev) wrote in #note-21:
> > `+@` seems very rarely useful
>
> No opinion on the rest of the t... - 11:40 AM Revision 9f3b6caf (git): * 2022-02-20 [ci skip]
-
11:39 AM Revision ed8776f9 (git): [MSWin] Tentative measure for a bug of VS2022 [Misc #18362]
- Disable the use of `__assume()`, when combinations of `isnan()`,
`isinf()` and `__assume()` will be wrongly optimized... -
-
02/19/2022
-
11:44 PM Feature #16295: Chainable aliases for String#-@ and String#+@
- > `+@` seems very rarely useful
No opinion on the rest of the ticket, but I thought `buffer = +""` is a quite wide... -
- To make progress on this issue I'd suggest to simplify it to only add `dedup` as an alias for `-@`.
That seems agree... -
- > .dup is not quite as good, as it always allocates a copy.
It creates a new String instance, which is what one ne... -
-
- `UNREACHABLE` in ruby/internal/has/builtin.h is only used as just
a flag now, and redefined in ruby/backward/2/assume... -
02:19 PM Feature #13110 (Closed): Byte-based operations for String
- Applied in changeset commit:git|c8817d6a3ebc9bbc151625bca198b8f327d1d68f.
----------
Add String#byteindex, String#by... -
02:18 PM Revision 6e6ee1e6 (git): Replace and Using METACLASS_OF macro
-
- I prepared the patch for this: https://github.com/ruby/ruby/pull/5571
If there is no objections I'd like to merge ... -
- * Add String#byteindex, String#byterindex, and MatchData#byteoffset [Feature #13110]
Co-authored-by: NARUSE, Yui <na... -
10:06 AM Feature #18585 (Closed): Promote find pattern to official feature
- Applied in changeset commit:git|db6b23c76cbc7888cd9a9912790c2068703afdd0.
----------
Find pattern is no longer exper... -
-
-
-
-
-
06:15 AM Bug #18358: zlib crashes when in progress
- ruby_3_0 951e1377c18f84b52fbd3aab048da8536a3bbdb0 merged revision(s) c51b92c18deb850d2cea3a7c9020db23b364ab72.
-
- [ruby/zlib] [Bug #18358] Fix crash in zlib when in progress
When Zlib::Inflate#inflate or Zlib::Deflate#defl... -
-
- ruby_3_0 5c15cecfbfe61f9d46f45c949829c79cb7f162a9 merged revision(s) 0c5f8c62766afe4605172800063e63fe36996658.
-
- ruby_3_0 49ed412060f48d3b9343b8b90d73e6fcb02b3354 merged revision(s) b3d62a77d928eff01268ca7fa1c1c0966702926d.
-
- [ruby/zlib] Synchronize access to zstream to prevent segfault in
multithreaded use
I'm not sure whe... -
- zlib: fix Gzip{Writer,Reader}.new fails with a O_TMPFILE file
---
ext/zlib/zlib.c | 18 +++++... -
- Fix -Wundef warnings for HAVE_RB_EXT_RACTOR_SAFE
* See [Feature #17752]
---
ext/cgi/escape/... -
- [ruby/zlib] Resume zstream if available [Bug #10961]
---
ext/zlib/zlib.c | 6 ++++++
1 file...
02/18/2022
-
10:48 PM Feature #16295: Chainable aliases for String#-@ and String#+@
- @Eregon how is `-@` different from `.freeze` ? The meaning of these seems very much the same.
-
- Eregon (Benoit Daloze) wrote in #note-16:
> `+@` is rarely safe to use (only if you know what allocated it and that i... -
10:17 PM Revision bec3a1f1 (git): Enhanced RDoc for io.c (#5573)
- Links to options doc added/improved; in particular, new links to new section "Encoding Options" in encoding.rdoc. Mi...
-
07:45 PM Feature #18593: Add back URI.escape
- `URI.escape` has been deprecated since Ruby 1.9. Unfortunately, the deprecation warnings were only emitted in verbos...
-
07:33 PM Feature #18593 (Open): Add back URI.escape
- It seems like there should have been a compatibility call left in place for the removal of URI escape between stdlib ...
- 07:33 PM Revision 344f775e (git): * 2022-02-19 [ci skip]
-
- This is the beginning of an extended explication of Ruby encoding.
One of its more important jobs is to provide link... -
02:30 PM Revision 82513c7d (git): Remove unused function declaration in dln.c
- getenv is no longer used in dln.c.
-
02:10 PM Feature #18589: Finer-grained constant invalidation
- > It increased total retained memory from 1.23Gb to 1.3Gb (about a 0.7% increase).
1.3 / 1.23 is a 5.7% increase,... -
- I have a fix for `open-uri`: https://github.com/ruby/open-uri/pull/8
-
- I took a stab at implementing the current spec: https://github.com/ruby/ruby/pull/5570
### Methods
- `ObjectSpa... -
- https://github.com/ruby/ruby/pull/5518#discussion_r809645406
-
- Clarifies security vulnerabilities for commands.
Treats:
Kernel.system
Kernel.` (backtick)
IO.popen
... -
12:44 PM Revision 542a38f6 (git): gen-mail.rb: support markdown file path
-
12:25 PM Bug #18592 (Closed): RPATH of bundled native extensions is incorrect
- Hi, when building Ruby 3.1.0 on Solaris, one of our lint checks found out that RPATH/RUNPATH of bundled native extens...
-
-
09:28 AM Revision dff70b50 (git): [wasm] vm.c: stop unwinding to main for every vm_exec call by setjmp
- the original rb_wasm_setjmp implementation always unwinds to the root
call frame to have setjmp compatible interface,... -
04:41 AM Bug #18249: The ABI version of dev builds of CRuby does not correspond to the ABI
- >Reinstalling pure-Ruby gems is extremely fast compared to installing C extensions (which must rebuilt, otherwise sig...
-
04:00 AM Feature #13110: Byte-based operations for String
- @austin I don't vote for it. Byte-based operations are not for beginners, and I don't think it's worth migration pain...
-
02:57 AM Feature #16989 (Open): Sets: need ♥️
-
02:56 AM
Feature #16989 (Closed): Sets: need ♥️
- Applied in changeset commit:git|dd3501bb9580951623a9aa7c2f86f7c98f9d6b9c.
----------
Make Set a builtin feature [Fea... - 02:56 AM Revision ac32b702 (git): Mention Set as a new builtin class to NEWS
- 02:56 AM Revision dd3501bb (git): Make Set a builtin feature [Feature #16989]
-
- # The next dev meeting
**Date: 2022/03/17 13:00-17:00** (JST)
Log: https://github.com/ruby/dev-meeting-log/blob/m... -
02/17/2022
-
- matz (Yukihiro Matsumoto) wrote in #note-6:
> Okay, `binding` should raise an exception when called from a C defined... -
- FWIW TruffleRuby currently raises one of these 2 errors when trying to call a Ruby method which needs a direct Ruby f...
-
- Okay, `binding` should raise an exception when called from a C defined method.
Matz. -
01:17 AM Bug #18487: Kernel#binding behaves differently depending on implementation language of items on the stack
- To simplify the semantics and implementation, we could make Kernel#binding
raise when the direct caller is not Ruby.... -
10:49 PM Bug #18567: Depending on default gems in stdlib gems when not needed considered harmful
- > We've seen many instances of gems breaking on JRuby & TruffleRuby over the years due to new default gems
We (JRu... -
- @eregon sorry I was not talking about default gems; by "stdlib" I meant the libraries that have not (yet) been gemifi...
-
- @Dan0042 One issue is some people want the dependency on default gems to be in the Gemfile.lock, which e.g. enables t...
-
- Here's one idea: what if there was a list of all standard libraries in a given ruby version, such as `RbConfig::STDLI...
-
- Another instance of this issue: https://github.com/mikel/mail/pull/1472#discussion_r808927322
I think new default ... -
07:29 PM Feature #18585: Promote find pattern to official feature
- ktsj (Kazuki Tsujimoto) wrote in #note-2:
> > Is this request related to the whole feature (as described at https://... -
- Accepted. Congratulations.
Matz.
-
- The problem with that approach though is it's frequent to not run CI before pushing in CRuby, and then `master` could...
-
- FWIW in TruffleRuby there is both a pre-commit hook and a check in CI: [code](https://github.com/eregon/truffleruby/c...
-
- I'm not sure if I agree with the approach of using a pre-commit hook. AFAIK pre-commit hooks are not automatically in...
-
- It could be a mix of both approaches. As a pre-commit hook, compute the checksum/hash of header files and, if differe...
-
- I don't think there's a way for us reinstall C extension gems through make in Ruby. I think this would be the respons...
-
- @hsbt Isn't `gem pristine`/`bundle install` (with Bundler path set) or similar good enough?
Reinstalling pure-Ruby g... -
- I agreed to check ABI breakage on dev branch. But I'm bit of against re-install or re-build all of gems each ABI vers...
-
- I am against ABI based on SHA1 hash. We should bump API version manually, I think.
If you can provide make target t... -
04:54 PM Feature #16663 (Closed): Add block or filtered forms of Kernel#caller to allow early bail-out
- Applied in changeset commit:git|4c366ec9775eb6acb3fcb3b88038d051512c75a2.
----------
Add Thread.each_caller_location... -
- I accept `each_caller_location`.
Matz.
- 04:54 PM Revision 7757ccb5 (git): * 2022-02-18 [ci skip]
-
- This method takes a block and yields Thread::Backtrace::Location
objects to the block. It does not take arguments, a... -
- Ok, so I went over all 71 matches after filtering vendored code: https://gist.github.com/casperisfine/5a26c7b85f7d15c...
-
- > Will you?
I'd like to champion this. I already started opening pull requests on the affected gems.
-
- Making `Encoding#name` to return the name different from the encoding name is unacceptable.
Besides that, in general... -
- Link to the gem-codesearch results from @ko1: https://hackmd.io/koJLPz4eRXKzaaDvVqji7w#Feature-18576-Rename-ASCII-8BI...
-
- > Does this counter-proposal solve the original problem?
I believe so because the main way users are exposed to `A... -
- Does this counter-proposal solve the original problem?
It seems it introduces another inconsistency (and possible co... -
- Can I make a counter proposal?
We could keep `Encoding#name` as `"ASCII-8BIT"`, but change `Encoding#inspect` and ... -
- I don't object to the proposal itself. But as @ko1 searched, there are so many gems that compare `Encoding#name` and ...
-
03:22 PM Feature #13110: Byte-based operations for String
- matz (Yukihiro Matsumoto) wrote in #note-24:
> Regarding names, I accept `byteindex`, `byterindex`, `byteoffset`.
>... -
- Regarding names, I accept `byteindex`, `byterindex`, `byteoffset`.
I am against `byte_rindex` since I consider the n... -
- Thank you Matz!
> I vote for putting it under ObjectSpace
I think it's fine. It's an advanced class, no need to... -
- I agree with introducing a map (hash) with each key referenced weakly. It should be in the core since weak reference...
-
- Applied in changeset commit:git|4113862c0068a8a95d752f5fdf14980f92cd41d7.
----------
Do not search for commands with... -
- The `CC` found by `AC_CHECK_TOOL` is prefixed by the host triplet
when cross compiling. To search for commands with ... -
- Accepted, for the record.
Matz.
-
- We decided on the following policy.
* We will remove the bundled sources from ruby repo.
* @hsbt is working now... -
- Amusingly enough, this discussion led me to instrument our production environment to see what is bumping the cache, a...
-
- I agree with merging the pull request above, and see how it goes.
Matz.
-
- I've prepared a PR: https://github.com/ruby/ruby/pull/5563
-
- I revisited this issue at the developer meeting and concluded to reject this proposal.
I understand OP's need for th... -
- ruby_3_1 7fe0ebc4e7abd78501094cbb2d47918c8ff29f60 merged revision(s) 496591de96b261b8789332c7f8b2bfbd17658955.
-
- Show the linked ruby library name when failed to load extension
built against different ruby library. -
-
- Backticks method invokes `/bin/sh` when the command contains
quotes, and `sh` clears some environment variables set i... -
11:02 AM Bug #18590 (Closed): String#downcase and CAPITAL LETTER I WITH DOT ABOVE
- Downcasing for "İ" character works in an unexpected way:
```ruby
'İ'.downcase
=> "i̇"
```
Expected result - ... -
- https://github.com/ruby/ruby/blob/fdf0f8d81487560f5837dc7e3888a96f7c2b4ec9/tool/lib/test/unit.rb#L1273-L1290
-
09:58 AM Revision fdf0f8d8 (git): btest-ruby OPTS=-v should disable quiet
- `make btest-ruby` is run with -q (quiet) option and -v should
remove -q option. -
- Lazy loading RubyGems sounds great. Ping us if you need support from the core.
Matz.
-
- Merged at https://github.com/ruby/ruby/commit/9f81d9f92d
-
- Agreed.
Matz.
-
-
- st.c: Do not clear entries_bound when calling Hash#shift for empty
hash
tab->entries_bound is used ... -
12:02 AM Misc #18587: What was the reason behind Ruby choosing SipHash for Hash?
- JFYI this thread can be something related: https://bugs.ruby-lang.org/issues/13017
02/16/2022
-
- During startup, global invalidation for constants also causes a lot of extra lookups, and with a JIT it throws away a...
-
07:10 PM Feature #18589: Finer-grained constant invalidation
- At the moment on Shopify's core monolith we're seeing around 1 in 30 requests invalidate the global cache. We're stil...
-
- Current design is the global counter doesn't change frequently.
Do you have measurements about it on some apps?
-
- This is related to https://github.com/ruby/ruby/pull/5433.
## Current behavior
Caches depend on a global counte... -
- * [Feature #18589] Finer-grained constant invalidation (Kevin Newton)
* We want to trade a very small memory incre... -
- One concern which might have been considered is what if someone writes their own hash table in pure-Ruby using `#hash...
-
04:12 PM Misc #18587: What was the reason behind Ruby choosing SipHash for Hash?
- I misread a point related to extra carefulness.
They don't suggest a rehash on collision, but on hash map grow; sinc... -
- Hello
I am digging into the history behind Ruby using SipHash for its Hash.
I found that in 2012 there were CVE-2... -
- The code attempts to read `C_ARG_REGS[leaf_builtin->argc + 1]`, and the
size of `C_ARG_REGS` is `NUM_C_ARG_REGS`. So... -
03:52 PM Bug #18588 (Closed): ruby -e 'p gets' with japanese charactors gets additional invalid leading chars and caught Encoding::InvalidByteSequenceError
- ### Input a line starting with japanese charactor from console, almost every time ruby gets additional invalid leadin...
- 03:34 PM Revision fabf60c9 (git): * 2022-02-17 [ci skip]
-
- Sizes for darray are size_t now. CC @peterzhu2118
-
- Using a fake (malloc) RArray is not friendly for the garbage
collector. Fake RArray does not have a heap page, so it ... -
- Changes size and capacity of darray to size_t to support more
elements.
Adds functions to darray that use GC allocat... -
- The modulo in `rb_yjit_code_page_alloc` seems interpreted wrongly.
-
- On the parallel test, workers can be killed because of timeout
and the information for the retrying can be inconsiste... -
- Random.urandom raises a RuntimeError if it is unavailable.
[Bug #13885] -
- いまは Random.urandom は利用できない環境で RuntimeError を投げるようになっているはずなのですが、securerandom.rb で Random.urandom が利用可能かをチェックするコードが古いまま...
-
- Applied in changeset commit:git|1ae630db2682831cc0f2d381ff46e7b8cd3c2174.
----------
`wmap#each` should check livene... - 04:32 AM Revision e7d76fe2 (git): * 2022-02-16 [ci skip]
-
- `ObjectSpace::WeakMap#each*` should check key's liveness.
fix [Bug #18586]
02/15/2022
-
- > I can't imagine a use case where you'd want to share metadata for objects that are eql.
As you certainly know, ... -
- byroot (Jean Boussier) wrote in #note-8:
> Then yes. But it's rarely convenient.
Can you elaborate? Because the D... -
- > as long as you use non-GC-able values only
Then yes. But it's rarely convenient. -
- If ObjectSpace::WeakMap had a #compare_by_identity that could be set to false, wouldn't this be equivalent to this We...
-
- > Do you think this Hash compatible? For example, default_proc (I think it is too much)?
Yes, I'd rather not ask f... -
- ko1 (Koichi Sasada) wrote in #note-4:
> Do you think this `Hash` compatible? For example, `default_proc` (I think it ... -
- Do you think this `Hash` compatible? For example, `default_proc` (I think it is too much)?
-
- ```
h = ObjectSpace::WeakMap.new
GC.disable
s = "a"
10000.times do
h[s] = true
s = s.succ
end
GC.en... -
- p8 (Petrik de Heus) wrote in #note-11:
> I can imagine having a `protected_send` just like we have a `public_send` a... -
- matthewd (Matthew Draper) wrote in #note-10:
> The trouble with using `send` in this [general] situation is that it m... -
02:53 PM Feature #12962: Feature Proposal: Extend 'protected' to support module friendship
- I can imagine having a `protected_send` just like we have a `public_send` and `send` (which is basically `private_sen...
-
01:25 PM Feature #12962: Feature Proposal: Extend 'protected' to support module friendship
- The trouble with using `send` in this [general] situation is that it makes it too equally-easy to reach into _all_ in...
-
- > Is this request related to the whole feature (as described at https://docs.ruby-lang.org/en/3.1/doc/syntax/pattern_...
-
- What about this?
```diff
diff --git a/configure.ac b/configure.ac
index 4feefb57915..01e87c0a9b4 100644
--- a/con... -
- > Could you write a picture (or flow) what happens on GVL hooks with GVL acquire/release?
I'm sorry, I don't under... -
- * Could you write a picture (or flow) what happens on GVL hooks with GVL acquire/release?
* It seems it doesn't use ... -
-
- @tenderlovemaking's comment for psych and libffi: https://github.com/ruby/psych/issues/535
02/14/2022
-
- For this Net::HTTP example IMHO it'd be better to use `send`, that would make it a private method and be explicit tha...
-
- > Calling "private/protected" methods on another object feels rather wrong to me.
The whole point of `protected` i... -
- Do you have an example in Rails?
This sounds like it can be solved by moving such private-but-shared method to `In... -
- * [Feature #18576] Rename `ASCII-8BIT` encoding to `BINARY`
- The `ASCII-8BIT` name is very confusing for beginners... -
- * [Misc #18362] mswin builds & vs2022
* What can we do for the bug? -
- * [Feature #18585] Promote find pattern to official feature (ktsj)
* Is it OK to to promote find pattern to offi... -
- RARRAY_SHARED_ROOT_FLAG is defined as FL_USER5, but we should use
RARRAY_SHARED_ROOT_FLAG instead of depending on tha... -
- Hello! Is this request related to the whole feature (as described at https://docs.ruby-lang.org/en/3.1/doc/syntax/pat...
-
- "Find pattern" has introduced in 3.0 and it is still marked as an experimental.
I don't see any problems, so it is t... -
- (1) gc_verify_internal_consistency() use barrier locking
for consistency while `during_gc == true` at the end
... -
- Visual Studio 2022 version 17.0.6 released at February 8 seems still unfixed.
I wonder how we deal with this issue (... -
05:57 AM Bug #18582: Hash.group_by not grouping correctly with SortedSets
- Ah, I had tried method_defined?, but it returns true (for inherited Kernel#eql?)
I did not realized that method_de... - 05:52 AM Revision 83803117 (git): * 2022-02-14 [ci skip]
-
- 1 seconeds is not enough on an specific (busy) machine w/ mjit.
http://ci.rvm.jp/results/trunk-mjit@phosphorus-docker... - 04:57 AM Revision 8a0dfd4a (git): * 2022-02-14 [ci skip]
-
Also available in: Atom