Project

General

Profile

Activity

From 03/13/2023 to 03/19/2023

03/19/2023

09:51 AM Bug #19485 (Closed): Unexpected behavior in squiggly heredocs
Applied in changeset commit:git|e7342e76dfd26237c604e42f9a59a1eaa578c94e.
----------
[Bug #19485] [DOC] Mention tabs...
nobu (Nobuyoshi Nakada)
07:22 AM Feature #19541 (Feedback): Proposal: Generate frame unwinding info for YJIT code
## What is being propsed?
Currently, when Ruby crashes with yjit generated code on the stack, `rb_print_backtrace(...
kjtsanaktsidis (KJ Tsanaktsidis)

03/18/2023

05:45 PM Bug #19539 (Closed): Heredocs with leading spaces inconsistency
Applied in changeset commit:git|67dd52d59cde0d2f1ebb3e299b605ed239b59f5b.
----------
[Bug #19539] Match heredoc iden...
nobu (Nobuyoshi Nakada)
12:47 PM Bug #19539 (Closed): Heredocs with leading spaces inconsistency
This is more like technical inconsistency that bothers me. Not sure someone will use this in real life, but still.
T...
hurricup (Alexandr Evstigneev)
05:17 PM Bug #19540 (Rejected): Undefined variable error when combining modifier if with one-line pattern matching
This isn't a bug, this is how Ruby works. It is unrelated to pattern matching, you get the same behavior for `x if x... jeremyevans0 (Jeremy Evans)
02:33 PM Bug #19540 (Rejected): Undefined variable error when combining modifier if with one-line pattern matching
If I try to use modifier `if` with a one-line pattern matching, the variable assigned by the pattern cannot be used i... mehanoid (Oleg Grigorev)
02:36 PM Bug #19537: Regexp caching algorithm since v3.2.0 causes invalid memory access
I have not understand the implementation in detail, but maybe this patch fixes the problem.
(No new tests have been ...
jj1uzh (Futa Miyachi)
02:28 PM Bug #18743: Enumerator#next / peek re-use each others stacktraces
Hello again. I've modified the patch to also link to the old exception via `cause`. Let me know if it's now a reasona... marcper (Marcelo Pereira)
01:07 PM Bug #19536 (Closed): Frozen status loss when moving objects
Applied in changeset commit:git|cb22d78354e201ca74eba68a8b4edefb593e6754.
----------
Fix frozen status loss when mov...
peterzhu2118 (Peter Zhu)
06:47 AM Bug #19532: Handling of 6-byte codepoints in left_adjust_char_head in CESU-8 encoding is broken
The change itself looks fine, but also I’m for obsoleting CESU-8. nobu (Nobuyoshi Nakada)
05:53 AM Bug #19469: Crash when resizing generic iv list
ruby_3_2 f3abe5ba645839fb2a686aee18d3466b59256af0 merged revision(s) 0700d0fd1c77b4fddf803dea3c10be654df600ff,62c2082... naruse (Yui NARUSE)

03/17/2023

07:30 PM Bug #19535: Instance variables order is unpredictable on objects with `OBJ_TOO_COMPLEX_SHAPE_ID`
byroot (Jean Boussier) wrote in #note-3:
> > I think it's best to make the too-complex-shape objects use an ordered ...
tenderlovemaking (Aaron Patterson)
05:29 PM Bug #19535: Instance variables order is unpredictable on objects with `OBJ_TOO_COMPLEX_SHAPE_ID`
> BTW it'd be nice to have some kind of standard performance warnings for Ruby.
Interesting. I guess we could have...
byroot (Jean Boussier)
04:25 PM Bug #19535: Instance variables order is unpredictable on objects with `OBJ_TOO_COMPLEX_SHAPE_ID`
> I think it's best to make the too-complex-shape objects use an ordered hash
I would also lean on that solution, ...
byroot (Jean Boussier)
01:06 PM Bug #19535: Instance variables order is unpredictable on objects with `OBJ_TOO_COMPLEX_SHAPE_ID`
BTW it'd be nice to have some kind of standard performance warnings for Ruby.
For instance there would be one for TO...
Eregon (Benoit Daloze)
01:02 PM Bug #19535: Instance variables order is unpredictable on objects with `OBJ_TOO_COMPLEX_SHAPE_ID`
I chatted with @tenderlovemaking. I think it's best to make the too-complex-shape objects use an ordered hash (such c... Eregon (Benoit Daloze)
07:48 AM Bug #19535 (Closed): Instance variables order is unpredictable on objects with `OBJ_TOO_COMPLEX_SHAPE_ID`
### Context
I've been helping the Mastodon folks in investigating a weird Marshal deserialization bug they randoml...
byroot (Jean Boussier)
07:23 PM Feature #19538: Performance warnings
So the example that sparked the idea was SHAPE_TOO_COMPLEX. It would be useful to emit a warning such as:
`warning...
byroot (Jean Boussier)
06:26 PM Feature #19538: Performance warnings
When does the option print a warning, for example? mame (Yusuke Endoh)
05:39 PM Feature #19538 (Closed): Performance warnings
Suggested by @Eregon.
There are program behaviors that are supported, but that we know aren't good for performance...
byroot (Jean Boussier)
07:20 PM Feature #19406 (Closed): Allow declarative reference definition for rb_typed_data_struct
Applied in changeset commit:git|7142328a94c85cc5f23630396f248b32133f87ab.
----------
[Feature #19406] Allow declarat...
eightbitraptor (Matt V-H)
05:50 PM Bug #19531 (Closed): ObjectSpace::WeakMap: replaced values still clear the key they were assigned to
Applied in changeset commit:git|3592b24cdc07ed89eecb39161f21fe721a89a5de.
----------
ObjectSpace::WeakMap: clean inv...
byroot (Jean Boussier)
02:36 PM Bug #19537 (Closed): Regexp caching algorithm since v3.2.0 causes invalid memory access
Some types of regular expressions causes invalid memory access on `#match`. Length of strings to match does not matte... jj1uzh (Futa Miyachi)
02:17 PM Bug #19536 (Closed): Frozen status loss when moving objects
GitHub PR: https://github.com/ruby/ruby/pull/7553
When objects are moved between size pools, their frozen status i...
peterzhu2118 (Peter Zhu)
08:58 AM Bug #19533: Behavior of ===/include? on a beginless/endless range (nil..nil) changed in ruby 3.2
mame (Yusuke Endoh) wrote in #note-2:
> In #18580, @matz said:
>
> > I decided to make `include?` to raise except...
knu (Akinori MUSHA)
04:29 AM Bug #19533: Behavior of ===/include? on a beginless/endless range (nil..nil) changed in ruby 3.2
In #18580, @matz said:
> I decided to make `include?` to raise exception for beginless/endless non-numeric ranges....
mame (Yusuke Endoh)
04:03 AM Bug #19533 (Closed): Behavior of ===/include? on a beginless/endless range (nil..nil) changed in ruby 3.2
Starting from Ruby 2.7.0 a range `nil..nil` used to match any value until 3.2.0-preview3, but 3.2.0-rc1 started to re... knu (Akinori MUSHA)
07:32 AM Bug #19534 (Closed): [ruby 3.2.1] Regular expression comparisons may be slower than in older versions.
Hello Sir.
When scanning a string with a regular expression created using many Japanese words, there was a slowdown ...
mizuKyo (kyosuke mizukami)
04:36 AM Bug #19468: Ruby 3.2: net/http sets UTF-8 encoding for binary responses
ruby_3_2 b309c246ee70926d593d3857e1625202e2d0f67b merged revision(s) d78ae78fd76e556e281a743c75bea4c0bb81ed8c. naruse (Yui NARUSE)
04:30 AM Bug #18580: Range#include? inconsistency for beginless String ranges
Unfortunately, this change broke an existing program: #19533.
The lesson here is that it would be best to avoid ch...
mame (Yusuke Endoh)
01:54 AM Bug #19464: YJIT miscompiles `BasicObject#__send__` to alias methods of `send`
ruby_3_2 b73a07359758a9034996752e981e09ddaffe8d87 merged revision(s) 0eb634ae73cb327ede833b72492f912792a4a9d5. naruse (Yui NARUSE)
01:15 AM Feature #18951: Object#with to set and restore attributes around a block
temp_set might be a better method name dsisnero (Dominic Sisneros)

03/16/2023

03:45 PM Bug #19412: Socket starts queueing and not responding after a certain amount of requests
Some other updates. I've been trying to undestand the `TIME_WAIT` and why it does behave the way it doesn on MacOS (b... brodock (Gabriel Mazetto)
11:32 AM Bug #19412: Socket starts queueing and not responding after a certain amount of requests
when the pause happens it seems the socket is still kept alive, based on netstat:
(there is a huge list of those):...
brodock (Gabriel Mazetto)
11:15 AM Bug #19412: Socket starts queueing and not responding after a certain amount of requests
@jeremyevans0 I'm new to debugging C code. Your idea on filedescriptors seems to to be somewhat spot on.
I'm not ...
brodock (Gabriel Mazetto)
02:31 PM Bug #19532 (Closed): Handling of 6-byte codepoints in left_adjust_char_head in CESU-8 encoding is broken
```ruby
irb(main):001:0> "\u{10000}".encode("cesu-8").chop
=> "\xED\xA0\x80"
```
But it should be `""`.
Fix in...
Eregon (Benoit Daloze)
02:01 PM Bug #19529: [BUG] ObjectSpace::WeakMap can segfault after compaction
To the backport manager: in addition to the two commits above, please also ensure to backport commit [e0cf80d666d4b5d... peterzhu2118 (Peter Zhu)
11:57 AM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
@ioquatix I think you need to explain the design of your reloading and usages of anonymous modules and why it's so im... Eregon (Benoit Daloze)
11:52 AM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
@Dan0042 Right, the rule is not as simple, indeed.
Of course `a::B` is not a fully-named constant here, so this is "...
Eregon (Benoit Daloze)
11:48 AM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
fxn (Xavier Noria) wrote in #note-26:
> We also know the coupling ends there. These entities ar highly decoupled in ...
Eregon (Benoit Daloze)
01:39 AM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
Eregon (Benoit Daloze) wrote in #note-17:
> IIRC naming of constants under a module is only done if a module is fully...
Dan0042 (Daniel DeLorme)
09:32 AM Bug #19442 (Closed): Remove USE_RINCGC flag
Applied in changeset commit:git|b3a271665b6d45fe21e775e1c523a040caa509a9.
----------
[Feature #19442] Remove USE_RIN...
eightbitraptor (Matt V-H)
08:55 AM Bug #19531: ObjectSpace::WeakMap: replaced values still clear the key they were assigned to
Patch: https://github.com/ruby/ruby/pull/7540 byroot (Jean Boussier)

03/15/2023

11:50 PM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
This is a long thread, I was not aware of it.
Let me say that nobody can assume from the name of a class or module...
fxn (Xavier Noria)
11:40 PM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
To be clear, Zeitwerk works only with constants. When you load `foo.rb`, the constant `:Foo` has to exist in `Object`... fxn (Xavier Noria)
11:30 PM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
> I don't think it's uncommon to cache instances of a class in some global mapping. Does Zeitwerk reload the entire n... fxn (Xavier Noria)
11:10 AM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
In fact, implementing `labeled_module`/`labeled_class` like you showed above would again break these expectations, il... Eregon (Benoit Daloze)
11:06 AM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
> Also, it looks like Zeitwerk absolutely can reload code and create confusion
This is again an unrealistic comple...
Eregon (Benoit Daloze)
11:03 AM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
> As demonstrated, if users want to do this, it's already possible.
Yes, and it just doesn't matter much in practi...
Eregon (Benoit Daloze)
05:54 PM Bug #19531 (Closed): ObjectSpace::WeakMap: replaced values still clear the key they were assigned to
### Reproduction script
```ruby
wmap = ObjectSpace::WeakMap.new
a = "A"
b = "B"
wmap[1] = a
wmap[1] = b #...
byroot (Jean Boussier)
04:29 PM Bug #19412: Socket starts queueing and not responding after a certain amount of requests
brodock (Gabriel Mazetto) wrote in #note-9:
> @jeremyevans0 I've tested again in MacOS system provided ruby version:...
jeremyevans0 (Jeremy Evans)
03:57 PM Bug #19412: Socket starts queueing and not responding after a certain amount of requests
@jeremyevans0 I've tested again in MacOS system provided ruby version:
```
ruby --version ...
brodock (Gabriel Mazetto)
03:33 PM Bug #19412: Socket starts queueing and not responding after a certain amount of requests
I've also tried to build something similar to "hey" in ruby and couldn´t make it crash (this is likely because of the... brodock (Gabriel Mazetto)
03:31 PM Bug #19412: Socket starts queueing and not responding after a certain amount of requests
I've went back to my Linux machine and tried to reproduce the problem.
Using Ruby 3.0 (from the package manager), I ...
brodock (Gabriel Mazetto)
03:07 PM Bug #19485: Unexpected behavior in squiggly heredocs
sawa (Tsuyoshi Sawada) wrote in #note-3:
> For the purpose of measuring an indentation, a horizontal tab is regard...
jemmai (Jemma Issroff)
11:28 AM Bug #19485: Unexpected behavior in squiggly heredocs
Another condition could be only accept tabs in squiggly heredoc if they prefix all lines of the squiggly heredoc? (ot... Eregon (Benoit Daloze)
08:40 AM Bug #19485: Unexpected behavior in squiggly heredocs
I don't think it's a good idea to assume a tab is 8 spaces.
Regarding indentation, it might be a nice simplification...
ioquatix (Samuel Williams)
07:57 AM Bug #19485: Unexpected behavior in squiggly heredocs
nobu (Nobuyoshi Nakada) wrote in #note-2:
> My [draft] is:
>
> > Note that the "indentation" is counted like as each...
sawa (Tsuyoshi Sawada)
05:16 AM Bug #19485 (Assigned): Unexpected behavior in squiggly heredocs
My [draft] is:
> Note that the "indentation" is counted like as each horizontal tabs are
> expanded to spaces up to ...
nobu (Nobuyoshi Nakada)
11:22 AM Bug #4040: SystemStackError with Hash[*a] for Large _a_
Regarding the original report, there is a clear solution now with `to_h`:
```ruby
1000.times.each_slice(2).to_a.to_...
Eregon (Benoit Daloze)
11:17 AM Bug #4040: SystemStackError with Hash[*a] for Large _a_
In other words, for efficiency arguments need to be passed on the stack, e.g. for JITed code.
Sure it could be possib...
Eregon (Benoit Daloze)
11:15 AM Bug #4040: SystemStackError with Hash[*a] for Large _a_
My opinion as a TruffleRuby implementer is I don't think TruffleRuby will or can support that.
So at least it should ...
Eregon (Benoit Daloze)
09:13 AM Bug #19530 (Closed): `Array#sum` and `Enumerable#sum` sometimes show different behaviours
Applied in changeset commit:git|ca437aeb395e77125fcd2ab9bc83bbcd3e357610.
----------
rb_ary_sum: don't enter fast pa...
byroot (Jean Boussier)
09:05 AM Bug #19526 (Closed): Rails Active Support behavior change since e87d0882910001ef3b0c2ccd43bf00cee8c34a0c
It was a bug. fixed https://github.com/ruby/ruby/pull/7507
Thank you!
ko1 (Koichi Sasada)
08:35 AM Bug #19459: Is `length` of `IO::Buffer#read` required or optional?
Thanks! ioquatix (Samuel Williams)
07:34 AM Bug #19459: Is `length` of `IO::Buffer#read` required or optional?
ruby_3_2 db28f7003f7d49cfa13871c38d10c1967282ca6b merged revision(s) 3b567eb491e460e00a66fdea8054eeb083b5dafd. naruse (Yui NARUSE)
03:21 AM Bug #19529: [BUG] ObjectSpace::WeakMap can segfault after compaction
To the backport manager: please ensure to also backport commit [3dc8cde70078ccb38f5f4b0818ad5eecded01bd5](https://git... peterzhu2118 (Peter Zhu)

03/14/2023

11:36 PM Bug #4040 (Open): SystemStackError with Hash[*a] for Large _a_
I'm reopening this issue.
Originally, when commit:2e7bceb34ea858649e1f975a934ce1894d1f06a6 fixed cfuncs to no long...
jeremyevans0 (Jeremy Evans)
10:19 PM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
Also, it looks like Zeitwerk absolutely can reload code and create confusion, and in addition, appending `file:line` ... ioquatix (Samuel Williams)
10:08 PM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
> I had a call with @ioquatix (Samuel Williams), trying to explain the importance of the name that Ruby shows us, for... ioquatix (Samuel Williams)
08:58 PM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
Another thought: maybe a much simpler way to solve most of these use-cases is adding `Module#source_location`, which ... Eregon (Benoit Daloze)
08:48 PM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
I had a call with @ioquatix, trying to explain the importance of the name that Ruby shows us, for example:
`undefine...
Eregon (Benoit Daloze)
10:17 PM Bug #18604: [BUG] ERROR(VpDivd): space for remainder too small
Use [bigdecimal-3.1.2](https://github.com/ruby/bigdecimal/releases/tag/v3.1.2) or later. hsbt (Hiroshi SHIBATA)
10:01 PM Bug #18604: [BUG] ERROR(VpDivd): space for remainder too small
got same issue here with any ruby 3.1.x version:(
Any news?
itsmegrave (Samuel Grave)
06:52 PM Bug #19412: Socket starts queueing and not responding after a certain amount of requests
brodock (Gabriel Mazetto) wrote in #note-4:
> I've also run a version of your client and got to reproduce the error ...
jeremyevans0 (Jeremy Evans)
06:33 PM Bug #19412: Socket starts queueing and not responding after a certain amount of requests
@jeremyevans0
running apache benchmark with `-c1` does show some of the behavior. It will go from 0 to somethign a...
brodock (Gabriel Mazetto)
04:57 PM Bug #19527: Object allocation during garbage collection phase
Please understand that while Ruby giving you the crash report
saying `[BUG] object allocation during garbage collect...
alanwu (Alan Wu)
03:16 AM Bug #19527: Object allocation during garbage collection phase
Hi everyone.
As I mentioned the first thing I did was check the issue with IBM, if you check the stack message, our ...
hjimenez89rb (Hugo Alberto Jiménez Santos)
03:49 PM Bug #19529 (Closed): [BUG] ObjectSpace::WeakMap can segfault after compaction
Applied in changeset commit:git|548086b34e3dd125edabf5dc1e46b891fad3ea9c.
----------
ObjectSpace::WeakMap: fix compa...
byroot (Jean Boussier)
08:17 AM Bug #19529: [BUG] ObjectSpace::WeakMap can segfault after compaction
Proposed patch: https://github.com/ruby/ruby/pull/7518 byroot (Jean Boussier)
07:46 AM Bug #19529: [BUG] ObjectSpace::WeakMap can segfault after compaction
Looking at the code, the `dcompact` function is wrong:
```c
static void
wmap_compact(void *ptr)
{
struct w...
byroot (Jean Boussier)
07:42 AM Bug #19529 (Closed): [BUG] ObjectSpace::WeakMap can segfault after compaction
Reproduction script:
```ruby
wm = ObjectSpace::WeakMap.new
obj = Object.new
100.times do |i|
GC.compact
w...
byroot (Jean Boussier)
09:15 AM Bug #19530: `Array#sum` and `Enumerable#sum` sometimes show different behaviours
Proposed patch: https://github.com/ruby/ruby/pull/7519 byroot (Jean Boussier)
08:51 AM Bug #19530: `Array#sum` and `Enumerable#sum` sometimes show different behaviours
Looking at `Array#sum` implementation, it very clearly has a fast path for when all the elements of the array are nat... byroot (Jean Boussier)
07:57 AM Bug #19530 (Closed): `Array#sum` and `Enumerable#sum` sometimes show different behaviours
Hi everyone. 👋🏻
We recently discovered that `Array#sum` and `Enumerable#sum` will output different results in some...
dstosik (David Stosik)

03/13/2023

10:46 PM Bug #19527 (Third Party's Issue): Object allocation during garbage collection phase
Unfortunately, the traces are not very helpful.
But I agree, it's likely an issue with the [IBM gem](https://github....
alanwu (Alan Wu)
09:22 PM Bug #19527: Object allocation during garbage collection phase
Seems to be identical indeed. rubyFeedback (robert heiler)
09:10 PM Bug #19527: Object allocation during garbage collection phase
Isn't this a duplicate of #19524? I don't think you will get a different answer to this ticket from the one that was ... ufuk (Ufuk Kayserilioglu)
06:08 PM Bug #19527 (Third Party's Issue): Object allocation during garbage collection phase
We are currently developing a Ruby based web application which connects to a DB2 Database and we have been using ibm_... hjimenez89rb (Hugo Alberto Jiménez Santos)
07:11 PM Feature #19528 (Third Party's Issue): `JSON.load` defaults are surprising (`create_additions: true`)
I'm not sure if it was actually intended, but there's some tacit naming convention for serializers in Ruby to use `lo... byroot (Jean Boussier)
03:41 PM Bug #19473: can't be called from trap context (ThreadError) is too limiting
ko1 (Koichi Sasada) wrote in #note-13:
> I think this reason violates (1).
What do you mean?
AFAIK https://githu...
Eregon (Benoit Daloze)
12:52 PM Bug #19485: Unexpected behavior in squiggly heredocs
I think what's happening here is that tabs are not converted directly to 8 spaces, but to "move ahead to next multipl... Dan0042 (Daniel DeLorme)
10:48 AM Feature #19440: Deprecate ThreadGroup
Yeah I know.
timeout.rb already has this workaround: https://github.com/ruby/timeout/pull/25/files
If `ThreadGroup#...
Eregon (Benoit Daloze)
02:27 AM Feature #19440: Deprecate ThreadGroup
Even if `ThreadGroup` were to be deprecated in 3.3, it can't help previous versions with the current timeout.rb. nobu (Nobuyoshi Nakada)
09:31 AM Bug #19476 (Closed): Regexp unexpected partial match
Applied in changeset commit:git|dddc542e9b61b292d80a96d0d0efbbf58719e3be.
----------
[Bug #19476]: correct cache ind...
make_now_just (Hiroya Fujinami)
06:46 AM Bug #19467 (Closed): Some linear_time regexp does not match in linear time
Applied in changeset commit:git|e22c4e8877677ff90805e4a4dcbdef80f4220136.
----------
[Bug #19467] correct cache poin...
make_now_just (Hiroya Fujinami)
 

Also available in: Atom