Activity
From 05/26/2023 to 06/01/2023
06/01/2023
-
09:55 PM Revision 10621f7c (git): Revert "Fix cvar caching when class is cloned"
- This reverts commit 77d1b082470790c17c24a2f406b4fec5d522636b.
-
08:10 PM Revision 2d2893f2 (git): [ruby/irb] Improve debug command tests
- (https://github.com/ruby/irb/pull/594)
* Use require_relative for envutil.rb
Requiring test helper files with `requ... -
07:27 PM Bug #19705 (Rejected): Ruby IPAddr class accepting wrong IPv6 address string
- It's expected that IPv6 with zone identifiers addresses are supported starting in Ruby 3.1 (ipaddr 1.2.3). See #10911...
-
10:52 AM Bug #19705 (Rejected): Ruby IPAddr class accepting wrong IPv6 address string
- We are middle of upgrading ruby versions v2.7.3 -> v3.1.3
One of our test cases are failing related to valid ipv6 ... -
04:16 PM Revision 39968112 (git): YJIT: Introduce RubyVM::YJIT.stats_string (#7857)
- * YJIT: Introduce RubyVM::YJIT.printed_stats
* Use #string instead
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang... -
03:52 PM Revision 77d1b082 (git): Fix cvar caching when class is cloned
- The class variable cache that was added in
https://github.com/ruby/ruby/pull/4544 changed the behavior of class
varia... - 01:54 PM Revision b7ee51e8 (git): Expose `enum rb_io_event` flags without `_t` suffix. (#7887)
- 12:46 PM Revision 47a8de60 (git): Drop `_t` suffix from struct names. (#7886)
- POSIX reserves `_t` suffix in types.
-
12:44 PM Revision a5e1d549 (git): [DOC] Mention the edge case of `any?`/`all?`
-
12:32 PM Revision a16cffe3 (git): Simplify duplicated code
- The capacity of the string can be calculated using the str_capacity
function. -
- The call to RSTRING_GETMEM already fetched the pointer and length, so we
don't need to fetch it again. -
12:16 PM Bug #19576: Backport request: Gemfile.lock resolving is broken with bundler shipped with Ruby 3.1.4
- With the --deployment option true:
This commit introduced the issue: https://github.com/rubygems/rubygems/commit/09b9... -
- Thank you. I can confirm that PR fixes what I described in the initial report.
Unfortunately, I recently found sec... -
07:57 AM Bug #19576: Backport request: Gemfile.lock resolving is broken with bundler shipped with Ruby 3.1.4
- I prepared to release new versions with your commits.
https://github.com/rubygems/rubygems/pull/6717 - 11:41 AM Revision d5a53331 (git): [ruby/stringio] Avoid direct struct usage.
- (https://github.com/ruby/stringio/pull/54)
We will eventually want to refactor this, but for now this is compatible
... -
11:11 AM Feature #19057: Hide implementation of `rb_io_t`.
- I'm in favour of eventually deprecating `rb_io_t` and I think that means anything related to it.
I think deprecation... -
09:56 AM Feature #19057: Hide implementation of `rb_io_t`.
- I am not sure there is an easier path here, IMO it's OK for some extensions to break while they test against ruby-hea...
-
-
- Unfortunately this was reverted due to some extensions no longer compiling.
- https://bugs.ruby-lang.org/issues/19... -
- I noticed Rails's Gemfile added a dependency to readline-ext in https://github.com/rails/rails/commit/a6e0b0acb2d1e85...
-
- 08:43 AM Revision 64ec1813 (git): Restores the changes in `io-console` without breaking backwards compatibility. (#7882)
- This reverts commit 35da41b29bf0a1a8fd2cd7e1d7fcb036ca8c2c7c.
This updates `io-console` to avoid accessing the inter... -
08:37 AM Revision edee9b6a (git): Use a real Ruby mutex in rb_io_close_wait_list (#7884)
- Because a thread calling IO#close now blocks in a native condvar wait,
it's possible for there to be _no_ threads lef... -
- It's hard to handle between ruby/syntax_suggest and ruby/ruby at gemspec.
https://github.com/ruby/syntax_suggest/com... - 05:23 AM Revision a218ed56 (git): Hide the usage of `rb_io_t` where possible. (#7880)
- This retries the compatible parts of the previously reverted PR so we can continue to update related code without bre...
-
- https://github.com/ruby/ruby/pull/7877
-
- - [Feature #19057] Hide implementation of `rb_io_t`.
- ~~So far the agreed approach is to hide the entire implement... -
12:39 AM Bug #19704 (Closed): Unable to install readline-ext since 18e55fc1e1ec20e8f3166e3059e76c885fc9f8f2
- Applied in changeset commit:git|85dcc4866d9ff29834596e9186cc97d622ee06f8.
----------
Revert "Hide most of the implem... -
- https://github.com/ruby/stringio is also build failure since 18e55fc1e1ec20e8f3166e3059e76c885fc9f8f2.
-
- This reverts commit 1889133c04f337fec3969cb5040a544088249046 and
commit 764207e47ce38d1b73774a8e65114c87bc888298.
...
05/31/2023
-
- This reverts commit 18e55fc1e1ec20e8f3166e3059e76c885fc9f8f2.
fix [Bug #19704]
https://bugs.ruby-lang.org/issues/197... -
-
03:47 PM Bug #19704 (Closed): Unable to install readline-ext since 18e55fc1e1ec20e8f3166e3059e76c885fc9f8f2
- Rails CI against Ruby 3.3.0dev fails to install readline-ext recenty.
https://buildkite.com/rails/rails/builds/96780... -
-
- Ensure that the frozen string is promoted to the old generation by
running the GC 4 times. -
-
02:34 PM Bug #19703 (Open): text/binary mode of parent process fd is not properly inherited on windows
- Windows OS can't inherit parent process fds greater than 2, but C runtime library support this.
https://learn.micros... -
- This test is flaky on some CI systems.
-
- I prefer option 2 as most (if not all other) ICLASS do not have a classpath so we shouldn't be paying the performance...
-
06:26 AM Bug #19701 (Open): The rb_classext_t::classpath field is not marked for T_ICLASS
- I am hacking Ruby to dump information about some objects, and I found that the `rb_classext_t::classpath` field for `...
-
- * [Bug #19702] Promote racc as bundled gems
* Does anyone have objection this? -
- In the past, we need to bundle `racc` runtime for RD parser of RDoc. Now, We have racc compiler and runtime in ruby r...
-
-
- The test `TestProcess#test_execopts_redirect_open_fifo_interrupt_print` in `test_process.rb` is flaky on macOS for me...
-
- > * ruby -h は一画面に収まるようにしたいのでこっちの説明はよく使うものだけにしたい
> * ruby --help はいろいろでるのでこっちに追加するのは反対ではない
ということで、`usage_msg[]`ではな... -
- https://github.com/rubygems/rubygems/commit/550d90f4ba
-
01:02 AM Misc #19599: DevMeeting-2023-05-10 @ Matsumoto, Japan
- Is a log going to be posted?
05/30/2023
-
- What is your “intention” to use an “empty” range?
And what do you think “idiomatic” way is? -
- * [Bug #11704] Refinements only get "used" once in loop (jeremyevans0)
* Is it expected that if a refinement is ac... -
- @headius and I discussed this on the train back from RubyKaigi and determined this is a Windows-specific limitation, ...
-
10:09 PM Feature #19699 (Closed): Need a way to store values like dig
- I believe this is a duplicate of [Feature #14564], [Feature #13179] and [Feature #11747].
This was previously reje... -
08:07 PM Feature #19699: Need a way to store values like dig
- Currently, there is no way to perform a `.store` operation on nested hashes in Ruby as there is for accessing them us...
-
- Currently, there is no way to perform a `.store` operation on nested hashes in Ruby as there is for accessing them us...
-
- Have you tried:
```ruby
def initialize(_a = nil, _b = nil, a: _a, b: _b)
```
But that too I'm not sure is s... -
06:36 PM Misc #19693: Data initialization is significantly slower than Struct
- @Eregon Just in case you are interested, I tried implementing your suggestion:
> Defining a `new` singleton method... -
- I guess the only noteworthy argument for a change goes like this:
A custom `timeout` only being available on `Reg... -
- janosch-x (Janosch Müller) wrote in #note-7:
> ```ruby
> regexp = Regexp.with_timeout(2.0) { /foo/ }
> regexp.time... -
-
12:53 PM Feature #19697: Resolv::DNS resolution for international domains fails with "Encoding::CompatibilityError: incompatible character encodings: UTF-8 and ASCII-8BIT"
- byroot (Jean Boussier) wrote in #note-5:
> > FWIW I've touched on the potential feature request in the stdlib uri li... -
-
- * Do not use a C extension on TruffleRuby for these 3 methods.
https://github.com/ruby/io-nonblock/commit/1b8e52abfa -
- * See https://github.com/ruby/io-console/pull/43/commits/d1d9aef45ceb14365fdf0ebee3e5ea06f27da682
https://github.com... -
12:27 PM Misc #19122: Use MADV_DONTNEED instead of MADV_FREE when freeing a Fiber's stack
- ioquatix (Samuel Williams) wrote in #note-5:
> If you want to use a specific mode (OS specific), you can do this:
>... -
- Closed per request.
-
- FreeBSD 13.1 CI hasn't failed since these fixes were merged so *touch wood* I think we can call this done.
-
01:43 AM Revision ec9364e5 (git): [ruby/racc] Remove ErrorSymbolValue reference
- I cannot find where this is defined. I'm guessing neither this
nor the else branch is ever hit. I only found out wh... -
- https://github.com/ruby/ruby/pull/6511 was merged.
In addition, the following related PRs were merged:
- https://gi... - 01:02 AM Revision 18e55fc1 (git): Hide most of the implementation of `struct rb_io`. (#6511)
- * Add rb_io_path and rb_io_open_descriptor.
* Use rb_io_open_descriptor to create PTY objects
* Rename FMODE_PREP -...
05/29/2023
-
- I think it is better if no code can mutate the timeout of the Regexps that are passed into it, even if that affected ...
- 09:24 PM Revision 7ddcd062 (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.77 to 0.9.78.
- [Release notes](https://github.com/oxid... -
- https://github.com/ruby/cgi/commit/1240fec9c9
-
- * See https://github.com/ruby/io-console/pull/43/commits/d1d9aef45ceb14365fdf0ebee3e5ea06f27da682
https://github.com... -
-
- The error messages were slightly different due, which causes different
behaviour on 32-bit and 64-bit systems. -
- 01:01 PM Revision 98f500d0 (git): [ruby/openssl] Remove usage of IO internals.
- 12:37 PM Revision 764207e4 (git): [ruby/io-console] Remove trailing whitespace.
- https://github.com/ruby/io-console/commit/55f1586463
- 12:30 PM Revision 1889133c (git): [ruby/io-console] Remove usage of IO internals.
- (https://github.com/ruby/io-console/pull/43)
https://github.com/ruby/io-console/commit/4b839a504f
Co-authored-by: B... -
- ianks (Ian Ker-Seymer) wrote in #note-8:
> > With one tweak: not int rb_ioptr_descriptor(struct rb_io *ioptr); but i... -
09:05 AM Feature #19695: mkmf: Adding the extra option --with-verbose to enable verbose mode.
- > $ rake compiler -- --with-verbose
Sorry for my typo in the commit message. It's not "rake compiler" but "rake co... -
08:55 AM
Feature #19695 (Closed): mkmf: Adding the extra option --with-verbose to enable verbose mode.
- Applied in changeset commit:git|57459b83a9a52ab921094a1562fe3056df9a437a.
----------
mkmf: Add the extra option `--w... -
- LGTM
-
- I enabled GitHub wiki page: https://github.com/ruby/ruby/wiki
- 08:09 AM Revision 57459b83 (git): mkmf: Add the extra option `--with-verbose` to enable verbose mode. (#7863)
- This commit is to add an extra option to enable verbose mode (V=1) in the
generated `Makefile` at runtime of the Ruby... -
05:06 AM Feature #19698 (Open): Need an idiomatic way to define an empty range
- It seems there is no idiomatic way to define an empty range. We can define empty ranges in several ways such as
``... -
- `File.absolute_path` and `File.expand_path` normalize a short path to the long path, and the case too (maybe as a sid...
05/28/2023
-
09:20 AM Revision d5ef373b (git): [ruby/irb] Set maximum document dialog height by
- preferred_dialog_height provided by Reline
(https://github.com/ruby/irb/pull/591)
https://github.com/ruby/irb/commit... - 08:40 AM Revision 14abb799 (git): [ruby/io-nonblock] Remove usage of IO internals.
- (https://github.com/ruby/io-nonblock/pull/11)
https://github.com/ruby/io-nonblock/commit/caa2b94d19 - 08:01 AM Revision 55393645 (git): [ruby/io-nonblock] Revert "Remove usage of IO internals."
- This reverts commit https://github.com/ruby/io-nonblock/commit/9772b6dcb63c.
https://github.com/ruby/io-nonblock/com... - 07:49 AM Revision 26dd9c5f (git): [ruby/io-nonblock] Remove usage of IO internals.
- https://github.com/ruby/io-nonblock/commit/9772b6dcb6
-
- > FWIW I've touched on the potential feature request in the stdlib uri library which was not further discussed
Tha... - 05:09 AM Revision 881757c0 (git): [ruby/io-wait] Remove usage of IO internals.
- (https://github.com/ruby/io-wait/pull/25)
https://github.com/ruby/io-wait/commit/e5854b46c7 - 05:08 AM Revision 00d66746 (git): [ruby/etc] Remove usage of IO internals.
- (https://github.com/ruby/etc/pull/26)
https://github.com/ruby/etc/commit/ea15eceb13 -
02:19 AM Feature #19057: Hide implementation of `rb_io_t`.
- > With one tweak: not int rb_ioptr_descriptor(struct rb_io *ioptr); but int rb_io_descriptor(VALUE io);.
> The goal ...
05/27/2023
-
- I agree with byroot, this shouldn't be solved at the resolve layer.
FWIW I've [touched on the potential feature requ... -
02:39 PM Feature #19697: Resolv::DNS resolution for international domains fails with "Encoding::CompatibilityError: incompatible character encodings: UTF-8 and ASCII-8BIT"
- clairity (claire c) wrote:
> i try to resolve a registered international domain, and instead of receiving DNS record... -
- While I think Ruby should offer a way to handle unicode domains, I'm not sure punycode should be handled at the Resol...
-
- i try to resolve a registered international domain, and instead of receiving DNS records, get an `incompatible charac...
-
- janosch-x (Janosch Müller) wrote in #note-8:
> BTW using literal kwargs in Ruby also makes struct initialization wit... -
- > I suppose it wouldn't hurt.
I think its beautiful 😁
Another option could be to bypass the initializer by defa... -
- > This is a kind of cheat
Hum, if I'm reading this correctly, you check is `initialize` was redefined, and if it w... -
- This is a kind of cheat, but...
https://github.com/nobu/ruby/tree/data-optimize
---
compare-ruby: ruby 3.3.0de... -
- (https://github.com/ruby/reline/pull/541)
https://github.com/ruby/reline/commit/ad6faada3f -
- problem
(https://github.com/ruby/reline/pull/542)
* Provide preferred_dialog_height for dialog positioning
* Fix re... -
- IMO we should find a way for RSpec to enable them by default, it is hurting RSpec users and destroying ruby-core's ef...
-
- Given that RSpec doesn't want to enable deprecation warnings by default, and that they were turned off mostly because...
-
- Given the discussion here, I just want to aim for "Hide all the details".
Thanks everyone, the discussion has been m... -
- ioquatix (Samuel Williams) wrote in #note-3:
> Maybe it's CRuby problem, but there is a performance issue with such ... -
- I did a bit of research on this topic this evening.
Firstly, some technical notes r.e. undefined behaviour.
My ... - 09:48 AM Revision bf1bc536 (git): Improve `read`/`write`/`pread`/`pwrite` consistency. (#7860)
- * Documentation consistency.
* Improve consistency of `pread`/`pwrite` implementation when given length.
* Remove H...
05/26/2023
-
- I understand it's intermittent and hard to reproduce, but could you try running it with `RUST_BACKTRACE=1` environmen...
-
- The STR_DEC_LEN macro is not used.
-
- Also .document was removed at 57bc4cfa283582f7c4c7013bb8a979e0baf3236c.
- 04:26 PM Revision 94e5ecbb (git): [ruby/rdoc] Improve `<summary>` CSS on sidebar
- - Use a smaller font size for the toggle symbol. (Currently, it seems a little too large)
- Use the child combinator ... - 04:24 PM Revision 54b7ce0b (git): [ruby/rdoc] Improve layout CSS
- - Use the `grid` property for the page layout.
- https://caniuse.com/css-grid
- Adjust the `<main>` margin.
- Make ... -
- byroot (Jean Boussier) wrote in #note-5:
> I assume you could have an internal regexp object that is deduplicated and... -
- > I do get the point that Regexp.new is less nice than /.../.
The main issue with `Regexp.new` is that it compile ... -
- On TruffleRuby all Regexp instances are frozen, notably because they are all globally cached and deduplicated, so thi...
-
- I agree with @austin, calling `new` with `timeout:` feels simpler and better than `dup` then set.
-
- This are implemented as Kernel methods and not keywords, but I
still think they are worth documenting with the other ... -
02:55 PM Misc #19679: Migrate Wiki from bugs.ruby-lang.org to ruby/ruby GitHub repository
- hsbt (Hiroshi SHIBATA) wrote in #note-1:
> So, I suggest to use option 1 at first for this migration
I agree, t... -
-
01:20 PM Revision d62ae187 (git): [DOC] Link fix (#7862)
- 01:19 PM Revision 6d450d62 (git): testing_ruby.md: Update `make test-all` tips [ci skip]
-
- Defining a `new` singleton method on the Data subclass, in Ruby and with explicit keyword arguments should be able to...
-
- OK so https://github.com/ruby/ruby/pull/7864 and https://github.com/ruby/ruby/pull/7865 were merged, so this _should_...
- 05:51 AM Revision cc698c6c (git): * expand tabs. [ci skip]
- Please consider using misc/expand_tabs.rb as a pre-commit hook.
-
- This test should be fixed and fast now because the closing thread sleeps
appropriately waiting for the file descripto... - 05:51 AM Revision 66871c5a (git): Fix busy-loop when waiting for file descriptors to close
- When one thread is closing a file descriptor whilst another thread is
concurrently reading it, we need to wait for th... -
- On Win32, currently, rb_nativethread_cond_t is an incomplete type
because it's a typedef for `struct rb_thread_cond_s... -
- This should now be fixed by the previous commit.
- 05:48 AM Revision 8e1abef4 (git): Fix a potential busy-loop in the thread scheduler (esp. on FreeBSD)
- This patch fixes a potential busy-loop in the thread scheduler. If there
are two threads, the main thread (where Ruby... - 03:39 AM Revision 3dae55ea (git): Bump github/codeql-action from 2.3.3 to 2.3.5
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.3.3 to 2.3.5.
- [Release notes](https://...
Also available in: Atom