Project

General

Profile

Activity

From 08/17/2023 to 08/23/2023

08/23/2023

11:46 PM Bug #12500 (Closed): TestProcess#test_aspawn_too_long_path fails on mips with "argument too big"
Applied in changeset commit:git|bd22bb259c183b91656bea72899fe91c31aeb44e.
----------
Handle Array#* raising Argument...
jeremyevans (Jeremy Evans)
08:16 PM Bug #12500: TestProcess#test_aspawn_too_long_path fails on mips with "argument too big"
I submitted a pull request to handle this ArgumentError: https://github.com/ruby/ruby/pull/8270 jeremyevans0 (Jeremy Evans)
11:46 PM Revision bd22bb25 (git): Handle Array#* raising ArgumentError in test
Treat ArgumentError as NoMemoryError, so it will resize the array
and try again.
Fixes [Bug #12500]
jeremyevans (Jeremy Evans)
11:35 PM Bug #16492 (Closed): TestBugReporter#test_bug_reporter_add test failures
I checked all recent ruby-master failures in the RHEL 7.1 s390 CI (http://rubyci.s3.amazonaws.com/rhel_zlinux/ruby-ma... jeremyevans0 (Jeremy Evans)
11:23 PM Bug #14480: miniruby crashing when compiled with -O2 or -O1 on aarch64
I submitted a pull request to disable `__builtin_setjmp` for Linux aarch64: https://github.com/ruby/ruby/pull/8272 jeremyevans0 (Jeremy Evans)
11:22 PM Bug #16288 (Closed): Segmentation fault with finalizers, threads
davidw (David Welton) wrote in #note-7:
> ```
> --- a/thread.c
> +++ b/thread.c
> @@ -682,7 +682,7 @@ thread_do_s...
jeremyevans0 (Jeremy Evans)
10:54 PM Bug #15428 (Feedback): Refactor Proc#>> and #<<
jeremyevans0 (Jeremy Evans)
10:47 PM Revision ce79887d (git): The first arg of NEW_KW_ARG macro is always 0
yui-knk (Kaneko Yuichiro)
10:38 PM Bug #14971 (Closed): error: implicit declaration of function ‘rb_vm_call0
jeremyevans0 (Jeremy Evans)
10:38 PM Bug #14957 (Closed): MinGW, gcc 8.2.0, bootstraptest test_thread.rb - failure ?
jeremyevans0 (Jeremy Evans)
10:30 PM Bug #14906 (Closed): MinGW failure - TestIO#test_copy_stream_no_busy_wait
jeremyevans0 (Jeremy Evans)
10:27 PM Bug #19792: arm の alpine 上でネストしたハッシュに長い文字列を入れると segmentation fault が発生する
ご丁寧にありがとうございます。 alanwu (Alan Wu)
10:16 PM Bug #19792 (Closed): arm の alpine 上でネストしたハッシュに長い文字列を入れると segmentation fault が発生する
Applied in changeset commit:git|2214bcb70d9f9120f1f3790ca340236c8f080991.
----------
Fix premature string collection...
alanwu (Alan Wu)
10:10 PM Bug #14679 (Closed): StdLib gems should properly specify their dependencies
jeremyevans0 (Jeremy Evans)
10:10 PM Bug #16951 (Closed): Consistently referer dependencies
jeremyevans0 (Jeremy Evans)
10:07 PM Revision 2214bcb7 (git): Fix premature string collection during append
Previously, the following crashed due to use-after-free
with AArch64 Alpine Linux 3.18.3 (aarch64-linux-musl):
```ru...
alanwu (Alan Wu)
09:32 PM Revision d7f1ea71 (git): Quarantine a very flaky spec
https://github.com/ruby/ruby/actions/runs/5956398507/job/16157091112
This has been extremely flaky on macOS GitHub A...
k0kubun (Takashi Kokubun)
09:30 PM Bug #19238 (Closed): URI.open fails for file path when second argument is a hash
Applied in changeset commit:git|43c2c1ed4814c6e1f0d0d0ec88641e12bf5aa290.
----------
[ruby/open-uri] Make URI.open p...
jeremyevans (Jeremy Evans)
09:30 PM Revision 43c2c1ed (git): [ruby/open-uri] Make URI.open pass keywords
Fixes [Bug #19238]
https://github.com/ruby/open-uri/commit/f636d01b85
jeremyevans (Jeremy Evans)
09:22 PM Revision 544488f1 (git): Improve comments in sync_default_gems
k0kubun (Takashi Kokubun)
09:16 PM Revision cdbc70d0 (git): [ruby/yarp] Match EOF after newline behavior
in Ripper EOL after whitespace is returned as a on_nl node with the whitespace as the content
k0kubun: This is a res...
HParker (Adam Hess)
08:56 PM Revision 455297d6 (git): Use https for remotes by default
I was testing this script on git.ruby-lang.org to use its git version,
but it did not work because the server's defau...
k0kubun (Takashi Kokubun)
08:43 PM Revision c6a07cc3 (git): Ignore more files for other gems as well
e.g. bin/ for reline that was included in its last commit. k0kubun (Takashi Kokubun)
08:35 PM Revision eb795b03 (git): Avoid sync rule duplication between YARP and others
k0kubun (Takashi Kokubun)
08:11 PM Bug #14474 (Closed): skip "TestException#test_thread_signal_location" as known bug
This test has not been skipped since commit:5ec3450438150e7cb05422c04dc18901161a13ea in January 2022, and I don't thi... jeremyevans0 (Jeremy Evans)
08:07 PM Bug #14422 (Closed): Ruby configuration options should not be reused for gem builds
vo.x (Vit Ondruch) wrote in #note-8:
> Unfortunately, this does not address the original issue. So is there any hope...
jeremyevans0 (Jeremy Evans)
07:32 PM Bug #14418 (Closed): ruby 2.5 slow regexp execution
Thanks to very impressive work by @makenowjust, this issue has been fixed in Ruby 3.2. jeremyevans0 (Jeremy Evans)
07:28 PM Bug #14064 (Closed): test-all with and without -j - incorrect assertions and missing test methods
It looks like a fix for this was committed in commit:dd3851d2786412de019350a11e749c56fa5a07cc jeremyevans0 (Jeremy Evans)
07:22 PM Bug #14049 (Closed): SEGV svn 60401 require_relative
jeremyevans0 (Jeremy Evans)
07:20 PM Bug #13644 (Closed): Windows - Setting Time.now
jeremyevans0 (Jeremy Evans)
07:19 PM Bug #13571 (Closed): Script arguments, encoding, windows / MinGW
Starting in Ruby 3.0, arguments provided to Ruby (in `ARGV`) are now in correct UTF-8 encoding. jeremyevans0 (Jeremy Evans)
07:07 PM Bug #13542 (Closed): MinGW trunk Builds - Summary of Issues
jeremyevans0 (Jeremy Evans)
07:06 PM Misc #12595 (Closed): Documentation
jeremyevans0 (Jeremy Evans)
07:06 PM Bug #13500 (Closed): MinGW TestArity#test_proc_err_mess stops testing
jeremyevans0 (Jeremy Evans)
07:03 PM Bug #13269 (Closed): test/readline/test_readline.rb and mingw
The readline extension was removed in commit:59fd67fc3d405e529e038172e769ff20a8fb5535. If this is still an issue, pl... jeremyevans0 (Jeremy Evans)
06:29 PM Revision f33c412e (git): [ruby/yarp] Constant paths followed by an & should be lexed as a call
https://github.com/ruby/yarp/commit/b0a2ba2c4d kddnewton (Kevin Newton)
06:20 PM Revision cedb3330 (git): Stop incrementing `jit_entry_calls` once threshold is hit
Otherwise the ISeq page will constantly be written
into preventing it from being shared.
byroot (Jean Boussier)
06:06 PM Revision 24bcd494 (git): [ruby/yarp] Fix first method param lex failures
When Ripper encounters a method parameter that is the first
parameter and is an identifier and it shadows a local sco...
kddnewton (Kevin Newton)
05:59 PM Revision 5766fb72 (git): Fix gdb.py for C frames [ci skip]
k0kubun (Takashi Kokubun)
05:52 PM Bug #12473 (Closed): Test failure on fedora with TestTimeExtension#test_huge_precision
jeremyevans0 (Jeremy Evans)
05:23 PM Revision 9aca3528 (git): [ruby/yarp] Match EOF after newline behavior
in Ripper EOL after whitespace is returned as a on_nl node with the whitespace as the content
https://github.com/rub...
HParker (Adam Hess)
05:20 PM Revision 77484528 (git): Change yjit stats list to be a unordered list
Without using a list, this show as a single paragraph with all stats descriptions being in one single line rafaelfranca (Rafael França)
04:07 PM Revision c837e1ad (git): [ruby/yarp] Add LABEL lex state when lexing a keyword params
https://github.com/ruby/yarp/commit/422bcd0ebf kddnewton (Kevin Newton)
03:42 PM Revision 9c43ec62 (git): [ruby/yarp] fix: newline tracking for a comment at EOF
https://github.com/ruby/yarp/commit/62fb0bddf5 mdalessio (Mike Dalessio)
03:40 PM Revision 8f0a8e57 (git): [ruby/yarp] Remove unnecessary loop
https://github.com/ruby/yarp/commit/86e8741ee3 mdalessio (Mike Dalessio)
03:10 PM Revision b4bc047f (git): YJIT: Implement VM_CALL_ARGS_BLOCKARG with Proc for ISeq calls
Rack uses this. Speculate that the `obj` in `the_call(&obj)`
will be a proc when the compile-time sample is a proc.
...
alanwu (Alan Wu)
03:08 PM Revision f902df12 (git): [ruby/yarp] refactor: extract `peek_addr()`
In many places in the code we use the idiom:
x < parser->end && *x == 'y'
which is essentially an extension of ...
mdalessio (Mike Dalessio)
02:34 PM Revision 58c1ebb6 (git): Fix guard-heap upgrades (#8264)
* Fix guard-heap upgrades
`getinstancevariable` was generating more heap guards than I thought.
It turns out that th...
tenderlovemaking (Aaron Patterson)
02:20 PM Bug #19436: Call Cache for singleton methods can lead to "memory leaks"
This bug is unrelated to YJIT, it happens with or without YJIT enabled. It thus cannot explain what you are seeing.
...
byroot (Jean Boussier)
01:48 PM Bug #19436: Call Cache for singleton methods can lead to "memory leaks"
Hi,
Will this be backported to 3.2?
I'm currently seeing this in production on a large Rails app: when YJIT is en...
cedricm (Cédric Maïon)
02:09 PM Revision 448ff162 (git): [DOC] Adding font usage to doc guide (#8255)
burdettelamar (Burdette Lamar)
10:40 AM Revision 129663c4 (git): tool/lib/output.rb: Make `--color` option like GNU coreutils
nobu (Nobuyoshi Nakada)
10:40 AM Revision de4a1ca7 (git): tool/lib/output.rb: Add `--create-only` and `--overwrite` options
nobu (Nobuyoshi Nakada)
10:40 AM Revision f1c6da65 (git): tool/lib/output.rb: Add `--no-color` option
nobu (Nobuyoshi Nakada)
08:28 AM Feature #19785: Deprecate `RUBY_GC_HEAP_INIT_SLOTS`
> RUBY_GC_HEAP_INIT_PAGES will allocate pages to size pools based on the distribution of objects at boot, and I worry... byroot (Jean Boussier)
01:44 AM Feature #19785: Deprecate `RUBY_GC_HEAP_INIT_SLOTS`
> How to know %d part?
The `%d` part is the sizes returned from `GC.stat_heap`. On 64-bit systems, it's 40, 80, 16...
peterzhu2118 (Peter Zhu)
01:11 AM Feature #19785: Deprecate `RUBY_GC_HEAP_INIT_SLOTS`
Sorry I didn't know about `RUBY_GC_HEAP_INIT_SIZE_%d_SLOTS`
* How to know `%d` part?
* How to tune the value?
...
ko1 (Koichi Sasada)
07:12 AM Bug #10416: Create mechanism for updating of Unicode data files downstreams when we want
The next version of Unicode (15.1) will be released in about 3 weeks. I'll check at that point, and close if no longe... duerst (Martin Dürst)
04:56 AM Revision e89150b1 (git): Render YARP templates into the build directory (#8266)
k0kubun (Takashi Kokubun)
04:56 AM Bug #19005 (Closed): Ruby interpreter compiled XCode 14 cannot build some native gems on macOS
jeremyevans0 (Jeremy Evans)
04:49 AM Bug #19005: Ruby interpreter compiled XCode 14 cannot build some native gems on macOS
We can close this now that XCode 14.3, which ships with clang 14.0.3, now fixes this issue: https://github.com/python... stanhu (Stan Hu)
04:45 AM Bug #11269 (Closed): ruby_init_setproctitle() should be called before require_libraries()
Applied in changeset commit:git|347993e95c4604d6c9460b64bb28c9b4f442531c.
----------
Call ruby_init_setproctitle bef...
jeremyevans (Jeremy Evans)
04:45 AM Revision 347993e9 (git): Call ruby_init_setproctitle before process_options
Fixes [Bug #11269] jeremyevans (Jeremy Evans)
04:09 AM Revision b92d599e (git): Fix typo in anonymous class string
If anonymous was shorted it should be `anon` not `annon`. Fixes typo in
APPEND_S for anonymous classes.
eileencodes (Eileen Uchitelle)
01:36 AM Feature #19783: Weak References in the GC
I ran the benchmark you wrote in #19436. On my machine it looks like this branch is a little bit slower:
Branch:
...
peterzhu2118 (Peter Zhu)
01:22 AM Feature #19783: Weak References in the GC
> [Bug #19436] is fixed by checking inline method cache data structures.
Thank you for fixing the bug.
An issue...
peterzhu2118 (Peter Zhu)
01:06 AM Feature #19783: Weak References in the GC
* [Bug #19436] is fixed by checking inline method cache data structures.
* So the rest motivation is to support weak ...
ko1 (Koichi Sasada)
12:19 AM Feature #19842: Introduce M:N threads
byroot (Jean Boussier) wrote in #note-18:
> > `Thread#lock_native_thread` may be what you want.
>
> Well, it depe...
ko1 (Koichi Sasada)

08/22/2023

10:59 PM Revision 00054de6 (git): Remove nd_entry from NODE_GASGN and NODE_GVAR
After a0f12a0258e4020bd657ee80b7d8f22bd33ea223 NODE_GASGN and
NODE_GVAR hold same value on both nd_vid and nd_entry.
...
yui-knk (Kaneko Yuichiro)
10:43 PM Revision ff552389 (git): YJIT: x64: Split mem-to-mem Insn::Store like Insn::Mov
The ARM backend allows for this so let's make x64 consistent. alanwu (Alan Wu)
10:35 PM Feature #14579: Hash value omission
Has it been considered to ever expand this feature to allow instance variables and global variables. Or was it strict... olivierlacan (Olivier Lacan)
10:33 PM Bug #12725: Trying to use ./miniruby before it exists
@duerst Have you seen this issue reoccur since it was initially posted? If not, do you think this can be closed? jeremyevans0 (Jeremy Evans)
10:29 PM Bug #11526: Streaming HTTP requests are not idempotent and should not be retried
A fix for this has been submitted as an upstream pull request: https://github.com/ruby/net-http/pull/87 jeremyevans0 (Jeremy Evans)
10:05 PM Bug #11174 (Closed): threads memory leak
jeremyevans0 (Jeremy Evans)
10:01 PM Bug #10580 (Closed): TestProcess#test_deadlock_by_signal_at_forking fails on ARM
jeremyevans0 (Jeremy Evans)
09:58 PM Bug #10416: Create mechanism for updating of Unicode data files downstreams when we want
@duerst Do you think this can be closed? jeremyevans0 (Jeremy Evans)
09:50 PM Bug #9507 (Closed): Ruby 2.1.0 is broken on ARMv5: tried to create Proc object without a block
jeremyevans0 (Jeremy Evans)
09:47 PM Bug #9955 (Closed): issue building dll on mingw, library not found
jeremyevans0 (Jeremy Evans)
09:36 PM Revision c23e2e19 (git): YJIT: add code_region_overhead stat output (#8262)
maximecb (Maxime Chevalier-Boisvert)
09:19 PM Revision 2d750697 (git): [ruby/yarp] Use require_relative for yarp/ffi
https://github.com/ruby/yarp/commit/c0598f8805 Eregon (Benoit Daloze)
09:12 PM Bug #9435 (Rejected): Kernel.system problem
I don't think this is a bug in Ruby, it is a general issue with Windows. As @nobu mentioned, you shouldn't use quote... jeremyevans0 (Jeremy Evans)
09:05 PM Bug #8782 (Closed): Don't set rl_getc_function on editline
Readline support was removed in commit:59fd67fc3d405e529e038172e769ff20a8fb5535. If this is still an issue, please f... jeremyevans0 (Jeremy Evans)
08:44 PM Bug #7859 (Closed): Readline: Incorrect arrow key behavior in vi_editing_mode insert mode with Readline 6.2
Readline was removed from Ruby in commit:59fd67fc3d405e529e038172e769ff20a8fb5535. If this is still an issue, please... jeremyevans0 (Jeremy Evans)
08:43 PM Bug #7840 (Closed): -Wdeclaration-after-statement is valid for C/ObjC but not for C++
Looking at recent Ruby versions:
* `-Wimplicit-function-declaration` is in `warnflags`
* `warnflags` is included ...
jeremyevans0 (Jeremy Evans)
08:31 PM Revision 837c12b0 (git): Use STR_EMBED_P instead of testing STR_NOEMBED
peterzhu2118 (Peter Zhu)
07:13 PM Bug #19844 (Feedback): Ruby 3.2 fails to build with openssl version 3
Ruby version 3.2 code base: https://github.com/ruby/ruby/tree/1c7624469880bcb964be09a49e4907873f45b026
openssl v3 ...
[email protected] (Narine Mossikyan)
06:04 PM Revision 9b373fb4 (git): [ruby/yarp] Fix small typo in templating to specify where template comes from
https://github.com/ruby/yarp/commit/96d69ceef6 jemmai (Jemma Issroff)
02:46 PM Revision 7127f39b (git): Add notes and name a magic number
nobu (Nobuyoshi Nakada)
01:43 PM Feature #19842: Introduce M:N threads
> `Thread#lock_native_thread` may be what you want.
Well, it depends if locked thread are counted as part of `RUBY...
byroot (Jean Boussier)
08:53 AM Feature #19842: Introduce M:N threads
byroot (Jean Boussier) wrote in #note-16:
> Another question I have is around being able to opt-out of N:M for a spe...
ko1 (Koichi Sasada)
08:40 AM Feature #19842: Introduce M:N threads
> `rb_thread_local_aref`
Ah, I totally missed that API, thank you.
Another question I have is around being able...
byroot (Jean Boussier)
07:00 AM Feature #19842: Introduce M:N threads
byroot (Jean Boussier) wrote in #note-14:
> > Thread Local Storage issue
>
> Is there any plan to expose a c API ...
ko1 (Koichi Sasada)
06:26 AM Feature #19842: Introduce M:N threads
> Thread Local Storage issue
Is there any plan to expose a c API to store data on the Ruby thread to replace the n...
byroot (Jean Boussier)
01:01 AM Feature #19842: Introduce M:N threads
> Ok. So Ruby Threads and Ractors will both share time on native threads. The difference being that Ractors can run i... ko1 (Koichi Sasada)
12:55 AM Feature #19842: Introduce M:N threads
> Hoping my guess was correct, I'm not quite sure what "2 level scheduling" means though. Is it just that the single-... ko1 (Koichi Sasada)
12:50 AM Feature #19842: Introduce M:N threads
> Ruby threads of a Ractor is managed by 1:N threads
is also typo (updated)
"Ruby threads of a Ractor is manage...
ko1 (Koichi Sasada)
12:47 AM Feature #19842: Introduce M:N threads
> We can run N ractors on N native threads simultaneously if the machine has N cores.
Sorry it was typo (updated)....
ko1 (Koichi Sasada)
12:45 AM Feature #19842: Introduce M:N threads
tenderlovemaking (Aaron Patterson) wrote in #note-2:
> ko1 (Koichi Sasada) wrote:
> > This ticket proposes to intro...
ko1 (Koichi Sasada)
12:21 AM Feature #19842: Introduce M:N threads
k0kubun (Takashi Kokubun) wrote in #note-3:
> > when M:N is enabled, threads become green threads, and Ractors are t...
tenderlovemaking (Aaron Patterson)
12:10 AM Feature #19842: Introduce M:N threads
> when M:N is enabled, threads become green threads, and Ractors are truly parallel (but CPU time is divided among N ... k0kubun (Takashi Kokubun)
01:38 PM Misc #19772: API naming for YARP compiler
I think `YARP` is already too widely used and talked about to be renamed without causing significant confusion and do... Eregon (Benoit Daloze)
05:06 AM Misc #19772: API naming for YARP compiler
If the motivation of this API is testing YARP compilation to ISeq, I agree to introduce `ISeq.compile_yarp` to Ruby 3... ko1 (Koichi Sasada)
12:50 PM Feature #19777: Make `Kernel#lambda` raise when called without a literal block
The ship has sailed, but I should at least mention I am disappointed at this turn of things. Again deprecating things... Dan0042 (Daniel DeLorme)
11:01 AM Revision 0ed3624c (git): Wrap nd_head in node dump message with brackets
yui-knk (Kaneko Yuichiro)
05:36 AM Feature #19843 (Closed): Promote bigdecimal as bundled gems at Ruby 3.4
Applied in changeset commit:git|1c93288f8bbf667cb95eb7137b2fe64213894b77.
----------
Added bigdecimal to warning tar...
hsbt (Hiroshi SHIBATA)
03:17 AM Feature #19843: Promote bigdecimal as bundled gems at Ruby 3.4
@hsbt I agree with you. I've wanted to make bigdecimal a bundled gem for a long time but I didn't have much time to ... mrkn (Kenta Murata)
03:10 AM Feature #19843 (Closed): Promote bigdecimal as bundled gems at Ruby 3.4
I triaged target list for bundled gems at https://bugs.ruby-lang.org/issues/19351.
After that, I resolved bigdecim...
hsbt (Hiroshi SHIBATA)
05:35 AM Revision 1c93288f (git): Added bigdecimal to warning targets for the bundled gems.
[Bug #19843] hsbt (Hiroshi SHIBATA)
05:04 AM Feature #19790: Optionally write Ruby crash reports into a file rather than STDERR
I would say only a file if the environment variable is set, with perhaps just a message on stderr saying the report w... byroot (Jean Boussier)
05:02 AM Feature #19790: Optionally write Ruby crash reports into a file rather than STDERR
Does it print to both STDERR and a file? or only to a file? ko1 (Koichi Sasada)
04:46 AM Revision ceafdb5a (git): Place -a in the correct location [ci skip]
It doesn't use optparse, so the location is not flexible. k0kubun (Takashi Kokubun)
04:46 AM Revision ccc80043 (git): Update default gems list at eec7a3f9ee0a40f4f5e22e0131c3ac [ci skip]
git[bot]
04:45 AM Revision eec7a3f9 (git): [ruby/erb] Version 4.0.3
https://github.com/ruby/erb/commit/c594f2fb86 k0kubun (Takashi Kokubun)
04:45 AM Revision be889b6d (git): Add a forgotten default value for ignored_paths
k0kubun (Takashi Kokubun)
04:41 AM Revision 0955ca34 (git): [ruby/erb] Enable frozen_string_literal in all files
(https://github.com/ruby/erb/pull/49)
I was surprised to see erb show up when I was using memory_profiler on
my app....
Josh Nichols
03:12 AM Misc #19766: DevMeeting-2023-08-24
* [Bug #19843] Promote bigdecimal as bundled gems at Ruby 3.4
* mrkn: Is it okay?
hsbt (Hiroshi SHIBATA)
01:25 AM Revision 4a8d7246 (git): zlib 1.2.13 is gone from zlib.net
U.Nakamura

08/21/2023

11:50 PM Feature #19842: Introduce M:N threads
ko1 (Koichi Sasada) wrote:
> This ticket proposes to introduce M:N threads to improve Threads/Ractors performance.
...
tenderlovemaking (Aaron Patterson)
08:41 PM Feature #19842 (Closed): Introduce M:N threads
This ticket proposes to introduce M:N threads to improve Threads/Ractors performance.
## Background
Ruby thread...
ko1 (Koichi Sasada)
11:36 PM Bug #19246: Rebuilding the loaded feature index much slower in Ruby 3.1
Applied at https://github.com/ruby/ruby/commit/788b03d5ba82fd8b35ce1fe2618ce6bacc648333.
nagachika (Tomoyuki Chikanaga)
11:33 PM Revision 788b03d5 (git): Re-apply "Ruby 3.2 - Speed up rebuilding the loaded feature index and realpath cache (#8023)" (#8252)
* Re-apply "Ruby 3.2 - Speed up rebuilding the loaded feature index and realpath cache (#8023)"
* [CI] mingw.yml - r...
MSP-Greg (Greg L)
08:43 PM Misc #19766: DevMeeting-2023-08-24
* [Feature #19842] Introduce M:N threads (ko1)
* Do you have any questions about it?
ko1 (Koichi Sasada)
08:30 PM Revision 925ce3f4 (git): Skip commits that are empty after conflict resolution
k0kubun (Takashi Kokubun)
08:24 PM Revision eee83af3 (git): Update yjit.md, document `--yjit-stats=quiet`
maximecb (Maxime Chevalier-Boisvert)
08:17 PM Revision 2502821a (git): Exclude docs/ from YARP sync
k0kubun (Takashi Kokubun)
08:14 PM Revision b9ef8191 (git): [rubygems/rubygems] Support `ruby file: ".tool-versions"` in Gemfile
(https://github.com/rubygems/rubygems/pull/6898)
Supports .tool-versions (ASDF) by checking for a line starting with...
Gaurav Khanna
07:00 PM Revision 95e29b04 (git): [ruby/yarp] fix: avoid invalid memory read when CR is present without LF
https://github.com/ruby/yarp/commit/2296c037de mdalessio (Mike Dalessio)
07:00 PM Revision 461f8eab (git): [ruby/yarp] fix: parsing a '%' expression with a CR but not a newline
Previously this failed an assertion and aborted.
https://github.com/ruby/yarp/commit/a037d942a8
mdalessio (Mike Dalessio)
06:23 PM Revision ca6db02c (git): [ruby/irb] Avoid overriding user's `irb_name` setting in debugger
integration
(https://github.com/ruby/irb/pull/688)
* Avoid overriding user's irb_name setting in debugger integratio...
st0012 (Stan Lo)
05:45 PM Revision 7d26c032 (git): Manually resync YARP
YARP commits were synced out of order. We are doing this reset
commit to ensure that all files are currently correct ...
jemmai (Jemma Issroff)
05:43 PM Revision 2cecd3c8 (git): [ruby/yarp] fix: newline tracking for nl-terminated % %q %Q
https://github.com/ruby/yarp/commit/1e4940864b mdalessio (Mike Dalessio)
05:43 PM Revision 9ca547b9 (git): [ruby/yarp] prefactor: extract yp_newline_list_check_append
https://github.com/ruby/yarp/commit/149c74291b mdalessio (Mike Dalessio)
05:43 PM Revision 926857eb (git): [ruby/yarp] fix: support newline-terminated regular expressions
Previously, parsing a snippet like this:
%r\nfoo\n
would result in tracking the second newline twice, resulting...
mdalessio (Mike Dalessio)
05:43 PM Revision e63bac31 (git): [ruby/yarp] Rename statements to body where appropriate
https://github.com/ruby/yarp/commit/0aa7d9d10c kddnewton (Kevin Newton)
05:43 PM Revision a7f40fc2 (git): [ruby/yarp] Change AndWriteNode, OrWriteNode, OperatorWriteNode to contain write nodes
It makes it more difficult to find all locations where a variable
is written to if they're just read nodes. To keep t...
kddnewton (Kevin Newton)
05:43 PM Revision 988b0108 (git): [ruby/yarp] Consolidate OperatorAndWrite and OperatorOrWrite nodes
https://github.com/ruby/yarp/commit/9e680a7598 kddnewton (Kevin Newton)
05:43 PM Revision 339b34be (git): [ruby/yarp] handle missing HEREDOC endline at start of heredoc
https://github.com/ruby/yarp/commit/7b72493b6d HParker (Adam Hess)
05:43 PM Revision 4fb2b3b6 (git): [ruby/yarp] Ensure correct location with if/elsif, allow FOCUS env var, fix newlines on __END__
https://github.com/ruby/yarp/commit/9da0bc4452 kddnewton (Kevin Newton)
05:43 PM Revision 0fd57ee0 (git): [ruby/yarp] Handle interpolated regular expressions with the o flag for locals checking
https://github.com/ruby/yarp/commit/db95191207 kddnewton (Kevin Newton)
05:43 PM Revision 524d99da (git): [ruby/yarp] Update to latest unparser
https://github.com/ruby/yarp/commit/5ba7394261 kddnewton (Kevin Newton)
05:43 PM Revision 289c0da5 (git): [ruby/yarp] Update to latest whitequark
https://github.com/ruby/yarp/commit/3607efb01d kddnewton (Kevin Newton)
05:33 PM Revision 05c59995 (git): [ruby/yarp] fix: newline tracking for nl-terminated % %q %Q
https://github.com/ruby/yarp/commit/1e4940864b mdalessio (Mike Dalessio)
05:33 PM Revision dcc8afe9 (git): [ruby/yarp] prefactor: extract yp_newline_list_check_append
https://github.com/ruby/yarp/commit/149c74291b mdalessio (Mike Dalessio)
05:32 PM Revision 67cd60ed (git): Manually move files from test/snapshots to test/yarp/snapshots
jemmai (Jemma Issroff)
04:52 PM Revision 817ffa8e (git): YJIT: Remove unnecessary roundtrip conversion
alanwu (Alan Wu)
04:42 PM Misc #19772: API naming for YARP compiler
We have reflected on the name YARP and would like to propose Prism as a new name for the external API. The parser is ... jemmai (Jemma Issroff)
04:22 PM Revision ac819f4d (git): [ruby/yarp] fix: support newline-terminated regular expressions
Previously, parsing a snippet like this:
%r\nfoo\n
would result in tracking the second newline twice, resulting...
mdalessio (Mike Dalessio)
04:20 PM Revision f83c1d62 (git): [ruby/yarp] Update to latest seattlerb
https://github.com/ruby/yarp/commit/d5365f08d0 kddnewton (Kevin Newton)
04:20 PM Revision 0c614063 (git): Fix YARP sync
kddnewton (Kevin Newton)
03:42 PM Revision 86ac17ef (git): [ruby/irb] Move input processing out of RubyLex
(https://github.com/ruby/irb/pull/683)
* Add a test case for Ctrl-C handling
* Test symbol aliases with integration...
st0012 (Stan Lo)
03:25 PM Revision 2929c472 (git): [ruby/yarp] Add a convenience value method for numeric literals
https://github.com/ruby/yarp/commit/a328f27d8f Eregon (Benoit Daloze)
01:13 PM Revision 196116e5 (git): Refactor rb_ensure_iv_list_size
We don't really need obj_ivar_heap_alloc and obj_ivar_heap_realloc since
they're just one liners.
peterzhu2118 (Peter Zhu)
04:46 AM Revision 8326bf1a (git): [rubygems/rubygems] Confirm verification warnings
Fix up https://github.com/rubygems/rubygems/pull/6882
https://github.com/rubygems/rubygems/commit/71c73ac6d9
nobu (Nobuyoshi Nakada)

08/20/2023

05:32 PM Revision 55f930aa (git): [ruby/yarp] Use node kind for Ruby types
* For example in ProgramNode:
# attr_reader statements: Node
=>
# attr_reader statements: StatementsNode
https...
Eregon (Benoit Daloze)
05:22 PM Revision 725ca2f9 (git): [ruby/irb] Support `VISUAL` env var, and prefer it over `EDITOR`
(https://github.com/ruby/irb/pull/686)
* Support `VISUAL` env var, and prefer it over `EDITOR`
* Update test/irb/te...
smmr (Summer ☀️)
05:17 PM Revision 5c75dc51 (git): Update default gems list at 314ccdd60c5fe3dfa90651d271209e [ci skip]
git[bot]
05:16 PM Revision 314ccdd6 (git): [ruby/reline] Bump version to 0.3.8
(https://github.com/ruby/reline/pull/582)
https://github.com/ruby/reline/commit/3840d1f958
st0012 (Stan Lo)
05:03 PM Revision 405c295a (git): [ruby/reline] Use fdiv for keyseq_timeout msec to sec conversion
(https://github.com/ruby/reline/pull/583)
https://github.com/ruby/reline/commit/a6504acd63
tompng (tomoya ishida)
04:17 PM Bug #19841: Marshal.dump stack overflow with recursive Time
https://github.com/nobu/ruby/tree/marshal-recursive-userdef nobu (Nobuyoshi Nakada)
02:24 PM Bug #19794: Ruby 3.2.2 fails to build on macOS Sonoma betas
Thanks for the analysis. I've reported this as FB13016123 in Apple's feedback system.
Diagnosing situations like thi...
jhaungs (Jim Haungs)
05:56 AM Bug #19794: Ruby 3.2.2 fails to build on macOS Sonoma betas
> ld maintains a list of directories to search for a library or framework to use. The default library search path is... ecnelises (Chaofan QIU)
11:12 AM Revision 812272bd (git): Tempfile is not needed
nobu (Nobuyoshi Nakada)
11:12 AM Revision f0923164 (git): Align the type of `num_entries` to `st_table`
nobu (Nobuyoshi Nakada)
10:40 AM Revision 7c226291 (git): [ruby/reline] Remove Timeout usage
(https://github.com/ruby/reline/pull/580)
Timeout's implementation relies on Thread, which would conflict with
`ruby...
st0012 (Stan Lo)
09:07 AM Revision 35442005 (git): [rubygems/rubygems] fix lint
https://github.com/rubygems/rubygems/commit/75c0f27b7e Josh Nichols
09:07 AM Revision 7c4431e6 (git): [rubygems/rubygems] use a one-liner
https://github.com/rubygems/rubygems/commit/46745885e8 Josh Nichols
09:07 AM Revision e5efa01c (git): [rubygems/rubygems] handle removing `BUNDLE_`, since using start_with? would still include that
https://github.com/rubygems/rubygems/commit/235d9b38d8 Josh Nichols
09:06 AM Revision f0bf9391 (git): [rubygems/rubygems] Don't rely on globals when not matching regexp for "local."
https://github.com/rubygems/rubygems/commit/e79ccdafd8 Martin Emde
09:06 AM Revision b5a0630c (git): [rubygems/rubygems] Use ! methods once we have a new copy of the string. Use .prepend to avoid allocating a new string.
https://github.com/rubygems/rubygems/commit/2ac35a661f Josh Nichols
09:06 AM Revision 29aab66e (git): [rubygems/rubygems] call key.to_s once instead of multiple times to save when it's a symbol
https://github.com/rubygems/rubygems/commit/535feb817c Josh Nichols
09:06 AM Revision 239e3525 (git): [rubygems/rubygems] Use value.match? only on Strings, which avoids allocating a matchdata, which is not used
https://github.com/rubygems/rubygems/commit/cbf9ac93d7 Josh Nichols
09:06 AM Revision 598048e3 (git): [rubygems/rubygems] Use .to_s once in the beginning to save allocations if it's a symbol.
https://github.com/rubygems/rubygems/commit/f8167db8a2 Josh Nichols
09:06 AM Revision e921efa4 (git): [rubygems/rubygems] name is often a symbol, so only to_s once to avoid allocating it multiple times
https://github.com/rubygems/rubygems/commit/8eac49c429 Josh Nichols
09:06 AM Revision 7cb6cbee (git): [rubygems/rubygems] String#start_with? is faster than regex with beginning boundaries
https://github.com/rubygems/rubygems/commit/d7cde68034 Josh Nichols
09:06 AM Revision b97e45d0 (git): [rubygems/rubygems] Use ! methods on the array, since it is brand new. The individual keys are also new, so we can use ! methods on each individual one as well.
https://github.com/rubygems/rubygems/commit/f2e912b9bb Josh Nichols
09:06 AM Revision 2a61e1dc (git): [rubygems/rubygems] Use Array#union to join these, instead of with | multiple times. This saves allocating 2 arrays
https://github.com/rubygems/rubygems/commit/48c03b33b7 Josh Nichols
09:06 AM Revision 79b187a4 (git): [rubygems/rubygems] config is a new Hash, and config.values is a new Array. that means we can use bang methods to avoid allocating new copies
https://github.com/rubygems/rubygems/commit/8bc13fa55f Josh Nichols
09:05 AM Revision 921c2bba (git): [rubygems/rubygems] ENV.to_h returns a new hash, so we can `select!` it to avoid allocating another hash.
`String#start_with?` is faster than regex that is bound to the start of
a string.
https://github.com/rubygems/rubyge...
Josh Nichols
09:05 AM Revision 7e5c3ec5 (git): Update specification.rb
Co-authored-by: David Rodríguez <[email protected]> segiddins (Samuel Giddins)
09:05 AM Revision b68be40e (git): [rubygems/rubygems] Use assert_raise instead of assert_raises
For ruby-core compat
https://github.com/rubygems/rubygems/commit/83aa7b794e
segiddins (Samuel Giddins)
09:05 AM Revision 1935433f (git): [rubygems/rubygems] Ensure that loading multiple gemspecs with legacy YAML class references does not warn
Before this, you would get constant redefinition warnings on Psych::DefaultKey
Additionally, ensure the retries wont...
segiddins (Samuel Giddins)
09:04 AM Revision f69f775f (git): [rubygems/rubygems] choose_from_list may return nil index since
https://github.com/rubygems/rubygems/commit/abacb0cb34cd
https://github.com/rubygems/rubygems/commit/5e2e9d6e50
matsuda (Akira Matsuda)
04:29 AM Revision d5ffbca5 (git): Move `MKSTR` markers for fake.rb into coments
nobu (Nobuyoshi Nakada)
04:26 AM Revision e517ba2e (git): Bump up syntax_suggest-1.1.0
hsbt (Hiroshi SHIBATA)
03:37 AM Bug #19761: AddressSanitizer fails with Thread and Process
For `70ce3c8947c7f95897e56b397270c061dd50f280`, I did a fresh build with `-fsanitize=address` CFLAGS, not reproduced.... ecnelises (Chaofan QIU)
12:28 AM Bug #19246: Rebuilding the loaded feature index much slower in Ruby 3.1
@MSP-Greg Thank you for investigations and providing patches! I will handle it soon. nagachika (Tomoyuki Chikanaga)

08/19/2023

07:47 PM Bug #19246: Rebuilding the loaded feature index much slower in Ruby 3.1
@nagachika
Thanks for your work on this. Please see https://github.com/ruby/ruby/pull/8252
MSP-Greg (Greg L)
06:02 PM Revision 70ce3c89 (git): [rubygems/rubygems] Fix leaked tempfiles
Fix up https://github.com/rubygems/rubygems/pull/6882
https://github.com/rubygems/rubygems/commit/525b94a89f
nobu (Nobuyoshi Nakada)
01:30 PM Bug #19841: Marshal.dump stack overflow with recursive Time
Right, I fear the best we can do is to detect this case and raise a cleaner error. byroot (Jean Boussier)
10:12 AM Bug #19841: Marshal.dump stack overflow with recursive Time
Not only would be data compatibility broken, but I think data created by "remembering" the index of an instance first... nobu (Nobuyoshi Nakada)
08:21 AM Bug #19841: Marshal.dump stack overflow with recursive Time
Hum, this is tricky.
`Time` implements `_dump`, so we enter this branch:
```c
if (rb_obj_respond_to(ob...
byroot (Jean Boussier)
07:53 AM Bug #19841: Marshal.dump stack overflow with recursive Time
It repros on 3.0, 3.1 and `master`. byroot (Jean Boussier)
01:14 AM Revision 79558738 (git): Update default gems list at bd440bf85d6eff5ecf5132e93a0721 [ci skip]
git[bot]
01:14 AM Revision bd440bf8 (git): [ruby/yarp] Bump to version 0.8.0
https://github.com/ruby/yarp/commit/bfde753702 kddnewton (Kevin Newton)
01:04 AM Revision 1d0b627b (git): [ruby/yarp] Rename statements to body where appropriate
https://github.com/ruby/yarp/commit/0aa7d9d10c kddnewton (Kevin Newton)

08/18/2023

10:27 PM Revision 3dff315e (git): YJIT: Quiet mode when running with `--yjit-stats` (#8251)
Quiet mode for running with --yjit-stats ywenc (CY Wen)
08:25 PM Revision 07833049 (git): [ruby/yarp] Consolidate operator write nodes
https://github.com/ruby/yarp/commit/22b287e2b1 kddnewton (Kevin Newton)
08:24 PM Revision ec47fc95 (git): [ruby/yarp] Consolidate OperatorAndWrite and OperatorOrWrite nodes
https://github.com/ruby/yarp/commit/9e680a7598 kddnewton (Kevin Newton)
07:14 PM Revision 3d7a0301 (git): [rubygems/rubygems] Resolve ruby version file relative to bundle root
This is a follow up to https://github.com/rubygems/rubygems/issues/6742.
This change makes it so that the version fil...
Ngan Pham
06:53 PM Bug #19841 (Closed): Marshal.dump stack overflow with recursive Time
``` ruby
#!/usr/bin/env ruby
puts RUBY_VERSION
t = Time.at(0, 1, :nanosecond)
t.instance_variable_set :@itsel...
segiddins (Samuel Giddins)
06:30 PM Revision e1505aeb (git): [ruby/yarp] fix: multiple heredocs with embedded expressions with newlines
Set heredoc_end to NULL at the start of lexing a heredoc, to avoid
having state from the previous heredoc confuse the...
mdalessio (Mike Dalessio)
06:05 PM Revision db076d8e (git): [ruby/yarp] handle missing HEREDOC endline at start of heredoc
https://github.com/ruby/yarp/commit/7b72493b6d HParker (Adam Hess)
05:05 PM Feature #19839: Need a method to check if two ranges overlap
Related to #16757 Dan0042 (Daniel DeLorme)
06:56 AM Feature #19839: Need a method to check if two ranges overlap
Thank you for your feedback.
> I've made several helpers for this exact same problem, as well as a `Range#merge` i...
shouichi (Shouichi Kamiya)
04:24 AM Feature #19839: Need a method to check if two ranges overlap
What do you expect when it is called with a non-Range object, `TypeError`, same as `cover?` or something else? nobu (Nobuyoshi Nakada)
02:09 AM Feature #19839: Need a method to check if two ranges overlap
I've made several helpers for this exact same problem, as well as a `Range#merge` in the past. I would very much be i... baweaver (Brandon Weaver)
01:30 AM Feature #19839 (Closed): Need a method to check if two ranges overlap
It would be convenient to have a method that checks if two ranges overlap. For example,
```
(0..10).overlap?(5..1...
shouichi (Shouichi Kamiya)
04:47 PM Misc #19766: DevMeeting-2023-08-24
* [Bug #19779] `eval "return"` at top level raises `LocalJumpError` (jeremyevans0)
* Do we want to allow `eval "re...
jeremyevans0 (Jeremy Evans)
04:42 PM Revision 744bc4d5 (git): [rubygems/rubygems] Make nil a valid license spec
https://github.com/rubygems/rubygems/commit/675effb67e John Hong
04:17 PM Revision 4524aeba (git): YJIT: Fix return type of Integer#/ with T_FIXNUM inputs
Issue found by running ruby/spec with `--yjit-verify-ctx`. Thanks! alanwu (Alan Wu)
02:35 PM Bug #19837: Concurrent calls to Process.waitpid2 misbehave on Ruby 3.1 & 3.2
Thanks - yeah it’s no problem if it doesn’t get back ported to 3.0. kjtsanaktsidis (KJ Tsanaktsidis)
02:32 PM Bug #19837 (Closed): Concurrent calls to Process.waitpid2 misbehave on Ruby 3.1 & 3.2
This updates the backport flags. Note that Ruby 3.0 is in security maintenance, and this doesn't appear to be securi... jeremyevans0 (Jeremy Evans)
02:28 PM Bug #19837: Concurrent calls to Process.waitpid2 misbehave on Ruby 3.1 & 3.2
OK - I hope I've done this right, let me know otherwise :)
* Ruby 3.0: https://github.com/ruby/ruby/pull/8248
* R...
kjtsanaktsidis (KJ Tsanaktsidis)
02:25 PM Revision c8d64199 (git): Refactor ary_make_partial
peterzhu2118 (Peter Zhu)
02:05 PM Revision 314eed8a (git): YJIT: implement fast path for integer multiplication in opt_mult (#8204)
* YJIT: implement fast path for integer multiplication in opt_mult
* Update yjit/src/codegen.rs
Co-authored-by: Ala...
maximecb (Maxime Chevalier-Boisvert)
01:24 PM Revision 724223b4 (git): Don't check for STR_NOEMBED in rb_fstring
We don't need to check for STR_NOEMBED because the check above for
STR_EMBED_P means that it can never be false.
peterzhu2118 (Peter Zhu)
12:51 PM Revision 2800d1fd (git): [ruby/yarp] fix: unterminated % in arguments
https://github.com/ruby/yarp/commit/efb3102369 mdalessio (Mike Dalessio)
08:21 AM Revision 20106fe2 (git): [rubygems/rubygems] Update SPDX license list as of 2023-06-18
https://github.com/rubygems/rubygems/commit/3db9165335 License Update
08:12 AM Revision 57dfd5c2 (git): Revert "Fix tool/update-deps for YARP files"
This reverts commit 6fff5c5ba23a2790c9d189de82e157c9fa986f96.
Revert "Use $(top_srcdir) entries for mswin (#8244)"
...
k0kubun (Takashi Kokubun)
08:07 AM Revision 6fff5c5b (git): Fix tool/update-deps for YARP files
k0kubun (Takashi Kokubun)
07:48 AM Revision e327bf32 (git): Use $(top_srcdir) entries for mswin (#8244)
While the $(VPATH) rules live in common.mk, mswin seems to ignore them.
We need to use $(VPATH) for OpenBSD, but we n...
k0kubun (Takashi Kokubun)
07:34 AM Revision aba26a88 (git): Update dependencies
k0kubun (Takashi Kokubun)
07:20 AM Revision 2046e054 (git): Use {$(VPATH)} for OpenBSD
Scratch build on OpenBSD has been failing since 67b5f63e97.
`make; make` works though. (`make` alone doesn't work)
I...
k0kubun (Takashi Kokubun)
05:12 AM Revision 6a6dacb0 (git): Attempt to recover from YARP sync failures
k0kubun (Takashi Kokubun)
04:47 AM Revision 7a2aeadb (git): Attempt to explain what sync_default_gems_with_commits does [ci skip]
k0kubun (Takashi Kokubun)
04:28 AM Feature #19840 (Feedback): [Proposal] Expand Find pattern to Multiple Find
Hello! I love Ruby's pattern matching features. I would like to propose an expansion of the Find pattern which allows... FlickGradley (Nick Bradley)
03:58 AM Bug #19829: Enumerator.product called with keyword arguments raises exception with not precise message
I submitted a pull request to fix this, by adding an rb_no_keywords_accepted C-API function and using that for both C... jeremyevans0 (Jeremy Evans)
03:55 AM Revision 412defc7 (git): [ruby/io-console] Get rid of address of an rvalue on TruffleRuby
https://github.com/ruby/io-console/commit/653c1cd33f nobu (Nobuyoshi Nakada)
03:55 AM Revision 818ba30e (git): [ruby/io-console] Avoid the influence of special variable `$/`
https://github.com/ruby/io-console/commit/5f71354332 nobu (Nobuyoshi Nakada)
03:55 AM Revision cff80587 (git): [ruby/io-console] Ensure to put a newline after password
https://github.com/ruby/io-console/commit/15e36af171 nobu (Nobuyoshi Nakada)
03:55 AM Revision 528da434 (git): [ruby/io-console] Flush after prompt
https://github.com/ruby/io-console/commit/040a1d6259 nobu (Nobuyoshi Nakada)
03:55 AM Revision 540cf432 (git): [ruby/io-console] Enable `getpass` methods always
https://github.com/ruby/io-console/commit/57f9649df4 nobu (Nobuyoshi Nakada)
01:17 AM Revision 1bbce429 (git): [ruby/io-console] [DOC] Remove a trailing space from the prompt too
https://github.com/ruby/io-console/commit/85a155f25f nobu (Nobuyoshi Nakada)
01:15 AM Revision 1107cfd0 (git): [ruby/io-console] * remove trailing spaces [ci skip]
https://github.com/ruby/io-console/commit/a0544eb74f nobu (Nobuyoshi Nakada)
01:02 AM Revision 43802a08 (git): [ruby/io-console] [DOC] IO::console.getpass usage example
There were no clear example of this very useful method's usage anywhere
in the IO or IO::Console docs, which was a sh...
olivierlacan (Olivier Lacan)
12:58 AM Revision ad2bad4a (git): Fix the scope of rubygems conflict resolution
The `git reset` and `rm_rf` are not necessary because `bundler/` is
considered as a `toplevels` and removed from the ...
k0kubun (Takashi Kokubun)
12:55 AM Revision 434cbc05 (git): Document the existence of sync_default_gems.rb -a [ci skip]
k0kubun (Takashi Kokubun)
12:06 AM Revision 995fd11b (git): [ruby/yarp] Remove strange :"#arg_rest" local
https://github.com/ruby/yarp/commit/66ecec218d kddnewton (Kevin Newton)

08/17/2023

11:16 PM Revision e9134316 (git): [rubygems/rubygems] Raise Gem::Package::FormatError on EOF, indicating corrupt gem
Gem::Package::TarReader::Entry now raises EOFError or returns nil
appropriately based on Ruby core IO.read and IO.rea...
martinemde (Martin Emde)
10:15 PM Misc #19766: DevMeeting-2023-08-24
* [Misc #19777] Make `Kernel#lambda` raise when called without a literal block
* There are two code paths for dete...
alanwu (Alan Wu)
10:08 PM Bug #19837: Concurrent calls to Process.waitpid2 misbehave on Ruby 3.1 & 3.2
@kjtsanaktsidis Yes, please prepare backport pull requests for ruby_3_2 and ruby_3_1, then we can update the backport... jeremyevans0 (Jeremy Evans)
10:06 PM Revision e504c368 (git): Remove obsoleted yp_-renaming logic
This has not been relevant since https://github.com/ruby/yarp/pull/1199. k0kubun (Takashi Kokubun)
10:04 PM Revision 78e7fd7b (git): Include YARP templated files in snapshots
Those files should be part of CRuby distributions. k0kubun (Takashi Kokubun)
10:02 PM Bug #19791 (Closed): Debugger does not handle delete key correctly
jeremyevans0 (Jeremy Evans)
09:58 PM Feature #19776 (Closed): Warn bundled gems when it called from `require`
jeremyevans0 (Jeremy Evans)
09:55 PM Bug #19770 (Third Party's Issue): TLS / Certificate Hostname Verification against IP fails with "address family must be specified"
Schachi65 (Joachim Schachermayer) wrote in #note-2:
> In that case, the hostname is a human readable IP: 192.168.55....
jeremyevans0 (Jeremy Evans)
09:52 PM Revision 72a16c61 (git): Move the dependency of node.rb and serialize.rb
to `main`.
This is what lib/ruby_vm/rjit/instruction.rb currently does. Letting
.time depend on those files was just...
k0kubun (Takashi Kokubun)
09:39 PM Revision 67b5f63e (git): Render YARP templates in the build process (#8228)
k0kubun (Takashi Kokubun)
09:17 PM Revision 5d48825d (git): YJIT: Fix String#<< return type
We previously falsely asserted that String#<< always returns a ::String
instance. Issue was discovered on CI with `--...
alanwu (Alan Wu)
09:14 PM Revision 518d5ab5 (git): Add note about rb_f_notimplement [ci skip]
Co-authored-by: Takashi Kokubun <[email protected]> alanwu (Alan Wu)
09:14 PM Revision 9683eb06 (git): YJIT: Fix Kernel#respond_to? handling of rb_f_notimplement
We should return false for this type of special methods but wasn't
previously. Was reproducible with:
make test-...
alanwu (Alan Wu)
08:57 PM Revision 57ec1673 (git): YARP: Ignore Rust sync failures
k0kubun (Takashi Kokubun)
07:53 PM Revision 5db8b9b3 (git): Move total_freed_objects to size pool
This commit moves the `total_freed_objects` statistic to the size pool
which allows for `total_freed_objects` key in ...
peterzhu2118 (Peter Zhu)
07:53 PM Revision 52506cbf (git): Move total_allocated_objects to size pool
This commit moves the `total_allocated_objects` statistic to the size
pool which allows for `total_allocated_objects`...
peterzhu2118 (Peter Zhu)
05:27 PM Revision 818998b4 (git): Refactor YARP_IGNORE_FILE_PATTERN
`.git.*` covers those two cases.
Co-authored-by: Nobuyoshi Nakada <[email protected]>
k0kubun (Takashi Kokubun)
05:21 PM Misc #19772: API naming for YARP compiler
nobu (Nobuyoshi Nakada) wrote in #note-5:
> I don't think "YA-" names nice in general, unless for development code n...
jemmai (Jemma Issroff)
05:01 PM Revision f50e814d (git): Resync YARP to https://github.com/ruby/yarp/commit/11ad3fb590
k0kubun (Takashi Kokubun)
04:58 PM Revision 40002dd7 (git): Resync YARP
k0kubun (Takashi Kokubun)
04:58 PM Revision 81d71509 (git): [ruby/yarp] Treat yp_buffer_t as an opaque pointer
Right now, we have to keep the buffer FFI object in sync with the
definition of yp_buffer_t because we access its fie...
kddnewton (Kevin Newton)
04:07 PM Revision 75a47675 (git): [rubygems/rubygems] Add `file` option to `ruby` method in Gemfile
https://github.com/rubygems/rubygems/commit/fb9354b7bf Ngan Pham
02:11 PM Revision 30a5b945 (git): YJIT: implement side chain fallback for setlocal to avoid exiting (#8227)
* YJIT: implement side chain fallback for setlocal to avoid exiting
* Update yjit/src/codegen.rs
Co-authored-by: Ta...
maximecb (Maxime Chevalier-Boisvert)
10:39 AM Revision 7433c8f7 (git): [rubygems/rubygems] Clarify that `bundle info` takes a gem name
https://github.com/rubygems/rubygems/commit/09ef74ef73 manu (Emmanuel Pinault)
10:29 AM Revision 8c447cff (git): Lrama v0.5.4
yui-knk (Kaneko Yuichiro)
07:30 AM Revision d26b015e (git): [Bug #19831] Remove duplicate library options
`$(LIBRUBYARG_SHARED)` is included in `$(LIBS)` in extension
libraries.
nobu (Nobuyoshi Nakada)
03:28 AM Revision e210b899 (git): Move the PC regardless of the leaf flag (#8232)
Co-authored-by: Alan Wu <[email protected]> k0kubun (Takashi Kokubun)
01:57 AM Bug #19831 (Closed): warning message of linker with macOS Sonoma beta
Applied in changeset commit:git|5bb946228550c7f171c27725860b153a675404f3.
----------
[Bug #19831] Remove duplicate l...
nobu (Nobuyoshi Nakada)
01:57 AM Revision 5bb94622 (git): [Bug #19831] Remove duplicate library options
`$(MAINLIBS)` should be included in `$(LIBRUBYARG)` in cases it is
needed.
nobu (Nobuyoshi Nakada)
01:16 AM Revision 48b241e5 (git): [ruby/yarp] Fix errors on locals test caused by LANG=C
https://github.com/ruby/yarp/commit/8fae286bc9 kddnewton (Kevin Newton)
12:55 AM Revision 1c53e64c (git): Fix a regexp error
k0kubun (Takashi Kokubun)
12:55 AM Revision cdb757f8 (git): Avoid synchronizing GitHub Actions from YARP
k0kubun (Takashi Kokubun)
12:51 AM Revision 7183cf53 (git): Revert an unintended revert
k0kubun (Takashi Kokubun)
12:48 AM Revision f1778870 (git): Update default gems list at 45740e7a248b4b995644646e38d94b [ci skip]
git[bot]
12:47 AM Revision 45740e7a (git): [ruby/yarp] Use _snprintf when using Windows versions prior to 2015 (< 1900)
Ruby CI has informed us that snprintf is not available on Windows
versions, but _sprintf is supported. This commit al...
jemmai (Jemma Issroff)
12:47 AM Revision c989c1b0 (git): [ruby/yarp] Omit locals test if running on a 32 bit machine
https://github.com/ruby/yarp/commit/809d046f36 jemmai (Jemma Issroff)
12:47 AM Revision 87f74a34 (git): Update dependencies
k0kubun (Takashi Kokubun)
12:47 AM Revision f20dfd08 (git): Fix the YARP init path
k0kubun (Takashi Kokubun)
12:47 AM Revision 3873b1eb (git): Resync YARP
k0kubun (Takashi Kokubun)
12:47 AM Revision 957cd369 (git): [ruby/yarp] Add test for empty heredoc
https://github.com/ruby/yarp/commit/e49b63a79e kddnewton (Kevin Newton)
12:47 AM Revision 3536cad9 (git): [ruby/yarp] Fixes so `bundle exec rake` can run on JRuby and TruffleRuby
https://github.com/ruby/yarp/commit/e6cea4fa08 Eregon (Benoit Daloze)
12:47 AM Revision 958ac8d5 (git): [ruby/yarp] Test all methods of the YARP Ruby API
https://github.com/ruby/yarp/commit/a723f40baf Eregon (Benoit Daloze)
12:47 AM Revision a8c70ed2 (git): [ruby/yarp] add a diagnostic for *rest in order after optional state
https://github.com/ruby/yarp/commit/908244ba12 HParker (Adam Hess)
12:47 AM Revision bf723b21 (git): [ruby/yarp] More flip flop flags
Whenever you see a `not` or a `!`, the receiver of that method should
potentially be marked as a flip-flop.
https://...
kddnewton (Kevin Newton)
12:47 AM Revision fb287fa4 (git): [ruby/yarp] Support the flipflop flag
https://github.com/ruby/yarp/commit/6315890390 kddnewton (Kevin Newton)
12:47 AM Revision ecf2e84c (git): [ruby/yarp] Add a CHANGELOG
https://github.com/ruby/yarp/commit/b490ff0919 kddnewton (Kevin Newton)
12:47 AM Revision 86cc82a1 (git): [ruby/yarp] Improved comments, moved flags after type
https://github.com/ruby/yarp/commit/4815d77e82 jemmai (Jemma Issroff)
12:47 AM Revision 383c47f5 (git): [ruby/yarp] Separate yp_node_flags_t from yp_node_type_t
Prior to this commit, we folded the flags into the type. This created
extra overhead when calculating the type and se...
jemmai (Jemma Issroff)
12:47 AM Revision 89de5444 (git): [ruby/yarp] Set constant path write node target type
https://github.com/ruby/yarp/commit/771f7ed789 kddnewton (Kevin Newton)
12:47 AM Revision ee885237 (git): [ruby/yarp] Fix string concat parsing
https://github.com/ruby/yarp/commit/58f839a3eb kddnewton (Kevin Newton)
12:47 AM Revision 77e52735 (git): [ruby/yarp] Fix warnings found from gcc-analyzer and clang-analyzer
https://github.com/ruby/yarp/commit/1f9a6e05c4 kddnewton (Kevin Newton)
12:47 AM Revision 9b952670 (git): [ruby/yarp] Less const_get
Right now whenever you go to create a Ruby object from a C struct
we dynamically look up the constants. This is not g...
kddnewton (Kevin Newton)
12:47 AM Revision 96aebb42 (git): [ruby/yarp] Address PR comments
- odd whitespace
- a couple of name changes
- properly read uint32_t when not properly aligned
https://github.com/ru...
enebo (Thomas Enebo)
12:47 AM Revision d6f9f3e4 (git): [ruby/yarp] Rename RescueNode#exception to RescueNode#reference
https://github.com/ruby/yarp/commit/ad0eb4b2c3 kddnewton (Kevin Newton)
12:47 AM Revision a793260c (git): [ruby/yarp] Also rework regexp lexer to check terminators properly
https://github.com/ruby/yarp/commit/4b157a8352 kddnewton (Kevin Newton)
12:47 AM Revision 2ef54d38 (git): [ruby/yarp] Rework the list lexer to check terminators properly
https://github.com/ruby/yarp/commit/60315d0f13 kddnewton (Kevin Newton)
12:47 AM Revision 5e939727 (git): [ruby/yarp] Handle escaping in regexp slow path
https://github.com/ruby/yarp/commit/8dd0a1b281 kddnewton (Kevin Newton)
12:47 AM Revision 72571453 (git): [ruby/yarp] Clang beats gcc in pedantry
Accidentally declared int32_t and not uint32_t and it was caught
on macos.
https://github.com/ruby/yarp/commit/65815...
enebo (Thomas Enebo)
12:47 AM Revision 1e0749e0 (git): [ruby/yarp] Addressed review comments.
Missing any tests and in fact this is untested so still a WIP.
https://github.com/ruby/yarp/commit/5411abd651
enebo (Thomas Enebo)
12:47 AM Revision 0b6a26ab (git): [ruby/yarp] Provide slow path for finding ) in regexp when encoding changes
https://github.com/ruby/yarp/commit/c1064a65e3 kddnewton (Kevin Newton)
12:47 AM Revision 0004565a (git): [ruby/yarp] Use yp_memchr in regexp parsing
https://github.com/ruby/yarp/commit/08081dd24f kddnewton (Kevin Newton)
12:47 AM Revision 1ad0d198 (git): [ruby/yarp] Parse individual snippets of test/fixtures/*.txt
* To ensure the parser does not try to read bytes further than the end of each snippet.
https://github.com/ruby/yarp...
Eregon (Benoit Daloze)
12:47 AM Revision 3f64defe (git): [ruby/yarp] Make sure lexing ? does not read off the end
https://github.com/ruby/yarp/commit/d694e3ebf2 kddnewton (Kevin Newton)
12:47 AM Revision d2eb82d9 (git): [ruby/yarp] Fix test to use the new location of yarp.so
https://github.com/ruby/yarp/commit/a22b204a11 Eregon (Benoit Daloze)
12:47 AM Revision 1002b777 (git): [ruby/yarp] Automatically find the right line for yarp/serialize.rb newline test
https://github.com/ruby/yarp/commit/5908130541 Eregon (Benoit Daloze)
12:47 AM Revision 820a58c2 (git): [ruby/yarp] Hide debug methods
https://github.com/ruby/yarp/commit/aa0dc2f301 kddnewton (Kevin Newton)
12:47 AM Revision 1ea9e444 (git): [ruby/yarp] Fix memory leak from constant write node creation
https://github.com/ruby/yarp/commit/0071bee0bb kddnewton (Kevin Newton)
12:47 AM Revision e66e60cf (git): [ruby/yarp] Handle invalid multiple parameters
https://github.com/ruby/yarp/commit/2f83265653 kddnewton (Kevin Newton)
12:47 AM Revision 7a1c4974 (git): [ruby/yarp] Add constant write node
https://github.com/ruby/yarp/commit/a62f2f0153 kddnewton (Kevin Newton)
12:47 AM Revision 9c61e0c8 (git): [ruby/yarp] Ensure token cannot begin an expression
https://github.com/ruby/yarp/commit/837522217c kddnewton (Kevin Newton)
12:47 AM Revision 3d032cf3 (git): [ruby/yarp] Simplify creation of numerics
https://github.com/ruby/yarp/commit/e5f6ffa23a kddnewton (Kevin Newton)
12:47 AM Revision b6f26c2e (git): [ruby/yarp] Use common fields for yp_string_t
* Otherwise it is undefined behavior to access the field of another `.as`.
* Accessing the right `.as` field accordin...
Eregon (Benoit Daloze)
12:47 AM Revision ab2f638a (git): [ruby/yarp] Test YARP.parse_file by using it in tests
https://github.com/ruby/yarp/commit/c603bba89a Eregon (Benoit Daloze)
12:47 AM Revision 7cc5b22b (git): [ruby/yarp] Add comment that extension.c should not contain non-trivial logic
https://github.com/ruby/yarp/commit/638f6849be Eregon (Benoit Daloze)
12:47 AM Revision e712bc9b (git): [ruby/yarp] Move efficient file reading using demand paging to librubyparser
* So it can be reused by the Fiddle backend, etc and not just the C extension.
* Add YP_STRING_MAPPED to use a consis...
Eregon (Benoit Daloze)
12:47 AM Revision 2ccaaaa1 (git): [ruby/yarp] Add simpler exported unescape function to librubyparser
* Moves logic from the C extension to librubyparser which can be shared with the Fiddle backend.
https://github.com/...
Eregon (Benoit Daloze)
12:47 AM Revision 31960a96 (git): [ruby/yarp] Handle missing block parameters
https://github.com/ruby/yarp/commit/bc9049418d kddnewton (Kevin Newton)
12:47 AM Revision eca3b934 (git): [ruby/yarp] **nil can be a STAR_STAR token
https://github.com/ruby/yarp/commit/33b06f252c kddnewton (Kevin Newton)
12:47 AM Revision e56da356 (git): [ruby/yarp] Handle invalid regexps more gracefully
https://github.com/ruby/yarp/commit/584a49f123 kddnewton (Kevin Newton)
12:47 AM Revision 4c4e75c0 (git): [ruby/yarp] Add error cases for ustar appearing in infix position
https://github.com/ruby/yarp/commit/8736c17359 kddnewton (Kevin Newton)
12:47 AM Revision cededf73 (git): [ruby/yarp] For errored % characters, use TOKEN_PERCENT and not TOKEN_STRING_BEGIN
https://github.com/ruby/yarp/commit/2ec671fe1e kddnewton (Kevin Newton)
12:47 AM Revision 242f3c3a (git): [ruby/yarp] Don't read off the end when parsing % literals
https://github.com/ruby/yarp/commit/aff40871e6 kddnewton (Kevin Newton)
12:47 AM Revision 45efbadb (git): [ruby/yarp] Enable all of -wconversion
https://github.com/ruby/yarp/commit/638163f6c6 kddnewton (Kevin Newton)
12:47 AM Revision f1658efe (git): [ruby/yarp] Split out newline test
https://github.com/ruby/yarp/commit/eeb4f6cb9d kddnewton (Kevin Newton)
12:47 AM Revision 41e8ba01 (git): [ruby/yarp] Mark locations in the tree where newlines can occur
https://github.com/ruby/yarp/commit/479e835756 kddnewton (Kevin Newton)
12:47 AM Revision 86b32dac (git): [ruby/yarp] Handle pound terminator in isolation
https://github.com/ruby/yarp/commit/1cfce46107 kddnewton (Kevin Newton)
12:47 AM Revision ede55edb (git): [ruby/yarp] Remove trailing whitespace
https://github.com/ruby/yarp/commit/04de272383 enebo (Thomas Enebo)
12:47 AM Revision 76c77b5e (git): [ruby/yarp] WIP - Introduce contextually parsing programs vs evals
This is more or less the code I used in my POC in JRuby
to parse evals. Evals depend on parent variable scopes
and w...
enebo (Thomas Enebo)
12:47 AM Revision 0f809194 (git): [ruby/yarp] Move the gem's C extension into lib/yarp/
and change the require from "yarp.so" to "yarp/yarp", which is more
aligned with existing community conventions for g...
Mike Dalessio
12:47 AM Revision c5dad5f1 (git): Sync script updates
jemmai (Jemma Issroff)
 

Also available in: Atom