Activity
From 09/07/2024 to 09/13/2024
09/13/2024
-
08:58 PM Bug #20736: prism emits wrong warnings in syntax-error code
- Right now Prism is lexing `9a` as an integer and then an identifier. So it's effectively parsing it as `1; 2; 9; a`. That's why it's warning that `9` is a useless literal. I could change this in the parser to parse it instead as a missin...
-
07:51 PM Bug #20736: prism emits wrong warnings in syntax-error code
- Although I can understand the technical reason, I still feel a bit uncomfortable when the warning says “use of a literal” since `9a` is clearly not a literal to the human eye.
As a practical matter, this behavior causes a lot of warni... -
-
- This is because Prism recovers from the syntax error. For example:
```ruby
eval("1; 2; 9a; 3; 4; 5; 9b")
```
with Prism this will give:
```
(eval at test.rb:1):1: warning: possibly useless use of a literal in void context
(e... -
- ```
$ ./local/bin/ruby -w --parser=parse.y -e 'begin eval("0a"); rescue SyntaxError; end'
$ ./local/bin/ruby -w --parser=prism -e 'begin eval("0a"); rescue SyntaxError; end'
(eval at -e:1):1: warning: possibly useless use of a literal... -
- https://github.com/ruby/prism/commit/4ed7de537b
-
07:16 PM Bug #20473: Ractor array/hash literals
- Okay, makes sense. Maybe if/when ractors are used more I'll take a look at this again.
-
- https://github.com/ruby/prism/commit/0b527ca93f
-
-
- I have opened https://github.com/ruby/ruby/pull/11622 to fix this.
-
- ```
$ ./local/bin/ruby -w --parser=parse.y -e 'def foo(&) = nil; foo &:bar'
$ ./local/bin/ruby -w --parser=prism -e 'def foo(&) = nil; foo &:bar'
-e:1: warning: ambiguous `&` has been interpreted as an argument prefix
``` -
- Applied in changeset commit:git|9afc6a981deae6e23d938cf5c2c4baadfeaafdb1.
----------
[PRISM] Only parse shebang on main script
Fixes [Bug #20730] -
- I have opened https://github.com/ruby/ruby/pull/11617 to fix this.
-
01:19 AM Bug #20730 (Closed): LoadError if Rakefile has shebang
- `LoadError` exception will be raised when invoke the rake task with latest ruby 3.4-dev.
### Reproduce code
Here is example code.
```ruby
#!/usr/bin/env rake
p "Hello"
```
### Result
```
$ ruby -v
ruby 3.4.0dev (2024-09... -
- Fixes [Bug #20735]
-
05:44 PM Feature #20309: Bundled gems for Ruby 3.5
- Regarding `irb`, I find it concerning that we need to add code like this: https://github.com/ruby/ruby/blob/9afc6a981deae6e23d938cf5c2c4baadfeaafdb1/prelude.rb#L12-L44. Those are internals of Bundler that are likely to break, and I can't...
-
05:16 PM Bug #20737: Accidentally changed warning target on Ruby 3.3
- Agreed, I didn't expect new warnings in 3.3.5 when 3.3.4 did not warn, and extra warnings can break CI (e.g. #20713).
-
05:57 AM Bug #20737 (Closed): Accidentally changed warning target on Ruby 3.3
- https://github.com/ruby/ruby/pull/11613
-
04:10 AM Bug #20737: Accidentally changed warning target on Ruby 3.3
- Makes sense. Let's revert that back to the Ruby 3.3.4 one in Ruby 3.3.6.
-
- I heard that concern from yhonda.
I request to backport bundled_gems.rb that is same version of the current master. After that, Ruby 3.3.5 show warnings when some default gems was loaded.
https://github.com/ruby/ruby/blob/ruby_3_3/... -
- I think it's a real issue and sometimes valuable to fix (it hurts the coverage of tests * flags).
#6648 could be helpful to automatically inherit passed flags.
Alternatively, we could ensure we only pass options for tests through `RUBYOP... -
- I'm not sure if anything needs to change here, but I wanted to report this in case anyone had any particular ideas. When running the ruby/ruby test suite, lots of tests call `EnvUtil.invoke_ruby` directly or indirectly through `assert_in...
-
-
- I have opened https://github.com/ruby/ruby/pull/11620 to fix this.
-
-
- @mame
Thanks! -
- The wrong warning with `rss` gem is a different issue. I have created a separate ticket #20732.
-
- I also have similar issues with `rss`.
```
/Users/hsbt/Documents/github.com/ruby/ruby/gems/src/rss/lib/rss/1.0.rb:81: warning: mismatched indentations at ‘else’ with ‘if’ at 79
(snip)
```
https://github.com/ruby/rss/blob/master/... -
01:20 AM Bug #20731 (Closed): warning: mismatched indentations at 'when' appears with prism enabled ruby
- ### Steps to reproduce
1. Create a `case_sample.rb` file
```
foo = :bar
case foo
when :bar
p 'foo is :bar'
when :baz
# do something
else
# do something
end
```
2. Run this file against the latest Ruby 3.4.0... -
- Fixes [Bug #20730]
-
- Fixes [Bug #20731]
-
- PR here: https://github.com/ruby/ruby/pull/11621
-
- I found a coding issue in prism_compile.c but I can't find a bug that would result from it.
The `current_block` is not set back when a block is given. -
- Applied in changeset commit:git|74f315c3f5908512dfdeeab2dd76d93e98149769.
----------
[PRISM] Turn off mismatched indentation warnings in eval
Fixes [Bug #20732] -
- I have opened https://github.com/ruby/ruby/pull/11618 to fix this.
-
- ```ruby
eval(<<-EOC)
if @check
end
EOC
```
```
$ ruby --parser=parse.y -w t.rb
$ ruby --parser=prism -w t.rb
(eval at t.rb:1):2: warning: mismatched indentations at 'end' with 'if' at 1
```
This issue actually occurs in ... -
- Fixes [Bug #20732]
-
03:05 PM Revision 353997dd (git): [ruby/prism] Refactor and move common node flags count into a constant to reuse in templates
- https://github.com/ruby/prism/commit/c20bf05ecc
-
- https://github.com/ruby/prism/commit/dbb7e0a44e
-
02:58 PM Feature #20738: Removing a specific entry from a hash literal
- With the previous idea, I can't have both removing entries and returning nil depending on the condition.
``` ruby
# If user.child? is true and user.parent is nil, I want parent_name: nil, but the entry is removed.
{
?parent_name:... -
- nobu (Nobuyoshi Nakada) wrote in #note-1:
> "A special value" doesn't feel like a good idea to me.
Hmmm, does that mean we should extend the syntax? For example, something like this?
``` ruby
{
foo: 1,
?bar: nil
} #=> {foo... -
- Yes, I sometimes do that as well. However, I am not happy that the shape of the resulting hash is unclear.
-
11:59 AM Feature #20738: Removing a specific entry from a hash literal
- How about using `**`?
```ruby
def bar? = false
{
foo: 1,
**(bar? ? { bar: 2 } : {})
}
# => {:foo=>1}
```
Also, you can use `**nil` in ruby 3.4-dev.
```ruby
def bar? = false
{
foo: 1,
**({ bar: 2 } if bar?)... -
07:57 AM Feature #20738: Removing a specific entry from a hash literal
- "A special value" doesn't feel like a good idea to me.
-
- Sometimes I want to decide whether or not to add a particular entry to a hash depending on a condition. If the entire hash does not use nil, I can use Hash#compact.
```ruby
{
foo: 1,
bar: bar? ? 2 : nil
}.compact
```
But i... -
02:06 PM Revision c996f409 (git): Ignore -Wdangling-pointer in rb_gc_set_stack_end
- Fixes this compiler warning:
thread.c:4530:18: warning: storing the address of local variable ‘stack_end’ in ‘*stack_end_p’ [-Wdangling-pointer=]
4530 | *stack_end_p = &stack_end;
| ~~~~~~~~~~~~~^~~~~~~~~~~~ -
- https://github.com/ruby/prism/commit/a2f57ef6e3
-
- As long as we use a high enough test version, the default version of
Bundler should never get in the middle.
https://github.com/rubygems/rubygems/commit/d63f0818aa -
- They are used by default.
https://github.com/rubygems/rubygems/commit/0b7f7d879f -
- https://github.com/rubygems/rubygems/commit/d850ea1d95
-
- Applied in changeset commit:git|24493779b79bb57fd2e71bf6e0ababe95448a9d6.
----------
[Bug #20725] Should not call compare on `nil`-endpoint
It means unbounded, always inclusive of other ranges. -
- https://github.com/ruby/ruby/pull/11609
-
- It means unbounded, always inclusive of other ranges.
-
-
07:45 AM Bug #20723: `IO#close` is broken on Ruby 3.3+ when using the Fiber scheduler.
- Sorry about this. I think https://github.com/ruby/ruby/pull/11614 is the smallest diff that will fix the issue (and this should probably be backported to 3.3).
Separately to that, I wonder if we need to wrap up some common function fo... -
-
-
- 05:35 AM Revision 58942023 (git): typo otherBasis -> orthoBasis
- The original function name in ao.c was orthoBasis.
I guess the function is generating orthonormal basis (https://en.wikipedia.org/wiki/Orthonormal_basis). -
-
- ```
/home/chkbuild/chkbuild/tmp/build/20240913T003003Z/ruby/test/net/http/utils.rb:32: warning: assigned but unused variable - e
/home/chkbuild/chkbuild/tmp/build/20240913T003003Z/ruby/test/net/http/utils.rb:61: warning: assigned but unu... -
-
-
- FreeBSD 14.1 build is also failure with ruby master. This is different error from #20733
```
[hsbt@freebsd ~/ruby]$ make
BASERUBY = /usr/local/bin/ruby --disable=gems
CC = clang
LD = ld
LDSHARED =... -
- FreeBSD 13.3 build on Ruby CI was failure from 1 week ago. I manually build ruby master on FreeBSD 13 and got the following error.
```
[hsbt@freebsd /usr/home/hsbt/ruby]$ make
BASERUBY = /usr/local/bin/ruby --disable=gems
... -
- I thought she was a committer long ago.
-
- I got the following failure with mswin environment.
```
1) Failure:
TestRubyOptions#test_command_line_progname_nonascii [C:/Users/hsbt/DevDrive/github.com/ruby/ruby/test/ruby/test_rubyoptions.rb:1086]:
[ruby-dev:48752] [Bug #1055... -
09/12/2024
-
- +1
-
- +1
-
08:25 PM Misc #20728: Propose Eileen Uchitelle as a core committer
- +1
-
08:17 PM Misc #20728: Propose Eileen Uchitelle as a core committer
- +1, I think Eileen would make a great addition, especially as a maintainer on the Prism parser / compiler. She's also been participating in the MMtk GC integration and her help in that area is valuable as well.
-
- I'd like to propose Eileen Uchitelle (@eileencodes) as a core committer. Now that Prism ([Feature #20564]) is merged, I would like her help maintaining the Prism parser and compiler without having to go through me to get patches merged.
... -
- >Is there the criteria for reverting this until Ruby 3.4 release?
I'm still waiting this answer. -
- Per this ticket, I have merged https://github.com/ruby/ruby/pull/11497 to switch the default parser on master. The caveats in this ticket still apply, and I will be working on those next.
As a part of this PR I have added a new GitHub... -
- If we are during heap traversal, we don't want to call rb_gc_impl_mark_weak.
This commit moves that check from rb_gc_impl_mark_weak to rb_gc_mark_weak. -
-
-
-
-
07:19 PM Revision 0960c8aa (git): [DOC] Tweaks for Array#fetch_values (#11603)
-
-
-
- Truthfully it might not be worth adding these optimizations. It's a lot to maintain in both compilers, and this kind of literal is extremely unlikely to be used with Ractors until other problems with Ractors are solved. I would just as s...
-
- I added back the array literal optimizations here: https://github.com/luke-gru/ruby/tree/bug20473
I didn't send a PR because it's not working with prism yet. Let me know if this is an okay solution, I could get it working for prism to... -
- For a while we've been seeing an occasional segfault in production inside of YJIT's invalidation code. It seems to happen most often when a invalidation on a widely used CME.
```
[BUG] Segmentation fault at 0x0000000000000014"
"ruby... -
05:43 PM Bug #20586 (Closed): Some filesystem calls in dir.c are missing error handling and can return incorrect results if interrupted
- Applied in changeset commit:git|f2919bd11c570fc5f5440d1f101be38f61e3d16b.
----------
Add error checking to readdir, telldir, and closedir calls in dir.c
Raise SystemCallError exception when these functions return an error.
This change... -
-
- https://github.com/ruby/prism/commit/d68ea29d04
-
-
-
- The description has been updated when running with Prism to have
+PRISM, which means that tests asserting against the description
when running with --parser=parse.y will be incorrect if the
subprocess ends up using Prism. We need to fix ... -
-
-
-
- This commit switches the default parser to Prism. There are a
couple of additional changes related to this that are a part of
this as well to make this happen.
* Switch the default parser in parse.h
* Remove the Prism-specific workflow ... -
- Raise SystemCallError exception when these functions return an error.
This changes behavior for the following case (found by the tests):
```ruby
dir1 = Dir.new('..')
dir2 = Dir.for_fd(dir1.fileno)
dir1.close
dir2.close
```
The above c... -
- https://github.com/ruby/prism/commit/e8c862ca1f
-
03:04 PM Revision a542479a (git): [ruby/irb] Remove KEYWORD_ALIASES which handled special alias name
- of irb_break irb_catch and irb_next command
(https://github.com/ruby/irb/pull/1004)
* Remove KEYWORD_ALIASES which handled special alias name of irb_break irb_catch and irb_next command
* Remove unused instance variable user_aliases
C... -
- Single `Integer` argument means an exact match to the major version.
-
-
-
-
- Do not release GVL around get{pwuid,pwnam,grgid,grnam} calls,
as doing so is not thread-safe. Another C extension could have
a concurrent call, and derefencing the returned pointer from
these calls could result in a segfault.
Have rb_h... -
02:23 PM Bug #20620: singleton_method undefined for module using "extend self"
- I submitted a pull request to implement this: https://github.com/ruby/ruby/pull/11605
In terms of compatibility issues:
* For singleton classes that prepend a module, and have the method defined in both the singleton class and prep... -
- The GC always locks the VM, so we don't need to lock it in rb_vm_ci_free.
-
- ```ruby
# shareable_constant_value: literal
a = 'hi'
A = ['hello' => a]
p A
```
gives:
```
./ruby -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/common -r./x86_64-linux-fake ../ruby/test.rb
-- raw disasm--------
trace:... -
01:03 PM Bug #20725 (Closed): Inconsistent handling of doubly-unbounded ranges in Range#overlap?
- The new `Range#overlap?` method does not seem to have a clear definition of how it behaves when passed ranges with nil begin **and** end `(nil..)`.
In the following two cases, it seems to treat this type of range as an "infinite" rang... -
12:06 PM Revision f47c057c (git): Remove unnecessary file
-
-
-
-
-
-
-
-
- >I think it's more prudent to do 15.1 first, then 16.0.
Agreed, thanks! -
03:21 AM Feature #19908: Update to Unicode 15.1
- hsbt (Hiroshi SHIBATA) wrote in #note-8:
> Unicode 16.0 has been released.
> ...
I think it's more prudent to do 15.1 first, then 16.0. I hope to be able to work on this soon. I created a separate issue for 16.0. -
- Unicode 16.0 has been released.
https://www.unicode.org/versions/Unicode16.0.0/
Should we move this instead of 15.1? -
- Unicode 16.0 has been released (see https://www.unicode.org/versions/Unicode16.0.0/). We should update to 16.0 after updating to 15.1.
09/11/2024
-
- Applied in changeset commit:git|5d358b660d41e64de301f428dc0300a52a6f9566.
----------
Fix issue with super and forwarding arguments in prism_compile.c
Fixes [Bug #20720] -
- Fixes [Bug #20720]
-
- https://github.com/ruby/prism/commit/487f0ffe78
-
07:03 PM Bug #20722: curious search result order on docs.ruby-lang.org
- You might have more luck reporting this at the RDoc repository:
https://github.com/ruby/rdoc -
05:07 AM Bug #20722 (Closed): curious search result order on docs.ruby-lang.org
- If you search for "String" on https://docs.ruby-lang.org/en/3.3/ the first four results returned are obscure:
1. Gem::SafeMarshal::Elements::String
2. Prism::StringFlags
3. Prism::StringNode
4. Reline::Terminfo::StringWithTiparm
5... -
- https://github.com/rubygems/rubygems/commit/03ddfd7610
Co-authored-by: Jonathan Hefner <[email protected]> -
- This was commented out almost 10 years ago, but I think it passes now!
https://github.com/rubygems/rubygems/commit/4a6b1aba3c - 05:19 PM Revision efc77d53 (git): [ruby/psych] Ensure strings with only underscores are not processed as Integer
- A string similar to "0x____" should be treated as a string.
Currently it is processed as an Integer.
This alters the regex specified by http://yaml.org/type/int.html
to ensure at least one numerical symbol is present in the string
befor... -
-
-
-
- https://github.com/ruby/prism/commit/ebd2889bee
-
- https://github.com/ruby/prism/commit/31154a389a
-
-
-
-
-
-
- In a `bundle exec` context, the local specification will actually be
part of the known specifications, so RubyGems will assume it has already
been installed, which is not actually true.
This will cause `RequestSet` to rebuild extensions... -
- DSLError prints the specific line in a Gemfile where the error was
raised. That's helpful when the error was explicitly raised by the
Gemfile DSL or, in the case it's implicitly raised, when the offending
code lives right in the Gemfile.... -
- Things like OOM, or StackOverflow should be raised immediately.
https://github.com/rubygems/rubygems/commit/11691ce492 -
- https://github.com/rubygems/rubygems/commit/b4ecb66224
-
- https://github.com/rubygems/rubygems/commit/ab44fa9ee4
-
10:49 AM Bug #20723: `IO#close` is broken on Ruby 3.3+ when using the Fiber scheduler.
- I've added the following work-around: <https://github.com/socketry/io-stream/commit/7d1546fa829d3fe046f66f559d9a774497390f3e>
-
- It may be related to https://github.com/ruby/ruby/commit/66871c5a06d723f8350935ced1e88d8cc929d809
-
- The following program seems to work okay on Ruby 3.2 but hangs on Ruby 3.3:
```ruby
#!/usr/bin/env ruby
require 'bundler/inline'
gemfile do
source 'https://rubygems.org'
gem 'async'
end
require 'socket'
def close_w... -
- I agree with @Dan0042, the new API should not have this error-prone behavior, it should raise if out of bounds instead of silent truncation.
I also think we should fix setbyte to not have this behavior, but that's a different issue.
... -
09:20 AM Feature #20594: A new String method to append bytes while preserving encoding
- Dan0042 (Daniel DeLorme) wrote in #note-31:
> Ironically, HexaPDF now uses an explicit modulo 256, so it would actually be fine if #setbyte raised an out-of-bound error.
> ...
Yes, as mentioned in the linked issue #15460 I implemented ... -
02:34 AM Feature #20594: A new String method to append bytes while preserving encoding
- Ironically, HexaPDF now uses an explicit modulo 256, so it would actually be fine if #setbyte raised an out-of-bound error.
https://github.com/gettalong/hexapdf/blob/master/lib/hexapdf/filter/predictor.rb#L166
imho better safe than s... -
01:54 AM Feature #20594: A new String method to append bytes while preserving encoding
- Dan0042 (Daniel DeLorme) wrote in #note-29:
> I understand the idea of keeping things consistent. But why does `setbyte` have this behavior in the first place? A few years back there was an attempt to check bounds, and then in #15460 Ma... -
- I understand the idea of keeping things consistent. But why does `setbyte` have this behavior in the first place? A few years back there was an attempt to check bounds, and then in #15460 Matz apparently decided he "prefers mod 256 behav...
-
-
-
-
-
- The clean targets should clean up all extensions, including those have
nothing to build for any reason, e.g., platform requirements etc. -
- exts.mk should deal with cleanings of extensions, including bundled
gems. - 04:49 AM Revision 6c16598a (git): [ruby/pathname] use delete_prefix instead of sub in find method
- delete_prefix with a string is easier to read than a regular expression
also it should be faster. It is available since ruby 2.5 and the gem requires
ruby 2.7.
https://github.com/ruby/pathname/commit/0070f43f19 -
04:41 AM Revision c37b6677 (git): [rubygems/rubygems] Make an exe file executable when generating new gems
- Currently, an exe file isn't executable when generating new gems
because it doesn't have the correct permission.
This PR sets the correct permission same as files under the `bin`.
https://github.com/rubygems/rubygems/commit/6509bf128a -
- With Ruby 3.3.5, every gem executable under `$prefix/bin` has a `.lock` file. This was [an unintended change](https://github.com/ruby/ruby/pull/11252#issuecomment-2337520641), which was fixed in rubygems master at https://github.com/ruby...
-
12:38 AM Revision 55ddfd58 (git): Fixes [Bug #20718] (#11576)
- Fixes [Bug #20718]
Allow objects that are not of type `RTypedData` to use the default free function, as `RTYPEDDATA_EMBEDDED_P` can return a false positive when casting non-`RTypedData` objects -
09/10/2024
-
- Dan0042 (Daniel DeLorme) wrote in #note-27:
> > > For integers, the i & 0xff masking behavior comes from String#setbyte.
> ...
I don't think there is a specific use case (or maybe the use case is the same as when providing out-of-bound... -
- > > For integers, the i & 0xff masking behavior comes from String#setbyte.
> ...
Can anyone explain what is the use case for this behavior? It seems strange to me that silently truncating integers would be a desirable behavior. Especial... -
- String#append_as_bytes was newly introduced in #11552.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
02:46 PM Bug #20716: Different instance_method behavior in Ruby 2.7 and Ruby 3.x
- Hi Evans,
Thank you for your guidance and the quick fix.
I truly appreciate it -
- I was able to track down the cause and submitted a pull request to fix this: https://github.com/ruby/ruby/pull/11582
It appears to be introduced by commit:ad729a1d11c6c57efd2e92803b4e937db0f75252, which I wrote and which was a fix for... -
- We don't use the key, so we can speed it up by not needing to convert the
key to ID in the iterator. -
- I've created a patch here: https://github.com/luke-gru/ruby/tree/20472 (the latest commit)
For kwsplat, it just calls compile_hash (which generates `hash_merge_kw` call after the hash generation), generates a `freeze` call on the compil... -
01:22 PM Feature #18368: Range#step semantics for non-Numeric ranges
- The compatibility with `(:a .. :z).step(3)` has also been restored.
https://github.com/ruby/ruby/pull/11573 -
09:15 AM Misc #20013: Travis CI status
- I see the case that the jobs are running with showing the outputs (and failing as expected).
https://app.travis-ci.com/github/ruby/ruby/builds/272246788
-
- We drop Travis CI for ruby/zlib, ruby/prism too. Because the Travis infra issues are still ongoing since my last report.
* https://github.com/ruby/zlib/pull/84
* https://github.com/ruby/prism/pull/3047
The Travis CI status page is... -
- https://github.com/ruby/tmpdir/commit/628c5bdc59
-
08:34 AM Revision 3231ac60 (git): [ruby/resolv] test_dns: Fix FD leak
- The listening TCP socket is closed by `with_udp_and_tcp` helper, but
the connected socket is leaking.
```
Leaked file descriptor: TestResolvDNS#test_multiple_servers_with_timeout_and_truncated_tcp_fallback: 12 : #<TCPSocket:fd 12, AF_IN... -
- https://github.com/ruby/resolv/commit/3189d16b69
-
-
- https://github.com/ruby/ruby/pull/11581
-
-
- 07:00 AM Revision 30d00a0b (git): * 2024-09-10 [ci skip]
-
- Remove `.ceil` from base time calculation that makes 10x gap.
This will make the assertion more strict and also less flaky. -
- strscan, ipaddr and some default gems still support Ruby 2.4.
After this, I extract this CoreAssertions to their repositories. -
-
- Some symbol argument might not be accepted by Process.clock_gettime.
-
- To prevent influence from other processes.
-
-
- Increase the timeout limit when variance at rehearsal is small.
-
-
-
- The following case is resolved at Xcode CLI RC and macOS 15.1 beta3
> pid = fork { p File.realpath "/" }
> ...
-
- `make test-bundler` on ruby/ruby don't have installed gemspec.
So, `require "psych"` didn't activate psych as default gems on ruby repo.
https://github.com/rubygems/rubygems/commit/f8ca514cbb -
- https://github.com/rubygems/rubygems/commit/d46b6a49af
-
- https://github.com/rubygems/rubygems/commit/6b1e8a14bd
-
- https://github.com/rubygems/rubygems/commit/8d94c14ca0
Co-authored-by: Jonathan Hefner <[email protected]> -
- `DSL#to_definition` already verifies this.
https://github.com/rubygems/rubygems/commit/c596f0af83 -
- https://github.com/rubygems/rubygems/commit/0b7be7bb77
Co-authored-by: Jonathan Hefner <[email protected]> -
- This is a bit off-topic, but I've often thought it would be nice to have multiple "levels" of warnings. So we could have the fine-grained `Warning[:strict_unused_block]` which, if unset, defaults to the coarse-grained `Warning[:strict]` ...
09/09/2024
-
11:16 PM Feature #13820: Add a nil coalescing operator
- Ruby already has the safe navigation operator `?.`, added back in Ruby 2.3, which was definitely a step in the right direction with regards to first-class `nil`-aware operations.
Now we just need a null coalescing operator like most o... -
-
-
-
07:01 PM Revision 7a653345 (git): [ruby/prism] Fix a token incompatibility for `Prism::Translation::Parser::Lexer`
- This PR fixes a token incompatibility between Parser gem and `Prism::Translation::Parser` for double splat argument.
## Parser gem (Expected)
Returns `tDSTAR` token:
```console
$ bundle exec ruby -Ilib -rparser/ruby33 -ve \
'buf = Par... -
-
- Applied in changeset commit:git|079ef92b5e59b616d670efe81a33e500f2bf6451.
----------
Implement global allocatable slots and empty pages
[Bug #20710]
This commit introduces moves allocatable slots and empty pages from per
size pool to ... -
07:25 AM Bug #20710: Reducing Hash allocation introduces large performance degradation (probably related to VWA)
- @peterzhu2118 Thanks for your work! I've confirmed this PR improves the performance in my environment too.
-
-
- This adds keys heap_empty_pages and heap_allocatable_slots to GC.stat.
-
- [Bug #20710]
This commit introduces moves allocatable slots and empty pages from per
size pool to global. This allows size pools to grow globally and allows
empty pages to move between size pools.
For the benchmark in [Bug #20710], thi... -
-
-
01:05 PM Feature #20594 (Closed): A new String method to append bytes while preserving encoding
- Applied in changeset commit:git|16f241f0aa047ed77ccea6b6c361b421a72d0454.
----------
Implement String#append_as_bytes(String | Integer, ...)
[Feature #20594]
A handy method to construct a string out of multiple chunks.
Contrary to `S... -
- [Feature #20594]
A handy method to construct a string out of multiple chunks.
Contrary to `String#concat`, it doesn't do any encoding negociation,
and simply append the content as bytes regardless of whether this
result in a broken str... -
11:59 AM Revision 966901b3 (git): [rubygems/rubygems] Don't include hook templates in cached git source
- With a default git setup, each cloned repo in the cache will end up with
~60K of sample git hooks. These files all end in `.sample`, and they are
disabled by default. Deleting them should be a no-op, and makes the
cache a bit smaller.
h... -
-
-
08:46 AM Revision d7b0f269 (git): Return back legacy Range#step behavior for symbol ranges
-
- https://github.com/rubygems/rubygems/commit/511c7b211b
-
- https://github.com/rubygems/rubygems/commit/032b3c518a
-
- https://github.com/rubygems/rubygems/commit/5887e6dfa1
-
- 06:47 AM Revision 330b2ffb (git): Update default gems list at 2d4fdafa64cc3153792c870a56971a [ci skip]
-
- https://github.com/ruby/psych/commit/a8b73bb80e
-
06:44 AM Revision 74872109 (git): [ruby/psych] Unlimited line_width with -1
- https://github.com/ruby/psych/commit/3b63a93dfc
-
- https://github.com/ruby/psych/commit/9f5392d180
- 06:40 AM Revision aed8e461 (git): [ruby/psych] docs: specify correct default `fallback` value
- https://github.com/ruby/psych/commit/ce7946981d
-
- natton (Tien Truong) wrote in #note-4:
> I am new here so is there anything I can do to escalate this or how can I help to resolve this issue?
There isn't an escalation process in place in Ruby, as it is an open source project manage... -
- Hi Evans,
Thank you for your confirmation.
I am new here so is there anything I can do to escalate this or how can I help to resolve this issue?
-
02:35 AM Feature #20309: Bundled gems for Ruby 3.5
- > No. irb is available as bundled gems.
Sorry, I misunderstood. -
- >Does this change mean that even if Ruby is installed, the irb command will no longer be available?
No. `irb` is available as bundled gems. -
-
12:10 AM Revision b5f12910 (git): The Timeout::Error example no longer works consistently
- * This PR from the timeout gem (https://github.com/ruby/timeout/pull/30) made it so you have to handle_interrupt on Timeout::ExitException instead of Timeout::Error
* Efficiency changes to the gem (one shared thread) mean you can't cons...
09/08/2024
-
04:43 PM Revision 19c1f023 (git): [ruby/benchmark] Set required_ruby_version = ">= 2.1.0"
- `Process.clock_gettime` only works since 2.1
https://github.com/ruby/benchmark/commit/94cfe56291 -
-
-
- Since universal-parser and prism support, prelude code used functions
inaccessible from outside libruby shared library.
```
linking goruby
/usr/bin/ld: goruby.o: in function `prelude_eval':
/home/runner/work/ruby/ruby/build/golf_prelude... -
- Refactor out the same code from `rb_builtin_ast_value` and
`pm_builtin_ast_value. -
-
- 02:13 PM Revision 903f3790 (git): [ruby/open-uri] Update error message for `request_specific_fields` option validation
- Added `inspect` to the `request_specific_fields` value to provide
better visibility for users in the exception message.
https://github.com/ruby/open-uri/commit/f89ce5112d - 02:13 PM Revision 76475bf5 (git): [ruby/open-uri] Add documentation for `request_specific_fields` option
- https://github.com/ruby/open-uri/commit/2e7734c061
- 02:12 PM Revision 0ac16215 (git): [ruby/open-uri] Add test about `request_specific_fields` option
- https://github.com/ruby/open-uri/commit/060886f312
- 02:12 PM Revision 6ea2b6f6 (git): [ruby/open-uri] Add `request_specific_fields` option for customizing headers
- This commit introduces the `request_specific_fields` option in OpenURI.
It provides two methods for customizing headers as follows.
1. Specify headers only for the initial request
Use a Hash to apply headers only to the first request.
... - 12:17 PM Revision ec5d5422 (git): [ruby/rdoc] Use pointer cursor for navigation toggle
- (https://github.com/ruby/rdoc/pull/1175)
https://github.com/ruby/rdoc/commit/964a1982c8
09/07/2024
-
- This PR fixes a token incompatibility between Parser gem and `Prism::Translation::Parser` for left parenthesis.
## Parser gem (Expected)
Returns `tLPAREN2` token:
```console
$ bundle exec ruby -Ilib -rparser/ruby33 \
-ve 'buf = Parser... -
- I think this issue was introduced in 3.3? Let me know if not and I'll update the backport target.
Also for 3.3 the branch maintainer appreciate backport PRs so don't hesitate to open it yourself and tag k0kubun if you wish. -
- Applied in changeset commit:git|c1a510a8dffa1c8065e47697cd57edae67126712.
----------
[Bug #20718] Free non-`RTypedData` objects
Allow objects that are not of type `RTypedData` to use the default
free function, as `RTYPEDDATA_EMBEDDED_P... -
- PR here: https://github.com/ruby/ruby/pull/11565
-
- ```ruby
class A
def foo(*b, &block)
end
end
class B < A
def foo(...)
super()
puts "2"
end
end
```
results in:
```
./ruby --parser=prism -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/common -r./x86_64-li... -
- Applied in changeset commit:git|c1862cbb89a6bf42dcd07d92fe4f4bfeebca5775.
----------
[Bug #20719] `Float` argument must be ASCII compatible -
- ```ruby
"\u{3036}" #=> "〶"
Float("\u{3036}".encode("utf-16be")) #=> 6.0
```
While:
```ruby
Integer("\u{3036}".encode("utf-16be")) #=> ASCII incompatible encoding: UTF-16BE (Encoding::CompatibilityError)
``` -
-
-
- Allow objects that are not of type `RTypedData` to use the default
free function, as `RTYPEDDATA_EMBEDDED_P` can return a false positive
when casting non-`RTypedData` objects. -
- This behavior isn't related to `instance_method`. It occurs in the following code:
```ruby
module A
def test(*args)
super
end
end
module B
def test(a)
puts a
end
end
class C; end
B.prepend(A)
C.incl...