Activity

7 days up to

User

Activity

From 09/09/2024 to 09/15/2024

09/15/2024

07:15 PM Bug #20726: Issue with hash without braces when assigned to constant with ractor literals: This problem was not reproduced with `--parser=prism`, but with `--parser=parse.y`.
```ruby
# shareable_constant_... osyo (manga osyo)
06:07 PM Bug #20743: ruby doesn't properly split RUBY_DEBUG_LOG_FILTER into items: Apparently introduced in the following commit:
https://github.com/ruby/ruby/commit/5a4f997b2e8e819ed40731cd769826112... x-yuri (Yuri Kanivetsky)
05:58 PM Bug #20743 (Assigned): ruby doesn't properly split RUBY_DEBUG_LOG_FILTER into items: ```
$ docker run --rm alpine:3.20.3 sh -euxc '
apk add git build-base autoconf ruby yaml-dev zlib-dev openssl-d... x-yuri (Yuri Kanivetsky)
06:06 PM Feature #20738: Removing a specific entry from a hash literal: > There are several Rails codes that can be improved with this feature.
As one of the maintainer of the code you ... byroot (Jean Boussier)
04:32 PM Feature #20738: Removing a specific entry from a hash literal: ursm (Keita Urashima) wrote in #note-9:
> There are several Rails codes that can be improved with this feature. In m... jeremyevans0 (Jeremy Evans)
12:36 PM Feature #20738: Removing a specific entry from a hash literal: Eregon (Benoit Daloze) wrote in #note-8:
> I don't think it's very frequent to need this to warrant a syntax change ... ursm (Keita Urashima)
05:52 PM Feature #20742: Trying to assign to a variable in statement modifier should emit a warning: Assigning in post-conditionals is a fairly common in Ruby. If this is to be a warning, it would have to be limited t... jeremyevans0 (Jeremy Evans)
05:42 PM Feature #20742 (Open): Trying to assign to a variable in statement modifier should emit a warning: There is an example in Control Expressions documentation:
```
p a if a = 0.zero? # raises NameError “undefined lo... esad (Esad Hajdarevic)
10:25 AM Bug #20736: prism emits wrong warnings in syntax-error code: I think good error recovery is key to have helpful error messages when writing Ruby code.
Maybe one way here is to... Eregon (Benoit Daloze)
12:51 AM Bug #20736: prism emits wrong warnings in syntax-error code: https://github.com/ruby/ruby/pull/11626 mame (Yusuke Endoh)
12:46 AM Bug #20736: prism emits wrong warnings in syntax-error code: I wonder if error recovery is needed in the interpreter's parser. It might be a benefit to be able to output almost a... mame (Yusuke Endoh)
09:10 AM Bug #20741: RubyVM::InstructionSequence.compile emits a wrong warning (prism?): > prism?
Yes:
```
$ ./miniruby --parser=parse.y -we 'p RubyVM::InstructionSequence.compile("42").eval'
42
$ ... byroot (Jean Boussier)
01:05 AM Bug #20741 (Closed): RubyVM::InstructionSequence.compile emits a wrong warning (prism?): ```
$ ./local/bin/ruby -we 'p RubyVM::InstructionSequence.compile("42").eval'
<compiled>:1: warning: possibly usele... mame (Yusuke Endoh)
01:06 AM Revision 532af89e (git): Prevent warnings: the block passed to ... may be ignored: mame (Yusuke Endoh)
01:05 AM Revision bc13ec73 (git): Prevent warnings: assigned but unused variable: mame (Yusuke Endoh)

09/14/2024

04:34 PM Feature #20738: Removing a specific entry from a hash literal: I don't think it's OK to magically drop entries from a literal based on some value, it's way too surprising.
Notably ... Eregon (Benoit Daloze)
05:24 AM Feature #20738: Removing a specific entry from a hash literal: I believe that the following two points will prevent the same problems as in the past:
1. Use a value that is neve... ursm (Keita Urashima)
04:53 AM Feature #20738: Removing a specific entry from a hash literal: History. Long ago in Ruby, such a special value actually existed. It was `nil`.
```ruby
# ruby 1.4.6
h = { 1 => ... mame (Yusuke Endoh)
07:54 AM Bug #20730: LoadError if Rakefile has shebang: `ruby` command handles a shebang, but it is not a part of the Ruby syntax.
Parsers should not consider shebang lines. nobu (Nobuyoshi Nakada)

09/13/2024

08:58 PM Bug #20736: prism emits wrong warnings in syntax-error code: Right now Prism is lexing `9a` as an integer and then an identifier. So it's effectively parsing it as `1; 2; 9; a`. ... kddnewton (Kevin Newton)
07:51 PM Bug #20736: prism emits wrong warnings in syntax-error code: Although I can understand the technical reason, I still feel a bit uncomfortable when the warning says “use of a lite... mame (Yusuke Endoh)
05:02 PM Bug #20736 (Feedback): prism emits wrong warnings in syntax-error code: kddnewton (Kevin Newton)
03:32 PM Bug #20736: prism emits wrong warnings in syntax-error code: This is because Prism recovers from the syntax error. For example:
```ruby
eval("1; 2; 9a; 3; 4; 5; 9b")
```
... kddnewton (Kevin Newton)
03:23 AM Bug #20736 (Feedback): prism emits wrong warnings in syntax-error code: ```
$ ./local/bin/ruby -w --parser=parse.y -e 'begin eval("0a"); rescue SyntaxError; end'
$ ./local/bin/ruby -w --p... mame (Yusuke Endoh)
07:30 PM Revision ddbd6440 (git): [ruby/prism] Stat file first to check directory: https://github.com/ruby/prism/commit/4ed7de537b kddnewton (Kevin Newton)
07:16 PM Bug #20473: Ractor array/hash literals: Okay, makes sense. Maybe if/when ractors are used more I'll take a look at this again. luke-gru (Luke Gruber)
07:13 PM Revision f85efc97 (git): [ruby/prism] Expose main_script in serialization API: https://github.com/ruby/prism/commit/0b527ca93f kddnewton (Kevin Newton)
06:13 PM Bug #20735 (Closed): prism emits "ambiguous `&`" warning: kddnewton (Kevin Newton)
04:49 PM Bug #20735: prism emits "ambiguous `&`" warning: I have opened https://github.com/ruby/ruby/pull/11622 to fix this. kddnewton (Kevin Newton)
02:40 AM Bug #20735 (Closed): prism emits "ambiguous `&`" warning: ```
$ ./local/bin/ruby -w --parser=parse.y -e 'def foo(&) = nil; foo &:bar'
$ ./local/bin/ruby -w --parser=prism -e... mame (Yusuke Endoh)
06:09 PM Bug #20730 (Closed): LoadError if Rakefile has shebang: Applied in changeset commit:git|9afc6a981deae6e23d938cf5c2c4baadfeaafdb1.
----------
[PRISM] Only parse shebang on m... kddnewton (Kevin Newton)
03:23 PM Bug #20730: LoadError if Rakefile has shebang: I have opened https://github.com/ruby/ruby/pull/11617 to fix this. kddnewton (Kevin Newton)
01:19 AM Bug #20730 (Closed): LoadError if Rakefile has shebang: `LoadError` exception will be raised when invoke the rake task with latest ruby 3.4-dev.
### Reproduce code
Here ... watson1978 (Shizuo Fujita)
06:09 PM Revision 77521afa (git): [PRISM] Do not warn ambiguous ampersand when symbol literal: Fixes [Bug #20735] kddnewton (Kevin Newton)
05:44 PM Feature #20309: Bundled gems for Ruby 3.5: Regarding `irb`, I find it concerning that we need to add code like this: https://github.com/ruby/ruby/blob/9afc6a981... deivid (David Rodríguez)
05:16 PM Bug #20737: Accidentally changed warning target on Ruby 3.3: Agreed, I didn't expect new warnings in 3.3.5 when 3.3.4 did not warn, and extra warnings can break CI (e.g. #20713). Eregon (Benoit Daloze)
05:57 AM Bug #20737 (Closed): Accidentally changed warning target on Ruby 3.3: https://github.com/ruby/ruby/pull/11613 hsbt (Hiroshi SHIBATA)
04:10 AM Bug #20737: Accidentally changed warning target on Ruby 3.3: Makes sense. Let's revert that back to the Ruby 3.3.4 one in Ruby 3.3.6. k0kubun (Takashi Kokubun)
04:03 AM Bug #20737 (Closed): Accidentally changed warning target on Ruby 3.3: I heard that concern from yhonda.
I request to backport bundled_gems.rb that is same version of the current master... hsbt (Hiroshi SHIBATA)
05:12 PM Misc #20739: Test suite does not carry over CLI options: I think it's a real issue and sometimes valuable to fix (it hurts the coverage of tests * flags).
#6648 could be help... Eregon (Benoit Daloze)
01:37 PM Misc #20739 (Open): Test suite does not carry over CLI options: I'm not sure if anything needs to change here, but I wanted to report this in case anyone had any particular ideas. W... kddnewton (Kevin Newton)
05:01 PM Bug #20731 (Closed): warning: mismatched indentations at 'when' appears with prism enabled ruby: kddnewton (Kevin Newton)
04:08 PM Bug #20731: warning: mismatched indentations at 'when' appears with prism enabled ruby: I have opened https://github.com/ruby/ruby/pull/11620 to fix this. kddnewton (Kevin Newton)
02:42 AM Bug #20731 (Assigned): warning: mismatched indentations at 'when' appears with prism enabled ruby: hsbt (Hiroshi SHIBATA)
01:37 AM Bug #20731: warning: mismatched indentations at 'when' appears with prism enabled ruby: @mame
Thanks! hsbt (Hiroshi SHIBATA)
01:34 AM Bug #20731: warning: mismatched indentations at 'when' appears with prism enabled ruby: The wrong warning with `rss` gem is a different issue. I have created a separate ticket #20732. mame (Yusuke Endoh)
01:24 AM Bug #20731: warning: mismatched indentations at 'when' appears with prism enabled ruby: I also have similar issues with `rss`.
```
/Users/hsbt/Documents/github.com/ruby/ruby/gems/src/rss/lib/rss/1.0.rb... hsbt (Hiroshi SHIBATA)
01:20 AM Bug #20731 (Closed): warning: mismatched indentations at 'when' appears with prism enabled ruby: ### Steps to reproduce
1. Create a `case_sample.rb` file
```
foo = :bar
case foo
when :bar
p 'foo is :bar... yahonda (Yasuo Honda)
04:51 PM Revision 9afc6a98 (git): [PRISM] Only parse shebang on main script: Fixes [Bug #20730] kddnewton (Kevin Newton)
04:51 PM Revision d42d1905 (git): [PRISM] Allow case/when to be indented with no warning: Fixes [Bug #20731] kddnewton (Kevin Newton)
04:45 PM Bug #20740: prism_compile coding issue for PM_FORWARDING_SUPER_NODE: PR here: https://github.com/ruby/ruby/pull/11621 luke-gru (Luke Gruber)
04:44 PM Bug #20740 (Closed): prism_compile coding issue for PM_FORWARDING_SUPER_NODE: I found a coding issue in prism_compile.c but I can't find a bug that would result from it.
The `current_block` is... luke-gru (Luke Gruber)
04:09 PM Bug #20732 (Closed): prism emits "mismatched indentations" warning in eval: Applied in changeset commit:git|74f315c3f5908512dfdeeab2dd76d93e98149769.
----------
[PRISM] Turn off mismatched ind... kddnewton (Kevin Newton)
03:26 PM Bug #20732: prism emits "mismatched indentations" warning in eval: I have opened https://github.com/ruby/ruby/pull/11618 to fix this. kddnewton (Kevin Newton)
01:28 AM Bug #20732 (Closed): prism emits "mismatched indentations" warning in eval: ```ruby
eval(<<-EOC)
if @check
end
EOC
```
```
$ ruby --parser=parse.y -w t.rb
$ ruby --parser=prism -w t... mame (Yusuke Endoh)
04:08 PM Revision 74f315c3 (git): [PRISM] Turn off mismatched indentation warnings in eval: Fixes [Bug #20732] kddnewton (Kevin Newton)
03:05 PM Revision 353997dd (git): [ruby/prism] Refactor and move common node flags count into a constant to reuse in templates: https://github.com/ruby/prism/commit/c20bf05ecc andrykonchin (Andrew Konchin)
03:05 PM Revision 38f8f42e (git): [ruby/prism] Unify code style of flags generation in the nodes templates: https://github.com/ruby/prism/commit/dbb7e0a44e andrykonchin (Andrew Konchin)
02:58 PM Feature #20738: Removing a specific entry from a hash literal: With the previous idea, I can't have both removing entries and returning nil depending on the condition.
``` ruby
... ursm (Keita Urashima)
01:17 PM Feature #20738: Removing a specific entry from a hash literal: nobu (Nobuyoshi Nakada) wrote in #note-1:
> "A special value" doesn't feel like a good idea to me.
Hmmm, does tha... ursm (Keita Urashima)
12:16 PM Feature #20738: Removing a specific entry from a hash literal: Yes, I sometimes do that as well. However, I am not happy that the shape of the resulting hash is unclear. ursm (Keita Urashima)
11:59 AM Feature #20738: Removing a specific entry from a hash literal: How about using `**`?
```ruby
def bar? = false
{
foo: 1,
**(bar? ? { bar: 2 } : {})
}
# => {:foo=>1}
... osyo (manga osyo)
07:57 AM Feature #20738: Removing a specific entry from a hash literal: "A special value" doesn't feel like a good idea to me. nobu (Nobuyoshi Nakada)
07:33 AM Feature #20738 (Rejected): Removing a specific entry from a hash literal: Sometimes I want to decide whether or not to add a particular entry to a hash depending on a condition. If the entire... ursm (Keita Urashima)
02:06 PM Revision c996f409 (git): Ignore -Wdangling-pointer in rb_gc_set_stack_end: Fixes this compiler warning:
thread.c:4530:18: warning: storing the address of local variable ‘stack_end’ in ‘*s... peterzhu2118 (Peter Zhu)
01:17 PM Revision f0dcbbe9 (git): [ruby/prism] Reverse-sync numbered reference range handling: https://github.com/ruby/prism/commit/a2f57ef6e3 kddnewton (Kevin Newton)
12:42 PM Revision 36b2fea6 (git): [rubygems/rubygems] Remove `BUNDLER_IGNORE_DEFAULT_GEM`: As long as we use a high enough test version, the default version of
Bundler should never get in the middle.
https:/... deivid (David Rodríguez)
12:42 PM Revision 8e2d971b (git): [rubygems/rubygems] Remove redundant arguments passed to `bundle` helper: They are used by default.
https://github.com/rubygems/rubygems/commit/0b7f7d879f deivid (David Rodríguez)
12:42 PM Revision 64252851 (git): [rubygems/rubygems] Make sure test does not load system version of Bundler: https://github.com/rubygems/rubygems/commit/d850ea1d95 deivid (David Rodríguez)
10:37 AM Bug #20725 (Closed): Inconsistent handling of doubly-unbounded ranges in Range#overlap?: Applied in changeset commit:git|24493779b79bb57fd2e71bf6e0ababe95448a9d6.
----------
[Bug #20725] Should not call co... nobu (Nobuyoshi Nakada)
01:56 AM Bug #20725: Inconsistent handling of doubly-unbounded ranges in Range#overlap?: https://github.com/ruby/ruby/pull/11609 nobu (Nobuyoshi Nakada)
09:23 AM Revision 24493779 (git): [Bug #20725] Should not call compare on `nil`-endpoint: It means unbounded, always inclusive of other ranges. nobu (Nobuyoshi Nakada)
07:52 AM Revision 0f3dc2f9 (git): Prevent warnings "the block passed to ... may be ignored": mame (Yusuke Endoh)
07:45 AM Bug #20723: `IO#close` is broken on Ruby 3.3+ when using the Fiber scheduler.: Sorry about this. I think https://github.com/ruby/ruby/pull/11614 is the smallest diff that will fix the issue (and t... kjtsanaktsidis (KJ Tsanaktsidis)
06:49 AM Revision b6c7226f (git): Put typeprof.gemspec: mame (Yusuke Endoh)
06:49 AM Revision f090d1fa (git): Try to find bundled gem version from lib/*/version.rb: mame (Yusuke Endoh)
06:49 AM Revision cf5b9658 (git): Use the development version of typeprof in test-bundled-gems: mame (Yusuke Endoh)
05:35 AM Revision 58942023 (git): typo otherBasis -> orthoBasis: The original function name in ao.c was orthoBasis.
I guess the function is generating orthonormal basis (https://en.w... aoki1980taichi
04:19 AM Revision 3146cbbb (git): Dont't warn reline called from irb, reline is already declared at irb gemspec: hsbt (Hiroshi SHIBATA)
02:39 AM Revision 6ae05584 (git): [ruby/net-http] Prevent warnings: ```
/home/chkbuild/chkbuild/tmp/build/20240913T003003Z/ruby/test/net/http/utils.rb:32: warning: assigned but unused v... mame (Yusuke Endoh)
02:34 AM Revision 5e3f1b6a (git): Prevent a warning: assigned but unused variable - exp_events: mame (Yusuke Endoh)
02:32 AM Revision d1d0c50c (git): Prevent a warning: assigned but unused variable - t0: mame (Yusuke Endoh)
02:30 AM Bug #20734 (Closed): Test failure at FreeBSD 14.1: FreeBSD 14.1 build is also failure with ruby master. This is different error from #20733
```
[hsbt@freebsd ~/rub... hsbt (Hiroshi SHIBATA)
02:29 AM Bug #20733 (Open): Build failure OpenSSL extension with FreeBSD 13.3: FreeBSD 13.3 build on Ruby CI was failure from 1 week ago. I manually build ruby master on FreeBSD 13 and got the fol... hsbt (Hiroshi SHIBATA)
01:39 AM Misc #20728: Propose Eileen Uchitelle as a core committer: I thought she was a committer long ago. mame (Yusuke Endoh)
12:47 AM Bug #20729 (Closed): Test failure with 0fc8422a05 and native mswin environment: I got the following failure with mswin environment.
```
1) Failure:
TestRubyOptions#test_command_line_progname... hsbt (Hiroshi SHIBATA)
12:28 AM Revision d80a81c1 (git): Constify `struct getpwnam_r_args::login`: nobu (Nobuyoshi Nakada)

Also available in: Atom

Project

General

Profile

Ruby

Activity

Activity

09/15/2024

09/14/2024

09/13/2024

09/12/2024

09/11/2024

09/10/2024

09/09/2024