Activity
From 03/15/2025 to 03/21/2025
03/21/2025
-
07:25 PM Revision 595040ba (git): FCALL shouldn't be forwarded from caller
- When we forward an FCALL (a method call with an implicit self), we
shouldn't forward the FCALL flag because it ignore... -
- I've sent [a PR with a fix](https://github.com/ruby/ruby/pull/12960), but I can't seem to merge it right now. I will...
-
02:47 PM Bug #21196 (Closed): Ruby 3.4 ignores visibility when passing arguments using `...`
- If method is passing arguments using `...`, then receiver visibility gets ignored if once called without receiver:
... -
07:06 PM Bug #21195: Crash when using IO#timeout
- Thanks @mame I will review it today.
-
04:41 PM Bug #21195 (Assigned): Crash when using IO#timeout
- Ah, the code was written by @ioquatix. @ioquatix Could you review the patch?
-
- Thank you, I could reproduce the issue.
```
$ ./miniruby -e '$stdin.read_nonblock(1, exception: false); trap(:HUP... -
02:12 PM Bug #21195 (Closed): Crash when using IO#timeout
- We have adopted the [IO#timeout](https://bugs.ruby-lang.org/issues/18630) feature in Dalli ([ref](https://github.com/...
-
02:18 PM Revision 93ac342a (git): [ruby/prism] Add node_id to Java serialization
- https://github.com/ruby/prism/commit/93e768bd18
-
11:18 AM Revision 9b5165b1 (git): [ruby/prism] Don't use `RUBY_VERSION.to_f`
- There will be a bunch of other problems should 3.10 ever exists, but I guess why not fix this one now.
https://githu... -
- It was understandable that you wanted `class C < D` to behave the same as `C = Class.new(D)` for the sake of consiste...
-
08:28 AM Bug #21193: Inherited callback returns `nil` for `Object.const_source_location`
- > I think the current state is the best: set the state internally (both superclass and constant) so when both hooks a...
-
- To clarify, when I said that I agree with @mame I am personally not qualifying the current approach. Just saying the ...
-
- Agree with @mame.
And, looking at that code from Shopify that showed up in nothing, I can imagine some other applica... -
08:10 AM Bug #21193: Inherited callback returns `nil` for `Object.const_source_location`
- mame (Yusuke Endoh) wrote in #note-8:
> I think this handling is dirty
I think it's fine and not dirty, based on ... -
- Hmmm, I think this handling is dirty. @matz said in #21143
> But I don't want to break any existing code. I'd like... -
06:17 AM Revision d868922e (git): Fix regexp when non-ruby thread received the signal
- A space is added only when the source path is found.
-
- ## Goal
I want to manage application-level information (e.g., application configuration) while making it easily ac... -
04:46 AM Bug #18878: parse.y: Foo::Bar {} is inconsistently rejected
- Now `Foo::Bar {}` parses in parse.y too, but `Foo::Bar {} + 1` still doesn't parse unlike in Prism.
-
-
01:36 AM Revision 99503ab9 (git): Escape `Binding` reference in pattern matching docs
- 01:30 AM Revision 80ab4246 (git): [DOC] beginless and endless ranges inspect returns "nil..nil" always
- Small correction to the Range docs. All beginless (nil..) and endless (..nil) ranges, as well as fully open ranges (n...
03/20/2025
-
- https://github.com/ruby/prism/commit/0073266cad
-
- https://github.com/ruby/prism/commit/fd96a6821f
-
- It's not my favorite api but for users that currently use the same thing
from `parser`, moving over is more difficult... -
09:01 PM Bug #20934: `UnboundMethod#bind_call` may cause "double free or corruption" with Ractor
- This should be fixed by bfe6068417ca41a6b88a1ba5fcde04f9a76718a7. I have some quick benchmark results in https://gith...
-
- Applied in changeset commit:git|bfe6068417ca41a6b88a1ba5fcde04f9a76718a7.
----------
Use atomic for method reference... -
- This changes reference_count on rb_method_definition_struct into an
atomic.
Ractors can create additional references... -
- Blocks insert a leading `nop` instruction in order to execute a "block
call" tracepoint. Block compilation unconditio... -
05:29 PM Bug #21193 (Closed): Inherited callback returns `nil` for `Object.const_source_location`
- Applied in changeset commit:git|de097fbe5f3df105bd2a26e72db06b0f5139bc1a.
----------
Trigger `inherited` and `const_... -
- That's what your PR does, I reviewed it, LGTM.
-
- Probably worth trying:
1. set the superclass, without calling `inherited`
2. set the constant (which also names the... -
- I tried to manage both considerations in https://github.com/ruby/ruby/pull/12956.
-
- Eileen, I proposed to document the previous ordering ([ruby#12759](https://github.com/ruby/ruby/pull/12759)), but the...
-
03:31 PM Bug #21193 (Closed): Inherited callback returns `nil` for `Object.const_source_location`
- Since https://github.com/ruby/ruby/pull/12927 the inherited callback no longer can access the `Object.const_source_lo...
-
05:28 PM Revision f07af59a (git): [ruby/prism] Dynamically register events to dispatch
- Instead of requiring the consumer to provide a list of all events which
they wish to handle, we can give them to opti... -
- [Misc #21143]
[Bug #21193]
The previous change caused a backward compatibility issue with code
that called `Object.c... -
- [Backport #21094]
-
- [Backport #21186]
-
-
- Applied in changeset commit:git|820c541671d9485144d81138bb029f2da8379edd.
----------
[Bug #21026] no singleton metho... -
-
06:44 AM Bug #21176 (Closed): Regression in case-insensitive matching for single-byte encodings
03/19/2025
-
- https://github.com/ruby/prism/commit/c02429765b
-
- https://github.com/ruby/prism/commit/d85c72a1b9
-
- `category` is only supported from Ruby 3.0 onwards and prism can still run with Ruyb 2.7
https://github.com/ruby/pri... -
- In https://github.com/ruby/prism/pull/3494 I added a bit of code
so that using the new builder doesn't break stuff.
T... -
- Backported to 3.4 in ae2fcdc0f705e767045c2bd5253e8eae733d2edb
-
- Backported in e15a9044d7a9ee5435e7a6d19ef9ac46b50bb880
-
- Backported in 698741d73a0e6c998fb47297ce7b129366b4835b
-
- Backported in 762e76cc50db059e71d1f6c13674103a488f5171
-
- Backported in 0e416faf450159a989fba87b41f3e3874a4af129
-
07:20 PM Bug #21141: `Time#utc?` does not work with a timezone object
- Should we backport this minor doc change?
-
- Don't mind, I understand it as a problem. Others have pointed this problem out to me. We need to convince @ko1.
Cl... -
04:00 PM Bug #21192: Coverage no longer reports coverage information about tracepoint handlers
- Oh my, I had forgotten about it, sorry for the noise!
-
- This is a duplicate of #16776 that you created, isn't it? :-)
-
- I minimized the issue like this:
### repro.rb
```ruby
require "coverage"
Coverage.start
require_relative... - 08:01 AM Revision 4e11ea42 (git): Update default gems list at 265dcd1733ede8f3e4cb13322392d6 [ci skip]
-
- https://github.com/ruby/optparse/commit/8c2c7a4903
-
-
-
- Since `rb_bug` does not always take Ruby frame info during SEGV, the
source file path may not be output.
```
1) Fa...
03/18/2025
-
- Applied in changeset commit:git|adaaa7878ebee62888bf3547d14c1db4938da88a.
----------
Handle void expressions in defi... -
- I have updated Prism with https://github.com/ruby/ruby/commit/adaaa7878ebee62888bf3547d14c1db4938da88a, but the added...
-
09:04 PM Bug #21083 (Closed): current SystemCallError.new(-1) behavior on windows is not in accordance with the intent of the source code.
- Applied in changeset commit:git|0f6c647b1a1e313e3cb4fe79d4b63ffa2b7a6a6e.
----------
avoid platform dependent messag... -
- Applied in changeset commit:git|f69ad0e810e1fdc18dc12f77bbecfa49999ef3bf.
----------
[Bug #21094] Update nested modu... - 07:07 PM Revision e391c337 (git): Update default gems list at 6e9568d202389dc5f820b024315cf8 [ci skip]
-
- https://github.com/ruby/prism/commit/71d31db496
-
- [Bug #21029]
-
-
- https://github.com/ruby/prism/commit/2afe89f8ce
-
- Caused by https://github.com/ruby/prism/pull/3478 and https://github.com/ruby/prism/pull/3443
I also made the builde... -
- This can get triggered even if the list of statements only contains
a single statement. This is necessary to properly... -
- ```
(a,), = []
PARSER====================
s(:masgn,
s(:mlhs,
s(:mlhs,
s(:lvasgn, :a))),
s(:array))
PRI... -
- In https://github.com/ruby/prism/commit/26370079291a420c6b2b7be5cdbd5c609da62f21 I added tests but didn't modify them...
-
- Mostly around newlines and line continuation.
* percent arrays need special backslash handling in the ast
* Fix offse... -
- Of course, these won't really be fixtures, but it allows to test against whole codebases
without copying them, doing ... -
- https://github.com/ruby/prism/commit/422d5c4c64
-
- I see `Array.include?` as 2.4% runtime. Probably because of `LPAREN_CONVERSION_TOKEN_TYPES` but
the others will be fa... -
- `Integer#chr` performs some validation that we don't want/need. Octal escapes can go above 255, where it will then ra...
-
- https://github.com/ruby/prism/commit/09c59a3aa5
-
- Mostly around newlines and line continuation.
* percent arrays need special backslash handling in the ast
* Fix offse... -
- Turns out, it was already almost correct. If you disregard \c and \M style escapes, only a single character is allowe...
-
- Also fixes a token incompatibility for the word separator. parser only considers whitespace until the first newline
... -
- When the line contains no real newline but contains unescaped ones, then there will be one less entry
https://github... -
- This is a followup to #3373, where the implementation
was extracted
https://github.com/ruby/prism/commit/2637007929 -
- The offset cache contains an entry for each byte so it can't be accessed via the string length.
Adds tests for all v... -
- There are a few other locations that should be included in that check.
I think the end location must always be presen... -
- https://github.com/ruby/prism/commit/bde8ccc038
-
- `Integer#chr` performs some validation that we don't want/need. Octal escapes can go above 255, where it will then ra...
-
- Mostly around newlines and line continuation.
* percent arrays need special backslash handling in the ast
* Fix offse... -
- I want to add new node types to the parser translator, for example `itblock`. The bulk of the work is already done by...
-
-
- 1. The string starts out as binary
2. `ち` is appended, forcing it back into utf-8
3. Some invalid byte sequences are ... -
- change SystemCallError.new(-1) message on Windows
(Bug #21083)
https://bugs.ruby-lang.org/issues/21083 -
-
- Co-authored-by: Nobuyoshi Nakada <[email protected]>
-
- (Bug #21083)
https://bugs.ruby-lang.org/issues/21083 -
- https://github.com/ruby/prism/commit/f734350499
-
03:34 PM Bug #21191 (Feedback): Ruby 3.4.2 crashes unexpectedly
- Running my Rails app in development mode with Ruby 3.4.2 crashes with:
Thread 15 Crashed:: puma srv tp 003
0 li... -
-
- I think tracing ivar assignments would be prohibitively slow, and so probably not really usable in practice.
-
- Applied in changeset commit:git|e63c516046b6dbf2f684454b68013b4eea12e94a.
----------
[Feature #19908] Update Unicode... -
01:35 AM Feature #19908: Update to Unicode 15.1
- Thanks, I've finished to prepare your account now.
-
- https://www.unicode.org/reports/tr29/tr29-43.html#GB9c
-
-
-
-
- Hi @mame.
After thinking about this, I have an important use case that I'd like to share, because it conflicts wit... -
-
- `Match#destruct` and `Match#destruct_keys` have been defined since ruby 3.2.
`Match#destruct` is an alias of `Match#... -
-
05:32 AM Feature #21190: Proposal for the Deconstruct Method in the MatchData Class
- You can implement this more easily using named captures:
```ruby
/(?<country_code>\d{2})(?<area_code>\d{2})(?<num... -
05:21 AM Feature #21190 (Closed): Proposal for the Deconstruct Method in the MatchData Class
- ## Context:
The MatchData class currently lacks the deconstruct method, which is necessary for extracting values f... -
- 07:28 AM Revision 76aaf8dd (git): [ruby/date] Add license files (COPYING, BSDL) to gem files
- https://github.com/ruby/date/commit/a3d85e0be5
-
-
-
-
- If you can't submit pull-request to https://github.com/ruby/git.ruby-lang.org/. Please use `[email protected]` ...
-
- I'm working hardening git.ruby-lang.org and ruby organization of GitHub in recent days. Our write grant policy is:
... -
- When reading from tty, `^D` ends the text without the newline.
```console
$ cat
a
```
Typing `^D` here, only... - 12:42 AM Revision 9b49ba5a (git): [rubygems/rubygems] Speed up Version#<=> ~20-50% when lengths differ
- Previously, the comparison code would loop through segments up to the
longest of the two versions being compared. How...
03/17/2025
-
09:10 PM Bug #21187 (Assigned): Strings concatenated with `\` getting frozen with literal hashes (PRISM only)
- When the first elements of a literal hash are strings that are concatenated with `\`, those elements are flagged with...
-
08:12 PM Revision 2dc50149 (git): [DOC] Fix indentation for documentation of Hash#compact
-
07:41 PM Feature #15854: Tracing instance variable assignment
- How about this naming convention:
- `ivar_set`
- `cvar_set`
- `gvar_set`
`ivar`, `cvar`, and `gvar` all match... -
- Applied in changeset commit:git|1acfb29015dbc38fd345d8786aa78aad59f7dcd1.
----------
[Bug #21186] multibyte char lit... -
05:19 PM Revision 52f65634 (git): Allow arguments to be passed through Binding#irb (#12796)
- * Allow arguments to be passed through Binding#irb
Modified Binding#irb to forward any arguments to the underlying i... -
02:55 PM
Bug #21185 (Closed): Range#overlap? is not commutative with doubly-unbounded range argument.
- Applied in changeset commit:git|b5cdbadeeddd2b8e834b9d5565c13fcc43f3e684.
----------
[Bug #21185] Fix Range#overlap?... -
- 02:42 PM Revision c85dffee (git): Avoid pinning `storage_head` in `iseq_mark_and_move` (#12880)
- * Avoid pinning `storage_head` in `iseq_mark_and_move`
This refactor changes the behavior of `iseq_mark_and_move` to... -
-
- `Proc` does not have `encoding` method.
Also, make `assert_raise_with_message` accept a `Proc` as the expected
patte... -
- Enum array may be the list of pairs of key and value. Check if only
key is completable, not pair.
Fix https://githu... - 07:26 AM Revision b5cdbade (git): [Bug #21185] Fix Range#overlap? with infinite range
- Infinite ranges, i.e. unbounded ranges, should overlap with any other range
which wasn't the case in the following ex... -
- @hsbt
I've sent an email to cvs-admin and opened https://github.com/ruby/git.ruby-lang.org/pull/91 -
- @ima1zumi Can you provide the required information to me? See https://github.com/ruby/ruby/wiki/Committer-How-To#how-...
-
02:53 AM Feature #19908: Update to Unicode 15.1
- #note-16 Approved.
Matz.
03/16/2025
-
08:00 PM Revision 3e04f7b6 (git): Only mark `cc->cme_` on valid imemo_callcache
- We observed T_NONE on `cc->cme_` on a --repeat-count=50 run a compaction
test on CI:
http://ci.rvm.jp/results/trunk-r... -
03:35 PM Revision 70a9e5f6 (git): [DOC] Doc for Hash#transform_keys
-
12:22 PM Bug #21131: IO.copy_stream: yielded string changes value when duped
- ruby_3_3 commit:f85e5e01bafeca387e833b9d79cab43a8b22aa3d merged revision(s) commit:f423f6e10c0c226dfed98e7cb7a5d48919...
-
- Ensure IO.copy_stream buffer is an independent string
Otherwise, changes to the buffer by the destination wr... -
- https://github.com/ruby/ruby/pull/12873
-
- ruby_3_3 commit:726bff43b462d2a1b0bc93299cf031202f7fe7a1 merged revision(s) commit:c224ca4feaff20cab03d76439bcbfb35d4...
-
- ruby_3_3 commit:2b2ab1a67c236eb0c47e63e8adcf877b0d20a38c merged revision(s) commit:08b3a45bc97c835b4677bf76dbce68fd51...
-
- Push a real iseq in rb_vm_push_frame_fname()
Previously, vm_make_env_each() (used during proc
creati... -
- ruby_3_3 commit:d213eb7f453fa0bd6c476826c450d9726c3c8b15 merged revision(s) commit:3f07bc76ff6a11232d9f18e5eaa31835c1...
-
- [Bug #21144] Win32: Use Windows time zone ID if TZ is not set
If the TZ environment variable is not set, the... -
- Fix a race condition with interned strings sweeping.
[Bug #21172]
This fixes a rare CI failure.
... -
-
- The content depends on ruby internal, not responsibility of the
caller. Revive `RUBY_GLOBAL_SETUP` macro to define t... -
- Added comparison with escaped chars
-
- `?あand 0` has inconsistent behavior between Prism and parse.y.
```console
% ./miniruby --parser=parse.y -e "?aand... -
- ruby_3_3 commit:da86a9959b4c5bbdefb6fd1000a0251a151ffbc1 merged revision(s) commit:2b6fc9ea7212543a1be26768403f59c7a7...
-
- ruby_3_3 commit:1d3c19871d7a0d05a0f0a80e78cfad843b7ef324 merged revision(s) commit:931ac960b6d11937364b6c4e847fdd575e...
-
- [Bug #21159] module names should not be modifiable
-
- [Bug #21092] Fallback variables after execonf has done
When reading from a dummy makefile, the global variab... -
- committed at commit:ac3f355fb33f4ce41df864f2084028610b7b38d1.
-
- In general I think the syntax should not be changed in stable branches.
But segmentation fault should be avoided as ... -
-
-
- Applied in changeset commit:git|06919949a60b42a8f30e8bd0cb075e17b05eebcd.
----------
[Bug #21141] [DOC] Clarify what... -
03/15/2025
-
07:21 PM Bug #21185: Range#overlap? is not commutative with doubly-unbounded range argument.
- https://github.com/ruby/ruby/pull/12937
-
- In https://bugs.ruby-lang.org/issues/20725 the following:
``` ruby
(nil..nil).overlap?(..3)
```
was fixed to outp... -
- * Use `assert_raise_kind_of` instead of `rescue` and `flunk`.
* Use `assert_include` for the pattern that may contain... -
- 06:50 AM Revision b148dfef (git): Fix crash in TCPSocket.open
- Fix segfault crash observable with TCPSocket.open(nil, nil)
-
- +1
-
12:36 AM Feature #19908: Update to Unicode 15.1
- +1
Also available in: Atom