Re: [matplotlib-devel] Introduction

>>>>> "Greg" == Greg Willden <gre...@gm...> writes:

    Greg> Hi All, I'm a longtime Matlab user.  I've been using Python
    Greg> for a year or two and have begun using
    Greg> Matplotlib/Numpy/Scipy.  I have a patch for specgram() that
    Greg> will plot the spectrogram with the positive and negative
    Greg> frequencies flipped (fftshift).  This is the way that you
    Greg> would examine the complex data coming out of a receiver.

    Greg> What is the prefered method for submitting patches?  I
    Greg> didn't find any information on the website.

The best way is to add them as patches to the sf site and then post
here with a link to the patch (and attach the patch if possible).  I
tend to monitor this list much more closely, but it is nice to have it
on the sf site if it falls between the cracks because it is easier for
someone to pick it up later.  If you get no action in a week or two,
ping us again.

    Greg> Also, I would like to add support for more window functions
    Greg> in specgram().  I see three options for doing this: a) Add
    Greg> the window functions directly ( drawback: code duplication)
    Greg> b) Add wrappers for the window functions in SciPy (drawback:
    Greg> additional dependencies?)  

We are trying to move away from adding our own numerical code and have
this go into numpy/scipy.  I suggest adding a docstring saying,
additional window functions a,b and c are available in
somepackage.somemodule

    Greg> c) Modify specgram so that if it
    Greg> receives an array as the window parameter it checks its
    Greg> length and then applies it as a window.  If the window
    Greg> parameter is not an array then it treats it as a function
    Greg> (current behaviour)

This is fine -- I suggest using the matplotlib.cookbook.iterable
function or the python builtin callable function to do the check.
Whatever changes you make for specgram should also be ported into psd,
csd and cohere.

Thanks,
JDH