Re: [Postgres-xc-developers] 2nd (revised) patch to check xid for implicit 2PC

Hi,
----------
Koichi Suzuki



2012年3月27日19:27 Pavan Deolasee <pav...@en...>:
>
>
> On Tue, Mar 27, 2012 at 8:27 AM, Koichi Suzuki <ko...@in...>
> wrote:
>>
>> Hi,
>>
>> Enclosed is a revised patch to check xid for implicit 2PC.   Now it is
>> checked and not allowed to use in explicit PREPARE TRANSACTION.
>>
>
> Couple of quick comments:
>
> 1. I think it should suffice to just check for GIDs starting with the
> pattern "_$XC$" to declare then invalid. Also, a hint regarding system
> reserved GIDs will be very useful to the user

Agreed.

>
> 2. Instead of hardcoding the length as 5, why not just use strlen() to do
> compute that ? I think compiler would be smart enough to optimize repeated
> evaluation if thats what worries you.

I was not sure if strlen() for the constant string can be computed by
the compiler.

I will replace this with strlen().

> Thanks,
> Pavan
>
> --
> Pavan Deolasee
> EnterpriseDB http://www.enterprisedb.com
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>