postgres-xc-committers Mailing List for Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  d6917fc7629b2a99651d4fab5465ddb8e723cd4b (commit)
      from  9fe8dc04625176fd12bad9b13ab5ec0b483b3f84 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=d6917fc7629b2a99651d4fab5465ddb8e723cd4b

commit d6917fc7629b2a99651d4fab5465ddb8e723cd4b
Author: Ashutosh Bapat <ash...@en...>
Date:   Wed Oct 19 09:50:42 2011 +0530

    The member is_single_step in RemoteQuery node is only assigned values to but
    never read and used. Hence removing this member.

M	src/backend/nodes/copyfuncs.c
M	src/backend/parser/analyze.c
M	src/backend/pgxc/plan/planner.c
M	src/include/pgxc/planner.h

-----------------------------------------------------------------------

Summary of changes:
 src/backend/nodes/copyfuncs.c   |    1 -
 src/backend/parser/analyze.c    |    1 -
 src/backend/pgxc/plan/planner.c |    6 ------
 src/include/pgxc/planner.h      |    1 -
 4 files changed, 0 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
Postgres-XC

On Wed, Oct 19, 2011 at 12:51 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Thanks for your reply.
>
> I think I am using this code to my advantage for FQS, so no need to worry
> about it.

Thanks. This is good to know.
-- 
Michael Paquier
http://michael.otacoo.com

Thanks for your reply.

I think I am using this code to my advantage for FQS, so no need to worry
about it.

On Wed, Oct 19, 2011 at 5:10 AM, Michael Paquier
<mic...@gm...>wrote:

>
>
> On Mon, Oct 17, 2011 at 8:04 PM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Hi All,
>> In transformExecDirectStmt() we set sql_statement to NULL.
>> 2353     /* Default list of parameters to set */
>> 2354     step->is_single_step = true;
>> 2355     step->sql_statement = NULL;
>> 2356     step->exec_nodes = makeNode(ExecNodes);
>> 2357     step->combine_type = COMBINE_TYPE_NONE;
>> 2358     step->sort = NULL;
>>
>> Later in pgxc_planner() we deparse the Query node and build the SQL
>> statement. Why don't we use the sql_statement in the Query node itself or
>> set RemoteQuery->sql_statement in this function itself? Why do we need to
>> deparse it in pgxc_planner()?
>>
> We do not need to parse the query, sending a raw string is enough. This is
> what I could call a bug :)
> I haven't been through this code in months, and unfortunately the fixes I
> did in this part were kind of made in a hurry, so there may be other issues.
> I will try to rework this code by the end of the month if possible as I've
> been kept busy now with release stuff, etc.
> Regards,
> --
> Michael Paquier
> http://michael.otacoo.com
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company