postgres-xc-developers Mailing List for Postgres-XC

Michael,
I will take care of updating the code.

I would be nice if you could review the patch from the UPDATE/DELETE point
of view. RemoteQuery nodes is also created under ModifyTable to send
UPDATE/DELETE queries. You know that code better.

On Fri, Jun 8, 2012 at 7:02 PM, Michael Paquier
<mic...@gm...>wrote:

> Do not forget to realign your code with current master, the copyrights are
> incorrect in this patch as they still refer to NTT and not xc development
> group.
>
> On 2012/06/08, at 22:04, Ashutosh Bapat <ash...@en...>
> wrote:
>
> > Hi All,
> > PFA the patch to support projection in RemoteQuery nodes. The patch also
> has some cleanup and expected output changes because of the fix. The plan
> also simplifies the handling of materialization in RemoteQuery node. The
> materialisation is needed only in case rescan is required, but still we
> always materialise. Hence there is scope for some performance improvement
> here, but this patch does not do that.
> >
> > How does projection work
> > In RemoteQuery node we provide base_tlist as the target list
> representing the data expected from the datanodes. This provides the scan
> tuple descriptor. The actual targetlist expected from the RemoteQuery node
> is saved in scan.plan.targetlist like other scan plans. This serves as the
> projection list. Rest of the logic to link the scan targetlist and project
> targetlist and also to apply quals is built in ExecScan().
> >
> > Advantages
> > 1. Since RemoteQuery nodes can project, there is no need to add Result
> node on top of RemoteQuery nodes.
> > 2. 1 makes reduction in create_remotejoin_plan easier and better.
> > 3. ExecRemoteQuery node now follows template similar to ExecSeqScan and
> uses ExecScan to do most of its work, thus reducing and simplifying a lot
> of code.
> >
> > Amit,
> > Since you had worked on an issue in this area, please spend some time
> reviewing the patch and provide your comments. Others too are very much
> welcome.
> >
> > --
> > Best Wishes,
> > Ashutosh Bapat
> > EntepriseDB Corporation
> > The Enterprise Postgres Company
> >
> > <xc_project_remote.patch>
> >
> ------------------------------------------------------------------------------
> > Live Security Virtual Conference
> > Exclusive live event will cover all the ways today's security and
> > threat landscape has changed and how IT managers can respond. Discussions
> > will include endpoint security, mobile security and the latest in malware
> > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> > _______________________________________________
> > Postgres-xc-developers mailing list
> > Pos...@li...
> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company