postgres-xc-developers Mailing List for Postgres-XC

Hi Michael,

I noticed you added IsConnFromCoord() after macro IS_PGXC_COORDINATOR
in all your committed code today and yesterday. I doubt whether it's
right.
In this patch,
                                     if (IS_PGXC_COORDINATOR &&
IsConnFromCoord())  //I consider IsConnFromCoord() should not be added
here because the coordinator which is connected by psql cann't execute
the code below.
			{
				RemoteQueryExecType remoteExecType = EXEC_ON_ALL_NODES;
				RenameStmt *stmt = (RenameStmt *) parsetree;

				if (stmt->renameType == OBJECT_SEQUENCE)
					remoteExecType = EXEC_ON_COORDS;
				else if (stmt->renameType == OBJECT_TABLE)
				{
					Oid relid = RangeVarGetRelid(stmt->relation, false);

					if (get_rel_relkind(relid) == RELKIND_SEQUENCE)
						remoteExecType = EXEC_ON_COORDS;
				}

				ExecUtilityStmtOnNodes(queryString, NULL, false,
remoteExecType);//There is "if (!IsConnFromCoord())" clause in this
function. It can control the execution flow.
			}

Regards,
Benny

> Hi,
>
> Just to let you know that this patch has been committed in git repository
> with this ID:
> 28da86b88e667b5e45e6deef831cc839ccba2703
>
> The logic of the patch was OK, I don't really have comments.
> Well 1 perhaps...
> Be sure to respect the 4-space tab :)
> This is a PostgreSQL convention.
>
> Regards,
>
> --
> Michael Paquier
> http://michaelpq.users.sourceforge.net
>
>

Hi,

Just to let you know that this patch has been committed in git repository
with this ID:
28da86b88e667b5e45e6deef831cc839ccba2703

The logic of the patch was OK, I don't really have comments.
Well 1 perhaps...
Be sure to respect the 4-space tab :)
This is a PostgreSQL convention.

Regards,

-- 
Michael Paquier
http://michaelpq.users.sourceforge.net

2011/1/12 Michael Paquier <mic...@gm...>:
> On Tue, Jan 11, 2011 at 11:57 AM, xiong wang <wan...@gm...> wrote:
>>
>> > I think there is still the multiple INSERT patch you wrote that needs
>> > some
>> > review, no?
>> >
>>
>> Yes. It will be much appreciated if you can review. Should I revise
>> and submit my patch now or after your recent release?
>
> Sorry for my late reply.
> I would say the faster the better, so feel free to submit your patch to the
> mailing list before the next release.
>
> If you could realign your code with the latest head,
> I'll be pleased to have a look at it and give you some feedback.
>
Ok, I will submit the patch soon.
Regards,
Benny
> Regards,
> --
> Michael Paquier
> http://michaelpq.users.sourceforge.net
>
>

On Tue, Jan 11, 2011 at 11:57 AM, xiong wang <wan...@gm...> wrote:

> > I think there is still the multiple INSERT patch you wrote that needs
> some
> > review, no?
> >
>
> Yes. It will be much appreciated if you can review. Should I revise
> and submit my patch now or after your recent release?
>
Sorry for my late reply.
I would say the faster the better, so feel free to submit your patch to the
mailing list before the next release.

If you could realign your code with the latest head,
I'll be pleased to have a look at it and give you some feedback.

Regards,
-- 
Michael Paquier
http://michaelpq.users.sourceforge.net