Menu
▾
▴
postgres-xc-developers — Postgres-XC hackers and developers
You can subscribe to this list here.
| 2010 |
Jan
|
Feb
|
Mar
|
Apr
(10) |
May
(17) |
Jun
(3) |
Jul
|
Aug
|
Sep
(8) |
Oct
(18) |
Nov
(51) |
Dec
(74) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2011 |
Jan
(47) |
Feb
(44) |
Mar
(44) |
Apr
(102) |
May
(35) |
Jun
(25) |
Jul
(56) |
Aug
(69) |
Sep
(32) |
Oct
(37) |
Nov
(31) |
Dec
(16) |
| 2012 |
Jan
(34) |
Feb
(127) |
Mar
(218) |
Apr
(252) |
May
(80) |
Jun
(137) |
Jul
(205) |
Aug
(159) |
Sep
(35) |
Oct
(50) |
Nov
(82) |
Dec
(52) |
| 2013 |
Jan
(107) |
Feb
(159) |
Mar
(118) |
Apr
(163) |
May
(151) |
Jun
(89) |
Jul
(106) |
Aug
(177) |
Sep
(49) |
Oct
(63) |
Nov
(46) |
Dec
(7) |
| 2014 |
Jan
(65) |
Feb
(128) |
Mar
(40) |
Apr
(11) |
May
(4) |
Jun
(8) |
Jul
(16) |
Aug
(11) |
Sep
(4) |
Oct
(1) |
Nov
(5) |
Dec
(16) |
| 2015 |
Jan
(5) |
Feb
|
Mar
(2) |
Apr
(5) |
May
(4) |
Jun
(12) |
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(4) |
| 2019 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
(2) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
|
|
1
(12) |
2
(2) |
|
3
(1) |
4
(6) |
5
(11) |
6
(4) |
7
(6) |
8
(5) |
9
|
|
10
|
11
(1) |
12
(6) |
13
(23) |
14
(5) |
15
(5) |
16
|
|
17
|
18
(1) |
19
|
20
(2) |
21
(2) |
22
(4) |
23
|
|
24
|
25
|
26
|
27
(3) |
28
(1) |
29
(2) |
30
|
|
From: 黄秋华 <ra...@16...> - 2011-04-15 05:14:03
|
OK , thanks a lot for reviewing code~ rahuahua -- At 2011-04-15 12:08:05，"Michael Paquier" <mic...@gm...> wrote: Regressions are OK. It has been committed with ID 820571e184fb6ae4dd4e63f14724afab283112e2. Thanks a lot for the good work ! Michael |
|
From: Michael P. <mic...@gm...> - 2011-04-15 04:08:13
|
Regressions are OK. It has been committed with ID 820571e184fb6ae4dd4e63f14724afab283112e2. Thanks a lot for the good work ! Michael |
|
From: Michael P. <mic...@gm...> - 2011-04-15 03:46:27
|
OK, thanks, I am running them too. Btw, you did a good job by finding this bug. All my individual test cases are working now. -- Thanks, Michael Paquier http://michael.otacoo.com |
|
From: rahua1<ra...@16...> - 2011-04-15 00:59:58
|
OK, I will do regression test.
2011-04-15
rahua1
发件人: Michael Paquier <mic...@gm...>
发送时间: 2011-04-15 08:22
主 题: Re: [Postgres-xc-developers] the patch for fixing bug#3124253
收件人: 黄秋华 <ra...@16...>
抄 送: pos...@li...
Hi,
Indeed there is an error of logic in the code.
But I think the problem you analyzed was bug 3231445 (which is related to 3140473),
and not bug 3124253 that has been solved last month.
However, you are right in the fact that by launching the following queries:
create table country (country_ab char(2), country_name char(30));
insert into country values ('ZZ','FOFO'),('AA','AAAA');
copy country to '/tmp/country.data';
I got gdb going like that:
Breakpoint 1, build_copy_statement (cstate=0x10d7cd8, attnamelist=0x0, tupDesc=0x7f929b56c190,
is_from=0 '\000', force_quote=0x0, force_notnull=0x0) at copy.c:3872
3872 ExecNodes *exec_nodes = makeNode(ExecNodes);
(gdb) n
3879 cstate->rel_loc = GetRelationLocInfo(RelationGetRelid(cstate->rel));
(gdb)
3881 pPartByCol = GetRelationDistColumn(cstate->rel_loc);
(gdb) p cstate->rel_loc
$1 = (RelationLocInfo *) 0x10d7f48
(gdb) p *cstate->rel_loc
$2 = {relid = 16436, locatorType = 78 'N', partAttrNum = 0, partAttrName = 0x0, nodeCount = 2,
nodeList = 0x10d7fc8, roundRobinNode = 0x0}
(gdb) n
3882 if (cstate->rel_loc)
(gdb)
3884 if (is_from || pPartByCol)
(gdb)
3892 exec_nodes->nodelist = GetAnyDataNode();
(gdb)
What it indeed incorrect because for a copy to we need all the connections for a round robin table.
The origin of the problem is that here the table country has no distribution data, and the analysis is based on that.
I think I'll be able to commit that patch, after checking it passes regression and test cases attached (perhaps you may be interested).
--
Thanks,
Michael Paquier
http://michael.otacoo.com |
|
From: Michael P. <mic...@gm...> - 2011-04-15 00:22:48
|
Hi,
Indeed there is an error of logic in the code.
But I think the problem you analyzed was bug 3231445 (which is related to
3140473),
and not bug 3124253 that has been solved last month.
However, you are right in the fact that by launching the following queries:
create table country (country_ab char(2), country_name char(30));
insert into country values ('ZZ','FOFO'),('AA','AAAA');
copy country to '/tmp/country.data';
I got gdb going like that:
Breakpoint 1, build_copy_statement (cstate=0x10d7cd8, attnamelist=0x0,
tupDesc=0x7f929b56c190,
is_from=0 '\000', force_quote=0x0, force_notnull=0x0) at copy.c:3872
3872 ExecNodes *exec_nodes = makeNode(ExecNodes);
(gdb) n
3879 cstate->rel_loc =
GetRelationLocInfo(RelationGetRelid(cstate->rel));
(gdb)
3881 pPartByCol = GetRelationDistColumn(cstate->rel_loc);
(gdb) p cstate->rel_loc
$1 = (RelationLocInfo *) 0x10d7f48
(gdb) p *cstate->rel_loc
$2 = {relid = 16436, locatorType = 78 'N', partAttrNum = 0, partAttrName =
0x0, nodeCount = 2,
nodeList = 0x10d7fc8, roundRobinNode = 0x0}
(gdb) n
3882 if (cstate->rel_loc)
(gdb)
3884 if (is_from || pPartByCol)
(gdb)
3892 exec_nodes->nodelist = GetAnyDataNode();
(gdb)
What it indeed incorrect because for a copy to we need all the connections
for a round robin table.
The origin of the problem is that here the table country has no distribution
data, and the analysis is based on that.
I think I'll be able to commit that patch, after checking it passes
regression and test cases attached (perhaps you may be interested).
--
Thanks,
Michael Paquier
http://michael.otacoo.com
|
