postgres-xc-developers Mailing List for Postgres-XC

Thank you very much for pointing out the issue.

I will put this to bug track list of the project.

Practically, it is just for internal use.   When coordinator receives 
statements using sequence, it first looks up coordinator catalog and go 
to GTM only when it is registered.   So this will not cause any problem.

Call to gtm is not exposed to XC application.   It is only called from 
within coordinator and datanode internals.

Thank you again;
---
Koichi Suzuki

(2011年01月13日 12:31), Suzuki Hironobu wrote:
> Dear developers,
>
> I found a gtm's bug.
>
> Two functions in gtm_seq.c (ProcessSequenceGetCurrentCommand and
> ProcessSequenceGetNextCommand) do not return the error even if
> sequence_key is not registered.
> In this case, these functions return 22 (= EINVAL) as a normal value.
> Therefore, gtm also returns 22 to proxy and coordinator.
>
>
> Regards,
> suzuki hironobu
>
>
> P.S.
> The simplest bugfix patch is as follows:
>
> diff -crN pgxc.org/src/gtm/main/gtm_seq.c pgxc/src/gtm/main/gtm_seq.c
> *** pgxc.org/src/gtm/main/gtm_seq.c 2011-01-13 11:38:55.000000000 +0900
> --- pgxc/src/gtm/main/gtm_seq.c 2011-01-13 11:45:48.000000000 +0900
> ***************
> *** 532,535 ****
> if (seqinfo == NULL)
> {
> ! ereport(LOG,
> (EINVAL,
> --- 532,535 ----
> if (seqinfo == NULL)
> {
> ! ereport(ERROR,
> (EINVAL,
> ***************
> *** 596,599 ****
> if (seqinfo == NULL)
> {
> ! ereport(LOG,
> (EINVAL,
> --- 596,599 ----
> if (seqinfo == NULL)
> {
> ! ereport(ERROR,
> (EINVAL,
>
>
>
>
> ------------------------------------------------------------------------------
> Protect Your Site and Customers from Malware Attacks
> Learn about various malware tactics and how to avoid them. Understand
> malware threats, the impact they can have on your business, and how you
> can protect your company and customers by using code signing.
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>