postgres-xc-developers Mailing List for Postgres-XC

Hmm Ok. Please commit the patch. I will be nice to write down somewhere, as
to how do we choose different ports, directories, for various coordinators
and datanodes.

On Fri, Sep 2, 2011 at 1:31 PM, Michael Paquier
<mic...@gm...>wrote:

>
>
> On Fri, Sep 2, 2011 at 3:32 PM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Hi Michael,
>> Sorry for delay.
>> Here are my comments,
>> 1. This patch adds  xc_groupby xc_distkey xc_having xc_temp in parallel
>> schedule. Does that mean that these tests will be run simultaneously? If so,
>> we have to make sure that they create tables/objects with different names
>> such that those do not conflict with each other. Are we going to use second
>> coordinator for firing the parallel testcase?
>>
> Those test cases run OK in parallel.
>
>
>> 2. It may be better to separate the XC specific code into a separate C
>> file pgxc_regress.c or something and call it in pg_regress.c. That way
>> pg_regress will remain clean.
>
> I am not sure it is the way to do.
> In order to keep a code compact I made a lot of functions that use static
> variables of pg_regress.c as the same operations are repeated several times.
> If I put the additional functions in another file I will have to export
> those variables or add additional arguments when calling for external APIs.
> This may heavy the code more than light it up.
> --
> Michael Paquier
> http://michael.otacoo.com
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

On Fri, Sep 2, 2011 at 3:32 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi Michael,
> Sorry for delay.
> Here are my comments,
> 1. This patch adds  xc_groupby xc_distkey xc_having xc_temp in parallel
> schedule. Does that mean that these tests will be run simultaneously? If so,
> we have to make sure that they create tables/objects with different names
> such that those do not conflict with each other. Are we going to use second
> coordinator for firing the parallel testcase?
>
Those test cases run OK in parallel.


> 2. It may be better to separate the XC specific code into a separate C file
> pgxc_regress.c or something and call it in pg_regress.c. That way pg_regress
> will remain clean.

I am not sure it is the way to do.
In order to keep a code compact I made a lot of functions that use static
variables of pg_regress.c as the same operations are repeated several times.
If I put the additional functions in another file I will have to export
those variables or add additional arguments when calling for external APIs.
This may heavy the code more than light it up.
-- 
Michael Paquier
http://michael.otacoo.com

Hi Michael,
Sorry for delay.
Here are my comments,
1. This patch adds  xc_groupby xc_distkey xc_having xc_temp in parallel
schedule. Does that mean that these tests will be run simultaneously? If so,
we have to make sure that they create tables/objects with different names
such that those do not conflict with each other. Are we going to use second
coordinator for firing the parallel testcase?
2. It may be better to separate the XC specific code into a separate C file
pgxc_regress.c or something and call it in pg_regress.c. That way pg_regress
will remain clean.

On Fri, Sep 2, 2011 at 10:56 AM, Michael Paquier
<mic...@gm...>wrote:

> Here is an updated version of the patch with some more comments.
>
> --
> Michael Paquier
> http://michael.otacoo.com
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

Here is an updated version of the patch with some more comments.
-- 
Michael Paquier
http://michael.otacoo.com