postgres-xc-developers Mailing List for Postgres-XC

I saw that the regression test xc_having is failing with this patch, because
of false explain reports.
This is not a big matter and please see updated patch attached.
However, the keyword "__FOREIGN_QUERY__" is printed from time to time in
tests. Everybody, especially Ashutosh, do you think it's OK like this?
-- 
Michael Paquier
http://michael.otacoo.com

On Wed, Oct 26, 2011 at 2:42 PM, Michael Paquier
<mic...@gm...>wrote:

> Hi,
>
> Could you be more precise with the SQLs you used in this test?
> I get the following result on a remote join for 2 tables.
> postgres=# create table aa (a int);
> CREATE TABLE
> postgres=# create table bb (a int);
> CREATE TABLE
> postgres=# explain select * from aa,bb;
>                                        QUERY
> PLAN
>
> ----------------------------------------------------------------------------------------
>  Nested Loop  (cost=0.00..2.04 rows=1 width=8)
>    ->  Materialize  (cost=0.00..1.01 rows=1 width=4)
>          ->  Data Node Scan (Node Count [2]) on aa  (cost=0.00..1.01
> rows=1000 width=4)
>    ->  Materialize  (cost=0.00..1.01 rows=1 width=4)
>          ->  Data Node Scan (Node Count [2])  (cost=0.00..1.01 rows=1000
> width=4)

Oh, OK. The second table name does not appear.
Here is the result with your patch:
                                       QUERY
PLAN
----------------------------------------------------------------------------------------
 Nested Loop  (cost=0.00..2.04 rows=1 width=8)
   ->  Materialize  (cost=0.00..1.01 rows=1 width=4)
         ->  Data Node Scan (Node Count [2]) on aa  (cost=0.00..1.01
rows=1000 width=4)
   ->  Materialize  (cost=0.00..1.01 rows=1 width=4)
         ->  Data Node Scan (Node Count [2]) on bb  (cost=0.00..1.01
rows=1000 width=4)
(5 rows)
-- 
Michael Paquier
http://michael.otacoo.com

Hi,

Could you be more precise with the SQLs you used in this test?
I get the following result on a remote join for 2 tables.
postgres=# create table aa (a int);
CREATE TABLE
postgres=# create table bb (a int);
CREATE TABLE
postgres=# explain select * from aa,bb;
                                       QUERY
PLAN
----------------------------------------------------------------------------------------
 Nested Loop  (cost=0.00..2.04 rows=1 width=8)
   ->  Materialize  (cost=0.00..1.01 rows=1 width=4)
         ->  Data Node Scan (Node Count [2]) on aa  (cost=0.00..1.01
rows=1000 width=4)
   ->  Materialize  (cost=0.00..1.01 rows=1 width=4)
         ->  Data Node Scan (Node Count [2])  (cost=0.00..1.01 rows=1000
width=4)
(5 rows)

On Wed, Oct 26, 2011 at 10:43 AM, xiong wang <wan...@gm...> wrote:

> Hi all,
>       The bug just like flows:
> postgres=# explain select * from j1_tbl, j2_tbl ;
>                                 QUERY PLAN
>
> -----------------------------------------------------------------------------
>  Data Node Scan  (cost=0.00..0.00 rows=0 width=0)
>   ->  Nested Loop  (cost=2.00..31103.90 rows=2482400 width=48)
>         ->  Broadcast Motion  (cost=2.00..49.40 rows=2140 width=8)
>               Hash Key:  ANY_KEY
>               ->  Seq Scan  (cost=0.00..31.40 rows=2140 width=8)
>         ->  Materialize  (cost=0.00..27.40 rows=1160 width=40)
>               ->  Seq Scan on j1_tbl  (cost=0.00..21.60 rows=1160 width=40)
>
> The second rangetable j2_tbl doesn't appear in the plan. The patch
> fixes such a problem.
>
Regards,
-- 
Michael Paquier
http://michael.otacoo.com

I reviewed the patch.  The original code looks strange and the proposed patch looks okay.

Further comments?
---
Koichi

On Wed, 26 Oct 2011 09:43:39 +0800
xiong wang <wan...@gm...> wrote:

> Hi all,
>        The bug just like flows:
> postgres=# explain select * from j1_tbl, j2_tbl ;
>                                  QUERY PLAN
> -----------------------------------------------------------------------------
>  Data Node Scan  (cost=0.00..0.00 rows=0 width=0)
>    ->  Nested Loop  (cost=2.00..31103.90 rows=2482400 width=48)
>          ->  Broadcast Motion  (cost=2.00..49.40 rows=2140 width=8)
>                Hash Key:  ANY_KEY
>                ->  Seq Scan  (cost=0.00..31.40 rows=2140 width=8)
>          ->  Materialize  (cost=0.00..27.40 rows=1160 width=40)
>                ->  Seq Scan on j1_tbl  (cost=0.00..21.60 rows=1160 width=40)
> 
> The second rangetable j2_tbl doesn't appear in the plan. The patch
> fixes such a problem.

Hi,

Please find attached an update of the patch that is ready for commit.
Concerning the code changes, I corrected the following issues:
- error messages in EXECUTE DIRECT
- GTM-Proxy problems with node name, code is now stabilized
- removed all the code warnings
Then, I made tests with 2 cluster configurations:
- 2Co/2Dn
- 5Co/5Dn
Regressions, DBT-1 and pgbench ran without issues.

Regards,
-- 
Michael Paquier
http://michael.otacoo.com

Hi all,
       The bug just like flows:
postgres=# explain select * from j1_tbl, j2_tbl ;
                                 QUERY PLAN
-----------------------------------------------------------------------------
 Data Node Scan  (cost=0.00..0.00 rows=0 width=0)
   ->  Nested Loop  (cost=2.00..31103.90 rows=2482400 width=48)
         ->  Broadcast Motion  (cost=2.00..49.40 rows=2140 width=8)
               Hash Key:  ANY_KEY
               ->  Seq Scan  (cost=0.00..31.40 rows=2140 width=8)
         ->  Materialize  (cost=0.00..27.40 rows=1160 width=40)
               ->  Seq Scan on j1_tbl  (cost=0.00..21.60 rows=1160 width=40)

The second rangetable j2_tbl doesn't appear in the plan. The patch
fixes such a problem.