Menu
▾
▴
postgres-xc-developers — Postgres-XC hackers and developers
You can subscribe to this list here.
| 2010 |
Jan
|
Feb
|
Mar
|
Apr
(10) |
May
(17) |
Jun
(3) |
Jul
|
Aug
|
Sep
(8) |
Oct
(18) |
Nov
(51) |
Dec
(74) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2011 |
Jan
(47) |
Feb
(44) |
Mar
(44) |
Apr
(102) |
May
(35) |
Jun
(25) |
Jul
(56) |
Aug
(69) |
Sep
(32) |
Oct
(37) |
Nov
(31) |
Dec
(16) |
| 2012 |
Jan
(34) |
Feb
(127) |
Mar
(218) |
Apr
(252) |
May
(80) |
Jun
(137) |
Jul
(205) |
Aug
(159) |
Sep
(35) |
Oct
(50) |
Nov
(82) |
Dec
(52) |
| 2013 |
Jan
(107) |
Feb
(159) |
Mar
(118) |
Apr
(163) |
May
(151) |
Jun
(89) |
Jul
(106) |
Aug
(177) |
Sep
(49) |
Oct
(63) |
Nov
(46) |
Dec
(7) |
| 2014 |
Jan
(65) |
Feb
(128) |
Mar
(40) |
Apr
(11) |
May
(4) |
Jun
(8) |
Jul
(16) |
Aug
(11) |
Sep
(4) |
Oct
(1) |
Nov
(5) |
Dec
(16) |
| 2015 |
Jan
(5) |
Feb
|
Mar
(2) |
Apr
(5) |
May
(4) |
Jun
(12) |
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(4) |
| 2019 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
(2) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
1
|
2
|
3
|
4
|
|
5
|
6
|
7
(13) |
8
(8) |
9
(12) |
10
(10) |
11
|
|
12
(1) |
13
(19) |
14
|
15
(22) |
16
(6) |
17
(20) |
18
|
|
19
|
20
(1) |
21
(1) |
22
(3) |
23
(4) |
24
(9) |
25
|
|
26
|
27
(4) |
28
(10) |
29
(3) |
30
(3) |
31
(2) |
|
|
From: Nikhil S. <ni...@st...> - 2013-05-07 13:31:38
|
Thanks Ashutosh, Looks ok to me. Regards, Nikhils On Tue, May 7, 2013 at 6:41 PM, Ashutosh Bapat < ash...@en...> wrote: > Hi Nikhil, > Thanks for the documentation changes. There were few more expected output > changes to make the test pass with the restriction. I have attached updated > patch. Please check if the changes are fine. I will commit it after that. > > > On Tue, Apr 30, 2013 at 6:17 PM, Nikhil Sontakke <ni...@st...>wrote: > >> There's so much noise in the output that it's kinda difficult to cogently >> provide a diff for just this case. Anyways I have added the relevant error >> messages in the output file where RESTART IDENTITY has been used. >> >> HTH, >> Nikhils >> >> >> On Tue, Apr 30, 2013 at 5:39 PM, Ashutosh Bapat < >> ash...@en...> wrote: >> >>> Hi Nikhil, >>> We are trying to clean up the regression, so that there are 0 failures. >>> This helps to stop new differences creeping in the already failing files. >>> >>> If there are features we are not supporting in XC, we are silencing >>> those failure (and only those failures) by adding alternate outputs. >>> truncate already has an alternate output file, so you need to change that. >>> >>> >>> On Tue, Apr 30, 2013 at 4:22 PM, Nikhil Sontakke <ni...@st...>wrote: >>> >>>> >>>> >>>> >>>> >>>>> Thanks for the patch. Please include the testcase expected output >>>>> changes as well. >>>>> >>>>> >>>> This patch already has a lot of other issues. I know I can provide a >>>> truncate_1.out but I do not see the point. >>>> >>>> PFA, patch with the documentation fixed up. >>>> >>>> Regards, >>>> Nikhils >>>> >>>> >>>>> >>>>> On Thu, Apr 25, 2013 at 2:21 PM, Nikhil Sontakke <ni...@st...>wrote: >>>>> >>>>>> PFA, the patch to disallow. >>>>>> >>>>>> >>>>>> >> +1 so far. Does anybody know how widely it is used? I hope it >>>>>> is not used widely. >>>>>> >>>>>> Suzuki-san, the user has an option to reset the sequence value >>>>>> afterwards on his own to circumvent this issue. So it should be ok.. >>>>>> >>>>>> Regards, >>>>>> Nikhils >>>>>> >>>>>> >>>>>> >>>>>> On Thu, Apr 25, 2013 at 2:05 PM, Ashutosh Bapat < >>>>>> ash...@en...> wrote: >>>>>> >>>>>>> Can you please provide the patch to restrict the feature? >>>>>>> >>>>>>> >>>>>>> On Thu, Apr 25, 2013 at 2:03 PM, Nikhil Sontakke < >>>>>>> ni...@st...> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> If it can not be done easily and before release, we need to at >>>>>>>>> least disable RESTART IDENTITY clause. >>>>>>>>> >>>>>>>>> +1 for now.. >>>>>>>> >>>>>>>> Regards, >>>>>>>> Nikhils >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> On Wed, Apr 24, 2013 at 11:45 PM, Nikhil Sontakke < >>>>>>>>> ni...@st...> wrote: >>>>>>>>> >>>>>>>>>> Ok, >>>>>>>>>> This is not so straight forward. We cannot reset the sequence >>>>>>>>>> value in the GTM as is. We got to handle the case when the user can >>>>>>>>>> rollback the truncate operation in which case the old value should still >>>>>>>>>> hold. >>>>>>>>>> >>>>>>>>>> ISTM, we need to add handing code when the commit operation >>>>>>>>>> actually unlinks the corresponding underlying relfilenode for the earlier >>>>>>>>>> version of the sequence. >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Nikhils >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Wed, Apr 24, 2013 at 7:34 PM, Ashutosh Bapat < >>>>>>>>>> ash...@en...> wrote: >>>>>>>>>> >>>>>>>>>>> Good, that works. This bug is causing testcase truncate to fail. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Wed, Apr 24, 2013 at 6:53 PM, Nikhil Sontakke < >>>>>>>>>>> ni...@st...> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Ashutosh, >>>>>>>>>>>> >>>>>>>>>>>> By the EOW? >>>>>>>>>>>> >>>>>>>>>>>> Regards, >>>>>>>>>>>> Nikhils >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Wed, Apr 24, 2013 at 6:49 PM, Ashutosh Bapat < >>>>>>>>>>>> ash...@en...> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi Nikhil, >>>>>>>>>>>>> Thanks for taking this up? >>>>>>>>>>>>> >>>>>>>>>>>>> By when do you think you can provide the patch? >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Wed, Apr 24, 2013 at 6:01 PM, Nikhil Sontakke < >>>>>>>>>>>>> ni...@st...> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> ResetSequence(), the function being called from >>>>>>>>>>>>>>> ExecuteTruncate() does not send reset message to GTM. It applies sequence >>>>>>>>>>>>>>> changes locally on the coordinator, which is not enough. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Can someone with relevant experience look into this problem >>>>>>>>>>>>>>> and provide a fix? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I have attached the testcase and its output showing the bug. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> I guess setval() was handled but we forgot to handle reset >>>>>>>>>>>>>> sequence. I will take this up when I cleanup currval, nextval for negative >>>>>>>>>>>>>> sequences. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Regards, >>>>>>>>>>>>>> Nikhils >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> Best Wishes, >>>>>>>>>>>>> Ashutosh Bapat >>>>>>>>>>>>> EntepriseDB Corporation >>>>>>>>>>>>> The Postgres Database Company >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> StormDB - http://www.stormdb.com >>>>>>>>>>>> The Database Cloud >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Best Wishes, >>>>>>>>>>> Ashutosh Bapat >>>>>>>>>>> EntepriseDB Corporation >>>>>>>>>>> The Postgres Database Company >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> StormDB - http://www.stormdb.com >>>>>>>>>> The Database Cloud >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Best Wishes, >>>>>>>>> Ashutosh Bapat >>>>>>>>> EntepriseDB Corporation >>>>>>>>> The Postgres Database Company >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> StormDB - http://www.stormdb.com >>>>>>>> The Database Cloud >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Best Wishes, >>>>>>> Ashutosh Bapat >>>>>>> EntepriseDB Corporation >>>>>>> The Postgres Database Company >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> StormDB - http://www.stormdb.com >>>>>> The Database Cloud >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Best Wishes, >>>>> Ashutosh Bapat >>>>> EntepriseDB Corporation >>>>> The Postgres Database Company >>>>> >>>> >>>> >>>> >>>> -- >>>> StormDB - http://www.stormdb.com >>>> The Database Cloud >>>> >>> >>> >>> >>> -- >>> Best Wishes, >>> Ashutosh Bapat >>> EntepriseDB Corporation >>> The Postgres Database Company >>> >> >> >> >> -- >> StormDB - http://www.stormdb.com >> The Database Cloud >> > > > > -- > Best Wishes, > Ashutosh Bapat > EntepriseDB Corporation > The Postgres Database Company > -- StormDB - http://www.stormdb.com The Database Cloud |
|
From: Ashutosh B. <ash...@en...> - 2013-05-07 11:17:22
|
Hi Abbas, Since this diff is because we do not support a particular feature, I think, we need up update alternate expected output file (only) with the diff. There is no need to add any new SQL. If we do so, we will have problem in future, when we start supporting SAVEPOINT. On Wed, Apr 24, 2013 at 11:12 PM, Abbas Butt <abb...@en...>wrote: > Hi, > The test was failing because ctid was being selected and was not being > reset explicitly. > SAVEPOINT is not implemented yet and the transaction fails because of that > statement. > Due to the failure / rollback the ctid remains incremented and that > incremented value > is dependent on cluster configuration. > The solution is to explicitly reset ctid using truncate statement. > > -- > *Abbas* > Architect > > Ph: 92.334.5100153 > Skype ID: gabbasb > www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> > * > Follow us on Twitter* > @EnterpriseDB > > Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> > > > ------------------------------------------------------------------------------ > Try New Relic Now & We'll Send You this Cool Shirt > New Relic is the only SaaS-based application performance monitoring service > that delivers powerful full stack analytics. Optimize and monitor your > browser, app, & servers with just a few lines of code. Try New Relic > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr > _______________________________________________ > Postgres-xc-developers mailing list > Pos...@li... > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers > > -- Best Wishes, Ashutosh Bapat EntepriseDB Corporation The Postgres Database Company |
|
From: Ashutosh B. <ash...@en...> - 2013-05-07 10:43:21
|
Ok, this is good to go then. On Tue, Apr 30, 2013 at 6:00 PM, Abbas Butt <abb...@en...>wrote: > > > On Tue, Apr 30, 2013 at 5:04 PM, Ashutosh Bapat < > ash...@en...> wrote: > >> Hi Abbas, >> This change looks confusing. The statements where you have added order by >> clause do not correspond to the statements where you have changed the >> output. Can you please explain this? >> > > The output of the test cases are changed because there was an error in the > expected output files of these test cases. These outputs have to be > modified (and the modified output is correct) because of your check in > 2608af3d5288607e8245fa10e74e7307bb1bb23d. > > The order by clause is added in test cases where the expected output was > already in order, but results were coming out to be in different order > depending on node configuration. > > >> >> Also, whenever you change .sql and need to change the .out for that, >> please change all the alt. expected output files. >> > > Sure > > >> >> >> On Thu, Apr 25, 2013 at 4:58 PM, Abbas Butt <abb...@en...>wrote: >> >>> Hi, >>> Attached please find patch to fix test case plpgsql. The test was >>> failing for some order by issues, Also there were some errors in expected >>> output. >>> >>> -- >>> *Abbas* >>> Architect >>> >>> Ph: 92.334.5100153 >>> Skype ID: gabbasb >>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> >>> * >>> Follow us on Twitter* >>> @EnterpriseDB >>> >>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> >>> >>> >>> ------------------------------------------------------------------------------ >>> Try New Relic Now & We'll Send You this Cool Shirt >>> New Relic is the only SaaS-based application performance monitoring >>> service >>> that delivers powerful full stack analytics. Optimize and monitor your >>> browser, app, & servers with just a few lines of code. Try New Relic >>> and get this awesome Nerd Life shirt! >>> http://p.sf.net/sfu/newrelic_d2d_apr >>> _______________________________________________ >>> Postgres-xc-developers mailing list >>> Pos...@li... >>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers >>> >>> >> >> >> -- >> Best Wishes, >> Ashutosh Bapat >> EntepriseDB Corporation >> The Postgres Database Company >> > > > > -- > -- > *Abbas* > Architect > > Ph: 92.334.5100153 > Skype ID: gabbasb > www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> > * > Follow us on Twitter* > @EnterpriseDB > > Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> > -- Best Wishes, Ashutosh Bapat EntepriseDB Corporation The Postgres Database Company |
|
From: Ashutosh B. <ash...@en...> - 2013-05-07 09:57:48
|
Hi Abbas,
The right fix is at line 402. Because of the condition there, we do not
call GetPreferredReplicationNode() if there is FOR SHARE/FOR UPDATE clause
there. I think we need to modify the condition.
392 if (exec_nodes && exec_nodes->nodeList)
393 {
394 /*
395 * If this is the highest level query in the query tree and
396 * relations involved in the query are such that ultimate JOIN
is
397 * replicated JOIN, choose only one of them.
398 * If we do this for lower level queries in query tree, we
might loose
399 * chance because common nodes are left out.
400 */
401 if (IsExecNodesReplicated(exec_nodes) &&
402 exec_nodes->accesstype == RELATION_ACCESS_READ &&
403 sc_context->sc_query_level == 0)
404
405 {
406 List *tmp_list = exec_nodes->nodeList;
407 exec_nodes->nodeList =
GetPreferredReplicationNode(exec_nodes->nodeList);
408 list_free(tmp_list);
409 }
410 return exec_nodes;
411 }
Regarding other places where you have used the wrapper around
GetPreferredReplicationNode(); we don't need those code changes. We set
en_expr only for distributed relations and en_relid is set and used
properly only for DMLs when this problem would not happen. May be we should
add assertions at these places to make sure that we don't come there for
replicated tables and FOR SHARE/UDPATE SELECTs.
On Tue, May 7, 2013 at 10:21 AM, Abbas Butt <abb...@en...>wrote:
> I changed to code by creating another function and calling it right after
> GetRelationNodes where needed. Updated patch attached.
>
>
> On Tue, Apr 30, 2013 at 3:41 PM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Hi Abbas,
>> Instead of fixing this in GetRelationNodes, we should fix it outside, by
>> calling GetPrefferedNode on the result returned by GetRelationNodes for
>> replicated tables. Please send a revised patch with this change. May be you
>> want to examine all callers of GetRelationNodes.
>>
>>
>> On Wed, Apr 24, 2013 at 10:58 PM, Abbas Butt <abb...@en...
>> > wrote:
>>
>>> Hi,
>>> The test case fails if there is no primary node in the cluster. The
>>> following test case was producing error.
>>>
>>> CREATE TABLE tt_22 (a int, b int) distribute by replication;
>>> INSERT INTO tt_22 VALUES (10);
>>>
>>> In a four datanode cluster the following query plan was being produced.
>>>
>>> explain verbose SELECT * FROM tt_22 FOR UPDATE;
>>> QUERY
>>> PLAN
>>>
>>> ----------------------------------------------------------------------------
>>> Data Node Scan on "__REMOTE_FQS_QUERY__" (cost=0.00..0.00 rows=0
>>> width=0)
>>> Output: tt_22.a, tt_22.b
>>> Node/s: data_node_1, data_node_2, data_node_3, data_node_4
>>> Remote query: SELECT a, b FROM tt_22 FOR UPDATE OF tt_22
>>> (4 rows)
>>>
>>> The reason was a missing else case in GetRelationNodes.
>>>
>>>
>>> --
>>> *Abbas*
>>> Architect
>>>
>>> Ph: 92.334.5100153
>>> Skype ID: gabbasb
>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>> *
>>> Follow us on Twitter*
>>> @EnterpriseDB
>>>
>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Try New Relic Now & We'll Send You this Cool Shirt
>>> New Relic is the only SaaS-based application performance monitoring
>>> service
>>> that delivers powerful full stack analytics. Optimize and monitor your
>>> browser, app, & servers with just a few lines of code. Try New Relic
>>> and get this awesome Nerd Life shirt!
>>> http://p.sf.net/sfu/newrelic_d2d_apr
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Postgres Database Company
>>
>
>
>
> --
> --
> *Abbas*
> Architect
>
> Ph: 92.334.5100153
> Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>
--
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company
|
|
From: Abbas B. <abb...@en...> - 2013-05-07 06:38:38
|
ok, sure. On Tue, May 7, 2013 at 11:37 AM, Ashutosh Bapat < ash...@en...> wrote: > BTW, fix the bug in separate patch and fix expected outputs in separate > patch. > > > On Tue, May 7, 2013 at 11:54 AM, Ashutosh Bapat < > ash...@en...> wrote: > >> Can you please fix the bug then? >> >> >> On Tue, May 7, 2013 at 10:25 AM, Abbas Butt <abb...@en...>wrote: >> >>> >>> >>> On Tue, Apr 30, 2013 at 4:57 PM, Ashutosh Bapat < >>> ash...@en...> wrote: >>> >>>> Hi Abbas, >>>> I see that the EXPLAIN commands are changed to include the XC specific >>>> options. Since the original test is using capital letters everywhere, it's >>>> better to maintain that style. >>>> >>> >>> Done. >>> >>> >>>> >>>> Please make sure that the changes you have done (explain output) >>>> reflect in all the alt. expected output files. >>>> >>> >>> Done. >>> >>> >>>> Can you please see if we can eliminate the alternate expected output >>>> files as well? What are the reasons we have to maintain those? >>>> >>> >>> select_views.out and select_view_1.out are maintained by vanilla PG. We >>> have added select_views_2.out and It can be removed, however I noticed that >>> the test case that was added (Leaky View Scenario) is failing and needs a >>> fix. >>> >>> >>>> >>>> >>>> On Wed, Apr 24, 2013 at 10:59 PM, Abbas Butt < >>>> abb...@en...> wrote: >>>> >>>>> Hi, >>>>> The test was failing because some more tests are added in sql file. >>>>> >>>>> -- >>>>> *Abbas* >>>>> Architect >>>>> >>>>> Ph: 92.334.5100153 >>>>> Skype ID: gabbasb >>>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> >>>>> * >>>>> Follow us on Twitter* >>>>> @EnterpriseDB >>>>> >>>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> >>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Try New Relic Now & We'll Send You this Cool Shirt >>>>> New Relic is the only SaaS-based application performance monitoring >>>>> service >>>>> that delivers powerful full stack analytics. Optimize and monitor your >>>>> browser, app, & servers with just a few lines of code. Try New Relic >>>>> and get this awesome Nerd Life shirt! >>>>> http://p.sf.net/sfu/newrelic_d2d_apr >>>>> _______________________________________________ >>>>> Postgres-xc-developers mailing list >>>>> Pos...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers >>>>> >>>>> >>>> >>>> >>>> -- >>>> Best Wishes, >>>> Ashutosh Bapat >>>> EntepriseDB Corporation >>>> The Postgres Database Company >>>> >>> >>> >>> >>> -- >>> -- >>> *Abbas* >>> Architect >>> >>> Ph: 92.334.5100153 >>> Skype ID: gabbasb >>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> >>> * >>> Follow us on Twitter* >>> @EnterpriseDB >>> >>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> >>> >> >> >> >> -- >> Best Wishes, >> Ashutosh Bapat >> EntepriseDB Corporation >> The Postgres Database Company >> > > > > -- > Best Wishes, > Ashutosh Bapat > EntepriseDB Corporation > The Postgres Database Company > -- -- *Abbas* Architect Ph: 92.334.5100153 Skype ID: gabbasb www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> * Follow us on Twitter* @EnterpriseDB Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> |
|
From: Ashutosh B. <ash...@en...> - 2013-05-07 06:38:01
|
BTW, fix the bug in separate patch and fix expected outputs in separate patch. On Tue, May 7, 2013 at 11:54 AM, Ashutosh Bapat < ash...@en...> wrote: > Can you please fix the bug then? > > > On Tue, May 7, 2013 at 10:25 AM, Abbas Butt <abb...@en...>wrote: > >> >> >> On Tue, Apr 30, 2013 at 4:57 PM, Ashutosh Bapat < >> ash...@en...> wrote: >> >>> Hi Abbas, >>> I see that the EXPLAIN commands are changed to include the XC specific >>> options. Since the original test is using capital letters everywhere, it's >>> better to maintain that style. >>> >> >> Done. >> >> >>> >>> Please make sure that the changes you have done (explain output) reflect >>> in all the alt. expected output files. >>> >> >> Done. >> >> >>> Can you please see if we can eliminate the alternate expected output >>> files as well? What are the reasons we have to maintain those? >>> >> >> select_views.out and select_view_1.out are maintained by vanilla PG. We >> have added select_views_2.out and It can be removed, however I noticed that >> the test case that was added (Leaky View Scenario) is failing and needs a >> fix. >> >> >>> >>> >>> On Wed, Apr 24, 2013 at 10:59 PM, Abbas Butt < >>> abb...@en...> wrote: >>> >>>> Hi, >>>> The test was failing because some more tests are added in sql file. >>>> >>>> -- >>>> *Abbas* >>>> Architect >>>> >>>> Ph: 92.334.5100153 >>>> Skype ID: gabbasb >>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> >>>> * >>>> Follow us on Twitter* >>>> @EnterpriseDB >>>> >>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Try New Relic Now & We'll Send You this Cool Shirt >>>> New Relic is the only SaaS-based application performance monitoring >>>> service >>>> that delivers powerful full stack analytics. Optimize and monitor your >>>> browser, app, & servers with just a few lines of code. Try New Relic >>>> and get this awesome Nerd Life shirt! >>>> http://p.sf.net/sfu/newrelic_d2d_apr >>>> _______________________________________________ >>>> Postgres-xc-developers mailing list >>>> Pos...@li... >>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers >>>> >>>> >>> >>> >>> -- >>> Best Wishes, >>> Ashutosh Bapat >>> EntepriseDB Corporation >>> The Postgres Database Company >>> >> >> >> >> -- >> -- >> *Abbas* >> Architect >> >> Ph: 92.334.5100153 >> Skype ID: gabbasb >> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> >> * >> Follow us on Twitter* >> @EnterpriseDB >> >> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> >> > > > > -- > Best Wishes, > Ashutosh Bapat > EntepriseDB Corporation > The Postgres Database Company > -- Best Wishes, Ashutosh Bapat EntepriseDB Corporation The Postgres Database Company |
|
From: Ashutosh B. <ash...@en...> - 2013-05-07 06:24:23
|
Can you please fix the bug then? On Tue, May 7, 2013 at 10:25 AM, Abbas Butt <abb...@en...>wrote: > > > On Tue, Apr 30, 2013 at 4:57 PM, Ashutosh Bapat < > ash...@en...> wrote: > >> Hi Abbas, >> I see that the EXPLAIN commands are changed to include the XC specific >> options. Since the original test is using capital letters everywhere, it's >> better to maintain that style. >> > > Done. > > >> >> Please make sure that the changes you have done (explain output) reflect >> in all the alt. expected output files. >> > > Done. > > >> Can you please see if we can eliminate the alternate expected output >> files as well? What are the reasons we have to maintain those? >> > > select_views.out and select_view_1.out are maintained by vanilla PG. We > have added select_views_2.out and It can be removed, however I noticed that > the test case that was added (Leaky View Scenario) is failing and needs a > fix. > > >> >> >> On Wed, Apr 24, 2013 at 10:59 PM, Abbas Butt <abb...@en... >> > wrote: >> >>> Hi, >>> The test was failing because some more tests are added in sql file. >>> >>> -- >>> *Abbas* >>> Architect >>> >>> Ph: 92.334.5100153 >>> Skype ID: gabbasb >>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> >>> * >>> Follow us on Twitter* >>> @EnterpriseDB >>> >>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> >>> >>> >>> ------------------------------------------------------------------------------ >>> Try New Relic Now & We'll Send You this Cool Shirt >>> New Relic is the only SaaS-based application performance monitoring >>> service >>> that delivers powerful full stack analytics. Optimize and monitor your >>> browser, app, & servers with just a few lines of code. Try New Relic >>> and get this awesome Nerd Life shirt! >>> http://p.sf.net/sfu/newrelic_d2d_apr >>> _______________________________________________ >>> Postgres-xc-developers mailing list >>> Pos...@li... >>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers >>> >>> >> >> >> -- >> Best Wishes, >> Ashutosh Bapat >> EntepriseDB Corporation >> The Postgres Database Company >> > > > > -- > -- > *Abbas* > Architect > > Ph: 92.334.5100153 > Skype ID: gabbasb > www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> > * > Follow us on Twitter* > @EnterpriseDB > > Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> > -- Best Wishes, Ashutosh Bapat EntepriseDB Corporation The Postgres Database Company |
|
From: Abbas B. <abb...@en...> - 2013-05-07 06:07:34
|
I am ok with the changes in the test. It worked fine for me. On Mon, Apr 22, 2013 at 3:10 PM, Ashutosh Bapat < ash...@en...> wrote: > Hi All, > The testcase was failing because of change in the query plans (because of > LIMIT optimization) and queries returning unpredictable results (because of > lack of order by clause). I have corrected the plans and added order by > clause to the queries. > > There is only one query (multiple instances) which needed order by clause. > It's > select * from patest0 join (select f1 from int4_tbl limit 1) ss on id = f1 > Since the first row inserted in int4_tbl has f1 = 0, the subquery "select > f1 from int4_tbl limit 1" returns 0 in PG, whereas that may not be true in > XC, hence we need to add order by and where clause to make sure that the > subquery returns 0. > > I found that inherit.out and inherit_1.out had more than differences > necessary (only differences expected were those because of tableoid). I > have removed those differences. > -- > Best Wishes, > Ashutosh Bapat > EntepriseDB Corporation > The Postgres Database Company > > > ------------------------------------------------------------------------------ > Precog is a next-generation analytics platform capable of advanced > analytics on semi-structured data. The platform includes APIs for building > apps and a phenomenal toolset for data science. Developers can use > our toolset for easy data analysis & visualization. Get a free account! > http://www2.precog.com/precogplatform/slashdotnewsletter > _______________________________________________ > Postgres-xc-developers mailing list > Pos...@li... > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers > > -- -- *Abbas* Architect Ph: 92.334.5100153 Skype ID: gabbasb www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> * Follow us on Twitter* @EnterpriseDB Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> |
|
From: Abbas B. <abb...@en...> - 2013-05-07 06:04:45
|
I am ok with the changes in the test case. It worked fine for me. On Thu, Apr 25, 2013 at 4:23 PM, Ashutosh Bapat < ash...@en...> wrote: > Hi All, > PFA the patch which fixes the regressions truncate.sql. > > Because of one foreign key constraint, one table needed to be replicated > instead of distributed. There were some diffs because statement triggers > are now enabled. This diff should have been resolved when statement trigger > work was completed. > > -- > Best Wishes, > Ashutosh Bapat > EntepriseDB Corporation > The Postgres Database Company > > > ------------------------------------------------------------------------------ > Try New Relic Now & We'll Send You this Cool Shirt > New Relic is the only SaaS-based application performance monitoring service > that delivers powerful full stack analytics. Optimize and monitor your > browser, app, & servers with just a few lines of code. Try New Relic > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr > _______________________________________________ > Postgres-xc-developers mailing list > Pos...@li... > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers > > -- -- *Abbas* Architect Ph: 92.334.5100153 Skype ID: gabbasb www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> * Follow us on Twitter* @EnterpriseDB Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> |
|
From: Abbas B. <abb...@en...> - 2013-05-07 04:55:40
|
On Tue, Apr 30, 2013 at 4:57 PM, Ashutosh Bapat < ash...@en...> wrote: > Hi Abbas, > I see that the EXPLAIN commands are changed to include the XC specific > options. Since the original test is using capital letters everywhere, it's > better to maintain that style. > Done. > > Please make sure that the changes you have done (explain output) reflect > in all the alt. expected output files. > Done. > Can you please see if we can eliminate the alternate expected output files > as well? What are the reasons we have to maintain those? > select_views.out and select_view_1.out are maintained by vanilla PG. We have added select_views_2.out and It can be removed, however I noticed that the test case that was added (Leaky View Scenario) is failing and needs a fix. > > > On Wed, Apr 24, 2013 at 10:59 PM, Abbas Butt <abb...@en...>wrote: > >> Hi, >> The test was failing because some more tests are added in sql file. >> >> -- >> *Abbas* >> Architect >> >> Ph: 92.334.5100153 >> Skype ID: gabbasb >> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> >> * >> Follow us on Twitter* >> @EnterpriseDB >> >> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> >> >> >> ------------------------------------------------------------------------------ >> Try New Relic Now & We'll Send You this Cool Shirt >> New Relic is the only SaaS-based application performance monitoring >> service >> that delivers powerful full stack analytics. Optimize and monitor your >> browser, app, & servers with just a few lines of code. Try New Relic >> and get this awesome Nerd Life shirt! >> http://p.sf.net/sfu/newrelic_d2d_apr >> _______________________________________________ >> Postgres-xc-developers mailing list >> Pos...@li... >> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers >> >> > > > -- > Best Wishes, > Ashutosh Bapat > EntepriseDB Corporation > The Postgres Database Company > -- -- *Abbas* Architect Ph: 92.334.5100153 Skype ID: gabbasb www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> * Follow us on Twitter* @EnterpriseDB Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> |
|
From: Abbas B. <abb...@en...> - 2013-05-07 04:51:13
|
I changed to code by creating another function and calling it right after GetRelationNodes where needed. Updated patch attached. On Tue, Apr 30, 2013 at 3:41 PM, Ashutosh Bapat < ash...@en...> wrote: > Hi Abbas, > Instead of fixing this in GetRelationNodes, we should fix it outside, by > calling GetPrefferedNode on the result returned by GetRelationNodes for > replicated tables. Please send a revised patch with this change. May be you > want to examine all callers of GetRelationNodes. > > > On Wed, Apr 24, 2013 at 10:58 PM, Abbas Butt <abb...@en...>wrote: > >> Hi, >> The test case fails if there is no primary node in the cluster. The >> following test case was producing error. >> >> CREATE TABLE tt_22 (a int, b int) distribute by replication; >> INSERT INTO tt_22 VALUES (10); >> >> In a four datanode cluster the following query plan was being produced. >> >> explain verbose SELECT * FROM tt_22 FOR UPDATE; >> QUERY >> PLAN >> >> ---------------------------------------------------------------------------- >> Data Node Scan on "__REMOTE_FQS_QUERY__" (cost=0.00..0.00 rows=0 >> width=0) >> Output: tt_22.a, tt_22.b >> Node/s: data_node_1, data_node_2, data_node_3, data_node_4 >> Remote query: SELECT a, b FROM tt_22 FOR UPDATE OF tt_22 >> (4 rows) >> >> The reason was a missing else case in GetRelationNodes. >> >> >> -- >> *Abbas* >> Architect >> >> Ph: 92.334.5100153 >> Skype ID: gabbasb >> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> >> * >> Follow us on Twitter* >> @EnterpriseDB >> >> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> >> >> >> ------------------------------------------------------------------------------ >> Try New Relic Now & We'll Send You this Cool Shirt >> New Relic is the only SaaS-based application performance monitoring >> service >> that delivers powerful full stack analytics. Optimize and monitor your >> browser, app, & servers with just a few lines of code. Try New Relic >> and get this awesome Nerd Life shirt! >> http://p.sf.net/sfu/newrelic_d2d_apr >> _______________________________________________ >> Postgres-xc-developers mailing list >> Pos...@li... >> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers >> >> > > > -- > Best Wishes, > Ashutosh Bapat > EntepriseDB Corporation > The Postgres Database Company > -- -- *Abbas* Architect Ph: 92.334.5100153 Skype ID: gabbasb www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> * Follow us on Twitter* @EnterpriseDB Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> |
|
From: Abbas B. <abb...@en...> - 2013-05-07 00:18:45
|
On Tue, Apr 30, 2013 at 4:19 PM, Ashutosh Bapat < ash...@en...> wrote: > Hi Abbas, > copy2 has an alternate output file. So, if you change .sql file, you need > to make corresponding changes in .out and _1.out. There is one missing > change about not enforcing 2PC with temporary tables, which needs to be > carried to .out file as well. > Done. > > Otherwise the change looks good. While adding the ORDER BY clause, hope > you have made sure that the data that is output is same except for change > in the ordering. > True. > > This testcase needs to be looked at by Amit for the trigger related > changes. After that I think we should remove alt. output file. > The data in copy2.out and copy2_1.out is different because FOR EACH ROW triggers are not fired on coordinators. There is one other difference and that is --- > "Jackson, Sam",\h > "It is ""perfect"".", 214,215c214,215 < "Jackson, Sam","\h" < "It is ""perfect""."," " Note quotes around \h in one case and no quotes in the other. So we need to decide how to take care of these two changes in the data before we remove the alternate expected output file. > > > On Wed, Apr 24, 2013 at 10:58 PM, Abbas Butt <abb...@en...>wrote: > >> Hi, >> Test was failing because of some order by issues in COPY TO statements. >> >> -- >> *Abbas* >> Architect >> >> Ph: 92.334.5100153 >> Skype ID: gabbasb >> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> >> * >> Follow us on Twitter* >> @EnterpriseDB >> >> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> >> >> >> ------------------------------------------------------------------------------ >> Try New Relic Now & We'll Send You this Cool Shirt >> New Relic is the only SaaS-based application performance monitoring >> service >> that delivers powerful full stack analytics. Optimize and monitor your >> browser, app, & servers with just a few lines of code. Try New Relic >> and get this awesome Nerd Life shirt! >> http://p.sf.net/sfu/newrelic_d2d_apr >> _______________________________________________ >> Postgres-xc-developers mailing list >> Pos...@li... >> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers >> >> > > > -- > Best Wishes, > Ashutosh Bapat > EntepriseDB Corporation > The Postgres Database Company > -- -- *Abbas* Architect Ph: 92.334.5100153 Skype ID: gabbasb www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> * Follow us on Twitter* @EnterpriseDB Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> |
1 message has been excluded from this view by a project administrator.
