postgres-xc-developers Mailing List for Postgres-XC

On Wed, Nov 9, 2011 at 5:46 PM, Ashutosh Bapat <
ash...@en...> wrote:

> I have few comments about style (Somebody still needs it to be looked from
> CREATE TABLE angle)
>
Regarding create table, it uses the structure introduced in create ddl
commit, so I'm not sure there is something that needs to be added.

>
> Instead of using "!= LOCATOR_TYPE_REPLICATED", we should rather check
> whether it's one of MODULO, HASH, CUSTOM etc. and throw error for unhandled
> cases. That will protect us from any crashes caused by adding new
> LOCATOR_TYPE, which is not REPLICATED or distributed.
>
OK, I will change the code in consequence it is not a big matter, but it
will make the if checks a bit heavier.


>
> +        /* Look at the subqueries */
> +        if (rte->rtekind == RTE_SUBQUERY &&
> +            !is_subcluster_mapping(rte->subquery->rtable))
> +            return false;
> This piece of code looks tricky. Where is the nodelist and locator_type
> for a subquery stored? The global_locator_type and inter_nodelist are
> variables local to function and will not be updated across the recursive
> calls to the function.

To be honest, I had a look at this part of the code and saw that
get_plan_nodes_walker was also used for subqueries themselves. So it is not
necessary and the subquery node list is evaluated automatically with its
own rtable separately.
-- 
Michael Paquier
http://michael.otacoo.com

I have few comments about style (Somebody still needs it to be looked from
CREATE TABLE angle)

Instead of using "!= LOCATOR_TYPE_REPLICATED", we should rather check
whether it's one of MODULO, HASH, CUSTOM etc. and throw error for unhandled
cases. That will protect us from any crashes caused by adding new
LOCATOR_TYPE, which is not REPLICATED or distributed.

+        /* Look at the subqueries */
+        if (rte->rtekind == RTE_SUBQUERY &&
+            !is_subcluster_mapping(rte->subquery->rtable))
+            return false;
This piece of code looks tricky. Where is the nodelist and locator_type for
a subquery stored? The global_locator_type and inter_nodelist are variables
local to function and will not be updated across the recursive calls to the
function.

On Wed, Nov 9, 2011 at 12:01 PM, Michael Paquier
<mic...@gm...>wrote:

> Please find attached the updated patch based on your comments.
> This time also is a simple O(n) and passes all the tests.
>
> --
> Michael Paquier
> http://michael.otacoo.com
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

Please find attached the updated patch based on your comments.
This time also is a simple O(n) and passes all the tests.
-- 
Michael Paquier
http://michael.otacoo.com