Fix warnings raised by clang 11 #8664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ef3e79 to
a6d4ed6
Compare
acozzette
reviewed
May 27, 2021
a6d4ed6 to
570fa1b
Compare
acozzette
suggested changes
Jun 1, 2021
acozzette
left a comment
There was a problem hiding this comment.
Thanks for the cleanup! Looks good to me except for a few more small comments I made.
acozzette
suggested changes
Jun 2, 2021
acozzette
left a comment
There was a problem hiding this comment.
Sorry but I added just two more things I might missed before, otherwise looks great.
This fixes a few kinds of warnings: - inconsistent-missing-override when the overriding site is missing the override keyword - unused-function when a function is neither visible nor used - unused-private-field when a private field exists but is never used - sign-compare when unsigned ints are compared to signed ints. Not all of those have been addressed, but this warning isn't enabled by default. This fixes protocolbuffers#8612.
467dd6d to
3ddcaca
Compare
Contributor
Author
|
I just addressed the last comments and rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few kinds of warnings:
override keyword
of those have been addressed, but this warning isn't enabled by
default.
This fixes #8580, fixes #8612.