Fix default value of enum(int) in json_util with proto2 #8835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
update: fix typo(shoule => should) |
Contributor
Author
|
Hi @acozzette , seems there still 2 pending checks for hours, and I can't get infomation about it, need some help, thx . |
|
I have the same problem, so I also need help,thx
Sent with [ProtonMail](https://protonmail.com/) Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
…On Saturday, July 31st, 2021 at PM 3:33, SpringHack ***@***.***> wrote:
Hi ***@***.***(https://github.com/acozzette) , seems there still 2 pending checks for hours, and I can't get infomation about it, need some help, thx .
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, [view it on GitHub](#8835 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AVBDXYFCNGRCCRA56NHQXSTT2ORM7ANCNFSM5A72MTEQ).
|
Contributor
Author
|
update: rebase master |
acozzette
suggested changes
Aug 3, 2021
acozzette
left a comment
There was a problem hiding this comment.
Thanks for the fix! Looks good but I made just a few small comments.
src/google/protobuf/util/internal/default_value_objectwriter.cc
Outdated
Show resolved
Hide resolved
acozzette
approved these changes
Aug 3, 2021
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while using proto2 with optional and default keyword, it always return string, so fix it