Changeset 204727 in webkit

Timestamp:

Aug 22, 2016, 10:26:22 AM (10 years ago)

Author:

clopez@igalia.com

Message:

[EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
​https://bugs.webkit.org/show_bug.cgi?id=160927

Reviewed by Daniel Bates.

• Scripts/process-linux-coredump: Removed.
• Scripts/webkitpy/port/efl.py:

(EflPort._get_crash_log):

• Scripts/webkitpy/port/gtk.py:

(GtkPort._get_crash_log):

• Scripts/webkitpy/port/linux_get_crash_log.py:

(GDBCrashLogGenerator.init):
(GDBCrashLogGenerator.generate_crash_log):

• Scripts/webkitpy/port/linux_get_crash_log_unittest.py:

(GDBCrashLogGeneratorTest.test_generate_crash_log):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/process-linux-coredump (deleted)
• Scripts/webkitpy/port/efl.py (modified) (1 diff)
• Scripts/webkitpy/port/gtk.py (modified) (1 diff)
• Scripts/webkitpy/port/linux_get_crash_log.py (modified) (2 diffs)
• Scripts/webkitpy/port/linux_get_crash_log_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
+        https://bugs.webkit.org/show_bug.cgi?id=160927
+
+        Reviewed by Daniel Bates.
+
+        * Scripts/process-linux-coredump: Removed.
+        * Scripts/webkitpy/port/efl.py:
+        (EflPort._get_crash_log):
+        * Scripts/webkitpy/port/gtk.py:
+        (GtkPort._get_crash_log):
+        * Scripts/webkitpy/port/linux_get_crash_log.py:
+        (GDBCrashLogGenerator.__init__):
+        (GDBCrashLogGenerator.generate_crash_log):
+        * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
+        (GDBCrashLogGeneratorTest.test_generate_crash_log):
+
 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/efl.py

@@ -143 +143 @@
 
     def _get_crash_log(self, name, pid, stdout, stderr, newer_than):
-        return GDBCrashLogGenerator(name, pid, newer_than, self._filesystem, self.path_to_script("process-linux-coredump"), self._path_to_driver).generate_crash_log(stdout, stderr)
+        return GDBCrashLogGenerator(name, pid, newer_than, self._filesystem, self._path_to_driver).generate_crash_log(stdout, stderr)
 
     def test_expectations_file_position(self):

trunk/Tools/Scripts/webkitpy/port/gtk.py

@@ -217 +217 @@
     def _get_crash_log(self, name, pid, stdout, stderr, newer_than):
         name = "WebKitWebProcess" if name == "WebProcess" else name
-        return GDBCrashLogGenerator(name, pid, newer_than, self._filesystem, self.path_to_script("process-linux-coredump"), self._path_to_driver).generate_crash_log(stdout, stderr)
+        return GDBCrashLogGenerator(name, pid, newer_than, self._filesystem, self._path_to_driver).generate_crash_log(stdout, stderr)
 
     def test_expectations_file_position(self):

trunk/Tools/Scripts/webkitpy/port/linux_get_crash_log.py

@@ -32 +32 @@
 
 class GDBCrashLogGenerator(object):
-    def __init__(self, name, pid, newer_than, filesystem, process_coredump_script_path, path_to_driver):
+    def __init__(self, name, pid, newer_than, filesystem, path_to_driver):
         self.name = name
         self.pid = pid
         self.newer_than = newer_than
         self._filesystem = filesystem
-        self._process_coredump_script_path = process_coredump_script_path
         self._path_to_driver = path_to_driver
 
     def _get_gdb_output(self, coredump_path):
-        process_name = os.path.join(os.path.dirname(str(self._path_to_driver())), self.name)
+        process_name = self._filesystem.join(os.path.dirname(str(self._path_to_driver())), self.name)
         cmd = ['gdb', '-ex', 'thread apply all bt 1024', '--batch', process_name, coredump_path]
         proc = subprocess.Popen(cmd, stdin=None, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
@@ -79 +78 @@
             if not log_directory:
                 log_directory = "/path/to/coredumps"
-            process_coredump_script_path = self._process_coredump_script_path
+            core_pattern = self._filesystem.join(log_directory, "core-pid_%p.dump")
             crash_log = """\
 Coredump %(expected_crash_dump_filename)s not found. To enable crash logs:
 
-- run this command as super-user: echo "|%(process_coredump_script_path)s %(log_directory)s/core-pid_%%p.dump" > /proc/sys/kernel/core_pattern
+- run this command as super-user: echo "%(core_pattern)s" > /proc/sys/kernel/core_pattern
 - enable core dumps: ulimit -c unlimited
 - set the WEBKIT_CORE_DUMPS_DIRECTORY environment variable: export WEBKIT_CORE_DUMPS_DIRECTORY=%(log_directory)s

trunk/Tools/Scripts/webkitpy/port/linux_get_crash_log_unittest.py

@@ -42 +42 @@
             return
 
-        process_coredump_script_path = "/path/to/coredump-processor"
-        generator = GDBCrashLogGenerator('DumpRenderTree', 28529, newer_than=None, filesystem=MockFileSystem({'/path/to/coredumps': ''}), process_coredump_script_path=process_coredump_script_path, path_to_driver=None)
+        generator = GDBCrashLogGenerator('DumpRenderTree', 28529, newer_than=None, filesystem=MockFileSystem({'/path/to/coredumps': ''}), path_to_driver=None)
 
         core_directory = os.environ.get('WEBKIT_CORE_DUMPS_DIRECTORY', '/path/to/coredumps')
-        core_pattern = "|%s %s/core-pid_%%p.dump" % (process_coredump_script_path, core_directory)
+        core_pattern = generator._filesystem.join(core_directory, "core-pid_%p.dump")
         mock_empty_crash_log = """\
 crash log for DumpRenderTree (pid 28529):