Problem/Motivation

* @deprecated as of 2.8, will be removed in 3.0. Use the \Symfony\Component\CssSelector\CssSelectorConverter class instead.

Proposed resolution

Either use CssSelectorConverter or \Behat\Mink\Selector\CssSelector which is backward compatible.

Remaining tasks

Commit the patch.

User interface changes

None

API changes

\Symfony\Component\CssSelector\CssSelectorConverter is removed.

Data model changes

None

CommentFileSizeAuthor
#9 remove_the_use_of-2720869-9.patch6.19 KBjibran
#9 interdiff.txt3.16 KBjibran
#5 remove_use_of-2720869-5.patch6.15 KBjibran
#5 interdiff.txt759 bytesjibran
#2 remove_use_of-2720869-2.patch6.15 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Title: Remove use of deprecated \Symfony\Component\CssSelector\CssSelectorConverter and use \Behat\Mink\Selector\CssSelector » Remove the use of deprecated CssSelectorConverter and use CssSelectorConverter instead.
Status: Active » Needs review
StatusFileSize
new remove_use_of-2720869-2.patch6.15 KB

Let's go with CssSelectorConverter for now.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Title: Remove the use of deprecated CssSelectorConverter and use CssSelectorConverter instead. » Remove the use of deprecated CssSelector and use CssSelectorConverter instead.

:/

dawehner’s picture

dawehner
Primary language German
commented

Just a quick nitpick

+++ b/core/tests/Drupal/Tests/BrowserTestBase.php
@@ -1523,4 +1523,23 @@ protected function getHtmlOutputHeaders() {
+   *   Whether HTML support should be enabled. Disable it for XML documents.
...
+   *   An optional prefix for the XPath expression.

Let's add (optional) on the documentation.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +Needs change record
StatusFileSize
new interdiff.txt759 bytes
new remove_use_of-2720869-5.patch6.15 KB

There you go. We need a change notice for this as well so contrib can adapt.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Fair

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Title: Remove the use of deprecated CssSelector and use CssSelectorConverter instead. » Remove the use of deprecated CssSelector and use CssSelectorConverter instead
Issue summary: View changes

Added https://www.drupal.org/node/2720913

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/tests/Drupal/Tests/BrowserTestBase.php
@@ -1523,4 +1523,23 @@ protected function getHtmlOutputHeaders() {
+  protected function cssSelect($selector, $html = TRUE, $prefix = 'descendant-or-self::') {

This doesn't do a cssSelect - it converts a css selector to an xpath. So I guess a method name like cssSelectToXpath() is better.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
Issue tags: -Needs change record
StatusFileSize
new interdiff.txt3.16 KB
new remove_the_use_of-2720869-9.patch6.19 KB

Done.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

looks good!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 852f0bd and pushed to 8.1.x and 8.2.x. Thanks!

I've committed this to 8.1.x as well since there is no BC breaking change and JTB and BTB are both experimental so keeping the code aligned makes everyone's life easier.

  • alexpott committed 2bef956 on 8.2.x 
    Issue #2720869 by jibran: Remove the use of deprecated CssSelector and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.