Update DrupalorgVersioncontrolLabelVersionMapperGit for semantic versioning in Drupal 8
>>> [!note] Migrated issue
<!-- Drupal.org comment -->
<!-- Migrated from issue #2173779. -->
Reported by: [drumm](https://www.drupal.org/user/3064)
>>>
<p>This logic will need to be changed:</p>
<div class="codeblock">
<pre><span style="color: #000000"><span style="color: #0000BB"><?php<br> </span><span style="color: #FF8000">// Core versions are totally different from contrib.<br> </span><span style="color: #007700">if (</span><span style="color: #0000BB">$project_node</span><span style="color: #007700">-></span><span style="color: #0000BB">nid </span><span style="color: #007700">== </span><span style="color: #0000BB">DRUPALORG_CORE_NID</span><span style="color: #007700">) {<br> </span><span style="color: #FF8000">// Core official versions can be any of the following:<br> // 4.7.0-beta3<br> // 4.7.0<br> // 6.18<br> // 7.0-unstable3<br> // 7.0<br> </span><span style="color: #007700">if (</span><span style="color: #0000BB">preg_match</span><span style="color: #007700">(</span><span style="color: #DD0000">'/^(\d+)\.(\d+)(\.(\d+))?(-((unstable|alpha|beta|rc)\d+))?$/'</span><span style="color: #007700">, </span><span style="color: #0000BB">$tag_name</span><span style="color: #007700">, </span><span style="color: #0000BB">$matches</span><span style="color: #007700">)) {<br> </span><span style="color: #FF8000">// Starting with version 5, we only have 2 digits, major and patch.<br> </span><span style="color: #007700">if (</span><span style="color: #0000BB">$matches</span><span style="color: #007700">[</span><span style="color: #0000BB">1</span><span style="color: #007700">] >= </span><span style="color: #0000BB">5</span><span style="color: #007700">) {<br> </span><span style="color: #0000BB">$version</span><span style="color: #007700">-></span><span style="color: #0000BB">version_major </span><span style="color: #007700">= </span><span style="color: #0000BB">$matches</span><span style="color: #007700">[</span><span style="color: #0000BB">1</span><span style="color: #007700">];<br> </span><span style="color: #0000BB">$version</span><span style="color: #007700">-></span><span style="color: #0000BB">version_patch </span><span style="color: #007700">= </span><span style="color: #0000BB">$matches</span><span style="color: #007700">[</span><span style="color: #0000BB">2</span><span style="color: #007700">];<br> </span><span style="color: #0000BB">$api_term </span><span style="color: #007700">= </span><span style="color: #0000BB">$version</span><span style="color: #007700">-></span><span style="color: #0000BB">version_major </span><span style="color: #007700">. </span><span style="color: #DD0000">'.x'</span><span style="color: #007700">;<br> }<br> </span><span style="color: #FF8000">// Prior to 5, we had all 3: major, minor and patch.<br> </span><span style="color: #007700">else {<br> </span><span style="color: #0000BB">$version</span><span style="color: #007700">-></span><span style="color: #0000BB">version_major </span><span style="color: #007700">= </span><span style="color: #0000BB">$matches</span><span style="color: #007700">[</span><span style="color: #0000BB">1</span><span style="color: #007700">];<br> </span><span style="color: #0000BB">$version</span><span style="color: #007700">-></span><span style="color: #0000BB">version_minor </span><span style="color: #007700">= </span><span style="color: #0000BB">$matches</span><span style="color: #007700">[</span><span style="color: #0000BB">2</span><span style="color: #007700">];<br> </span><span style="color: #FF8000">// Match 4 contains the patch level without the leading '.'.<br> </span><span style="color: #0000BB">$version</span><span style="color: #007700">-></span><span style="color: #0000BB">version_patch </span><span style="color: #007700">= </span><span style="color: #0000BB">$matches</span><span style="color: #007700">[</span><span style="color: #0000BB">4</span><span style="color: #007700">];<br> </span><span style="color: #0000BB">$api_term </span><span style="color: #007700">= </span><span style="color: #0000BB">$version</span><span style="color: #007700">-></span><span style="color: #0000BB">version_major </span><span style="color: #007700">. </span><span style="color: #DD0000">'.' </span><span style="color: #007700">. </span><span style="color: #0000BB">$version</span><span style="color: #007700">-></span><span style="color: #0000BB">version_minor </span><span style="color: #007700">. </span><span style="color: #DD0000">'.x'</span><span style="color: #007700">;<br> }<br> </span><span style="color: #FF8000">// Match 6 contains the version extra without the leading '-'.<br> </span><span style="color: #007700">if (!empty(</span><span style="color: #0000BB">$matches</span><span style="color: #007700">[</span><span style="color: #0000BB">6</span><span style="color: #007700">])) {<br> </span><span style="color: #0000BB">$version</span><span style="color: #007700">-></span><span style="color: #0000BB">version_extra </span><span style="color: #007700">= </span><span style="color: #0000BB">$matches</span><span style="color: #007700">[</span><span style="color: #0000BB">6</span><span style="color: #007700">];<br> }<br> }<br> }<br></span><span style="color: #0000BB">?></span></span></pre></div>
<p>The change might be as simple as adding <code> && $matches[1] <= 7</code> to <code>$matches[1] >= 5</code>, and updating all the comments.</p>
issue