user_revision.module line 43 contains a call to setQueryable(), which triggers the following message:

BaseFieldDefinition::setQueryable() is deprecated in Drupal 8.4.0 and will be removed before Drupal 9.0.0. Instead, you should use \Drupal\Core\Field\BaseFieldDefinition::setCustomStorage() . See https://www.drupal.org/node/2856563.

CommentFileSizeAuthor
#2 set_queryable_is_now_deprecated-2973540-2.patch882 bytessergiu stici

Comments

Gogowitsch created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
StatusFileSize
new set_queryable_is_now_deprecated-2973540-2.patch882 bytes

We should be able to just remove it since we're already setting the field as computed.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
gogowitsch’s picture

gogowitsch commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +ContributionWeekend2020

I have tested the patch locally and it works wonderfully.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Reviewed & tested by the community » Fixed

Thanks for contributing this and linking the CR. According to the issue that method was a NOP anyway so green by me. Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.