6/6 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


================================================================================
User revision,  8.8.5
Scanned on Sat, 05/23/2020 - 17:16

FILE: web/modules/contrib/user_revision/src/Access/UserRevisionAccessCheck.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Fix now        37   Parameter $entity_manager of method
                    Drupal\user_revision\Access\UserRevisionAccessCheck::__const
                    ruct() has typehint with deprecated interface
                    Drupal\Core\Entity\EntityManagerInterface. Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/user_revision/src/Controller/UserController.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 57   Call to deprecated method entityManager() of class
                    Drupal\Core\Controller\ControllerBase. Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Most of the
                    time static::entityTypeManager() is supposed to be used
                    instead.
--------------------------------------------------------------------------------
Check manually 58   Call to deprecated method entityManager() of class
                    Drupal\Core\Controller\ControllerBase. Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Most of the
                    time static::entityTypeManager() is supposed to be used
                    instead.
--------------------------------------------------------------------------------
Fix now        84   Call to deprecated method link() of class
                    Drupal\Core\Entity\EntityInterface. Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\EntityInterface::toLink()->toString() instead.
--------------------------------------------------------------------------------
Fix now        87   Call to deprecated method l() of class
                    Drupal\Core\Controller\ControllerBase. Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Use
                    \Drupal\Core\Link::fromTextAndUrl() instead.
--------------------------------------------------------------------------------
Check manually 97   Call to deprecated function drupal_render(). Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Use the
--------------------------------------------------------------------------------
Check manually 172  Call to deprecated method entityManager() of class
                    Drupal\Core\Controller\ControllerBase. Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Most of the
                    time static::entityTypeManager() is supposed to be used
                    instead.
--------------------------------------------------------------------------------
Check manually 177  Call to deprecated method entityManager() of class
                    Drupal\Core\Controller\ControllerBase. Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Most of the
                    time static::entityTypeManager() is supposed to be used
                    instead.
--------------------------------------------------------------------------------
Check manually 191  Call to deprecated method entityManager() of class
                    Drupal\Core\Controller\ControllerBase. Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Most of the
                    time static::entityTypeManager() is supposed to be used
                    instead.
--------------------------------------------------------------------------------
Check manually 192  Call to deprecated function format_date(). Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Use
                    Drupal::service('date.formatter')->format().
--------------------------------------------------------------------------------

FILE: web/modules/contrib/user_revision/src/Form/UserRevisionDeleteForm.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Fix now        47   Call to deprecated method getStorage() of class
                    Drupal\Core\Entity\EntityManager. Deprecated in drupal:8.0.0
                    and is removed from drupal:9.0.0. Use
                    Drupal\Core\Entity\EntityTypeManagerInterface::getStorage()
                    instead.
--------------------------------------------------------------------------------
Check manually 62   Call to deprecated function format_date(). Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Use
                    Drupal::service('date.formatter')->format().
--------------------------------------------------------------------------------
Check manually 97   Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------
Check manually 97   Call to deprecated function format_date(). Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Use
                    Drupal::service('date.formatter')->format().
--------------------------------------------------------------------------------

FILE: web/modules/contrib/user_revision/src/Form/UserRevisionRevertForm.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Fix now        46   Call to deprecated method getStorage() of class
                    Drupal\Core\Entity\EntityManager. Deprecated in drupal:8.0.0
                    and is removed from drupal:9.0.0. Use
                    Drupal\Core\Entity\EntityTypeManagerInterface::getStorage()
                    instead.
--------------------------------------------------------------------------------
Check manually 61   Call to deprecated function format_date(). Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Use
                    Drupal::service('date.formatter')->format().
--------------------------------------------------------------------------------
Check manually 108  Call to deprecated function format_date(). Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Use
                    Drupal::service('date.formatter')->format().
--------------------------------------------------------------------------------
Check manually 112  Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------
Check manually 112  Call to deprecated function format_date(). Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Use
                    Drupal::service('date.formatter')->format().
--------------------------------------------------------------------------------

FILE: web/modules/contrib/user_revision/user_revision.install

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 21   Call to deprecated method entityManager() of class Drupal.
                    Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0.
                    Use Drupal::entityTypeManager() instead in most cases. If
                    the needed method is not on
                    \Drupal\Core\Entity\EntityTypeManagerInterface, see the
                    deprecated \Drupal\Core\Entity\EntityManager to find the
                    correct interface or service.
--------------------------------------------------------------------------------
Check manually 32   Call to deprecated method entityManager() of class Drupal.
                    Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0.
                    Use Drupal::entityTypeManager() instead in most cases. If
                    the needed method is not on
                    \Drupal\Core\Entity\EntityTypeManagerInterface, see the
                    deprecated \Drupal\Core\Entity\EntityManager to find the
                    correct interface or service.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/user_revision/user_revision.module

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 290  Call to deprecated method entityManager() of class Drupal.
                    Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0.
                    Use Drupal::entityTypeManager() instead in most cases. If
                    the needed method is not on
                    \Drupal\Core\Entity\EntityTypeManagerInterface, see the
                    deprecated \Drupal\Core\Entity\EntityManager to find the
                    correct interface or service.
--------------------------------------------------------------------------------
Check manually 291  Call to deprecated function db_query(). Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
                    a database connection injected into your service from the
                    container and call query() on it. For example,
--------------------------------------------------------------------------------
Check manually 304  Call to deprecated method entityManager() of class Drupal.
                    Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0.
                    Use Drupal::entityTypeManager() instead in most cases. If
                    the needed method is not on
                    \Drupal\Core\Entity\EntityTypeManagerInterface, see the
                    deprecated \Drupal\Core\Entity\EntityManager to find the
                    correct interface or service.
--------------------------------------------------------------------------------
Check manually 305  Call to deprecated function db_query(). Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
                    a database connection injected into your service from the
                    container and call query() on it. For example,
--------------------------------------------------------------------------------

FILE: web/modules/contrib/user_revision/user_revision.info.yml

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    Add <code>core_version_requirement: ^8 || ^9 to
                    user_revision.info.yml to designate that the module is
                    compatible with Drupal 9. See
                    https://drupal.org/node/3070687.
--------------------------------------------------------------------------------
CommentFileSizeAuthor
#8 3139411-8.patch26.28 KBdabley
#2 3139411-2.patch30.27 KBashutosh.mishra

Issue fork user_revision-3139411

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ashutosh.mishra created an issue. See original summary.

ashutosh.mishra’s picture

ashutosh.mishra commented
Status: Needs work » Needs review
StatusFileSize
new 3139411-2.patch30.27 KB
ashutosh.mishra’s picture

ashutosh.mishra commented
Assigned: ashutosh.mishra » Unassigned
vivek panicker’s picture

vivek panicker commented
Assigned: Unassigned » vivek panicker
Issue tags: +DIACWNov2020
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

@vivek:
Why not leverage #3142033: Automated Drupal 9 compatibility fixes? Note that i just committed that and this may well have the job done.

If anything is left, please create an issue fork and push to it. Thanks!

jasonluttrell made their first commit to this issue’s fork.

dabley’s picture

dabley commented

Patch #2 does not apply to the latest dev release. It clashes with changes made in issues #3142033: Automated Drupal 9 compatibility fixes and #3194850: Fix user revision pages. (Note that #3142033: Automated Drupal 9 compatibility fixes does not fix all D9 compatibility issues - it doesnt even add the core_version_requirement into the info.yml file.)

Can someone generate a new patch for this issue?

dabley’s picture

dabley commented
StatusFileSize
new 3139411-8.patch26.28 KB

I've produced a new patch. I fixed a couple of bugs in patch #2, and rebuilt it so that it will apply to the current dev branch.

dabley’s picture

dabley commented

I have added patch #8 into the issue fork, so that anyone using composer for their site can now reference this to achieve D9 compatibility (that's not possible using a patch file). This package doesnt have its own composer.json file, so you'll need to add something like this to your composer.json file to identify the package:

    "repositories": {
        "drupal": {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": [
                "drupal/user_revision"
            ]
        },
        "drupal/user_revision": {
            "type": "package",
            "package": {
                "name": "drupal/user_revision",
                "version": "dev-3139411-drupal-9-compatibility",
                "source": {
                    "type": "git",
                    "url": "git@git.drupal.org:issue/user_revision-3139411.git",
                    "reference": "3139411-drupal-9-compatibility"
                }
            }
        }
    },
    "require": {
        ...
        "drupal/user_revision": "dev-3139411-drupal-9-compatibility",
        ...
   },

More details

Ibn al-Hazardous’s picture

Ibn al-Hazardous commented

Thanks! This was very helpful. I have one minor update, in the composer.json snippet in comment #9, there's a line missing:

"drupal/user_revision": {
            "type": "package",
            "package": {
                "name": "drupal/user_revision",
                "type": "drupal-module",
                "version": "dev-3139411-drupal-9-compatibility",
                "source": {
                    "type": "git",
                    "url": "git@git.drupal.org:issue/user_revision-3139411.git",
                    "reference": "3139411-drupal-9-compatibility"
                }
            }
        }

If you add "type": "drupal-module" as above, the module will install in the correct path.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Needs review » Closed (duplicate)
Related issues: +#3142033: Automated Drupal 9 compatibility fixes
dabley’s picture

dabley commented
Status: Closed (duplicate) » Needs review

Yes, this issue is a duplicate of https://www.drupal.org/project/user_revision/issues/3142033 - however, that issue does not actually provide a fix to the problem, whereas this one does. So, perhaps 3142033 should have been marked as a duplicate of this one?

mlncn’s picture

mlncn commented
Assigned: vivek panicker » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good and thank you Ibn al-Hazardous for that catch.

  • mlncn committed 2502929 on 8.x-1.x 
    Issue #3139411 by dabley, ashutosh.mishra, JasonLuttrell, Ibn al-...
mlncn’s picture

mlncn commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.