API page: http://api.drupal.org/api/drupal/includes%21database%21database.inc/func...

Enter a descriptive title (above) relating to db_rename_table, then describe the problem you have found:

> $table: The table to be renamed.

Given Drupal's love of monster arrays, this parameter could be construed as being a schema API array. It would be clearer to say 'the current name of the table to rename'.

CommentFileSizeAuthor
#7 make-param-in-db_rename_table-clearer-1703184-1.patch796 bytessalah1
#3 make-param-in-db_rename_table-clearer-1703184-1.patch775 bytessalah1

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Sounds like a good suggestion. Good Novice patch project... ah, you already tagged it. Thanks!

salah1’s picture

salah1
Location VA, U.S
commented
Assigned: Unassigned » salah1
salah1’s picture

salah1
Location VA, U.S
commented
Status: Active » Needs review
StatusFileSize
new make-param-in-db_rename_table-clearer-1703184-1.patch775 bytes
joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Perfect! Thanks!

salah1’s picture

salah1
Location VA, U.S
commented

Working on the backport to D7

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Usually it's best to wait until the 8.x patch is actually committed before working on a 7.x patch. Sometimes, the committer finds something wrong and sets the issue back to "needs work", and sometimes the same patch can be applied to 7.x (by ignoring path segments), so there's no need to make a new patch at all.

Anyway, I just committed the above patch to 8.x, thanks! I

think David is working on a 7.x release this morning, so I don't want to commit anything to 7.x at the moment... And in this case the function is in a completely different file for D7 so it does need to be ported.

salah1’s picture

salah1
Location VA, U.S
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new make-param-in-db_rename_table-clearer-1703184-1.patch796 bytes

Here is the D7 Patch. Thanks

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks! I'll get this committed.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x. Thanks again!

Automatically closed -- issue fixed for 2 weeks with no activity.