Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Minor
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
19 Aug 2012 at 10:38 UTC
Updated:
4 Jan 2014 at 02:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
funex commentedAdded documentation to language_is_locked() and checked other language functions documentation.
Comment #2
FelixH commentedIm gonna review the patch.
Comment #3
FelixH commentedTested if Patch does only modify commented parts.
Patch reviewed. Patch works and may be applied. Improving Docs may also be continued.
Comment #4
catchIf it returns bool, shouldn't it return TRUE if more than one language instead of 1?
Comment #5
albert volkman commentedChanged per @catch's suggestion. Also added missing space before @return.
Comment #6
gábor hojtsyShould this be a sentence instead? ie. "is enabled" is missing at the end.
Are we using lowercase FALSE when documenting return types? We use it uppercase in all other cases?!
Comment #7
albert volkman commentedFixed those issues, and found a comment that was > 80 chars.
Comment #8
gábor hojtsyLooks good to me, let's place it with the docs component, so Jennifer will see it directly. Thanks all!
Comment #9
jhodgdonCommitted to 8.x. I'm undecided on backporting to 7.x... for the most part we don't have return/param types in 7.x at all, and some of the types here would not be right for 7.x anyway... but some of this patch could be useful maybe?
Comment #10
albert volkman commentedYeah, a couple of hunks are still applicable.
Comment #11
albert volkman commentedComment #12
jhodgdonThanks -- that patch is committed to 7.x.