Part of meta #500866: [META] remove t() from assert message.

CommentFileSizeAuthor
#6 poll-1797376-6.patch21.65 KBdcam
#3 poll-1797376-3.patch24.5 KBxjm
#3 interdiff.txt1011 bytesxjm
#1 poll-1797376-1.patch24.5 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: xjm » Unassigned
Status: Active » Needs review
StatusFileSize
new poll-1797376-1.patch24.5 KB

Aside: This poor little feature module is still in core? :)

Status: Needs review » Needs work

The last submitted patch, poll-1797376-1.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1011 bytes
new poll-1797376-3.patch24.5 KB
lazysoundsystem’s picture

lazysoundsystem commented
Status: Needs review » Reviewed & tested by the community

I've reviewed all the changes and they all look good. RTBC.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

This one's in 8.x now, thanks!

dcam’s picture

dcam commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new poll-1797376-6.patch21.65 KB

Backported #3 to D7.

lazysoundsystem’s picture

lazysoundsystem commented
Status: Needs review » Reviewed & tested by the community

I've checked all these changes and they're all good. RTBC.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: Unassigned » jhodgdon

Thanks! I can probably take care of final review and commit for this this tomorrow, unless someone else beats me to it.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks! Committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.