Minor documentation correction required.

Seems to be fixed now.

Sorry I read the issue description wrong.

attached is the solution on d8

#5 looks good to me. Patch applys well and changes are made like in issue summary.

Good catch! It needs to say $options['type'] though, not $options[type].

hope thats ok now

Good catch! It needs to say $options['type'] though, not $options[type].

Actually if the options parameter is a string, then it will be interpreted as the type:

$options: (optional) A string defining the type of JavaScript that is being added in the $data parameter ('file'/'setting'/'inline'/'external'), or an associative array.

So saying $options['type'] isn't always right.

We could say something like

(optional) If given, the value depends on the $options parameter, or $options['type'] if $options is passed as an associative array.

Ok you are right and your sentence is more precise.

#12: minor_documentation_correction-1821024-12.patch queued for re-testing.

Looks good, thanks! I'll get this committed sometime soon.

Sorry for the delay in committing this -- there's a big Views sprint going on and commits are delaying their patch reviews, so postponing a few days.

Thanks again! Committed to 8.x and 7.x.