Selecting 'Disabled' does not move the block to the disabled region when there are no disabled blocks

This still occurs in Drupal 8 as well as Drupal 7, so it should be fixed in Drupal 8 first and then backported to 7.

Attached patch ports #1 to Drupal 8.

@idebr I can't seem to replicate this issue in Drupal 8? I had no blocks disabled and then using the region select list I managed to disable it correctly.

@tisteegz Thanks for having a look! Indeed, disabling a block still works. The problem is limited to the display in the UI: when selecting a different region, a block is moved to the bottom of the target region. However, when the target region is 'Disabled' and there are no other disabled blocks this fails. I have updated the issue summary with two screencaps to clarify the problem.

Needs re-roll.

Rerolled patch with code from idebr.

I was able to reproduce the UI issue. After applying the patch in #9, selecting -none- (when no other blocks are already present in "Disabled") for a block results in the block being moved to the appropriate "Disabled" section in the UI. The patch looks like it works.

This looks and works great in Chrome 47, FF 42, Safari 9.0.3, IE 9, IE 10. This patch just fixes up formatting.

I've manually tested the patch and it works. I've also run the code against our eslint rules and it passes.

+++ b/core/modules/block/js/block.js
@@ -125,14 +125,22 @@
           table.find('.region-' + select[0].value + '-message').nextUntil('.region-message').eq(-1).before(row);

However, I think this line is now obsolete because of the code added by this patch. The row is placed (in the correct position) by the new code.

Removed line suggested by alexpott.

+++ b/core/modules/block/js/block.js
@@ -125,14 +125,19 @@
-          // Find the correct region and insert the row as the last in the
-          // region.

please don't remove useful comment

Returned comment

After applying above patch if we move a block to empty region using dropdown, it is working fine.

Step 1

Step 2

Committed d841acb and pushed to 8.0.x, 8.1.x, 8.2.x. Thanks! Added myself and @samiullah to the credit for reviewing - me for the code review and @samiullah for adding screenshots.

Unfortunately no one who has worked on this issue will get any credit until the patch is ported and committed to Drupal 7 because of the current backport policy.

Here is a patch for D7.

Unfortunately, this last patch doesn't work for me (ver 7.x.) I still can't move blocks from the block list (I can however, from inside the block) and I cannot move a block in Dashboard (same thing, I need to configure the block and select the region there. That works.)

I have tested the D7 patch #27 and it is working correctly (you need to clear the cache after applying the patch). Now it is possible to move block to the "disabled" region when there are no blocks.

I think the issue got fixed now, because i have tested the issue in D7 and applied above patch. The patch was successfully applied and issue got solved. Adding Screen record for the reference . Need RTBC +1

Moving carefully to RTBC (because we do not have JS tests in D7) and adding tag for the second review.

I have tested the D7 patch #27 and it is working fine. So I am moving it RTBC+1.

Tested this manually and confirmed the fix (once caches are cleared).

I don't think it's worth adding an empty update hook to force a cache clear for this change.

Thank you everyone that contributed!