Sample output:
Running d6_filter_format [ok]
Running d6_user_role [ok]
Running d6_user_picture_field [ok]
Running d6_user_picture_field_instance [ok]
Running d6_user_picture_entity_display [ok]
Running d6_user_picture_entity_form_display [ok]
Running d6_user_picture_file [ok]
Running d6_user [ok]
Running d6_user_profile_field [ok]
Attempt to create a field of unknown type link. [error]
(/var/www/drupal/core/modules/field/src/Entity/FieldConfig.php:287)
Running d6_user_profile_field_instance [ok]
Attempt to create an instance of field profile_website that does not exist on entity type user. [error]
(/var/www/drupal/core/modules/field/src/Entity/FieldInstanceConfig.php:472)
Running d6_user_profile_entity_display [ok]
Running d6_user_profile_entity_form_display [ok]
Running d6_profile_values:user [ok]
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2302259-5.patch | 2.37 KB | quietone |
Comments
Comment #1
Anonymous (not verified) commentedComment #2
ultimikeThis will likely be resolved once #2235457: Use link field for shortcut entity is committed.
-mike
Comment #3
benjy commentedPostponing on the issue mentioned in #2
Comment #4
hussainwebThe issue mentioned in #2 is resolved. Is the issue fixed now?
Comment #5
quietone commentedWent to verify that this is fixed and discovered that the link field and checkbox field in the user profile were not tested in the user profile migration test, MigrateUserProfileValuesTest.php. So, added the assertions and they failed, the link field was not migrated. Hmm. Turns out there is an error in the drupal 6 test fixture. The profile id for the link field was different in the user tables. It was 16 in profile_fields but 13 in profile_values. Correct that and the tests pass.
In summary, the migration of the link field has been working, it was an error in the test fixture. The patch fixes drupal6.php and MigrateUserProfileValuesTest now has assertions for all profile fields.
Comment #6
benjy commentedGreat, RTBC if it's green.
Comment #7
catchCommitted/pushed to 8.1.x, thanks!
Comment #8
quietone commentedWhy is this on 8.1.x? This is just a bug fix and migrate is experimental. I asked about this on IRC and pwolanin suggested I reopen the issue.
Comment #9
catchI failed to push to 8.1.x so back to RTBC. Will re-commit once the 8.1.0-beta is out.
8.0.x is unlikely to get anything but fixes for major/critical bugs between now and April 6th when it will be EOL. On April 20th, 8.1.0 will be available, and will have this fix and any others that don't get backported in it. We're going to have the 8.2.x branch to deal with as well, and actively managing three branches at once would mean less time overall to review and commit issues, that in turn means rather than committing things to 8.1.x and 8.0.x, it's more likely they'd sit in the RTBC queue unattended and not make it into either version for either date.
Comment #10
catchComment #11
quietone commentedComment #15
catchCommitted/pushed to 8.2.x and cherry-picked to 8.1.x and 8.0.x. Thanks!