This is a development tool which integrates the Emmet plugin for textareas with a Drupal development site. This module allows developers to use the Emmet Toolkit that they may already be using in your development software within a textarea element in a web browser.

Permissions can be used to control access to Emmet functionality.

There is an example make file in the module for downloading the Emmet Textarea js files. https://github.com/emmetio/textarea/archive/master.zip

https://www.drupal.org/sandbox/tschet/2563319
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Tschet/2563319.git emmet

CommentFileSizeAuthor
#10 Error.png19.81 KBvisabhishek

Comments

Tschet created an issue. See original summary.

Tschet’s picture

Tschet commented
Title: Emmet [D7] » [D7] Emmet
PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxTschet2563319git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

shelane’s picture

shelane
Primary language English
commented

Automated Review
There are some style errors that need to be addressed.
http://pareview.sh/pareview/httpgitdrupalorgsandboxTschet2563319git

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template.
Please refer to https://www.drupal.org/node/2181737
Code long/complex enough for review
No:
* The project has less than five function or class method definitions
* The PHP/Javscript source code is less than 120 lines long (including comments and whitespace).
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage

The starred items (*) are fairly issues that may prevent full project status, but this may warrent a single project promotion.

Tschet’s picture

Tschet commented
Status: Needs work » Needs review

Sorry about the formatting errors. They should all be fixed now.
I thought I was testing against the Drupal standards, but I wasn't.
I'll work on the prioritized review, but no promises on how fast I'll get it. This may make it through the slow way before I get there.

Thanks a lot for your time.

melvix’s picture

melvix commented
Status: Needs review » Needs work

You should address the issues that @shelane noted in comment #4:

README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
No: Does not follow the guidelines for project length and complexity.
Tschet’s picture

Tschet commented

First I'd like to say thank you very much for the reviews. I found them very helpful.

  1. I have updated the readme.md file as requested.
  2. Changed the functionality to allow for more reliable usage across themes and with Overlay turned on.
  3. Added a configuration page to allow for the setting of an output format. (This was previously hardcoded.)
  4. Added a simple Help page with a link to the Emmet project.
  5. Added install and runtime validation to let users know if the Emmet library is installed. It now blocks installation if the Emmet library isn't present, and shows an error message on Status report page if it is missing after installation. The library version number is shown on Status report page if the library is installed.
Tschet’s picture

Tschet commented
Status: Needs work » Needs review
Tschet’s picture

Tschet commented

Will this ever be addressed, or is the answer that the module is too simple to be considered? I was under the impression that if the module wasn't complex enough the module could be approved, but the user wouldn't be.

visabhishek’s picture

visabhishek commented
Status: Needs review » Needs work
StatusFileSize
new Error.png19.81 KB

Automated Review

Please fix Error reported By PAReview.sh:
http://pareview.sh/pareview/httpgitdrupalorgsandboxtschet2563319git

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
No: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
  1. (*) I am getting error while i am trying to enable this module. I am attaching the screenshot.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Tschet’s picture

Tschet commented
Issue summary: View changes
Tschet’s picture

Tschet commented

I thought I had posted a comment after your reply. Sorry for the delay. Thank you very much for your comments.

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.