[D7] ALXS Matrix

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxalxs2625182git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Individual user account
Yes: Follows guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity
Secure code
Yes: Meets the security requirements
Coding style & Drupal API usage
Yes: It follows code and API guidelines.

But I suggest you to change the file encoding to UTF-8, which is not prone to cause corrupted coding and displaying of non-latin characters.

Hi,

Remove all variable alxs_matrix_xxx when module has uninstall.
Refer:
https://api.drupal.org/api/drupal/modules!system!system.api.php/function...

Please don't RTBC your own issues, see the workflow: https://www.drupal.org/node/532400

Hi djalxs,

Firstly fix the https://pareview.sh/node/798 for your module

Regards
Satyam

Hi

1: Found XSS Issue : If I enter <script>alert('XSS');</script> , its getting executed(see the attached screenshot). You need to sanitize data before printing. For more information about sanitizing, please read https://www.drupal.org/node/28984.

2: Please remove all used variable under hook_unistall().

Example:

variable_get('alxs_matrix_background_color', 'FFFFFF'),
variable_get('alxs_matrix_text_color', '008CBA'),
variable_get('alxs_matrix_shadow_color', '000000'),
variable_get('alxs_matrix_code_color', '008CBA'),
variable_get('alxs_matrix_min_velocity', 1),
variable_get('alxs_matrix_max_velocity', 5),
variable_get('alxs_matrix_min_length', 3),
variable_get('alxs_matrix_max_length', 16),
variable_get('alxs_matrix_column_width', 16),
variable_get('alxs_matrix_column_height', 25),
variable_get('alxs_matrix_secret_code', 'Codebusta')
variable_get('alxs_matrix_show_content', 'true'),
variable_get('alxs_matrix_text_content', 'Enter some text here...'),

Please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2625384

Project 2: https://www.drupal.org/node/2856112

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.