Problem/Motivation

If you use more than one form element with autocomplete on the page and want to use html elements like strong, then you can't because the "_renderItem" option applies only for first form element on the page. For the second and next items jquery ui use built in function to render them.

Proposed resolution

Apply this option to each element on page.

CommentFileSizeAuthor
#9 Autocomplete.gif63.87 KBdroplet
#5 testing-for-committer--do-not-test.patch1.34 KBdroplet
jquery-autocomplete-applies-renderItem-option-only-for-first-element.patch611 byteszviryatko

Comments

zviryatko created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +JavaScript
droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs manual testing

Looks sensible but until we have automated js testing it'd be good to ensure this is manually tested before it goes in.

droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new testing-for-committer--do-not-test.patch1.34 KB

:)

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

#5 doesn't work for me.

The first autocomplete field on the page the matches are highlighted in red.

In the second, the match has the escaped, suggesting these are still not behaving consistently.

droplet’s picture

droplet commented
Status: Needs work » Needs review

have you remove caches ? I re-test again, no problems.

catch’s picture

catch
he/him
Primary language English
commented

Yes cleared all caches. If you can re-test and post a screenshot that'd help.

droplet’s picture

droplet commented
Issue summary: View changes
StatusFileSize
new Autocomplete.gif63.87 KB

Well, make you a GIF. If you're Chrome users, you should try Private mode or close it completely. As I known Chrome sometimes failed on clean caches.

droplet’s picture

droplet commented

@catch,

maybe you can provide a screenshot to help us understand your problem ?

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

No that's OK, I'll assume it's an issue on my end.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: testing-for-committer--do-not-test.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Reviewed & tested by the community

back rtbc

  • catch committed ec2819c on 8.2.x 
    Issue #2665738 by droplet, zviryatko: jQuery Autocomplete applies "...

  • catch committed 4d6abe7 on 8.1.x 
    Issue #2665738 by droplet, zviryatko: jQuery Autocomplete applies "...

  • catch committed fd1649e on 8.0.x 
    Issue #2665738 by droplet, zviryatko: jQuery Autocomplete applies "...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.