Audit use of YAML to ensure we're not using deprecated syntax

I tried to scan core (only yaml files inside core/) today and I could not find any YAML deprecations from http://symfony.com/blog/new-in-symfony-2-8-yaml-deprecations

@Luukyb

Me too :)

At least the case

app.user_manager:
    # ...
    arguments: ['@router', '@logger', '@doctrine.orm.entity_manager']

should be triggered by @neclimdul's YML testing.

core/modules/system/tests/modules/theme_test/theme_test.services.yml

services:
  theme_test.subscriber:
    class: Drupal\theme_test\EventSubscriber\ThemeTestSubscriber
    arguments: [@current_route_match, @renderer]

You must have noticed this one. Do the arguments in this file purposely not have quotes?

@lokapujya You are right! Feel free to upload a patch.

Arguments with certain leading special characters need quotes. Even though this is in a test.

Looks good to me.

I just did a grep and this seemed to be the only place in core with that combination

I can confirm that there are no other instances of arguments beginning with special characters in YML files. The patch is good on my end.

I have test again using my phpStorm editor. There is no deprecated syntax like this issue in core. The patch also worked perfectly for me.

Committed 8023d8c and pushed to 8.0.x, 8.1.x and 8.2.x. Thanks!

You guys may be interested in the issue that triggered that change in Symfony and has tests that catch these sorts of invalid YAML in testbot. #1920902: Add a Drupal Yaml wrapper so we can default to PECL Yaml component if it is available

How did this issue cause a conflict? and why if it's catching invalid YAML, why wasn't that issue failing?

NEVERMIND: I see that the previous patch has a similar fix for this same issue.

Yeah, exactly that. It was triggering errors which is why it had the same fix which conflicted. Sorry if it wasn't clear.