Closed (fixed)
Project:
Drupal core
Version:
8.2.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Mar 2016 at 15:57 UTC
Updated:
24 Mar 2016 at 18:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
traviscarden commentedComment #3
jhodgdonThanks!
Um...
So it looks like the @return line already has both Config and ImmutableConfig in it. The new @return line in the patch has added Config in there twice?
I like the added docs, because they clarify when each one will be returned, but the changes to @return line itself seem to be wrong.
Also... Do you think we could fix up this paragraph that is further up in the docs header?
I cannot understand what it means. Actually, it seems like the docs you have added to @return kind of restate this. So maybe just take this out?
Comment #4
traviscarden commentedI agree. That other paragraph is confusing and redundant. Updated patch attached.
Comment #5
jhodgdonLooks good, thanks!
This should be OK for 8.0, 8.1, and 8.2. I'll set this to 8.2 with backport tags, and set off a test against 8.2.
Comment #9
alexpottCommitted ea35e64 and pushed to 8.0.x, 8.1.x, and 8.2.x. Thanks!
Comment #11
alexpott